14 years agodefaulting selection_ou to the pickup lib instead of home_ou of the recipient
erickson [Fri, 15 Feb 2008 02:41:35 +0000 (02:41 +0000)]
defaulting selection_ou to the pickup lib instead of home_ou of the recipient

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8755 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoin-DB circ matrix models (a couple more to go)
miker [Thu, 14 Feb 2008 21:39:19 +0000 (21:39 +0000)]
in-DB circ matrix models (a couple more to go)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8752 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotweaked wording for Items Out interface to better match reality
phasefx [Thu, 14 Feb 2008 04:25:58 +0000 (04:25 +0000)]
tweaked wording for Items Out interface to better match reality

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8749 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUpdate copyright statement in catalogue footer
dbs [Wed, 13 Feb 2008 16:32:35 +0000 (16:32 +0000)]
Update copyright statement in catalogue footer

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8741 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoremoving dead code.. Hold Capture interface is a variant of Check In interface
phasefx [Wed, 13 Feb 2008 04:00:28 +0000 (04:00 +0000)]
removing dead code.. Hold Capture interface is a variant of Check In interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8740 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoarg! typo
miker [Tue, 12 Feb 2008 16:13:11 +0000 (16:13 +0000)]
arg! typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8731 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoi18n for the server/main and server/OpenILS directories
dbs [Tue, 12 Feb 2008 02:41:11 +0000 (02:41 +0000)]
i18n for the server/main and server/OpenILS directories

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8726 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoComplete server/circ/util.js i18n (oh my aching fingers)
dbs [Mon, 11 Feb 2008 21:44:51 +0000 (21:44 +0000)]
Complete server/circ/util.js i18n (oh my aching fingers)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8725 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadde Parse::RecDescent stubbing for future use
miker [Mon, 11 Feb 2008 20:47:11 +0000 (20:47 +0000)]
adde Parse::RecDescent stubbing for future use

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8723 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoaugmented parse_and_raise to act as a pass-thru when the provided object is not an...
erickson [Mon, 11 Feb 2008 20:37:58 +0000 (20:37 +0000)]
augmented parse_and_raise to act as a pass-thru when the provided object is not an event

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8721 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorolling back one change to oilsEventFree, which was causing a double-free. as noted...
erickson [Mon, 11 Feb 2008 18:47:54 +0000 (18:47 +0000)]
rolling back one change to oilsEventFree, which was causing a double-free.  as noted in a new comment, if event->json is generated, it will contain a pointer to event->payload, which will cause event->payload to be automatically freed at ->payload free time

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8713 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agonew lib IP ranges
erickson [Mon, 11 Feb 2008 15:44:34 +0000 (15:44 +0000)]
new lib IP ranges

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8711 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott McKellar which plugs a couple of memory leaks, and
miker [Mon, 11 Feb 2008 12:52:04 +0000 (12:52 +0000)]
Patch from Scott McKellar which plugs a couple of memory leaks, and
applies some minor optimizations, as much for clarity as for

1. In buildSELECT() we were leaking defaultselhash in the case of an
early return.

2. In doFieldmapperSearch() we were leaking flesh_blob in the case
of an early return.

3. In doFieldmapperSearch() I rearranged the logic a bit.  First,
I performed a single search of meta to get a method type and saved
the result for reuse, instead of performing the identical search
repeatedly.  Second, I turned a series of ifs into a series of
if/elses.  That way we stop searching when we find a match.  More
importantly, the if/else structure makes it more clear to the reader
that we're really just branching on method type in a case structure.

This latter change requires that none of the branches changes the
contents of ctx->method->userData.  So far as I can tell by tracing
out all the branches, this condition is satisfied, as one would
intuitively expect.

4. Also in doFieldmapperSearch(): I increased the size of the
growing_buffer sel_list from 16 characters to 64.  Since the
formatted string is at least 13 characters long, depending on the
length of the class name and primary key, I suspect that 16
characters will almost never be big enough.  Even 64 characters
might be too short.  I don't know how long the values typically
are in practice.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8708 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoStart tackling circ/util.js i18n
dbs [Mon, 11 Feb 2008 05:04:23 +0000 (05:04 +0000)]
Start tackling circ/util.js i18n

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8707 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomoving to direct call syntax instead of indirection based, since it is unsafe
miker [Fri, 8 Feb 2008 21:01:19 +0000 (21:01 +0000)]
moving to direct call syntax instead of indirection based, since it is unsafe

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8705 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodirect function calls to prevent any issues with $self. removed some unused code
erickson [Fri, 8 Feb 2008 20:57:29 +0000 (20:57 +0000)]
direct function calls to prevent any issues with $self.  removed some unused code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8704 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodirect function calls to prevent any issues with $self
erickson [Fri, 8 Feb 2008 20:51:54 +0000 (20:51 +0000)]
direct function calls to prevent any issues with $self

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8703 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocalling copy_details directly to prevent any issues with the $self variable
erickson [Fri, 8 Feb 2008 20:46:18 +0000 (20:46 +0000)]
calling copy_details directly to prevent any issues with the $self variable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8702 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix one little typo
dbs [Fri, 8 Feb 2008 19:56:33 +0000 (19:56 +0000)]
Fix one little typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8701 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomoving variable decl. until after config is loaded
erickson [Fri, 8 Feb 2008 17:35:04 +0000 (17:35 +0000)]
moving variable decl. until after config is loaded

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8700 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadding subfield setting for idfield
miker [Fri, 8 Feb 2008 15:38:30 +0000 (15:38 +0000)]
adding subfield setting for idfield

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8699 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMostly finish off server/circ i18n work
dbs [Thu, 7 Feb 2008 22:39:23 +0000 (22:39 +0000)]
Mostly finish off server/circ i18n work

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8696 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTypo: lenth -> length
dbs [Thu, 7 Feb 2008 21:41:17 +0000 (21:41 +0000)]
Typo: lenth -> length

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8693 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoalso bringing the permacrud.xsd from acq (thanks for the reminder, Dan!)
miker [Thu, 7 Feb 2008 19:49:48 +0000 (19:49 +0000)]
also bringing the permacrud.xsd from acq (thanks for the reminder, Dan!)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8691 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadding index for object perms, and re-tabbing a bit
miker [Thu, 7 Feb 2008 19:48:17 +0000 (19:48 +0000)]
adding index for object perms, and re-tabbing a bit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8690 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocross-port the per-object perm scheme from the acq branch
miker [Thu, 7 Feb 2008 19:36:16 +0000 (19:36 +0000)]
cross-port the per-object perm scheme from the acq branch

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8689 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnsure ils_events.py is executable
dbs [Thu, 7 Feb 2008 04:39:38 +0000 (04:39 +0000)]
Ensure ils_events.py is executable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8680 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBring copy_status to the world of i18n
dbs [Thu, 7 Feb 2008 04:24:31 +0000 (04:24 +0000)]
Bring copy_status to the world of i18n

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8679 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofixing readonly IDL logic
miker [Thu, 7 Feb 2008 01:26:36 +0000 (01:26 +0000)]
fixing readonly IDL logic

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8677 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded explicit "return undef"
erickson [Wed, 6 Feb 2008 20:23:22 +0000 (20:23 +0000)]
added explicit "return undef"

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8674 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agologic bug in new perm checker. removed some dead code
erickson [Wed, 6 Feb 2008 18:03:15 +0000 (18:03 +0000)]
logic bug in new perm checker.  removed some dead code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8669 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded vars to store permission error info
erickson [Wed, 6 Feb 2008 17:53:33 +0000 (17:53 +0000)]
added vars to store permission error info

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8667 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agousing shared build_org_tree in apputils
erickson [Wed, 6 Feb 2008 17:33:51 +0000 (17:33 +0000)]
using shared build_org_tree in apputils

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8666 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agonow using the find_highest_perm_org and get_org_tree methods provided in apputils
erickson [Wed, 6 Feb 2008 17:14:41 +0000 (17:14 +0000)]
now using the find_highest_perm_org and get_org_tree methods provided in apputils

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8665 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofixed variable declaration
erickson [Wed, 6 Feb 2008 16:39:23 +0000 (16:39 +0000)]
fixed variable declaration

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8663 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agogave cstore editor the ability to check an array of permissions
erickson [Wed, 6 Feb 2008 16:29:55 +0000 (16:29 +0000)]
gave cstore editor the ability to check an array of permissions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8661 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agouse serial instead of plain INT for pkey on circ_mod_test table
miker [Wed, 6 Feb 2008 06:24:56 +0000 (06:24 +0000)]
use serial instead of plain INT for pkey on circ_mod_test table

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8656 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agooverriding save to force None-ness on the interval fields
erickson [Wed, 6 Feb 2008 04:18:00 +0000 (04:18 +0000)]
overriding save to force None-ness on the interval fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8655 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded example verbose name
erickson [Wed, 6 Feb 2008 04:00:23 +0000 (04:00 +0000)]
added example verbose name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8654 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agogetting closer on the circmatrixmatchpoint editing
erickson [Wed, 6 Feb 2008 03:57:01 +0000 (03:57 +0000)]
getting closer on the circmatrixmatchpoint editing
- using edit_inline on foreign keys to allow for up-front editing of
objects which link to circmatrixmatchpoint
- updated some of the __str__ methods to use gettext's unique brand of string interpolation
- added some blank=False flags for non-required fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8653 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoi18n improvements as I go through updating status
dbs [Wed, 6 Feb 2008 03:44:09 +0000 (03:44 +0000)]
i18n improvements as I go through updating status

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8652 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoupdating the exporter config to add the proxy for staff
miker [Tue, 5 Feb 2008 19:35:57 +0000 (19:35 +0000)]
updating the exporter config to add the proxy for staff

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8645 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoregression in dos.print kludge.. need to quote path for windows, and assure text...
phasefx [Tue, 5 Feb 2008 19:28:43 +0000 (19:28 +0000)]
regression in dos.print kludge.. need to quote path for windows, and assure text is being passed and not objects

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8643 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorepaired descendant logic for initial high perm org
erickson [Tue, 5 Feb 2008 15:52:44 +0000 (15:52 +0000)]
repaired descendant logic for initial high perm org

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8636 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded a descendants option to the high work org retrieval function
erickson [Tue, 5 Feb 2008 15:25:11 +0000 (15:25 +0000)]
added a descendants option to the high work org retrieval function

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8634 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofixed some typos
erickson [Tue, 5 Feb 2008 15:15:57 +0000 (15:15 +0000)]
fixed some typos

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8632 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofixed calls to new_editor, which will not work in apputils (circular ref)
erickson [Tue, 5 Feb 2008 15:05:34 +0000 (15:05 +0000)]
fixed calls to new_editor, which will not work in apputils (circular ref)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8630 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded org descendant/ancestor/full_path utility methods
erickson [Tue, 5 Feb 2008 14:59:55 +0000 (14:59 +0000)]
added org descendant/ancestor/full_path utility methods

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8628 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoupdating models with (what should be) working display code
miker [Tue, 5 Feb 2008 13:21:10 +0000 (13:21 +0000)]
updating models with (what should be) working display code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8627 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMore i18n for chrome
dbs [Tue, 5 Feb 2008 04:30:59 +0000 (04:30 +0000)]
More i18n for chrome

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8626 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCorrect common.error vs. common.exception mistake, plus a bit more i18n
dbs [Tue, 5 Feb 2008 03:44:01 +0000 (03:44 +0000)]
Correct common.error vs. common.exception mistake, plus a bit more i18n

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8625 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBring i18n to main.js
dbs [Tue, 5 Feb 2008 03:22:51 +0000 (03:22 +0000)]
Bring i18n to main.js

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8624 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomoved some of the work org and perm calls into apputils since they will be needed...
erickson [Mon, 4 Feb 2008 23:40:23 +0000 (23:40 +0000)]
moved some of the work org and perm calls into apputils since they will be needed accross applications and they will be hit a lot

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8619 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBring more i18n love to chrome/main
dbs [Mon, 4 Feb 2008 22:33:11 +0000 (22:33 +0000)]
Bring more i18n love to chrome/main

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8618 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded a .ids version of the work ou retrieval function. short circuiting the highest...
erickson [Mon, 4 Feb 2008 22:14:58 +0000 (22:14 +0000)]
added a .ids version of the work ou retrieval function. short circuiting the highest-work-org method if we hit an org with depth 0

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8616 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix typo (getStrint->getString)
dbs [Mon, 4 Feb 2008 22:08:53 +0000 (22:08 +0000)]
Fix typo (getStrint->getString)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8615 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoclear "Red Items are circulating" hint on refresh in Patron Bills interface
phasefx [Mon, 4 Feb 2008 22:01:39 +0000 (22:01 +0000)]
clear "Red Items are circulating" hint on refresh in Patron Bills interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8614 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorepaired some copy/paste errors
erickson [Mon, 4 Feb 2008 21:52:33 +0000 (21:52 +0000)]
repaired some copy/paste errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8611 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadding baseline circ matrix models
miker [Mon, 4 Feb 2008 21:22:27 +0000 (21:22 +0000)]
adding baseline circ matrix models

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8610 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBring i18n to JSAN error messages
dbs [Mon, 4 Feb 2008 18:17:10 +0000 (18:17 +0000)]
Bring i18n to JSAN error messages

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8609 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded a min-depth function for a group of orgs, changed some variable names to be...
erickson [Mon, 4 Feb 2008 16:45:51 +0000 (16:45 +0000)]
added a min-depth function for a group of orgs, changed some variable names to be more explicit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8606 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoforcing int-ness on flat org keys for consistency
erickson [Mon, 4 Feb 2008 16:35:03 +0000 (16:35 +0000)]
forcing int-ness on flat org keys for consistency

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8604 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoverifying existance of org tree before building union tree
erickson [Mon, 4 Feb 2008 16:28:06 +0000 (16:28 +0000)]
verifying existance of org tree before building union tree

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8602 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agono longer clobbering client-provided array of orgs
erickson [Mon, 4 Feb 2008 16:23:30 +0000 (16:23 +0000)]
no longer clobbering client-provided array of orgs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8600 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorepaired logic error in union-tree builder
erickson [Mon, 4 Feb 2008 15:36:28 +0000 (15:36 +0000)]
repaired logic error in union-tree builder

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8592 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoComplete i18n of chrome/cat/opac.js
dbs [Mon, 4 Feb 2008 05:56:31 +0000 (05:56 +0000)]
Complete i18n of chrome/cat/opac.js

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8591 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBring i18n to the main login window
dbs [Mon, 4 Feb 2008 05:43:50 +0000 (05:43 +0000)]
Bring i18n to the main login window

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8590 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott McKellar:
miker [Sun, 3 Feb 2008 19:08:44 +0000 (19:08 +0000)]
Patch from Scott McKellar:

1. In setSavepoint(), releaseSavepoint() and rollbackSavepoint()
we were leaking spName.

2. Deep in doCreate() we were passing the return value of
jsonObjectToSimpleString() directly to strcmp(), resulting in a leak.
The strcmp() was inside a complex if condition. which I rearranged so
as to capture the string and free it.

Also: I captured and reused the return value from
jsonObjectGetKeyConst() so as to avoid duplicated calls.

Aso: I reversed the sense of the if condition and swapped the branches,
so that it tests for equality rather than inequality.  To my eyes this
arrangement is more readable.

3. doRetrieve() was leaking id.

4. jsonNumberToDBString() was passing the return value of
jsonObjectToSimpleString() directly to atol() and atof(), thereby
leaking the memory.  I captured the pointers and freed them.

5. searchFieldTransform() was leaking val.

6. In searchJOIN() we were leaking type and filter_op in the case of
some early returns.  I moved the allocations past the early returns
so that we don't allocate them until we need them.  I also free them
as soon as we are done with them.  As a side benefit, I was able to
avoid allocating filter_op at all in some cases.

I gave similar treatment to table, although that wasn't being leaked.
As a result I could avoid having to free it in the early returns.

A couple of the early returns would leak field or fkey.  I plugged
those leaks as well.

I moved the declarations of filter and join_filter to their points
of first use, in the interest of clarity.

7. In buildSELECT(): we were passing the return value of
jsonObjectToSimpleString() directly to osrfHashGet(), thereby leaking
the memory.  I captured the pointer and freed it.

8. In doFieldmapperSearch() a do/while loop allocates pkey_val but
in some cases wasn't freeing it.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8589 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoinitial in-db circ and hold stuff. this codifies the circ_modifier, and requires...
miker [Sun, 3 Feb 2008 03:51:59 +0000 (03:51 +0000)]
initial in-db circ and hold stuff.  this codifies the circ_modifier, and requires that values be registered before importing items that use them.  so, word to the wise, and the importer.  there is some example SQL that will be useful for upgrading embedded in the script files right now.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8588 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoi18n of copy status overlay
dbs [Sat, 2 Feb 2008 22:16:55 +0000 (22:16 +0000)]
i18n of copy status overlay

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8587 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoprotect against null fingerprints (???)
miker [Sat, 2 Feb 2008 21:18:14 +0000 (21:18 +0000)]
protect against null fingerprints (???)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8586 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoi18n for copy details and circulation summary screens
dbs [Sat, 2 Feb 2008 21:15:51 +0000 (21:15 +0000)]
i18n for copy details and circulation summary screens

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8585 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoi18n for checkout and circulation info interfaces
dbs [Sat, 2 Feb 2008 19:53:18 +0000 (19:53 +0000)]
i18n for checkout and circulation info interfaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8584 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMake "make clean" clean the staff_client directory as well
dbs [Sat, 2 Feb 2008 19:48:53 +0000 (19:48 +0000)]
Make "make clean" clean the staff_client directory as well

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8583 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoRevert revision 8546 - checked in the wrong file.
dbs [Sat, 2 Feb 2008 19:48:13 +0000 (19:48 +0000)]
Revert revision 8546 - checked in the wrong file.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8582 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocreated method to return the thinnest full tree which contains a list of org IDs
erickson [Fri, 1 Feb 2008 22:25:53 +0000 (22:25 +0000)]
created method to return the thinnest full tree which contains a list of org IDs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8580 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadding the usr->barcode link
miker [Fri, 1 Feb 2008 20:38:03 +0000 (20:38 +0000)]
adding the usr->barcode link

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8577 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoremoved cstoreditor :funcs import, was causing circular import problems when apputils...
erickson [Fri, 1 Feb 2008 20:19:52 +0000 (20:19 +0000)]
removed cstoreditor :funcs import, was causing circular import problems when apputils was imported by cstoreeditor.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8575 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomoved old-fashioned perm check to json_query for speed
erickson [Fri, 1 Feb 2008 20:10:26 +0000 (20:10 +0000)]
moved old-fashioned perm check to json_query for speed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8573 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded method to find the org tree segments where a user has a given permission, inclu...
erickson [Fri, 1 Feb 2008 20:03:45 +0000 (20:03 +0000)]
added method to find the org tree segments where a user has a given permission, includes work orgs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8572 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosidestep race condition with new volumes and db replication.. this should fix the...
phasefx [Fri, 1 Feb 2008 17:25:57 +0000 (17:25 +0000)]
sidestep race condition with new volumes and db replication.. this should fix the Stat Cat popup errors, but we need to test on weezie

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8571 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosingle-row refresh does not realize when an item needs to move between lists, as...
phasefx [Fri, 1 Feb 2008 17:25:05 +0000 (17:25 +0000)]
single-row refresh does not realize when an item needs to move between lists, as in the Item Outs interface with Mark Lost or Claimed Returned.  This is a quick fix, needs testing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8570 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoit's the little things that getcha .... typo
miker [Fri, 1 Feb 2008 14:24:01 +0000 (14:24 +0000)]
it's the little things that getcha .... typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8566 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosubcolumn redux: need to wrap the function call in parens to delimit the subcolumn...
miker [Fri, 1 Feb 2008 14:20:32 +0000 (14:20 +0000)]
subcolumn redux: need to wrap the function call in parens to delimit the subcolumn from the function

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8565 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agogive cstore the ability to select a subcolumn from a complex datatype, using the...
miker [Fri, 1 Feb 2008 14:10:33 +0000 (14:10 +0000)]
give cstore the ability to select a subcolumn from a complex datatype, using the transform syntax

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8564 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadding 610, 611 and 630 to the list of controlled fields
miker [Fri, 1 Feb 2008 05:10:42 +0000 (05:10 +0000)]
adding 610, 611 and 630 to the list of controlled fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8563 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocomitting initial authoritative auto-magic transactions for cstore
erickson [Thu, 31 Jan 2008 22:45:28 +0000 (22:45 +0000)]
comitting initial authoritative auto-magic transactions for cstore

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8562 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoduping method_type before using it as a data in the hash, since method_type is later...
erickson [Thu, 31 Jan 2008 21:58:50 +0000 (21:58 +0000)]
duping method_type before using it as a data in the hash, since method_type is later freed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8559 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomoving dedup to just where it is needed
miker [Thu, 31 Jan 2008 21:40:30 +0000 (21:40 +0000)]
moving dedup to just where it is needed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8558 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodisallow marking an item lost that is already marked lost
erickson [Thu, 31 Jan 2008 20:52:21 +0000 (20:52 +0000)]
disallow marking an item lost that is already marked lost

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8557 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoput source include files in front of installed, system include files in the -I list...
miker [Thu, 31 Jan 2008 20:13:05 +0000 (20:13 +0000)]
put source include files in front of installed, system include files in the -I list (avoids mis-matched definition errors when const, etc is corrected)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8554 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott McKellar to plug a small leak in open-ils.auth
miker [Thu, 31 Jan 2008 19:59:04 +0000 (19:59 +0000)]
Patch from Scott McKellar to plug a small leak in open-ils.auth

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8553 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMissed the header in the last patch (from Scott McKellar)
miker [Thu, 31 Jan 2008 19:55:57 +0000 (19:55 +0000)]
Missed the header in the last patch (from Scott McKellar)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8552 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott McKellar:
miker [Thu, 31 Jan 2008 19:53:27 +0000 (19:53 +0000)]
Patch from Scott McKellar:

1. In oilsInitIDL: I added the const qualifier to the input parameter.
This change involved some juggling of a couple of extra variables.

2. Also in oilsInitIDL: I plugged a potential memory leak related to
an early return.

3. In oilsUtilsFetchUserByBarcode we create a jsonObject named
"card" but we weren't freeing it.  Now we free it.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8551 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1. In main() we allocate a growing_buffer named "json". I added a
miker [Thu, 31 Jan 2008 19:01:25 +0000 (19:01 +0000)]
1. In main() we allocate a growing_buffer named "json".  I added a
line to free it.

2. In commitTransaction() and rollbackTransaction() I eliminated
a layer of jsonObjectClone(), along with the associated
jsonObjectFree().  Now we extract the string we want directly from
the original object without making an unnecessary copy.

3. I renamed the four macros starting with "E" so as to start
with "E_" instead.

4. All functions (other than main()) are now static, as are the three
variables that had been declared at global scope.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8550 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott Mckellar to plug a few leaks
miker [Thu, 31 Jan 2008 18:56:38 +0000 (18:56 +0000)]
Patch from Scott Mckellar to plug a few leaks

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8549 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott McKellar:
miker [Thu, 31 Jan 2008 18:34:42 +0000 (18:34 +0000)]
Patch from Scott McKellar:

1. I added the const qualifier to a number of function parameters.

2. I moved the prototype for _oilsEventParseEvents() from the header
into the implementation file, and made the function static.  No other
source file calls it, nor should it.

3. I removed an extra leading underscore from each of _oilsEventEvents
and _oilsEventDescriptions, and made them static.

3. I removed an unhelpful cast from a call to safe_malloc().

4. I made sure to initialize every member of a new oilsEvent.

5. In several spots where we update pointer members of an oilsEvent,
I preceded the update with a free, in order to avoid potential
memory leaks.

6. I replaced calls to oilsEventSetPermission() and
oilsEventSetPayload() with the equivalent inline code.

7. In oilsEventFree(), the original code would free the json member
or the payload member but not both.  We now free both.  We also
free the event member, which we didn't do before.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8548 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Scott McKellar plugging several pointer leaks
miker [Thu, 31 Jan 2008 18:13:37 +0000 (18:13 +0000)]
Patch from Scott McKellar plugging several pointer leaks

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8547 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMake "make clean" clean the staff_client directory as well
dbs [Wed, 30 Jan 2008 21:56:40 +0000 (21:56 +0000)]
Make "make clean" clean the staff_client directory as well

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8546 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agochange D_ALERT log level to D_WARN to avoid unneeded popups
phasefx [Wed, 30 Jan 2008 19:00:38 +0000 (19:00 +0000)]
change D_ALERT log level to D_WARN to avoid unneeded popups

git-svn-id: svn://svn.open-ils.org/ILS/trunk@8544 dcc99617-32d9-48b4-a31d-7c20da2025e4