Galen Charlton [Sun, 15 Aug 2021 15:27:41 +0000 (11:27 -0400)]
LP#1905068: (follow-up) never initialize an OU ID to 1
This change has no effect on behavior, as defaultOuId's
initialization value always gets replaced with the user's
WS OU or the org root when the contructor is run, but
avoids any implication during code-reading that the top
of the OU tree can be assumed to have ID 1.
Jane Sandberg [Wed, 23 Jun 2021 23:59:51 +0000 (16:59 -0700)]
LP1905068: Add org-family-select to course list
To test:
1) Apply this patch
2) Admin > Local admin > Course reserves list
3) Check that the list defaults to courses available
at your workstation org unit
4) Check that, when you select ancestors, descendants,
or a different org unit, the course list updates
accordingly
5) Check that the list only displays org units for
which you have the MANAGE_RESERVES permission
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Add lp1923076-test-perl-scalar-return.t to the Perl live tests to test
a couple of back end calls affected by the changes in this branch.
These backend calls are those that are easily testable with Concerto
data.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Remove a block of commented code that was turned up while working on
this issue. This is in its own commit to make it easier to revert, if
necessary.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Add cast to int of scalar used on arrays in more places where it seems
necessary.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jeff Davis [Thu, 8 Apr 2021 02:41:49 +0000 (19:41 -0700)]
LP#1923076: ensure length of empty array is treated as a number when retrieving hold counts
Thanks to Jason Stephenson for suggesting this solution.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jane Sandberg [Tue, 13 Jul 2021 03:56:01 +0000 (20:56 -0700)]
LP1935693: Add circulation modifier to course page
Also makes some strings extractable for translation that
were previously missed.
To test:
1) Enable the course materials module
2) Add some courses
3) Add some materials to those courses, using a mix of
circulation modifiers
4) In the OPAC, use the Course Search to search for
your courses
5) Click on the course you created
6) Note that physical items associated with the course
display their circulation modifiers in the circulation
modifier column.
Mike Rylander [Mon, 28 Jun 2021 19:06:26 +0000 (15:06 -0400)]
LP#1895052: Avoid foreign targets when local items exist
This commit adds a new YAOUS that allows a pickup library to specify
that it does not want its holds to have foreign (prox > 0) copies
directly targeted if there is a local copy in an available status (on
the shelf). The setting is an interval, and after the age of the hold
has passed that interval, foreign direct targetting is allowed.
This does not change the calculation of the potential list, so
op-capture will be availalbe (all else being equal) without
retargetting.
This setting (circ.pickup_hold_stalling.hard) is meant to be used in
concert with the other new setting in the parent commit
(circ.pickup_hold_stalling.soft), and should generally have a value the
same or smaller than the soft setting. Doing this allows tiered
targetting, where no remote items are targeted via the hard setting for,
say, 3 days, where all capture is restricted to only the pickup, and
then, with a soft setting of 5 days, the next 2 days allow only direct
target capture of foreign copies. After 5 days, normal, global
targetting and op-capture resumes.
An alternative use for this setting is to ignore the parent-commit soft
setting and allow op-capture everywhere, but only direct targetting at
the pickup library. The effect of this, if used globally throughout an
entire Evergreen instance, would be that the pull list would only
represent pickup-local holds, but serendipitous scans of items that
could fill remote holds could capture for transit.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
This commit provides a new YAOUS that, when set, takes precedence over
the current "soft stalling interval" YAOUS. Instead of limiting capture
to items owned by the pickup library (or the directly targeted item)
based on the context of scanned item's circulating library, it instead
restricts op capture to holds that have a pickup library of the scanning
location when the hold is younger that the interval, base on the context
of the pickup location of each hold.
tl;dr: It allows the pickup library to control op capture stalling
rather than the circulating library of an arbitrary scanned item.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Also removes the underlying component, since it's not longer used
anywhere.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Bill Erickson [Wed, 28 Jul 2021 14:17:48 +0000 (10:17 -0400)]
LP1910452 Staff catalog Patron View button
Adds a Patron View button to the Angular staff catalog record detail
page which opens the catalog in a new browser tab.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
LP#1912852: add jump-on-one-hit support to Angular staff catalog
This patch add support for the opac.staff.jump_to_details_on_single_hit
library setting to the Angular staff catalog.
To test
-------
[1] Apply the patch.
[2] Ensure that the opac.staff.jump_to_details_on_single_hit setting
is off for your workstation.
[3] Perform searches using the Angular staff catalog. Verifying that
searches that return any number of results display them on the
results page.
[4] Set the library setting to true and reload the staff catalog.
[5] Perform keyword, numeric, and MARC searches using terms that
result in a single-record result set. Verify that the interface
redirects to the single-record page for that hit.
[6] Perform searches that would return zero results. Verify that
the results page indicates zero hits fuond.
[7] Perform searches that would return more than one result. Verify
that the results are displayed on the results page.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
When a staff person tries to schedule curbside appointments
after their UTC equivalent time moves to the next day, the
timeslots for the next day are shown, and appointments get
made for the next day.
For example, when CST is the local timezone (UTC-6), after 6pm
appointments for the current day are scheduled for the next day.
Appointments for the next day get scheduled for the day after.
This happens because toISOString is used to grab the current date,
but toISOString always returns UTC time. The date widget will show
the correct date, but the time slots will actually be for the next
day. This is more noticeable if days have different schedules.
Another clue is that the time slot selector will show all timeslots for
the day, not just the ones that are upcoming.
Testing Plan:
1. Enable curbside for test location, and set org unit hours to
be at least through 8pm for open hours.
2. Wait until after 4PM (Pacific), 6pm CST, 7PM EST, or
change your computer clock.
3. Try to schedule an appointment for the current day.
4. The appointment should get scheduled for the next day.
5. Apply the fix.
6. Try to schedule another appointment and see that the correct
date gets selected.
Jason Boyer [Sat, 10 Nov 2018 22:53:16 +0000 (17:53 -0500)]
LP1802682: Use Default Net Access Level OUS
This branch does two things: makes use of the OUS
that determines the default Net Access Level, and
also changes the type of the coust entry to make
using it more user friendly.
Terran McCanna [Thu, 22 Oct 2020 22:05:37 +0000 (18:05 -0400)]
LP1901028 Print Template for Checkout Missing Fields
The fields are actually available, but the hints in the template
were incorrect. This fixes the hints for call number, owning library
name, owning library short name, and circulation modifier.
This patch makes the form in the self-registration screen in the Bootstrap
opac a little responsive on smaller devices.
To test.
1. Turn on self-registration in the library settings.
2. Go to the self-registration screen and make the screen as small as possible.
3. Apply the patch.
4. Notice that the form labels and input boxes are now more aesthetic.
5. Create some self-registration requests to make sure the form captures the data.
Bill Erickson [Tue, 13 Apr 2021 17:05:18 +0000 (13:05 -0400)]
LP1923640 Manage visibility of grid action menu entries
Adds a new Angular Grid configuration menu entry labeled "Manage Actions
Menu", which launches a new dialog which allows staff to show/hide
individual entries in the grid toolbar actions menu / context menu.
The new menu action is disabled when a grid has no toolbar actions.
Garry Collum [Thu, 27 May 2021 17:49:00 +0000 (13:49 -0400)]
LP1929839 Load Shared Bucket text error
Changes the title of the Load Shared Bucket pop-up box from "Load Shared
Bucket Bucket by ID" to "Load Shared Bucket by ID". I decided not to
change it to "Load Shared Bucket by Bucket ID" since "Bucket ID" is
displayed next to the input field.
This affects all 3 types of buckets: item, record and user.
Jason Boyer [Mon, 28 Jan 2019 15:22:01 +0000 (10:22 -0500)]
LP1813191: Add a Dewey Classification View to acn
The most-missed part of the Classic Item View in the
reporter are the dewey ranges and blocks. This branch
pulls those out into their own view and hangs it off
of a link from asset.call_number so they can be used
in reports from any path that connects to acn.
Galen Charlton [Tue, 1 Jun 2021 22:23:36 +0000 (18:23 -0400)]
LP#1904244: format: switch from CurrencyPipe to DecimalPipe
CurrencyPipe has no easy way of displaying the monetary amount
without a currency symbol, which means that currency amounts
display with a dollar sign -- which isn't a univeral assumption
for Evergreen.
Future work is indicated to (a) teach Evergreen a global flag
or a library setting for the system's base currency and (b) let
the format service be passed a currency code. Once both are in place,
CurrencyPipe can be restored.
This is a synonym of the 'required' attribute, as overloading
the HTML5 required attribute can lead the colored left border
indicated the state of the widget extending to the container
of the combobox.
LP#1904244: fm-editor: add a linkedSearchConditions field option
This option allows the caller to specify conditions to add
when retrieving values for a linked field, e.g., to specify
that only active values should be fetched.
If the underlying record has a value set for the linked field, that
value will be included when preloadLinkedValues and the value
doesn't otherwise meet the search conditions.
This patch also sorts the values if preloadLinkedValues is used.
Galen Charlton [Thu, 25 Mar 2021 17:44:44 +0000 (13:44 -0400)]
LP#1904244: teach grid columns how to start with a filter set
This adds initialFilterOperator and initialFilterValue inputs
to eg-grid-column to specify that the data set should start off
with a column filter set.
LP#1904244: update various IDL labels for acq columns
* Claiming and fund tables: "Org Unit" or "Org" to "Owner"
* "Claim Policy ID" to "Claim Policy" for links to claim
policies
* "Fund ID" to "Fund" for links to funds
* Fund allocation and fund debit times
Bill Erickson [Tue, 3 Aug 2021 20:58:29 +0000 (16:58 -0400)]
LP1934184 Vandelay Delete Queue action repair
Fixes the Queue Details page Delete Queue link. Before it did nothing,
now it prompts the user to confirm deletion followed by deleting the
queue (when confirmed).
To test, go to Cataloging => MARC Batch Import/Export => Inspect Queue
=> Double-click a queue => Click Delete Queue (under Queue Actions) and
confirm that the confirmation dialog appears and deletion works.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 6 Aug 2021 15:35:49 +0000 (11:35 -0400)]
LP#1450519: remove unauthorized access to library setting history
This patch changes the current Library Settings editor so that
it doesn't display the setting history for a setting that the user
doesn't have the underlying view permission for. It also removes
the coustl IDL class [config.org_unit_setting_type_log] from PCRUD.
Access to the setting history is now done through a new method,
open-ils.actor.org_unit.settings.history.visible.retrieve, which
accepts an authtoken and a setting name. If the user has the
relevant view permission, setting history entries at all of the
OUs that they have the permission at are returned. If the user
lacks the permission, an empty array is returned. If the setting
has no permission associated with it, all history entries for
the setting are returned. The user must have at least STAFF_LOGIN
to retrieve any entries at all.
To test
-------
[1] As an administrator, make some changes to the values of
a privileged library setting (such as one of the credit card
ones) and an unprivileged one (e.g., lib.info_url).
[2] Log in as a staff user without administration privileges
and go to the library settings editor. Note that while the
current value of privileged settings are not displayed, clicking
on the history link displays the full history of the setting.
[3] Apply the patch and repeat step 2.
[4] This time, history for the privileged setting is not displayed,
while history for an unprivileged setting continues to be
available.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Shula Link <slink@gchrl.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
The baseline schema did not get updated to include the
opac.did_you_mean.max_suggestions YAOUS, so fresh, rather than upgraded,
Evergreen installs will be missing it.
This commit adds it to the baseline and provides an upgrade script to
give the setting to impacted instances.
Jason Stephenson [Fri, 16 Jul 2021 19:50:59 +0000 (15:50 -0400)]
Lp 1936662: Add CPAN Module Prerequisites for Debian and Ubuntu
This commit adds the missing CPAN module prerequisites for the "did
you mean" feature to the PostgreSQL server Makefile targets for Debian
Jessie, Stretch, Buster and Ubuntu Bionic.
They were added to the Makefile target for Ubuntu Focal but were
apparently overlooked in the other distros.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Boyer [Thu, 22 Jul 2021 17:50:53 +0000 (13:50 -0400)]
LP1937299: Collections Exempt User Setting Repair
The collections exempt user setting was never added to the seed data
meaning that depending on the age of your database it may or may not
be there. Additionally, correct the label for this setting in the
user editor.
The method of playing audio alerts seems to not be working in modern browsers.
It seemed to work in firefox V40, but no longer in V68.
Adding the autoplay element and then immediately removing it prevents the audio
from playing. I've also noticed in the past that the audio had been cut off
before the file was fully played.
Using the .play() method does seem to work in newer versions of Firefox
and Chrome. Tested with Chrome V90 and Firefox V78.10.1esr.
Testing Plan:
1. Enable Self Check Audio Alerts Library Setting.
2. See the docs for setting up the default audio alerts.
https://docs.evergreen-ils.org/reorg/3.1/command_line_admin/_self_check_interface.html
3. Launch self check interface, create a workstation and try to trigger an alert.
https://eg-server.you.com/eg/circ/selfcheck/main
4. entering a fake barcode will trigger an alert which should not be audible.
Apply the fix:
1. Launch self check interface, and reload/clear cache.
2. Enter a fake barcode to trigger an audio alert.
3. The audio alert should now be audible.
Jason Etheridge [Thu, 25 Mar 2021 20:21:00 +0000 (16:21 -0400)]
lp1894005 Stripe payment intents
===== Credit card payments using Stripe now implimented with PaymentIntents instead of Charges =====
This changes the Stripe code in the OPAC to use their PaymentIntents and confirmCreditCard API,
which is recommended over their Charges API. Credit card charges are no longer finalized
(captured/confirmed) on Evergreen's backend, though the backend does check whether a payment was
made successfully before recording it.
Sponsored-by: CW MARS Sponsored-by: NOBLE Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Lynn Floyd [Mon, 2 Aug 2021 16:03:15 +0000 (09:03 -0700)]
DOCS:Shelving Locations, Added images and updated directions
Added images and updated information on Shelving locations. Included information on Hold_Verify
Adding additional information in to the shelving locations.
Added Index terms.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Wed, 14 Jul 2021 16:20:03 +0000 (09:20 -0700)]
LP1718782: follow up to fix failing test
LP1718782 added a missing fixed field, but failed to also add it to
the expected data in this pgtap test. This commit updates the
expected data to also include a SRCE fixed field.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Thu, 10 Sep 2020 18:35:22 +0000 (11:35 -0700)]
LP1718782: Add the Srce fixed field to the Angular MARC editor
To test:
1) Without using private browsing, open up a bibliographic record in
the Angular catalog MARC editor.
2) Notice that there is a gap between the ELvl and Audn fixed fields.
3) Apply this patch.
4) Open up the same bibliographic record, this time using private
browsing (since the Angular MARC editor caches fixed field values).
5) Notice that the Srce fixed field is available between the ELvl and
Audn fixed fields.
6) Notice that you can right click inside the fixed field to get a list
of three possible values.
7) Repeat the test with different record types (e.g. BKS, SCO, VIS)
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Mary Llewellyn <mllewell@biblio.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Bill Erickson [Mon, 5 Jul 2021 20:04:56 +0000 (16:04 -0400)]
LP1910808 Staff catalog show call number
In the search results page, show the first call number for each record
(sorting by label sortkey) that is owned either by the user's preferred
library or the search library.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
projects / Evergreen.git / log