Evergreen.git
6 years agoTeach ACQ EDI and print PO templates about order identifiers
Bill Erickson [Wed, 23 Jan 2013 20:10:42 +0000 (15:10 -0500)]
Teach ACQ EDI and print PO templates about order identifiers

Update both templates to look for the preferred order identiier value
instead of the first reasonable it can find.

ISSN identifiers are now correctly encoded in the EDI as well.

[LFW] Fix permission numbering flub.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoACQ order identifier release notes
Bill Erickson [Mon, 11 Mar 2013 21:01:31 +0000 (17:01 -0400)]
ACQ order identifier release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoACQ order identifier UI
Bill Erickson [Fri, 18 Jan 2013 17:27:28 +0000 (12:27 -0500)]
ACQ order identifier UI

In the lineitem table show the set of possible order identifier types
and values.  The user may enter new values when necessary.  When changes
are applied, the selected order identifier is applied to each lineitem.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoACQ API for setting the lineitem order identifier
Bill Erickson [Mon, 21 Jan 2013 19:51:48 +0000 (14:51 -0500)]
ACQ API for setting the lineitem order identifier

API: open-ils.acq.lineitem.order_identifier.set

Given an existing lineitem_attr (typically a marc_attr), this will
create a matching local_attr to store the name and value and mark
the attr as the order_ident.  Any existing local_attr marked as
order_ident is removed.  When necessary, the value (isbn, issn, upc) is
added to the record first to create the marc attribute.  If the lineitem
is linked to a bib record and the user has the correct permissions, any
new data will also be applied to the bib record.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoACQ lineitem order identifier SQL/IDL
Bill Erickson [Fri, 18 Jan 2013 17:27:20 +0000 (12:27 -0500)]
ACQ lineitem order identifier SQL/IDL

New 'order_ident' column on acq.lineitem_attr to represent which
attribute should be considered the order identifier for the item.

New permission ACQ_SET_LINEITEM_IDENTIFIER allowing staff to apply
lineitem identifiers.

New permission ACQ_ADD_LINEITEM_IDENTIFIER is added for allowing staff
to update linked bib records when a order identifier is added to a
lineitem.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoExtract multiple like values from lineitem
Bill Erickson [Tue, 22 Jan 2013 19:35:22 +0000 (14:35 -0500)]
Extract multiple like values from lineitem

Make it possible to extract multiple values with the same MARC tag
during acquisitions lineitem ingest.  Prior to this, only one (e.g.)
ISBN for each record would be extracted as a lineitem attribute.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoStamping upgrade scripts for Z-source attr DELETE cascade (and repairing previous...
Mike Rylander [Wed, 13 Mar 2013 18:52:16 +0000 (14:52 -0400)]
Stamping upgrade scripts for Z-source attr DELETE cascade (and repairing previous upgrade script id)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP 849008 : Cascade delete Z39.50 attributes
Bill Erickson [Wed, 13 Mar 2013 18:26:48 +0000 (14:26 -0400)]
LP 849008 : Cascade delete Z39.50 attributes

Force deletion of Z39.50 attributes within the database when the Z39.50
source to which the attributes refer is deleted.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade scripts for "Storing Z39.50 Passwords on the server"
Mike Rylander [Wed, 13 Mar 2013 18:47:16 +0000 (14:47 -0400)]
Stamping upgrade scripts for "Storing Z39.50 Passwords on the server"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAdd CASCADE and DEFERRABLE clauses to fkey
Mike Rylander [Wed, 13 Mar 2013 18:45:22 +0000 (14:45 -0400)]
Add CASCADE and DEFERRABLE clauses to fkey

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoZ39.50 stored credentials
Bill Erickson [Wed, 27 Feb 2013 18:08:07 +0000 (13:08 -0500)]
Z39.50 stored credentials

* New non-IDL-accessible DB table for storing credentials
* API for applying credentials
* Additions to the Z39.50 configuration UI for applying and clearing
  credentials.
* At Z39.50 search time, if no creds are provided by the caller, but
  creds are configured in the database, creds from the DB are used to
  make the Z39 search call.
* Release notes included

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoDefault and force patrons to TPac
Thomas Berezansky [Wed, 25 Apr 2012 15:55:42 +0000 (11:55 -0400)]
Default and force patrons to TPac

May be incomplete, but better than nothing.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoDisable JSPac in staff client
Thomas Berezansky [Mon, 17 Sep 2012 14:02:13 +0000 (10:02 -0400)]
Disable JSPac in staff client

This includes removing the toggle option for TPac usage.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP 1134829 - stamping upgrade script
Bill Erickson [Wed, 13 Mar 2013 17:33:05 +0000 (13:33 -0400)]
LP 1134829 - stamping upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoAdded a second no attempt to code to the authority thesaurus for spaces.
Steven Callender [Wed, 27 Feb 2013 21:42:18 +0000 (16:42 -0500)]
Added a second no attempt to code to the authority thesaurus for spaces.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoReturn calculated value for SIP recall_ok test
Bill Erickson [Wed, 26 Dec 2012 15:29:30 +0000 (10:29 -0500)]
Return calculated value for SIP recall_ok test

Determine the value for the "recall OK" testing for patron information
requests the same we we determine the value for ciruclations and holds.
Previously, the recall-OK test always returned false, presumably since
recalls are not currently supported in Evergreen SIP.

Note that like holds and circs, we determine whether a user has good
standing based on the users penalties and whether the user is active /
non-barred.  Though we could in some cases, we are not checking whether
the user has the required permission to perform specific tasks.

This feature is enabled via a new oils_sip.xml configuration option:

<option name='patron_calculate_recal_ok' value='true' />

This option is disabled by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade script for #deleted modifier support
Mike Rylander [Wed, 13 Mar 2013 17:08:42 +0000 (13:08 -0400)]
Stamping upgrade script for #deleted modifier support

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoQP search modifier '#deleted'
Mike Rylander [Fri, 8 Mar 2013 19:26:17 +0000 (14:26 -0500)]
QP search modifier '#deleted'

These tweaks involve an internal flag that's off by default. If you
want '#deleted', you'll have to turn it on explicitly at your site (and
reingest existing records) to get the functionality. If you don't need
'#deleted', you may prefer to leave the setting off so that your system
will be purged (as before) of useless (to you) metarecord mappings
taking up room in the database for deleted bibs.

[LFW] upgrade script; commit message; release note

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade script for user-barred A/T hooks
Mike Rylander [Wed, 13 Mar 2013 16:52:45 +0000 (12:52 -0400)]
Stamping upgrade script for user-barred A/T hooks

6 years agoA/T aggregator --granularity option
Bill Erickson [Thu, 20 Dec 2012 21:38:16 +0000 (16:38 -0500)]
A/T aggregator --granularity option

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoBatch CSV notifications release notes
Bill Erickson [Tue, 11 Dec 2012 17:09:42 +0000 (12:09 -0500)]
Batch CSV notifications release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoScript to collect CSV notification status responses
Bill Erickson [Tue, 11 Dec 2012 17:07:37 +0000 (12:07 -0500)]
Script to collect CSV notification status responses

For 3rd-party services which provide batch notifications status updates
via CSV file.  The script assumes the action/trigger event definition ID
is included in the response and, from there, applyes the "status" value
to the async_output of the event definition in question.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoSupport FTP/SCP delete operation in RemoteAccount
Bill Erickson [Thu, 10 Jan 2013 17:25:09 +0000 (12:25 -0500)]
Support FTP/SCP delete operation in RemoteAccount

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAction/Trigger template output aggregator
Bill Erickson [Tue, 11 Dec 2012 17:03:27 +0000 (12:03 -0500)]
Action/Trigger template output aggregator

Script to collect template output data from action-trigger events,
potentially spanning multiple event definitions, and stitching the
output together into a single file / output.  The file may then be
delivered to a 3rd party via sFTP/SCP using config.remote_account.

The primary use case of the script is for aggregating CSV, XML, etc.
output to deliver to a 3rd party for notification purposes (e.g. phone,
print notices).  This is useful because a) no one event definition can
cover all notification types and b) template output files can become too
large to practically store in the DB and deliver to/from opensrf
services.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoSeed data for CSV notification export
Bill Erickson [Tue, 11 Dec 2012 16:59:50 +0000 (11:59 -0500)]
Seed data for CSV notification export

Full set of seed data for CSV action/trigger notification batch exports.
The seed data is added to its own file and not automatically loaded into
new installs (or via upgrade script) since it adds a significant number
of new event definitions, probably more than most installs need by
default.

Review the event defs. and their parameters prior to loading this seed
data, as it only represents one possible set of CSV notification
options.  For example, it assumes one type of "notify media" for all
created notices.  It may necessary to add additional event defs to cover
additional media, etc.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAction/trigger user barred/unbarred hooks
Bill Erickson [Thu, 27 Dec 2012 15:58:01 +0000 (10:58 -0500)]
Action/trigger user barred/unbarred hooks

New active A/T hooks 'au.barred' and 'au.unbarred', plus PatronBarred
and PatronNotBarred validators, plus code to make the hooks dance.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAdditional action/trigger helper functions
Bill Erickson [Tue, 11 Dec 2012 16:57:42 +0000 (11:57 -0500)]
Additional action/trigger helper functions

Added to the 'helpers' environment for action/trigger templates

 * get_org_unit -- get org object from id
 * escape_csv -- escapes strings ia csv values
 * get_user_setting

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoRelease notes for Serial Control special statuses
Dan Wells [Tue, 12 Mar 2013 17:47:41 +0000 (13:47 -0400)]
Release notes for Serial Control special statuses

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoSerials special status support for Items tab
Dan Wells [Fri, 14 Dec 2012 19:22:20 +0000 (14:22 -0500)]
Serials special status support for Items tab

The Serial Control interface prevents direct editing of item status, as
some status changes require additional updates and/or can create data
conflicts.

In the current state, though, we have no way to set three important
statuses: claimed, not held, and not published.  At some point, claims in
particular should be more than a simple status, but in the meantime, the
ability to set these should not be overlooked.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoAllow nesting of create_date and edit_date filters
Mike Rylander [Tue, 12 Mar 2013 20:01:25 +0000 (16:01 -0400)]
Allow nesting of create_date and edit_date filters

As gently suggested by tsbere, this commit allows nesting of said
filters.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoTwo new QP filters: create_date and edit_date
Mike Rylander [Fri, 8 Mar 2013 20:13:11 +0000 (15:13 -0500)]
Two new QP filters: create_date and edit_date

These filter on the fields of the same name in biblio.record_entry.

e.g.
    create_date(,2013-02-01)  =>  records created before 2013-02-01
    create_date(2013-02-01)   =>  records created since 2013-02-01
    create_date(2013-02-01,2013-02-28)  =>  records created in Feb 2013
    create_date(yesterday)    =>  records since created yesterday

[LFW] Reviewed and added a single missing 'use' line; rewrote commit
message; release note.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoFix holding lib for certain distribution svrs
Dan Wells [Thu, 28 Feb 2013 20:32:07 +0000 (15:32 -0500)]
Fix holding lib for certain distribution svrs

On a serial virtual record (svr), the holding lib is expected to be
just an ID.  In one logic branch, Search/Serial.pm was attaching the
entire aou object, and we should instead attach just the ID of this
object.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoStamping upgrade for inactive barcode retrieval
Ben Shum [Tue, 12 Mar 2013 21:22:36 +0000 (17:22 -0400)]
Stamping upgrade for inactive barcode retrieval

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1154235 Allow inactive patron barcode to be loaded
Michael Peters [Tue, 12 Mar 2013 20:14:23 +0000 (16:14 -0400)]
LP#1154235 Allow inactive patron barcode to be loaded

This addresses LP#1154235 by modifying the evergreen.get_barcodes
function to allow users to retrieve patrons in barcode retrieve
who have inactive barcodes.

This returns to functionality in versions prior to around 2.2.x
series.

End result is staff receiving an alert that the patron was
accessed with an invalid barcode.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoEscape barcode completion button labels
Thomas Berezansky [Mon, 11 Mar 2013 19:09:51 +0000 (15:09 -0400)]
Escape barcode completion button labels

Some characters piss off the XML parser.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoShow OPAC-invisible copies in TPAC in staff context
Dan Scott [Sat, 9 Mar 2013 03:41:08 +0000 (22:41 -0500)]
Show OPAC-invisible copies in TPAC in staff context

We were not calling the staff variation of the copy count method; thus,
the record details template was skipping the copy table in the event
that all copies for a given record were marked as OPAC-invisible via
either copy visibility or shelving location visibility.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoDon't populate the MFHD menu with distributions
Dan Wells [Thu, 28 Feb 2013 19:49:16 +0000 (14:49 -0500)]
Don't populate the MFHD menu with distributions

If a distribution has no legacy record, it shouldn't get a menu
entry in the MFHD menus. A magic id of '-1' is used to indicate
this case, so we need to check for that when populating
mfhdDetails via the TPAC.

Also, entryNum must be an int, not a string, because it is
incremented prior to display. Removing the quotes solves this
display issue.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTweak Google Book Preview Display, Take 2
Dan Wells [Wed, 27 Feb 2013 14:34:58 +0000 (09:34 -0500)]
Tweak Google Book Preview Display, Take 2

After some additional feedback, this commit makes three changes
to the Google Book preview link:

1) As a solution offered by Dan Scott, rather than move the
button, we simply scroll to the preview when the button is clicked.
This effectively makes it impossible to miss. (In the current
code it sometimes loads off the screen.)

2) Make the viewer display in the same style as other added
content.

3) Allow the added content header to function as an additional
toggle to turn the viewer on and off.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoMake Google Books Preview Honor Setting
Dan Wells [Wed, 27 Feb 2013 14:24:33 +0000 (09:24 -0500)]
Make Google Books Preview Honor Setting

The new Google Book Preview was loading even if the setting was
off, provided some other 'want_dojo' feature was loaded. This
change will honor the setting regardless.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoUser seed data has (mostly) valid addresses
Bill Erickson [Wed, 6 Mar 2013 18:10:21 +0000 (13:10 -0500)]
User seed data has (mostly) valid addresses

Make all but 3 (2 patrons, 1 staff) user addresses in the sample SQL
seed data valid.  Prior to this, most addresses were marked as
non-valid.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoError Checking for Hold Targeter
Thomas Berezansky [Fri, 6 Apr 2012 18:39:28 +0000 (14:39 -0400)]
Error Checking for Hold Targeter

Because having it leave lock files around is annoying.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoStamping upgrade for "exclude_invisible_acn" unapi holdings filter
Ben Shum [Mon, 11 Mar 2013 21:45:23 +0000 (17:45 -0400)]
Stamping upgrade for "exclude_invisible_acn" unapi holdings filter

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTPAC my-list call number includes child orgs
Bill Erickson [Wed, 6 Mar 2013 21:02:37 +0000 (16:02 -0500)]
TPAC my-list call number includes child orgs

For my-list call number display, if the most relevant call number is a
child of any of the context org units (physical/pref/search), it is
considered relevant for purposes of call number display.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agotpac avoid more org_unit template var leaks
Bill Erickson [Tue, 12 Feb 2013 17:19:58 +0000 (12:19 -0500)]
tpac avoid more org_unit template var leaks

Avoid using the variable name 'org_unit' in misc_utils (when compiling
copy visibility info) since the value can leak into the org_selector
template, disrupting the rendering of the org selector.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoConsistent response type from TPAC pref lib lookup
Bill Erickson [Mon, 28 Jan 2013 18:40:12 +0000 (13:40 -0500)]
Consistent response type from TPAC pref lib lookup

In some contexts, the $user->home_ou field is fleshed with a real org
unit object.  Ensure that the response value from _get_pref_lib in the
TPAC takes this into consideration when finding the ID of the user's
home org unit.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoTPAC My List Call-Number Release Notes
Bill Erickson [Fri, 25 Jan 2013 14:32:38 +0000 (09:32 -0500)]
TPAC My List Call-Number Release Notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoShow local call number in TPAC My Lists display
Bill Erickson [Thu, 13 Dec 2012 16:34:50 +0000 (11:34 -0500)]
Show local call number in TPAC My Lists display

If an opac-visible call number exists that is owned by an org unit
relevant to the patron, show the (most relevant) call number label in
the My Lists display for each record in the list.  Call number is
displayed in both saved and temporary lists.

A call number is considered relevant if its owner is one of:

physical location library
preferred library (plib, home, etc.)
search library

This code leverages the new "exclude_invisible_acn" unapi filter to
ensure that we are only required to retrieve 1 call number in the unapi
output instead of an arbitrarily large set of call numbers, against
which we may have to filter non-visible call numbers.

This commit also addresses and outstanding TODO item in the tpac Perl:
Replace the last use of fetch_marc_xml_by_id with get_records_and_facets
and remove fetch_marc_xml_by_id

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years ago"exclude_invisible_acn" unapi holdings filter
Bill Erickson [Wed, 12 Dec 2012 22:14:09 +0000 (17:14 -0500)]
"exclude_invisible_acn" unapi holdings filter

When present in the unapi includes array, this filter ensures that no
call numbers with 0 opac-visible copies are included in the holdings_xml
output.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agounapi exclude_invisible_acn
Bill Erickson [Wed, 12 Dec 2012 19:58:26 +0000 (14:58 -0500)]
unapi exclude_invisible_acn

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoStamping upgrade for relaxing rank_ou sorting
Ben Shum [Mon, 11 Mar 2013 21:40:11 +0000 (17:40 -0400)]
Stamping upgrade for relaxing rank_ou sorting

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agorank_ou() honors pref-lib in non-global context
Bill Erickson [Thu, 7 Feb 2013 18:43:19 +0000 (13:43 -0500)]
rank_ou() honors pref-lib in non-global context

When determining how to sort an org unit (e.g. sorting copies by circ
lib for display in the catalog), allow the pref-lib to affect the sort
order in global and non-global searches.

Org units are now sorted with the following criteria in the following
order.  For example, assume we are sorting a copy circ_lib:

1. circ_lib matches the search_lib
2. circ_lib matches pref_lib
3. distance of circ_lib from pref_lib when pref_lib is a child of
   search_lib, if circ_lib is a child of pref_lib.
   (For example, searching CONS with pref_lib SYS1, items at BR1 will
   sort ahead of items at BR3, since BR1 is a child of the pref_lib).
4. proximity of circ_lib to search_lib, when circ_lib is a child of
   search_lib.
5. In all other cases, circ_lib is sorted to the bottom with the rest of
   the riffraff.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoextract PO name from picklist upload
Bill Erickson [Wed, 21 Nov 2012 15:12:39 +0000 (10:12 -0500)]
extract PO name from picklist upload

If a PO name is encoded in a lineitem (via provider attribute
definition), extract that PO name when creating a new purchase order
from lineitems that were previously only linked to a selection list.
This allows staff to create selection lists first, then orders second,
while retaining the encoded purchase order name.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade for serials harmonization
Mike Rylander [Mon, 11 Mar 2013 20:22:38 +0000 (16:22 -0400)]
Stamping upgrade for serials harmonization

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoFix divergence of stock serials schema and upgraded schema
Lebbeous Fogle-Weekley [Tue, 23 Oct 2012 16:25:18 +0000 (12:25 -0400)]
Fix divergence of stock serials schema and upgraded schema

And additionally make a function used in a constraint on
serial.issuance.holding_code a little bit smarter.

These issues were reported to me by Galen Charlton.

The upgrade script included here will set serial.issuance.holding_code
to NULL in cases where the value doesn't validate, but in those cases
there is no part of Evergreen that could have made use of the data
anyway, and the data is just plain bad.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoExclude copies that have been deleted from showing up on the browse holds shelf list.
Steven Callender [Thu, 4 Oct 2012 13:17:29 +0000 (09:17 -0400)]
Exclude copies that have been deleted from showing up on the browse holds shelf list.

If an item had been deleted while it had a status of On Holds Shelf, it would permanently show up on
the browse holds list. This will exclude deleted copies from the results.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoRemote Account Conify UI
Bill Erickson [Tue, 11 Dec 2012 20:50:56 +0000 (15:50 -0500)]
Remote Account Conify UI

Admin interface for config.remote_account.  To date, remote accounts
have been managed solely as EDI accounts, which have their own
interface.  If one wishes to add/manage non-EDI remote accounts, then
this new UI is needed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/xul/staff_client/chrome/content/main/menu_frame_menus.xul

[minor, related to adjacent addition]

6 years agoPulls the Copy Notes for the records, shows in the table, introduces a new style
edoceo [Thu, 21 Feb 2013 02:21:29 +0000 (18:21 -0800)]
Pulls the Copy Notes for the records, shows in the table, introduces a new style

Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade script for null SVF attribute value fix
Mike Rylander [Mon, 11 Mar 2013 19:41:00 +0000 (15:41 -0400)]
Stamping upgrade script for null SVF attribute value fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1116509: prevent null SVF attribute value from breaking record import
Galen Charlton [Tue, 5 Feb 2013 18:12:02 +0000 (13:12 -0500)]
LP#1116509: prevent null SVF attribute value from breaking record import

Fix problem where a record could fail to be staged for import
with the following error:

ERROR: query string argument of EXECUTE is null
CONTEXT: PL/pgSQL function "extract_rec_attrs" line 72 at EXECUTE statement
SQL function "extract_rec_attrs" statement 1

This error would be triggered if at least one SVF attribute has a normalization
function defined that is applied to a null value during record import.

Patch is based on a suggestion by Bob Wicksall.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoReify required authority fixed field names
Mike Rylander [Mon, 11 Mar 2013 17:40:46 +0000 (13:40 -0400)]
Reify required authority fixed field names

Adam (and Art, by way of Adam's patch) added a goodly pile of fixed
field definitions that were lacking previously.  The change in this
commit simply changes the label of two (008/11 and 008/15) to those
in use by other parts of the code.  In particular, internally, we call
the field holding a thesaurus code value "Subj" and use that name during
ingest of authority records.  Therefore, that should not change.  This
required a subsequent change to the label of another, to SubjUse.

I've included a duplication in the backend-only (probably deprecated)
version of this mapping to allow the front-end labels to work.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agolp1040381: match up Subj and SubjUse fixed labels
Galen Charlton [Wed, 5 Dec 2012 17:23:04 +0000 (12:23 -0500)]
lp1040381: match up Subj and SubjUse fixed labels

Update the labels used in the fixed field editor for
authority records to match OCLC's labels specified at

http://www.oclc.org/support/documentation/worldcat/authorities/authformat/default.htm

This is consistent with commit's e675b854 change to the
OCLC labels, and also fixes a problem where changing the
008/11 and 008/15 was not reflected in the fixed field boxes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoAdd fixed fields missing from previous configuration, namely for MAP and SER record...
Adam Bowling [Fri, 26 Oct 2012 14:59:54 +0000 (10:59 -0400)]
Add fixed fields missing from previous configuration, namely for MAP and SER record types.  Incoporate previous changes for AUT record types from 1040381.

Signed-off-by: Adam Bowling <adbowling@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agolp1110538: DB upgrade; default provider copies
Bill Erickson [Mon, 11 Mar 2013 13:12:43 +0000 (09:12 -0400)]
lp1110538: DB upgrade; default provider copies

Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoDefault ACQ copies use workstation org as owning lib
Bill Erickson [Mon, 4 Feb 2013 20:46:20 +0000 (15:46 -0500)]
Default ACQ copies use workstation org as owning lib

When creating default copies for new lineitems or lineitems added to
POs, use the workstation org unit as the owning lib for each copy.  With
this, it's possible to order items for "here" without having to edit any
single copies.  This also resolves a confusing issue where opening the
copies in the copies grid made it appear that each copy had an
owning_lib applied (via the autofieldwidget) when none was yet set.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoDefault number of ACQ copies per provider
Bill Erickson [Wed, 30 Jan 2013 14:36:17 +0000 (09:36 -0500)]
Default number of ACQ copies per provider

Acquisitions providers have a new "Default # Copies" field.  When the value
is set, this number of copies will be automatically added to each lineitem
added to a purchase order for the provider.  This takes place during PO
creation from a selection list or existing bib record and when a lineitem is
added to an existing purchase order.  If a lineitem already has copies
attached, no default copies are added.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
6 years agoLP#867691: Authority match sets are not working
Mark Cooper [Fri, 12 Oct 2012 23:18:28 +0000 (16:18 -0700)]
LP#867691: Authority match sets are not working

Authority match sets are not supported so hide the option for now.
It's confusing having it there.

[with minor conflict resolution]

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoRemove deprecated, old, unused GridColumnPicker
Lebbeous Fogle-Weekley [Mon, 22 Oct 2012 22:54:18 +0000 (18:54 -0400)]
Remove deprecated, old, unused GridColumnPicker

Spotted by Joseph Lewis in LP #804462.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years ago.gitignore additions for (new) generated files
Bill Erickson [Wed, 6 Mar 2013 18:30:59 +0000 (13:30 -0500)]
.gitignore additions for (new) generated files

Add these to Evergreen .gitignore:

Open-ILS/examples/apache/eg.conf
Open-ILS/examples/apache/eg_startup
Open-ILS/examples/apache/eg_vhost.conf
Open-ILS/src/support-scripts/eg_db_config

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP1147286 - Allow translating more of the staff client portal page.
Pasi Kallinen [Tue, 5 Mar 2013 16:38:57 +0000 (18:38 +0200)]
LP1147286 - Allow translating more of the staff client portal page.

Add translatable strings for image alt-tags and the Search button on
the staff client portal page.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoStamping upgrade for LOC z39.50 target seed data
Ben Shum [Thu, 7 Mar 2013 06:48:46 +0000 (01:48 -0500)]
Stamping upgrade for LOC z39.50 target seed data

Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoUpgrade script for LP#1105225: LOC z39.50 seed data
Bill Erickson [Wed, 6 Mar 2013 18:54:35 +0000 (13:54 -0500)]
Upgrade script for LP#1105225: LOC z39.50 seed data

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1105225: update LOC z39.50 target seed data
Galen Charlton [Fri, 25 Jan 2013 16:35:27 +0000 (11:35 -0500)]
LP#1105225: update LOC z39.50 target seed data

This patch updates the seed data from the target list at
http://www.loc.gov/z3950/lcserver.html#addr.  It also changes the
structure attribute for the 'lccn' search attribute to wordlist,
which means that LCCNs can be searched without having to enter
the leading spaces.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1022582: MARC Exporter includes deleted copies in holdings export
Mark Cooper [Thu, 11 Oct 2012 06:20:02 +0000 (23:20 -0700)]
LP#1022582: MARC Exporter includes deleted copies in holdings export

Added check to filter out callnumbers/copies if deleted.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
6 years agoStamping upgrade for truncate-to-max-fine
Mike Rylander [Tue, 5 Mar 2013 20:13:32 +0000 (15:13 -0500)]
Stamping upgrade for truncate-to-max-fine

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agotruncate fines to max fine amount (LP#1145284)
Jeff Davis [Mon, 4 Mar 2013 21:42:08 +0000 (13:42 -0800)]
truncate fines to max fine amount (LP#1145284)

When the max fine amount is not a multiple of the recurring fine amount,
fines will actually max out at an amount greater than the max fine
value.  This commit adds YAOUS and some simple functionality to
optionally truncate the final amount billed to the max fine amount.

For example, if max fine is $5.00 and recurring fine is $0.30, the 17th
billing will bring the total amount billed to $5.10 (17 x $0.30),
thereby exceeding the max fine amount.  With this commit, if
circ.fines.truncate_to_max_fine is true, the final billing amount will
be reduced and the total amount billed will be $5.00.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1136084: drop silent dependency on 'bsdmainutils' Debian/Ubuntu package
Galen Charlton [Thu, 28 Feb 2013 17:39:40 +0000 (12:39 -0500)]
LP#1136084: drop silent dependency on 'bsdmainutils' Debian/Ubuntu package

colrm is a perfectly good command, but isn't guaranteed to be
present on a minimal Ubuntu system.  This patch replaces ti with
with cut, which is more likely to be present (including on *BSD
servers).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
6 years agoRemove dependency on libreadline5-dev from Debian and Ubuntu.
Jason Stephenson [Mon, 4 Mar 2013 19:10:16 +0000 (14:10 -0500)]
Remove dependency on libreadline5-dev from Debian and Ubuntu.

libreadline5-dev is old and superseded by libreadline-dev.

Also OpenSRF installs libreadline-dev, so we should not have to
install it from Evergreen's Makefile.install.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: move up event listeners in place_hold.js
Ben Shum [Thu, 28 Feb 2013 03:37:31 +0000 (22:37 -0500)]
LP#1086458: move up event listeners in place_hold.js

The preceding two functions need the event listeners to be defined before
use. Move up to prevent errors.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
6 years agoLP#1086458: fix typo
Galen Charlton [Wed, 20 Feb 2013 20:00:55 +0000 (15:00 -0500)]
LP#1086458: fix typo

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: add destructor to caption binding
Galen Charlton [Wed, 30 Jan 2013 16:38:33 +0000 (11:38 -0500)]
LP#1086458: add destructor to caption binding

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: add destructor to messagecatalog
Galen Charlton [Wed, 30 Jan 2013 16:24:21 +0000 (11:24 -0500)]
LP#1086458: add destructor to messagecatalog

Based on patch by Jason Etheridge.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: clean up event listener functions
Galen Charlton [Wed, 30 Jan 2013 15:59:10 +0000 (10:59 -0500)]
LP#1086458: clean up event listener functions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agomove EventListenerList out of global_util.js
Jason Etheridge [Thu, 24 Jan 2013 22:30:26 +0000 (17:30 -0500)]
move EventListenerList out of global_util.js

So that we can more easily pull it into main.xul (which we also do here)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: remove references to windows during cleanup
Galen Charlton [Thu, 24 Jan 2013 20:25:47 +0000 (15:25 -0500)]
LP#1086458: remove references to windows during cleanup

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: clear util.list lists and trees during cleanup
Galen Charlton [Thu, 24 Jan 2013 20:16:52 +0000 (15:16 -0500)]
LP#1086458: clear util.list lists and trees during cleanup

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: add missing cleanup call
Galen Charlton [Thu, 24 Jan 2013 18:07:05 +0000 (13:07 -0500)]
LP#1086458: add missing cleanup call

Thanks to Jason Etheridge for the catch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: clean up after event listeners in circ/patron interface
Galen Charlton [Sat, 19 Jan 2013 05:46:32 +0000 (00:46 -0500)]
LP#1086458: clean up after event listeners in circ/patron interface

Upon window unload, now removes event listeners, both ones explicitly
created by the page JavsScript as well as ones created by
util.list, util.controller, and persist_helper().

The same approach of defining cleanup fnctions used by unload
events can be applied to the rest of the staff client, but
this patch focuses on circulation first.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: add more event listener tracking
Galen Charlton [Thu, 24 Jan 2013 17:27:34 +0000 (12:27 -0500)]
LP#1086458: add more event listener tracking

util.list and util.controller now have cleanup()
methods that can be invoked to unregister the event
listeners they create.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: add way to clean up persist_helper event listeners
Galen Charlton [Thu, 24 Jan 2013 17:02:57 +0000 (12:02 -0500)]
LP#1086458: add way to clean up persist_helper event listeners

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoLP#1086458: add class to manage event listeners
Galen Charlton [Thu, 24 Jan 2013 16:56:30 +0000 (11:56 -0500)]
LP#1086458: add class to manage event listeners

EventListenerList allows one to maintain a list
of event listeners, then remove them all when it's
time to clean up a window.

Usage is:

var list = new EventListenerList();
// attach an event listener
list.add(node, 'command', function(ev) { alert('BOO!'); }, false);
...
// get rid of them
list.removeAll();

Based on an idea by Jason Etheridge.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
6 years agoVersion upgrade script from 2.4-alpha1
Mike Rylander [Fri, 1 Mar 2013 21:13:44 +0000 (16:13 -0500)]
Version upgrade script from 2.4-alpha1

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoUpdated translations for 2.4-alpha1
Mike Rylander [Thu, 28 Feb 2013 20:17:12 +0000 (15:17 -0500)]
Updated translations for 2.4-alpha1

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoStamping upgrade scripts for ingest partitioning
Mike Rylander [Thu, 28 Feb 2013 20:00:14 +0000 (15:00 -0500)]
Stamping upgrade scripts for ingest partitioning

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1066326: protect against flags being entirely missing from config.internal_flag
Galen Charlton [Thu, 28 Feb 2013 19:05:25 +0000 (14:05 -0500)]
LP#1066326: protect against flags being entirely missing from config.internal_flag

Belt, meet suspenders.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1066326: use internal flags; sync with master
Galen Charlton [Thu, 28 Feb 2013 18:30:36 +0000 (13:30 -0500)]
LP#1066326: use internal flags; sync with master

After discussion with Mike Rylander, moved the new flags
to internal flags, as exposing them to the staff client's
global flag admin page could lead to records getting incompletely
ingested without there being an easy way to rectify the problem
from the staff client.

Also, sync up with other recent work on ingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoLP#1066326: Allow component partitioning of ingest
Mike Rylander [Sat, 13 Oct 2012 15:38:55 +0000 (11:38 -0400)]
LP#1066326: Allow component partitioning of ingest

The component parts of the indexing process are fairly flexible. In some
places they can be called with parameters that control the behavior, and
other places will respond to global and/or internal flags.  However, there
is some inconsistency to which parts will react to each mechanism.

Previous to this commit, there was no way to cause ingest to skip specific
parts of the indexing process (search / facet / browse, in particular)
even though the stored procedure responsible for this had the ability to
perform, and parameters for the control of, this behavior.  Now, when any
of the parameters are false (the default, saying "do not skip") it will
check the value of a related global flag and, if enabled, skip that part
of the ingest.

This will allow one to do perform massive, batch, parallel ingests of bib
records, something that was effectively blocked by the way browse ingest
is performed.  By disabling browse ingest during the main record loading,
and then performing only the browse ingest later, one can significantly
reduce the time required to load massive batches of records.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoTPAC: Don't display serial headers without content
Dan Wells [Wed, 16 Jan 2013 20:05:17 +0000 (15:05 -0500)]
TPAC: Don't display serial headers without content

Currently, the TPAC serial display code will print a section
header, then see if there is any content to show.  This causes
headers to show up when they are unnecessary or unwanted.

Now, we only show the header if we have content needing heading.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
6 years agoProvide some level of support for legacy install locations
Dan Scott [Tue, 22 Jan 2013 14:52:52 +0000 (09:52 -0500)]
Provide some level of support for legacy install locations

If someone really wants to keep OpenSRF and Evergreen installed in
/openils, then enable the configure script to find the osrf_config
script and add the library location to the test to prevent it from
failing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoClean-up unused Apache header/library config vars
Dan Scott [Fri, 19 Oct 2012 21:24:50 +0000 (17:24 -0400)]
Clean-up unused Apache header/library config vars

apxs is used to build the Apache modules, so there is no need to
configure the Apache / APR header and library paths.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoReduce hard-coded configure defaults
Dan Scott [Fri, 19 Oct 2012 21:05:53 +0000 (17:05 -0400)]
Reduce hard-coded configure defaults

We can and should be smarter about how we set configuration variables.
Rather than using hard-coded defaults for the OpenSRF header and library
locations, ask osrf_config what values to use.

Also be smarter about how we check for the OpenSRF library as a dependency.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>