Evergreen.git
8 years agofix authentication failure
Galen Charlton [Thu, 6 Oct 2011 17:55:43 +0000 (13:55 -0400)]
fix authentication failure

Ensure that the auth_limit values are read when open-ils.auth
initializes, not during oilsAuthInit().  This solves a problem
observed on brick-based setups where authentication could
incorrectly fail because the drone that processes
open-ils.auth.authenticate.complete didn't have the the block
count value initialized yet.

Also fixed type nit when compare the fail count to the block
limit.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFix "0 holds created" message on successful hold
Thomas Berezansky [Fri, 30 Sep 2011 20:55:05 +0000 (16:55 -0400)]
Fix "0 holds created" message on successful hold

Caused by results not always being an array.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: My List add/remove page anchor fix
Bill Erickson [Thu, 6 Oct 2011 15:42:54 +0000 (11:42 -0400)]
TPac: My List add/remove page anchor fix

Removed /g modifier from URL anchor regex to prevent URLs with multiple
page #-anchors.  This change primarily affects IE which includes #-anchors
in the referer header.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoReally add *entire* selection list to a purchase order, when desired,
Lebbeous Fogle-Weekley [Tue, 4 Oct 2011 21:51:35 +0000 (17:51 -0400)]
Really add *entire* selection list to a purchase order, when desired,

and generally do what a user would expect when, in Acq, the user
executes an operation on "all items".

This addresses LaunchPad bug #810030.

The fundamental issue is that an AcqLiTable, which is used in several
different ways in different interfaces, may be representing items on a
selection list (for example), but it doesn't necessarily know all of the
items that belong to that selection list.  It only knows what it has drawn.

This addresses that deficiency by teaching the getSelected() method
some new tricks so that it can consult the server in the various ways
appropriate to getting a list of /all/ the items on a selection list, a
purchase order, a virtual PO, a set of search results, etc.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix copy-paste-o: "su - postgres" to become postgres
Dan Scott [Wed, 5 Oct 2011 20:30:54 +0000 (16:30 -0400)]
Fix copy-paste-o: "su - postgres" to become postgres

Thanks to sal_ in IRC who caught this nugget!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoREADME: Explicitly identify accounts for commands
Dan Scott [Wed, 5 Oct 2011 17:12:30 +0000 (13:12 -0400)]
README: Explicitly identify accounts for commands

Add a preamble to the beginning listing all of the accounts referenced
in the instructions (Linux accounts, PostgreSQL accounts, Evergreen
administrator accounts). Also move the Developer Instructions to the
start to follow the natural order of operations.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAvoid collecting facet data for non-facet fields
Bill Erickson [Wed, 5 Oct 2011 19:16:17 +0000 (15:16 -0400)]
Avoid collecting facet data for non-facet fields

If a config.metabib_field (Admin -> Server Admin -> MARC Search/Facet
Fields) starts out as a facet field but is later changed, data for that
facet can still bubble up since it has already been extracted.  This
patch prevents facets for config.metabib_field entries whose
facet_field=false from getting collected/cached for search results.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac: jump to details page on single hit
Bill Erickson [Tue, 4 Oct 2011 19:25:00 +0000 (15:25 -0400)]
TPac: jump to details page on single hit

When enabled, any time an OPAC search yields 1 result, the user will be
redirected to the record detail page for that result.  This change adds
2 new org unit settings, one to control the behavior in the staff
client, the other to control the public catalog.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFix typo in lang.dtd: "instantenous"
Dan Scott [Wed, 5 Oct 2011 03:17:39 +0000 (23:17 -0400)]
Fix typo in lang.dtd: "instantenous"

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Fix es-ES illegal use of '%' in lang.dtd
Dan Scott [Wed, 5 Oct 2011 03:04:15 +0000 (23:04 -0400)]
i18n: Fix es-ES illegal use of '%' in lang.dtd

The '%' character is used to include previously defined blocks in DTD
files; would be nice if translate-toolkit gave a more obvious error to
alert us to this rather than saying the en-US doesn't validate and
dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSlightly updated about.html for rel_2_1
Dan Scott [Tue, 4 Oct 2011 18:40:44 +0000 (14:40 -0400)]
Slightly updated about.html for rel_2_1

Not sure we want to actually keep listing individuals in this file -
there's a lot more credit to spread around - but at least I can bring it
somewhat up to date with current info.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agopin version for upgrade script
Jason Etheridge [Tue, 4 Oct 2011 18:22:15 +0000 (14:22 -0400)]
pin version for upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoUnwrapped upgrade script for security lockdown
Thomas Berezansky [Mon, 15 Aug 2011 13:04:13 +0000 (09:04 -0400)]
Unwrapped upgrade script for security lockdown

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoRequire permission or pref to debug in client
Thomas Berezansky [Mon, 15 Aug 2011 12:59:31 +0000 (08:59 -0400)]
Require permission or pref to debug in client

Disables all debug functions I know of unless:

1 - You have new DEBUG_CLIENT permission (after login)

This should work even on operator change.
Once a given debug interface is open you can change operator back.

2 - You have a client with the debug preference enabled

This causes the client in all places I touched to think you have DEBUG_CLIENT
This also allows debugging *before* login, including in the Standalone interface.

Debug functions I know of:

Debug box on login page (already protected by pref)
Debug items in Admin menu
    Venkman
    Javascript Shells
    Inspector
    Chrome List
CTRL+SHIFT+F7 debug box in overlays

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoClear password from password_prompt post-login
Thomas Berezansky [Fri, 12 Aug 2011 13:17:46 +0000 (09:17 -0400)]
Clear password from password_prompt post-login

Otherwise it remains as the plain text value.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoi18n: Fix ru-RU lang.dtd problem
Dan Scott [Tue, 4 Oct 2011 18:13:43 +0000 (14:13 -0400)]
i18n: Fix ru-RU lang.dtd problem

No ampersands at the end of a string! Breaks moz2po horribly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agopin version for upgrade script
Jason Etheridge [Tue, 4 Oct 2011 17:20:41 +0000 (13:20 -0400)]
pin version for upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoSwitch to Modal printing
Thomas Berezansky [Mon, 12 Sep 2011 16:43:59 +0000 (12:43 -0400)]
Switch to Modal printing

Prevents an OS-level race condition on window focus.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoUnwrapped upgrade script for print.custom_js_file
Thomas Berezansky [Wed, 24 Aug 2011 15:32:15 +0000 (11:32 -0400)]
Unwrapped upgrade script for print.custom_js_file

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoRemove in-template javascript, add script files
Thomas Berezansky [Wed, 24 Aug 2011 15:31:59 +0000 (11:31 -0400)]
Remove in-template javascript, add script files

Adds support for a print_custom.js file and an org unit specified file.

If either exists and contains a print_custom function it will be called
before printing to allow for DOM manipulation.

If neither exists the print_win.js file will call all functions it has
defined.

In addition, if any code sets do_print to false the window will close
instead of attempting to print.

The print_custom function will receive the type of template used, if any.
This only applies to "Receipt Template" based print jobs, and the type in
question is the "Type" that shows in the template editor.

Functions defined in print_win.js:

print_init
    Main function, checks for print_custom and does final printing

print_do_sums
    Does summing of values.

print_check_alt
    Does swapping out of template blocks with display:none styling.

print_check_noprint
    Disables printing under certain circumstances.

For more information about usage of the print_do_sums, print_check_alt,
and print_check_noprint functions check the comments in print_win.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoStamped upgrade script for username limit settings
Bill Erickson [Tue, 4 Oct 2011 17:00:59 +0000 (13:00 -0400)]
Stamped upgrade script for username limit settings

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoUnwrapped, badly named upgrade script
Thomas Berezansky [Mon, 26 Sep 2011 14:19:20 +0000 (10:19 -0400)]
Unwrapped, badly named upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoWording change on username error
Thomas Berezansky [Sun, 25 Sep 2011 02:37:22 +0000 (22:37 -0400)]
Wording change on username error

Add that they may be restricted by policy.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoUsername Change Limits
Thomas Berezansky [Sun, 25 Sep 2011 02:31:41 +0000 (22:31 -0400)]
Username Change Limits

Default is "Only allowed to change username if it looks like a barcode".

There is a "Lock Username Changes" option to disallow username changing via
the OPAC entirely, useful if syncing usernames to an outside source.

There is also a username change limit disabling option that, if enabled and
the Lock option is disabled, allows the previous behaviour of unlimited
username changes.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoUsername Rules
Thomas Berezansky [Sun, 25 Sep 2011 01:50:15 +0000 (21:50 -0400)]
Username Rules

In TPac, enforce the "username can't look like a barcode" rule.
Add new setting for username validation. If set, usernames must match.
Add patron registration checks for usernames:
    No spaces
    If set, can look like a barcode (initial/no username picked)
    If set, can look like a username
    If both set, must look like one of them

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRequire password to change email/username
Thomas Berezansky [Sat, 24 Sep 2011 20:51:20 +0000 (16:51 -0400)]
Require password to change email/username

Alter backend to check password period, not just for password changes.
Add form elements for asking for current password to JSPac and TPac.
Add handling for said form elements where needed.
Add handling for "incorrect password" events in TPac.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPac: Default Password Strength Rule
Thomas Berezansky [Sat, 24 Sep 2011 20:28:29 +0000 (16:28 -0400)]
TPac: Default Password Strength Rule

Every other password interface seems to have it.
Implemented as a single regex in this case.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoWhen workstation is invalid request a new seed
Thomas Berezansky [Mon, 12 Sep 2011 17:33:03 +0000 (13:33 -0400)]
When workstation is invalid request a new seed

The original one may no longer be valid

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMake more auth values configurable
Thomas Berezansky [Thu, 1 Sep 2011 20:41:33 +0000 (16:41 -0400)]
Make more auth values configurable

Amount of time seed is valid
Amount of time to keep failure count in memcache since last auth event
Number of failures before locking out auth attempts

Also, remove seed from memcache once it has been used once.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoBrute Force protection for authentication
Thomas Berezansky [Tue, 30 Aug 2011 15:55:35 +0000 (11:55 -0400)]
Brute Force protection for authentication

Count auth failures in memcache.
If 10+ have occurred cause failure.

After 90 seconds of no activity counter resets.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agolink asset.copy_template.status to config.copy_status in the IDL
Lebbeous Fogle-Weekley [Fri, 30 Sep 2011 17:37:58 +0000 (13:37 -0400)]
link asset.copy_template.status to config.copy_status in the IDL

If nothing else, this provides a dropdown for status in the copy
template editor (the one for Serials, under the admin menus, not the
one on the copy editing interface).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoMake sure baseline schema is up to date
Mike Rylander [Tue, 4 Oct 2011 13:22:03 +0000 (09:22 -0400)]
Make sure baseline schema is up to date

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix update_db.sh to set eg_version correctly
Dan Scott [Tue, 4 Oct 2011 03:35:35 +0000 (23:35 -0400)]
Fix update_db.sh to set eg_version correctly

psql wants --set=VARNAME=VALUE, we had -set VARNAME=VALUE; tested this
fix and it works with PostgreSQL 9.0.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: Fix searchbar typo by closing div
Dan Scott [Tue, 4 Oct 2011 03:22:27 +0000 (23:22 -0400)]
TPAC: Fix searchbar typo by closing div

Nesting of divs was thrown off, resulting in the footer appearing in the
wrong place in search results / record display / etc, with the result
that the footer inherited the 974px width instead of full 100% width.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoLP865817: Fix Located URI visibility test
Dan Scott [Tue, 4 Oct 2011 02:34:47 +0000 (22:34 -0400)]
LP865817: Fix Located URI visibility test

Wrapped upgrade script for LP865817.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoCorrect Located URI visiblity
Mike Rylander [Mon, 3 Oct 2011 19:01:26 +0000 (15:01 -0400)]
Correct Located URI visiblity

Located URIs should be visible when they exist at the search context org unit
or an ancestor thereof.  However, before the change embodied in this commit,
they effectively acted exactly like copies, making records visible anywhere
within the context+depth range.

An example, using the stock example OU hierarchy:

 * Before this change, a Located URI with an owner of BR1 would cause its
record to show up in a search at (or scoped to via a depth parameter) BR1,
SYS1 or CONS.

 * Before this change, a Located URI with an owner of SYS1 would NOT cause its
record to show up in a search at (or scoped to via a depth parameter) BR1!

 * After this change, a Located URI with an owner of BR1 will cause its record
to show up only in a search with a context OU of BR1, irrespective of depth
scoping.

 * After this change, a Located URI with an owner of SYS1 WILL cause its
record to show up in a search with a context OU of BR1 or SYS1, regardless of
depth scoping.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPAC: No need for a 26px padding on the header bottom
Dan Scott [Tue, 4 Oct 2011 02:03:00 +0000 (22:03 -0400)]
TPAC: No need for a 26px padding on the header bottom

26px on the bottom of the header was giving a bit too much space to the
header.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: Replace dashboard images with CSS
Dan Scott [Tue, 4 Oct 2011 01:58:17 +0000 (21:58 -0400)]
TPAC: Replace dashboard images with CSS

Also gets rid of a number of tables and a bunch of CSS definitions with
hard-coded widths that will cause trouble when longer translated terms
get dropped into place.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTpac: expand facet display fix
Bill Erickson [Mon, 3 Oct 2011 15:52:34 +0000 (11:52 -0400)]
Tpac: expand facet display fix

When only one facet is collapsed, make sure we can expand it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: Facets on results page
Bill Erickson [Fri, 30 Sep 2011 20:01:22 +0000 (16:01 -0400)]
TPac: Facets on results page

Show search facets along the left side of the results page.  Clicking on
a facet re-runs the current search with the  new facet appeneded.
Selected facets are styled to indicate they are selected.  Clicking on a
selected facet removes that facet from the set of selected facets (i.e.
it backs out the facet).

TODO: update CSS to match default Evergreen skin

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoJSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ...
Lebbeous Fogle-Weekley [Mon, 3 Oct 2011 20:03:00 +0000 (16:03 -0400)]
JSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ...

... when search scope would have it so.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTweak the tab shape in TT OPAC
Michael Peters [Mon, 3 Oct 2011 20:07:30 +0000 (16:07 -0400)]
Tweak the tab shape in TT OPAC

A slight modification to the "tab" elements throughout the OPAC to make them look more like tabs on a file folder.  I
found the rounded off bottoms less attractive, so I flattened them out to flow more evenly with the rest of the page.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoHave TTPac utilize gradient friendly, transparent PNG files for the Evergreen logo
Michael Peters [Mon, 3 Oct 2011 14:47:22 +0000 (10:47 -0400)]
Have TTPac utilize gradient friendly, transparent PNG files for the Evergreen logo

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPAC: Simple CSS gradients for the header/footer
Dan Scott [Mon, 3 Oct 2011 02:59:28 +0000 (22:59 -0400)]
TPAC: Simple CSS gradients for the header/footer

Firefox, Safari, Chrome, Opera, and the Android browser support
gradients. Use them. iOS 5 will support gradients. IE does not,
naturally, but support is promised for IE 10.

Including better IE support.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPAC: Remove the printnav bar from all screens
Dan Scott [Tue, 20 Sep 2011 13:20:06 +0000 (09:20 -0400)]
TPAC: Remove the printnav bar from all screens

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoRevamp the search bar to a narrative, single-line style
Dan Scott [Tue, 20 Sep 2011 13:19:41 +0000 (09:19 -0400)]
Revamp the search bar to a narrative, single-line style

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAdd the remaining extras back to the record details
Dan Scott [Tue, 20 Sep 2011 03:09:51 +0000 (23:09 -0400)]
Add the remaining extras back to the record details

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPAC: and then there were series
Dan Scott [Tue, 20 Sep 2011 02:49:55 +0000 (22:49 -0400)]
TPAC: and then there were series

Also, tighten up spacing considerably.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoMove the copies up higher
Dan Scott [Mon, 19 Sep 2011 23:55:08 +0000 (19:55 -0400)]
Move the copies up higher

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoRemove "Expand all extras" as there are fewer extras to expand
Dan Scott [Mon, 19 Sep 2011 23:43:28 +0000 (19:43 -0400)]
Remove "Expand all extras" as there are fewer extras to expand

Cleaner.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoGoing for the Jungle skin feel (like Amazon)
Dan Scott [Mon, 19 Sep 2011 22:59:25 +0000 (18:59 -0400)]
Going for the Jungle skin feel (like Amazon)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPac: propagate searches to advanced search page
Bill Erickson [Fri, 30 Sep 2011 16:19:35 +0000 (12:19 -0400)]
TPac: propagate searches to advanced search page

The link that takes users to the advanced searc page now propagates
any existing (well, all) search URL params.  The change required some
minor augmentation to the code that builds the advanced search form.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoLP740320: Make <enter> submit the new bookbag dialog
Dan Scott [Fri, 30 Sep 2011 03:27:19 +0000 (23:27 -0400)]
LP740320: Make <enter> submit the new bookbag dialog

For the keyboard jockeys out there - if the enter key doesn't submit,
the UI reviewer will not commit.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoInitial dialog isn't quite wide enough, here's a hackish way to fix it
James Fournie [Fri, 26 Aug 2011 16:23:53 +0000 (09:23 -0700)]
Initial dialog isn't quite wide enough, here's a hackish way to fix it

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoShould probably use a more common button rather than the one for the advanced search
James Fournie [Fri, 26 Aug 2011 16:19:14 +0000 (09:19 -0700)]
Should probably use a more common button rather than the one for the advanced search

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoThis makes more sense as an alert; the Dojo dialog has no button which is not user...
James Fournie [Fri, 26 Aug 2011 15:56:44 +0000 (08:56 -0700)]
This makes more sense as an alert; the Dojo dialog has no button which is not user-friendly.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMarkup-based dijit.Dialog implementation, inspired by and based on a patch from Josep...
Mike Rylander [Tue, 2 Aug 2011 16:42:53 +0000 (12:42 -0400)]
Markup-based dijit.Dialog implementation, inspired by and based on a patch from Joseph Lewis in https://bugs.launchpad.net/evergreen/+bug/787162

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge en-GB translation from Launchpad
Dan Scott [Fri, 30 Sep 2011 02:22:14 +0000 (22:22 -0400)]
i18n: Merge en-GB translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge en-CA translation from Launchpad
Dan Scott [Fri, 30 Sep 2011 02:14:50 +0000 (22:14 -0400)]
i18n: Merge en-CA translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge pt-BR translation from Launchpad
Dan Scott [Fri, 30 Sep 2011 01:57:24 +0000 (21:57 -0400)]
i18n: Merge pt-BR translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge ru-RU translation from Launchpad
Dan Scott [Fri, 30 Sep 2011 01:51:03 +0000 (21:51 -0400)]
i18n: Merge ru-RU translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years ago i18n: Merge Armenian (hy-AM) translation from Launchpad
Dan Scott [Thu, 29 Sep 2011 20:22:06 +0000 (16:22 -0400)]
 i18n: Merge Armenian (hy-AM) translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge cs-CZ translation from Launchpad
Dan Scott [Thu, 29 Sep 2011 20:13:52 +0000 (16:13 -0400)]
i18n: Merge cs-CZ translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge es-ES translation from Launchpad
Dan Scott [Thu, 29 Sep 2011 19:51:22 +0000 (15:51 -0400)]
i18n: Merge es-ES translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoi18n: Merge fr-CA translation from Launchpad
Dan Scott [Thu, 29 Sep 2011 19:39:02 +0000 (15:39 -0400)]
i18n: Merge fr-CA translation from Launchpad

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoModified spine_labels.js to retain UTF-8 encoding
Liam Whalen [Fri, 16 Sep 2011 12:52:08 +0000 (08:52 -0400)]
Modified spine_labels.js to retain UTF-8 encoding

Dan Wells posted a fix to the DEV list for receipt printing that allowed the
receipt printer to print UTF-8 characters.  I used the ideas in that fix to
modify spine_labels.js.  In spine_labels.js, the url passed to the preview in
preview_xul_192 was encoding the url with the javascript encode() function.
This function does not preserve UTF-8 encodings.  I changed the function to
encodeURIComponent, and UTF-8 characters are now displayed properly by the
spine label printer code.

Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdded missing Penalty module import for AssetCommon
Bill Erickson [Thu, 29 Sep 2011 15:57:46 +0000 (11:57 -0400)]
Added missing Penalty module import for AssetCommon

The lack of import primarily affected the Action/Trigger MarkItemLost
reactor, which does not already import OpenILS::Utils::Penalty directly
or indirectly.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRemove an installation step: Listen 443 uncommenting
Dan Scott [Thu, 29 Sep 2011 03:06:19 +0000 (23:06 -0400)]
Remove an installation step: Listen 443 uncommenting

Every distribution known to man ships Apache listening on port 443, so
installers always have to comment out the "Listen 443" directive - so
why not just comment it out ourselves and save a step in the
installation instructions?

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: move google analytics import to head
Bill Erickson [Wed, 28 Sep 2011 21:23:13 +0000 (17:23 -0400)]
TPac: move google analytics import to head

Google Analytics documention recommends loading the JS in the page
<head>.

http://www.google.com/support/googleanalytics/bin/answer.py?answer=174090

Use as directed by default.

Also, moved the JS loading chunk to its own template to ease override by
those who do not wish to use as directed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoA slight modification to prevent clipping in the EDI Accounts interface
Michael Peters [Wed, 28 Sep 2011 13:09:33 +0000 (09:09 -0400)]
A slight modification to prevent clipping in the EDI Accounts interface

Just a few tweaks via CSS to make sure the footer notes don't clip off part of the main grid.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoProvide proper hrefs for links back from report debugging pages
Mike Rylander [Wed, 28 Sep 2011 19:45:36 +0000 (15:45 -0400)]
Provide proper hrefs for links back from report debugging pages

Reimplementation of a fix provided by Michael Peters.  The originally submitted
patch included several fixes provided by an unrelated patch, and a regression
in build-time embedded tokens.

Original branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/clark_kent_back_links

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP856567: Mark HTML report output as Unicode-encoded
Dan Scott [Thu, 22 Sep 2011 16:51:22 +0000 (12:51 -0400)]
LP856567: Mark HTML report output as Unicode-encoded

Non-ASCII characters in report ouput that has been generated in HTML
format appears to be corrupted when viewed in a browser. This can be
manually corrected by switching the "Encoding" browser option, but it
would be better to include <meta charset='utf-8'> in the output HTML to
tell the browser directly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMFHD compression fails with pattern-less captions
Dan Wells [Tue, 27 Sep 2011 16:22:38 +0000 (12:22 -0400)]
MFHD compression fails with pattern-less captions

The current code assumes that if you try to compress a range of
MFHD holdings, you actually have the necessary pattern information.
This commit introduces a very basic check to avoid the most common
failure case.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTeach update_db.sh to find the currently installed version number via eg_config and...
Mike Rylander [Tue, 27 Sep 2011 15:46:03 +0000 (11:46 -0400)]
Teach update_db.sh to find the currently installed version number via eg_config and supply that when applying updates

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoLP857460: Get the generic class scheme when adding vols
Dan Scott [Fri, 23 Sep 2011 14:55:28 +0000 (10:55 -0400)]
LP857460: Get the generic class scheme when adding vols

In a default Evergreen instance, in the "Add Volumes" interface for a
bib record with both LC and Dewey call numbers, the list of call numbers
from which you can select appears to be limited to Dewey, even though
the "Bib Call #" field is populated with an LC call number.

The problem is that here we're grabbing the first entry from the
asset.call_number_classification table, and you might expect that to be
the "Generic" entry - however, it turns out to be the "Dewey" entry
because the entries are ordered alphabetically by .name(), not by
database ID. (You can test this be changing the name of "Dewey" to
"Vicious" and see that the "Generic" entry is chosen instead).

This commit changes the process to first search the acnc array for a
name() = "Generic"; and then if we don't find that, fall back to the
first entry in the classification scheme.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoRemoved old vandelay config from sample apache config
Bill Erickson [Mon, 26 Sep 2011 21:15:25 +0000 (17:15 -0400)]
Removed old vandelay config from sample apache config

Bye, bye xmlent

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPac: Respect OU opac_visible flags
Thomas Berezansky [Mon, 26 Sep 2011 14:04:35 +0000 (10:04 -0400)]
TPac: Respect OU opac_visible flags

Unless we appear to be in staff mode. Then continue to ignore them.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: Fix bolding of bad email/username
Thomas Berezansky [Sat, 24 Sep 2011 23:03:27 +0000 (19:03 -0400)]
TPac: Fix bolding of bad email/username

HTML filter the variable, not the entire language string.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: Hide CC Payment info when not enabled
Thomas Berezansky [Sat, 24 Sep 2011 18:55:18 +0000 (14:55 -0400)]
TPac: Hide CC Payment info when not enabled

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac Fixes - Missing Quotes
Thomas Berezansky [Sat, 24 Sep 2011 18:23:00 +0000 (14:23 -0400)]
TPac Fixes - Missing Quotes

Start off real easy, add some missing quotes.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Dan Wells [Mon, 26 Sep 2011 18:29:30 +0000 (14:29 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

8 years agoStamping Upgrade Script for Suppress Transits
Dan Wells [Mon, 26 Sep 2011 18:23:31 +0000 (14:23 -0400)]
Stamping Upgrade Script for Suppress Transits

In addition to stamping, this commit also makes a few trivial
wording changes.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoCreate git .mailmap file for Evergreen
Jeff Godin [Wed, 14 Sep 2011 16:41:51 +0000 (12:41 -0400)]
Create git .mailmap file for Evergreen

This is an initial .mailmap file for Evergreen.

The .mailmap file is used by git-shortlog to "coalesce together
commits by the same person".

In the output of git-shortlog, this eliminates duplicate entries
such as the username@UUID entries from the svn to git migration.

Compare "git shortlog -nes" with and without this .mailmap

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoUnwrapped Suppress Transits upgrade script
Thomas Berezansky [Fri, 23 Sep 2011 23:30:20 +0000 (19:30 -0400)]
Unwrapped Suppress Transits upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoSuppress Transits
Thomas Berezansky [Wed, 14 Sep 2011 01:50:11 +0000 (21:50 -0400)]
Suppress Transits

Add two new OU settings:

circ.transit.suppress_hold
circ.transit.suppress_non_hold

If a transit would be generated between the current library and another and
the appropriate setting is set for both end with the same value the transit
will be suppressed. If either end is set to an empty string then transit
suppression will be disabled, even if both ends are set to an empty string.

In addition, transits from other locations will be received when their
destination shares suppression with the current library.

circ.transit.suppress_hold will cause holds to go to the hold shelf instead
of into transit when in effect. Non-hold transits should not check it. This
should be useful when multiple parts of a library share a hold shelf, but
are split on the org tree.

circ.transit.suppress_non_hold will cause items to reshelve instead of
going into transit. Hold transits should not check it. This should be
useful when multiple parts of a library are in the same building and have
no need to transit items before reshelving/cataloging.

In order to suppress *all* transits both settings need to be set.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoTPAC: Fix for staff UI with multiple MFHD records
Dan Scott [Mon, 26 Sep 2011 17:34:00 +0000 (13:34 -0400)]
TPAC: Fix for staff UI with multiple MFHD records

XUL's JavaScript doesn't mind trailing commas on an array,
but really doesn't like an array in which the elements aren't separated
by commas :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: MFHD staff client actions integration
Bill Erickson [Mon, 26 Sep 2011 16:56:17 +0000 (12:56 -0400)]
TPac: MFHD staff client actions integration

Populdate the necessary window.mfhdDetails data for the staff client and
fire the mfhdDrawn event

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoStamping upgrade script for EDI cleanup
Mike Rylander [Mon, 26 Sep 2011 16:18:03 +0000 (12:18 -0400)]
Stamping upgrade script for EDI cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSome EDI translation fixes for troublesome input characters
Lebbeous Fogle-Weekley [Mon, 19 Sep 2011 17:19:22 +0000 (13:19 -0400)]
Some EDI translation fixes for troublesome input characters

This attempts to address enough of the issues in
https://bugs.launchpad.net/evergreen/+bug/812593 to move forward.

When the ? character appears in lineitem attributes for a PO that we
send off for EDI translation, the translator fails if that ? is the last
character of the string.  This commit avoids that situation.

This commit also removes any Unicode characters from the JEDI (the input
to the translator process), as they're not going to make it to the
EDIFACT output anyhow, and will just confound the translator.

This commit also pre-escapes quotation marks in lineitem attributes so
that we don't produce invalid JSON for our JEDI.

This commit also destroys the death star.

Seriously, the right way to fix some of the issues people have had is
for somebody to learn Ruby and to address them either in edi_webrick.rb, in
edi4r, or in openils-mapper (wherever the issues may be).  Working on
that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPac: Page through search results on details page
Bill Erickson [Wed, 14 Sep 2011 18:25:41 +0000 (14:25 -0400)]
TPac: Page through search results on details page

Consistent with jspac, when you land on a record details page and you
got there from doing a search, let the user page through the search
results directly on the record detail page.

This also includes the necessary JS callbacks to support paging in the
staff client.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoperl-parent prerequisite for RHEL. hope it's fine for centos :)
Jason Etheridge [Mon, 26 Sep 2011 15:04:12 +0000 (11:04 -0400)]
perl-parent prerequisite for RHEL. hope it's fine for centos :)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoTPAC: Add some style to MFHD holdings summaries
Dan Scott [Mon, 19 Sep 2011 02:27:00 +0000 (22:27 -0400)]
TPAC: Add some style to MFHD holdings summaries

Simple grey background for the holdings summary header for each record;
add a TBODY element to the holdings table for validity; offset the MFHD
type by 1em to group entries under each holdings location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: Give MFHD summaries OU / depth awareness
Dan Scott [Mon, 19 Sep 2011 01:12:23 +0000 (21:12 -0400)]
TPAC: Give MFHD summaries OU / depth awareness

Rather than returning all results and filtering on the client-side, as
we're currently doing in the JSPAC, teach the
open-ils.search.serial.record.bib.retrieve method to accept optional OU
& OU depth arguments and do the filtering in the query; cuts down on
network traffic and should be generally more efficient.

Note that in the absence of an explicit "depth" CGI param,
EGCatLoader/Record currently defaults to a depth of "0"; we could
teach it to look up & cache the depth of the "loc" param for the sake of
convenience & arguably more accuracy.

Also note that the sub/dist serial approach probably needs to be taught
similar method-side filtering, but I hope more knowledgeable brains will
work out what should happen with ssub.holding_lib / sdist.owning_lib.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPAC: tentative MFHD display steps
Dan Scott [Sun, 18 Sep 2011 05:37:37 +0000 (01:37 -0400)]
TPAC: tentative MFHD display steps

Retrieve and display MFHD records in the TPAC, piggybacking on the
"Issues" twisty section.

TODO: Take org_unit & depth into account when deciding which MFHD
records to display. Right now we're just showing all of them.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agolp859190: make marc_stream_import always import non-matches
Galen Charlton [Sun, 25 Sep 2011 20:55:38 +0000 (16:55 -0400)]
lp859190: make marc_stream_import always import non-matches

Fixes regression of (implicit, undocumented) functionality
introduced in commit da3a45344205.  Current use case for
the streaming MARC importer for OCLC Connexion exports assumes
that non-matching records should always be added.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFix: Current Bills thinks it is Bill History
Jeff Godin [Wed, 21 Sep 2011 20:41:19 +0000 (16:41 -0400)]
Fix: Current Bills thinks it is Bill History

This fixes LP 855894: Bills interface calls itself Bill History,
uses bills_historical receipt template

https://bugs.launchpad.net/evergreen/+bug/855894

At some point in development, the Current Bills and the Bill History
interface were in a unified file, with an xul_param of "current" used
to switch between the two.

Nothing currently sets the xul_param "current", so the Current Bills
interface (bill2.xul and bill2.js) was improperly:

* not hiding the xact_finish column
* using a caption label of "Bill History"
* using the bills_historical receipt template

The Bill History interface was okay -- "not current" was the default.

This commit removes the tests for xul_param('current') and uses the
appropriate code for each interface.

// this code in both bill2.js and bill_history.js:
var template = 'bills_historical';
if (xul_param('current')) template = 'bills_current';

// becomes:
var template = 'bills_current';    // in bill2.js
var template = 'bills_historical'; // in bill_history.js

Also: added missing staff.patron.bill_interface.caption.label entity

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoRemove the old bills interface.
Jeff Godin [Tue, 20 Sep 2011 18:41:10 +0000 (14:41 -0400)]
Remove the old bills interface.

Remove the old bills interface and references to it.

see https://bugs.launchpad.net/evergreen/+bug/854951

Also remove the XUL_PATRON_BILL_ALTERNATE_VIEW constant and the
bills_main_view receipt template, as they were only referenced
in bills.js.

The bills_main_view template will still persist in existing
workstation configurations until such time as we have code to
remove unused templates.

I made no effort to remove strings which may have only been used
by the old bills interface.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoTPac: repair IE check-all action on transaction list
Bill Erickson [Thu, 22 Sep 2011 20:55:50 +0000 (16:55 -0400)]
TPac: repair IE check-all action on transaction list

IE does not respond to 'onchange' for checkboxes?  Use onclick
instead...

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamped upgrade script for ACQ fund view repairs
Bill Erickson [Thu, 22 Sep 2011 15:10:09 +0000 (11:10 -0400)]
Stamped upgrade script for ACQ fund view repairs

At the heart of this change is the need to force acq.fund_debit_total to
return exactly 1 row per fund, instead of 1 per fund + encumbrance
value.  However, such a change required rearranging a number of
dependent views.

Also added acq.fund_spent_balance to the set of views that needs
dropping and re-building.

Minor SQL format change to match surrounding code in schema file

See also https://bugs.launchpad.net/evergreen/+bug/800477

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAddresses LP#800477 where some acq views calculate the totals incorrectly or in unexp...
James Fournie [Mon, 19 Sep 2011 23:01:01 +0000 (16:01 -0700)]
Addresses LP#800477 where some acq views calculate the totals incorrectly or in unexpected ways.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>