Evergreen.git
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Bill Erickson [Fri, 5 Aug 2011 18:58:50 +0000 (14:58 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

8 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Bill Erickson [Fri, 5 Aug 2011 17:53:54 +0000 (13:53 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

8 years agoSpeed up t-pac record details copy retrieval
Bill Erickson [Fri, 5 Aug 2011 17:52:17 +0000 (13:52 -0400)]
Speed up t-pac record details copy retrieval

Using JOIN filters instead of WHERE clauses, drastically speed up
paged/sorted copy retrieval, particularly for items with many copies, in
the record details page.

Thanks for the suggestions, Mike.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoThis doesn't need to be lying around any more
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 17:32:55 +0000 (13:32 -0400)]
This doesn't need to be lying around any more

Its purpose was superceded by another upgrade script in master.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agomrpeters caught this; wrong variable fed to error dialog
Jason Etheridge [Fri, 5 Aug 2011 02:27:45 +0000 (22:27 -0400)]
mrpeters caught this; wrong variable fed to error dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoRepaired copy private/public note vandelay bug
Bill Erickson [Thu, 4 Aug 2011 20:46:54 +0000 (16:46 -0400)]
Repaired copy private/public note vandelay bug

Previously, all copy notes imported through vandelay were coming in as
public copy notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoRevert "remove the unfinished id_as_barcode functionality"
Thomas Berezansky [Thu, 4 Aug 2011 19:25:08 +0000 (15:25 -0400)]
Revert "remove the unfinished id_as_barcode functionality"

This reverts commit 5fa01d69f7374c0c8710db4a951edb80ed5ae733.

Bit too soon, actually. Staff client still uses the function to
verify credentials.

Maybe I skipped this the first time on purpose.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoremove the unfinished id_as_barcode functionality
Jason Etheridge [Sun, 31 Jul 2011 04:01:31 +0000 (00:01 -0400)]
remove the unfinished id_as_barcode functionality

remove the unfinished id_as_barcode setting for open-ils.actor and remove unused open-ils.actor.user.retrieve_id_by_barcode_or_username method

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoStamped upgrade script for ACQ_INVOICE_REOPEN permission addition
Mike Rylander [Thu, 4 Aug 2011 19:10:36 +0000 (15:10 -0400)]
Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUpgrade script for LP818311 branch.
Jason Stephenson [Thu, 4 Aug 2011 14:13:56 +0000 (10:13 -0400)]
Upgrade script for LP818311 branch.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#818311: ACQ_INVOICE_REOPEN is missing
Michael Peters [Thu, 4 Aug 2011 12:59:15 +0000 (08:59 -0400)]
LP#818311:  ACQ_INVOICE_REOPEN is missing

This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions
Administrator user.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSpeed up holds history retrieval
Bill Erickson [Thu, 4 Aug 2011 19:01:09 +0000 (15:01 -0400)]
Speed up holds history retrieval

Consistent w/ circ history retrieval, use the longer column 'transform'
stored proc invocation to limit retrieval to historical holds IDs
instead of entire objects, which are later fetched/fleshed anyway.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFix i18n build
Dan Scott [Fri, 29 Jul 2011 20:09:58 +0000 (16:09 -0400)]
Fix i18n build

Two problems thrown at the i18n build:

  * $$ quoting is not understood by db-seed-i18n.py; simple approach is
    to use standard single-quote escaping of the single-quote in
    950.data.seed-values.sql (warning: this might lead to other problems
    with the regular expression in db-seed-i18n.py)
  * authority.js includes Unicode values (shock!) and so we must treat
    the incoming strings as unicode() instead of plain old str()

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFaster T-pac circ history retrieval
Bill Erickson [Thu, 4 Aug 2011 18:53:36 +0000 (14:53 -0400)]
Faster T-pac circ history retrieval

* Take advantage of the new default sorting behavior of
action.usr_visible_circs to perform limit/offset within the DB instead
of fetching the whole circ history in the mod_perl code and sorting
through it.

* Also use the  more powerful/verbose column transform syntax for
calling stored procedures to retrieve only the historical circ IDs
instead of the full circ objects, since we are re-fetching fleshed circ
objects later in the code.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFix staff client Clear Expired Hold Shelf action
Jason Etheridge [Wed, 3 Aug 2011 04:44:41 +0000 (00:44 -0400)]
Fix staff client Clear Expired Hold Shelf action

Accomodate an API change.  FIXME: See if can remove some of the redundant and/or
un-needed data being sent over the wire.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoOnly update MARC on full entry of fixed fields
Thomas Berezansky [Thu, 28 Jul 2011 15:04:36 +0000 (11:04 -0400)]
Only update MARC on full entry of fixed fields

AKA:
Lang is 3 characters long. Entering 1 character would cause focus to leave.
MARC would also update incorrectly.

This only triggers the update when the full 3 characters are entered.

This not only prevents issues with catalogers editing multi-character fixed
fields but also makes it less likely they accidentally corrupt the records.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoStamped upgrade script for schema.circ_holds_history_repairs
Mike Rylander [Thu, 4 Aug 2011 18:36:17 +0000 (14:36 -0400)]
Stamped upgrade script for schema.circ_holds_history_repairs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoRepair holds history func; sort circ history desc.
Bill Erickson [Thu, 4 Aug 2011 17:49:11 +0000 (13:49 -0400)]
Repair holds history func; sort circ history desc.

Update holds history to use oils_json_to_text instead of
oils_json_to_string, which does not exist.

Sort circ history newest to oldest by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix title/author sort. Use SVF 'titlesort'/'authorsort'
Bill Erickson [Thu, 4 Aug 2011 15:47:47 +0000 (11:47 -0400)]
Fix title/author sort.  Use SVF 'titlesort'/'authorsort'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRepaired qtype bug introduced w/ bool searching
Bill Erickson [Thu, 4 Aug 2011 12:56:46 +0000 (08:56 -0400)]
Repaired qtype bug introduced w/ bool searching

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen into QP_bucket_filter
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:42:34 +0000 (16:42 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen into QP_bucket_filter

8 years agoCast needed
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:42:17 +0000 (16:42 -0400)]
Cast needed

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoSpeed up hold editing by only fetching hold to edit
Bill Erickson [Wed, 3 Aug 2011 20:04:26 +0000 (16:04 -0400)]
Speed up hold editing by only fetching hold to edit

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRepaired bug in t-pac org selector value propagation
Bill Erickson [Wed, 3 Aug 2011 19:33:24 +0000 (15:33 -0400)]
Repaired bug in t-pac org selector value propagation

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamped upgrade script for more_cache_visbility_breakage
Mike Rylander [Wed, 3 Aug 2011 17:46:24 +0000 (13:46 -0400)]
Stamped upgrade script for more_cache_visbility_breakage

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUnwrapped upgrade script
Thomas Berezansky [Mon, 25 Jul 2011 20:39:57 +0000 (16:39 -0400)]
Unwrapped upgrade script

for more_cache_visbility_breakage

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoExtraneous semicolons break SQL
Thomas Berezansky [Mon, 25 Jul 2011 20:39:07 +0000 (16:39 -0400)]
Extraneous semicolons break SQL

Remove them so that cache_copy_visibility can function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoFix overzealous template application
Jason Etheridge [Mon, 1 Aug 2011 06:10:15 +0000 (02:10 -0400)]
Fix overzealous template application

The idea was that we'd track templates if they were applied prior to copies
actually being specified in the unified interface, and then apply them "for
real" once copies were entered.  But these remembered templates kept applying
themselves whenever changes were made in the volume/copy creator portion of
the interface (possibly overriding tweaks made by staff).  So now we delete
the list of tracked templates once they're applied to actual copies.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agorobustify (and klunkify) unified volume copy creator
Jason Etheridge [Mon, 1 Aug 2011 05:40:22 +0000 (01:40 -0400)]
robustify (and klunkify) unified volume copy creator

Disable/style the Item Editor while changes in the volume/item pane are being
considered, and require an explicit press of a Ready Item Editor button to
enable the interface.  This reduces the chance of editing widgets in the item
editor from being ripped out from under you (for example, if you try to go
straight from editing a call number to editing an item attribute).

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agolp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for...
Jason Etheridge [Thu, 21 Jul 2011 19:25:28 +0000 (15:25 -0400)]
lp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for Catalogers

Alerts with the number of pre-cat records skipped prior to invoking the title bucket dialog.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoThis adds a SAN box to the org unit editor's address editor pane.
James Fournie [Thu, 28 Jul 2011 19:08:18 +0000 (12:08 -0700)]
This adds a SAN box to the org unit editor's address editor pane.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUpgrade script for a patch from Steven Callender addressing payment types in money...
Mike Rylander [Wed, 3 Aug 2011 17:02:30 +0000 (13:02 -0400)]
Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoDeleted a line the removed single quotes (') from search strings
Liam Whalen [Wed, 20 Jul 2011 16:49:27 +0000 (12:49 -0400)]
Deleted a line the removed single quotes (') from search strings

The multiclass_query function replaces single quotes with spaces (') ( ).
This causes a problem when toggling between Advanced and Basic search.
If a search is conducted with a ' in it, that quote appears in the
basic search box displayed above the results.  However, if the user
then clicks the 'Advanced' button to toggle to the advanced search
the single quote is missing from the search term.  By removing the line
$query =~ /s/'/ /go; from Biblio.pm this problem is resolved.

Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years ago2.0-2.1 upgrade integration of a patch from Steven Callender addressing payment types...
Mike Rylander [Wed, 3 Aug 2011 16:40:42 +0000 (12:40 -0400)]
2.0-2.1 upgrade integration of a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoUpgrade script for a patch from Steven Callender addressing payment types in money...
Mike Rylander [Wed, 3 Aug 2011 16:38:24 +0000 (12:38 -0400)]
Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoA fix so that the last payment types will be cash_payment and check_payment rather...
Steven Callender [Thu, 28 Jul 2011 19:37:27 +0000 (19:37 +0000)]
A fix so that the last payment types will be cash_payment and check_payment rather than bnm_payment for cash and check payments.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoQuote container id param for safety
Mike Rylander [Wed, 3 Aug 2011 00:05:53 +0000 (20:05 -0400)]
Quote container id param for safety

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMerge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bu...
Mike Rylander [Wed, 3 Aug 2011 00:02:28 +0000 (20:02 -0400)]
Merge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bucket_filter

8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter
Mike Rylander [Wed, 3 Aug 2011 00:01:49 +0000 (20:01 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter

8 years agoFixed some syntax errors, but getting no results when I'd expect some
Lebbeous Fogle-Weekley [Tue, 2 Aug 2011 21:34:10 +0000 (17:34 -0400)]
Fixed some syntax errors, but getting no results when I'd expect some

I searched with this

    container(bre,bookbag,12,$authtoken)

where $authtoken is substituted with an actual live authtoken for the
user that owns that container, and here is the example generated query
that returns no results:

  SELECT * FROM  search.query_parser_fts(
            4::INT,
            2::INT,
            $core_query_3553$SELECT  m.source AS id,
ARRAY_ACCUM(DISTINCT m.source) AS records,
1.0/((AVG(
        (1)
) * COALESCE( NULLIF( FIRST(mrd.attrs @> hstore('item_lang', $_3553$eng$_3553$)), FALSE )::INT * 5, 1)))::NUMERIC AS rel,
1.0/((AVG(
        (1)
) * COALESCE( NULLIF( FIRST(mrd.attrs @> hstore('item_lang', $_3553$eng$_3553$)), FALSE )::INT * 5, 1)))::NUMERIC AS rank,
FIRST(mrd.attrs->'date1') AS tie_break
FROM  metabib.metarecord_source_map m
JOIN metabib.record_attr mrd ON (m.source = mrd.id)

JOIN ( SELECT ci.target_biblio_record_entry AS container_item
        FROM  container.biblio_record_entry_bucket_item ci
              JOIN container.biblio_record_entry_bucket c ON (c.id = ci.bucket)

        WHERE c.btype = $_3553$bookbag$_3553$ AND c.id = 12
              AND (c.pub IS TRUE OR c.owner = 1)) container ON (container.container_item = mrd.id)

WHERE 1=1

AND (TRUE)
GROUP BY 1
ORDER BY 4 ASC NULLS LAST, 5 DESC NULLS LAST, 3 DESC
LIMIT 10000
$core_query_3553$::TEXT,
            $${}$$::INT[],
            $${}$$::INT[],
            NULL::INT,
            1000::INT,
            10000::INT,
            'f'::BOOL,
            't'::BOOL
        );

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoRemove craftsman skin.
Joseph Lewis [Tue, 2 Aug 2011 20:41:37 +0000 (14:41 -0600)]
Remove craftsman skin.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Via LP:
https://bugs.launchpad.net/evergreen/+bug/820010

And this email thread:
http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-August/006269.html

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoMerge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bu...
Mike Rylander [Tue, 2 Aug 2011 19:01:55 +0000 (15:01 -0400)]
Merge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bucket_filter

8 years agoActually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre...
Mike Rylander [Tue, 2 Aug 2011 18:58:57 +0000 (14:58 -0400)]
Actually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre containers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAdd cointainer() and record_list() filters to QueryParser
Mike Rylander [Fri, 22 Jul 2011 19:10:23 +0000 (15:10 -0400)]
Add cointainer() and record_list() filters to QueryParser

The container() filter takes 3 or 4 positional params:
  - class (bre, acn, acp, au)
  - type  (bookbag, etc -- btype of the container)
  - id    (container id)
  - token (authtoken, optional, for checkin ownership of non-public containers)

The record_list() filter takes a list of record ids to restrict the search by.
These are bib ids by default, but are treated as metarecord ids in the presence
of the #metabib (aka #metarecord) modifier.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoActually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre...
Mike Rylander [Tue, 2 Aug 2011 18:58:57 +0000 (14:58 -0400)]
Actually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre containers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Mike Rylander [Tue, 2 Aug 2011 18:39:35 +0000 (14:39 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Mike Rylander [Tue, 2 Aug 2011 18:39:31 +0000 (14:39 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter
Mike Rylander [Tue, 2 Aug 2011 18:39:18 +0000 (14:39 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter

8 years agoRepaired seed data T-pac merge conflict
Bill Erickson [Tue, 2 Aug 2011 17:04:25 +0000 (13:04 -0400)]
Repaired seed data T-pac merge conflict

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agolp758945: make receipt template macros repeatable
Galen Charlton [Tue, 2 Aug 2011 16:20:32 +0000 (12:20 -0400)]
lp758945: make receipt template macros repeatable

Patch from Jason Boyer to allow macros to be used
more than once in a section; prior to this patch, only
the first occurrence was replaced with the substitation
value.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Thomas Berezansky [Tue, 2 Aug 2011 16:09:33 +0000 (12:09 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

8 years agoFormat an unordered list appropriately
Dan Scott [Sun, 24 Jul 2011 19:51:38 +0000 (15:51 -0400)]
Format an unordered list appropriately

The list of developer prereqs was munged inline rather than as a list.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoProvide Fedora-friendly instructions for the DBD libraries
Dan Scott [Thu, 21 Jul 2011 22:39:06 +0000 (18:39 -0400)]
Provide Fedora-friendly instructions for the DBD libraries

We had only provided the Debian / Ubuntu location of the libdbi-libdbd
libraries, so add the Fedora location as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoBring more of the wiki docs over to the README
Dan Scott [Thu, 21 Jul 2011 22:35:17 +0000 (18:35 -0400)]
Bring more of the wiki docs over to the README

Document Perl prerequisites for a standalone PostgreSQL server.
Include a section on starting Evergreen and basic troubleshooting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoUpdate the README to include database installation instructions
Dan Scott [Thu, 21 Jul 2011 21:39:49 +0000 (17:39 -0400)]
Update the README to include database installation instructions

A long time ago, the database server was installed by default.
Nowadays, installing the database server is a separate step
reserved for whatever machine you want to devote to PostgreSQL.
Not that you can't put it on the same machine as the rest of
Evergreen and OpenSRF...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoFixed typo in vandelay UI
Bill Erickson [Tue, 2 Aug 2011 15:49:03 +0000 (11:49 -0400)]
Fixed typo in vandelay UI

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Bill Erickson [Tue, 2 Aug 2011 15:31:24 +0000 (11:31 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

8 years agoStamped upgrade script for user/miker/replace_field_fix
Bill Erickson [Tue, 2 Aug 2011 15:26:19 +0000 (11:26 -0400)]
Stamped upgrade script for user/miker/replace_field_fix

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoHave replace_field return input XML when no replace rule is provided
Mike Rylander [Tue, 2 Aug 2011 14:55:00 +0000 (10:55 -0400)]
Have replace_field return input XML when no replace rule is provided

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerge branch 'rec_attr_def_config_avoid_cxt_fetch'
Lebbeous Fogle-Weekley [Tue, 2 Aug 2011 15:28:01 +0000 (11:28 -0400)]
Merge branch 'rec_attr_def_config_avoid_cxt_fetch'

8 years agoAvoid xml_transform retrieval in record attr def editor
Bill Erickson [Mon, 1 Aug 2011 18:09:23 +0000 (14:09 -0400)]
Avoid xml_transform retrieval in record attr def editor

config.xml_transform stores large chunks of XML.  Fetching it angers
Ejabberd on my test system.  All we need is the name, so use the new
AutoFieldWidget.searchOptions param to do just that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAdd the new patron retrieval to the toolbar
Thomas Berezansky [Tue, 2 Aug 2011 15:11:26 +0000 (11:11 -0400)]
Add the new patron retrieval to the toolbar

Specifically, in the little list of things that shows up when you use the arrow next to patron search.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoLabel tweaks re: Database ID vs Record ID, etc.
Jason Etheridge [Sun, 31 Jul 2011 04:42:05 +0000 (00:42 -0400)]
Label tweaks re: Database ID vs Record ID, etc.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAdd "Retrieve patron via Database ID" menu entry
Jason Etheridge [Sun, 31 Jul 2011 04:33:31 +0000 (00:33 -0400)]
Add "Retrieve patron via Database ID" menu entry

Add "Retrieve patron via Database ID" menu entry to top-level Search menu

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAllow advanced search bool selectors to size down
Bill Erickson [Tue, 2 Aug 2011 14:38:14 +0000 (10:38 -0400)]
Allow advanced search bool selectors to size down

... to avoid unnecessary horizontal screen gobbling

Tested in Chrome, FF, and IE

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agocalculate penalties when letting Mark Item Damaged add bills
Jason Etheridge [Thu, 14 Jul 2011 21:21:52 +0000 (17:21 -0400)]
calculate penalties when letting Mark Item Damaged add bills

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoFix oils_i18n_gettext id numbers
Thomas Berezansky [Tue, 2 Aug 2011 13:37:24 +0000 (09:37 -0400)]
Fix oils_i18n_gettext id numbers

config.metabib_field ids 29/30 had 28 for translation id.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoSupport for boolean operators in advanced search
Bill Erickson [Mon, 1 Aug 2011 21:34:35 +0000 (17:34 -0400)]
Support for boolean operators in advanced search

Implements a new column with And/Or selectors.  Terms are grouped from
top to bottom in the UI as left to right in the compiled query.

A && B || C && D  => ((A && B) || C) && D

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agomaketext filter must be registered as a dynamic filter to properly handle arguments
Bill Erickson [Mon, 1 Aug 2011 22:35:39 +0000 (18:35 -0400)]
maketext filter must be registered as a dynamic filter to properly handle arguments

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAutoFieldWidget support for augmenting pcrud search options
Bill Erickson [Mon, 1 Aug 2011 18:04:24 +0000 (14:04 -0400)]
AutoFieldWidget support for augmenting pcrud search options

Adds a new searchOptions attribute to AutoFieldWidget for specifying
additional parameters to pcrud when retrieving linked objects.  The
initial use case is for supporting a "select" list to allow
AutoFieldWidget to retrieve only the display column of a linked object
and not the whole object.

Example:

 // fetch 'remote_field_name' on the remote objects instead of
 // fetching the entire object

 myGrid.overrideWidgetArgs.some_field = {searchOptions :
 {"select":{"some_hint":["remote_field_name"]}}};

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRemove KCLS mattype SQL seed data comment
Bill Erickson [Mon, 1 Aug 2011 13:08:33 +0000 (09:08 -0400)]
Remove KCLS mattype SQL seed data comment

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoBypass install_filter mem leak via direct insertion
Bill Erickson [Mon, 1 Aug 2011 13:00:30 +0000 (09:00 -0400)]
Bypass install_filter mem leak via direct insertion

See https://rt.cpan.org/Ticket/Display.html?id=46691

On the one hand we have a memory leak, on the other we have a bug caused
by the fix to the memory leak.  Bypass this altogether and insert the
filter manually into the template environment using Template's FILTER
configuration argument.  This has the added bonus of simplifying the
i18n filter code.

Since the filter is manually inserted, it's not necessary (and possibly
counter-productive) to USE the filter directly in the template.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agouse isNaN here, since NaN == NaN => false
Jason Etheridge [Sun, 31 Jul 2011 05:08:07 +0000 (01:08 -0400)]
use isNaN here, since NaN == NaN => false

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoClean up OpenSRF::AppSession objects after use
Lebbeous Fogle-Weekley [Fri, 29 Jul 2011 18:08:28 +0000 (14:08 -0400)]
Clean up OpenSRF::AppSession objects after use

These things need ->kill_me called on them after we're done using them.

(note to self: check to see if we can just add a DESTROY sub to that
package)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMerge branch 'template-toolkit-opac' of git://git.evergreen-ils.org/evergreen/equinox...
Lebbeous Fogle-Weekley [Fri, 29 Jul 2011 16:34:26 +0000 (12:34 -0400)]
Merge branch 'template-toolkit-opac' of git://git.evergreen-ils.org/evergreen/equinox into template-toolkit-opac

8 years agoFix incorrect search advice on the no-results page.
Lebbeous Fogle-Weekley [Fri, 29 Jul 2011 16:33:52 +0000 (12:33 -0400)]
Fix incorrect search advice on the no-results page.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoadvanced/cnbrowse label tweak
Bill Erickson [Fri, 29 Jul 2011 16:24:46 +0000 (12:24 -0400)]
advanced/cnbrowse label tweak

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoPrevent undef warnings on org unit lookup
Bill Erickson [Fri, 29 Jul 2011 16:19:18 +0000 (12:19 -0400)]
Prevent undef warnings on org unit lookup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agocnbrowse tweaks
Lebbeous Fogle-Weekley [Fri, 29 Jul 2011 16:11:22 +0000 (12:11 -0400)]
cnbrowse tweaks

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoDirect entry point into the call number browser
Lebbeous Fogle-Weekley [Fri, 29 Jul 2011 15:51:26 +0000 (11:51 -0400)]
Direct entry point into the call number browser

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoIf there's no sort org unit, just fall back to the usual sorting
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 20:59:59 +0000 (16:59 -0400)]
If there's no sort org unit, just fall back to the usual sorting

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoDon't build image tags for non-existing mattype icons
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 20:46:12 +0000 (16:46 -0400)]
Don't build image tags for non-existing mattype icons

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoSort copies on record detail page with copies belonging to "sort org unit" first
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 20:37:19 +0000 (16:37 -0400)]
Sort copies on record detail page with copies belonging to "sort org unit" first

"sort org unit" needs to eventually be an abstract concept that could
either refer to "orig_loc" or to "loc" or perhaps be skipped altogether,
depending on some future configuration.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFix broken builds due to test that can't find its data
Dan Scott [Thu, 28 Jul 2011 19:49:12 +0000 (15:49 -0400)]
Fix broken builds due to test that can't find its data

LP 817699 reports a problem that began with commit
e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that
had previously been resolved with commit
f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are
run from different directories, but a new test opened a file without
making any allowance that the test might be run from anything other than
the /test/ directory.

This fix uses the dirname(__FILE__) approach to provide the appropriate
relative directory for the test data, and enables the tests to be
processed without dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoitem_barcode had broken the rest of numeric search
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 19:12:28 +0000 (15:12 -0400)]
item_barcode had broken the rest of numeric search

but now it's fixed

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMinor code cleanup of unused code; avoids Apache warning
Bill Erickson [Thu, 28 Jul 2011 18:32:35 +0000 (14:32 -0400)]
Minor code cleanup of unused code; avoids Apache warning

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoAvoid server-error on barcode search when barcode not found
Bill Erickson [Thu, 28 Jul 2011 18:31:31 +0000 (14:31 -0400)]
Avoid server-error on barcode search when barcode not found

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMake users confirm they really want to delete lineitems from POs...
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 18:17:44 +0000 (14:17 -0400)]
Make users confirm they really want to delete lineitems from POs...

... when they've already been ordered. There's really no reason to ever
make such a deletion this that I can think of, but I use a confirm()
instead of stricter measures in case I'm missing something.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoStamped upgrade for user/dbs/oclcnumbers
Bill Erickson [Thu, 28 Jul 2011 16:34:28 +0000 (12:34 -0400)]
Stamped upgrade for user/dbs/oclcnumbers

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoPrevent control numbers from duplicating
Dan Wells [Thu, 21 Jul 2011 16:14:02 +0000 (12:14 -0400)]
Prevent control numbers from duplicating

In maintain_control_numbers(), if you have more than one 001 or
003, and at least one is the correct one, you will end up
duplicating the correct number every time the record is saved.

For example, if the incoming record was record ID # 12345, and
the record contained:

001: 12345
001: ocm10202

... then after maintain_control_numbers() ran, the record would
contain:

001: 12345
001: 12345

Also, clean up some leftovers from the refactor I suggested in the
previous commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd an unwrapped upgrade script for OCLC-aware control numbers
Dan Scott [Thu, 21 Jul 2011 15:12:36 +0000 (11:12 -0400)]
Add an unwrapped upgrade script for OCLC-aware control numbers

The upgrade script creates the SCN and LCCN search indexes and
populates them using metabib.full_rec as a source; cheating, but
the normalized values will work for non-exact search purposes. Sites can
reingest all of their bibs if they want exact search to work.

Also, refactor maintain_control_numbers() using a suggestion by
Dan Wells to eliminate some duplicate code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTreat OCLC numbers specially in maintain_control_numbers
Dan Scott [Thu, 21 Jul 2011 14:18:55 +0000 (10:18 -0400)]
Treat OCLC numbers specially in maintain_control_numbers

For some reason, many records that come with OCLC numbers in the 001
field are not populated with a 003 field. This resulted in the OCLC
number being thrown away entirely, rather than being moved into the 035,
as there was no corresponding control number identifier field.

However, given that we know that control numbers starting with "ocm" or
"ocn" are special OCLC numbers, we can generate the 035 accordingly even
in the absence of a 003. This update to maintain_control_numbers()
teaches it to do the right thing for OCLC numbers.

In addition, add an identifier search index so we can easily find
records by their system control numbers (035 $a subfields).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoRevert "Add lccn field to the identifier search class"
Bill Erickson [Thu, 28 Jul 2011 16:28:23 +0000 (12:28 -0400)]
Revert "Add lccn field to the identifier search class"

This change will be absorbed when merging working/user/dbs/oclcnumbers,
which I will do pronto...

This reverts commit 94f69d21b6759dc43c151c7796dafee74083f62c.

8 years agoAdd lccn field to the identifier search class
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 16:09:01 +0000 (12:09 -0400)]
Add lccn field to the identifier search class

Facilitates easily searching by LCCN (010 ‡a).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Bill Erickson [Thu, 28 Jul 2011 15:39:09 +0000 (11:39 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

8 years agoRedirector support for T-pac
Bill Erickson [Thu, 28 Jul 2011 15:36:23 +0000 (11:36 -0400)]
Redirector support for T-pac

Includes new Apache configuration option:

PerlSetVar OILSRedirectTpac "true"

"Original location" is tracked initially as a URL param (orig_loc), but
is ultimately absorbed into a cookie (eg_orig_loc) since the URL param
would otherwise have to be propagated to every page.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoYou can now have multiple rows in your MARC Expert Search
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 15:10:47 +0000 (11:10 -0400)]
You can now have multiple rows in your MARC Expert Search

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoMARC expert search working
Lebbeous Fogle-Weekley [Wed, 27 Jul 2011 22:21:31 +0000 (18:21 -0400)]
MARC expert search working

This just needs the JS row cloning so you can search on multiple terms
at a time.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoIt's ugly and hacky, but numeric search fully works (item barcode included)
Lebbeous Fogle-Weekley [Wed, 27 Jul 2011 21:31:30 +0000 (17:31 -0400)]
It's ugly and hacky, but numeric search fully works (item barcode included)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoSIP2 support for checkin local holds as transits
Thomas Berezansky [Thu, 14 Jul 2011 20:49:14 +0000 (16:49 -0400)]
SIP2 support for checkin local holds as transits

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>