Adjust comments in Storage::Driver::Pg to remove references to
Class::DBI::Replication, which we did not end up using.
Also remove a commented-out sub that purported to make use of a function
that did not exist in the home-grown multi-db implementation.
NOTE: While unused, the multi-db implementation in Storage::Driver::Pg
intelligently decides when to use a read-only secondary based on the
existence of a transaction or the "write-iness" state controlled by the
caller, and does not require separate main (or primary) and secondary
db lists.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Boyer [Thu, 21 May 2020 22:19:57 +0000 (18:19 -0400)]
LP1880035: Fix rendering of monograph parts
A BorderContainer is primarily used to allow anchoring views to the top,
bottom, left, or right of the container and usually allows the use of a
splitter to resize child views. Since we don't use any of that and don't
need such a control, it was apparrently just luck that it worked at all.
Using a plain ContentPane instead allows the page to render as expected.
Thanks to Galen Charlton for tracking this down and finding the fix.
Signed-off-by: Jason Boyer <JBoyer@eoli.info> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 22 Aug 2019 14:12:53 +0000 (10:12 -0400)]
LP1837656 Org proximity admin disable org filter
Disable the org unit filter for the auto-generated org unit proximity
adjustment admin page so that it does not automatically filter the grid by
any of the org unit fields.
Modify the IDL to indicate that the 'pos' field on the org unit
proximity adjustement class is required.
To test:
1. Navigate to
/eg2/en-US/staff/admin/server/actor/org_unit_proximity_adjustment
2. Create an adjustment if non exist.
3. Confirm the 'Position' field is now required.
4. Confirm new adjusment row appears in the grid after it's created.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
* Indicate in the UI when grid filters are applied via URL and offer a
way for the user to clear the filters.
* When grid filters are applied, use them as the basis for the "Default
New Record" object which seeds the fm-editor. In other words, apply
default values to the fm-editor to match the grid filters.
* Repair some IDL thinkos and add more 'selector' values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Tue, 5 May 2020 21:37:05 +0000 (14:37 -0700)]
LP#1847800: secondary admin pages for Authority Control Sets and Authority Thesauri
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Tue, 5 May 2020 21:11:41 +0000 (14:11 -0700)]
LP#1847800 / LP#1847810: secondary admin pages: MARC Search/Facet Fields -> virtual index definitions
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Tue, 5 May 2020 19:16:37 +0000 (12:16 -0700)]
LP#1847800 / LP#1847781: secondary admin pages for MARC Import Remove Fields
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Wed, 29 Apr 2020 21:27:23 +0000 (17:27 -0400)]
LP1847800 Admin grids support config_field links
For IDL fields which have config_field=true, the value in the admin grid
is rendered as a link to the grid for the linked field. Additionally,
the link contains a gridFilter so the destination grid only displays
rows related to the selected field.
Adds config_field=true values for z39.50 source and two links for hard
due date and hard due date values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Wed, 18 Dec 2019 00:06:19 +0000 (16:06 -0800)]
LP#1847800 / LP#1834687: secondary admin pages: config_field attribute in IDL
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Thu, 30 Apr 2020 17:36:44 +0000 (10:36 -0700)]
LP#1873048: add scoped retrieve perms for booking resource types and resources
In the XUL client, when selecting a resource type, the list was limited
by owning library. But in the web client, the list would show all
resource types across all libraries. This commit addresses that
regression by adding a new VIEW_BOOKING_RESOURCE_TYPE permission with
context_field in the IDL. That way, users only see resource types owned
by org units where they have the permission.
While we're at it, a new VIEW_BOOKING_RESOURCE perm is also added for
resources.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Tue, 28 Apr 2020 20:52:52 +0000 (13:52 -0700)]
LP#1865533: save changes on Edit Hold in My Account
When editing a hold in the OPAC, changes are not saved if the SMS field
is blank. The sms_notify value is being passed as an empty string, and
this non-null value violates the "sms_check" constraint on
action.hold_request. Replacing the empty string with undef allows the
hold update to succeed.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Daniel Pearl [Wed, 13 Mar 2019 14:07:17 +0000 (10:07 -0400)]
LP1787636: Sort Libraries without Holdings In Holdings View
Empty libraries in holdings view are listed at the end of the library
list instead of integrated within the list. This patch sorts them
within the list.
Signed-off-by: Daniel Pearl <dpearl@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Thu, 26 Mar 2020 14:47:46 +0000 (10:47 -0400)]
LP1813088: Coerce Values to String in egGridValueFilter
Coerce values to string in the switch for Boolean columns in the main
egGridValueFilter function. This came about after an IRC conversation
with Mike Rylander who suggested this as a possible fix. It should
when field values are strings, integers, or Booleans.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Stephenson [Fri, 24 Apr 2020 18:22:25 +0000 (14:22 -0400)]
LP1873286: Fix Bad End Tags
Fix self-closing tags used in non-void HTML and non-empty XHTML tags.
These tags now cause errors with jQuery version 3.5.0 and were
technically wrong from the start.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Mon, 2 Dec 2019 17:26:22 +0000 (12:26 -0500)]
LP1848550 Cache org settings in IndexedDB (Angular)
Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.
Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Wed, 27 Nov 2019 00:12:37 +0000 (16:12 -0800)]
LP#1848550: client-side caching of org settings for AngularJS
The web client almost always does live lookups any time it needs to
check an org setting. But these settings rarely change, so it would
make sense to cache them. They're already cached using Lovefield in
order to support offline; this commit checks the cache first, and only
does a live lookup if the setting is uncached.
The settings cache is cleared on login to ensure stale values don't
stick around forever. To refresh the cache, simply logout and then
login; cached values will be deleted and the latest values will be
retrieved from the server when they are needed.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Change "TODO" to "1202" in versioned upgrade script. I'm not sure how
that didn't happen unless I forgot to save the file or doing an
--amend before pushing changed things.
Bill Erickson [Fri, 24 Apr 2020 14:42:42 +0000 (10:42 -0400)]
LP1858448 Disable inititial aged money migration
Modify the existing SQL upgrade scripts to prevent the automatic
migration of billings/payments to the new aged money tables. This is
done to prevent data loss for sites which have not yet upgraded to the
affected versions.
The schema changes are kept so both pre- and post-upgrade sites can
follow the same schema update path.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Stephenson [Wed, 11 Mar 2020 16:47:55 +0000 (12:47 -0400)]
LP1858448 More IDL fixups
Make IDL fixes as recommended in the Launchpad bug discussion.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Adds a srfsh script for manually aging money based on the
'history.money.retention_age' setting value.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Fri, 7 Feb 2020 20:52:19 +0000 (15:52 -0500)]
LP1858448 Aged payment fields release notes
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Fri, 7 Feb 2020 20:19:15 +0000 (15:19 -0500)]
LP1858448 Additional aged_payment fields
Adds accepting_usr, cash_drawer, and billing columns to the
money.aged_payment table.
Modifies the existing "xact" column for aged payments and billings in
the IDL to link to "mbt" instead of "acirc", since not all
payments/billings are linked to aged circs.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Almost complete implementation for LP1772053. To be done: items
relating to call numbers, prefixes and suffixes for Hold Pull Lists
and Transit Slips.
Signed-off-by: Daniel Pearl <dpearl@cwmars.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Michele Morgan [Fri, 20 Dec 2019 21:00:08 +0000 (16:00 -0500)]
LP1781274 Fix floating point issue preventing transactions from closing
Paying multiple bills with a single payment can lead to some
transactions not closing because of floating point math inaccuracies.
This branch resolves the issue by limiting pending payment amounts to
2 decimal places.
The bug can be reproduced using grocery bills as follows.
Retrieve a patron that owes no money.
Add a billing of $.90
Add a billing of $.10
Select both billings
Enter $1 in payment received and Apply the payment
Click on History in the billings screen. Turn on the Total Billed and
Transaction Finish Time column and note that the $.10 bill has zero
balance owed, but does not have a transaction finish time.
To test:
Use the steps above to reproduce, noting the lack of Transaction
Finish Time. Apply the patch.
Use the same steps above and note that the post patch payments
resulted in both transactions getting a Transaction Finish Time.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Kyle Huckins [Wed, 11 Mar 2020 21:07:11 +0000 (21:07 +0000)]
lp1801137 Item Status Precat Information
- Display precat title, author, and isbn in place of
regular title, author, and isbn fields in Item Status
list view when working with precat items.
- Add Dummy Title and Dummy Author fields to Item Status
Detail view when looking at a precat item.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jeff Davis [Wed, 19 Feb 2020 20:36:30 +0000 (12:36 -0800)]
LP#1774268: handle opac.hold_notify empty string in AngJS patron editor
If a patron does not want either phone or email hold notifications,
their opac.hold_notify user setting will be an empty string. Let's
ensure that the hold notify checkboxes remain unchecked in the patron
editor when that is the case.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Boyer <JBoyer@eoli.info>
On patron edit screen set the email and phone notification
to true when patron doesn't have any prefernces. This mimics
the behavior in the xul client.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Sam Link [Tue, 22 Oct 2019 19:51:57 +0000 (15:51 -0400)]
Bug 1834251: adding alt attributes to Open-ILS\src\templates\kpac\parts\paginate.tt2.
Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Llewellyn Marshall <lbmarshallv.ncdcr@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Dan Wells [Wed, 4 Mar 2020 19:38:49 +0000 (14:38 -0500)]
First pass at release notes for 3.5
This commit consolidates all the release notes in RELEASE_NOTES_NEXT,
and does a few minor edits to formatting, layout, and text for improved
flow of the content.
Mike Risher [Wed, 22 Jan 2020 22:56:42 +0000 (22:56 +0000)]
lp1789491 visited link color
Some interfaces use a red or dark red background color for certain rows
and the visited link color makes it hard to read. Adjust this color
so there is more contrast against the red background.
Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jessica Woolford <jwoolford@biblio.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
This patch adds a new oils_sip.xml login attribute called
patron_status_always_permit_loans that specifies whether
the charge privileges denied, renewal privilges denied, and
card reported lost flags in the patron status block should be
coerced to permissive values regardless of the actual state
of the patron record. Turning this on works around an issue
where a 2019-12 change by the Hoopla SIP2 client takes those flag
fields into account, but some libraries may not wish those
to block a patron's access to online resources that use
SIP2 to authenticate. This setting can also be set as
an implementation_config option; note that if it is set to
'true' or 'false' as a login attribute, the login attribute will
override whatever is set in the implementation_config.
To test
-------
[1] Set up a test system that has SIPServer running. Also set
up a patron that either has a standing penalty blocking CIRC
or renewals, expired privileges, and/or a lost primary card.
[2] Perform a SIP2 patron information request (message 63) for
the patron created in step 1. Note that the charge, renewal,
and card lost flag fields in the SIP2 response should be set
to indicated that privileges are denied.
[3] Apply the patch and enable patron_status_always_permit_loans
either as a login attribute or a implementation_config option;
oils_sip.xml.example in this patch contains examples.
[4] Repeat step 2; this time, the three flag fields should have
permissive values (i.e., they will be set to the space character)
regardless of the state of the patron record.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jason Boyer <JBoyer@eoli.info> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Ruth Frasur <rfrasur@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Chris Sharp [Fri, 4 Oct 2019 18:31:22 +0000 (14:31 -0400)]
LP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder
Let's give end users a break and forgive them when they mix
up the order of a date range. BETWEEN SYMMETRIC allows users
to enter a date range in any order rather than strictly
enforcing "oldest date first" and returning an empty result
set.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Mike Risher [Tue, 24 Sep 2019 17:41:27 +0000 (17:41 +0000)]
lp1845240 port of Surveys UI from DOJO to Angular
idlClass asv holds the surveys, asvq holds their questions, and
asva holds the answers to those questions. The surveys are in
their own module and are lazy loaded
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Modernize the survey create API by migrating it to cstore.
Additionally, make it possible to modify an existing survey top-level
object by setting 'ischanged' to the inbound survey.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1845240 Migrate survey create API to cstore
Modernize the survey create API by migrating it to cstore.
New API supports full range of isnew / ischanged / isdeleted actions on
the survey, questions, and answers.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1845240 Survey API returns updated fleshed survey
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey-edit.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey-edit.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey-routing.module.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey.module.ts
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Survey.pm
modified: Open-ILS/tests/datasets/sql/surveys.sql
Since we enter the surveys, questions, and answers with specified ID values
but don't set the values to one higher, testers were unable to enter survey
data.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Josh Stompro [Tue, 25 Feb 2020 19:53:08 +0000 (13:53 -0600)]
LP#850160 - Event Def Environment Fleshing Might Have Issue
When the action trigger environment gets fleshed out, there is a bug
with how might_have relations are fleshed ever other time they are
evaluated.
The first time they are correctly evaluated, but then the next time the
same path gets evaluated, the object gets reset to the first value in
the object.
See https://bugs.launchpad.net/evergreen/+bug/850160 for testing notes.
The fix is to add an extra check to only grab the first element if the object is
an array. If it isn't an array it means it has already been fleshed.
Testing notes:
One way to test this bug is by looking at the self check
receipt, hours of operations bug.
https://bugs.launchpad.net/evergreen/+bug/793627
By default, the self check receipt will fail for even numbers of items checked
out because the hours of operation doesn't get fleshed correctly.
With this change, the receipt should print for even and odd numbers of items.
Another test is to add user.money_summary to a lost/bill action trigger
event notification. Before the fix, if you have an even number of items billec, the
user.money_summary gets set to the first object in that table, and for odd
numbers of items, user.money_summary.balanced_owed gets set correctly.
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Cesar Velez [Tue, 22 Jan 2019 17:16:54 +0000 (12:16 -0500)]
LP#1570072: update hold notification methods upon preference changes
This patch adds a feature where if a patron's hold notification
preferences are changed, they are given an opportunity to have
notfication methods for their pending hold requests updated to
reflect their new prefernces.
This feature affects both the public catalog My Account interface
and the staff patron registration form. In both cases, the user
is presented with a modal (staff-side) or interstitial page (public
catalog) asking them whether to update current hold requests.
Sponsored-by: MassLNC Additional-work-by: Mike Rylander <mrylander@gmail.com> Additional-work-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Josh Stompro [Tue, 10 Dec 2019 19:25:37 +0000 (13:25 -0600)]
LP#1774285 - Change Pull list page title from Holds Shelf title.
Add a string for 'Pull List' and set the page title to that string
when the pull list interface is loaded. Allows staff to tell which
tab has the Holds Shelf open and which tab has the Pull List open.
* Teach the Angular holdings module vol/copy delete dialog to correctly
report failure events to the user and handle permission overrides.
* Add support for automatically launching the op-change dialog when a
permission failed event is returned by an API call for any /eg2/staff/
interface.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Wed, 4 Dec 2019 20:52:23 +0000 (15:52 -0500)]
LP1840287 Floating group admin minor code tweaks
* Added grid sorting to both group and group member grids.
* Avoid using the defaultNewRecord in fm-editor directly, by cloning it
as needed, so that subsequent new records (within a single parent
component instance) do not pick up values from the previously created
record.
* Renamed the eg-admin-page @Input() 'hideFields' to 'hideGridFields'
to better explain how the value will be passed along.
* Replace access of fieldmapper innards (thing.a[0]) with field names
(thing.id())
* Remove unused <eg-string /> entries.
* Avoid unnecessary newlines in translatable strings.
* Remove unused @Inputs() and unnecessary functions
* Remove unneccessary TreeModule import
* Removed a redundant <eg-title /> -- <eg-staff-banner /> will set the
title when present.
* Various 'ng lint' repairs.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Mike Risher [Fri, 13 Sep 2019 20:26:47 +0000 (20:26 +0000)]
lp1840287 Edit Floating Group Members
Add functionality so that when editing a floating group, one
is taken to a page where one can edit a given floating group as
well as all its linked members. New functionality:
- eg-admin-page can hide grid fields
- fm-editor can create a record with fields defaulting to values
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/edit-floating-group.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/edit-floating-group.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group-routing.module.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html
modified: Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.ts
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Marking items Missing or Damaged from the patron Items Out interface
is sometimes necessary. This commit adds that ability.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Galen Charlton [Thu, 13 Feb 2020 21:49:46 +0000 (16:49 -0500)]
LP#1863386: link ADMIN_CAROUSEL permission to appropriate OU context
This patch restricts prcrud retrieval and modification of templates
to users who have ADMIN_CAROUSEL in the relevant carousel owner OU
rather than requiring global_required.
To test
-------
[1] Apply the patch.
[2] Ensure that a user with ADMIN_CAROUSEL privileges at a depth
lower than "Consortium" can only view and edit carousel
definitions at OUs applicable to their working libraries.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Gina Monti <gmonti@biblio.org>
Bill Erickson [Mon, 2 Dec 2019 22:44:14 +0000 (17:44 -0500)]
LP1854197 Add Vols and Copies honors owning lib
Fixes a bug in the Add Volumes and Copies action where there vol/copy
editor was unable to extract the owning library of the selected volumes,
thus leading to no differentation between owning libraries in the editor
and having all of the new volumes/copies linked (by default) to the
first owning library in the list.
To test:
1. Navigate to Item Status UI
2. Scan multiple (say, 3) barcodes, each with a different owning lib.
3. Select all 3 items and chose "Add Callnumbers and Items"
4. The holdings edit page that results should show one volume and copy
row per owning library instead of all rows linked to the first owning
library in the set.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jessica Woolford <jwoolford@biblio.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
blake [Thu, 2 Jan 2020 22:48:45 +0000 (16:48 -0600)]
LP#1849736 Add action trigger for email/sms for patron self registration
Setup a new A/T Hook.
Includes:
1. New row in action_trigger.hook
2. New row in action_trigger.event_definition
3. New clause in action_trigger_filters.json.example
4. Link XML clause for oils_obj:fieldmapper="staging::user_stage" on fm_IDL.xml
4. pgTAP Test
5. Release Documentation