Mike Rylander [Tue, 11 Jun 2013 20:44:35 +0000 (16:44 -0400)]
Use the centralized initialization method for QP
QueryParser maintains an effective singleton for internal configuration of
the driver in order to avoid going to the database on every search request
to gather configuration parameters. There is also a centralized sub that
has the task of properly configuring said singleton. Previous to this commit
we were not using that centralized initializer in one case, and that case
happened to be the most important initialization of QP in all of Evergreen.
The fallout from that was that some configuration was not being gathered
and passed to QueryParser, resulting in incorrect search SQL being generated.
This is rectified by using the centralized initializer everywhere that it
is needed and can be used -- and particularly in the effected case.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Tue, 30 Apr 2013 20:45:55 +0000 (16:45 -0400)]
Search clicked /and/ preceding sf values
When looking for authority records to control a bib field, we currently
search using exactly, and only, the subfield that was clicked. This
commit changes that so that the full field up to and including the clicked
subfield is used in the simple authority heading search we perform to find
the best-match (pivot) authority record.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Ben Shum [Wed, 5 Jun 2013 04:40:53 +0000 (00:40 -0400)]
LP1079041 - making state not required (continued)
The last commit did not add the default YAOUS to the seed data. Also, some
wording tweaks to bring the content in line with the existing entries for
consistency.
Michael Peters [Thu, 15 Nov 2012 17:49:05 +0000 (12:49 -0500)]
Make the "state" field in registration a togglable YAOUS
Some countries do not use "State" therefore we need to create
a YAOUS to make it non-required/displaying. This also requires
that we no longer force a "not null" on state in actor.usr_address.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
Add table, view and trigger for "aging" hold requests on delete.
This creates the action.aged_hold_request table, the
action.all_hold_request view, the action.age_hold_on_delete
function, and the action_hold_request_aging_tgr on action.hold_request.
Add fieldmapper entries for action.all_hold_request view and
action.aged_hold_request table.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Mon, 25 Feb 2013 18:17:59 +0000 (13:17 -0500)]
Z39.50 Batch Search/Overlay TPAC my-list entry point
Similar to the staff client bucket UI, this adds a button which allows
staff to access the batch Z39 search-and-queue operation directly from
the TPAC my-lists UI.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Mon, 18 Feb 2013 15:41:01 +0000 (10:41 -0500)]
Z39.50 Batch Search/Overlay Z-Search UI
Adds a new "Find Z39.50 Matches" option to Cataloging -> Manage Record
Buckets. When selected, the user chooses the Z39 fields, the Z39
sources, the destination queue, and the queue match set. The user then
submits the search. Basic progress info is reported to the user.
Once complete, the user can open the destination queue, from which
regular vandelay import, etc. actions may be performed on the newly
found records.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Thu, 31 Jan 2013 17:37:44 +0000 (12:37 -0500)]
Vandelay record bucket-limited matching
Provides the option to link record buckets to vandelay queues. When
linked, vandelay imports where a match set is specified will limit
matches to records within the selected bucket.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Wed, 30 Jan 2013 22:44:30 +0000 (17:44 -0500)]
Z39.50 Batch Search/Overlay API
New API for performing Z39.50 queries for a set of bib records across a
set of Z39 sources. Searches are performed in parallel (up to a
configurable maximum number of active searches and maximum results) and
results are stored in a vandelay MARC Import/Export queue.
Search fields and values are determined by Z39 index field maps. At
search time, the caller provides a set of field maps to use for the
search. Search values for each bib record are found by following the
index maps to the indexed values in metabib.*_field_entry or
metabib.record_attr.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Fri, 5 Apr 2013 17:28:08 +0000 (13:28 -0400)]
Repair SIP start/end list ranges
SIP supports paging of certain lists (holds, fines, etc.) by allowing
the SIP client to provide start and end points for lists. This patch
repairs how Evgreen extracts the list ranges from arrays.
When using Perl array ranges, the array variable should be accessed via
'@' and not '$'. Prior to this change, all ranged lists resulted in
returning the first item in the list instead of the full range.
This change affects lists of holds, overdues, fines, and charges.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
(Just whitespace conflicts on tab vs space -- repaired by hand.)
Ben Shum [Sat, 2 Mar 2013 07:21:58 +0000 (02:21 -0500)]
TPAC - set autofocus to user input when placing holds in staff client
When placing holds in TPAC via the staff client, the focus had been on the
basic search field above. Change this to have autofocus on the input field
for the hold user by default.
This can potentially save staff from having to perform an extra click to
select the input field. Now they can immediately begin entering the barcode
of the user they plan to create a hold on behalf of.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 7 Jan 2013 14:35:55 +0000 (09:35 -0500)]
SIP renew-all; reset renewal statuses
Reset the list of renewed and unrenewed items for each instance of the
RenewAll transactions. Otherwise, items from previous transactions will
bleed into the current transaction.
While we're in there, fix a couple of tabs.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 26 Nov 2012 19:51:27 +0000 (14:51 -0500)]
SIP RenewAll
Adds SIP plugin support for SIP message types 65/66 (Renew All). When
requested, the plugin performs a renewal on all items currently checked
out for the user.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 21 Aug 2012 21:19:54 +0000 (17:19 -0400)]
Include Wrong-Shelf holds in clear-shelf results
Include non-expired, Wrong-Shelf holds in the results list of the "Clear
Shelf-Expired Holds" process. ("Wrong-Shelf" holds are those whose
pickup lib was changed while the hold was on the holds shelf). The idea
behind this option is that branches may use the clear-shelf process as a
general shelf management report beyond just holds that have expired.
I.e. tell me everything I need to remove from the shelf.
This change includes a label change for the clear-shelf menu options:
Ben Shum [Fri, 7 Jun 2013 00:14:08 +0000 (20:14 -0400)]
Remove unnecessary TPAC toggle strings on staff client splash page
Accidentally reintroduced with commit ad86ef5d3c689c9b514cc09bfc93e7f451461dc7,
we can skip adding back TPAC toggle strings to the index.xhtml file since that
toggle action has been removed from the page.
Acq: Be fuzzy about case when retrieving EDI documents
The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
other things, try to avoid fetching the same EDI document multiple times
when many rows in acq.edi_account refer to the same host and login
credentials.
Since in practice most vendors seem to run FTP servers for EDI on
Windows, not UNIX, and pathnames are therefore case-insensitive, that
test for other occurrences ought also to be case-insensitive.
If I were to look at this as a purist, I could argue that vendor servers
might sometimes by run on UNIX, and that for some reason it is possible
that different vendor-to-buyer EDI documents (order responses or
invoices) could have pathnames that differ only in the case of some
characters. But that seems wildly unlikely. If anyone does take this
possibility seriously, perhaps acq.edi_account needs a Boolean column to
indicate the remote host's case [in]sensitivity.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Etheridge [Thu, 6 Jun 2013 21:39:24 +0000 (17:39 -0400)]
lp1183525 Edit Item Attributes pop-up dimensions
Took Steven Chan's patch from the launchpad bug and added "stickiness" to the
window dimensions. So by default, it'll come up maximized, but once adjusted,
it will stay adjusted.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
"Return to record" after submission of phone number on SMS page fixed
Before this, it only worked on the page load *before* form submission.
There's probably a more elegant solution that doesn't involve keeping
track of URIs, but this seems to me to work.
Problem relayed to me by Dale Rigney at Equinox, who helped reproduce
the issue and test a fix.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Dan Scott [Thu, 6 Jun 2013 16:13:36 +0000 (12:13 -0400)]
Add new POT files to git so "make newpo" will work
Running "make newpo" errored out because the po subdirectories didn't
exist for the newly added POT files. This will also enable translators
to access the strings in Launchpad.
Dan Scott [Thu, 6 Jun 2013 13:40:59 +0000 (09:40 -0400)]
Fedora RPM for bzip2 headers is bzip2-devel
There was an attempt to add the right RPM for the bzip2 headers in
Makefile.install, but that failed on Fedora 19. Swap in bzip2-devel
instead to correct that.
TPAC: First part of locg param can be branch shortname
Addresses LP #1020625. You can use the locg param, which can set an
an OU for search context (and which has other implications related to
location/scope) by shortname now.
As long as your shortnames are something that work in an HTTP query
string, don't contain colons, and as long as you don't have numeric
shortnames for any orgs that would mask orgs with the sames numbers
as an ID (but that would be a lousy setup anyway), this should work.
Now case insensitive per recommendation by Michael Peters. In the
event that you have org units with names that are the same except
for case (probably a bad practice), the locg parameter will simply
fail to set your context, rather than try to guess which org unit
you meant.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
Kyle Tomita [Thu, 14 Mar 2013 22:01:14 +0000 (15:01 -0700)]
Patron Blocking by lost items and include lost as items out
This feature has two main parts, patron blocking by number
of lost items and include lost items as items out. A group penalty
threshold will be added for lost items. This will restrict patrons
who have lost too many items. The inclusion of lost items as items
out will be an optional setting, like claimed returned items. This
will allow libraries to set what type of item statuses count toward
the total items out.
Bill Erickson [Thu, 23 May 2013 13:11:25 +0000 (09:11 -0400)]
LP1183340 selectivly apply editable funds sorting
Avoid sorting editable funds to the front of the fund list when there
are no org units at which the user has the ADMIN_ACQ_FUND permission.
Otherwise, we are sorting on an empty 'IN' list in pcrud, which results
in an error.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
When delivering MARC21 via SuperCat, OpenSearch, offer filename w/ extension
If you want a record feed in MARC21, without this commit a web browser
just suggests "marc21" as the filename for saving to your local system.
Although many consumers of these feeds will be custom scripts and other
non-interactive software components that won't care about filename, for
the web browser case it's helpful if the server suggests a filename that
ends in .mrc.
So here we go.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Thu, 23 May 2013 20:32:49 +0000 (16:32 -0400)]
LP1081576 - fix utf8 characters in searches using portal page
Replace escape() with encodeURIComponent() on the portal page to allow utf8
characters to be passed more appropriately to the subsequent search in catalog.
Thanks Dan Scott for pointing this out.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Kathy Lussier [Sat, 25 May 2013 00:52:01 +0000 (20:52 -0400)]
Acquisitions Admin updates
Updates to the chapter on acquisitions administration, including 1) the
reintroduction of the Providers section, which appears to have dropped out
of the docs after 2.1 2) the new default # copies and improvements to
distributions formulas introduced in 2.4 and 3) minor copy editing.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Wed, 29 May 2013 22:06:09 +0000 (18:06 -0400)]
Change autoconf required version for libmar's configure.ac
Having it set to 2.68 (current for Ubuntu Precise) broke autoreconf for other
distributions. Notably Debian Squeeze/Wheezy have 2.67 and Ubuntu Lucid has
2.65 for their autoconf version.
Set a minimum requirement of 2.61 that we use in the existing options.
Jason Stephenson [Tue, 19 Mar 2013 12:38:31 +0000 (08:38 -0400)]
Fix segmentation fault in mbsdiff and fix crc by linking with libbz2.
Doh! I typed memcpy when I really wanted memset.
This does not actually introduce any new dependencies. Evergreen
updates/installation already requires bzip2. If bzip2 is present,
then libbz2 is present. We don't need libbz2 headers, just the
library itself for a single data structure used in crc32 calculation.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Stephenson [Tue, 19 Mar 2013 00:03:42 +0000 (20:03 -0400)]
Add libmar to build update tools to the repo.
This adds code from Mozilla to build a command line mar program and the
libmar library that it uses. This code is now dual-licensed under the
MPL 2.0 and GPL v2 or later.
We also add our own version of mbsdiff using a modified version of Colin
Percival's FreeBSD-licensed bsdiff program. We also copy the crc32 code
from Mozilla's updater.
Add libmar as "subpackage" in cofigure.ac.
Add AC_CONFIG_SUBDIRS macro call for Open-ILS/xul/staff_client/external/
libmar so that our update tools will get configured and built when
Evergreen is built.
Modify make_updates.sh for our update tools.
Instead of downloading mar and mbsdiff from Mozilla.org's servers,
we check if they exist in Open-ILS/xul/staff_client/external/libmar/tool
and if not we build them. They should be there already.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Thu, 23 May 2013 13:43:52 +0000 (09:43 -0400)]
LP1183357 Pass locale to bib search (tpac)
Pass the TPAC locale value, which is collected at each page load, to the
bib search API call. This allows us to take advantage of language-based
relevance bumps.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Thu, 11 Apr 2013 13:43:10 +0000 (06:43 -0700)]
Test dataset: authority records for concerto
Add a handful of authority records to match a subset of the Concerto
bib records. When the --load-all or --load-concerto options are passed
to eg_db_config, these authority records will be loaded. Running
"authority_control_fields -s 1 -e 100" will then generate 19 links from
Concerto bibs to corresponding authority records.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Fri, 10 May 2013 17:12:55 +0000 (13:12 -0400)]
TPAC: Death date missing from authors in record details
The trailing period prescribed by ISBD punctuation for x00 $d subfields
in certain circumstances confounds the regex that was expected the $d
subfield to match ^\s*\d{4}-\d{4}\s*$. As a result, death dates were
often being omitted from the record detail display. Relaxing the regex
to match against a trailing .* instead of \s* resolves the issue.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Ben Shum <bshum@biblio.org>
Clicking on an author with a dash or dates in the name on the search
results page comes up with 0 results. It looks like the dash is stripped
from the date and/or name.
Clicking on such a link from the record view actually works because
the dash is replaced with a space.
This branch changes table.tt2 to replace special characters in author
output with a space in the same way that authors.tt2 does.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Thu, 23 May 2013 16:09:55 +0000 (12:09 -0400)]
Avoid additional whitespace in password messages
Trivial enhancements to avoid extra linefeeds in generated HTML, as well
as including a linefeed at the end of the new password_reset_msg.tt2
file. Good old DOS vs. UNIX :)
Melissa Lefebvre [Fri, 10 May 2013 19:19:09 +0000 (15:19 -0400)]
TPAC - Password Messages
In jspac a message appeared when the patron went to change their
password stating the requirements. This same message is missing
in TPAC. The wording from jspac has been added to a separate
file, update_password_msg.tt2, that can later be easily edited
and the original update_password.tt2 has been edited with an
INCLUDE statement pointing to the newly created file.
Also improved is the message when requesting a forgotten password.
Patrons are unaware that a valid email address needs to be in
their record until after they try to send a reset. Text has been
added to a new file, password_reset_msg.tt2, to explain the need
for an email address. Password_reset.tt2 has been edited with
an INCLUDE statement pointing to the newly created file.
Style.css.tt2 was also updated to remove extra padding on
#account-update-email table to raise the table on
update_password.tt2. This value is also used on
update_username.tt2 and update_email.tt2 without considerable
impact to the look of those pages.
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
projects / Evergreen.git / log