Evergreen.git
14 months agoLP#1748006 Patron edit juv flag manual override
Bill Erickson [Fri, 9 Feb 2018 19:27:05 +0000 (14:27 -0500)]
LP#1748006 Patron edit juv flag manual override

Allow staff to manually override the patron juvenile flag value
regardless of patron DoB.

Patch removes the ng-blur handler for dob and expire_date, which fires
too aggressively.  The dob handler is replaced with a $watch handler, so
the new and old value can be compared.  No watch is applied to
expire_date, since no code is currently fired when it's changed.

Change the log level of the "field changed" message from log to debug.

To test:

[1] Open a patron in the web staff patron editor.
[2] Apply a juvenile birth date (less than 18 years by default).
[3] Confirm the juvenile flag is automatically activated (if it wasn't
    already).
[4] Confirm it's possible to un-check the juvenile flag and save the
    patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1752434: (follow-up) fix un/highlighting of author name
Galen Charlton [Mon, 30 Apr 2018 18:43:02 +0000 (14:43 -0400)]
LP#1752434: (follow-up) fix un/highlighting of author name

This patch fixes a regression introduced by the previous patch
that caused portions of an author/contributor name that matched
a search to always be highlighted, regardless of whether or not
the user had turned off highlighting.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1752434: Use display fields even when not highlighting
Mike Rylander [Thu, 1 Mar 2018 20:34:02 +0000 (15:34 -0500)]
LP#1752434: Use display fields even when not highlighting

Always retrieve display field data, and decide whether to use the highlighted
version of each based on the configuration and user option rather than falling
back to template-side MARC extraction when not highlighting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP173259 - Array error appears in search box while placing hold after advanced search
Dan Pearl [Fri, 2 Mar 2018 18:37:43 +0000 (13:37 -0500)]
LP173259 - Array error appears in search box while placing hold after advanced search

The place-hold code assumed it was not in "_adv" parameter mode.  This
assumption was faulty.  Now, the link generated for Place Hold will
translate the argument list to the single-line format that Place Hold
expected, when necessary.

Testing procedure:

Set holds for all the following items, observing that the searchbox in
the searchbar is not blank and does not contain ARRAY(xxx).

Basic Search / Place Hold
Basic Search / Record Detail / Place Hold
Advanced Search with a plain search term / Place Hold
Advanced Search with a plain search term / Record Detail / Place Hold
Advanced Search with a fancy (multiline) search term / Place Hold
Advanced Search with a fancy (multiline) search term / Record Detail / Place Hold

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
14 months agoLP#1738249: sort out circ or renewal workstation
Galen Charlton [Tue, 6 Feb 2018 21:56:56 +0000 (16:56 -0500)]
LP#1738249: sort out circ or renewal workstation

This patch uses accs to work out the name of the workstation
of the most recent renewal, if it exists, or the original
checkout. It implicitly handles the case where the workstation
on the original circulation is null.  As a bonus, this patch
adds an explicit "Last Renewal Workstation" to the item status
grid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
14 months agoLP#1738249: further fix to checkout workstation
Galen Charlton [Tue, 6 Feb 2018 21:44:32 +0000 (16:44 -0500)]
LP#1738249: further fix to checkout workstation

Since accs.checkout_workstation contains the workstation associated
with the initial loan (and not any subsequent renewals), use that.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
14 months agoLP#1738249 - Fix checkout_workstation display issue
Cesar Velez [Thu, 25 Jan 2018 17:50:59 +0000 (12:50 -0500)]
LP#1738249 - Fix checkout_workstation display issue

Addresses the issue with checkout workstation, by
attaching as a object property to the flatCopy hash.
Also makes sure the pcrud call uses combcirc.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
14 months agoLP#1738249 - Webstaff CircLib should point to item's circ_lib plus misc
Cesar Velez [Fri, 19 Jan 2018 17:55:03 +0000 (12:55 -0500)]
LP#1738249 - Webstaff CircLib should point to item's circ_lib plus misc

This addresses some display issues in the webstaff Item Status grid.
Besides, correcting the Circ Lib to be the item's and not the
circulation,this also fleshes the owning lib. Additionally, I've applied
miker's fix to 1743819 in order to prevent a regression.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
14 months agoLP#1738249: Item status column picker fixes
Kathy Lussier [Wed, 17 Jan 2018 04:40:32 +0000 (23:40 -0500)]
LP#1738249: Item status column picker fixes

Adds some fixes to the column pickers in the web staff client Item Status
interface:

  * The Circulation Library field now displays the asset.copy circ library
    instead of the checkout library.
  * The Circulation Library and Checkout / Renewal Library now show the
    shortname instead of the full name.
  * A typo fix so that Remaining Renewals display

Conflicts:
Open-ILS/src/templates/staff/cat/item/t_list.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
14 months agoLP#1756993: Add padding to bottom of web client pages
Kathy Lussier [Mon, 19 Mar 2018 20:15:01 +0000 (16:15 -0400)]
LP#1756993: Add padding to bottom of web client pages

Adds 50px of padding at the bottom of web client interfaces. This padding
provides some breathing room at the bottom of the page without giving the
appearance of too much white space.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1746300: Fix circulation counts in Item Status Details
Chris Sharp [Tue, 10 Apr 2018 15:40:35 +0000 (11:40 -0400)]
LP#1746300: Fix circulation counts in Item Status Details

Currently, the "Total Circs -Current Year" and "Total Circs -
Prev Year" numbers are seemingly randomly incorrect.  This is
caused by pulling the numbers from the "circbyyr" fieldmapper
object, which results in an array of 2 rows (one for renewals
and one for new circs).  The current JS only displays the count
for the first item in the array, ignoring the other.

This branch totals the two, resulting in the right result for each
year's circulations.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1758360: handle DOB display logic in egPatronSummary correctly
Galen Charlton [Fri, 23 Mar 2018 18:48:02 +0000 (14:48 -0400)]
LP#1758360: handle DOB display logic in egPatronSummary correctly

This patch ensures that the patron DOB will be displayed or
obscured correctly by the standalone egPatronSummary directive
in the same way that the patron app does.

To test
-------
[1] In the web staff client, do a patron search, select two patrons,
    then click the Merge Patrons button.
[2] Note that the patron DOB is not displayed in the modal.
[3] Apply the patch and repeat step #1.
[4] This time, the patron DOB will be displayed (if the
    circ.obscure_dob library setting is not enabled) or the
    the field label will be clickable (and clicking it will
    cause the DOB to be displayed).

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
14 months agoLP1721143: making permission group dropdown scrollable in patron create/edit interface
Jane Sandberg [Sat, 17 Mar 2018 18:01:08 +0000 (11:01 -0700)]
LP1721143: making permission group dropdown scrollable in patron create/edit interface

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1682296: Avoid database query error on serials batch receive
Jeff Davis [Mon, 22 May 2017 20:26:10 +0000 (13:26 -0700)]
LP#1682296: Avoid database query error on serials batch receive

To test
-------
[1] Example Search -> Retrieve title by database ID -> Actions
    for this Record -> Serials Batch Receive -> Next ->
    this works as expected & receivable issues are listed.
[2] Click on "Start Over"; you are prompted to "Enter an identifier
    for a bibliographic record" this is where the search fails

    Example enter "109242427" results in two errors.

[3] Desired behavior - If you enter a database ID or ISSN in the
    "Enter an identifier for a bibliographic record" field the
    receivable issuances should be displayed

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1744585: Patron summary display accessibility fix.
Sam Link [Wed, 24 Jan 2018 15:34:56 +0000 (10:34 -0500)]
LP#1744585: Patron summary display accessibility fix.

When a patron summary contains an image of the patron, that image tag
now has a null alt attribute to remove it from the flow of a screen
reader. As the image provides no navigation capabilities or additional
data, this is the proper way to assign an alt attribute

Signed-off-by: Sam Link <slink@columbiacountyga.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1739044: fix lock file detection in eg-pbx-allocator.pl
Josh Stompro [Tue, 19 Dec 2017 14:37:55 +0000 (08:37 -0600)]
LP#1739044: fix lock file detection in eg-pbx-allocator.pl

Lock file detection wasn't working correctly.  The
wrong operator was used to read the contents of the lock file.

Testing:

Running the eg-pbx-allocator.pl in the background multiple times will
trigger the lock file detection.  Use -t to run in test mode to avoid
moving any files while testing.

/usr/local/bin/eg-pbx-allocator.pl -t -v -c /usr/local/etc/eg-pbx-daemon.conf &
/usr/local/bin/eg-pbx-allocator.pl -t -v -c /usr/local/etc/eg-pbx-daemon.conf

In syslog you can see entries that are missing the PID number when you test
before the fix is installed.

virt-asterisk1 eg-pbx-allocator.pl: lock file present (/tmp/eg-pbx-allocator-LOCK),  still running

after the fix is installed, you will see the PID in the syslog entry.

virt-asterisk1 eg-pbx-allocator.pl: lock file present (/tmp/eg-pbx-allocator-LOCK), 21039 still running

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1745001 - action_trigger_runner.pl max-sleep argument broken.
Josh Stompro [Tue, 23 Jan 2018 19:19:20 +0000 (13:19 -0600)]
LP#1745001 - action_trigger_runner.pl max-sleep argument broken.

Fix the --max-sleep argument so it accepts an integer number of max
seconds to sleep waiting for a lock file to disappear.

Testing:

Before Fix: Add --max-sleep=60 to action_trigger_runner.pl and view the
error message that results.

After Fix: Run the same command and notice that it no longer errors out.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1760223: Update HTTP headers to follow standard
Mike Rylander [Mon, 2 Apr 2018 20:09:12 +0000 (16:09 -0400)]
LP#1760223: Update HTTP headers to follow standard

In the olden days, some browsers didn't understand the "attachment" content
disposition.  They only understood "inline" but would let the user save a file
if a filename was provided.  However, in these modern days, relevant browsers
all do the right thing and know about both flavors of content disposition, so
we, too, must change with the times and support the letter of the standard.

This commit fixes downloading of MARCXML from the Exporter module.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
14 months agoLP#1745233: Don't test for LURIs during copy location searches
Mike Rylander [Mon, 16 Apr 2018 14:29:05 +0000 (10:29 -0400)]
LP#1745233: Don't test for LURIs during copy location searches

When a user is searching with a copy location or location group filter,
Located URIs should not be used to include records in the result set because
they are not "within" a copy location.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoDocs: Update several chapters for web client
Remington Steed [Fri, 20 Apr 2018 16:09:55 +0000 (12:09 -0400)]
Docs: Update several chapters for web client

  - User and Group Permissions
    - One new screenshot
    - Minor line reformatting
  - SMS Text Messaging
    - Update screenshots and alt text
    - Correction/clarification to some instructions
  - Barcode Completion
    - Replace composite screenshot with separate updated screenshots
    - Reformat headings to accommodate new screenshots
    - Update other screenshots
    - Slight rewording (change "actor" to "patron", "asset" to "copy")
    - Remove release date and reference to previous name of feature

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoForward-port 3.0.7 upgrade script
Dan Wells [Thu, 19 Apr 2018 13:49:54 +0000 (09:49 -0400)]
Forward-port 3.0.7 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoForward-port 3.1.1 upgrade script
Dan Wells [Thu, 19 Apr 2018 13:41:52 +0000 (09:41 -0400)]
Forward-port 3.1.1 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoForward-port upgrades notes from 3.1.0
Dan Wells [Wed, 18 Apr 2018 20:41:59 +0000 (16:41 -0400)]
Forward-port upgrades notes from 3.1.0

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoTouch up release notes for 3.1.1
Dan Wells [Wed, 18 Apr 2018 20:25:54 +0000 (16:25 -0400)]
Touch up release notes for 3.1.1

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoTouch up release notes for 3.0.7
Dan Wells [Wed, 18 Apr 2018 20:25:34 +0000 (16:25 -0400)]
Touch up release notes for 3.0.7

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLP1760662: Item Status Holdable Field Display Follow-up
Jason Stephenson [Mon, 2 Apr 2018 20:14:43 +0000 (16:14 -0400)]
LP1760662: Item Status Holdable Field Display Follow-up

Remove the boolText filter because it was always return false.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLP1760662: Item Status Holdable Field Display
Jason Boyer [Mon, 2 Apr 2018 17:55:02 +0000 (13:55 -0400)]
LP1760662: Item Status Holdable Field Display

The Holdable field on the Summary tab of the Detail View
of Item Status was displaying the value for OPAC Visible.
Let's change that from opac_visible() to holdable().

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLp 1735539: Fix Item Status ability to delete multiple copies.
Jason Stephenson [Thu, 12 Apr 2018 14:47:40 +0000 (10:47 -0400)]
Lp 1735539: Fix Item Status ability to delete multiple copies.

Use the notify handler instead of the resolve handler to collect our
copies.  This ensures we get them all instead of just the last one.

To reproduce the bug:
   1. Open Item Status in the web staff client.
   2. Load multiple items, perhaps by uploading a file of barcodes.
   3. Select more than 1 item from the list.
   4. Choose "Delete Items" from the Actions menu.
   5. Note that the dialog indicates that you will delete 1 copy.
   6. Click the Cancel button in the dialog.

To test, after applying the fix branch:
   1. Open Item Status in the web staff client.
   2. Load multiple items, perhaps by uploading a file of barcodes.
   3. Select more than 1 item from the list.
   4. Choose "Delete Items" from the Actions menu.
   5. Note that that the dialog indicates you will delete X copies,
      where X is the number of items selected.
   6. Click OK and confirm that all copies were deleted.
   7. You can confirm 6 by reloading the interface and uploading the
      file of barcodes again.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoDocs: starting release notes for 3.1.1
Jane Sandberg [Tue, 17 Apr 2018 19:14:35 +0000 (12:14 -0700)]
Docs: starting release notes for 3.1.1

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoDocs: starting release notes for 3.0.7
Jane Sandberg [Tue, 17 Apr 2018 18:52:24 +0000 (11:52 -0700)]
Docs: starting release notes for 3.0.7

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoDocs: Minor updates in Ordering_materials.adoc
Morkor Quarshie [Tue, 10 Apr 2018 20:14:49 +0000 (16:14 -0400)]
Docs: Minor updates in Ordering_materials.adoc

  - A menu item was slightly incorrect. This fixes it.
  - Added a missing step to click "New" button.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoLP#1729934 Webstaff display org-scoped penalties
Bill Erickson [Thu, 29 Mar 2018 21:06:16 +0000 (17:06 -0400)]
LP#1729934 Webstaff display org-scoped penalties

Consistent with the XUL client, only display patron standing penalties
(AKA Messages) that are linked to an org unit which is an ancestor,
matching, or descendant org unit of the workstation (e.g. the full
path).

To test:

[1] Create a patron Message which applies to a branch using a branch or
null-depth penalty (e.g. at BR1).

[2] Create a second message that links to the root org unit (e.g. CONS)
via depth=0 penalty.

[2] Log out and back in to the browser client at a workstation under a
different section of the org unit tree (e.g. BR3) and confirm the
Messages created at BR1 do not display, but the messages created at CONS
do.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1729934 Webstaff penalty create org/depth repair
Bill Erickson [Fri, 5 Jan 2018 19:55:56 +0000 (14:55 -0500)]
LP#1729934 Webstaff penalty create org/depth repair

Apply correct org unit to patron penalties created in the web staff
client.  Specifically, be sure the standing penalty depth value is
honored when set.

Commit replaces manual pcrud creation with the XUL-tested API, which
calculates the correct org unit by depth for us.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Jane Sandberg [Tue, 10 Apr 2018 23:30:54 +0000 (16:30 -0700)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

15 months agoDocs: adding some basic info about getting data from opensearch
Jane Sandberg [Tue, 10 Apr 2018 23:30:39 +0000 (16:30 -0700)]
Docs: adding some basic info about getting data from opensearch

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoDocs: Update "Ordering materials" for web client
Remington Steed [Tue, 10 Apr 2018 18:00:31 +0000 (14:00 -0400)]
Docs: Update "Ordering materials" for web client

  - Update menu names to match web client

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: updating marc_export options documentation
Jane Sandberg [Tue, 10 Apr 2018 16:07:55 +0000 (09:07 -0700)]
Docs: updating marc_export options documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoDocs: Update "Acquisitions Admin" for web client
Remington Steed [Tue, 10 Apr 2018 14:43:27 +0000 (10:43 -0400)]
Docs: Update "Acquisitions Admin" for web client

  - Change menu names to match web client ("Admin" to "Administration", and
    "Server Admin -> Acq" becomes "Acq Admin")
  - Fix list formatting where images were breaking a numbered list into
    two lists

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoForward-port 3.1.0 upgrade script
Dan Wells [Mon, 9 Apr 2018 14:50:34 +0000 (10:50 -0400)]
Forward-port 3.1.0 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoDocs: Update "User Activity Types" for web client
Remington Steed [Thu, 29 Mar 2018 21:12:19 +0000 (17:12 -0400)]
Docs: Update "User Activity Types" for web client

  - Update screenshot, provided by Kevin Tran

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Update "Z39.50 Servers" for web client
Remington Steed [Thu, 29 Mar 2018 20:58:19 +0000 (16:58 -0400)]
Docs: Update "Z39.50 Servers" for web client

  - Switch incorrectly placed screenshots
  - Update first screenshot for web client

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Update circulation_limit_groups.adoc for web client
Kevin Tran [Thu, 1 Mar 2018 16:34:10 +0000 (11:34 -0500)]
Docs: Update circulation_limit_groups.adoc for web client

  - Updated menu label to "Circ Limit Sets".

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Add screenshots to "Load MARC Order Records"
Remington Steed [Thu, 29 Mar 2018 13:55:08 +0000 (09:55 -0400)]
Docs: Add screenshots to "Load MARC Order Records"

Thanks to Morkor Quarshie for the screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Update "User and Group Permissions" for web client
Remington Steed [Wed, 21 Mar 2018 21:01:05 +0000 (17:01 -0400)]
Docs: Update "User and Group Permissions" for web client

  - Update instructions for web client
  - New screenshot shows menu path from patron screen. Thanks to Kevin
    Tran for the screenshot.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Update MARC_RAD_MVF_CRA.adoc for web client
Kevin Tran [Thu, 15 Mar 2018 14:48:09 +0000 (10:48 -0400)]
Docs: Update MARC_RAD_MVF_CRA.adoc for web client

  - Updated instructions for web client
  - Narrower screenshot (with arrow) for Coded Value Map section

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: New screenshot for "MARC Import Remove Fields"
Remington Steed [Wed, 21 Mar 2018 20:20:50 +0000 (16:20 -0400)]
Docs: New screenshot for "MARC Import Remove Fields"

  - New screenshot for "MARC Import Remove Fields", which still showed
    small amount of XUL client. Thanks to Kevin Tran for the screenshot.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Update "Selection Lists" and "Invoices" for web client
Remington Steed [Thu, 29 Mar 2018 12:51:28 +0000 (08:51 -0400)]
Docs: Update "Selection Lists" and "Invoices" for web client

  - Update references to Acq Admin menu
  - Make menu name formatting more consistent (should be bold or
    italics)
  - Remove outdated reference to old Evergreen version under "Activate
    Purchase Order with Zero Copies"

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months agoDocs: Update "Hold-driven recalls" for web client
Remington Steed [Wed, 28 Mar 2018 19:53:18 +0000 (15:53 -0400)]
Docs: Update "Hold-driven recalls" for web client

  - Update reference to "Admin" menu
  - Remove old note about when feature was added to Evergreen

Signed-off-by: Remington Steed <rjs7@calvin.edu>
15 months ago2.12.11-2.12.12 schema update
Galen Charlton [Wed, 28 Mar 2018 14:40:59 +0000 (10:40 -0400)]
2.12.11-2.12.12 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months ago3.0.5-3.0.6 schema update
Galen Charlton [Wed, 28 Mar 2018 14:38:59 +0000 (10:38 -0400)]
3.0.5-3.0.6 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agorelease notes for Evergreen 3.0.6
Galen Charlton [Wed, 28 Mar 2018 14:29:12 +0000 (10:29 -0400)]
release notes for Evergreen 3.0.6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agorelease notes for Evergreen 2.12.12
Galen Charlton [Wed, 28 Mar 2018 14:14:41 +0000 (10:14 -0400)]
release notes for Evergreen 2.12.12

15 months agoLP#1757526: escape more catalog data (MFHD edition)
Galen Charlton [Tue, 27 Mar 2018 20:30:35 +0000 (16:30 -0400)]
LP#1757526: escape more catalog data (MFHD edition)

This patch ensures that data derived from MFHDs is escaped
for in the issues held tab on the public catalog record display
page.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agoLP1757526 Escape displayed catalogue data
Dan Scott [Wed, 21 Mar 2018 21:08:35 +0000 (22:08 +0100)]
LP1757526 Escape displayed catalogue data

Content in content fields (5xx) as well as for the names of locations in copy
count alt text was not being properly escaped, allowing for the possibility of
executing arbitrary JavaScript in the case of a malicious catalogue record
(whether edited in the system, or imported)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agoDocs: fund tag preservation
Jane Sandberg [Wed, 28 Mar 2018 14:08:04 +0000 (07:08 -0700)]
Docs: fund tag preservation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoDocs: small readability changes to 3.1 release notes
Jane Sandberg [Wed, 28 Mar 2018 13:23:28 +0000 (06:23 -0700)]
Docs: small readability changes to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoDocs: adding info about new setting to 3.1 release notes
Jane Sandberg [Wed, 28 Mar 2018 13:04:01 +0000 (06:04 -0700)]
Docs: adding info about new setting to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
15 months agoSmall fix to release note numbering
Dan Wells [Mon, 26 Mar 2018 16:46:06 +0000 (12:46 -0400)]
Small fix to release note numbering

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoTranslation updates - po files
Dan Wells [Mon, 26 Mar 2018 13:33:49 +0000 (09:33 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoTranslation updates - newpot
Dan Wells [Mon, 26 Mar 2018 13:16:23 +0000 (09:16 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLP#1699838: Stamping upgrade script for default pickup lib YAOUS
Kathy Lussier [Fri, 23 Mar 2018 19:39:49 +0000 (15:39 -0400)]
LP#1699838: Stamping upgrade script for default pickup lib YAOUS

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1699838 Scale back settings for staff-based hold placement
Dan Wells [Fri, 23 Mar 2018 17:07:45 +0000 (13:07 -0400)]
LP#1699838 Scale back settings for staff-based hold placement

For now, we will add just one new setting to optionally restore the old
behavior.  In the absence of a 'preferred pickup location', the staff
form will default to the staff workstation OU.

Also, add setting to seed data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

15 months agoLP1699838 - add YOUSes for defaulting hold pickup locs
Cesar Velez [Wed, 28 Feb 2018 19:08:08 +0000 (14:08 -0500)]
LP1699838 - add YOUSes for defaulting hold pickup locs

Add a YAOUS... err make that two, to control how staff-placed holds
default the pickup library.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1693036: Simplify template, cleanup preview data
Remington Steed [Fri, 23 Mar 2018 14:46:32 +0000 (10:46 -0400)]
LP#1693036: Simplify template, cleanup preview data

This commit corrects a few minor problems, and also attempts to simplify
and cleanup the template. The changes include:

  - Adding the missing "ident_type2" field to the template and JS
  - Adding missing sample data for "county"
  - Moving "postal code" closer to the standard location (at the end of
    the address)
  - Fixing typos, and making "Claims..." labels more consistent
  - Minor cleanup of the sample data
  - Removing template comments that list available variables, because
    this template is simpler than most, intended to print everything

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLP#1693036: follow-up: fix printing of daytime phone number
Galen Charlton [Wed, 14 Mar 2018 14:33:27 +0000 (10:33 -0400)]
LP#1693036: follow-up: fix printing of daytime phone number

This patch corrects how the 'day_phone' field should be referred
to in the print template.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agolp1693036 Patron Editor Print Data
Kyle Huckins [Thu, 15 Feb 2018 23:03:20 +0000 (23:03 +0000)]
lp1693036 Patron Editor Print Data

- Add Print button to Patron Editor.
- Add Patron Data print template.
- Add additional print template dummy data needed for Patron
Data template.
- Implement print functionality for Patron registration/edit
data.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>/
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLP#1758322: Fix lp1731960_test_preserving_bookbag_entries test
Kathy Lussier [Fri, 23 Mar 2018 12:35:56 +0000 (08:35 -0400)]
LP#1758322: Fix  lp1731960_test_preserving_bookbag_entries test

A typo inserted the incorrect record number for the
 lp1731960_test_preserving_bookbag_entries. This patch fixes
the typo.

Thanks to Jason Boyer for spotting the problem!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agoLP#1758347: ensure that upgrade includes latest asset.merge_record_assets()
Galen Charlton [Fri, 23 Mar 2018 14:23:19 +0000 (10:23 -0400)]
LP#1758347: ensure that upgrade includes latest asset.merge_record_assets()

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agoLP#1731960: Stamping upgrade script for preserve book bags on bib merge
Kathy Lussier [Thu, 22 Mar 2018 23:36:19 +0000 (19:36 -0400)]
LP#1731960: Stamping upgrade script for preserve book bags on bib merge

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1731960: adding upgrade script for updating the function
Rogan Hamby [Thu, 22 Mar 2018 17:50:52 +0000 (13:50 -0400)]
LP#1731960: adding upgrade script for updating the function

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1731960-preserving book bag entries with new values during bib merge
Rogan Hamby [Tue, 21 Nov 2017 23:50:34 +0000 (18:50 -0500)]
LP#1731960-preserving book bag entries with new values during bib merge

The asset.merge_record_assets() removes bib records from containers when
merging and deleting the record as appropriate but bib containers with
the btype of 'bookbag' (used as reading lists) should instead be updated
to the new bib record. Includes Pgtap test.

Signed-off-by: Rogan Hamby <rhamby@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/999.functions.global.sql

15 months agoForward port 2.12.11 upgrade script
Dan Wells [Thu, 22 Mar 2018 19:36:50 +0000 (15:36 -0400)]
Forward port 2.12.11 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoForward port 3.0.5 upgrade script
Dan Wells [Thu, 22 Mar 2018 18:39:14 +0000 (14:39 -0400)]
Forward port 3.0.5 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
15 months agoLP#1755502 Fix hold user test
Dan Wells [Thu, 22 Mar 2018 14:31:58 +0000 (10:31 -0400)]
LP#1755502 Fix hold user test

Now that we are fleshing this field, we need to dig a little deeper
for the 'id' to test if we are the same user.

To test
-------
[1] Set up a patron with a hold request and with a item
    on the hold shelf that fills the hold.
[2] Check out the item to patron. Note that you
    will get a ITEM_ON_HOLDS_SHELF alert, even though the
    item is on hold for that patron. Cancel the alert.
[3] Apply the patch and repeat step 2. This time, the checkout
    will proceed.
[4] Set up another patron with a hold request and an item
    on the hold shelf, then checkout it at to a _different_ patron.
    Verify that the ITEM_ON_HOLDS_SHELF alert appears.

This patch also fixes test failures caught by the
19-lp1306666-abort-transit-copy-status.t live test.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agoLP#1728147: more tweaks to grid
Galen Charlton [Thu, 22 Mar 2018 16:51:45 +0000 (12:51 -0400)]
LP#1728147: more tweaks to grid

* Make paths to expire_time and cut_in_line more concise
* Add SMS Carrier column back
* Tweak labels of the patron first and last name columns
* Ensure that the "Call Number" column continues to be sortable
  by normalized call number label. Note that due to a quirk of
  egGrid, which doesn't currently have a way to specify that a column
  always be retrieved by a fielder query but /not/ be directly
  available as a displayable column, we also need a "Call Number Label"
  column at the moment.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1728147: correct fleshing of staff hold column
Galen Charlton [Thu, 22 Mar 2018 16:14:17 +0000 (12:14 -0400)]
LP#1728147: correct fleshing of staff hold column

This patch fixes the test (ahr.usr is fleshed, but not ahr.requestor)
and ensures that the value is cached correctly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1728147: Add patron's first/last name and Alias column
Cesar Velez [Fri, 16 Feb 2018 19:40:17 +0000 (14:40 -0500)]
LP#1728147: Add patron's first/last name and Alias column

These were also missing from the Holds Pull grid.

This patch also corrects the determination of whether a hold
was staff-placed or not.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1728147 - fix some Holds Pull List grid columns
Cesar Velez [Tue, 30 Jan 2018 18:13:52 +0000 (13:13 -0500)]
LP#1728147 - fix some Holds Pull List grid columns

This adds a few missing columns to the Holds Pull List grid,
and addresses a few display issues.

New columns added are Hold Type, Circ Mod, Staff Hold,
Email/Phone/SMS Notify, Copy Status Change Time, ISBN,
Edition, Top of Queue, Total Holds, and Expire Date.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1738488 Optimize Flattener join logic
Dan Wells [Fri, 2 Mar 2018 17:54:46 +0000 (12:54 -0500)]
LP#1738488 Optimize Flattener join logic

The current Flattener.pm autogenerates necessary joins for sorting
and filtering, but in doing so, it gives every intermediate table a
unique alias, even if the path to that table is exactly the same as
another member in the map we are flattening.

Instead, let's reuse joins whenever the path is identical, even for
intermediate tables.  We do so by tracking every path to each core
type, then reusing as much of that join path as we can.  In cases
where we have different paths to the same type, we still necessarily
provide a new unique alias.

This problem was first noticed in the web staff billing history
interface, where the particular stacking of joins resulted (for one
specific library) in 17 joins and 44,575,740,147,225,592,344,870,912
potential rows.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
15 months agoLP#1702557-Make Acq MarcEditor Just Have Save Button
Cesar Velez [Fri, 19 Jan 2018 19:43:38 +0000 (14:43 -0500)]
LP#1702557-Make Acq MarcEditor Just Have Save Button

Like the changes to the z3950 marceditor UI, and serials,
make the Acq marceditor have a simple Save button, instead
of the Modify + Save Edits buttons needed to save a change.
Same change as in 1710405, et al. Note this also fixes a
propagation issue that prevented changes from marceditor's
scope.marcXml from making it to the modal controller scope,
and being saved. Props to miker for helping me debug this!

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1361258 Patron reg repair user settings saving/loading
Bill Erickson [Mon, 19 Mar 2018 19:22:44 +0000 (15:22 -0400)]
LP#1361258 Patron reg repair user settings saving/loading

Avoid caching user setting values at the service (app) level in the user
editor.  In other words, always fetch a fresh copy of the current user's
setting with each instance of the editor page.

This solves a number problems where stale versions of the cached data
were referenced and acted on, both when displaying an updating user
settings.

Additionally, ensure that clone user and stage user data is refreshed
on all page instances as the URL params that affect these values can
change per instance.

Other data that is common to all instances (e.g. the set of profile
groups) is still cached as before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoLP#1742779: Distinguish between no statcat values and multiple values in copy editor...
Mike Rylander [Wed, 10 Jan 2018 16:25:27 +0000 (11:25 -0500)]
LP#1742779: Distinguish between no statcat values and multiple values in copy editor to assist staff

WRT stat cats, the copy editor in the web client will display the value of a
stat cat IFF all selected copies both use the stat cat AND use the same value
for that stat cat. Otherwise it displays <NONE>, which is confusing in the
case of some selected copies just not using the stat cat, or all selected
copies using it, but using different values.

This commit provides tracking of the mixed-use stat, and displays <MULTIPLE>
for the value instead of <NONE> in that case.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
15 months agoDocs: adding several bug fixes to 3.0.5
Jane Sandberg [Thu, 22 Mar 2018 14:05:21 +0000 (07:05 -0700)]
Docs: adding several bug fixes to 3.0.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
16 months agoLP#1752983: sort circ modifier list in precat checkout
Jeff Davis [Mon, 12 Mar 2018 18:09:23 +0000 (11:09 -0700)]
LP#1752983: sort circ modifier list in precat checkout

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
16 months agoLP#1755924: show circ modifier in Item Status list view
Jeff Davis [Wed, 14 Mar 2018 21:33:07 +0000 (14:33 -0700)]
LP#1755924: show circ modifier in Item Status list view

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
16 months agoLP#1755892: ensure profile is fleshed in patron search
Jeff Davis [Thu, 15 Mar 2018 21:58:16 +0000 (14:58 -0700)]
LP#1755892: ensure profile is fleshed in patron search

To test
-------
[1] Do a catalog search or retrieve a record in the web staff client.
[2] Click Place Hold.
[3] On the place hold screen, click Patron Search.
[4] Search for patrons (e.g. last name = "smith"). In the results grid,
    the Profile column is empty.
[5] Apply the patch and repeat steps 3 and 4. This time, the Profile
    column should contain the profile name.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
16 months agoLP#1747963 Fix "trim list" feature in web client
Remington Steed [Wed, 7 Feb 2018 19:41:47 +0000 (14:41 -0500)]
LP#1747963 Fix "trim list" feature in web client

The use of splice() here caused buggy behavior and seemed to be a typo,
so I tried using slice() instead. But that still didn't work correctly.
The list stopped adding items after it reached 21 total, so scanning a
new barcode didn't add it to the list but only refreshed the list.

Instead, this commit sets the length of the array to 20, which shortens
the array as described in the MDN documentation for Array.length. Now it
behaves like it did in the XUL client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
16 months agoLP#1743045: skip redundant grid refresh on checkin
Jeff Davis [Wed, 14 Mar 2018 22:10:23 +0000 (15:10 -0700)]
LP#1743045: skip redundant grid refresh on checkin

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
16 months agoLP#1756572: Update to point release notes to include underlined links
Kathy Lussier [Wed, 21 Mar 2018 14:01:01 +0000 (10:01 -0400)]
LP#1756572: Update to point release notes to include underlined links

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
16 months agoLP#1756572: accessibility tweaks to links in webstaff client
Galen Charlton [Sat, 17 Mar 2018 17:38:01 +0000 (13:38 -0400)]
LP#1756572: accessibility tweaks to links in webstaff client

This patch changes the default
text color of text inside egGrid cells to #000; changes the default text
color to #000 (but note that more work would be needed to do this
comprehensively); and adds underlines to links inside grid cells.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
16 months agoDocs: adding 3.0.5 release notes
Jane Sandberg [Tue, 20 Mar 2018 21:49:56 +0000 (14:49 -0700)]
Docs: adding 3.0.5 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
16 months agoDocs: adding 2.12.11 release notes
Jane Sandberg [Tue, 20 Mar 2018 21:29:07 +0000 (14:29 -0700)]
Docs: adding 2.12.11 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
16 months agoLP#1756110: fix egBasicComboBox drop-down functionality
Galen Charlton [Thu, 15 Mar 2018 15:13:27 +0000 (11:13 -0400)]
LP#1756110: fix egBasicComboBox drop-down functionality

Somehow egBasicComboBox got missed when it became necessary to
switch to the newer way of specifying Bootstrap drop-downs. This
patch rectifies that and fixes the drop-down functionality.

To test
-------
[1] Create a report template in the web staff report editor and
    add a filter field.
[2] Attempt to change the filter operator. Note that nothing happens
    when the drop-down button is clicked.
[3] Apply the patch and repeat step 2. This time, the drop-down
    should work and display the list of available filter operators.

Other places affected include:

- The part selector in the volume/copy editor
- Template selector in the volume/copy editor
- Template selector in the labels interface
- Routing label selector in the subscription manager
- Call number prefix and suffix selectors in the serials batch receiving
  interface

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
16 months agoLP#1721807: fix webstaff report templates that have might_have and has_many joins
Galen Charlton [Tue, 6 Mar 2018 23:00:23 +0000 (18:00 -0500)]
LP#1721807: fix webstaff report templates that have might_have and has_many joins

This patch fixes a bug where using a virtual field in the web staff
report template editor to join another table would result in a syntax
error in the generated SQL.

To test
-------
[1] Apply the patch and verify that the regression test in the previous
    commit passes.
[2] Create new report template in the web staff client that include
    virtual fields and joins and verify that they work. One example
    would be a report that uses ILS User as the base source and joins
    in the patron notes virtual field.
[3] If available, clone a report template originally created in the web
    staff client that had previously failed, then save it. The new
    report should work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
16 months agoLP#1721807: regression test
Galen Charlton [Wed, 7 Mar 2018 19:27:44 +0000 (14:27 -0500)]
LP#1721807: regression test

This adds an automated regression test as well as some additional
unit tests for the web staff reporter app and template service.  This
patch could be applied by itself to verify that the regression
test (run using 'npm run test' for master or 'grunt test' for rel_3_0)
fails.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
16 months agoDocs: Adding an affiliation; updating CW MARS name in 3.1 release notes
Jane Sandberg [Sun, 18 Mar 2018 15:20:32 +0000 (08:20 -0700)]
Docs: Adding an affiliation; updating CW MARS name in 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
16 months agoDocs: Adding affiliations and documenters to 3.1 release notes
Jane Sandberg [Sun, 18 Mar 2018 15:15:29 +0000 (08:15 -0700)]
Docs: Adding affiliations and documenters to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
16 months agoLP#1746365 Change default staff link colors to provide adequate contrast
Kathy Lussier [Tue, 6 Feb 2018 16:40:11 +0000 (11:40 -0500)]
LP#1746365 Change default staff link colors to provide adequate contrast

The default link color from bootstrap works well on white backgrounds, but
doesn't provide adequate contrast once the background color is changed.
This introduces accessbility problems, particularly in cases where linked
text displays on a selected grid row that uses a light blue background
color. This change provides a darker default link color.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
16 months agoDocs: Add aspell wordlist to improve spellchecking
Remington Steed [Fri, 16 Mar 2018 15:18:11 +0000 (11:18 -0400)]
Docs: Add aspell wordlist to improve spellchecking

To spellcheck the docs:

  - Go into the docs/ directory.
  - Copy the wordlist to your home directory (making a backup of your
    existing wordlist, if you have one):
    - cp --backup .aspell.en.pws ~/
  - Run 'aspell' over all AsciiDoc files, except release notes. Don't
    need to create backup files, since we're under version control. This
    runs the interactive spellchecker; use it to fix incorrect words, or
    add new correct words to the wordlist:
    - for f in $(find . -name '*.adoc' -and ! -name 'RELEASE*'); do
      aspell check --ignore-case --dont-backup $f; done
  - Review your changes:
    - git diff
  - Commit spelling corrections in one commit. Noteworthy changes should
    be included in the commit message.
  - Commit changed wordlist in a separate commit.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
16 months agoDocs: Spell check corrections
Remington Steed [Fri, 16 Mar 2018 14:58:17 +0000 (10:58 -0400)]
Docs: Spell check corrections

I walked through all the docs (except for release notes) and made a
number of small corrections. Most of them are simple typos, but there
are a few special cases:

  - In cases where the correction required matching with actual code or
    labels in Evergreen, those were checked to make sure the correction
    matched.
  - Changed spelling of "correct" word "Transcendent" to match database
    spelling "transcendant"
  - Changed very informal contractions "it'll" and "that'll" to "it
    will" and "that will". Same for "whatever's" to "whatever is".
  - Changed very informal expressions: "handwaving" to "glossing",
    "modernish" to "modern", "deduping" to "deduplicating".
  - Changed "unclick" to "uncheck" (regarding a checkbox)

Signed-off-by: Remington Steed <rjs7@calvin.edu>