Bill Erickson [Wed, 27 Mar 2019 16:43:32 +0000 (12:43 -0400)]
Coerce numbers for bib IDs in Angular staff catalog
Under some circumstances, the search results screen in the new
experimental Angular staff catalog did not display any results (though
it did show the pager, facets, etc.).
This was traced back to the results array attempting to be populated
with ID values of '-1' instead of the real IDs. Coercing the incoming
IDs to numbers appears to resolve the issue.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Mon, 25 Mar 2019 20:29:27 +0000 (20:29 +0000)]
LP1811288 Allow Combobox to default to field id
If a combobox field is provided without a label, use the id value as the
display value. This helps avoid ugly JS errors while trying to format
a null string.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 22 Mar 2019 21:43:34 +0000 (14:43 -0700)]
LP1811288 Admin grids preload combobox values
Adds a global option to the fieldmapper editor component to preload
linked selector values by default. Update the basic admin pages to use
the new flag to preload comboboxes.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Wed, 20 Feb 2019 18:51:36 +0000 (13:51 -0500)]
LP1811288 Basic admin page readonlyFields repair
Fix a bug in the basic admin page component that prevented the readOnly
fields from successfully propagating to the fieldmapper editor.
To Test:
1. Navigate to /eg2/en-US/staff/admin/booking/resource_type
2. Click "New Resource Type"
3. Confirm the "Bibliographic Record" field is disabled.
Includes ng-lint repair as well.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Thu, 10 Jan 2019 23:04:59 +0000 (18:04 -0500)]
LP1811288 Angular fm-editor uses combobox
* Linked field options traditionally rendered via <select> are now
rendered with an eg-combobox.
* Caller has option to force a combobox to preload values or rely solely
on typehead.
* Caller has option to provide a canned list of combobox values.
* Caller has option to set / override which field on the linked class
should searched by the typeahead
* General improvements to fm-editor form building and field options
management.
* Includes Angular7 rxjs import repairs
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 11 Jan 2019 18:06:23 +0000 (13:06 -0500)]
LP1811288 Combobox support entrylist+async / id labels
Allow the caller to pass a seed entrylist value for async comboboxes.
This is useful when a value should be applied to the box on load instead
of waiting for user input for typeahead loading.
Allow combobox entries to default to using the 'id' field for the label
if no label is provided.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 22 Mar 2019 20:41:12 +0000 (13:41 -0700)]
LP1821409 Ang admin editor clears fields on new
The Angular admin pages re-use an FmEditor component for creating and
updating objects. When creating a new object after editing an existing
object, reset the editor so it won't load the previously edited object.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 8 Mar 2019 18:16:35 +0000 (13:16 -0500)]
LP1819179 PCRUD selector fleshing handles maps
Teach the PCUD selector fleshing code to handle selector fields on
mapped classes, where an intermediate object flesh is performed by pcrud
at flesh time.
Adds a 'selector' column on metabib.metarecord in the IDL so that we can
have a functioning example of this to use in the sandbox test code.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 8 Mar 2019 17:30:26 +0000 (12:30 -0500)]
LP1819179 IDL2js includes 'map' attribute data
Patch from Mike Rylander to teach the IDL2js generator to include 'map'
attributes, which allow JS clients to step through mapped, linked
fields, particuarly useful for auto-fleshing these fields.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Wed, 6 Mar 2019 22:41:25 +0000 (17:41 -0500)]
LP#1819179: Angular value formatter gets link smarts
Teach the FormatService to display selector values for linked objects
when the requested field is a link field and it contains an object value
instead of just a id/key value.
Improve IDL data passing from the grid to the IDL service so it can
better determine which fields are avialble for link selector display.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 25 Jan 2019 20:17:56 +0000 (15:17 -0500)]
LP1812670 Angular grid shows selector labels
* Teach PcrudService how to flesh link fields when a selector is defined
on the linked class. This uses a new search/retrieve API flag
{fleshSelectors:true}.
* Teach the grid how to render selector values when configured to do so
via a new grid component attribute [showLinkSelectors]="true".
* Teach the Angular staff admin page to request linked selectors from
pcrud and tell its grid to expect them.
* Adds utility function to IdlServer for finding the selector for a
given class + field.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Wed, 23 Jan 2019 22:30:26 +0000 (17:30 -0500)]
LP1807461 Admin page avoid errors on dialog dismissal
Add support to the base DialogComponent class for passing information to
the caller via the reject handler about whether a dialog was dismissed
via user interface interaction (body click, esc key, cross click, cancel
button) or for some other reason, presumably an error.
Teach the generic admin page to avoid toasting errors when an edit or
create dialog is dismissed via UI.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Adds a new "Edit Selected" action to the "Actions for Selected Items"
menu in the general purpose admin grid. This only visibly affects the
ACQ admin grids at time of writing, but applies to all auto-generated
admin grids.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Wed, 20 Mar 2019 15:57:02 +0000 (11:57 -0400)]
Docs: Add bugfix release notes for 3.2.5
For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.2.5. I'm not sure what the criteria were
for pervious point release notes.
Remington Steed [Wed, 20 Mar 2019 16:16:54 +0000 (12:16 -0400)]
Docs: Add bugfix release notes for 3.1.11
For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.1.11. Not sure if this is the same as past
point release notes.
Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order
- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org>
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.
We add the call number prefix and suffix as separate columns to the
holds pull list print template. We also add the suffix to the end of
the orderBy so that we also sort by the suffix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: John Amundson <jamundson@cwmars.org>
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container
Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen. A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines
The below message repeats in the open-ils.storage_stderr.log:
Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.
This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.
Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected
If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers
Provide call numbers extracted from the MARC record as options in the
volume batch editor. Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.
Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Thu, 17 Jan 2019 18:33:10 +0000 (13:33 -0500)]
LP1798628: Copy alert counts in Holdings
Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Remington Steed [Thu, 25 Oct 2018 12:53:32 +0000 (08:53 -0400)]
LP#1778571 Fix logic error converting JS bool to DB bool
Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.
To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
still checked. (That's bug #2.)
To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
- At step 5, the new note correctly has the "Public Note" checkbox
checked.
- At step 11, the edited note correctly has the "Public Note" checkbox
unchecked.
NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement
Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data. The key benefit is that subfields retain their order
in affected MARC fields. As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached
This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update
Previously, if a volume label was edited, all items attached to that
volume would be essentially affected. Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched. If no copies are
being edited along with a volume, then the volume itself is edited.
Auto-merging of volumes may still happen in all of these scenarios.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)
Bill Erickson [Mon, 4 Mar 2019 19:06:59 +0000 (14:06 -0500)]
LP1716473 Copy editor hide disabled defaults
Disabling a field in the copy editor "Defaults" tab now hides the field
instead of simply disabling it. Once a field is hidden, subsequent
field shift left to fill the space.
The "Working Items" grid is shifted to the bottom of the page, below the
attributes editor. This allows the attributes to fill the horizontal
space and puts the working items and save operations visually at the end
of the page, i.e. at end of the work flow.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Geoff Sams <gsams@roanoketexas.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Galen Charlton [Wed, 23 Jan 2019 15:52:24 +0000 (10:52 -0500)]
LP#1812389: make Group Penalty Threshold admin page accessible again
As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.
To test
-------
[1] From Administration | Local Administration, go to Group Penalty
Thresholds. Note that the embedded Conify admin interface
is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
should appear.
[3] Verify that the Permission Group Tree Entries interface remains
accessible from Local Administration.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status
The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jane Sandberg [Sat, 2 Mar 2019 01:03:31 +0000 (17:03 -0800)]
LP1721109: Update item status when holdings are edited
To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time. Note that
there is a new status column, and that an icon appears for
all the rows that you have changed. Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).
Bill Erickson [Thu, 21 Feb 2019 18:12:52 +0000 (13:12 -0500)]
LP1806087 Ang catalog pending tabs offer manual redirect
Instead of sending users to the AngJS versions of not-yet-implemented
tabs from the Angular catalog, show a message indicating the tab is not
yet implemented and offer a link to open the requested record tab in a
new browser tab. This better clarifies what is happening and helps to
avoid situations where the back-button is confusingly hijacked via
intermediate redirect.
We now also open the "View" link for copies in a new tab as well for
consistency with the modified "Edit" link.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Thu, 28 Feb 2019 20:44:46 +0000 (15:44 -0500)]
First pass at 3.3 release notes
Ran create_release_notes.sh, cleaned up the output a bit, and removed
the separate files. Still TODO are acknowledgments and combing out
any upgrade notes.
- Replace two instances of 'cleanse_ISO8601' with 'clean_ISO8601', as
the former does not exist (at least in these contexts)
- Delay converting DateTimes to strings until necessary (which allows us
to compare the original DateTime objects instead of having to recreate
them from strings)
- Increase comments
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Adam Bowling [Wed, 13 Feb 2019 04:15:08 +0000 (23:15 -0500)]
LP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud objects
in previous submission and adds CSS to item label template.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Adam Bowling [Thu, 10 Jan 2019 07:05:50 +0000 (02:05 -0500)]
LP#1787479: Adds customization for multipage print label printing and fixes the issue
with saving templates after the change to DB saving from local storage.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Based on cataloger feedback, we 1) Moved the Label Set Configuration higher
grouped with the spine and spine/pocket options because all of these options
are related 2) Moved the starting label option higher because this is the
one setting that will probably be adjusted on each use of the interface and
3) Made the Gap Between Columns setting label conditional on whether the
user us printing to a sheet with label sets or not.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kathy Lussier [Wed, 14 Nov 2018 17:49:16 +0000 (12:49 -0500)]
LP#1787479: Make the display of some fields conditional on the Print Feed Option
Ideally, we would remove the entire Page Settings section for those who are
printing to a continuous feed printer, but it carries the risk of users
not being able to see a field with a value that is affecting the layout. However, there are several fields within that section that don't affect the
continuous feed layout and can be hidden in continuous feed mode. I also
adjusted one help tip to display different information for continuous and
sheet feed printing.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
As previously discussed on the cataloging list and the LP bug, the previous
label names of 'left' and 'right' no longer make sense since staff can
control the placement of these labels. However, label 1 and label 2 are too
generic. We therefore are going back to spine and pocket labels.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Moved most of the CSS to cat.css.tt2; removed most borders since they aren't
needed as much without the full settings descriptions on the page; added some
more help text and removed Windows carriage returns.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2
projects / Evergreen.git / log