Jeff Davis [Wed, 7 Feb 2018 23:11:18 +0000 (15:11 -0800)]
LP#1715767: Allow others to use my account (privacy waiver)
Use case: Jane Doe has a hold ready for pickup but is unable to come
into the library. Her husband John Doe goes to the library to pick up
the hold on her behalf. His name is listed on Jane's account, so
library staff know it's okay to check out the book on Jane's account and
give it to John.
This commit adds a new table which lists the names of people who are
allowed to place holds, pick up holds, check out items, or view
borrowing history for a user account. Staff can add, edit, or remove
entries via the patron editor in the web client; patrons can do so in My
Account. The entries are not linked to other user accounts and they do
not add any extra functionality. They are essentially special patron
notes for circulation staff.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Signed-off-by: James Fournie <jfournie@vcc.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Thu, 3 Jan 2019 15:17:42 +0000 (10:17 -0500)]
LP1809288 Angular fm-editor read-only additions
* Add read-only view to org-select
* FM editor displays read-only values as plain text
* Mark readOnly checkboxes "disabled"
* Link fields only fetch linked data when an IDL selector exists
* Minor code/style changes
** Define all class vars before class methods (ng-lint)
** Replace some tabs with spaces (ng-lint)
** Avoid unnecessary type defs with default values (ng-lint)
** More const goodness (ng-lint)
** camelCase some vars for consistentcy
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values. This commit changes it to
a more generic if() test to cover null/undefined. Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.
Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.
Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 14 Dec 2018 04:50:15 +0000 (20:50 -0800)]
LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2
To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2. Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying
This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.
Two paths to test:
Path A)
1. Import a new bib record from z3950, but via "Edit then Import"
2. Bring up marc editor and choose save w/ bib source.
3. Verify chosen bib source saved correctly on record page.
Path B)
1. Mark a record as target for Overlay, go to z3950 import.
2. Make a search, select item for Overlay.
3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
4. Verify chosen bib source saved correctly on record page.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Tue, 18 Dec 2018 15:50:26 +0000 (10:50 -0500)]
LP1807764 Angular grid gets datePlusTime option
Adds a new boolean datePlusTime option to the Angular grid column
configuration, informing the grid to display both date and time in the
cell for a datetype=timestamp column.
Includes sandbox example.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 7 Dec 2018 00:42:49 +0000 (16:42 -0800)]
LP1805856: Open records in new tabs
Catalogers have given the feedback that it's very helpful to have
certain records open in a new tab after they perform certain tasks.
This commit opens the relevant records in a new tab in the following
circumstances:
1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
existing tab)
2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
overlaid record at all)
3) Cataloging > Record Buckets > Merge (previously opened the lead
record in the existing tab)
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Add a deprecation warning to the Hatch configuration page notifying
users that Hatch for storage is deprecated. Includes suggestions on how
to migrate away from Hatch for storage.
Remove the unusued "Use Hatch for Offline Files" option.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Cesar Velez [Fri, 7 Dec 2018 23:50:43 +0000 (18:50 -0500)]
LP1765179 - fix issue with pending/staged user reg
After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc
Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Thu, 27 Sep 2018 14:53:35 +0000 (07:53 -0700)]
LP1782652: Make template dropdown larger in Volume/Copy Editor
To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates. Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates. Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again. Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab. Note that the template dropdown has changed
to be much larger.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Jason Stephenson [Wed, 12 Dec 2018 18:24:01 +0000 (13:24 -0500)]
Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 9.6
PostgreSQL 9.6 apparently exhibits the same behavior as Postgresql 10
when it comes the OE ligature in the unaccent function. We modify the
test case to take that into account.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 10
PostgreSQL 10 has improvements in the unaccent function used by the
evergreen.unaccent_and_squash function. The test needs a small
modification to take this into account. Actual code change from Mike
Rylander with a little typo fix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Fix a number of PgTap tests for PostgreSQL 10.
A number of tests disabled output via "\set ECHO". In PostgreSQL 10,
the lack of a value in \set is an error. We change these lines to
"\set ECHO none".
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Lp 1730726: Basic Patch to build the database with PostgreSQL 10.
* Modify the evergreen.org_top() function, with code from Galen
Charlton, to be non-set returning.
* Modify Open-ILS/src/support-scripts/eg_db_config.in to not strip the
period from PostgreSQL version numbers and to use the first two
components when checking for supported PostgreSQL versions.
* Add link from Open-ILS/src/sql/Pg/000.english.pg94.fts-config.sql
to Open-ILS/src/sql/Pg/000.english.pg10.fts-config.sql.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
For standalone DB server install, ensure that we are applying the proper
PostgreSQL community apt repo for packages.
DO NOT backport this branch. There are presently known issues with
Ubuntu 18.04 and email generation from action/trigger and other
interfaces. We plan to address these before the 3.3 release, but do
not necessarily expect to backport those fixes.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Stephenson [Tue, 25 Sep 2018 15:47:05 +0000 (11:47 -0400)]
LP#1793585: Fix Unescaped left brace in regex Perl error.
Running make check results in the following error on Perl 5.26:
Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\${ <-- HERE EMAIL_SENDER}/ at Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/HoldNotify.pm line 358.
Prior to Ubuntu 18.04 and Perl 5.26, this was a deprecation warning.
This commit fixes the regular expressions in HoldNotify.pm to escape
the left braces to make this error/warning go away.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Changes to Makefile.install to support this version of Ubuntu.
Note: We are using PG9.6 from the PostgreSQL apt source instead of the
standard PG10 version that ships with Ubuntu 18.04. Further testing required
before we switch PG versions so relying on a known working version for now.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Terran McCanna [Wed, 12 Dec 2018 22:57:19 +0000 (17:57 -0500)]
LP#1743783 Web Client Bill Full Detail Display Issues
Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type
2) Corrected path for Type
3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Remington Steed [Wed, 12 Dec 2018 16:36:17 +0000 (11:36 -0500)]
Docs: Fix screenshot file name
The asciidoc is looking for "My_Lists_dd.png", but the file has a
capitalized extension ".PNG". This commit renames the file to match the
code, since lowercase is our common naming convention.
Remington Steed [Mon, 26 Nov 2018 19:10:36 +0000 (14:10 -0500)]
Docs: LP#1731048: Update json_query documentation for new join syntax
This commit simply adds the text from the related commit message (see
LP#1527731) to the original DocBook file. NOTE: This documentation is
also available on the wiki, and has been updated there as well:
Jason Boyer [Fri, 7 Dec 2018 15:05:43 +0000 (10:05 -0500)]
LP1807398: Add workstation to marc_stream_importer
In order to work properly with vandelay session
tracking in 3.2+ a workstation is required at login.
This branch adds a workstation option to the importer
and alerts the user if it's missing.
Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Ben Shum [Sun, 9 Dec 2018 08:11:48 +0000 (03:11 -0500)]
Docs: Followup commit to fix screenshot for My_Lists3.jpg
The previous commit added some new screenshots for My_Lists, but this one
was saved with .JPG extension instead of .jpg so the original file was
retained.
katiegmartin [Thu, 2 Aug 2018 19:06:28 +0000 (15:06 -0400)]
Docs: LP1783387: update print templates to reflect new name
launchpad 1783387 - update receipt template editor documentation to reflect language change to "print templates" in web client
put both terms in index
updated title to Print (Receipt) Templates
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Added a section on how to apply a binding template to a distribution as this is necessary to ensure the binding does not fail. Also updated an instance of "Action" to "Actions".
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Remington Steed [Mon, 26 Nov 2018 15:04:28 +0000 (10:04 -0500)]
LP#1739606: Allow saving Billing History xacts grid
For a web staff eg-grid to save and retrieve its settings, it needs a
unique persist-key. This commit adds one for the Transactions tab grid
under Billing History (on patron record Bills tab, click the History
grid button).
Adds a new dedicated patron parent/guardian field. This field is
editable in the patron edit interface, displays in the patron summary
side bar on the browser client, and is search-able from the patron
search interface in the browser client.
Adds patron editor "show" and "suggest" library settings.
Also adds a new library setting
'ui.patron.edit.guardian_required_for_juv' ("GUI: Juvenile account
requires parent/guardian"). When this setting is applied, a value
will be required in the patron editor when the juvenile flag is active.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Way back when, we switched from a misspelled 'clense_ISO8601' to a
corrected 'cleanse_ISO8601' in OpenSRF. This function has again moved,
and is now part of OpenILS::Utils::DateTime, and is named
'clean_ISO8601'. This was done as part of LP bug #1552778.
However, a few stragglers of the misspelling remained, so these were
missed when the big changeover occurred. This hopefully catches them
all!
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Jason Boyer [Tue, 20 Nov 2018 16:54:50 +0000 (11:54 -0500)]
LP1793154: Cancel Holds from OPAC Record
The name of the grid handler was misspelled
in the holds grid for records in the opac.
Swapping the location of the 'wide' part of
the function name will allow it to match up
with the functions available in the holds
grid module.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
projects / Evergreen.git / log