Mike Rylander [Wed, 28 Sep 2011 19:45:36 +0000 (15:45 -0400)]
Provide proper hrefs for links back from report debugging pages
Reimplementation of a fix provided by Michael Peters. The originally submitted
patch included several fixes provided by an unrelated patch, and a regression
in build-time embedded tokens.
Original branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/clark_kent_back_links
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 22 Sep 2011 16:51:22 +0000 (12:51 -0400)]
LP856567: Mark HTML report output as Unicode-encoded
Non-ASCII characters in report ouput that has been generated in HTML
format appears to be corrupted when viewed in a browser. This can be
manually corrected by switching the "Encoding" browser option, but it
would be better to include <meta charset='utf-8'> in the output HTML to
tell the browser directly.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 27 Sep 2011 16:22:38 +0000 (12:22 -0400)]
MFHD compression fails with pattern-less captions
The current code assumes that if you try to compress a range of
MFHD holdings, you actually have the necessary pattern information.
This commit introduces a very basic check to avoid the most common
failure case.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Fri, 23 Sep 2011 14:55:28 +0000 (10:55 -0400)]
LP857460: Get the generic class scheme when adding vols
In a default Evergreen instance, in the "Add Volumes" interface for a
bib record with both LC and Dewey call numbers, the list of call numbers
from which you can select appears to be limited to Dewey, even though
the "Bib Call #" field is populated with an LC call number.
The problem is that here we're grabbing the first entry from the
asset.call_number_classification table, and you might expect that to be
the "Generic" entry - however, it turns out to be the "Dewey" entry
because the entries are ordered alphabetically by .name(), not by
database ID. (You can test this be changing the name of "Dewey" to
"Vicious" and see that the "Generic" entry is chosen instead).
This commit changes the process to first search the acnc array for a
name() = "Generic"; and then if we don't find that, fall back to the
first entry in the classification scheme.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
If a transit would be generated between the current library and another and
the appropriate setting is set for both end with the same value the transit
will be suppressed. If either end is set to an empty string then transit
suppression will be disabled, even if both ends are set to an empty string.
In addition, transits from other locations will be received when their
destination shares suppression with the current library.
circ.transit.suppress_hold will cause holds to go to the hold shelf instead
of into transit when in effect. Non-hold transits should not check it. This
should be useful when multiple parts of a library share a hold shelf, but
are split on the org tree.
circ.transit.suppress_non_hold will cause items to reshelve instead of
going into transit. Hold transits should not check it. This should be
useful when multiple parts of a library are in the same building and have
no need to transit items before reshelving/cataloging.
In order to suppress *all* transits both settings need to be set.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Some EDI translation fixes for troublesome input characters
This attempts to address enough of the issues in
https://bugs.launchpad.net/evergreen/+bug/812593 to move forward.
When the ? character appears in lineitem attributes for a PO that we
send off for EDI translation, the translator fails if that ? is the last
character of the string. This commit avoids that situation.
This commit also removes any Unicode characters from the JEDI (the input
to the translator process), as they're not going to make it to the
EDIFACT output anyhow, and will just confound the translator.
This commit also pre-escapes quotation marks in lineitem attributes so
that we don't produce invalid JSON for our JEDI.
This commit also destroys the death star.
Seriously, the right way to fix some of the issues people have had is
for somebody to learn Ruby and to address them either in edi_webrick.rb, in
edi4r, or in openils-mapper (wherever the issues may be). Working on
that.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 14 Sep 2011 18:25:41 +0000 (14:25 -0400)]
TPac: Page through search results on details page
Consistent with jspac, when you land on a record details page and you
got there from doing a search, let the user page through the search
results directly on the record detail page.
This also includes the necessary JS callbacks to support paging in the
staff client.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 19 Sep 2011 02:27:00 +0000 (22:27 -0400)]
TPAC: Add some style to MFHD holdings summaries
Simple grey background for the holdings summary header for each record;
add a TBODY element to the holdings table for validity; offset the MFHD
type by 1em to group entries under each holdings location.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 19 Sep 2011 01:12:23 +0000 (21:12 -0400)]
TPAC: Give MFHD summaries OU / depth awareness
Rather than returning all results and filtering on the client-side, as
we're currently doing in the JSPAC, teach the
open-ils.search.serial.record.bib.retrieve method to accept optional OU
& OU depth arguments and do the filtering in the query; cuts down on
network traffic and should be generally more efficient.
Note that in the absence of an explicit "depth" CGI param,
EGCatLoader/Record currently defaults to a depth of "0"; we could
teach it to look up & cache the depth of the "loc" param for the sake of
convenience & arguably more accuracy.
Also note that the sub/dist serial approach probably needs to be taught
similar method-side filtering, but I hope more knowledgeable brains will
work out what should happen with ssub.holding_lib / sdist.owning_lib.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
lp859190: make marc_stream_import always import non-matches
Fixes regression of (implicit, undocumented) functionality
introduced in commit da3a45344205. Current use case for
the streaming MARC importer for OCLC Connexion exports assumes
that non-matching records should always be added.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jeff Godin [Wed, 21 Sep 2011 20:41:19 +0000 (16:41 -0400)]
Fix: Current Bills thinks it is Bill History
This fixes LP 855894: Bills interface calls itself Bill History,
uses bills_historical receipt template
https://bugs.launchpad.net/evergreen/+bug/855894
At some point in development, the Current Bills and the Bill History
interface were in a unified file, with an xul_param of "current" used
to switch between the two.
Nothing currently sets the xul_param "current", so the Current Bills
interface (bill2.xul and bill2.js) was improperly:
* not hiding the xact_finish column
* using a caption label of "Bill History"
* using the bills_historical receipt template
The Bill History interface was okay -- "not current" was the default.
This commit removes the tests for xul_param('current') and uses the
appropriate code for each interface.
// this code in both bill2.js and bill_history.js:
var template = 'bills_historical';
if (xul_param('current')) template = 'bills_current';
// becomes:
var template = 'bills_current'; // in bill2.js
var template = 'bills_historical'; // in bill_history.js
Bill Erickson [Thu, 22 Sep 2011 15:10:09 +0000 (11:10 -0400)]
Stamped upgrade script for ACQ fund view repairs
At the heart of this change is the need to force acq.fund_debit_total to
return exactly 1 row per fund, instead of 1 per fund + encumbrance
value. However, such a change required rearranging a number of
dependent views.
Also added acq.fund_spent_balance to the set of views that needs
dropping and re-building.
Minor SQL format change to match surrounding code in schema file
See also https://bugs.launchpad.net/evergreen/+bug/800477
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Thu, 22 Sep 2011 05:11:06 +0000 (01:11 -0400)]
Password resets: avoid run-on subjects
The password reset template had a space on the first blank line after
the Subject: which lead to the first paragraph being tacked onto the
Subject line. Get rid of the space, and create an upgrade script ready
to roll.
Bill Erickson [Mon, 19 Sep 2011 22:18:41 +0000 (18:18 -0400)]
TPac: integrated patron password reset
Port the existing password reset functionality into TPac. This allows
us to leverage the TPac innards for localization. It also means there's
one less moving part. (and, incidentally, no more dojo for the form).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
In testing I didn't have to restart the staff client, but as constants.js
is loaded pretty much everywhere I have no clue where the URL array may
be stale.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 22 Sep 2011 02:36:09 +0000 (22:36 -0400)]
TPAC: Make "Sort by" select box match style of search bar
The "Sort by" select box in search results had a native widget style,
compared to the search widget styles of the search bar. A simple CSS
tweak makes it consistent.
Dan Scott [Sat, 17 Sep 2011 03:44:28 +0000 (23:44 -0400)]
Can't have two identical IDs on the same page
Nobody who cares about the pure Web experience ever noticed that this
page has two identical IDs. Chromium and other browsers complain,
though, so make them happy.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 25 Aug 2011 18:20:56 +0000 (14:20 -0400)]
Clear hold shelf [expire] time at checkout to alternate patron
When an item on the holds shelf is checked out to an alternate patron
(i.e. not the hold user), clear the shelf_time and shelf_expire_time
along with capture_time, current_copy, etc. on the hold.
tsbere++ for isolating the problem.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Dan Scott [Sat, 17 Sep 2011 03:45:53 +0000 (23:45 -0400)]
TPAC: Enable password resets - crude, for now
Use the existing crude password reset form to enable password resets.
Slightly longer term, we need to destroy the existing form and pull it
into TPAC proper (including such good stuff as real localization and
getting rid of Dojo / Dijit), but this works for now.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Staff saved searches when browsing catalog in staff client
By default, show a user's ten most recent searches to them on the left
side of the results and record details pages. Configurable by org unit
setting 'opac.staff_saved_searches.size'
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
You can get to it via a button in the upper right-hand corner of
the view-invoice interface, assuming you're looking at an invoice that's
already been created/saved (and which has acqlid objects in a receivable
state), not one you're just now creating.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bookbags have descriptions now (and they're reflected in feeds).
Bookbag item notes are editable.
Bookbags can now be sorted by title or author using QP tricks.
You can export a bookbag as CSV.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Sat, 17 Sep 2011 02:16:19 +0000 (22:16 -0400)]
TPAC: PROCESS config.tt2 needed in results.tt2
If the values in config.tt2 are not available to the results page, then
all of them are false - so Google Analytics, Resolver, etc, won't work
in the results page.
Dan Scott [Fri, 16 Sep 2011 13:59:54 +0000 (09:59 -0400)]
LP 851915: Remove references to /openils/lib/perl5
To prevent old versions of the OpenSRF and Evergreen Perl modules from
conflicting with the new versions of these modules (which are now
located in the default system Perl package directories), remove
references to them.
Also, O:W:AddedContent contains an old reference to a distro-specific
Perl directory that we can clean up at the same time.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Move all COUST seed values to the same insert statement in 950.data.seed-values.sql
Make data upgrade file do *all* the changes that happen in the seed values
Add groups to some of the new settings since Joseph looked at the list
Make history view escape &, <, and > before showing values to prevent HTML from being parsed
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Mike Rylander [Wed, 7 Sep 2011 18:27:05 +0000 (14:27 -0400)]
Cleanup, yay! Give YAOUS logging table a surrogate pkey and upgrade script; clean up some typos; position the existing upgrade script correctly
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Thu, 7 Jul 2011 19:21:53 +0000 (13:21 -0600)]
Added the following features/imporovements suggested by the community:
* Sort history by date descending.
* Add revert button to history.
* Search after pause.
* Dynamically adjust amount of time message is shown by its length.
* Fix a bug about things not being shown in history after delete.
* Fix a problem with user not being shown change if they make a change in a
context that isn't currently shown.
* Do i18n on everything.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Mon, 20 Jun 2011 19:36:25 +0000 (13:36 -0600)]
Fixed my database errors (although some still exist, I can't tell if they
are mine or not, I'm going to test the master and see if they exist there...)
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Fri, 17 Jun 2011 21:05:51 +0000 (15:05 -0600)]
Cleaned up so it shouldn't ruin the database creation (hopefully).
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Wed, 15 Jun 2011 19:28:26 +0000 (13:28 -0600)]
Fixed the non i18n settings for oust.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Wed, 15 Jun 2011 17:46:33 +0000 (11:46 -0600)]
Got rid of old bug (pre me) that existed when an autowidget was used then
canceled and the next setting wasn't an autowidget. The autowidget would
continue to appear because it was never destroyed.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Wed, 15 Jun 2011 17:03:14 +0000 (11:03 -0600)]
Changed text in seed values to reflect addition of groups, added an update
script for groups, fixed org_unit_settings.js so the dojo grid would correctly
alphabetize with the additon of groups and the removal of groups from the
labels themselves.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Wed, 15 Jun 2011 14:35:45 +0000 (08:35 -0600)]
Remove duplicates due to groups in seed-values.sql, and include groups in
seed-values; delete seed values upgrade patch.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Tue, 14 Jun 2011 21:46:59 +0000 (15:46 -0600)]
Updated so that the history shows the org-unit shortname rather than the id.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Tue, 14 Jun 2011 19:35:33 +0000 (13:35 -0600)]
Convert buttons to toobar cleaning up page a lot. Added new notification
system.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Mon, 13 Jun 2011 22:54:06 +0000 (16:54 -0600)]
Added revision logging to oust, updated fm_IDL.xml to reflect that
and changed org_unit_settings.js and org_unit_settings.xhtml to add some
functionality of revisions.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Thu, 9 Jun 2011 21:14:22 +0000 (15:14 -0600)]
Updated the staff_client code to be much better at searching, renamed the sql upgrade script b/c 0549 was just snatched up!
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Thu, 9 Jun 2011 19:17:16 +0000 (13:17 -0600)]
Finished import/export of settings.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Wed, 8 Jun 2011 20:07:27 +0000 (14:07 -0600)]
Updated to include search.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Tue, 7 Jun 2011 17:34:20 +0000 (11:34 -0600)]
Added Tags support in the org_unit_settings display page.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Mon, 6 Jun 2011 22:06:25 +0000 (16:06 -0600)]
Whoops, typed in the wrong number.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Mon, 6 Jun 2011 21:59:37 +0000 (15:59 -0600)]
Forgot to put in the logging information :)
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Joseph Lewis [Mon, 6 Jun 2011 21:03:27 +0000 (15:03 -0600)]
Added seed values for the "tags" of the settings in org unit settings.
Signed-off-by: Joseph Lewis <joehms22@gmail.com> Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Etheridge <jason@esilibrary.com>
lp834961: fix authoritative versions of callnumber retrieval calls
Makes open-ils.search.callnumber[.fleshed].retrieve.authoritative
actually be authoritative. Fixes bug where adding a volume
could result in a false ASSET_CALL_NUMBER_NOT_FOUND error if using
database replication and Slony-II.
Bill Erickson [Tue, 13 Sep 2011 17:42:01 +0000 (13:42 -0400)]
Remove unused reference to oils_web.xml in startup.pl
TODO: give EGCatLoader child_init-like functionality to connect to
opensrf to address the (unlikely) case that EGWeb/EGCatLoader are
the first/only mod_perl handlers loaded on an Evergreen Apache server.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
projects / Evergreen.git / log