7 years agoAlways display the hold type indicator
Mike Rylander [Tue, 22 May 2012 12:00:12 +0000 (08:00 -0400)]
Always display the hold type indicator

We should be showing the type of hold on any pull-list or hold detail
interface we build.  The primary use case is to alert staff when an
alternate identical copy of the same title will (very likely) be usable
by a hold, and (as in the case of C-like holds) it will not.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoStamping upgrade for Copy Location Circ Limits
Mike Rylander [Tue, 24 Jul 2012 12:11:23 +0000 (08:11 -0400)]
Stamping upgrade for Copy Location Circ Limits

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoAdd Copy Location to circ matrix matchpoint
Bill Erickson [Fri, 22 Jun 2012 16:04:41 +0000 (12:04 -0400)]
Add Copy Location to circ matrix matchpoint

Similar to circulation modifiers, circ policies can now be based on copy

This also adds copy location to the circ matrix weights.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoCopy Location Circ Limit Sets Admin UI
Bill Erickson [Fri, 13 Apr 2012 20:19:03 +0000 (16:19 -0400)]
Copy Location Circ Limit Sets Admin UI

Changes are applied to the existing Admin -> Local Administration ->
Circ Limit Sets interface to support copy location limit groups.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Copy Location Circ Limit Sets : UI 2

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoCopy Location Circ Limit Sets : DB and IDL
Bill Erickson [Fri, 13 Apr 2012 19:39:18 +0000 (15:39 -0400)]
Copy Location Circ Limit Sets : DB and IDL

Support for copy location-based circulation limit sets.  Similar to circ
mod limit sets, this allows staff to configure a maximum number of items
allowed checked out based on copy location(s) and link that rule to
circulation policies to control who the rule affects.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoJSPAC: Point to TPAC from <noscript> section
Dan Scott [Mon, 23 Jul 2012 16:09:03 +0000 (12:09 -0400)]
JSPAC: Point to TPAC from <noscript> section

TPAC was built for browsers with no JavaScript. Ironically, we're still
pointing to the SlimPAC from the <noscript> section of the JSPAC... fix

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoStamping upgrade script for Trigger Event Log
Mike Rylander [Mon, 23 Jul 2012 20:13:36 +0000 (16:13 -0400)]
Stamping upgrade script for Trigger Event Log

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoTrigger Event Log
Lebbeous Fogle-Weekley [Fri, 18 May 2012 16:12:55 +0000 (12:12 -0400)]
Trigger Event Log

A better, more browsy/filtery way to browse Action Trigger Events
related to holds and circs, which staff users sometimes want to filter
by patron barcode.

This is accessed from various menus around the staff client, notably the
patron interface and the item status interface.

This has better printing capabilities than previous versions of this
interface, too.

There's also a new org unit setting to go with this,
"circ.staff.max_visible_event_age", which if set, should hide any events
older than the configured age.

One new permission: VIEW_TRIGGER_EVENT.  This does what it sounds like
it does.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts (resolved):

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoTPAC: Set autofocus appropriately for different contexts
Dan Scott [Thu, 12 Jul 2012 23:12:06 +0000 (19:12 -0400)]
TPAC: Set autofocus appropriately for different contexts

At login, the basic search bar was fighting (and winning) for the
default focus rather than the username field. Additionally, in the
advanced search pages, no field was getting focus. Therefore, check to
see if we expect to be in a context where it makes sense to set the
default focus to the basic search input field; otherwise, set the focus
to the login username field or the appropriate advanced search field.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoDocumentation: Fix typo in upgrade instructions. Bug #1027752 reported by Jeff...
Robert Soulliere [Mon, 23 Jul 2012 12:12:15 +0000 (08:12 -0400)]
Documentation:  Fix typo in upgrade instructions. Bug #1027752 reported  by Jeff Green.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoFix / improve bookbag list paging
Dan Scott [Sun, 22 Jul 2012 22:58:11 +0000 (18:58 -0400)]
Fix / improve bookbag list paging

The prior code used CSS to hide elements, which is a bit weird given
that we can simply avoid creating the element in the first place and
keep the DOM a lot simpler.

Also, the previous code was subject to some bugs if it wasn't given
an explicit offset GET param or paging at the end of a list
(particularly given that the LIMIT parameter ensured that the number of
bookbags returned would always be equal to or less than the LIMIT

Finally, the changes related the permanent bookbags didn't pass through
one of the context parameters we needed (bookbag_count) to enable

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoWrap upgrade script for permanent bookbag lists
Dan Scott [Sun, 22 Jul 2012 20:01:38 +0000 (16:01 -0400)]
Wrap upgrade script for permanent bookbag lists

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoTPAC: Refactor bookbag list actions into a common template
Dan Scott [Wed, 18 Jul 2012 16:27:08 +0000 (12:27 -0400)]
TPAC: Refactor bookbag list actions into a common template

The "add to bookbag" actions in both the search results and record
details pages contained a large amount of duplicated code; consolidate
those into a single template that can be included into each page.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAbility to add records to permanent bookbags in TPAC.
Jason Stephenson [Wed, 11 Jul 2012 12:59:48 +0000 (08:59 -0400)]
Ability to add records to permanent bookbags in TPAC.

Add an actor usr setting for holding the name of a default book
list: opac.default_list.

Add a button on the my list interface to choose a list should as
the default list for adding titles.  There is presently no way to
unset a default menu, though the default can be changed to any
other menu at any time by clicking that list's button.

Modify opac/record and opac/results so that if a patron is logged
in their my lists will populate a menu.  This menu will include
options to add to a temporary list, the default list (if any), up
to 10 of the user's other lists, to add to a newly created list,
or to see all of their lists and add to one that does not appear
on the menu.

Adding to a temporary list will function the same as adding to a
list does prior to this enhancement.

Adding to a list chosen from the menu will add the record to that
list, and return the user to the search results or record page
that they were looking at.

Choosing to add to a new list will take the user to their "my
lists" page where they can create a new list.  After the list is
created, the record they wanted to add will be added to the new
list and they will be returned to the search results or record
that they were looking at.

Choosing the "see all" menu option will also take the user to
their "my lists" page.  However, all of their bookbags will be
visible and not just the normal limit of 10.  Their will be a
button next to each list's name with the text "Add to this list."
When the user clicks one of those buttons, the record will be
added to that list and the user's session redirected back to
their search or result page.

The user will have the option to create a new list when viewing
all of their lists.

The user will also be able to use the "Add to this list" feature
when they have chosen the "Add to new list" menu option.  This is
done from simplicity in the design, but also allows the user to
change their mind at the last second.

If a patron is not logged in, the add to my list will appear the
same as it does prior to this development.  It will continue to
function as it does prior to this development.

Add coust for opac.patron_temporary_list_warn to let an ou enable
warning users when adding records to a temporary book bag.

Add cust opac.temporary_list_no_warn to let patrons disable
the warning for themselves.

Add the opac.default_list usr_setting_type. This will be used to track a
user's default bookbag.

Add the upgrade script to create new coust and custs.

Insert coust (opac.patron.temporary_list_warn) and cust
(opac.temporary_list_no_warn, opac.default_list) into the respective

Add release notes for add to permanent bookbag feature.

Add a warning when the user adds a record to a temporary list.

TPAC has been modified so that a user will see a warning before adding
a record to a temporary bookbag.  This message serves to inform the
user that they are adding to a temporary list that will disappear when
their session ends.

A new org. unit setting has been added,
opac.patron.temporary_list_warn, that will enable this warning when
set.  Sites may choose not to display this warning.

The user may also set a preference in their search preferences to
disable this warning.  The setting only works when a user is logged
in, of course.

Add release notes for the temporary list warning feature.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoDocumentation: remove those darn Windows carriage returns.
Robert Soulliere [Thu, 19 Jul 2012 17:35:49 +0000 (13:35 -0400)]
Documentation: remove those darn Windows carriage returns.

I am using linux based system for editing so I am not sure where they are coming from.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoDocumentation: Migrate reports documentation from 2.1
Robert Soulliere [Thu, 19 Jul 2012 17:23:18 +0000 (13:23 -0400)]
Documentation: Migrate reports documentation from 2.1

Content reviewed by Jenny Turner. I converted to asciidoc and tested
processing. I also added index terms.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoDocumentation: Format text to limit line length to 80 characters.
Robert Soulliere [Thu, 19 Jul 2012 01:49:02 +0000 (21:49 -0400)]
Documentation: Format text to limit line length to 80 characters.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoAdd Journal Title search to stock TPAC filters
Dan Scott [Thu, 12 Jul 2012 03:37:11 +0000 (23:37 -0400)]
Add Journal Title search to stock TPAC filters

Academics need access to a quick and easy Journal Title search, this
gives it to them. Due to the requirement to combine search index + bib
level, we define a special search index that can then be acted upon

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoDocumentation: Fix various issues causing errors during processing.
Robert Soulliere [Wed, 18 Jul 2012 14:16:09 +0000 (10:16 -0400)]
Documentation: Fix various issues causing errors during processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoTPAC: Use % font size + bold to highlight login failure
Dan Scott [Tue, 17 Jul 2012 16:55:39 +0000 (12:55 -0400)]
TPAC: Use % font size + bold to highlight login failure

Loved the idea to call more attention to login failures, but wanted to
try to stick to % for font sizes where possible. Testing suggested that
font-weight:bold and a little padding on top would help the display as

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
7 years agoTpac CSS: Login failure message
Melissa Lefebvre [Fri, 11 May 2012 15:07:50 +0000 (11:07 -0400)]
Tpac CSS: Login failure message

To draw attention to failed logins, the font size was increased
to 16px and the font color changed from black to red.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoTPAC: Slightly more accessible user-visible account notes display
Dan Scott [Tue, 17 Jul 2012 16:39:37 +0000 (12:39 -0400)]
TPAC: Slightly more accessible user-visible account notes display

Rather than a table layout that resembles an unordered list, use a real
table with table header so that screen readers will know what to
associate each column with.

Also, move the table display into its own class so that we don't pick up
the uppercase transform, and move it out of the div box so that we can
use whatever screen real estate is given to us, rather than forcing
notes into the hard-coded 662px box.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoTPAC: show patron-visible notes in my-account
Bill Erickson [Tue, 19 Jun 2012 18:24:33 +0000 (14:24 -0400)]
TPAC: show patron-visible notes in my-account

Notes display in the 'Account Summary' box on the first page of

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoTPAC: Physical description, now with spaces
Dan Scott [Sat, 16 Jun 2012 02:59:23 +0000 (22:59 -0400)]
TPAC: Physical description, now with spaces

Record details will regularly include physical descriptions like
"Physical Description: 1 sound disc :33 1/3 rpm, mono." where the colon
is jammed up against the content from the following subfield. Easily
fixed by using a space as the joiner for the subfields.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
7 years agoMove Prefix field ahead of Names in patron editor
Ben Shum [Wed, 27 Jun 2012 18:01:24 +0000 (14:01 -0400)]
Move Prefix field ahead of Names in patron editor

In earlier versions of Evergreen (1.6 and earlier), the Prefix field
was used to enter title information, such as Mr., Mrs., etc. When the
field was eventually added to the newer patron registration screens
(2.0+), it was added before the patron's last name field. Ideally,
the prefix should be listed prior to the patron's first name instead.

In addition, address label issues by changing "Suffix/Title" back to
only "Suffix" and making "Prefix" into "Prefix/Title".

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoSquelch uninitialized var warning from hold_copy_targeter
Bill Erickson [Mon, 16 Jul 2012 20:56:10 +0000 (16:56 -0400)]
Squelch uninitialized var warning from hold_copy_targeter

open-ils.storage_stderr.log was getting filled with entries like:

"Use of uninitialized value in concatenation (.) or string at

... consuming disk space endlessly. Stop that!

(Stealing Lebbeous' footwork and providing a slightly different solution.)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoSearchbar spacing: move inline CSS into a style
Dan Scott [Mon, 16 Jul 2012 21:22:16 +0000 (17:22 -0400)]
Searchbar spacing: move inline CSS into a style

In keeping with our attempt to control styles via the CSS file rather
than inline overrides, define a class for the searchbar and style that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
7 years agoTPAC: Search wrapper spacing
Melissa Lefebvre [Tue, 3 Jul 2012 16:53:09 +0000 (12:53 -0400)]
TPAC: Search wrapper spacing

Currently the search box options are "smooshed up" against the
links toolbar.  The following changes address this.

Padding was added to style.css search_box_wrapper in order to
bring the "Search the Catalog" down lower from the link toolbar.

Padding was also added to the searchbar.tt2 in order to bring the
search filter options down lower from the "Search the Catalog"

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoincrease the default width for the xul list line number column
Jason Etheridge [Thu, 10 May 2012 18:18:37 +0000 (14:18 -0400)]
increase the default width for the xul list line number column

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoDocumentation: Add Patron Bills section to Patron Management chapter.
Jennifer Turner [Sat, 14 Jul 2012 22:51:25 +0000 (18:51 -0400)]
Documentation: Add Patron Bills section to Patron Management chapter.

Converted to asciidoc by Robert Soulliere

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoWhen a user views holds in their account, clicking "only available"
Kathy Lussier [Fri, 6 Jul 2012 21:01:51 +0000 (17:01 -0400)]
When a user views holds in their account, clicking "only available"
on the holds screen or "Ready for Pickup" in the navbar will add an
"available=1" parameter. However, if the user then attempts to return
to a list of all holds, the "available" parameter is not cleared, and
the user will only see holds available for pickup.

This commit will clear those parameters.

Signed-off-by: Kathy Lussier <kmlussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoDocumentation: Add Circulation, Patron management Chapter
Jennifer Turner [Fri, 13 Jul 2012 18:16:32 +0000 (14:16 -0400)]
Documentation: Add Circulation, Patron management Chapter

Content provided by Jennifer Turner at PALS. Converted to Asciidoc by Robert Soulliere. Robert also added indexing terms. Appendices for documentation cleaned up as well.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoTPAC: Use .staff variant for MARC Expert Search
Dan Scott [Fri, 13 Jul 2012 13:56:54 +0000 (09:56 -0400)]
TPAC: Use .staff variant for MARC Expert Search

Inside the staff client, we want to use the .staff method to retrieve
records that match the MARC Expert Search, so that records with no
attached copies can be found and returned.

Fixes LP # 1024382.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
7 years agoCache propagated funds in fund rollover action
Bill Erickson [Mon, 11 Jun 2012 19:23:17 +0000 (15:23 -0400)]
Cache propagated funds in fund rollover action

Repair display of propagated funds grid which was likely broken with
b9bb6d47.  Propagated funds must be collected and added to the local
cache for grid getter functions to find them.


Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoRepair PCrudFilter localeStrings variable collisions
Bill Erickson [Mon, 11 Jun 2012 19:19:48 +0000 (15:19 -0400)]
Repair PCrudFilter localeStrings variable collisions

Rename PCrudFilter's localeStrings global variable to avoid name
collisions with UI scripts that define the same variable.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoSet unix file format to remove trailing "\r"s in file.
Robert Soulliere [Thu, 12 Jul 2012 19:46:29 +0000 (15:46 -0400)]
Set unix file format to remove trailing "\r"s in file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoAdd Group Serials Issues Chapter from Sally Fortin at Equinox Software. Source: http...
Sally Fortin [Thu, 12 Jul 2012 19:36:03 +0000 (15:36 -0400)]
Add Group Serials Issues Chapter from Sally Fortin at Equinox Software. Source: esilibrary.com/esi/availableDocs.php.

Tested in documentation  processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoTPac: Disable caching for auth-required pages
Thomas Berezansky [Thu, 14 Jun 2012 17:41:33 +0000 (13:41 -0400)]
TPac: Disable caching for auth-required pages

To make back buttons less likely to show sensitive info.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoSilence undef string concatenation warning in AutoSuggest
Lebbeous Fogle-Weekley [Thu, 12 Jul 2012 13:16:12 +0000 (09:16 -0400)]
Silence undef string concatenation warning in AutoSuggest

Addressing LP #1023651 reported by Dan Scott.

When building a cache key, use processed input values that are
guaranteed to be defined rather than raw ones.

This will mean brief cache misses for AutoSuggest once applied, but
the default life of AutoSuggest cache entries is only 5 minutes anyway.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoFix titles/tabs in Account Preferences subpages
Jeff Godin [Wed, 11 Jul 2012 15:54:34 +0000 (11:54 -0400)]
Fix titles/tabs in Account Preferences subpages

Adjust the value of myopac_page in the Notification Preferences and
Search Preferences pages so that the page title and tab
color/hilight will be correct.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoGet Z39.50 source names to be linked as expected
Dan Scott [Wed, 11 Jul 2012 22:41:55 +0000 (18:41 -0400)]
Get Z39.50 source names to be linked as expected

The direct thead/th approach appeared to be interfering with the JS
event that was supposed to link the Z39.50 source names; adding the
expected tr layer resolved that.

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoZ39.50 attributes management interface
Bill Erickson [Tue, 19 Jun 2012 14:23:22 +0000 (10:23 -0400)]
Z39.50 attributes management interface

From the release notes:

There is a new interface for managing Z39.50 attributes on a Z39.50
source.  The interface is linked from each source name in the Z39.50
Source administrative interface.


In addition to attribute creation, deletion, and editing, it's also
possible to clone a set of attributes from one source into another.
When cloning, any attributes present in the cloned source that are
not present in the destination source are copied into the destination

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoFlattener grid defines override args in constructor
Bill Erickson [Tue, 19 Jun 2012 14:18:44 +0000 (10:18 -0400)]
Flattener grid defines override args in constructor

...instead of the seconday load handler.  Otherwise, the
grid.overrideEditWidget, etc. containers may be undefined at page load

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoRepaired typo in example rsyslog config file
Bill Erickson [Tue, 26 Jun 2012 17:54:53 +0000 (13:54 -0400)]
Repaired typo in example rsyslog config file

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoTPAC: Handle multiple matches for an XPath expression
Dan Scott [Fri, 15 Jun 2012 17:25:29 +0000 (13:25 -0400)]
TPAC: Handle multiple matches for an XPath expression

Per LP 1009980, "If a record has multiple subfield b's in the 260 field,
tpac will not display the publisher or publication date in the record
details page and will not display the publisher on the search results

This is because we're calling textContent on a nodeset, rather than an
individual node, and therefore get null back rather than any content.

To avoid this, always expect a nodeset and iterate over it to populate a
list of the strings.  To maintain the same semantics of expecting a
single text string back for, say, args.pubdate, we define the list as
args.pubdates (plural name), and then grab the first item from the list
and populate that as args.pubdate (singular name).

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
7 years agoAvoid problem with 2.1 -> 2.2 upgrade script issuing error
Lebbeous Fogle-Weekley [Wed, 11 Jul 2012 14:54:44 +0000 (10:54 -0400)]
Avoid problem with 2.1 -> 2.2 upgrade script issuing error

The error is:
    > ERROR: cannot ALTER TABLE "thesaurus" because it has pending
    > trigger events.

Reported by Justin Hopkins, George Duimovich, and Bill Erickson.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Justin Hopkins <hopkinsju@gmail.com>
7 years agoTPac: Add paging to My Lists
Bob Wicksall [Fri, 29 Jun 2012 18:33:22 +0000 (14:33 -0400)]
TPac: Add paging to My Lists

- Added paging to My Lists based on the code from the Checkout History tab.
- Fixed a bug where adding more than 10 items to the Temporary list failed
- After adding paging renaming a list on page 2+ would fail.  Fixed.
- Redirect after saving a list now leaves you on the same page
- Paging was bleeding between My Lists, Holds History and Circ History.

List contents were also limited to the first 10.  I have upped the limit to
1000 rather than having nested paging.  This should be revisited.

CSV download of lists is still limited to the first 10.  Not sure where to
fix this.

Signed-off-by: Bob Wicksall <bwicksall@pls-net.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoUpdate Evergreen upgrade instructions to reflect the 2.2.0 release.
Robert Soulliere [Tue, 19 Jun 2012 16:23:55 +0000 (12:23 -0400)]
Update Evergreen upgrade instructions to reflect the 2.2.0 release.

Update download reference to point to 2.2.0. Also moved
database updates to the end of the process. It seemed out of order since
the database update scripts were run before the download of the 2.2 tar file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoTeach the autosuggest web service to cache suggestions where appropriate
Mike Rylander [Tue, 26 Jun 2012 19:03:37 +0000 (15:03 -0400)]
Teach the autosuggest web service to cache suggestions where appropriate

Should spare some DB load on sites.

LFW: I'm not sure the update to the Apache config made any difference,
but it doesn't hurt.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoOrg unit retrieval cleanup
Bill Erickson [Mon, 12 Mar 2012 19:05:50 +0000 (15:05 -0400)]
Org unit retrieval cleanup

Clean up and consolidate the various org unit retrieval method (in Perl)
to reduce code/confusion and make it easier to integrate changes to the
org unit tree in the future.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agotpac: repair some straggling bookbag CGI param names
Bill Erickson [Tue, 12 Jun 2012 20:04:09 +0000 (16:04 -0400)]
tpac: repair some straggling bookbag CGI param names

We missed some going from "id" to "bbid"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoAcq: fix widget choice for user-linked fields in Acquisitions Search
Lebbeous Fogle-Weekley [Wed, 20 Jun 2012 15:13:11 +0000 (11:13 -0400)]
Acq: fix widget choice for user-linked fields in Acquisitions Search

The Acquisitions Search interface (which also sits underneath the
Purchase Orders inteface, My Selection Lists, and one or two others)
stopped presenting the correct widget for search terms linked to
actor.usr.  This was brought on when PCRUD control was added to
actor.usr, so that means the bug affects only master, not rel_2_2 or

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agolp#1014664: add new columns to CDBI table definitions
Galen Charlton [Mon, 18 Jun 2012 14:11:17 +0000 (10:11 -0400)]
lp#1014664: add new columns to CDBI table definitions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix Title Holds
Thomas Berezansky [Wed, 13 Jun 2012 17:16:51 +0000 (13:16 -0400)]
Fix Title Holds

Holdable formats was being filled in with oargs, causing random failures.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoFix version numbers in 2.1 -> 2.2 upgrade script
Lebbeous Fogle-Weekley [Thu, 21 Jun 2012 14:01:56 +0000 (10:01 -0400)]
Fix version numbers in 2.1 -> 2.2 upgrade script

Justin Hopkins spotted the problem, and offered a fix in LP #1015807.
I'm just doing it slightly differently here.  Thanks Justin!

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoStop editing README header
Thomas Berezansky [Tue, 19 Jun 2012 20:43:42 +0000 (16:43 -0400)]
Stop editing README header

We no longer have the version in the README header, so we don't need to
update it with a new value.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoAvoid file extensions on scripts
Dan Scott [Thu, 14 Jun 2012 19:16:51 +0000 (15:16 -0400)]
Avoid file extensions on scripts

Borrowing from the Debian policy, you might reimplement the same
functionality using a different language such as Perl or Python. So
avoid having a file extension in the first place. What are we, Windows

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
7 years agoRevert to generic ftp.mozilla.org hostname
Dan Scott [Mon, 4 Jun 2012 16:33:56 +0000 (12:33 -0400)]
Revert to generic ftp.mozilla.org hostname

download02.mozilla.org started returning 403 errors; ftp.mozilla.org
seems to work again, so let's go with that.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
7 years agogit2cl mangles the changelog; let's just use git's log
Dan Scott [Sun, 3 Jun 2012 03:25:53 +0000 (23:25 -0400)]
git2cl mangles the changelog; let's just use git's log

git2cl does bizarre things to line wrapping. The log it generates looks
deranged. Let's just use what git gives us; it's clean and easy to
parse, even if it doesn't adhere to the GNU changelog standards

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
7 years agoRelease Building Script
Thomas Berezansky [Wed, 28 Sep 2011 19:05:22 +0000 (15:05 -0400)]
Release Building Script

make_release.sh [-v VERSION] [-f PREV_BRANCH | -t | -b] [-F PREV_VERSION] [-n] [-p]
   VERSION is auto-detected by default and is based on the currently checked out branch.
   PREV_BRANCH is auto-detected by default but that isn't reliable. Include remote name!
   PREV_VERSION Is auto-detected by default and is based on the PREV_BRANCH's name.
   -n specifies that you don't want an upgrade script to be auto-generated.
   -p specifies that this is a preview build.
   -t turns on tag only mode.
   -b turns on build only mode.
   NOTE: -t and -b override PREV_BRANCH/PREV_VERSION, but -b overrides -t.

When building a release you should have git2cl in your PATH as well as
all packages needed for building i18n and staff clients.

Usage examples:

Tagging a major version root (no need for git2cl/staff client deps):

    git checkout -b rel_X_Y origin/master
    build/tools/make_release.sh -t

Building a release:

    git checkout -b rel_X_Y_Z rel_X_Y

Building a new major release:

    git checkout -b rel_X_Y_Z rel_X_Y
    build/tools/make_release.sh -f origin/tags/rel_U_V_W

Specifying a version outright:

    build/tools/make_release.sh -v X.Y.Z

Very Specific Example: Building the 2.2 RC1 release:

    git checkout -b rel_2_2_rc2 origin/rel_2_2
    build/tools/make_release -f origin/rel_2_1 -n -p

Release files are placed in a "release" folder one level up from your git
root directory.

Nothing is pushed to remote servers, but dojo and xulrunner files may be
downloaded. Dojo to install in the release tarball properly, xulrunner for
building the staff client and avoiding issues with xulrunner changes if
end-users build a custom staff client (say, for autoupdate purposes).

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoTPAC: Add record detail navigation to page bottom
Dan Scott [Sat, 16 Jun 2012 02:10:15 +0000 (22:10 -0400)]
TPAC: Add record detail navigation to page bottom

A usability rule of thumb suggests that navigation on long pages should
not require you to scroll back up to the top of the page from the
bottom; that gets old fast. We already do this on search results pages;
bring the same good practice to record details.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoRemove antiquated 1.6 directory from docs folder.
Robert Soulliere [Thu, 14 Jun 2012 18:35:24 +0000 (14:35 -0400)]
Remove antiquated 1.6 directory from docs folder.

This was used for early DocBook testing and is no longer needed.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoSecurity fix: For auth, give same stacktrace for all cases of LOGIN_FAILED
Lebbeous Fogle-Weekley [Tue, 12 Jun 2012 21:26:39 +0000 (17:26 -0400)]
Security fix: For auth, give same stacktrace for all cases of LOGIN_FAILED

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoSecurity fix: Prevent login by deleted and barred users
Lebbeous Fogle-Weekley [Mon, 11 Jun 2012 18:16:34 +0000 (14:16 -0400)]
Security fix: Prevent login by deleted and barred users

An existing comment in the code suggested that we thought we were already
keeping barred users out.  LP #1010671 brings up that deleted users were
not being kept out.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoSecurity fix for Launchpad Bug 1003052.
Jason Stephenson [Mon, 11 Jun 2012 20:12:54 +0000 (16:12 -0400)]
Security fix for Launchpad Bug 1003052.

Bug reported by James Fournie:

Revoking the UPDATE_MARC permission doesn't actually seem to prevent a
user from editing a record. Our use case is that we would like a user
to create new records but not edit existing MARC records.

Changing CREATE_MARC to UPDATE_MARC in OpenILS::Application::Cat's
biblio_record_replace_marc() method seems to fix the problem.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix in-transit hold retarget
Thomas Berezansky [Wed, 13 Jun 2012 14:12:05 +0000 (10:12 -0400)]
Fix in-transit hold retarget

Tell the abort transit function to not commit our editor on us, basically.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoRemove unsafe thesaurus/control-set mapping
Mike Rylander [Fri, 8 Jun 2012 13:26:25 +0000 (09:26 -0400)]
Remove unsafe thesaurus/control-set mapping

Evergreen 2.2 and beyond includes new Authority Control Set functionality
intended to allow the definition of locally defined authority control
headings.  The primary mechanism for determining which Control Set is used
by any given authority record is to look at the thesaurus fixed field
(mnemonic: Subj), which currently must be uniquely linked to a Control Set.
Failing that (in the case of no thesaurus code at all), there is a backup
mechanism: if the thesaurus value for the authority record is missing or not
used by any configured Control Set then Evergreen will look at the first Main
Entry (1xx) field in the record, and find a control set which uses this field.
This is, obviously, not perfect, but for non-overlapping authority field
schemes, it works very well.

However, the seed data for Evergreen currently includes the "no attempt to
code" value of "|" in the set of thesauri that point to the LoC Control Set.
This value ("|") is also the default value for the Subj fixed field.  This
means that the fallback mechanism is very likely never reached, and anything
short of fully specifying an appropriate thesaurus code for any non-LoC
authority record will run afoul of a similar outcome as the bib-data loss
situation described in bug #983487.

We can avoid this situation in most cases by /not/ tying the "|" thesaurus
value to the LoC control set.

This commit accomplishes this goal by allowing the Control Set for a thesaurus
to be NULL, removing the Control Set for "|" and removing the Control Set
recorded for records with "|" as the thesaurus value, thereby forcing Main
Entry inspection on any use of the authority record where Control Set is

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoSerial Note Sort Fix
Dan Wells [Tue, 12 Jun 2012 13:03:31 +0000 (09:03 -0400)]
Serial Note Sort Fix

Serial notes are currently sorting backwards from what is intended
(and what is expected based on other interfaces).  This was caused
by adding a sort to the middle-layer code which resulted in an
unwanted double reverse.

[whitespace adjustment by LFW per request of DBS]

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoVandelay: Add some padding for inspect queue list
Thomas Berezansky [Mon, 11 Jun 2012 13:43:08 +0000 (09:43 -0400)]
Vandelay: Add some padding for inspect queue list

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoVandelay: Update Current Type/ID on queue retrieve
Thomas Berezansky [Mon, 11 Jun 2012 13:26:17 +0000 (09:26 -0400)]
Vandelay: Update Current Type/ID on queue retrieve

Because other parts of the javascript need those values.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoVandelay: Rewrite Inspect Queues Interface
Thomas Berezansky [Wed, 14 Mar 2012 16:04:25 +0000 (12:04 -0400)]
Vandelay: Rewrite Inspect Queues Interface

This accomplishes several things:
1 - Load the list of queues on page load
2 - Single-click access (rather than select and click) to queues
3 - Batch Deletion of Queues

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agofix double-click in Holdings Maintenance
Jason Etheridge [Fri, 20 Apr 2012 02:37:56 +0000 (22:37 -0400)]
fix double-click in Holdings Maintenance

so that it won't attempt to spawn the Item Editor for non-items

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoMerge remote branch 'origin' into documentation_test
Robert Soulliere [Mon, 11 Jun 2012 18:13:33 +0000 (14:13 -0400)]
Merge remote branch 'origin' into documentation_test

7 years agoConvert docs files from DOS to UNIX format.
Ben Shum [Sun, 27 May 2012 20:55:39 +0000 (16:55 -0400)]
Convert docs files from DOS to UNIX format.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoShow Vandelay Buckets in Manage Record Buckets
Dan Wells [Mon, 11 Jun 2012 15:18:08 +0000 (11:18 -0400)]
Show Vandelay Buckets in Manage Record Buckets

The 'Manage Record Buckets' view is currently filtered to show
only 'staff_client' type buckets.  This expands the filter to
include 'vandelay_queue' buckets.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoRemove licensing info redarding removed PDF icon.
Robert Soulliere [Mon, 11 Jun 2012 17:27:07 +0000 (13:27 -0400)]
Remove licensing info redarding removed PDF icon.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
7 years agoAdded a days_back parameter to authority_control_fields.pl in order to process bibs...
Steven Callender [Thu, 19 Apr 2012 13:47:46 +0000 (09:47 -0400)]
Added a days_back parameter to authority_control_fields.pl in order to process bibs edited X amount of days ago.

The days_back parameter can be used to easily run the script through cron nightly and have it process all newly created or newly added bib records. Ideally it would be ran once a day at nighttime prior to midnight using the --days_back 0 option.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLoad Vandelay queue list in Inspect Queue
Bill Erickson [Fri, 8 Jun 2012 19:51:50 +0000 (15:51 -0400)]
Load Vandelay queue list in Inspect Queue

When the Inspect Queue tab is opened, ensure the list of queues for the
default selected type (bib queues) is loaded.


Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoLP#845096 - coded_value_map_id_seq doesn't have a proper last_value
Michael Peters [Tue, 10 Apr 2012 20:12:13 +0000 (16:12 -0400)]
LP#845096 - coded_value_map_id_seq doesn't have a proper last_value

Thanks to Kathy Lussier for the original report.  Kathy discovered
that users were unable to add new Coded Value Maps via the staff client.

With some log digging, I discovered the culprit was a rash of
primary key errors.

With help from Dan Scott, I was able to rectify this via a quick bit
of SQL which properly sets the last_value in the sequence.

Thanks, Kathy and Dan!

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix broken non-RSS bookbag feeds
Dan Wells [Thu, 7 Jun 2012 14:32:59 +0000 (10:32 -0400)]
Fix broken non-RSS bookbag feeds

This commit addresses LP#1010036 by defining a stub 'description()'
method.  Lack of such a method was causing internal server errors
for other kinds of feeds.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP1009752: activate purchase orders with patron requests
James Fournie [Wed, 6 Jun 2012 21:47:30 +0000 (14:47 -0700)]
LP1009752: activate purchase orders with patron requests

Simple typo: "actor_hold_request" should be "action_hold_request".

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoUpdate 2.1.2 DB schema upgrade script
Dan Scott [Thu, 7 Jun 2012 03:19:10 +0000 (23:19 -0400)]
Update 2.1.2 DB schema upgrade script

As part of the march to 2.1.2, and in time for 2.2.0, update the
2.1.1-2.1.2 update script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAdd TPAC translations
Dan Scott [Wed, 6 Jun 2012 21:43:33 +0000 (17:43 -0400)]
Add TPAC translations

We're still working out our translation update process; new PO files can
fairly easily slip through the net. Fix that for TPAC, which is a pretty
big deal for 2.2.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoCommit i18n POT file changes after 'make newpot'
Lebbeous Fogle-Weekley [Mon, 4 Jun 2012 22:15:57 +0000 (18:15 -0400)]
Commit i18n POT file changes after 'make newpot'

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoImport updated translations from Launchpad
Dan Scott [Wed, 6 Jun 2012 20:39:10 +0000 (16:39 -0400)]
Import updated translations from Launchpad

Lebbeous Fogle-Weekley originally imported these updated translations
from Launchpad. Dan Scott just weeded out a few metadata-only changes
to PO files that didn't need to be pushed to git.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
7 years agoAddress LP #983487: Avoid clobbering bib records at authority merge
Lebbeous Fogle-Weekley [Tue, 5 Jun 2012 21:44:37 +0000 (17:44 -0400)]
Address LP #983487: Avoid clobbering bib records at authority merge

If you've set up a relationship between bib record and authority records
based on arbitrary sets of controlling and controlled fields, but your
authority records don't have the right Subj fixed field value
corresponding to a control set that defines the controlling and
controlled fields you're using, authority merge operations may wipe out
lots of bib data.

Yamil Suarez encountered this bug in testing, and in his case what he
needed to do was set the Subj fixed field in his authority records to
'A' to match his Song Title Index (see the launchpad bug referened

Previously, you could not actually save the Subj fixed field in the MARC
editor (which showed HeadSubj instead of Subj for authority records, and
didn't work).  Now you can.

Thanks to Mike Rylander for help in figuring out the above.

To provide additional protection against merging authority records when
they might not be linked with the right control set, the Manage
Authorities interface will now also show you the linked control set for
any given records.

The implementation of that last bit incidentally meant making sure flesh
and flesh_fields get passed through to PermaCrud for retrieve() calls via
the Javascript openils.PermaCrud wrapper.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoMove 2.0.11 upgrade script into version_upgrade dir
Dan Scott [Tue, 5 Jun 2012 13:17:52 +0000 (09:17 -0400)]
Move 2.0.11 upgrade script into version_upgrade dir

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoAdd the 2.0.10-2.0.11 upgrade script.
Jason Stephenson [Thu, 10 May 2012 17:56:41 +0000 (13:56 -0400)]
Add the 2.0.10-2.0.11 upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoDistinguish route-to-cataloging exception circ messages
Dan Scott [Sun, 3 Jun 2012 00:06:30 +0000 (20:06 -0400)]
Distinguish route-to-cataloging exception circ messages

It appears as though a copy-and-paste error introduced duplicate keys in
circ.properties, which in turn makes newer versions of the Translate
Toolkit unhappy and results in empty translated files. Tracing through
the pertinent code in xul/staff_client/server/circ/util.js, it looks
like the desired key was for "not_found" for the second "cataloging" key
- so change that accordingly.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoFix check for duplicate strings in i18n properties
Dan Scott [Sat, 2 Jun 2012 23:51:55 +0000 (19:51 -0400)]
Fix check for duplicate strings in i18n properties

We had the core of the check in place - just failed to check the
property we were iterating over. Doh.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agoImprove Fedora prereqs and instructions
Dan Scott [Sun, 3 Jun 2012 05:09:26 +0000 (01:09 -0400)]
Improve Fedora prereqs and instructions

Fedora 16 and 17 need the makensis package.

As well, make the Makefile.install target "fedora" to match the OpenSRF
target, and adjust the docs accordingly. This should lead to fewer
changes in the future as Fedora 18, 19, etc roll out.

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoLP975422 patron search from portal/splash page
Jason Etheridge [Wed, 9 May 2012 14:30:17 +0000 (10:30 -0400)]
LP975422 patron search from portal/splash page

make it consider the "Patron circulation summary is horizontal" library setting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoTPAC: Prevent unitialized variable warnings in My Account (repair)
Bill Erickson [Thu, 3 May 2012 20:36:38 +0000 (16:36 -0400)]
TPAC: Prevent unitialized variable warnings in My Account (repair)

The logic in the second IF test was slightly altered by the fix.  An
undef value for username_unlimit should result in executing the block.
Since org setting values are stored as real boolean values, I simplified
the test to a simple if(!username_unlimit) test.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoTPAC: Prevent unitialized variable warnings in My Account
Dan Scott [Wed, 11 Apr 2012 03:34:24 +0000 (23:34 -0400)]
TPAC: Prevent unitialized variable warnings in My Account

Viewing a user's account preferences would trigger two uninitialized
variable warnings if the corresponding org unit settings were not set.

Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoACQ guarantee no PO re-activation
Bill Erickson [Fri, 23 Mar 2012 19:17:50 +0000 (15:17 -0400)]
ACQ guarantee no PO re-activation

Prevent the possibility of double PO activation by preventing it within
the API.  There have been reports in the wild of double-activation, even
though the UI is supposed to prevent it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dan@coffeecode.net>
7 years agoFix broken menu entries under "Other -> Booking" in patron interface
Lebbeous Fogle-Weekley [Fri, 1 Jun 2012 19:43:54 +0000 (15:43 -0400)]
Fix broken menu entries under "Other -> Booking" in patron interface

This issue was reported to me by Steve Callender.  The menu entries
under "Other -> Booking" had all stopped working.

There's a catalog of URL constants under window.urls sometimes, and
formerly (or other times?) at xulG.urls for XUL-based staff client
interfaces.  There's a new-tab-opening method that needed to be more
flexible when looking for that catalog.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoOverride arguments parameter repairs
Bill Erickson [Fri, 1 Jun 2012 14:28:28 +0000 (10:28 -0400)]
Override arguments parameter repairs

In some cases, the override arguments were passed as a paramater after
an @array or %hash argument.  In such cases, any params following are
clumped into the array/hash and the trailing parameters get no values.
Let's explicitly push the $oargs into the preceeding structures.

In the case of Circulate.pm:new, no $oargs argument is needed, as all keys
within the %args hash are tacked onto the circulator object.

Also, for consistency, this change affects one of the hold API calls by
moving $oargs into $params even when not strictly necessary.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
7 years agolp#1007248: tweak order in which pgt rows are renumbered
Galen Charlton [Fri, 1 Jun 2012 03:31:11 +0000 (23:31 -0400)]
lp#1007248: tweak order in which pgt rows are renumbered

Need to renumber from highest to lowest.  Because the primary
key constraint is not deferred, doing the renumbering in a single
statement will fail if there is overlap between the set of
existing pgt.id values and the set of {pgt.id + 100}.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoTPAC bookbag CGI param changed to bbid
Bill Erickson [Fri, 25 May 2012 18:41:18 +0000 (14:41 -0400)]
TPAC bookbag CGI param changed to bbid

To avoid propagating a generic URL parameter like 'id', which can be
picked up by other pages and cause breakage, use 'bbid' instead.  Also,
clear the 'bbid' param from the my-account tabs.

While we're in there, silence an uninitialized string warning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
7 years agoWork Log entry for holds placed from "Search the Catalog"
Jason Etheridge [Fri, 20 Apr 2012 02:22:53 +0000 (22:22 -0400)]
Work Log entry for holds placed from "Search the Catalog"

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>