Bill Erickson [Fri, 14 Sep 2012 19:30:15 +0000 (15:30 -0400)]
Consistent permission filtering in ACQ search results
Add permission checks to search result objects when calling unified
search in 'idlist' mode, consistent with the existing permission checks
for non-id-list mode. Without this, different forms of the call return
different sets of results.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
LP #1092179 FlattenerGrid Filter dialog lead to clobbering grid's base query
You could see this in the Simplified Hold Pull List interface. Using
the filter dialog would refresh the grid and populate it with rows
corresponding to your filters, but it would throw away your setting from
the context org dropdown (labeled "Show the pull list for..." there).
FlattenerGrid had a broken mechanism for trying to nicely mix a user's
input from things like context org dropdowns with whatever they put into
the filter dialog, and now that mechanism has been fixed.
This also means a tiny change to the User Event Log interface to react
to the slight change in FlattenerGrid's API.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Simon Hieu Mai [Wed, 19 Dec 2012 20:33:54 +0000 (14:33 -0600)]
LP#1088561: remove current password (renew password issue with TPAC)
If a user chooses to have their browser remember their password for the
catalog, it can fill in the password to the change password form page
as hidden dots. This behavior was observed specifically with Firefox.
Instead, add autocomplete="off" attribute to the form to force users to
enter existing password to change to a new password as intended.
Signed-off-by: Simon Mai <hieu.mai@mnsu.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Tue, 18 Dec 2012 20:51:12 +0000 (15:51 -0500)]
Make config.update_coded_value_map() consistent
The version of this function in the upgrade file is different than
the one in the 002.schema.config.sql file. This commit fixes the
broken logic in the 002 file and makes it match the logic in the
old upgrade file.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dan Scott <dscott@laurentian.ca>
James Fournie [Tue, 18 Dec 2012 20:45:51 +0000 (12:45 -0800)]
Check for a selection_depth returned from title_hold.is_possible.
See Launchpad 1064651 for details. This is a quick fix which solves a
fairly serious issue whereby copies outside of a hard boundary could fill
holds when they are placed within the TPAC in the staff client.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Scott [Tue, 18 Dec 2012 13:52:55 +0000 (08:52 -0500)]
Dojo IDL: Set the "Accept-Language" header
The internationalization support for /reports/fm_IDL.xml keys off of the
Accept-Language header - which, if not set to ^[a-z]{2}-[A-Z]{2}$, falls
back to en-US. Setting the header in the dojo.xhrGet() request makes
Apache able to serve up the right flavour of /reports/fm_IDL.xml
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Dan Scott [Tue, 18 Dec 2012 12:39:18 +0000 (07:39 -0500)]
Set locale properly in Apache configuration
A RewriteCond only applies to the next RewriteRule, while our config was
attempting to apply multiple rules for a single condition. Fix that up
by using skip (S) rules to apply blocks of rules for the condition in
question.
Also, use the HTTP:Accept-Language value directly, rather than relying
on a backreference (which did not seem to be working as desired).
These fixes enable screens like the Register Patron interface to present
field labels from the IDL in the correct locale, whereas previously they
would always default to en-US.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Pasi Kallinen [Sun, 2 Dec 2012 20:49:42 +0000 (22:49 +0200)]
LP#1078596: Cannot translate strings handled by fieldmapper
Strings that should be translatable only show up in English,
for example in the Patron Registration screen.
There's a bug in the fieldmapper where it sets a variable to
an empty array, but later in the code only checks whether that
particular variable exists, not if it's an empty array.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Tue, 4 Dec 2012 16:04:08 +0000 (11:04 -0500)]
ACQ: repair lineitem cancel-reason fleshing
When fetching lineitems for display in the general lineitem list page,
if the lineitem is cancelled, be sure we correctly retrieve the
cancel-reason object.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Stephenson [Wed, 14 Nov 2012 16:49:49 +0000 (11:49 -0500)]
Resolve LP893448: Prevent hold expiration in past.
If a hold is placed with an expiration date in the past, the
expire_time of the hold will be reset using the hold expiration
interval settings.
Likewise, if a hold is changed to have an expiration date in the
past, the hold expiration date will be recalculated using the
hold expiration interval settings.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Stephenson [Wed, 14 Nov 2012 16:27:53 +0000 (11:27 -0500)]
Add calculate_expire_time helper function to Holds.pm.
This new function calculates an expire_time for a hold based on the hold
expiration interval setting for a passed in org_unit. If the setting is found
the interval is added to "now" and returned as an ISO8601 string. undef is
returned if the setting is not found for the org_unit or its ancestors.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Tue, 6 Nov 2012 21:32:23 +0000 (16:32 -0500)]
Fix foreign character display in receipts
This commit makes two changes to the staff client print code to
help with the proper display of foreign characters:
1) Specify the utf-8 charset in the receipt Data URIs.
2) Properly encode the entire data string using encodeURIComponent
rather than encode(). Failing to do so was causing XULRunner to
be "creative" with the interpretation of the data.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Michael Peters [Thu, 13 Sep 2012 20:28:04 +0000 (16:28 -0400)]
LP#1047475 Set action.hold_request.email_notify to default to false
LP#1047475 points out that email notify prefs are ignored in TPAC.
Even if a patron deselects email notify during hold request time, it
will always be set to true due to the column default.
This change defaults the column in the database to false (like most
other similar columns are) and resolves the bug.
Credit to Steve Callender for the idea.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Pearl [Tue, 11 Dec 2012 15:13:41 +0000 (10:13 -0500)]
LP: #1086064 Ignore spaces in opac username/barcode entry field
Too often, patrons copy the spacing on the barcode on their keytag,
or enter a spurious space before entering their name/barcode. This
change will remove spaces in their name/barcode.
(For now, keep the login screen's directions to omit spaces when
entering the username/barcode.)
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Tue, 4 Dec 2012 15:08:36 +0000 (10:08 -0500)]
Highlight selected facets over multiple lines
As reported by Dan Pearl in LP# 1086150, selected facets that wrap over
multiple lines only have the first line highlighted. Which is odd, and
easily fixed with a small tweak to the CSS.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Acq: When invoice-building with embedded search, allow control of results list
Previously, a results list could accumulate under inconsistent
conditions. You'd get an accumulating results list if you were pressing
enter after successful searches, but your results lists would clear if
you actually clicked the Search button. Worse, searches yielding empty
result sets would *appear* to clear your result list, but subsequent
sucessful searches would restore what was there before.
This is the "missing commit" that makes the behavior consistent and
togglable.
Mark Cooper [Wed, 24 Oct 2012 05:02:38 +0000 (22:02 -0700)]
LP#1058321: Acq: Possible to receive a pending purchase order
Revised to allow a cancelled PO to be received, as this is needed under
certain conditions (note - bib/items are not restored in this case).
Added po_state variable to avoid repeated PO.state() function invocations.
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mark Cooper [Tue, 16 Oct 2012 01:03:44 +0000 (18:03 -0700)]
LP#1058321: Possible to receive a pending purchase order
Restrict 'Mark purchase order as received' to on-order state
purchase orders, and 'Un-Receive Purchase Order' to 'received'
POs. Otherwise inconsistencies easily occur ...
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Fri, 28 Sep 2012 19:48:22 +0000 (15:48 -0400)]
AutoFieldWidget support external copy loc retrieval
When rendering a collection of copy locations, AFW fetches locations
relevant to the context org unit. While rendering an AFW for an
existing object, though, whose copy location is outside of that scope,
the code will now append the non-local copy location to the selector and
tag it with the owning lib (to avoid dupes).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Fri, 28 Sep 2012 19:00:37 +0000 (15:00 -0400)]
ACQ order upload use copy location from owner
When uploading an ACQ MARC order record, attempt to match copy locations
to copies based on the copy owning location instead of the upload
context org unit. This allows one branch to order copies for another
and have the copies use the copy location of the other (owning) branch
(when they exist) instead of the ordering branch (or parent org).
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mark Cooper [Wed, 5 Dec 2012 21:11:23 +0000 (13:11 -0800)]
Use consistent language for holdings/items profiles in Vandelay. Now
uses "Holdings Import Profiles" as standard.
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Wed, 20 Jun 2012 15:47:54 +0000 (11:47 -0400)]
lp1010187 eliminate redundant/unnecessary calls
Particularly invocations of open-ils.circ.stat_cat.asset.retrieve.all in the
Item Attribute Editor
To test:
login with a BR1 workstation
load a pristine (non-stat-cat-laden) BR1 item with the editor
there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
change the Circ Lib on the item to BR4
reload the item in the editor
there should be a call to open-ils.circ.stat_cat.asset.retrieve.all
reload the item in the editor
there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
assign the item a stat cat entry owned by CONS
reload the item in the editor
there should be no call to open-ils.circ.stat_cat.asset.retrieve.all
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Patch to improve the warning on double checkout attempt
Code modifications by David Busby of Edoceo for KCLS
Released without restriction to Evergreen community Signed-off-by: edoceo <code@edoceo.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
edoceo [Thu, 8 Nov 2012 04:08:27 +0000 (20:08 -0800)]
Allow 'Enter' key to run Verify Credentials user check
In both the "Verify Credentials" menu and "Test Password" patron account
option, this change checks for the keypress of "Enter" and then executes
the cmd_verify routine.
Additionally, the password field is blanked after each attempt.
Signed-off-by: edoceo <code@edoceo.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Acq: Yet more efforts to sanitize data for the EDI translator
I specifically did this to address cases reported to me by Galen
Charlton in which get_li_attr_jedi() would return the string "nul", but
I hope this is a nail in the coffin for problems involving
JEDI-producing Action/Trigger templates feeding the EDI translator
strings that the latter doesn't like.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sat, 8 Dec 2012 23:36:12 +0000 (18:36 -0500)]
Roll in some Evergreen in Action chapters
For the initial import we're keeping the formatting and words identical,
so that we can manually sycnhronize changes as needed between the FLOSS
Manuals version of this documentation and the AsciiDoc version.
Receipt template editor sections moved to this chapter.
Converted to asciidoc by rsoulliere. Index terms added by rsoulliere
Some duplicate images were also removed from media directory.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Ben Shum [Wed, 21 Nov 2012 19:17:59 +0000 (14:17 -0500)]
KPAC - fix getit_results with short titles
When using the "Get it" options to either add an item to a list or place an
item on hold, one would get an internal server error whenever attemping this
on a bib record with a short title.
Turns out that the substr function that shortens the length of long titles
breaks when the title is 18 characters or less.
Add an IF check around the substr function to avoid this error.
Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Pasi Kallinen [Tue, 27 Nov 2012 10:39:02 +0000 (12:39 +0200)]
LP#1082260: Update OPAC low search hits template for i18n
The OPAC lowhits.tt2 template is only partially translatable,
and the translatable part is impossible to make sound good
for languages with different word order than English.
This patch changes the already translatable part so there
are 4 different phrases to translate (instead of two phrase
fragments), and makes the search hints translatable.
For English language, the patch does not introduce any visible differences.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Fix lp1076379: Can't edit holds beyond first page.
When a hold was being edited on page 2+ of a patron's list of holds, the
offset was > 0. Since the input hold_ids array ref has only 1 member, using
the offset as a starting point in searching began the search beyond the end
of the array and thus returned nothing.
The code in this commit moves the handling of the offset and limit to cases
where the input hold_ids is undefined, as this is, I think the intended
behavior. Typically when hold_ids is passed to the fetch_user_holds function
in EGCatLoader::Account, you want to retrieve those holds regardless of
the offset and limit values.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Wed, 21 Nov 2012 16:37:06 +0000 (11:37 -0500)]
Test data: avoid crazy transactions for expired patrons
Rather than creating brand new circ transactions for patrons who expired
in 1999, make things a little more realistic by filtering out the
patrons to those whose account expired in the past month or later, and
creating xact_start / due_date values based on their account expiry
date if expired, or NOW() if still active.
Oh, and add some patrons who expired over the past month. :)
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sun, 11 Nov 2012 23:32:44 +0000 (18:32 -0500)]
Sample data: enable loading via eg_db_config.pl
Add "--load-concerto-sample" and "--load-all-sample" options to the
eg_db_config.pl script so that would-be testers can create the database
and load sample data on it in one easy step.
Add a release notes entry.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sun, 11 Nov 2012 15:48:55 +0000 (10:48 -0500)]
Concerto test data: realistic call numbers
Add a parameter to the populate call number function so that we can define the
call number class. As a result, create a new 3-parm version of the function
that simply calls the 4-parm version with a NULL value for the 3rd parm.
Use some realistic LC and Dewey call numbers for the "concerto" bibs so
that we can have more useful tests of the call number browse functionality.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Bill Erickson [Sat, 13 Oct 2012 16:28:29 +0000 (12:28 -0400)]
Expand and modularize concerto data set
* Break function creation and deletion out to their own files.
* Translates lul_fre_100 bibs into SQL
* adds a load_all.sql file for loading all test data
* moves all test data sql to its own dir
* creates a backward-compat concerto.sql loader
* ensure that most users are not already expired
* Adds a 'tag' column to marcxml_import, which populates last_xact_id on
import. This 'tag' is useful for differentiating which records to link
callnumbers to.
* Adds an 'id' column to marcxml_import to ensure insert-order inserts
into biblio.record_entry
* Adds a handful of copies for french records
* Adds supporting functions for creating circ/hold test data.
* creates a pile of sample circ and hold data
* Give most users NULL dobs and suffixes.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 21 Nov 2012 14:24:09 +0000 (09:24 -0500)]
Tweak wording of patron account expiry warning
A warning is something that comes in advance of an event, so a
pre-warning would be a warning about the warning, which is a bit weird.
Hopefully this language will be a little simpler and easier for users to
understand.
Also, fetch the value of the setting once and stuff it in a variable;
vars are cheap and things might be a little more legible.
Also, add a release note entry for the new feature.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Michael Peters [Thu, 8 Nov 2012 19:14:42 +0000 (14:14 -0500)]
Warn on card expiring within 28 days
Thank you to Thomas Berzansky for pointing out a simple way of
accomplishing this, since we were already checking and alerting
if card was already expired.
This places an alert on the "stop sign" page if the card expires
within 28 days from the current date.
Interval can be configured by editing preexpire.setDate in display.js.
Signed-off-by: Michael Peters <mrpeters@library.in.gov> Signed-off-by: Ben Shum <bshum@biblio.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 19 Nov 2012 20:55:34 +0000 (15:55 -0500)]
Docs: Add offline circulation basics
Based heavily on the documentation from Evergreen 1.6, which was in turn
based heavily on the Sitka documentation for offline mode, add some
coverage of the offline processes for registering patrons, checking
items in and out, renewing items, and uploading & processing
transactions.
Dan Scott [Thu, 27 Sep 2012 03:25:53 +0000 (23:25 -0400)]
Apply the 0715 update for acq settings_group
We add the 'acq' config.settings_group in the seed data, and add the
other settings groups in the 2.1-2.2 upgrade script, but need to add the
acq settings_group to the 2.1-2.2 upgrade script.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
After upgrade, list records with missing or incorrect 901$c
This is a common cause of pain for upgrades. Let's try to identify the
problem early (even if it takes forever on a site with 3 million bibs)
and offer advice on correcting the problem if it is flagged.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Check for stop fines reason of CHECKIN or RENEW before closing a circulation
transaction when the balance reaches zero.
Also, if the stop fines reason is LOST, then check a new ou setting,
circ.lost.xact_open_on_zero, to determine if the transaction is closed or
kept open. The setting is checked for the circulation copy's circ_lib.
Add CircCommon->can_close_circ.
Following up on Dan Wells' comments on Launchpad Bug 793550, I have moved
the logic to check if the circ transaction can be closed to its own utility
function in OpenILS::Application::Circ::CircCommon. This potentially
consolidates the logic in one place in case we need to use it elsewhere.
Instead of checking for stop fines reasons of CHECKIN and RENEW and
checking for checkin time on the circ, we just check for checkin time.
Both CHECKIN and RENEW should set the checkin time.
Also, use the constant for stop fines reason of LOST, rather than the
literal string "LOST".
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Mon, 12 Nov 2012 16:46:21 +0000 (11:46 -0500)]
No need for vanity info in OpenSRF article
We don't credit particular authors in the Evergreen docs, and we don't
want to dissuade contributors from improving & evolving any particular
section of the docs, so get rid of a hangover attribution from the
OpenSRF article.
Dan Scott [Mon, 12 Nov 2012 16:32:31 +0000 (11:32 -0500)]
Add "Intro to OpenSRF" to development section
We have the Asciidoc source, so let's drop it into place. Triggered by a
request for info on OpenSRF development on IRC that was answered with
"we don't really have much information on that" response. *Poof*, now
we have some.
Dan Scott [Mon, 12 Nov 2012 16:28:58 +0000 (11:28 -0500)]
Docs: resolve transform errors and warnings
ePub really doesn't like absolute references to images - which is good,
it shouldn't. Also, single line NOTE blocks are much easier to deal with
using the prefix approach (and don't generate warnings during normal
HTML generation).
Dan Scott [Wed, 7 Nov 2012 17:55:49 +0000 (12:55 -0500)]
make_release: add the \set eg_version command to upgrade script
We were echoing the output to STDOUT instead of redirecting it to the
upgrade script that we were generating. Let's go the last mile and
actually get it into the upgrade script.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Mike Rylander [Wed, 10 Oct 2012 21:36:52 +0000 (17:36 -0400)]
Make it possible to suppress IDL fields
Some clients of external services, particularly pcrud and reporter-store,
need to be able to access tables that contain columns we'd rather restrict.
For instance, the passwd field on actor.usr.
To effect this feature we provide a blacklist attribute for fields, called
suppress_controller, which works in the same way as the class controller
attribute but names controllers not allowed to use the field. When the field
is explicitly named in a query (fieldmapper select block or json_query) an
error is thrown, and suppressed fields are ingored in general fieldmapper
search/retreive requests.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
projects / Evergreen.git / log