LP#1904244: fm-editor: add a linkedSearchConditions field option
This option allows the caller to specify conditions to add
when retrieving values for a linked field, e.g., to specify
that only active values should be fetched.
If the underlying record has a value set for the linked field, that
value will be included when preloadLinkedValues and the value
doesn't otherwise meet the search conditions.
This patch also sorts the values if preloadLinkedValues is used.
Galen Charlton [Thu, 25 Mar 2021 17:44:44 +0000 (13:44 -0400)]
LP#1904244: teach grid columns how to start with a filter set
This adds initialFilterOperator and initialFilterValue inputs
to eg-grid-column to specify that the data set should start off
with a column filter set.
LP#1904244: update various IDL labels for acq columns
* Claiming and fund tables: "Org Unit" or "Org" to "Owner"
* "Claim Policy ID" to "Claim Policy" for links to claim
policies
* "Fund ID" to "Fund" for links to funds
* Fund allocation and fund debit times
Bill Erickson [Tue, 3 Aug 2021 20:58:29 +0000 (16:58 -0400)]
LP1934184 Vandelay Delete Queue action repair
Fixes the Queue Details page Delete Queue link. Before it did nothing,
now it prompts the user to confirm deletion followed by deleting the
queue (when confirmed).
To test, go to Cataloging => MARC Batch Import/Export => Inspect Queue
=> Double-click a queue => Click Delete Queue (under Queue Actions) and
confirm that the confirmation dialog appears and deletion works.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 6 Aug 2021 15:35:49 +0000 (11:35 -0400)]
LP#1450519: remove unauthorized access to library setting history
This patch changes the current Library Settings editor so that
it doesn't display the setting history for a setting that the user
doesn't have the underlying view permission for. It also removes
the coustl IDL class [config.org_unit_setting_type_log] from PCRUD.
Access to the setting history is now done through a new method,
open-ils.actor.org_unit.settings.history.visible.retrieve, which
accepts an authtoken and a setting name. If the user has the
relevant view permission, setting history entries at all of the
OUs that they have the permission at are returned. If the user
lacks the permission, an empty array is returned. If the setting
has no permission associated with it, all history entries for
the setting are returned. The user must have at least STAFF_LOGIN
to retrieve any entries at all.
To test
-------
[1] As an administrator, make some changes to the values of
a privileged library setting (such as one of the credit card
ones) and an unprivileged one (e.g., lib.info_url).
[2] Log in as a staff user without administration privileges
and go to the library settings editor. Note that while the
current value of privileged settings are not displayed, clicking
on the history link displays the full history of the setting.
[3] Apply the patch and repeat step 2.
[4] This time, history for the privileged setting is not displayed,
while history for an unprivileged setting continues to be
available.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Shula Link <slink@gchrl.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
The baseline schema did not get updated to include the
opac.did_you_mean.max_suggestions YAOUS, so fresh, rather than upgraded,
Evergreen installs will be missing it.
This commit adds it to the baseline and provides an upgrade script to
give the setting to impacted instances.
Jason Stephenson [Fri, 16 Jul 2021 19:50:59 +0000 (15:50 -0400)]
Lp 1936662: Add CPAN Module Prerequisites for Debian and Ubuntu
This commit adds the missing CPAN module prerequisites for the "did
you mean" feature to the PostgreSQL server Makefile targets for Debian
Jessie, Stretch, Buster and Ubuntu Bionic.
They were added to the Makefile target for Ubuntu Focal but were
apparently overlooked in the other distros.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Boyer [Thu, 22 Jul 2021 17:50:53 +0000 (13:50 -0400)]
LP1937299: Collections Exempt User Setting Repair
The collections exempt user setting was never added to the seed data
meaning that depending on the age of your database it may or may not
be there. Additionally, correct the label for this setting in the
user editor.
The method of playing audio alerts seems to not be working in modern browsers.
It seemed to work in firefox V40, but no longer in V68.
Adding the autoplay element and then immediately removing it prevents the audio
from playing. I've also noticed in the past that the audio had been cut off
before the file was fully played.
Using the .play() method does seem to work in newer versions of Firefox
and Chrome. Tested with Chrome V90 and Firefox V78.10.1esr.
Testing Plan:
1. Enable Self Check Audio Alerts Library Setting.
2. See the docs for setting up the default audio alerts.
https://docs.evergreen-ils.org/reorg/3.1/command_line_admin/_self_check_interface.html
3. Launch self check interface, create a workstation and try to trigger an alert.
https://eg-server.you.com/eg/circ/selfcheck/main
4. entering a fake barcode will trigger an alert which should not be audible.
Apply the fix:
1. Launch self check interface, and reload/clear cache.
2. Enter a fake barcode to trigger an audio alert.
3. The audio alert should now be audible.
Jason Etheridge [Thu, 25 Mar 2021 20:21:00 +0000 (16:21 -0400)]
lp1894005 Stripe payment intents
===== Credit card payments using Stripe now implimented with PaymentIntents instead of Charges =====
This changes the Stripe code in the OPAC to use their PaymentIntents and confirmCreditCard API,
which is recommended over their Charges API. Credit card charges are no longer finalized
(captured/confirmed) on Evergreen's backend, though the backend does check whether a payment was
made successfully before recording it.
Sponsored-by: CW MARS Sponsored-by: NOBLE Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Lynn Floyd [Mon, 2 Aug 2021 16:03:15 +0000 (09:03 -0700)]
DOCS:Shelving Locations, Added images and updated directions
Added images and updated information on Shelving locations. Included information on Hold_Verify
Adding additional information in to the shelving locations.
Added Index terms.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Wed, 14 Jul 2021 16:20:03 +0000 (09:20 -0700)]
LP1718782: follow up to fix failing test
LP1718782 added a missing fixed field, but failed to also add it to
the expected data in this pgtap test. This commit updates the
expected data to also include a SRCE fixed field.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Thu, 10 Sep 2020 18:35:22 +0000 (11:35 -0700)]
LP1718782: Add the Srce fixed field to the Angular MARC editor
To test:
1) Without using private browsing, open up a bibliographic record in
the Angular catalog MARC editor.
2) Notice that there is a gap between the ELvl and Audn fixed fields.
3) Apply this patch.
4) Open up the same bibliographic record, this time using private
browsing (since the Angular MARC editor caches fixed field values).
5) Notice that the Srce fixed field is available between the ELvl and
Audn fixed fields.
6) Notice that you can right click inside the fixed field to get a list
of three possible values.
7) Repeat the test with different record types (e.g. BKS, SCO, VIS)
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Mary Llewellyn <mllewell@biblio.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Bill Erickson [Mon, 5 Jul 2021 20:04:56 +0000 (16:04 -0400)]
LP1910808 Staff catalog show call number
In the search results page, show the first call number for each record
(sorting by label sortkey) that is owned either by the user's preferred
library or the search library.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Sun, 10 Jan 2021 06:20:29 +0000 (22:20 -0800)]
LP1910891: Add new booking perms to appropriate groups
Steps to test:
1) Without this patch, create a reservation for a BR1 resource at BR1.
2) Log in as a circulator at BR1.
3) Go to Booking > Manage Reservations. Note that you can't see your reservation.
4) Run this upgrade script.
5) Repeat steps 2-3. Notice that you can now see the reservation.
6) Wipe your database and re-install it with the additions to the seed data
in this commit. Repeat steps 1-3 and notice that you can see the reservation
as expected.
Bill Erickson [Fri, 2 Jul 2021 20:57:40 +0000 (16:57 -0400)]
LP1908722 Staff catalog Show More Details
Adds a "Show More Details" (and "Show Fewer Details") buttons to the
Angualr staff catalog. Similar to the TPAC, activating the button means
more holdings details are displayed in the search results page.
Adds a new workstation setting type called
'eg.staff.catalog.results.show_more'
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Mike Risher [Tue, 17 Sep 2019 21:33:04 +0000 (21:33 +0000)]
LP#1844169: port Search Filter Groups admin interface to Angular
Port search filter groups admin from DOJO UI to Angular. Each search
filter group has its own edit page, from which you can edit search
filter group entries.
Jane Sandberg [Tue, 2 Feb 2021 02:04:02 +0000 (18:04 -0800)]
LP1913221: Don't display blank course section number in OPAC
To test:
1) Use the Library Settings Editor to turn on the Course Materials
Module.
2) In Local administration, go to the course reserves list.
3) Add several courses, some with section numbers, others without.
4) In the OPAC, use the Course Search function to search for the courses
you just added.
5) Notice that the search results page has a place for section numbers,
whether or not the course has one.
6) Click into some of the courses. Notice that the course page also
includes a place for section numbers, whether or not the course has
one.
7) Apply this patch.
8) Repeat steps 4-6. Notice that the blank "section number" areas no
longer appear.
Garry Collum [Tue, 11 May 2021 19:43:34 +0000 (15:43 -0400)]
LP1928005 Bootstrap Opac: Current charges not aligned on mobile.
This patch removes the classes from the charges table that presents the table in a vertical format.
It wraps the table in a <div> that uses the table-responsive class.
To test add some charges to a patron record.
Bring that patron's account up in the opac and view the charges table in the smallest browser size
possible.
Notice that the table switches to a vertical format and the column names are mis-aligned.
Apply the patch.
View the table again. The table should now be horizontal with all of the columns correct.
Galen Charlton [Fri, 4 Jun 2021 20:17:33 +0000 (16:17 -0400)]
LP#1929136: (follow-up) reduce bounce time to 500ms
During testing, 500ms was enough to avoid excessive
PCRUD calls while still keeping the interface's display
of duplicate or missing barcode warnings responsive.
Jeff Davis [Thu, 20 May 2021 21:51:17 +0000 (14:51 -0700)]
LP#1929136: delay barcode lookup on change in holdings editor
In the Holdings Editor, any change to the barcode field results in an
immediate API call. Thus, if you type the barcode "123456789", you
would get 9 separate calls: 1, 12, 123, 1234, 12345 ...
This commit adds a 1000ms delay to avoid excessive pcrud calls when
typing a barcode.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 14 Jun 2021 15:34:51 +0000 (11:34 -0400)]
LP#1930933: fix issue with over-escaping in search results title attributes
This patch fixes an issue where a record with a title containing the
word "hidden" can have its title, ironically enough, not show up
on public catalog search results.
To test
-------
[1] Create an OPAC-visible record whose 245 is something like:
=245 04$aThe hidden one <script>alert('title!')</script>
[2] Search for the record in both the TPAC and Bootstrap skin. Note
that the title isn't displayed.
[3] Apply the patch and repeat step 2. This time, the full title
should be displayed.
[4] Verify that the OPAC does not display an alert box.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Bill Erickson [Mon, 4 Jan 2021 21:12:50 +0000 (16:12 -0500)]
LP1910145 Angular Hold Detail Notes & Notifications
The hold detail view now displays hold notes and hold notification
records. Notes and Notifications may be created by staff. Notes may be
deleted by staff.
The catalog under the Holds tab in the Checkout interface
doesn't load the default search or preferred library if
you haven't visited the main catalog page earlier in the
session.
This branch sets these settings as cookies in the
AngularJS wrapper for the catalog embedded in the Checkout
interface under the Holds tab.
Test:
1. Close browser, open browser, log into Evergreen
2. Admin->Workstation set search & preferred library
3. Open a patron record -> Holds tab -> Place Holds
4. Search for an item owned by your preferred library
5. Note the library's copies aren't separately indicated
6. Apply patch and repeat steps 1-5
7. Note the library's copies are separately indicated
Jason Etheridge [Thu, 1 Oct 2020 15:45:44 +0000 (11:45 -0400)]
lp1895738 need eg.orgselect.hopeless.wide_holds
This fixes the following:
ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.
However, it exposes a different (harmless?) error within the /eg2 holds grid:
ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Fri, 28 May 2021 02:32:27 +0000 (19:32 -0700)]
LP1922120: Add to carousel action in angular catalog
To test:
1) Create several manual carousels, and make sure they are
set to active.
2) Open a bib record in the Angular staff catalog.
3) Under Other Actions, choose the "Add to Carousel" action
4) Choose your preferred carousel.
5) Click Add to carousel.
6) Go back to carousel administration (or look at the carousel
itself), and confirm that the record has been added to the
carousel in question.
projects / Evergreen.git / log