Steven Callender [Thu, 14 Nov 2013 20:42:12 +0000 (15:42 -0500)]
LP1251424 - Fix for submit button when placing holds in staff client
I've moved the initializing of the cur_hold_barcode variable
to within the function rather than floating outside of it.
This seemed to fix an intermittent issue where the submit
button would not become activatable when first going to the
place hold screen via the staff client. To create the hold,
ths user had to cycle through the "Place hold by patron barcode"
option and then back to "Place hold for me" option.
It looked like behind the scenes for certain org units that
variable would not be set and the button will not open until
it at least has something. This causes it to be set on the initial
loading of the screen.
Signed-off-by: Steven Callender <stevecallender@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
Added a definition to the HOLD_ITEM_CHECKED_OUT event in ils_events.xml.
Trying to be generic between the opac and the staff client the message
reads, "The item you have attempted to place on hold is already checked
out to the requestor."
[LFW: I made a tiny spelling change to be consistent with other
appearances in Evergreen of the term "requestor".]
Acq: Improvements to account-matching incoming EDI messages
The way the EDI fetcher works gives us a problem. That process iterates
over EDI accounts for which it has FTP host and credential information,
downloads documents from each of those sites, and files the messages
within those documents under the EDI account from which the login
credentials came. The problem is that in practice the exact same host
and login information is used by multiple accounts under the same
vendor, and files relating to these sub-accounts are commingled, so that
you can't make the decision about which messages should be filed under
which accounts based on the name of the document or its location. You
have to make that decision later, based on its contents.
We are already incompletely doing this, distinguishing between
sub-accounts under which we could file our messages when the vendor
specifies the buyer's SAN next to the specific sub-account number *and*
those sub-accounts belong to different Evergreen org units. We still
need ways to distinguish in other cases.
This will do what is natural for at least one vendor, and match the
message content against the vendacct field of the acq.edi_account table.
*Also,*
We were re-retrieving the working acq.edi_message row from the database
before writing it, throwing away possible changes to the object in hand
made by O::A::Acq::EDI::process_parsed_msg(). We should only do that in
the case where that function has raised an exception.
We were doing the same kind of thing in another place actually inside
process_parsed_msg() where we set the edi_message's purchase_order field
based on the first lineitem encountered if the message itself didn't
specify a valid PO identifier.
This supports making account-correction work for ORDRSP messages in
addition to INVOIC messages.
We also propagate that same correction to the provider and shipper
fields of any invoices that get created from said edi_message.
Dan Wells [Mon, 28 Oct 2013 15:23:08 +0000 (11:23 -0400)]
TPAC: Remove fixed height from 'View My List' button
The TPAC button styles have been largely consolidated, but this little
outlier got missed. It doesn't do anything of noticeable value in
recent browsers, and in fact hurts the display by causing the "Sort by"
widget to "hang" when resizing the window to certain intermediate
sizes. Remove it.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Wells [Wed, 6 Nov 2013 22:24:38 +0000 (17:24 -0500)]
Fix typos in 2.5 release notes
These typos were fixed in the separate (now deleted) files, but only
after the collective file had been built. This commit transfers those
fixes to the built file.
Bill Erickson [Thu, 23 May 2013 19:20:14 +0000 (15:20 -0400)]
Default per-request TPAC locale
Set the OpenSRF default client locale for each TPAC request to ensure
all outbound OpenSRF calls use the requested locale. When done, reset
the locale to the OpenSRF default.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Fri, 1 Nov 2013 17:57:35 +0000 (13:57 -0400)]
Add indicators; Remove junk tags
First, we were not supplying authority tag indicators when generating the
overlay template. The xml merge function does not currently transfer
indicators, but we need to do this anyway because newer MARC::Field version
balk at fields with no indicators.
Second, PG 9.1+ adds wrapper tags to xml content that is passed to XMLELEMENT
as an array. So, we'll use XMLAGG to get around that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Tue, 29 Oct 2013 15:37:36 +0000 (11:37 -0400)]
Use all subfield values to link authority records to bibs
Given an Evergreen instance with two authority records loaded, one
being a more specific than the other via a repeated subdivision subfield,
we must make sure that we use all the bib-supplied subfield values when
attempting to auto-link to the correct authority. Otherwise, the "shorter"
authority record may be selected as appropriate, and data in the bib record
would be lost.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Fri, 1 Nov 2013 19:08:23 +0000 (15:08 -0400)]
Clean up 2.5 upgrade instructions
This commit cleans up a few tiny issues and a large formatting bug,
fixes a filename, and reorders the linux distros to put the newest ones
first. The content related changes are:
- fix filename in 'tar' command
- reorder linux distros (in two places)
- fix various punctuation (add comma; remove colon in header)
And the AsciiDoc changes:
- add asciidoc '+'s before and after 'indexterm' commands to fix
broken ordered list formatting
- remove an unnecessary asciidoc '+'
- correct the length of an asciidoc block header line (doesn't change
behavior, but helps readability of the text file)
Mike Rylander [Fri, 25 Oct 2013 16:15:25 +0000 (12:15 -0400)]
Respect source XML subfield order during overlay
When adding specific subfields to a field as described by an add
or replace rule we were adding them in rule-order. Instead, they
should be added in source-XML physical order. This commit does
that.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Tue, 29 Oct 2013 13:42:08 +0000 (09:42 -0400)]
Make browse pivot DB funcs STABLE
Since these are just convenience functions doing only selects, these
should be STABLE safe, and making this change allows browse to be
functional on production-size data sets.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 24 Oct 2013 20:10:00 +0000 (16:10 -0400)]
Make sure that # can be used in auth browse
Because we use URLs to call the SuperCat browse API, we need to
be more careful about encoding parameters. #, in particular, breaks
auth browse because it's seen as a URL fragment separator by the browser
and web server.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Yamil Suarez <yamil@yamil.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 24 Oct 2013 13:54:49 +0000 (09:54 -0400)]
RDA / TPAC: Add 264 for pubinfo graphic 880 lookups
Per https://bugs.launchpad.net/evergreen/+bug/1243746 the publication
info in search results was coming up empty for RDA records because they
use 264 for publication info instead of 260.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
Remington Steed [Thu, 24 Oct 2013 12:40:05 +0000 (08:40 -0400)]
Docs 2.5: Fix floating groups heading level (2nd try)
The first attempt successfully pushed the Floating Groups chapter to
its proper place in the table of contents, but it also mistakenly pushed
many following chapters down one heading level. This commit follows the
approach already common in the root.txt file, and also undoes the
previous approach of shifting the heading level within the chapter file
itself. I suspect the previous approach only failed because it lacked a
blank line before the final 'leveloffset' command, but this new
approach is better because it is already in common use.
Remington Steed [Thu, 17 Oct 2013 16:07:03 +0000 (12:07 -0400)]
Serials Docs: Update for new features in 2.5
This commit adds a "Notes" section to the chapter on Receiving, including
a subsection on using the new "alerts" feature in the receiving interface.
It also adds a new screenshot for the "Notes" section and updates two
screenshots that have changed in 2.5. Finally, this commit updates the
Serials Copy Template doc to reflect the new 2.5 Floating Groups feature.
Remington Steed [Wed, 16 Oct 2013 20:13:50 +0000 (16:13 -0400)]
Serials Docs: Improve format, fix typos, and update
This commit makes several minor changes to the Serials doc files, mostly
changes in formatting or corrections of bugs/typos. This list covers
most of the changes:
- Add row on 'receiving' to Serials interfaces comparison table
- Improve formatting of actionable items (using bold and arrows),
e.g. Click on *First Menu* -> *Next Menu* -> *Last Menu*
- Standardize formatting of form field names (using italics)
- Improve unclear wording
- Correct an outdated description of copy template 'status' field
(changed before 2.3)
- Change heading level for a subsection
Remington Steed [Wed, 23 Oct 2013 13:54:00 +0000 (09:54 -0400)]
Docs 2.5: Fix floating groups heading level
The new Floating Groups docs are acting like a Docs Section rather than
a Docs Chapter. This commit should bump all the headings down one level
so they will take their appropriate place in the TOC.
Dan Scott [Mon, 21 Oct 2013 15:12:06 +0000 (11:12 -0400)]
Fix "elfield" typo noted by Ben Ostrowsky
Per sylvar in IRC and in
https://bugs.launchpad.net/evergreen/+bug/1240636, "elfield" should be
"selfield" (even though the code in question is currently inside an "#if
0" block and will never execute).
Kathy Lussier [Wed, 16 Oct 2013 21:04:11 +0000 (17:04 -0400)]
Release notes cleanup
General release notes clean-up including the following:
* Fixing typos and grammatical errors. Thank you to paxed and remingtron
for alerting me to some typos.
* Fixing up the section headers so that they don't go beyond 5 levels
deep. In some cases, this invovled reorganizing content. I didn't trim
content as suggested by dbwells, but there may be room for some more
trimming.
* Renaming some things to reflect the name that is used in the staff
client to make the release notes more accessible to the average user.
* Reorganizing some content in a logical order.
Dan Wells [Tue, 15 Oct 2013 21:27:57 +0000 (17:27 -0400)]
Initial compilation of release notes for 2.5
This is a first real attempt at compiled release notes for 2.5.
A few things to note:
1) While content was moved around a little (New Features vs Upgrade
Notes), nothing was outright removed.
2) Some of the sections are indented using ':leveloffset:'. As a
result, some section headers end up being more than 5 levels deep, and
therefore do not display when generating (for example) HTML. I think
(in most cases) we want to trim these parts out of this 'release notes'
file and put the offending sections in the actual documentation for
the feature, so I am leaving it as-is for now.
To easily see these too-deep sections, you can run:
asciidoc -a toc -a numbered RELEASE_NOTES_2_5.txt
and look at the warnings.
I have also not yet cleared out the RELEASE_NOTES_NEXT folder, as I
want to ask some of the docs folks first before I do so.
Galen Charlton [Mon, 14 Oct 2013 16:21:58 +0000 (09:21 -0700)]
LP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()
This follows up on observations made by Steven Chan that
suggests that even the act of creating an anonymous hash and
passing it to a global function can cause (I assume) JavaScript
execution contexts to be leaked.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
This implements using the new custom event rather than
xulG.set_tab() to refresh a refresh of the checkout tab. It
also removes use of a callback function to request the tab
refresh in favor of a simple setTimeout().
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1086458: define custom event for refreshing the checkout page
Using a custom event handled by a chrome event handler rather
than calling xulG.set_tab() directly avoids any possibility of
leaking objects and executation contexts from the code that's
requesting refresh of the checkout page.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Galen Charlton [Mon, 14 Oct 2013 15:23:23 +0000 (08:23 -0700)]
LP#1086458: convert last-print information hash to JSON string before caching
By serializing the printing message and context information to a
JSON string before caching it, we avoid inadvertantly dragging in
things like Javascript execution contexts and possibly references
to objects created by the checkout interface. This was contributing
to the staff client memory leaks observed during receipt printing.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Tue, 15 Oct 2013 13:33:46 +0000 (09:33 -0400)]
Serial alert notes missing commit
These changes were somehow lost during the hacking on this feature
at the Hack-a-Way. The translation string is nice, but the changes
to notes.xul are necessary for being able to create notes.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
Dan Scott [Tue, 15 Oct 2013 03:09:54 +0000 (23:09 -0400)]
Fix TPAC account preferences
Clean up a few problems in the TPAC "My Account" preferences area:
1. Add a missing </form> closing element, which was preventing any
submitted changes from actually being posted to the correct URL
(thus preventing most account preference changes such as
notifications).
2. Remove trailing semicolon from several generated <option> elements
for cleaner HTML.
3. Make the aria-label for the element translatable.
As we're touching a majority of the lines in the section and the lines
do not follow normal whitespace standards (mixed tabs, inconsistent
indentation, etc), clean up the whitespace.
Also turn one HTML comment into a Template::Toolkit comment.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Chris Sharp [Tue, 15 Oct 2013 13:01:57 +0000 (09:01 -0400)]
Fixing typo in the crontab.example file
I'm assuming here that the intention was to set the purge_pending_users.srfsh
job to run at 2:30 a.m., but it was set to run at 30:02 - obviously an invalid
time.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Wells [Mon, 14 Oct 2013 19:24:39 +0000 (15:24 -0400)]
Fix integrated subscription editor record field
When trying to edit a subscription using the new 'integrated' editor,
it foolishly tries to populate an unfiltered bre dropdown selector.
This works OK in test environments, but (as expected) fails miserably
with production-size data sets.
The end result is that the dropdown either never populates, or takes
a really long time. If the user saves before the dropdown loads, the
associated record ID is lost, and the subscription is no longer
properly associated with the record.
To fix this, simply turn the dropdown into a disabled text input
instead, as the ability to edit this field would generally be more
harmful than it is necessary.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Fri, 4 Oct 2013 15:34:04 +0000 (11:34 -0400)]
TPAC: Remove needless divs from results header bar
In the current state of the TPAC, these "div"ider elements were
completely invisible, yet nobody seemed to miss them. It wasn't
altogether clear what the divisions meant anyway, so rather than fix
them, let's just trim them out for now.
Also, get rid of a useless clearing div while we are at it. I could
not detect a valuable display difference in current Chrome, Firefox,
or IE9.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Fri, 4 Oct 2013 15:23:13 +0000 (11:23 -0400)]
TPAC: Redo some margins/padding for better collapse behavior
In the "results header", we have both buttons and form elements. In
order to have these elements collapse in an orderly fashion, they need
to be exactly the same size. To accomplish this, let's simplify and
redo a few of the element margins and padding.
At the very least, this will make the elements line up better
vertically when viewed at the normal screen width.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Wed, 4 Sep 2013 18:55:57 +0000 (14:55 -0400)]
Vandelay copy overlay call number merge
When overlaying a copy, if the copy brings with it a new call number
which collides with an existing call number AND said copy is the only
copy linked to its (old) call number, merge the copy's (old) call
number into the (new) existing call number, i.e. the one we collided
with.
Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Wed, 9 Oct 2013 17:46:55 +0000 (13:46 -0400)]
Don't index browse extracts as search terms unless needed
In previous releases, we didn't have any major config.metabib_field
rows which had 'browse_field = true' but 'search_field = false'. Now
that we have one (for title browse), make sure we honor the
'search_field = false' by not creating rows in the
metabib.xxxxxx_field_entry tables.
This gets us back to where we started as far as what gets into the
search index tables, but we should consider going a step further and
*not* adding the glommed row to the search tables if we are already
adding separate rows for search+browse.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Mon, 7 Oct 2013 21:22:42 +0000 (17:22 -0400)]
Tweak MODS32 stylesheet for titles
<titleNonfiling> was added to help certain search cases, but trailing
punctuation makes it unsuitable for display. <titleInfo>, on the other
hand, chops all trailing punctuation out, which helps the trailing case
but actually makes display of subtitle information worse. Let's split
the difference and simplify at the same time by building the whole
title, then trimming extra punctuation.
While the above was done to help in browse display, it turns out that
<titleNonfiling> is not able to generate correct browse data. We want
the display as corrected above, but we also need to preserve the
<nonSort> tag for proper browse sorting.
Rather than complicate the metabib logic, we'll add another special-
purpose field to the MODS called <titleBrowse>. This field is a hybrid
of <titleInfo> and <titleNonfiling>, which will give us a preformatted
string (for preserving needed punctuation) but also keep the <nonSort>
stuff in a separate field (for sorting).
NOTE: We are purposely ignoring similar changes to MODS33, pending
a discussion of how best to handle EG specific MODS changes overall.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Pasi Kallinen [Mon, 24 Jun 2013 16:59:58 +0000 (19:59 +0300)]
Fix LP1118245: Name Subject facet ordering change
Where Name Subject facet shows subfields in order "cad" and Personal
Author shows subfields in order "acd". This change makes the Name
Subject show the subfields in the same order as in record view and the
Personal Author facet.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
NOTE: We are purposely ignoring similar changes to MODS33, pending
a discussion of how best to handle EG specific MODS changes overall.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Thu, 10 Oct 2013 19:54:40 +0000 (15:54 -0400)]
Adding 0842, 0843 to help with 0841 deficiencies
A clean backport of 0841 was not possible due to partial schema
differences in the upgrade. While we may have planned ahead better,
add 0842 just for 2_3 upgraders which ends up being a no-op for
2_4, and adds ON UPDATE CASCADE for 2_5.
Also, for similar but additional reasons, add 0843, which serves two
purposes:
1) add ON UPDATE CASCADE to the rest for those upgrading 2_5/master
2) alter config.z3950_index_field_map for those upgrading from 2_4
and previous (other lines are no-ops in this case)
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
Jason Etheridge [Thu, 22 Aug 2013 16:48:53 +0000 (12:48 -0400)]
Add a TestUtils library for live tests
Package commonly used live test calls in a new Perl module to they can
be shared by different test scripts.
Based it off of Cronscript. Added a cache method to Cronscript for getting at
memcached. TestUtils currently has methods for checkin, checkout, and
workstation registration.
Ported existing live tests to use TestUtils.
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Fri, 2 Aug 2013 19:25:58 +0000 (15:25 -0400)]
test bill payment
./05-pay_bills.t ..................
1..10
# Test bill payment against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
# authtime is 7200, authtoken is b039320a72bbd06c30f0918d1aeeb07a
ok 3 - Have an authtoken
ok 4 - Registered a new workstation
# authtime is 7200, authtoken is b039320a72bbd06c30f0918d1aeeb07a
ok 5 - Have an authtoken associated with the workstation
ok 6 - Two billable xacts for admin user from previous tests
ok 7 - Both transactions combined have a balance owed of 1.25
ok 8 - Payment attempt returned HASH
ok 9 - Payment response included two payment ids
ok 10 - Zero billable xacts for admin user after payment
ok
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Wed, 17 Jul 2013 21:55:07 +0000 (17:55 -0400)]
tests against stock test data and live Evergreen
I'm running these on a machine where Evergreen has been installed with the stock
test data. Repeat invocations of the tests will cause test failures, as they
don't completely cleanup after themselves (the goal long-term is to rely on
complete database wipes between invocations).
Manual cleanup right now could include doing the following in psql:
DELETE FROM actor.workstation WHERE name ~ '.t$';
and paying the bills on the admin user (otherwise, once a Max Fines penalty is
generated, checkout tests will fail).
opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods (livetests)$ make livecheck 2> /dev/null
perl Build.PL --destdir || make -s build-perl-fail
Creating new 'MYMETA.yml' with configuration results
Creating new 'Build' script for 'OpenILS' version '2.4'
./Build test --test_files live_t || make -s build-perl-fail
live_t/00-simple.t ..................... ok
live_t/01-auth.t ....................... ok
live_t/02-simple_circ.t ................ ok
live_t/03-overdue_circ.t ............... ok
live_t/04-overdue_with_closed_dates.t .. ok
All tests successful.
Files=5, Tests=62, 11 wallclock secs ( 0.25 usr 0.16 sys + 3.52 cusr 0.63 csys = 4.56 CPU)
Result: PASS
and
opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods (livetests)$ prove -v live_t/
live_t/00-simple.t .....................
1..2
# Simple tests against the open-ils.storage service and the stock test data.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok
live_t/01-auth.t .......................
1..4
# Simple tests against the open-ils.auth service, memcached, and the stock test data.
# authtime is 7200, authtoken is a3f2d06775fb670284450ad1f1d6ea00
ok 1 - Have an authtoken
ok 2 - Default authtime for staff login is 7200 seconds
ok 3 - Can retrieve authtoken from memcached
ok 4 - Authtoken is removed from memcached after logout
ok
live_t/02-simple_circ.t ................
1..14
# Test circulation of item CONC70000345 against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 310 has barcode CONC70000345
ok 5 - Item with id = 310 has status of Reshelving or Available
# authtime is 7200, authtoken is f7c9ae35165ec74ab5e8ce5b84673da8
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
# authtime is 7200, authtoken is f7c9ae35165ec74ab5e8ce5b84673da8
ok 8 - Have an authtoken associated with the workstation
ok 9 - Checkout request returned a HASH
ok 10 - Checkout returned a SUCCESS event
ok 11 - Item with id = 310 has status of Checked Out after fresh Storage request
ok 12 - Checkin request returned a HASH
ok 13 - Checkin returned a SUCCESS event
ok 14 - Item with id = 310 has status of Reshelving or Available after fresh Storage request
ok
live_t/03-overdue_circ.t ...............
1..20
# Test fine generation on checkin against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 810 has barcode CONC71000345
ok 5 - Item with id = 810 has status of Reshelving or Available
# authtime is 7200, authtoken is 5ab4ae5b9a09c7fd04b4eb0dabf19da5
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
# authtime is 7200, authtoken is 5ab4ae5b9a09c7fd04b4eb0dabf19da5
ok 8 - Have an authtoken associated with the workstation
ok 9 - Checkout request returned a HASH
ok 10 - Checkout returned a SUCCESS event
ok 11 - Checkout response object has payload object
ok 12 - Payload object has circ object
ok 13 - Circ objection has loan duration of "7 days"
ok 14 - Item with id = 810 has status of Checked Out after fresh Storage request
ok 15 - Zero bills associated with circulation
ok 16 - rewrote circ to have happened 20 days ago
ok 17 - Checkin request returned a HASH
ok 18 - Checkin returned a SUCCESS event
ok 19 - Item with id = 810 has status of Reshelving or Available after fresh Storage request
ok 20 - Thirteen bills associated with circulation
ok
live_t/04-overdue_with_closed_dates.t ..
1..22
# Test fine generation with closed date on checkin against the admin user.
ok 1 - open-ils.storage.direct.actor.user.retrieve returned aou object
ok 2 - User with id = 1 is admin user
ok 3 - open-ils.storage.direct.asset.copy.retrieve returned acp object
ok 4 - Item with id = 1310 has barcode CONC72000345
ok 5 - Item with id = 1310 has status of Reshelving or Available
# authtime is 7200, authtoken is dd4b533f677dd5ec6d177312eca2e86b
ok 6 - Have an authtoken
ok 7 - Registered a new workstation
# authtime is 7200, authtoken is dd4b533f677dd5ec6d177312eca2e86b
ok 8 - Have an authtoken associated with the workstation
ok 9 - Created a closed date for 10 days ago
ok 10 - Checkout request returned a HASH
ok 11 - Checkout returned a SUCCESS event
ok 12 - Checkout response object has payload object
ok 13 - Payload object has circ object
ok 14 - Circ objection has loan duration of "7 days"
ok 15 - Item with id = 1310 has status of Checked Out after fresh Storage request
ok 16 - Zero bills associated with circulation
ok 17 - rewrote circ to have happened 20 days ago
ok 18 - Checkin request returned a HASH
ok 19 - Checkin returned a SUCCESS event
ok 20 - Item with id = 1310 has status of Reshelving or Available after fresh Storage request
ok 21 - Twelve bills associated with circulation (instead of 13, thanks to closed date)
ok 22 - Removed closed date
ok
All tests successful.
Files=5, Tests=62, 10 wallclock secs ( 0.06 usr 0.04 sys + 3.29 cusr 0.50 csys = 3.89 CPU)
Result: PASS
Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Garry Collum [Sun, 4 Aug 2013 20:10:26 +0000 (16:10 -0400)]
lp1193487 Circulation Policy Column Picker not saving configuration.
The circulation policy column picker is not saving its configuration
because ui.grid_columns.conify.config.circ_matrix_matchpoint is not
defined in the config.usr_setting_type table. This updates the sql
to populate the table.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Mon, 30 Sep 2013 13:22:26 +0000 (09:22 -0400)]
Capture all alternative titles
With the addition of bib browse, the alternative title index definition
was made to point at the 740 (ind2 != 2), which contains non-analytic
alternative titles /and/ non-filing indicator info. It used to capture
both the 246 and (appropriate) 740's. Allow either to match the XPath.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
OPAC: Make advanced search -> numeric search -> bib cn hone in on right target
The bib call number search under the advanced search page's numeric
search pane was doing the wrong thing. By thinking the search field
desired was called 'bib_cn' where it's actually called 'bibcn', it
generated searches that just fell back to the broader search class
'identifier'. This would often find your matches, but would also find
too many records that *shouldn't* have been matches.
Discovered with help from Erica Rohlfs and Mike Rylander.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remove unnecessary Title Proper (Browse) index from config.metabib_field
As pointed out by Ben Shum and Dan Wells, we don't need this index, and
it made it only into the seed data and not into any upgrade script in
master. It's a relic of bib-and-auth-browse development that ought to
have been removed before the merge to master.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kathy Lussier [Fri, 4 Oct 2013 19:32:56 +0000 (15:32 -0400)]
Move some release notes to core docs
The release notes for Phonelist.pm and floating groups provided some good
documentation, so let's move them to the core docs and leave just the
intro for the release notes.
Dan Wells [Thu, 3 Oct 2013 21:54:03 +0000 (17:54 -0400)]
Relax MFHD subfield 'a' requirement for caption/patterns
If going by the book, every caption/pattern field would have a
subfield 'a', since the data from subfield 'i' would be moved to
'a' if 'a' was empty. Since that is arcane, and our own wizards
used to bend this rule, let's make some minor adjustments to our
expectations:
1) When calculating date progression, don't expect there to be an 'a'
subfield which needs to be "carried" into.
2) When determining whether a field is 'open-ended', check the first
availabile enum/chron subfield rather than hard-coding the check to
'a'.
These changes do not affect the display formatters, so strings
generated from 'a'-less caption/pattern combos are not exactly right,
but they suffice.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1207281: require SSL when downloading offline patron list
This patch builds on the previous one by forcing use of
SSL for downloading the offline patron list. It also
updates the Apache 2.4 example configuration.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Michael Peters [Tue, 24 Sep 2013 20:57:37 +0000 (16:57 -0400)]
LP#1207281 Prevent download of offline patron list without authentication
This patch addresses the vulnerability which allowed a user with the proper
knowledge of the location of offline patron lists to download the file over
regular HTTP without any staff credentials.
This small addition to eg_vhost.conf.in will present users with a login prompt
when trying to access the /standalone/ subdirectory on an Evergreen server.
Users are able to download the patron list in the staff client as normal
because they already have obtained credentials during the normal staff client
authentication process.
Signed-off-by: Michael Peters <mpeters@emeralddata.net> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Stephenson [Wed, 30 Jan 2013 21:56:12 +0000 (16:56 -0500)]
Fix an omission in the log redaction configuration.
open-ils.actor.patron.password_reset.commit was omitted in the
<log_protect> block of opensrf_core.xml.example. This commit adds
it and updates the release notes for 2.3 to include it.
There is also a release notes file informing users that they need to
edit opensrf_core.xml to address this issue.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
projects / Evergreen.git / log