Volume transfer did not honor the cat.bib_keep_on_empty organizational
unit setting when removing empty bib records. This commit changes it
so that tranfer honors the setting in the same manner that deleting
copies and volumes does.
To test this fix, set cat.bib_keep_on_empty for your workstation
org. unit to true, and then transfer all of the volumes from one bib
record to another. The empty bib record should not get deleted.
You can also test with the setting on false to make sure that the
empty bib gets deleted.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Beth Willis <willis@noblenet.org>
Jeff Davis [Fri, 5 Apr 2019 18:08:55 +0000 (11:08 -0700)]
LP#1823387: avoid double slashes in booking URLs, which will not work with recent versions of Apache
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Wed, 24 Apr 2019 13:19:40 +0000 (09:19 -0400)]
LP1642036 Group member detail grid query repair
Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Boyer [Thu, 28 Jun 2018 18:36:27 +0000 (14:36 -0400)]
LP1778940: Add Indexes to ate.*_output
When there are many rows in action_trigger.event_output
simply ensuring referencial integrity can take an
unacceptably long time as Postgres has to make sure
that the output being deleted isn't referenced in
any of these 3 fields. Adding these indexes keeps
these checks always fast.
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc
Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Fri, 22 Mar 2019 20:41:12 +0000 (13:41 -0700)]
LP1821409 Ang admin editor clears fields on new
The Angular admin pages re-use an FmEditor component for creating and
updating objects. When creating a new object after editing an existing
object, reset the editor so it won't load the previously edited object.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Wed, 23 Jan 2019 22:30:26 +0000 (17:30 -0500)]
LP1807461 Admin page avoid errors on dialog dismissal
Add support to the base DialogComponent class for passing information to
the caller via the reject handler about whether a dialog was dismissed
via user interface interaction (body click, esc key, cross click, cancel
button) or for some other reason, presumably an error.
Teach the generic admin page to avoid toasting errors when an edit or
create dialog is dismissed via UI.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Adds a new "Edit Selected" action to the "Actions for Selected Items"
menu in the general purpose admin grid. This only visibly affects the
ACQ admin grids at time of writing, but applies to all auto-generated
admin grids.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Wed, 20 Mar 2019 15:57:02 +0000 (11:57 -0400)]
Docs: Add bugfix release notes for 3.2.5
For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.2.5. I'm not sure what the criteria were
for pervious point release notes.
Remington Steed [Wed, 20 Mar 2019 16:16:54 +0000 (12:16 -0400)]
Docs: Add bugfix release notes for 3.1.11
For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.1.11. Not sure if this is the same as past
point release notes.
Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order
- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org>
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.
We add the call number prefix and suffix as separate columns to the
holds pull list print template. We also add the suffix to the end of
the orderBy so that we also sort by the suffix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: John Amundson <jamundson@cwmars.org>
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container
Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen. A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines
The below message repeats in the open-ils.storage_stderr.log:
Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.
This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.
Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected
If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers
Provide call numbers extracted from the MARC record as options in the
volume batch editor. Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.
Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Thu, 17 Jan 2019 18:33:10 +0000 (13:33 -0500)]
LP1798628: Copy alert counts in Holdings
Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Remington Steed [Thu, 25 Oct 2018 12:53:32 +0000 (08:53 -0400)]
LP#1778571 Fix logic error converting JS bool to DB bool
Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.
To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
still checked. (That's bug #2.)
To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
- At step 5, the new note correctly has the "Public Note" checkbox
checked.
- At step 11, the edited note correctly has the "Public Note" checkbox
unchecked.
NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement
Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data. The key benefit is that subfields retain their order
in affected MARC fields. As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached
This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update
Previously, if a volume label was edited, all items attached to that
volume would be essentially affected. Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched. If no copies are
being edited along with a volume, then the volume itself is edited.
Auto-merging of volumes may still happen in all of these scenarios.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)
Galen Charlton [Wed, 23 Jan 2019 15:52:24 +0000 (10:52 -0500)]
LP#1812389: make Group Penalty Threshold admin page accessible again
As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.
To test
-------
[1] From Administration | Local Administration, go to Group Penalty
Thresholds. Note that the embedded Conify admin interface
is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
should appear.
[3] Verify that the Permission Group Tree Entries interface remains
accessible from Local Administration.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status
The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jane Sandberg [Sat, 2 Mar 2019 01:03:31 +0000 (17:03 -0800)]
LP1721109: Update item status when holdings are edited
To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time. Note that
there is a new status column, and that an icon appears for
all the rows that you have changed. Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).
Bill Erickson [Tue, 29 Jan 2019 16:15:38 +0000 (11:15 -0500)]
LP1813647 Angular page title component & sandbox example
Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.
Each title may have a prefix and/or a suffix. If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Sam Link [Wed, 12 Dec 2018 16:35:20 +0000 (11:35 -0500)]
LP1802594 - Splash Page Image Alt Text
Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.
Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Sat, 6 Oct 2018 12:52:09 +0000 (05:52 -0700)]
LP1796225: Only auto-focus search on the home page
For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.
To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages. Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages. Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog. Notice that the
cursor still leaps to the search bar on this page only.
Jason Boyer [Mon, 3 Dec 2018 18:23:39 +0000 (13:23 -0500)]
LP1799963: Adjust fix to Staff Default Adv Search
By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels
This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID. As a consequence, the
following fields are now available for label templates:
If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.
To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
or more of the new fields listed above; verify that the current
value is displayed on the label preview.
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view
To test:
[1] Locate or create a bibliographic record that has at least
one located URI (e.g., an 856 with a $9 containing an org
unit code)
[2] View the record in the Holdings View in the web staff interface,
with the 'Show empty call numbers' (or volumes) option
selected.
[3] Note that rows are displayed with a call number label of '##URI##';
these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
should not display.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Signed-off-by: James Fournie <jfournie@vcc.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values. This commit changes it to
a more generic if() test to cover null/undefined. Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.
Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.
Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 14 Dec 2018 04:50:15 +0000 (20:50 -0800)]
LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2
To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2. Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying
This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.
Two paths to test:
Path A)
1. Import a new bib record from z3950, but via "Edit then Import"
2. Bring up marc editor and choose save w/ bib source.
3. Verify chosen bib source saved correctly on record page.
Path B)
1. Mark a record as target for Overlay, go to z3950 import.
2. Make a search, select item for Overlay.
3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
4. Verify chosen bib source saved correctly on record page.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 7 Dec 2018 00:42:49 +0000 (16:42 -0800)]
LP1805856: Open records in new tabs
Catalogers have given the feedback that it's very helpful to have
certain records open in a new tab after they perform certain tasks.
This commit opens the relevant records in a new tab in the following
circumstances:
1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
existing tab)
2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
overlaid record at all)
3) Cataloging > Record Buckets > Merge (previously opened the lead
record in the existing tab)
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>