Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order
- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org>
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.
We add the call number prefix and suffix as separate columns to the
holds pull list print template. We also add the suffix to the end of
the orderBy so that we also sort by the suffix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: John Amundson <jamundson@cwmars.org>
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container
Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen. A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines
The below message repeats in the open-ils.storage_stderr.log:
Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.
This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.
Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected
If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers
Provide call numbers extracted from the MARC record as options in the
volume batch editor. Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.
Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Thu, 17 Jan 2019 18:33:10 +0000 (13:33 -0500)]
LP1798628: Copy alert counts in Holdings
Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Remington Steed [Thu, 25 Oct 2018 12:53:32 +0000 (08:53 -0400)]
LP#1778571 Fix logic error converting JS bool to DB bool
Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.
To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
still checked. (That's bug #2.)
To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
- At step 5, the new note correctly has the "Public Note" checkbox
checked.
- At step 11, the edited note correctly has the "Public Note" checkbox
unchecked.
NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement
Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data. The key benefit is that subfields retain their order
in affected MARC fields. As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached
This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update
Previously, if a volume label was edited, all items attached to that
volume would be essentially affected. Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched. If no copies are
being edited along with a volume, then the volume itself is edited.
Auto-merging of volumes may still happen in all of these scenarios.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)
Bill Erickson [Mon, 4 Mar 2019 19:06:59 +0000 (14:06 -0500)]
LP1716473 Copy editor hide disabled defaults
Disabling a field in the copy editor "Defaults" tab now hides the field
instead of simply disabling it. Once a field is hidden, subsequent
field shift left to fill the space.
The "Working Items" grid is shifted to the bottom of the page, below the
attributes editor. This allows the attributes to fill the horizontal
space and puts the working items and save operations visually at the end
of the page, i.e. at end of the work flow.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Geoff Sams <gsams@roanoketexas.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Galen Charlton [Wed, 23 Jan 2019 15:52:24 +0000 (10:52 -0500)]
LP#1812389: make Group Penalty Threshold admin page accessible again
As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.
To test
-------
[1] From Administration | Local Administration, go to Group Penalty
Thresholds. Note that the embedded Conify admin interface
is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
should appear.
[3] Verify that the Permission Group Tree Entries interface remains
accessible from Local Administration.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status
The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jane Sandberg [Sat, 2 Mar 2019 01:03:31 +0000 (17:03 -0800)]
LP1721109: Update item status when holdings are edited
To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time. Note that
there is a new status column, and that an icon appears for
all the rows that you have changed. Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).
Bill Erickson [Thu, 21 Feb 2019 18:12:52 +0000 (13:12 -0500)]
LP1806087 Ang catalog pending tabs offer manual redirect
Instead of sending users to the AngJS versions of not-yet-implemented
tabs from the Angular catalog, show a message indicating the tab is not
yet implemented and offer a link to open the requested record tab in a
new browser tab. This better clarifies what is happening and helps to
avoid situations where the back-button is confusingly hijacked via
intermediate redirect.
We now also open the "View" link for copies in a new tab as well for
consistency with the modified "Edit" link.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Thu, 28 Feb 2019 20:44:46 +0000 (15:44 -0500)]
First pass at 3.3 release notes
Ran create_release_notes.sh, cleaned up the output a bit, and removed
the separate files. Still TODO are acknowledgments and combing out
any upgrade notes.
- Replace two instances of 'cleanse_ISO8601' with 'clean_ISO8601', as
the former does not exist (at least in these contexts)
- Delay converting DateTimes to strings until necessary (which allows us
to compare the original DateTime objects instead of having to recreate
them from strings)
- Increase comments
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Adam Bowling [Wed, 13 Feb 2019 04:15:08 +0000 (23:15 -0500)]
LP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud objects
in previous submission and adds CSS to item label template.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Adam Bowling [Thu, 10 Jan 2019 07:05:50 +0000 (02:05 -0500)]
LP#1787479: Adds customization for multipage print label printing and fixes the issue
with saving templates after the change to DB saving from local storage.
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Based on cataloger feedback, we 1) Moved the Label Set Configuration higher
grouped with the spine and spine/pocket options because all of these options
are related 2) Moved the starting label option higher because this is the
one setting that will probably be adjusted on each use of the interface and
3) Made the Gap Between Columns setting label conditional on whether the
user us printing to a sheet with label sets or not.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kathy Lussier [Wed, 14 Nov 2018 17:49:16 +0000 (12:49 -0500)]
LP#1787479: Make the display of some fields conditional on the Print Feed Option
Ideally, we would remove the entire Page Settings section for those who are
printing to a continuous feed printer, but it carries the risk of users
not being able to see a field with a value that is affecting the layout. However, there are several fields within that section that don't affect the
continuous feed layout and can be hidden in continuous feed mode. I also
adjusted one help tip to display different information for continuous and
sheet feed printing.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
As previously discussed on the cataloging list and the LP bug, the previous
label names of 'left' and 'right' no longer make sense since staff can
control the placement of these labels. However, label 1 and label 2 are too
generic. We therefore are going back to spine and pocket labels.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Moved most of the CSS to cat.css.tt2; removed most borders since they aren't
needed as much without the full settings descriptions on the page; added some
more help text and removed Windows carriage returns.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2
Remington Steed [Wed, 20 Feb 2019 22:08:38 +0000 (17:08 -0500)]
LP1797934: Simplify header labels
Since the patron is already on the "Reservations" tab in their account,
it seems unnecessary to use the word "Reservations" in the header
labels. Also, simpler labels will make translations easier, since "Start
time" and "End time" are already used in other Bookings interfaces.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kyle Huckins [Thu, 7 Feb 2019 19:54:56 +0000 (19:54 +0000)]
lp1806087 Place Holds Improvements
- Disable SMS Carriers dropdown if Notify by SMS unchecked.
- Move Search for patron button to same level as "Place Hold (name)" text.
- Add Search icon to "Search for Patron" button
- Add "Submit" button to Barcode input for improved UX.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Thu, 10 Jan 2019 17:11:41 +0000 (12:11 -0500)]
LP1806087 Org setting to enable experimental staff catalog
Adds a new org unit setting "GUI: Enable Experimental Angular Staff
Catalog" (ui.staff.angular_catalog.enabled). When set to true, a new
navbar menu item will appear in both the Angular and AngJS client menus
for "Staff Catalog (Experimental)". This action directs the user to the
Angular staff catalog.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Wed, 7 Nov 2018 15:18:31 +0000 (10:18 -0500)]
LP1806087 Angular staff catalog phase II.
* Record detail tabs redirect to AngJS catalog where needed.
* Initial holds placement UI.
* Record baskets, actions, and UI.
* Ported MonographParts tab to Angular
* Set default catalog tab
* Browse
* MARC search
* Identifier search
* pub date filter
* Record detail 'View in Catalog' button
* Group formats and editions
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 29 Jan 2019 16:15:38 +0000 (11:15 -0500)]
LP1813647 Angular page title component & sandbox example
Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.
Each title may have a prefix and/or a suffix. If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.
Bill Erickson [Mon, 7 Jan 2019 21:35:15 +0000 (16:35 -0500)]
LP1779158 Always clear import selection
Clear the import selection (e.g. Queue => Import All Items) from the
import UI when the user navigates away, regardless of whether the import
succeeded. Otherwise, the import UI gets stuck in selection mode
requiring the user to manually clear it.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
* Fix some workstation setting names that were missing the 'eg.grid.*'
prefix
* Add workstation setting types for merge profile and attr definition
admin pages.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 4 Jan 2019 16:07:31 +0000 (11:07 -0500)]
LP1779158 Cache new queues / display active queues
* Only list active (non-complete) queues in the Vandelay queue selector
combobox.
* Display an alert message when the user attempts to create a queue
whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
to maintain 2 separate queue caches.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 4 Jan 2019 16:05:17 +0000 (11:05 -0500)]
LP1779158 Angular alert dialog component
Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kyle Huckins [Tue, 18 Dec 2018 22:57:21 +0000 (22:57 +0000)]
lp1779158 Inspect Queue Improvements
- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kyle Huckins [Tue, 27 Nov 2018 21:07:35 +0000 (21:07 +0000)]
lp1779158 Vandelay Authority Import Tweaks
- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified: Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Support saving MARC Import form values as named templates. Values are
stored as (by defualt) workstation settings. A template may be selected
as the default and templates may be deleted.
Includes release notes update angular vandelay.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Port of the MARC Import/Export UI from a Dojo-driven interface to a
Angular(6) interface.
Includes an additional UI called "Recent Imports" which displays
Vandelay session tracker information for both active sessions and those
within the selected time frame. Active sessions are updated regularly
to display progress to the user.
Includes grid persist key workstation settings.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
projects / Evergreen.git / log