Evergreen.git
34 hours agoLP#1887852 Pending patron passwords aren't initially set to phone # master
Dan Briem [Fri, 17 Jul 2020 20:09:54 +0000 (16:09 -0400)]
LP#1887852 Pending patron passwords aren't initially set to phone #

If a patron self registers with a phone # and the org unit
setting to use the phone for the password is true, when the
pending patron stage loads the password is initially random
instead of the last 4 digits of the phone #.

This branch sets the password to the last 4 digits of the phone
when the patron stage loads if the phone is set and the org
unit setting to use the phone # for the password is true.

To test:
1. Set org unit settings for allow patron self-registration and
   show day_phone on registration to true
2. Go to the OPAC and request a library card (include phone #)
3. Login to the staff client, Circulation->Pending Patrons and
   load the patron
4. Note the password is random
5. Load patch and repeat steps 3-4
6. Note the password is the last 4 digits of the phone #

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Stephenson <jason@sigio.com>
36 hours agoLP#1398107: Add i18n attribute to alert text
Chris Sharp [Tue, 27 Oct 2020 19:52:09 +0000 (15:52 -0400)]
LP#1398107: Add i18n attribute to alert text

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
36 hours agoLP#1398107: Add header to generic alerts.
Chris Sharp [Tue, 27 Oct 2020 13:40:18 +0000 (09:40 -0400)]
LP#1398107: Add header to generic alerts.

Currently, generic alerts/events passed up from the Perl
layer are presented in an unadorned modal that just begins
with "Reason(s) include" without further context.  This
adds a "Could not Complete the Action" header with the
idea that something is better than nothing.  At this point,
i18n is not considered.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
36 hours agoLP#1398107: Alert when autodeleting a title with holds on it.
Chris Sharp [Wed, 11 Mar 2020 23:33:15 +0000 (19:33 -0400)]
LP#1398107: Alert when autodeleting a title with holds on it.

Add a new "TITLE_HAS_HOLDS" event that we pass up to the user
if any non-canceled, unfulfilled title hold targets a bib that
would otherwise be silently deleted with holds canceled.

Also, retarget any holds pointing to a bib that is automatically
deleted after removing its volumes/copies to the destination bib
if this is the last copy.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 days agoCorrect asciidoc issues
Jason Boyer [Wed, 25 Nov 2020 15:32:46 +0000 (10:32 -0500)]
Correct asciidoc issues

The values for col need to be quoted and the [#..] anchor style
needs to be used in this fashion: [#..]#some phrase# while a simple
anchor is just [[..]].

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
13 days agoDocs: fix typo in 3.6 release notes
Jane Sandberg [Wed, 18 Nov 2020 17:38:32 +0000 (09:38 -0800)]
Docs: fix typo in 3.6 release notes

Thanks to Elizabeth Thomsen for catching this error.

13 days agoDocs: release notes for 3.6.1
Jane Sandberg [Wed, 18 Nov 2020 17:23:12 +0000 (09:23 -0800)]
Docs: release notes for 3.6.1

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 days agoDocs: release notes for 3.5.2
Jane Sandberg [Wed, 18 Nov 2020 17:14:49 +0000 (09:14 -0800)]
Docs: release notes for 3.5.2

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
13 days agoDocs: release notes for 3.4.5
Jane Sandberg [Wed, 18 Nov 2020 17:11:41 +0000 (09:11 -0800)]
Docs: release notes for 3.4.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 weeks agoLP1904220: Fix Booking Service Check
Jason Boyer [Fri, 13 Nov 2020 16:12:22 +0000 (11:12 -0500)]
LP1904220: Fix Booking Service Check

Instead of trying to tell AppService which router we want to talk
to and confusing it, just tell it we want to talk to a router and
let it do its thing.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 weeks agoLP#1900184 Patron password use phone not working
Dan Briem [Fri, 30 Oct 2020 17:06:59 +0000 (13:06 -0400)]
LP#1900184 Patron password use phone not working

An early return statement in extract_hold_notify() was removed
in 7e92293 and added back in ddf5b4b3, so props set at the end
of that function used in future comparisons never get set.

This re-removes the return statement and sets the local notify
variable to default string values so the rest of the function
can play out.

To test:
1. Set org unit setting: "Patron: password from phone #" to TRUE
   at the top context location
2. Circulation->Register Patron
3. Type 123-456-7890 into the Daytime Phone field and press tab
4. Note: the password field isn't updated to the last 4 digits
5. Apply patch and repeat steps
6. Note: the password field updates to the last 4 digits

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
3 weeks agoDocs: LP1826256 Change 'catalogue' to 'catalog'
Katie Greenleaf Martin [Mon, 26 Oct 2020 20:39:57 +0000 (16:39 -0400)]
Docs: LP1826256 Change 'catalogue' to 'catalog'

Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 weeks agoLP#1508208: live_t/ test for this branch
Jason Etheridge [Fri, 15 May 2020 18:37:13 +0000 (14:37 -0400)]
LP#1508208: live_t/ test for this branch

Includes timing information for the checkin, but pass/fail is not predicated on it.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 weeks agoLP#1508208: Only look at holds that age protection allows
Mike Rylander [Tue, 10 Dec 2019 22:17:38 +0000 (17:17 -0500)]
LP#1508208: Only look at holds that age protection allows

When hold capture is attempted, we look at (currently) the first 100
holds ordered by Best Hold Sort Selection Order.  If a very long list
of holds are targetting an age-protected item then op capture may not
have a chance to see a viable hold for that copy.

This commit attempts to take into account the age protection currently
set for the copy by restricting the holds to just those where the
hold-copy-map proximity is less than or equal to the maximum proximity
allowed by the age protection.  This works now because we store the
hold proximity in the hold copy map, where we did not before.

Being based on the hold-copy-map proximity, which is calculated
proximity, means this is an approximation and the final hold capture
logic may still reject some holds for the copy.  Likewise, this does
not entirely eliminate the possibility that there may be a better hold
to capture the copy for if the in-range set of holds is very, very
long, but this should allow hold capture to proceed if even
imperfectly.

If no age protection is set for the copy, the current behavior
(looking at all holds) is maintained.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 weeks agoLP#1325704: stamping upgrade script
Chris Sharp [Wed, 28 Oct 2020 19:57:42 +0000 (15:57 -0400)]
LP#1325704: stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 weeks agoLP#1325704: Update Items-Out YAOUS descrip for web client
Remington Steed [Tue, 15 May 2018 13:46:41 +0000 (09:46 -0400)]
LP#1325704: Update Items-Out YAOUS descrip for web client

Three settings refer to the "top" and "bottom" lists on the XUL client
Items Out screen. With the web client, these have become three named
tabs. This commit updates the setting descriptions in the seed data so
they reflect the new design. I also attempted to make the meaning of the
values more clear by labeling the two subsettings as "A" and "B".

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 weeks agoLP#1879790: Give carousels their own context org
Mike Rylander [Thu, 22 Oct 2020 20:32:54 +0000 (16:32 -0400)]
LP#1879790: Give carousels their own context org

Before this commit, the context org unit for carousels was the same as
the physical_loc environment variable, or the client-passed physcial
location, or the search location, whichever was set in that order.  This
commit provides the ability to specify a carousel_loc environment
variable in the apache vhost configuration, as an override to
physical_loc.  This, in turn, allows hostname-segregated branches of the
org hierarchy in a resource sharing group to specify their own carousels
even when they want the top of the group to be the default search
location.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 weeks agoDocs: adding information about 3.6 features from the release notes
Jane Sandberg [Mon, 26 Oct 2020 16:24:10 +0000 (09:24 -0700)]
Docs: adding information about 3.6 features from the release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 weeks agoLP1901038 Repair Angular catalog journal title search
Bill Erickson [Thu, 22 Oct 2020 15:10:17 +0000 (11:10 -0400)]
LP1901038 Repair Angular catalog journal title search

Completes the Journal Title search implementation in the Angular staff
catalog.

To test in concerto, search Journal Title => IEEE.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 weeks agoLP1855737 Don't send error object across shared worker port
Bill Erickson [Mon, 9 Dec 2019 16:47:30 +0000 (11:47 -0500)]
LP1855737 Don't send error object across shared worker port

Data must be string-ifiable to pass across a shared web worker message
port.  In Firefox, at least, errors encountered during IndexedDB /
Lovefield operations are not candidates for automatic stringification.
Avoid trying to send the error object back to the caller.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 weeks agoLP#1893463: Protect against null emails
Mike Rylander [Mon, 12 Oct 2020 19:51:29 +0000 (15:51 -0400)]
LP#1893463: Protect against null emails

Unique indexes on nullable columns will allow multiple conceptually
unique rows if the nullable columns are, in fact, NULL because NULL does
not equal itself.  This commit uses COALESCE to make sure that the
nullable email column in the reporter.schedule table gets a value of the
empty string for the purposes of the unique index.  The upgrade script
now also takes this into account and ignores the email column.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 weeks agoLP#1713138 EDI buyer codes from RFF+API
Bill Erickson [Fri, 25 Aug 2017 19:46:31 +0000 (15:46 -0400)]
LP#1713138 EDI buyer codes from RFF+API

Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field.  This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.

The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 weeks agoLP1882828: (follow-up) Add static parameter to ViewChild decorator
Jason Boyer [Wed, 14 Oct 2020 16:11:27 +0000 (12:11 -0400)]
LP1882828: (follow-up) Add static parameter to ViewChild decorator

While not strictly required in rel_3_6 and above, rel_3_5 uses
a version of Angular that requires specifying a value for the
static parameter when using the ViewChild decorator on an object.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
7 weeks agostamp version-upgrade script for 3.6.0
Galen Charlton [Tue, 13 Oct 2020 21:28:03 +0000 (17:28 -0400)]
stamp version-upgrade script for 3.6.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agostamp release notes for 3.6.0
Galen Charlton [Tue, 13 Oct 2020 21:27:13 +0000 (17:27 -0400)]
stamp release notes for 3.6.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP1893463: Follow-up to address de-duplication and adding release notes.
Chris Sharp [Wed, 7 Oct 2020 19:38:34 +0000 (15:38 -0400)]
LP1893463: Follow-up to address de-duplication and adding release notes.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 weeks agoLP1893463: stamp upgrade script
Chris Sharp [Wed, 7 Oct 2020 18:54:41 +0000 (14:54 -0400)]
LP1893463: stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 weeks agoLP1893463: Prevent duplicated report outputs
Jason Boyer [Fri, 28 Aug 2020 21:13:14 +0000 (17:13 -0400)]
LP1893463: Prevent duplicated report outputs

When re-running recurring reports that are interrupted,
it's possible to end up with a duplicate copy of the next
recurrance of that report. This branch adds a unique index
to reporter.schedule and tells clark-kent.pl not to worry
about it.

For the purposes of this change a duplicate report is
one where report.schedule has identical values for report,
(output) folder, runner, run_time, and email.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 weeks agoupdate Czech translation for Angular staff client
Galen Charlton [Wed, 7 Oct 2020 15:42:47 +0000 (11:42 -0400)]
update Czech translation for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoTranslation updates - newpot
Galen Charlton [Wed, 7 Oct 2020 15:38:57 +0000 (11:38 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agomove 3.6-beta2 update to 3.6-rc
Galen Charlton [Wed, 7 Oct 2020 15:37:22 +0000 (11:37 -0400)]
move 3.6-beta2 update to 3.6-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agostamp release notes for 3.6-beta2
Galen Charlton [Wed, 7 Oct 2020 15:36:32 +0000 (11:36 -0400)]
stamp release notes for 3.6-beta2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1895398: (follow-up) show outline when the login link has focus
Galen Charlton [Wed, 7 Oct 2020 15:24:24 +0000 (15:24 +0000)]
LP#1895398: (follow-up) show outline when the login link has focus

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP1895398 Bootstrap OPAC Follow Up #2
Chris Burton [Fri, 25 Sep 2020 12:10:42 +0000 (08:10 -0400)]
LP1895398 Bootstrap OPAC Follow Up #2

1) Fix some whitespace issues
2) Move CSS for language pickuper to style.css.tt2

Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP1895398 Bootstrap OPAC Follow Up #1
Chris Burton [Fri, 25 Sep 2020 11:59:47 +0000 (07:59 -0400)]
LP1895398 Bootstrap OPAC Follow Up #1

Includes following changes:

1) Login modal Aria-labelledby removed. The modal doesn’t have a label.
2) Due to a slight change in versioning, an issue occurred where another
attribute had to be added.
3) Added Buttons back to the middle.
4) Fixed button clicking issues on results and summary.
5) Print and email separated (Still needs
https://bugs.launchpad.net/evergreen/+bug/1895676 resolved)
6) Tabindex removed and now the cart navigation can be controlled by
keyboard
7) Data Toggle added to disabled elements on staff OPAC
8) Not sure what details are missing in the "More Details" section. I
did some old/new comparisons with the OPAC and some of the default books
found in the search and their information was matching up)
9)Tooltips changed to allow keyboard navigation and popups
10) Name was missing from the buttons, so it wasn’t passing actions
properly.
11) Move Language to footer as links. This will make it widely
accessible and noticable. Having a dropdown was not appealing and
removing the submit button would cause it to not be acceptable. I think
they call it a "jump box" because as soon as you make the selection it
redirects you, giving no chance to change it. It's not expected
behaviour from a dropdown.

Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
8 weeks agodocs: release notes: adding EOLI to the list of commissioning entities
Galen Charlton [Mon, 5 Oct 2020 21:55:01 +0000 (17:55 -0400)]
docs: release notes: adding EOLI to the list of commissioning entities

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
8 weeks agodocs: corrections to the 3.6 release notes
Lisa Carlucci [Mon, 5 Oct 2020 21:51:46 +0000 (17:51 -0400)]
docs: corrections to the 3.6 release notes

Signed-off-by: Lisa Carlucci <lisa@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
8 weeks agoupdate target branches for Antora
Galen Charlton [Fri, 2 Oct 2020 21:21:25 +0000 (17:21 -0400)]
update target branches for Antora

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1774008 Remove Hatch storage options
Bill Erickson [Wed, 5 Aug 2020 18:19:52 +0000 (14:19 -0400)]
LP1774008 Remove Hatch storage options

Remove option to store settings in Hatch from the AngJS Hatch admin
page.  Update some Hatch labels to remove the term 'Storage'.  Remove
deprecated JS code related to tracking this setting and the
long-deprecated offline file storage setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoTranslation updates - newpot
Galen Charlton [Wed, 30 Sep 2020 19:10:03 +0000 (15:10 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agomove 3.6-beta1 schema update to 3.6-beta2
Galen Charlton [Wed, 30 Sep 2020 19:08:04 +0000 (15:08 -0400)]
move 3.6-beta1 schema update to 3.6-beta2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agostamp 3.6-beta2 release notes
Galen Charlton [Wed, 30 Sep 2020 19:07:09 +0000 (15:07 -0400)]
stamp 3.6-beta2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoclean up RELEASE_NOTES_NEXT upon branching of rel_3_6
Galen Charlton [Wed, 30 Sep 2020 19:05:25 +0000 (15:05 -0400)]
clean up RELEASE_NOTES_NEXT upon branching of rel_3_6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1896070: ensure that deatching course material doesn't delete non-temporary bibs
Galen Charlton [Thu, 17 Sep 2020 14:44:01 +0000 (10:44 -0400)]
LP#1896070: ensure that deatching course material doesn't delete non-temporary bibs

This patch fixes how the temporary_record field is checked; in Perl code,
non-NULL Boolean fields in Fieldmapper objects do /not/ evaluate as
Perl Boolean values; you have to use $U->is_true() or explictly
compare against 't' and 'f'.

This patch also tweaks live_t/31-courses.t so that it can be run
repeatedly.

To test
-------
[1] Run live_t/31-courses.t repeatedly; note that it will start failing
    the second time.
[2] Reset the database and apply the patch, then repeat step 1.
[3] This time, the test should work when run repeatedly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
2 months agodocs: Curbside Pickup documentation
Angela Kilsdonk [Tue, 29 Sep 2020 21:01:45 +0000 (17:01 -0400)]
docs: Curbside Pickup documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: OPAC Email Print documentation
Angela Kilsdonk [Tue, 29 Sep 2020 20:57:23 +0000 (16:57 -0400)]
docs: OPAC Email Print documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: Acquisitions Providers documentation
Angela Kilsdonk [Tue, 29 Sep 2020 20:47:32 +0000 (16:47 -0400)]
docs: Acquisitions Providers documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: adding new image files for Hopeless Holds
Andrea Buntz Neiman [Tue, 29 Sep 2020 20:38:58 +0000 (16:38 -0400)]
docs: adding new image files for Hopeless Holds

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: updates to holds documentation
Felicia Beaudry [Tue, 29 Sep 2020 20:02:26 +0000 (16:02 -0400)]
docs: updates to holds documentation

Signed-off-by: Felicia Beaudry <felicia.beaudry@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: Angular Acq Sprint 0 Tools and Infrastructure
Andrea Buntz Neiman [Tue, 29 Sep 2020 19:53:39 +0000 (15:53 -0400)]
docs: Angular Acq Sprint 0 Tools and Infrastructure

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: Acquisitions Search documentation
Angela Kilsdonk [Tue, 29 Sep 2020 19:27:01 +0000 (15:27 -0400)]
docs: Acquisitions Search documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: updates to Best Hold Sort Selection Order
Andrea Buntz Neiman [Tue, 29 Sep 2020 19:22:24 +0000 (15:22 -0400)]
docs: updates to Best Hold Sort Selection Order

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: adding credit card payment info
Andrea Buntz Neiman [Tue, 29 Sep 2020 19:17:49 +0000 (15:17 -0400)]
docs: adding credit card payment info

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1849212: (follow-up) Don't use group ids in upgrade scripts
Jason Boyer [Tue, 29 Sep 2020 14:32:48 +0000 (10:32 -0400)]
LP1849212: (follow-up) Don't use group ids in upgrade scripts

Previously if there was not a permission group with an id of 9
this upgrade script would fail. Changing the consatruction to
match the seed data allows the insert to benignly do nothing if
the group is missing. Also, the permission is made grantable.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoDocs: more 3.6 release notes updates
Andrea Buntz Neiman [Fri, 25 Sep 2020 19:27:01 +0000 (15:27 -0400)]
Docs: more 3.6 release notes updates

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
2 months agoDocs: 3.6 release notes update
Andrea Buntz Neiman [Fri, 25 Sep 2020 18:44:09 +0000 (14:44 -0400)]
Docs: 3.6 release notes update

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
2 months agoLP1851882 Relase Notes (Angular catalog hold types)
Bill Erickson [Fri, 8 Nov 2019 22:09:03 +0000 (17:09 -0500)]
LP1851882 Relase Notes (Angular catalog hold types)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP1851882 Angular catalog recall/force/part holds
Bill Erickson [Fri, 8 Nov 2019 22:02:48 +0000 (17:02 -0500)]
LP1851882 Angular catalog recall/force/part holds

Adds entry points for placing Recall, Force, and Part-level holds.

For any item-level hold type, the user now has the option to cycle
between Item, Recall, and Force hold types.  The selected type affects
the full batch of holds.

For title-level holds, the user now has the option to select a part as
the hold target for each hold in the list.  Part selection is optional.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoaccount for race condition in courses live test
Chris Sharp [Thu, 24 Sep 2020 23:46:51 +0000 (19:46 -0400)]
account for race condition in  courses live test

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP1872867 Staff catalog filters use search labels
Bill Erickson [Thu, 30 Jul 2020 16:23:15 +0000 (12:23 -0400)]
LP1872867 Staff catalog filters use search labels

The Angular staff catalog now displays the search_label value for all of
the coded-value-map filters (search format, item type, etc.) when
available.  It falls back to the 'value' field when no search_label exists.

If a value is not opac_visible, the text "(Hidden)" is appended to the
label.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
2 months agoLP#1096209: Stamp upgrade script
Chris Sharp [Thu, 24 Sep 2020 17:41:20 +0000 (13:41 -0400)]
LP#1096209: Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP#1096209: add check_sms_notify parameter to all relevant event defs
Jeff Davis [Thu, 28 May 2020 16:17:11 +0000 (09:17 -0700)]
LP#1096209: add check_sms_notify parameter to all relevant event defs

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP#1776954 - Add release notes
Chris Sharp [Thu, 24 Sep 2020 17:18:39 +0000 (13:18 -0400)]
LP#1776954 - Add release notes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP#1776954 Avoid empty string for tcn_source
Dan Scott [Thu, 14 Jun 2018 17:59:42 +0000 (13:59 -0400)]
LP#1776954 Avoid empty string for tcn_source

The tcn_source for some records is an empty string, instead of the database
default of 'AUTOGEN', because the Perl record import code avoids a Perl warning
in the logger info call by setting the value to an empty string if it can't
find any other source (e.g. OCLC number). Unfortunately, the empty string then
gets passed to the database, meaning that it satisfies the non-NULL constraint
and does not invoke the default value of 'AUTOGEN'.

The resulting MARCXML then contains an empty, self-closing 901 $b subfield
(<subfield code="b"/>) that causes an error for some other applications, such
as Zotero, which do not anticipate empty subfields.

The simple fix applied here is to follow the example for $source and $tcn of
not setting the value of the tcn_source field in the bib record object if the
corresponding variable evaluates to false (such as if it's an empty string).

To test: create a basic record in the MARC editor that includes minimal fields
(for example, a 100 and 245) so that it has no TCN source to extract. Check the
MARCXML served up by SuperCat ("curl
http://<hostname>/opac/extras/supercat/retrieve/marcxml-uris/record/<bib-id>").
Before this patch, it will have a self-closing 901 $b subfield. After applying
this patch and creating a new test record, the new test record will have a
901$b subfield with the value 'AUTOGEN'.

A site that has been running without this patch for a long time might want to
check how many bib records they have with an empty tcn_source:

SELECT COUNT(*) FROM biblio.record_entry WHERE deleted IS FALSE AND tcn_source = '';

Sites can fix the problem by issuing UPDATE statements to set the 901$b to a value
like 'AUTOGEN' or 'Unknown'. They should probably do it per-record, however, to
avoid locking the table in a huge commit.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP1882828: Fix issues with displaying cataloged resources in Pull List
Jane Sandberg [Wed, 19 Aug 2020 23:22:43 +0000 (16:22 -0700)]
LP1882828: Fix issues with displaying cataloged resources in Pull List

I had mistakenly used switchMap, when I should have used mergeMap. This
led to erroneously canceled subscriptions, leaving rows out of the pull
list.

This commit also uses getRows, rather than manually setting the
GridDataSource's data.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1882825: (follow-up) include update number
Galen Charlton [Thu, 24 Sep 2020 15:59:02 +0000 (11:59 -0400)]
LP#1882825: (follow-up) include update number

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1835127: (follow-up) fixes to update script
Galen Charlton [Thu, 24 Sep 2020 15:58:08 +0000 (11:58 -0400)]
LP#1835127: (follow-up) fixes to update script

- include the version number stamp
- adjust the permission IDs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoRepair Permission Seed Data
Jason Boyer [Thu, 24 Sep 2020 12:03:33 +0000 (08:03 -0400)]
Repair Permission Seed Data

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoLP1882825 - Stamp upgrade script
Chris Sharp [Wed, 23 Sep 2020 20:47:33 +0000 (16:47 -0400)]
LP1882825 - Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP1882825: Add setting for booking pull list grid
Jane Sandberg [Tue, 9 Jun 2020 20:51:24 +0000 (13:51 -0700)]
LP1882825: Add setting for booking pull list grid

Steps to test:
[1] Go to the Booking Pull List.
[2] Change the grid around and try to save.
[3] Note in your browser console an error message: "Error saving columns: No user or workstation setting type exists for eg.grid.booking.pull_list"
[4] Run the database migration included in this commit.
[5] Repeat steps 1-2.
[6] Note that no error message appears.
[7] Try exiting Evergreen and coming back (using the same workstation).  Note that your changes to the grid have stuck!

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP#1835127 - Stamp upgrade script
Chris Sharp [Wed, 23 Sep 2020 20:33:06 +0000 (16:33 -0400)]
LP#1835127 - Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP#1835127: scoped permissions for reservations
Jeff Davis [Wed, 6 May 2020 21:22:49 +0000 (14:22 -0700)]
LP#1835127: scoped permissions for reservations

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP#1361270 Self-registration doesn't retain org unit on refresh
Dan Briem [Tue, 25 Aug 2020 19:47:15 +0000 (15:47 -0400)]
LP#1361270 Self-registration doesn't retain org unit on refresh

This sets the self-registration form's org unit selector to the
the current org unit request parameter if it's set and self-
registration is allowed for that org unit. This will preopulate
the org selector on refresh or error instead of resetting to the
default context.

To test:
1. Administration->Local Administration->Library Settings Editor
   set Allow Patron Self-Registration to True (top context)
2. go to OPAC->Request Library Card (stock link is on bottom)
3. select a Home Library and click Submit Registration
4. note the Home Library select doesn't retain your selection
5. apply this fix and repeat steps
6. note the Home Library is retained

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 months agoLP1883126 Angular accesskey sort repair
Bill Erickson [Wed, 10 Jun 2020 15:46:39 +0000 (11:46 -0400)]
LP1883126 Angular accesskey sort repair

Fixes sorting issue in Angular egAccessKey directive to ensure that the
most recent additions are given highest priority and to ensure that
like keys (same action) are sorted next to each other in the control-h
help dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
2 months agoLP1896629 Angular catalog deleted record indicators
Bill Erickson [Mon, 1 Jun 2020 19:43:02 +0000 (15:43 -0400)]
LP1896629 Angular catalog deleted record indicators

Adds a (Deleted) record indictor to the bib summary component, which
appears in various Angular interfaces.

Also adds a (Deleted) to the catalog search results.  It sits where the
Place Hold button would normally go.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1885767: stamp DB update
Galen Charlton [Tue, 22 Sep 2020 14:26:51 +0000 (10:26 -0400)]
LP#1885767: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1885767 Staff catalog exclude electronic option
Bill Erickson [Fri, 28 Aug 2020 16:11:39 +0000 (12:11 -0400)]
LP1885767 Staff catalog exclude electronic option

Adds support for the 'Exclude Electronic Resources' checkbox in the
staff catalog, consistent with the TPAC option.

Adds a workstation setting, 'Staff Catalog "Exclude Electronic
Resources" Option' to control the behavior and an option to
toggle the preference in the staff catalog preferences page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1892111 Staff Catalog Digital Bookplates
Bill Erickson [Wed, 19 Aug 2020 14:54:35 +0000 (10:54 -0400)]
LP1892111 Staff Catalog Digital Bookplates

Support for digital bookplates searching in the staff catalog.

Note to testers, the org setting 'opac.search.enable_bookplate_search'
must be set to true and copy tags must be added and linked to copies.

Included in commit is a minor i18n tweak to address some complaints by
the Angular build.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1896081 Repair staff catalog filter expansion error
Bill Erickson [Thu, 17 Sep 2020 15:15:39 +0000 (11:15 -0400)]
LP1896081 Repair staff catalog filter expansion error

Simplifies an i18n structure that was leading to this error when
expanding the staff catalog filters section:

ERROR DOMException: Failed to execute 'appendChild' on
'Node': The new child element contains the parent.
    at EmulatedEncapsulationDomRenderer2.appendChild

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1896083 Staff catalog handles not-found barcodes
Bill Erickson [Thu, 17 Sep 2020 15:39:43 +0000 (11:39 -0400)]
LP1896083 Staff catalog handles not-found barcodes

Staff catalog => Numeric Search => Item Barcode

Display the standard 'No Maching Items Were Found' message when a
barcode search returns no results.

Prior to this patch, the search progress indicator would freeze as the
page failed to completely render on JS error.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1896512 Angular retrieve record by ID/TCN
Bill Erickson [Mon, 21 Sep 2020 19:38:26 +0000 (15:38 -0400)]
LP1896512 Angular retrieve record by ID/TCN

Ports the retrieve records by ID/TCN to Angular.  Note this version of
the form confirms a record exists by both ID and TCN before directing
the user to the record detail page in the Angular staff catalog.

Updates the navigation bars to use the Angular port for each.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1788260: stamp schema update
Galen Charlton [Mon, 21 Sep 2020 15:51:09 +0000 (11:51 -0400)]
LP#1788260: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1788260 - Break out in-house-use non-cat circulations.
Chris Sharp [Tue, 21 Aug 2018 18:22:05 +0000 (14:22 -0400)]
LP#1788260 - Break out in-house-use non-cat circulations.

Previously, all non-cataloged circulations were grouped
together, causing problems for libraries who need to
exclude in-house circulations from circ counts.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agomake npm run export-strings happier
Galen Charlton [Thu, 17 Sep 2020 16:16:01 +0000 (12:16 -0400)]
make npm run export-strings happier

The UrlMatcher function used by the provider interface needs
to spelled slighly differently to avoid the AOT compiler
used by "npm run export-strings" from failing with the following error:

ERROR in Error during template compile of 'AcqProviderRoutingModule'
  Function expressions are not supported in decorators in 'ɵ0'
    'ɵ0' contains the error at app/staff/acq/provider/routing.module.ts(7,14)
      Consider changing the function expression into an exported function

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoRemove Extraneous Permissions from Course Reserves
Jason Boyer [Wed, 16 Sep 2020 17:03:20 +0000 (13:03 -0400)]
Remove Extraneous Permissions from Course Reserves

According to the release notes and seed data the MANAGE_RESERVES
permission is intended to be granted to the Circulation Administrator
group rather than Serials and System / Global Administrators.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoupdate schema update script for Curbside Pickup
Galen Charlton [Tue, 15 Sep 2020 20:41:20 +0000 (16:41 -0400)]
update schema update script for Curbside Pickup

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agofirst pass at consolidated schema update for 3.6-beta1
Galen Charlton [Tue, 15 Sep 2020 18:39:33 +0000 (14:39 -0400)]
first pass at consolidated schema update for 3.6-beta1

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoCorrect typo in seed data
Jason Boyer [Wed, 16 Sep 2020 18:22:15 +0000 (14:22 -0400)]
Correct typo in seed data

Rather than causing an error, forgetting a comma between 2 strings
concatenates them, and we don't have a permission called
VIEW_MERGE_PROFILEVIEW_REPORT_OUTPUT.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoTranslation updates - po file - 3.6
Galen Charlton [Wed, 16 Sep 2020 18:34:12 +0000 (14:34 -0400)]
Translation updates - po file - 3.6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoTranslation updates - newpot for 3.6
Galen Charlton [Wed, 16 Sep 2020 18:28:21 +0000 (14:28 -0400)]
Translation updates - newpot for 3.6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoadjusted release notes title to use -beta1 rather than -beta
Galen Charlton [Wed, 16 Sep 2020 18:10:41 +0000 (14:10 -0400)]
adjusted release notes title to use -beta1 rather than -beta

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agovarious changes to the 3.6 release notes
Michele Morgan [Wed, 16 Sep 2020 17:54:26 +0000 (13:54 -0400)]
various changes to the 3.6 release notes

Added notes for:

LP1818367
LP1841974
LP1880028
LP1884657

as well as typos and omissions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoupdate draft release notes for Curbside Pickup
Galen Charlton [Tue, 15 Sep 2020 20:43:19 +0000 (16:43 -0400)]
update draft release notes for Curbside Pickup

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agostart 3.6 release notes
Galen Charlton [Tue, 15 Sep 2020 18:17:27 +0000 (14:17 -0400)]
start 3.6 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoCorrect opensrf.xml.example
Jason Boyer [Wed, 16 Sep 2020 10:57:55 +0000 (06:57 -0400)]
Correct opensrf.xml.example

Add missing closing tag, include child process limits.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
2 months agoFix errors in live tests for courses
Jane Sandberg [Tue, 15 Sep 2020 23:34:55 +0000 (16:34 -0700)]
Fix errors in live tests for courses

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agofix some warnings reported by Launchpad's translation import
Galen Charlton [Tue, 15 Sep 2020 21:38:22 +0000 (17:38 -0400)]
fix some warnings reported by Launchpad's translation import

This patch fixes POT syntax errors in two cases and checks
in the results of xml2po for another. None of the files involved
(nowadays) are visible to users, so this patch is strictly
about keeping LP happy.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1811710: (follow-up) update loadChildren for hopeless holds
Galen Charlton [Tue, 15 Sep 2020 20:53:02 +0000 (16:53 -0400)]
LP#1811710: (follow-up) update loadChildren for hopeless holds

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1879983: stamp schema update
Galen Charlton [Tue, 15 Sep 2020 20:38:24 +0000 (16:38 -0400)]
LP#1879983: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1879983: Look at closings when getting times for a date
Mike Rylander [Mon, 24 Aug 2020 23:40:51 +0000 (19:40 -0400)]
LP#1879983: Look at closings when getting times for a date

This adds a check for library closings when getting the list of times to
offer for an appointment.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>