Evergreen.git
3 years agoLP#1816475: offset the start time after end time alert
Galen Charlton [Fri, 18 Oct 2019 15:56:54 +0000 (11:56 -0400)]
LP#1816475: offset the start time after end time alert

Move the alert over to align with the date inputs for a slightly
tidier appearance.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: form validation prevents users from making reservations in the past
Jane Sandberg [Mon, 14 Oct 2019 21:47:49 +0000 (14:47 -0700)]
LP1816475: form validation prevents users from making reservations in the past

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: give booking pull list columns the correct datatype
Jane Sandberg [Mon, 14 Oct 2019 19:27:46 +0000 (12:27 -0700)]
LP1816475: give booking pull list columns the correct datatype

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Strip whitespace from patron barcodes
Jane Sandberg [Thu, 10 Oct 2019 03:27:43 +0000 (20:27 -0700)]
LP1816475: Strip whitespace from patron barcodes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Change calendar_today icon to event icon
Jane Sandberg [Wed, 9 Oct 2019 19:25:17 +0000 (12:25 -0700)]
LP1816475: Change calendar_today icon to event icon

The locally served calendar_today icon doesn't look good in buttons
(like the date-select and datetime-select component buttons).  But the
event icon looks very similar, and doesn't have the same negative
effects when placed in buttons.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: use [routerLink] instead of href in Angular app
Jane Sandberg [Wed, 9 Oct 2019 18:42:08 +0000 (11:42 -0700)]
LP1816475: use [routerLink] instead of href in Angular app

Using <a href=""> forces a reload of the Angular app in the user's
browser, which substantially slows down the experience.  This commit
changes some href attributes to routerLink directives in the booking
navigation menu.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Fix resource type filter in manage reservations grid
Jane Sandberg [Fri, 13 Sep 2019 18:04:27 +0000 (11:04 -0700)]
LP1816475: Fix resource type filter in manage reservations grid

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Add ancestors checkbox to manage reservations screen
Jane Sandberg [Fri, 13 Sep 2019 15:16:15 +0000 (08:16 -0700)]
LP1816475: Add ancestors checkbox to manage reservations screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Don't let users edit reservation.email_notify, pickup_lib, request_lib
Jane Sandberg [Tue, 10 Sep 2019 01:18:06 +0000 (18:18 -0700)]
LP1816475: Don't let users edit reservation.email_notify, pickup_lib, request_lib

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Add action buttons to Pickup and Return reservation screens
Jane Sandberg [Mon, 9 Sep 2019 21:52:16 +0000 (14:52 -0700)]
LP1816475: Add action buttons to Pickup and Return reservation screens

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Return reservations screen refreshes properly
Jane Sandberg [Mon, 9 Sep 2019 15:02:53 +0000 (08:02 -0700)]
LP1816475: Return reservations screen refreshes properly

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Fix an icon spacing issue
Jane Sandberg [Mon, 9 Sep 2019 12:27:51 +0000 (05:27 -0700)]
LP1816475: Fix an icon spacing issue

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1816475: Add a Create Reservation button to the Create Reservation screen
Jane Sandberg [Mon, 9 Sep 2019 12:11:15 +0000 (05:11 -0700)]
LP1816475: Add a Create Reservation button to the Create Reservation screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1830973 Remove no longer needed navbar margin mods
Bill Erickson [Mon, 21 Oct 2019 17:38:46 +0000 (13:38 -0400)]
LP1830973 Remove no longer needed navbar margin mods

Angular 8 and dependency changes render some existing nav bar padding no
longer necessary.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1830973 Angular8 lint repair
Bill Erickson [Mon, 21 Oct 2019 17:25:42 +0000 (13:25 -0400)]
LP1830973 Angular8 lint repair

Avoid lint warning:

"In the class "NotBeforeMomentValidatorDirective", the directive input
property "egNotBeforeMoment" should not be renamed."

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1830973 Angular 8 updates
Bill Erickson [Mon, 21 Oct 2019 15:18:29 +0000 (11:18 -0400)]
LP1830973 Angular 8 updates

Update package.json versions and perform the angular 7 to angular 8
migration steps.

Update some configs to match supported options in newer versions of
typescript and tslint.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1830973 Angular reversioning script
Bill Erickson [Mon, 5 Aug 2019 21:58:41 +0000 (17:58 -0400)]
LP1830973 Angular reversioning script

Script for rebuilding the dependencies for the Angular app.  This is
useful both for major Angular upgrades or just for simply refreshing the
deps on the current version to ensure everything is up to date, but not
so up to date is breaks Angular compatibility.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1830973 Node install v12.6.0
Bill Erickson [Mon, 8 Jul 2019 16:28:17 +0000 (12:28 -0400)]
LP1830973 Node install v12.6.0

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1830973 Deps installer uses Angular 8
Bill Erickson [Mon, 8 Jul 2019 15:08:20 +0000 (11:08 -0400)]
LP1830973 Deps installer uses Angular 8

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1821969 Additional fix to second_given_name
Michele Morgan [Mon, 16 Sep 2019 18:50:16 +0000 (14:50 -0400)]
LP1821969 Additional fix to second_given_name

Adds primary second_given_name to the preferred name if there is no
preferred second_given_name. This matches the behavior of the other name
fields.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1821969 Patron Prefix and Suffix Display in Summary
Garry Collum [Wed, 8 May 2019 00:57:50 +0000 (20:57 -0400)]
LP1821969 Patron Prefix and Suffix Display in Summary

Adds support for displaying the patron prefix, suffix, preferred prefix, and preferred suffix in the patron summary sidebar.

To test:
  1. Add a combination of prefixes, suffixes, preferred prefixes, and preferred suffixes to several patrons.
  2. Also add some other preferred information to some of these patrons.
  3. In the sidebar notice the lack of prefix information in both the patron's main heading and in the preferred name information.
  4. Apply the patch.
  5. In the sidebar the prefixes and suffixes are now displayed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1802952: stamp schema update
Galen Charlton [Mon, 21 Oct 2019 18:08:39 +0000 (14:08 -0400)]
LP#1802952: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1802952 Check bib visibility for located URI auto suggest
Dan Wells [Mon, 12 Nov 2018 16:31:33 +0000 (11:31 -0500)]
LP#1802952 Check bib visibility for located URI auto suggest

Suggestions from records with only located URIs (no copies) do not
appear in the OPAC search suggestions. This appears to be a cousin of
bug #1773479, but in a neighboring function.

In the case of libraries with LURIs, we need to consider bib visibility
separate from copy visibility in order for both to show up.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1749970 Fix paging of pending patrons
Jeff Godin [Tue, 2 Apr 2019 16:49:18 +0000 (12:49 -0400)]
LP#1749970 Fix paging of pending patrons

Fix paging of pending patrons by passing a count and offset to the
backend API call.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1657171 - Adding upgrade script
Chris Sharp [Mon, 21 Oct 2019 13:44:27 +0000 (09:44 -0400)]
LP#1657171 - Adding upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP#1657171 - Normalize right and left single and double quotes
Michele Morgan [Fri, 12 Oct 2018 20:01:40 +0000 (16:01 -0400)]
LP#1657171 - Normalize right and left single and double quotes

Changes search_normalize and naco_normalize to replace right and left
leaning single quotes with U+0027, double quotes with U=0022

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP#1777698 Duplicate barcode alert appearing on new barcodes
Dan Briem [Sun, 11 Aug 2019 01:02:00 +0000 (21:02 -0400)]
LP#1777698 Duplicate barcode alert appearing on new barcodes

When scanning new copy barcodes, ng-change quickly fires multiple times
and sends promises to check for duplicates. If 1234 exists and you scan
12345, if the 1234 promise resolves after 12345, it will indicate it's a
duplicate. This patch keeps a count of the promises sent and only the
latest promise will set the boolean to indicate if it's a duplicate.

Hard to test because the promises usually resolve in order:
1. Add a new holding with the first few characters of an unused barcode
2. Scan the new barcode multiple times until you see the dup error
3. Apply patch and scan the new barcode multiple times (no error)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP 985957 Prevent hold activation date being in the past
Suzanne Paterno [Tue, 6 Aug 2019 14:25:05 +0000 (10:25 -0400)]
LP 985957 Prevent hold activation date being in the past

Created a new JS function isValidDate. Checks that the date is in the future, is a valid date within the month/year given. Also makes sure the date is in the proper format D/m/Y.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1778606 Web Client - Place Hold Requires Two Clicks on Submit
Dan Briem [Fri, 4 Oct 2019 14:57:06 +0000 (10:57 -0400)]
LP#1778606 Web Client - Place Hold Requires Two Clicks on Submit

Issue: the barcode lookup runs on the input's onchange, onkeypress (Enter), &
disables the submit button until the patron loads. So, if you type a barcode,
click enter, click the submit button, mousedown fires, if focus was still the
barcode input, its onchange fires, the lookup runs again, the submit button
disables, prevents button mouseup from firing, the click event is disrupted, &
the form doesn't submit. Click again & it works.

Instead of onchange & onkeypress this branch runs the lookup when there's a
500ms pause between onkeydowns. onpaste and enter still run the lookup
immediately. The patron search triggers the input's keydown instead of change.

To test:
1. Search for any holdable item in the catalog and click Place Hold
2. Type in an existing patron barcode and click Enter
3. Before tabbing or clicking off the barcode input, click the Submit button
4. Note it doesn't submit - click again and it submits
5. Apply patch
6. Repeat steps 1-3
7. Note it submits

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
3 years agoLP#1555791: add release notes entry
Galen Charlton [Fri, 18 Oct 2019 15:05:47 +0000 (11:05 -0400)]
LP#1555791: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1555791 - Hide Print List from checkout screen
Josh Stompro [Fri, 13 Sep 2019 20:02:36 +0000 (15:02 -0500)]
LP#1555791 - Hide Print List from checkout screen

Hide the print list button from the checkout screen so customers
don't learn to use that instead of logout.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1842763: Vandelay: disable grid row select on queued record matches
Jeff Davis [Thu, 10 Oct 2019 18:04:48 +0000 (11:04 -0700)]
LP#1842763: Vandelay: disable grid row select on queued record matches

Users are on this screen to select a merge target, which they do by
selecting a cell in the Merge Target column.  The grid selector
checkboxes are confusing and useless (they don't support the purpose of
this screen and there are no supported actions for selected rows).

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1841089 Apply button in Patron Bill History screen is in confusing location
Dan Briem [Sat, 24 Aug 2019 18:44:01 +0000 (14:44 -0400)]
LP#1841089 Apply button in Patron Bill History screen is in confusing location

It's possible to miss the apply button for the date range in bill history
because it's located before the datepickers. The interface also allows
invalid date ranges.

This removes the apply button and watches the start and finish dates in the
bill history and payment history controllers. If it's not first init and they
are valid date objects in a valid date range, the grid refreshes with the new
date range query. If start > finish they are set equal to each other to force
a valid range.

To test:

1. Apply patch
2. Bring up a patron with bills and payments (or add bills and payments)
3. Under the Bills tab click History
4. Change the date range and observe that the grid refreshes
5. Try to set the start date past the finish date and vice versa

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1729435: stamp DB update
Galen Charlton [Fri, 4 Oct 2019 14:33:45 +0000 (10:33 -0400)]
LP#1729435: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1729435: Add Seed Data for WS type for Bill Full Details grids
Michele Morgan [Fri, 5 Apr 2019 20:55:19 +0000 (16:55 -0400)]
LP#1729435: Add Seed Data for WS type for Bill Full Details grids

Adds the config.workstation_setting_type values to the seed data and
an upgrade script to allow storing in the database.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1729435: Allow saving Bill Full Details grids
Remington Steed [Mon, 5 Nov 2018 21:11:35 +0000 (16:11 -0500)]
LP#1729435: Allow saving Bill Full Details grids

For a web staff eg-grid to save and retrieve its settings, it needs a unique
persist-key. This commit adds one for the Bills grid and Payments grid on the
patron bills Full Details view (right-click a bill, choose Full Details, then
click the Details tab).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1803790: apply alphabetization fix to Angular admin splash pages
Galen Charlton [Fri, 4 Oct 2019 14:12:49 +0000 (10:12 -0400)]
LP#1803790: apply alphabetization fix to Angular admin splash pages

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1803790 Re-alphabetize Local & Server Administration Links
Terran McCanna [Wed, 6 Mar 2019 21:40:53 +0000 (16:40 -0500)]
LP#1803790 Re-alphabetize Local & Server Administration Links

Small fix that re-orders the links that were out of order due
to link name changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings
Jeff Davis [Tue, 2 Oct 2018 21:28:31 +0000 (14:28 -0700)]
LP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings

To test:

1. Create a bib record.
2. Add an item to the record at BR1. Mark it as not OPAC-visible.
3. Do a CONS-level SRU search for the record, including holdings. The
   record is not included in results because there are no OPAC-visible
   holdings.
4. Add a second item to the same record, this time at BR3. Mark this
   one as OPAC-visible.
5. Repeat the CONS-level SRU search, including holdings. The record
   appears in search results, but holdings information in 852 includes
   *all* copies, including non-OPAC-visible copies.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP 1827250: Fix Last Captured Hold Check for Holds Shelf
Jason Stephenson [Thu, 2 May 2019 12:36:15 +0000 (08:36 -0400)]
LP 1827250: Fix Last Captured Hold Check for Holds Shelf

When the current copy on an on shelf hold is the same as that on some
uncaptured holds, the hold fails to appear on the hold shelf when it
should.  This comes down to some SQL in the storage function to
retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.

The intent of the new code is to check that the current hold matches
the most recently captured hold for the copy.  However, the order by
in the query fails to take into account holds with a NULL capture time
on the same copy will sort before the captured holds.  This patch
rectifies this situation by adding "NULLS LAST" to the order by.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agolp1813056 Fixes Current Date in Date Returned in Circ History CSV
Garry Collum [Mon, 20 May 2019 16:48:10 +0000 (12:48 -0400)]
lp1813056 Fixes Current Date in Date Returned in Circ History CSV

The date returned column in the csv file created in the opac for the patron's
Check Out History contains the current date instead of the check-in date. This
patch fixes that issue.

To test:
1. Turn on "Keep history of checked out items" in the patron Search and
History Preferences in the opac, or find a patron that already has this
option turned on.
2. Check-in some items that the patron has checked-out.
3. Wait a day, or if it was an existing history list immediately, go to the patron's Items Checked Out in the opac and look at the Date Returned
column in the Check Out History list.
4. Download the CSV file and note that the date is the current date.
5. Apply the patch.
6. Refresh and download the CSV file again and note that the Date Returned
is now the checkin date.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
3 years agoLP#1836963: reduce the cost of utility functions, speeding up search
Mike Rylander [Wed, 17 Jul 2019 21:14:01 +0000 (17:14 -0400)]
LP#1836963: reduce the cost of utility functions, speeding up search

For large org trees, some several seconds are spent testing org visibility.
The immediate cause is that AppUtils::get_org_tree() does not populate the
process-local cache with a memcache-cached org tree. That only happens when
memcache does not have a copy of the org tree. This is obviously a simple
oversight, which is addressed by making sure any memcache return value
is pushed into the the process local cache.

Additionally, the visibility check is making heavy use of lots of
indirection and delegation to utility code, when some slightly smarter code
could avoid many repeated function calls.  We now supply some local
utility code to flesh and unflesh the parent_ou field of objects in the
org tree, allowing us to avoid using find_org() and instead just calling
parent_ou() when walking "up" the tree.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: adding basic documentation for new 3.4 features
Jane Sandberg [Thu, 3 Oct 2019 16:41:09 +0000 (09:41 -0700)]
Docs: adding basic documentation for new 3.4 features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoforward-port 3.3.3-3.4.0 schema update
Galen Charlton [Wed, 2 Oct 2019 21:28:11 +0000 (17:28 -0400)]
forward-port 3.3.3-3.4.0 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoforward-port 3.4 release notes
Galen Charlton [Wed, 2 Oct 2019 21:27:16 +0000 (17:27 -0400)]
forward-port 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agonote minimum OpenSRF version in upgrade instructions
Galen Charlton [Wed, 2 Oct 2019 20:08:59 +0000 (16:08 -0400)]
note minimum OpenSRF version in upgrade instructions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1846369: add libhtml-defang-perl to Debian Buster installation
Galen Charlton [Wed, 2 Oct 2019 16:55:28 +0000 (12:55 -0400)]
LP#1846369: add libhtml-defang-perl to Debian Buster installation

This patch fixes an oversight where the HTML::Defang dependency
added in LP#1825851 wasn't installed on Debian Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoLP#1846357: fix circulation and billing aging
Galen Charlton [Wed, 2 Oct 2019 15:31:06 +0000 (11:31 -0400)]
LP#1846357: fix circulation and billing aging

An error merging an update to action.age_circ_on_delete() resulted
in a regression to the aging of billings. This patch fixes it.

To test
-------
[1] Apply the patch, then age circulations. Verify that relevant
    billings are also aged.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoTranslation updates - po files
Galen Charlton [Wed, 2 Oct 2019 00:02:33 +0000 (20:02 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoTranslation updates - newpot
Galen Charlton [Tue, 1 Oct 2019 23:58:33 +0000 (19:58 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1842940: stamping and slight tweak to upgrade script
Jane Sandberg [Tue, 1 Oct 2019 21:47:07 +0000 (14:47 -0700)]
LP1842940: stamping and slight tweak to upgrade script

Mike Rylander suggested the INSERT ... SELECT ... WHERE NOT
EXISTS approach, since this fix is being backported to older
releases, and we don't want to cause duplicate entries or
upgrade failures if the perm already exists

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1842940: Improve Alert
Mike Rylander [Tue, 17 Sep 2019 15:07:04 +0000 (11:07 -0400)]
LP#1842940: Improve Alert

Attempt to float the alerts below the sticky bar and above the main
content of the user editor.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1842940: Alert when editing is disallowed
Mike Rylander [Wed, 11 Sep 2019 18:46:44 +0000 (14:46 -0400)]
LP#1842940: Alert when editing is disallowed

Provide functions that checks the permissions required to edit ones
own account, or accounts in groups based on group application
permissions, and alert the user if and why they can't edit an account.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1842940: add perm to permit staff to edit their own accounts in the client
Jeff Davis [Thu, 5 Sep 2019 17:23:55 +0000 (10:23 -0700)]
LP#1842940: add perm to permit staff to edit their own accounts in the client

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1842940: Don't allow self-edit or perm-restricted edit
Mike Rylander [Thu, 5 Sep 2019 15:34:51 +0000 (11:34 -0400)]
LP#1842940: Don't allow self-edit or perm-restricted edit

Pre-webstaff, we disallowed editing of ones own record, an of records
that have a group application permission that the staff do not possess.

This commit brings back those restrictions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoLP#1835458: bump up OpenSRF requirement
Galen Charlton [Tue, 1 Oct 2019 21:56:47 +0000 (17:56 -0400)]
LP#1835458: bump up OpenSRF requirement

OpenSRF 3.2.0 or later is now required for Evergreen 3.4+ as
a consequence of the new support for Debian 10 Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoupdates to 3.4 release notes
Galen Charlton [Tue, 1 Oct 2019 21:55:58 +0000 (17:55 -0400)]
updates to 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1835085: stamp DB update
Galen Charlton [Tue, 1 Oct 2019 21:24:16 +0000 (17:24 -0400)]
LP#1835085: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLp 1835085: Update Item Status templates for auto-renewal
Jason Stephenson [Mon, 9 Sep 2019 12:47:09 +0000 (08:47 -0400)]
Lp 1835085: Update Item Status templates for auto-renewal

Add checks for circ.auto_renewal() == 't' in the circ list and summary
pane views of the web staff client Item Status interface.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLp 1835035: Refactor auto_renewal back end code
Jason Stephenson [Fri, 30 Aug 2019 15:37:24 +0000 (11:37 -0400)]
Lp 1835035: Refactor auto_renewal back end code

Refactor the auto_renewal feature so that it works like other renewal
types: opac_renewal, sip_renewal, etc.  This refactor prevents
desk_renewal from being set when auto_renewal is set.

Deprecate the newly added open-ils.circ.renew.auto API and ensure that
it still works as intended.  Add release note indicating the
deprecation of this API and intent to remove it in Evergreen 3.5.

Modify the AutoRenew action trigger reactor to use the plain
open-ils.circ.renew API with the auto_renewal option set to 1.

Add database update script to cleanup (i.e. set to FALSE) the
desk_renewal field on action.circulation and action.aged_circulation
tables where auto_renewal is TRUE.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1835577: stamp schema updates
Galen Charlton [Tue, 1 Oct 2019 21:19:51 +0000 (17:19 -0400)]
LP#1835577: stamp schema updates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLp 1835577: Add more missing auto_renewal fields
Jason Stephenson [Tue, 10 Sep 2019 15:27:07 +0000 (11:27 -0400)]
Lp 1835577: Add more missing auto_renewal fields

Add missing auto_renewal and auto_renewal_remaining fields to the
following additional IDL classes:

* aacs
* aoc
* circbyyr
* robcirc

Add database updates to add auto_renewal fields to the following
views:

* action.billable_circulations
* action.open_circulation
* reporter.circ_type
* reporter.overdue_circs

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLp 1835577: Add missing Auto Renewal fields to the IDL
Jason Stephenson [Thu, 29 Aug 2019 14:15:33 +0000 (10:15 -0400)]
Lp 1835577: Add missing Auto Renewal fields to the IDL

Add entries for auto_renewal and auto_renewal_remaining fields to the
acirc and combcirc classes in fm_IDL.xml.  They were missing after the
auto-renewal feature was added.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1839002: stamp DB update
Galen Charlton [Tue, 1 Oct 2019 21:15:36 +0000 (17:15 -0400)]
LP#1839002: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLp 1839002: Default circulation auto_renewal field to FALSE
Jason Stephenson [Thu, 29 Aug 2019 15:06:56 +0000 (11:06 -0400)]
Lp 1839002: Default circulation auto_renewal field to FALSE

Change the definition of the action.circulation table so that the
auto_renewal field is not null, default false.

Add an upgrade script to update the field values and alter the field
definition in both the action.circulation and action.aged_circulation
tables.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1840669: stamp schema update
Galen Charlton [Tue, 1 Oct 2019 21:06:16 +0000 (17:06 -0400)]
LP#1840669: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLp 1840669: Handle autorenewals when aging circulations
Jason Stephenson [Thu, 29 Aug 2019 14:03:50 +0000 (10:03 -0400)]
Lp 1840669: Handle autorenewals when aging circulations

Add auto_renewal and auto_renewal_remaining fields to the
action.age_circ_on_delete trigger function.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1845050: fix issue where reports interface was partially loaded
Galen Charlton [Tue, 24 Sep 2019 17:48:08 +0000 (13:48 -0400)]
LP#1845050: fix issue where reports interface was partially loaded

This patch adjusts mod_xmlent to not free its XML parser
prematurely in the face of an EOS bucket received while processing
a sub-request.

To test
-------
[1] Test on a platform that has Apache 2.4.25 or later, such as
    Debian Stretch.
[2] Note that when loading the reports interface that the source
    of the frame containing oils_rpt.xhtml is incomplete and that
    actions like creating a template or folder do not work in the
    interface.
[3] Apply the patch and repeat step 2. This time, oils_rpt.xhtml
    should be fully loaded and the interface fuctional.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoLP#1845260: add additional DB update to be sure
Galen Charlton [Tue, 1 Oct 2019 20:54:39 +0000 (16:54 -0400)]
LP#1845260: add additional DB update to be sure

... that the function is correct if somebody is upgrading a
beta1 or beta2 database.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1845260: fix error in vandelay.auto_overlay_org_unit_copies db function
Jeff Davis [Mon, 23 Sep 2019 23:15:14 +0000 (16:15 -0700)]
LP#1845260: fix error in vandelay.auto_overlay_org_unit_copies db function

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1844812 Combobox avoids processing matching entry lists
Bill Erickson [Fri, 20 Sep 2019 15:31:16 +0000 (11:31 -0400)]
LP1844812 Combobox avoids processing matching entry lists

Teach the combobox to only process newly provided entry lists if they
are different from the list already on record for the combobox.

The combobox entry list Input() is responsive to changes in data
throughout the life of the combobox.  As a new entry list is provided,
the component will perform various actions on the list.  However, in
many cases the list provided may be identical the list the component
already has, which can lead to a lot of unnecessary processing and in
some case an infinite loop of inputs and outputs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1811442 - Assign copy alert permissions.
Chris Sharp [Mon, 20 May 2019 19:44:08 +0000 (15:44 -0400)]
LP#1811442 - Assign copy alert permissions.

VIEW_COPY_ALERTS and ADMIN_COPY_ALERT permissions were added
recently, but not assigned in the default seed data.  This branch
assigns VIEW_COPY_ALERTS to Staff profiles at the Consortium depth
and adds ADMIN_COPY_ALERT to the Cataloging Administrator profile.

Since permissions are set so specifically per-site, this branch does
not contain an upgrade script, but does provide an update to release
notes reminding site admins to manually add them to the appropriate
profiles.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1560805 Webstaff locale picker repair
Bill Erickson [Wed, 23 May 2018 15:13:16 +0000 (11:13 -0400)]
LP#1560805 Webstaff locale picker repair

Make the locale picker less finicky by replacing the search/replace
regex with a simple static URL for applying the locale.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1830642: add tests for authenticating users when password contains percent sign
Jeff Davis [Mon, 27 May 2019 19:03:00 +0000 (12:03 -0700)]
LP#1830642: add tests for authenticating users when password contains percent sign

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1768141: Stamping Upgrade Script
Jason Boyer [Tue, 1 Oct 2019 19:10:56 +0000 (15:10 -0400)]
LP#1768141: Stamping Upgrade Script

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoLP#1768141: (follow-up) change schema update
Galen Charlton [Fri, 2 Aug 2019 14:41:44 +0000 (10:41 -0400)]
LP#1768141: (follow-up) change schema update

Change the update to an "ALTER FUNCTION ... STABLE" both
to make the purpose of the update more clear and to remove
the need to check the rest of the function definition when
backporting.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoLP#1768141 - Mark permission.grp_descendants STABLE.
Chris Sharp [Mon, 20 May 2019 20:14:00 +0000 (16:14 -0400)]
LP#1768141 - Mark permission.grp_descendants STABLE.

Quoting Galen Charlton's comments on the bug report:

The database function permission.grp_descendants should
be marked stable; it qualifies, and doing so should allow
PostgreSQL to improve query plans. One example of a query
that would benefit is searching by patron profile (a la
bug 1497322)

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoLP1739607: Add missing columns to patron record
Jane Sandberg [Wed, 21 Aug 2019 17:26:47 +0000 (10:26 -0700)]
LP1739607: Add missing columns to patron record

To test:
1) Open up a patron record with some bills.
2) On the Items Out tab, notice that there is a column named Location
3) On the Bills tab, open up Bill history.
4) In the history transactions grid, note that the column picker is
missing the following columns:
  * Item owning library
  * Checkout/renewal library
  * Due date
  * Fines Stopped Reason
5) In the history payments grid, note that the column picker is missing
the same columns.
6) Apply this commit.
7) Note that the Items Out tab's column is renamed to "Shelving
Location".
8) Notice that both Bill history grids column pickers include the
requested columns.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoDocs: minor formatting changes to Hide Fields doc
Andrea Buntz Neiman [Tue, 1 Oct 2019 17:57:32 +0000 (13:57 -0400)]
Docs: minor formatting changes to Hide Fields doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoDocs: adding Hiding Fields in Holdings Editor docs and screenshots
Beth Willis [Tue, 1 Oct 2019 17:32:06 +0000 (13:32 -0400)]
Docs: adding Hiding Fields in Holdings Editor docs and screenshots

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoDocs: added another contributor
Andrea Buntz Neiman [Fri, 27 Sep 2019 20:51:35 +0000 (16:51 -0400)]
Docs: added another contributor

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoLP#1843637 MARC View Display Issues
Terran McCanna [Mon, 16 Sep 2019 19:45:52 +0000 (15:45 -0400)]
LP#1843637 MARC View Display Issues

This fixes vertical alignment issues in the MARC View table
by removing the deprecated valign tags and moving the inline
CSS to the cat.css file. The text within each table cell should
now align to the top for better readability.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoDocs: Adding contributors and employers; fixing formatting
Jane Sandberg [Wed, 25 Sep 2019 20:58:04 +0000 (13:58 -0700)]
Docs: Adding contributors and employers; fixing formatting

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoDocs: typo corrections and added dev funders
Andrea Buntz Neiman [Wed, 25 Sep 2019 20:22:42 +0000 (16:22 -0400)]
Docs: typo corrections and added dev funders

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoDocs: rearranging 3.4 release notes
Jane Sandberg [Tue, 24 Sep 2019 20:17:52 +0000 (13:17 -0700)]
Docs: rearranging 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 years agoadded code formatting to text
Andrea Buntz Neiman [Tue, 24 Sep 2019 19:48:53 +0000 (15:48 -0400)]
added code formatting to text

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoForward-port 3.3.4 upgrade script
Dan Wells [Thu, 19 Sep 2019 19:34:47 +0000 (15:34 -0400)]
Forward-port 3.3.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoupdate 3.4 release notes for security bugfixes
Galen Charlton [Thu, 19 Sep 2019 19:38:23 +0000 (15:38 -0400)]
update 3.4 release notes for security bugfixes

NOTE: This section can be removed for 3.4-rc.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: adding release notes for 3.3.4
Jane Sandberg [Wed, 18 Sep 2019 03:59:28 +0000 (20:59 -0700)]
Docs: adding release notes for 3.3.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: adding release notes for 3.2.9
Jane Sandberg [Wed, 18 Sep 2019 03:55:19 +0000 (20:55 -0700)]
Docs: adding release notes for 3.2.9

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoDocs: adding release notes for 3.1.15
Jane Sandberg [Wed, 18 Sep 2019 03:48:13 +0000 (20:48 -0700)]
Docs: adding release notes for 3.1.15

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1822630: fix sanitizing CGI params on place_hold_result
Jeff Davis [Mon, 10 Jun 2019 16:53:44 +0000 (09:53 -0700)]
LP#1822630: fix sanitizing CGI params on place_hold_result

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1822630: further sanitizing of CGI params when embedded in HTML
Jeff Davis [Mon, 1 Apr 2019 22:13:09 +0000 (15:13 -0700)]
LP#1822630: further sanitizing of CGI params when embedded in HTML

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1822630: sanitize user input before display on browse results
Jeff Davis [Mon, 1 Apr 2019 17:00:59 +0000 (10:00 -0700)]
LP#1822630: sanitize user input before display on browse results

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP#1559239: use rel="noopener" when opening external URLs in a new tab
Jeff Davis [Thu, 13 Sep 2018 18:58:48 +0000 (11:58 -0700)]
LP#1559239: use rel="noopener" when opening external URLs in a new tab

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoLP1735847: Remove patron info from default Hold Transit Slip
blake [Fri, 1 Dec 2017 22:32:22 +0000 (16:32 -0600)]
LP1735847: Remove patron info from default Hold Transit Slip

Removes most patron information from the Hold Transit Slip
in both the web and XUL client default definitions.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
3 years agoDocs: Group similar release notes together
Remington Steed [Tue, 10 Sep 2019 13:21:09 +0000 (09:21 -0400)]
Docs: Group similar release notes together

This commit simply moves one release note to be near a group of similar
release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 years agoDocs: Make "staff catalog" titles consistent in 3.4 Rel Notes
Remington Steed [Tue, 10 Sep 2019 13:18:24 +0000 (09:18 -0400)]
Docs: Make "staff catalog" titles consistent in 3.4 Rel Notes

This commit tries to make the release note titles regarding the angular
staff client both consistent and more readable.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 years agoTranslation updates - po files
Galen Charlton [Mon, 9 Sep 2019 21:05:56 +0000 (17:05 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 years agoTranslation updates - newpot
Galen Charlton [Mon, 9 Sep 2019 20:57:43 +0000 (16:57 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>