Evergreen.git
6 months agoDocs: Fixing broken link
Jane Sandberg [Thu, 7 Mar 2019 15:14:50 +0000 (07:14 -0800)]
Docs: Fixing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 months agoLP#1800178 Holdings View should also sort by part
Remington Steed [Fri, 26 Oct 2018 15:28:32 +0000 (11:28 -0400)]
LP#1800178 Holdings View should also sort by part

The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1818153 Stamping DB upgrade - WS user activity
Bill Erickson [Tue, 5 Mar 2019 17:21:00 +0000 (12:21 -0500)]
LP1818153 Stamping DB upgrade - WS user activity

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1818153 Log user activity for websocket login/verify
Bill Erickson [Thu, 28 Feb 2019 22:20:31 +0000 (17:20 -0500)]
LP1818153 Log user activity for websocket login/verify

Adds support for logging additional user activity types:

 * websocket v1 login (apache2-websockets)
 * websocket v2 login (websocketd)
 * websocket v1 verify
 * websocket v2 verify
 * generic login (any ingress)
 * generic verify (any ingress)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
6 months agoLP#1746360 Add Deleted Column to Record Bucket
Terran McCanna [Tue, 5 Mar 2019 15:50:59 +0000 (10:50 -0500)]
LP#1746360 Add Deleted Column to Record Bucket

This adds the Deleted column to the Record Bucket view.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP#1667497 - Define $params{depth} to avoid uninitialized warning.
Josh Stompro [Mon, 4 Mar 2019 14:57:02 +0000 (08:57 -0600)]
LP#1667497 - Define $params{depth} to avoid uninitialized warning.

$depth is set to 0 if $params{depth} is unset, but then $params{depth}
gets used later on, which causes an uninitialized value warning.

So set $params{depth} to whatever $depth was set to.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoLP1806087 Synchronize browse code for staff cat / tpac
Bill Erickson [Thu, 21 Feb 2019 19:21:47 +0000 (14:21 -0500)]
LP1806087 Synchronize browse code for staff cat / tpac

Teach the TPAC to call the use browse API, which was originally built
from the TPAC browse code.  This way we avoid duplicating the code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1806087 Ang catalog pending tabs offer manual redirect
Bill Erickson [Thu, 21 Feb 2019 18:12:52 +0000 (13:12 -0500)]
LP1806087 Ang catalog pending tabs offer manual redirect

Instead of sending users to the AngJS versions of not-yet-implemented
tabs from the Angular catalog, show a message indicating the tab is not
yet implemented and offer a link to open the requested record tab in a
new browser tab.  This better clarifies what is happening and helps to
avoid situations where the back-button is confusingly hijacked via
intermediate redirect.

We now also open the "View" link for copies in a new tab as well for
consistency with the modified "Edit" link.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoStop asciidoc from squawking about missing list number
Dan Wells [Thu, 28 Feb 2019 22:55:15 +0000 (17:55 -0500)]
Stop asciidoc from squawking about missing list number

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoTranslation updates - po files
Dan Wells [Thu, 28 Feb 2019 21:20:14 +0000 (16:20 -0500)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoTranslation updates - newpot
Dan Wells [Thu, 28 Feb 2019 21:12:17 +0000 (16:12 -0500)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoForward-port 3.2.4 upgrade script
Dan Wells [Thu, 28 Feb 2019 20:59:26 +0000 (15:59 -0500)]
Forward-port 3.2.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoForward-port 3.1.10 upgrade script
Dan Wells [Thu, 28 Feb 2019 20:59:02 +0000 (15:59 -0500)]
Forward-port 3.1.10 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoFirst pass at 3.3 release notes
Dan Wells [Thu, 28 Feb 2019 20:44:46 +0000 (15:44 -0500)]
First pass at 3.3 release notes

Ran create_release_notes.sh, cleaned up the output a bit, and removed
the separate files.  Still TODO are acknowledgments and combing out
any upgrade notes.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1813646: For now, direct the Home link to the AngularJS version.
Mike Rylander [Wed, 27 Feb 2019 15:44:59 +0000 (10:44 -0500)]
LP#1813646: For now, direct the Home link to the AngularJS version.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 months agoDocs: Adding release notes for 3.2.4
Jane Sandberg [Fri, 22 Feb 2019 21:15:56 +0000 (13:15 -0800)]
Docs: Adding release notes for 3.2.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 months agoDocs: adding release notes for 3.1.10
Jane Sandberg [Fri, 22 Feb 2019 20:30:14 +0000 (12:30 -0800)]
Docs: adding release notes for 3.1.10

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 months agoLP#1801191: Refactor for clarity; bugfix
Remington Steed [Fri, 22 Feb 2019 16:31:59 +0000 (11:31 -0500)]
LP#1801191: Refactor for clarity; bugfix

This commit makes a few small adjustments:

- Replace two instances of 'cleanse_ISO8601' with 'clean_ISO8601', as
  the former does not exist (at least in these contexts)
- Delay converting DateTimes to strings until necessary (which allows us
  to compare the original DateTime objects instead of having to recreate
  them from strings)
- Increase comments

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1801191: ensure recall does not extend due date
Jeff Davis [Thu, 1 Nov 2018 23:29:36 +0000 (16:29 -0700)]
LP#1801191: ensure recall does not extend due date

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1787479: Stamping upgrade script
Chris Sharp [Thu, 21 Feb 2019 18:05:48 +0000 (13:05 -0500)]
LP#1787479: Stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud...
Adam Bowling [Wed, 13 Feb 2019 04:15:08 +0000 (23:15 -0500)]
LP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud objects
in previous submission and adds CSS to item label template.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Fixes print label template customization saving for local storage
Adam Bowling [Tue, 29 Jan 2019 21:31:43 +0000 (16:31 -0500)]
LP#1787479: Fixes print label template customization saving for local storage

updates and incorporates added template fields from the patch
user/gmcharlt/lp1726568_label_owning_lib.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Adds customization for multipage print label printing and fixes the issue
Adam Bowling [Thu, 10 Jan 2019 07:05:50 +0000 (02:05 -0500)]
LP#1787479: Adds customization for multipage print label printing and fixes the issue
with saving templates after the change to DB saving from local storage.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Relocate t_view.tt2 file
Kathy Lussier [Fri, 23 Nov 2018 14:07:26 +0000 (09:07 -0500)]
LP#1787479: Relocate t_view.tt2 file

Accidentally saved tt2 changes in last commit to the wrong directory. Fixing
it in this commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: More layout changes
Kathy Lussier [Sat, 17 Nov 2018 18:56:12 +0000 (13:56 -0500)]
LP#1787479: More layout changes

Based on cataloger feedback, we 1) Moved the Label Set Configuration higher
grouped with the spine and spine/pocket options because all of these options
are related 2) Moved the starting label option higher because this is the
one setting that will probably be adjusted on each use of the interface and
3) Made the Gap Between Columns setting label conditional on whether the
user us printing to a sheet with label sets or not.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Make the display of some fields conditional on the Print Feed Option
Kathy Lussier [Wed, 14 Nov 2018 17:49:16 +0000 (12:49 -0500)]
LP#1787479: Make the display of some fields conditional on the Print Feed Option

Ideally, we would remove the entire Page Settings section for those who are
printing to a continuous feed printer, but it carries the risk of users
not being able to see a field with a value that is affecting the layout. However, there are several fields within that section that don't affect the
continuous feed layout and can be hidden in continuous feed mode. I also
adjusted one help tip to display different information for continuous and
sheet feed printing.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Make label names more descriptive
Kathy Lussier [Wed, 14 Nov 2018 02:07:19 +0000 (21:07 -0500)]
LP#1787479: Make label names more descriptive

As previously discussed on the cataloging list and the LP bug, the previous
label names of 'left' and 'right' no longer make sense since staff can
control the placement of these labels. However, label 1 and label 2 are too
generic. We therefore are going back to spine and pocket labels.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Some CSS and other formatting changes
Kathy Lussier [Tue, 13 Nov 2018 17:27:02 +0000 (12:27 -0500)]
LP#1787479: Some CSS and other formatting changes

Moved most of the CSS to cat.css.tt2; removed most borders since they aren't
needed as much without the full settings descriptions on the page; added some
more help text and removed Windows carriage returns.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Use help tips for settings descriptions
Kathy Lussier [Mon, 12 Nov 2018 18:04:02 +0000 (13:04 -0500)]
LP#1787479: Use help tips for settings descriptions

We are now using popup help tips for descriptions on this page. Adding these
help tips for the new settings added through this branch.

Also changes strings in this interface to translatable text.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Restore spacing fixes
Kathy Lussier [Mon, 12 Nov 2018 14:42:50 +0000 (09:42 -0500)]
LP#1787479: Restore spacing fixes

Restore spacing fixes introduced by Garry Collum that were overwritten with
the original branch.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoModified Evergreen custom print label toolbox with save modifications.
Adam Bowling [Fri, 9 Nov 2018 05:35:25 +0000 (00:35 -0500)]
Modified Evergreen custom print label toolbox with save modifications.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1787479: Custom label printing toolbox
Adam Bowling [Wed, 17 Oct 2018 20:15:44 +0000 (16:15 -0400)]
LP#1787479: Custom label printing toolbox

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2

6 months agoLP1806087 Repair SQL upgrade script file name
Bill Erickson [Thu, 21 Feb 2019 17:30:45 +0000 (12:30 -0500)]
LP1806087 Repair SQL upgrade script file name

Make the name of the file match the upgrade version number applied by
the file.

As is, build/tools/update_db.sh fails to recognize a new update is
available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1784893 Reporter - External Documentation Links
McCanna [Fri, 15 Feb 2019 18:29:21 +0000 (13:29 -0500)]
LP#1784893 Reporter - External Documentation Links

Removed old xulG logic which was not working in
the web client. Link now opens in new browser tab.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoLP1797934: Simplify header labels
Remington Steed [Wed, 20 Feb 2019 22:08:38 +0000 (17:08 -0500)]
LP1797934: Simplify header labels

Since the patron is already on the "Reservations" tab in their account,
it seems unnecessary to use the word "Reservations" in the header
labels. Also, simpler labels will make translations easier, since "Start
time" and "End time" are already used in other Bookings interfaces.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1797934: Add a patron's booking reservations to their OPAC account
Jane Sandberg [Mon, 15 Oct 2018 17:00:00 +0000 (12:00 -0500)]
LP1797934: Add a patron's booking reservations to their OPAC account

This commit creates a new tab in the patron OPAC account area where a
patron can view their current bookings.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1806087 Stamp upgrade script for staff catalog preview
Dan Wells [Wed, 20 Feb 2019 22:05:25 +0000 (17:05 -0500)]
LP#1806087 Stamp upgrade script for staff catalog preview

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agolp1806087 Place Holds Improvements
Kyle Huckins [Thu, 7 Feb 2019 19:54:56 +0000 (19:54 +0000)]
lp1806087 Place Holds Improvements

- Disable SMS Carriers dropdown if Notify by SMS  unchecked.
- Move Search for patron button to same level as "Place Hold (name)" text.
- Add Search icon to "Search for Patron" button
- Add "Submit" button to Barcode input for improved UX.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1806087 Angular catalog Ang7 & lint repairs
Bill Erickson [Thu, 31 Jan 2019 15:42:57 +0000 (10:42 -0500)]
LP1806087 Angular catalog Ang7 & lint repairs

Update rxjs imports to work with Angular7.  Add ng-lint repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1806087 Experimental Angular catalog release notes
Bill Erickson [Thu, 10 Jan 2019 18:33:19 +0000 (13:33 -0500)]
LP1806087 Experimental Angular catalog release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1806087 Org setting to enable experimental staff catalog
Bill Erickson [Thu, 10 Jan 2019 17:11:41 +0000 (12:11 -0500)]
LP1806087 Org setting to enable experimental staff catalog

Adds a new org unit setting "GUI: Enable Experimental Angular Staff
Catalog" (ui.staff.angular_catalog.enabled).  When set to true, a new
navbar menu item will appear in both the Angular and AngJS client menus
for "Staff Catalog (Experimental)".  This action directs the user to the
Angular staff catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1806087 Angular staff catalog phase II.
Bill Erickson [Wed, 7 Nov 2018 15:18:31 +0000 (10:18 -0500)]
LP1806087 Angular staff catalog phase II.

* Record detail tabs redirect to AngJS catalog where needed.
* Initial holds placement UI.
* Record baskets, actions, and UI.
* Ported MonographParts tab to Angular
* Set default catalog tab
* Browse
* MARC search
* Identifier search
* pub date filter
* Record detail 'View in Catalog' button
* Group formats and editions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLp 1813172: Option to Specify Attributes for Reingest in pingest.pl
Jason Stephenson [Fri, 25 Jan 2019 13:14:40 +0000 (08:14 -0500)]
Lp 1813172: Option to Specify Attributes for Reingest in pingest.pl

Add the --attr option to pingest.pl to specify one or more specific
attributes to be reingested by metabib.reingest_record_attributes.

Add a release note.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agolp1717551 Holdings view action menu clarity adjustment
Katlyn Beck [Wed, 28 Nov 2018 16:47:56 +0000 (16:47 +0000)]
lp1717551 Holdings view action menu clarity adjustment

- Added clarifying wording for add, edit, and delete options

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1813647 Titles for Angular admin and splash page
Bill Erickson [Tue, 29 Jan 2019 18:01:18 +0000 (13:01 -0500)]
LP1813647 Titles for Angular admin and splash page

Add page titles for auto-generated admin pages, workstation admin, and
the root splash page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1813647 Angular page title component & sandbox example
Bill Erickson [Tue, 29 Jan 2019 16:15:38 +0000 (11:15 -0500)]
LP1813647 Angular page title component & sandbox example

Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.

Each title may have a prefix and/or a suffix.  If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP#1779158 Stamping upgrade scripts for Angular Vandelay
Dan Wells [Tue, 19 Feb 2019 23:14:49 +0000 (18:14 -0500)]
LP#1779158 Stamping upgrade scripts for Angular Vandelay

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Angular7 and ng-lint updates
Bill Erickson [Thu, 31 Jan 2019 17:08:37 +0000 (12:08 -0500)]
LP1779158 Angular7 and ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Import field id/class mismatch fix
Bill Erickson [Tue, 8 Jan 2019 15:57:53 +0000 (10:57 -0500)]
LP1779158 Import field id/class mismatch fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Always clear import selection
Bill Erickson [Mon, 7 Jan 2019 21:35:15 +0000 (16:35 -0500)]
LP1779158 Always clear import selection

Clear the import selection (e.g. Queue => Import All Items) from the
import UI when the user navigates away, regardless of whether the import
succeeded.  Otherwise, the import UI gets stuck in selection mode
requiring the user to manually clear it.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Vandelay workstation setting repairs/additions
Bill Erickson [Mon, 7 Jan 2019 21:23:12 +0000 (16:23 -0500)]
LP1779158 Vandelay workstation setting repairs/additions

* Fix some workstation setting names that were missing the 'eg.grid.*'
  prefix
* Add workstation setting types for merge profile and attr definition
  admin pages.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Import non-matching saved template repair
Bill Erickson [Mon, 7 Jan 2019 21:04:41 +0000 (16:04 -0500)]
LP1779158 Import non-matching saved template repair

Fix issue in Vandelay import form templates where template variable name
did not match the form variable name.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Cache new queues / display active queues
Bill Erickson [Fri, 4 Jan 2019 16:07:31 +0000 (11:07 -0500)]
LP1779158 Cache new queues / display active queues

* Only list active (non-complete) queues in the Vandelay queue selector
  combobox.
* Display an alert message when the user attempts to create a queue
  whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
  the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
  to maintain 2 separate queue caches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1779158 Angular alert dialog component
Bill Erickson [Fri, 4 Jan 2019 16:05:17 +0000 (11:05 -0500)]
LP1779158 Angular alert dialog component

Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agolp1779158 Inspect Queue Improvements
Kyle Huckins [Tue, 18 Dec 2018 22:57:21 +0000 (22:57 +0000)]
lp1779158 Inspect Queue Improvements

- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agolp1779158 Vandelay Authority Import Tweaks
Kyle Huckins [Tue, 27 Nov 2018 21:07:35 +0000 (21:07 +0000)]
lp1779158 Vandelay Authority Import Tweaks

- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1779158 Vandelay UI accessibilty/usability improvements
Bill Erickson [Tue, 4 Dec 2018 19:13:42 +0000 (14:13 -0500)]
LP#1779158 Vandelay UI accessibilty/usability improvements

* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1800481 Vandelay import form templates
Bill Erickson [Mon, 29 Oct 2018 16:31:26 +0000 (12:31 -0400)]
LP#1800481 Vandelay import form templates

Support saving MARC Import form values as named templates.  Values are
stored as (by defualt) workstation settings.  A template may be selected
as the default and templates may be deleted.

Includes release notes update angular vandelay.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1779158 Ang6 Vandelay Release Notes
Bill Erickson [Thu, 11 Oct 2018 19:47:58 +0000 (15:47 -0400)]
LP#1779158 Ang6 Vandelay Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1779158 Ang6 Vandelay UI Port
Bill Erickson [Thu, 28 Jun 2018 22:23:39 +0000 (18:23 -0400)]
LP#1779158 Ang6 Vandelay UI Port

Port of the MARC Import/Export UI from a Dojo-driven interface to a
Angular(6) interface.

Includes an additional UI called "Recent Imports" which displays
Vandelay session tracker information for both active sessions and those
within the selected time frame.  Active sessions are updated regularly
to display progress to the user.

Includes grid persist key workstation settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLp 1808580: Remove Installation Support for Ubuntu 14.04
Jason Stephenson [Fri, 14 Dec 2018 21:00:41 +0000 (16:00 -0500)]
Lp 1808580: Remove Installation Support for Ubuntu 14.04

Remove prerequisite installation on Ubuntu 14.04 "Trusty Tahr" from
Makefile.install and the edi_translator installation script.

Remove and/or update references to Ubuntu 14.04 Trusty Tahr to Ubuntu
18.04 Bionic Beaver in the server installation and upgrade documents.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
6 months agoLP#1802594: (follow-up) avoid a regression on "Copy" => "Item"
Galen Charlton [Mon, 18 Feb 2019 19:17:29 +0000 (14:17 -0500)]
LP#1802594: (follow-up) avoid a regression on "Copy" => "Item"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP1802594 - Splash Page Image Alt Text
Sam Link [Wed, 12 Dec 2018 16:35:20 +0000 (11:35 -0500)]
LP1802594 - Splash Page Image Alt Text

Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLp 1813290: Fix IAMBROWSER check in ac lineitem table.
Jason Stephenson [Sat, 9 Feb 2019 20:45:50 +0000 (15:45 -0500)]
Lp 1813290: Fix IAMBROWSER check in ac lineitem table.

Looks like commit e9a9875d added a check for IAMBROWSER that missed
the window.  This commit adds the window.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP1796225: Only auto-focus search on the home page
Jane Sandberg [Sat, 6 Oct 2018 12:52:09 +0000 (05:52 -0700)]
LP1796225: Only auto-focus search on the home page

For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.

To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages.  Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages.  Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog.  Notice that the
cursor still leaps to the search bar on this page only.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP1799963: Adjust fix to Staff Default Adv Search
Jason Boyer [Mon, 3 Dec 2018 18:23:39 +0000 (13:23 -0500)]
LP1799963: Adjust fix to Staff Default Adv Search

By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1799963 - fix catalog advanced search type default
Cesar Velez [Thu, 25 Oct 2018 21:54:42 +0000 (17:54 -0400)]
LP#1799963 - fix catalog advanced search type default

Since eg.search.adv_pane is now a server stored WS setting
it needed to be fetched with the proper way in order to work.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1806709: stamp schema update
Galen Charlton [Mon, 18 Feb 2019 18:37:00 +0000 (13:37 -0500)]
LP#1806709: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLp 1806709: Add circ.patron.billhistory_xacts persist key to database.
Jason Stephenson [Wed, 5 Dec 2018 19:55:30 +0000 (14:55 -0500)]
Lp 1806709: Add circ.patron.billhistory_xacts persist key to database.

We add the eg.grid.circ.patron.billhistory_xacts persist key to
config.workstation_setting_type in the database.

This is a follow-on to the LP1739606: Allow saving Billing History
xacts grid commit and should be applied to master and rel_3_2.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1726568: expose circ lib and owning lib fields to spine/pocket labels
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
6 months agoLP#1752665: suppress located URIs in holdings view
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view

To test:

[1] Locate or create a bibliographic record that has at least
    one located URI (e.g., an 856 with a $9 containing an org
    unit code)
[2] View the record in the Holdings View in the web staff interface,
    with the 'Show empty call numbers' (or volumes) option
    selected.
[3] Note that rows are displayed with a call number label of '##URI##';
    these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
    should not display.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1812733: stamp schema update
Galen Charlton [Mon, 18 Feb 2019 18:01:27 +0000 (13:01 -0500)]
LP#1812733: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1812733: put in correct version of actor.usr_delete()
Galen Charlton [Mon, 18 Feb 2019 17:57:48 +0000 (12:57 -0500)]
LP#1812733: put in correct version of actor.usr_delete()

This fixes an issue in the previous patch where second_given_name
would never have been NULLed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1812733 - Repair actor.usr_delete function.
Chris Sharp [Mon, 21 Jan 2019 18:50:17 +0000 (13:50 -0500)]
LP#1812733 - Repair actor.usr_delete function.

The Parent/Guardian feature altered the actor.usr_delete
function, but accidentally tries to update the "guardian"
field twice.  This fixes that problem.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 months agoStamping upgrade script
Mike Rylander [Wed, 13 Feb 2019 17:00:27 +0000 (12:00 -0500)]
Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 months agoLP1811156 Angular server admin grid settings
Bill Erickson [Thu, 24 Jan 2019 16:37:51 +0000 (11:37 -0500)]
LP1811156 Angular server admin grid settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 months agoLP1811156 Activate Angular server admin page
Bill Erickson [Wed, 9 Jan 2019 22:13:43 +0000 (17:13 -0500)]
LP1811156 Activate Angular server admin page

Point Admin -> Server Admin from AngJS and Angular navbars to the
Angular version of the server admin splash page.

Includes Angular auto-admin page sanity check for cases where a route
has no extra data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 months agoLP#1715767 - stamping upgrade scripts
Chris Sharp [Thu, 7 Feb 2019 22:40:15 +0000 (17:40 -0500)]
LP#1715767 - stamping upgrade scripts

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 months agoLP#1715767: remove privacy waiver entries when purging user data
Jeff Davis [Thu, 7 Feb 2019 19:38:47 +0000 (11:38 -0800)]
LP#1715767: remove privacy waiver entries when purging user data

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 months agoLP#1715767: remove privacy waiver entries when referenced actor.usr rows are deleted
Jeff Davis [Mon, 19 Nov 2018 23:53:00 +0000 (15:53 -0800)]
LP#1715767: remove privacy waiver entries when referenced actor.usr rows are deleted

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 months agoLP#1715767: Allow others to use my account (privacy waiver)
Jeff Davis [Wed, 7 Feb 2018 23:11:18 +0000 (15:11 -0800)]
LP#1715767: Allow others to use my account (privacy waiver)

Use case: Jane Doe has a hold ready for pickup but is unable to come
into the library.  Her husband John Doe goes to the library to pick up
the hold on her behalf.  His name is listed on Jane's account, so
library staff know it's okay to check out the book on Jane's account and
give it to John.

This commit adds a new table which lists the names of people who are
allowed to place holds, pick up holds, check out items, or view
borrowing history for a user account.  Staff can add, edit, or remove
entries via the patron editor in the web client; patrons can do so in My
Account.  The entries are not linked to other user accounts and they do
not add any extra functionality.  They are essentially special patron
notes for circulation staff.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 months agoLp 1805897: Add Release Note
Jason Stephenson [Tue, 5 Feb 2019 20:35:53 +0000 (15:35 -0500)]
Lp 1805897: Add Release Note

Signed-off-by: Jason Stephenson <jason@sigio.com>
7 months agoLp 1805897: Add Item Status to the Holdings of marc_export.in
Rogan Hamby [Thu, 29 Nov 2018 20:19:43 +0000 (15:19 -0500)]
Lp 1805897: Add Item Status to the Holdings of marc_export.in

Export status in the 852 subfield s when exporting items.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: John Yorio <jyorio@equinoxinitiative.org>
Signed-off-by: Steve Callender <stevecallender@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 months agoLP#1801984 Upgrading Angular 6 to Angular 7
Bill Erickson [Tue, 6 Nov 2018 19:08:42 +0000 (14:08 -0500)]
LP#1801984 Upgrading Angular 6 to Angular 7

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 months agoLP1783421 - Make Copy Alerts permission not global
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global

For some reason copy alerts require global permissions.  Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.

Signed-off-by: James Fournie <jfournie@vcc.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 months agoLP1809288 Angular Booking Admin release notes
Bill Erickson [Fri, 25 Jan 2019 17:27:42 +0000 (12:27 -0500)]
LP1809288 Angular Booking Admin release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP1809288 Stamping SQL upgrade for booking admin
Bill Erickson [Fri, 25 Jan 2019 17:10:14 +0000 (12:10 -0500)]
LP1809288 Stamping SQL upgrade for booking admin

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP1809288: Fix a small javascript error when value is undefined
Jane Sandberg [Fri, 4 Jan 2019 20:08:08 +0000 (12:08 -0800)]
LP1809288: Fix a small javascript error when value is undefined

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP1809288 Avoid booking grid prefix doubling
Bill Erickson [Thu, 3 Jan 2019 15:36:07 +0000 (10:36 -0500)]
LP1809288 Avoid booking grid prefix doubling

Teach the booking admin to avoid doubling up the grid prefix, which
would lead to grid settings with names like eg.grid.booking.booking.*

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agoLP1809288 Angular fm-editor read-only additions
Bill Erickson [Thu, 3 Jan 2019 15:17:42 +0000 (10:17 -0500)]
LP1809288 Angular fm-editor read-only additions

* Add read-only view to org-select
* FM editor displays read-only values as plain text
* Mark readOnly checkboxes "disabled"
* Link fields only fetch linked data when an IDL selector exists
* Minor code/style changes
** Define all class vars before class methods (ng-lint)
** Replace some tabs with spaces (ng-lint)
** Avoid unnecessary type defs with default values (ng-lint)
** More const goodness (ng-lint)
** camelCase some vars for consistentcy

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agoLP1809288: Make some brt fields read-only
Jane Sandberg [Sun, 30 Dec 2018 00:40:10 +0000 (16:40 -0800)]
LP1809288: Make some brt fields read-only

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP1809288: Add workstation grid settings for booking admin
Jane Sandberg [Sat, 29 Dec 2018 23:17:02 +0000 (15:17 -0800)]
LP1809288: Add workstation grid settings for booking admin

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP1809288: Port Booking Admin to Angular
Jane Sandberg [Thu, 20 Dec 2018 17:39:03 +0000 (11:39 -0600)]
LP1809288: Port Booking Admin to Angular

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP1808268 eg2 grid action disableOnRows sanity check
Bill Erickson [Wed, 23 Jan 2019 17:09:18 +0000 (12:09 -0500)]
LP1808268 eg2 grid action disableOnRows sanity check

The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values.  This commit changes it to
a more generic if() test to cover null/undefined.  Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.

Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP#1808268 eg2 grid rename action disable option
Bill Erickson [Mon, 17 Dec 2018 15:56:36 +0000 (10:56 -0500)]
LP#1808268 eg2 grid rename action disable option

Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agoLP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2
Jane Sandberg [Fri, 14 Dec 2018 04:50:15 +0000 (20:50 -0800)]
LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2

To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2.  Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoForward-port 3.2.3 upgrade script
Dan Wells [Tue, 22 Jan 2019 19:33:08 +0000 (14:33 -0500)]
Forward-port 3.2.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 months agoForward-port 3.1.9 upgrade script
Dan Wells [Tue, 22 Jan 2019 19:32:45 +0000 (14:32 -0500)]
Forward-port 3.1.9 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 months agoLP#1727345 - fix bibsource when importing or overlaying
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying

This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.

Two paths to test:
Path A)
    1. Import a new bib record from z3950, but via "Edit then Import"
    2. Bring up marc editor and choose save w/ bib source.
    3. Verify chosen bib source saved correctly on record page.
Path B)
    1. Mark a record as target for Overlay, go to z3950 import.
    2. Make a search, select item for Overlay.
    3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
    4. Verify chosen bib source saved correctly on record page.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agoLP#1812698 - stamping upgrade script
Ben Shum [Mon, 21 Jan 2019 17:00:13 +0000 (12:00 -0500)]
LP#1812698 - stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>