10 years agoavoid multiple clicks of selfcheck logout link
gmc [Mon, 27 Sep 2010 01:43:12 +0000 (01:43 +0000)]
avoid multiple clicks of selfcheck logout link

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18021 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agohonor SIP return date as the circ backdate
erickson [Sun, 26 Sep 2010 23:20:12 +0000 (23:20 +0000)]
honor SIP return date as the circ backdate

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18017 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agono need to warn when emails may just be disabled
erickson [Sun, 26 Sep 2010 23:20:11 +0000 (23:20 +0000)]
no need to warn when emails may just be disabled

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18016 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agopush copy location order update into ML method. return updated orders from method...
erickson [Sun, 26 Sep 2010 23:20:10 +0000 (23:20 +0000)]
push copy location order update into ML method.  return updated orders from method to prevent replication issues.  update UI JS to match

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18015 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove a debugging statement that slipped in
dbs [Sun, 26 Sep 2010 18:34:47 +0000 (18:34 +0000)]
Remove a debugging statement that slipped in

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18013 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded missing columns to CDBI table definitions
gmc [Sun, 26 Sep 2010 16:26:21 +0000 (16:26 +0000)]
added missing columns to CDBI table definitions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18011 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoOnly show facetOrder limited facets that have values
miker [Sun, 26 Sep 2010 15:53:21 +0000 (15:53 +0000)]
Only show facetOrder limited facets that have values

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18009 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoallow more complex facet ordering
miker [Sun, 26 Sep 2010 15:31:41 +0000 (15:31 +0000)]
allow more complex facet ordering

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18007 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agounmark record for overlay after it is overlaid
phasefx [Sun, 26 Sep 2010 10:29:36 +0000 (10:29 +0000)]
unmark record for overlay after it is overlaid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18006 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake the MARC editor optional with Z39.50
phasefx [Sun, 26 Sep 2010 10:02:38 +0000 (10:02 +0000)]
make the MARC editor optional with Z39.50

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18005 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCall persist_helper() in most interfaces. Give it the ability to handle resizing...
phasefx [Sun, 26 Sep 2010 09:23:43 +0000 (09:23 +0000)]
Call persist_helper() in most interfaces.  Give it the ability to handle resizing windows and set some windows up so that their height, width, and maximized state persist

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18004 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake all the splitters sticky with oils_persist
phasefx [Sun, 26 Sep 2010 08:06:33 +0000 (08:06 +0000)]
make all the splitters sticky with oils_persist

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18003 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake the splitters in the z39.50 interface sticky
phasefx [Sun, 26 Sep 2010 07:05:58 +0000 (07:05 +0000)]
make the splitters in the z39.50 interface sticky

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18002 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoShow cover art in Z39.50 client. I'm slow, so it only hit me this year that we can...
phasefx [Sun, 26 Sep 2010 06:34:22 +0000 (06:34 +0000)]
Show cover art in Z39.50 client.  I'm slow, so it only hit me this year that we can show added content for material not actually in the catalog yet

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18001 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomake address_type required in the patron editor, otherwise a blank value sends a...
phasefx [Sun, 26 Sep 2010 03:17:05 +0000 (03:17 +0000)]
make address_type required in the patron editor, otherwise a blank value sends a null to the db where it silently fails

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17999 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomore selfcheck receipt transaction hackery
gmc [Sun, 26 Sep 2010 02:49:39 +0000 (02:49 +0000)]
more selfcheck receipt transaction hackery

Instead of having authoritative versions of
open-ils.circ.fire_*_trigger_events, wrap just the
target retrieval itself in a transaction.  Avoids as
yet unexplained rollback failure that occurs if
processing a selfcheck receipt with more than a few items on it.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17997 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodon't leak cstores if CStoreEditor rollback fails
gmc [Sun, 26 Sep 2010 02:42:50 +0000 (02:42 +0000)]
don't leak cstores if CStoreEditor rollback fails

Patch by Mike Rylander.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17995 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoonly need to wrap event retrieve in xact for latest copy. otherwise, run the risk...
erickson [Sat, 25 Sep 2010 04:09:57 +0000 (04:09 +0000)]
only need to wrap event retrieve in xact for latest copy.  otherwise, run the risk of xact-ed cstore timing out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17994 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix misplaced paranoia
senator [Sat, 25 Sep 2010 03:54:09 +0000 (03:54 +0000)]
fix misplaced paranoia

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17992 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agono need to start a xact in the holds pull list. really long lists can results in...
erickson [Sat, 25 Sep 2010 03:46:03 +0000 (03:46 +0000)]
no need to start a xact in the holds pull list.  really long lists can results in sending a rollback on a timed-out cstore handle, resulting in errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17991 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHow did this get lost? PermaCrud authoritative might work now?
senator [Sat, 25 Sep 2010 03:45:21 +0000 (03:45 +0000)]
How did this get lost? PermaCrud authoritative might work now?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17989 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoevents don't have granularity's. removing
erickson [Sat, 25 Sep 2010 03:27:20 +0000 (03:27 +0000)]
events don't have granularity's.  removing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17987 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoparanoia
senator [Sat, 25 Sep 2010 01:13:31 +0000 (01:13 +0000)]

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17985 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agopedantic protection of cstore backends -- always use die_event when in xact mode...
miker [Sat, 25 Sep 2010 00:58:35 +0000 (00:58 +0000)]
pedantic protection of cstore backends -- always use die_event when in xact mode, and rollback otherwise

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17984 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoMaybe not abandon poor little cstore so much.
senator [Sat, 25 Sep 2010 00:56:24 +0000 (00:56 +0000)]
Maybe not abandon poor little cstore so much.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17982 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomore transaction cleanups
erickson [Fri, 24 Sep 2010 23:04:45 +0000 (23:04 +0000)]
more transaction cleanups

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17980 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoclean up the fire_object_events cstore xact
erickson [Fri, 24 Sep 2010 22:23:58 +0000 (22:23 +0000)]
clean up the fire_object_events cstore xact

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17978 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove confusing older targeter version; move status trimming to earlier in the process
miker [Fri, 24 Sep 2010 20:29:43 +0000 (20:29 +0000)]
Remove confusing older targeter version; move status trimming to earlier in the process

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17976 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFix an autogrid create dialog of the kind that gets big, unusable and jumpy
senator [Fri, 24 Sep 2010 20:11:12 +0000 (20:11 +0000)]
Fix an autogrid create dialog of the kind that gets big, unusable and jumpy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17974 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoremoved extra {}'s from where clause
erickson [Fri, 24 Sep 2010 19:30:10 +0000 (19:30 +0000)]
removed extra {}'s from where clause

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17972 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agospawn item attribute editor instead of item notes UI during process missing pieces...
phasefx [Fri, 24 Sep 2010 18:23:10 +0000 (18:23 +0000)]
spawn item attribute editor instead of item notes UI during process missing pieces workflow

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17965 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocut-n-paste-o ... removing bad "my"
miker [Fri, 24 Sep 2010 18:08:05 +0000 (18:08 +0000)]
cut-n-paste-o ... removing bad "my"

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17963 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodon't styled the juvenile indicator in the patron display based on age calculations...
phasefx [Fri, 24 Sep 2010 18:04:59 +0000 (18:04 +0000)]
don't styled the juvenile indicator in the patron display based on age calculations by default, just go by the juvenile flag on the user.  local CSS can restore the behavior if desired

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17958 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoput the frozen (and also empty issuance or last-copy-removed) check back in as a...
miker [Fri, 24 Sep 2010 17:56:31 +0000 (17:56 +0000)]
put the frozen (and also empty issuance or last-copy-removed) check back in as a conditional select if we found nothing mapped

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17957 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoexcise the no-potentials check, should only effect frozen holds
miker [Fri, 24 Sep 2010 17:45:49 +0000 (17:45 +0000)]
excise the no-potentials check, should only effect frozen holds

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17956 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoimprove hold targetting
gmc [Fri, 24 Sep 2010 16:37:23 +0000 (16:37 +0000)]
improve hold targetting

* all potential capturable copies are now checked (up to the first
  one that is permitted for the request), instead of a small random
  subset of them
* don't do redundant permission checks

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17954 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agothis call returns an array; fixes surprise stat cats in patron display
phasefx [Fri, 24 Sep 2010 05:48:39 +0000 (05:48 +0000)]
this call returns an array; fixes surprise stat cats in patron display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17952 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBe more tolerant of long-running A/T event handling for holds pull list printing
senator [Fri, 24 Sep 2010 04:45:42 +0000 (04:45 +0000)]
Be more tolerant of long-running A/T event handling for holds pull list printing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17950 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoWe're starting to get events where ilsevent == empty string now, not just null or...
phasefx [Fri, 24 Sep 2010 02:36:55 +0000 (02:36 +0000)]
We're starting to get events where ilsevent == empty string now, not just null or a number.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17948 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agouse _session_request in RO calls
miker [Fri, 24 Sep 2010 01:47:06 +0000 (01:47 +0000)]
use _session_request in RO calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17946 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agocorrect the comment
miker [Fri, 24 Sep 2010 01:46:41 +0000 (01:46 +0000)]
correct the comment

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17945 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoApply some fixes that were earlier applied to the base installation script
scottmk [Fri, 24 Sep 2010 00:56:21 +0000 (00:56 +0000)]
Apply some fixes that were earlier applied to the base installation script
090.schema.action.sql, but not in an upgrade script.

Also: correct a typo (INTEVAL -> INTERVAL).  Hence this upgrade needs to go
to v2.0 as well as to trunk.

M    Open-ILS/src/sql/Pg/090.schema.action.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0418.function.action.fix-purge-circ.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17944 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRe-commit miker's PermaCrud changes, just a tad more nicer ;-)
senator [Fri, 24 Sep 2010 00:15:31 +0000 (00:15 +0000)]
Re-commit miker's PermaCrud changes, just a tad more nicer ;-)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17941 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoStopping the leak (let us try this again)
miker [Thu, 23 Sep 2010 23:49:26 +0000 (23:49 +0000)]
Stopping the leak (let us try this again)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17939 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoreverting previous. sorry, folks
miker [Thu, 23 Sep 2010 23:47:49 +0000 (23:47 +0000)]
reverting previous. sorry, folks

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17938 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoStopping the leak
miker [Thu, 23 Sep 2010 23:38:10 +0000 (23:38 +0000)]
Stopping the leak

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17937 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoI can has authoritative for selfcheck receipts
erickson [Thu, 23 Sep 2010 23:01:06 +0000 (23:01 +0000)]
I can has authoritative for selfcheck receipts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17935 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIE hates the dangling comma (sometimes).
senator [Thu, 23 Sep 2010 20:59:13 +0000 (20:59 +0000)]
IE hates the dangling comma (sometimes).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17933 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agorepaired search call for user_setting. cstoreeditor uses the fieldmapper name, sos...
erickson [Thu, 23 Sep 2010 20:47:47 +0000 (20:47 +0000)]
repaired search call for user_setting. cstoreeditor uses the fieldmapper name, sos/usr/user/

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17931 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoesolving various discrepancies between a freshly built 2.0
scottmk [Thu, 23 Sep 2010 18:58:36 +0000 (18:58 +0000)]
esolving various discrepancies between a freshly built 2.0
database and an upgraded one.

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17929 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agodisable holds Detail View button until the asynchronously loading details UI is ready
phasefx [Thu, 23 Sep 2010 16:35:20 +0000 (16:35 +0000)]
disable holds Detail View button until the asynchronously loading details UI is ready

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17927 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward-port of a patch from Steve Callendar, via James Fournie, via launchpad:
miker [Thu, 23 Sep 2010 15:38:46 +0000 (15:38 +0000)]
Forward-port of a patch from Steve Callendar, via James Fournie, via launchpad:

When the patron.password.use_phone is set, new patrons are created with their password set to the last 4 digits of their phone number, HOWEVER, when a patron's password is reset, it does not work properly. Although the little underlined summary shows the proper 4 digits, the password box displays 9-ish digits, and is not the last 4 digits of the password.

The attached patch was created by Steve Callender and is confirmed working on 1.6.0

ORIGINAL CAVEAT: This patch will not work on 2.0 as that has a new user editor, but it would presumably be worthwhile to verify this functionality works in that editor as well.

ED NOTE: Because it is possible to use the old editor -- it still exists -- this patch should be applied.  It does what it advertises to do, which is fix the old editor to follow the "use phone number" OU setting.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17922 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDrop the never-used column item_count from acq.lineitem.
scottmk [Thu, 23 Sep 2010 15:22:29 +0000 (15:22 +0000)]
Drop the never-used column item_count from acq.lineitem.
Drop it also from the associated history table, and rebuild
the function that maintains it.  Finally, rebuild the
associated lifecycle view.

Apply to trunk only; this column never existed in 2.0.
The column has already been removed from the base installation

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0417.schema.acq.drop-lineitem-item-count.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17918 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRename a couple of indexes (recuring -> recurring)
scottmk [Thu, 23 Sep 2010 14:31:32 +0000 (14:31 +0000)]
Rename a couple of indexes (recuring -> recurring)

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0416.schema.rename-recuring-idx.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17917 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDropping and recreating a foreign key constraint for config.metabib_field,
scottmk [Thu, 23 Sep 2010 13:45:06 +0000 (13:45 +0000)]
Dropping and recreating a foreign key constraint for config.metabib_field,
in order to change its name.  WHen this foreign key was first introduced,
the upgrade script gave it one name and the base install script gave it
a different name.  Here we bring the names into sync.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0415.schema.rename-field-class-fkey.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17915 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofetch last updated event before comitting to stay in the xact
erickson [Thu, 23 Sep 2010 07:17:00 +0000 (07:17 +0000)]
fetch last updated event before comitting to stay in the xact

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17914 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoevent firing util code needs to run in a xact
erickson [Thu, 23 Sep 2010 05:31:03 +0000 (05:31 +0000)]
event firing util code needs to run in a xact

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17913 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHave the CStoreEditor grow a DESTROY
miker [Thu, 23 Sep 2010 04:33:39 +0000 (04:33 +0000)]
Have the CStoreEditor grow a DESTROY

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17912 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove most annoying UI "feature" of the new authority browse list interface
dbs [Thu, 23 Sep 2010 03:45:16 +0000 (03:45 +0000)]
Remove most annoying UI "feature" of the new authority browse list interface

When I added the new authority browse list interface, I used dojo.xhrGet()
to retrieve records from the authority browse backend - but because I didn't
specify sync:true, when you first right-clicked on a subfield, the function
would return immediately and default to showing the context menu. You would
then need to click two more times to show the authority list.

Now you get it on your first right-click, as it should be.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17910 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoBrowse through 20 authority records at a time in management interface
dbs [Thu, 23 Sep 2010 03:18:14 +0000 (03:18 +0000)]
Browse through 20 authority records at a time in management interface

The default browse list is set to 9 elements, but we have enough vertical
space to make use of more. Perhaps we should check the font size and
viewport height and then adjust accordingly, but that would be Hard.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17908 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoRemove most UI annoyances from authority management interface
dbs [Thu, 23 Sep 2010 03:09:19 +0000 (03:09 +0000)]
Remove most UI annoyances from authority management interface

  * term input field now gets the focus automatically
  * pressing enter in most places submits a new search
  * removed the onBlur event as that required users to click a second
    time to open the action menu

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17906 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUse a transaction to avoid talking to a replicated db when building A/T data structures
miker [Thu, 23 Sep 2010 02:49:36 +0000 (02:49 +0000)]
Use a transaction to avoid talking to a replicated db when building A/T data structures

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17905 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoonly flesh up to, but not including, the leaf for the group_field
miker [Thu, 23 Sep 2010 02:12:02 +0000 (02:12 +0000)]
only flesh up to, but not including, the leaf for the group_field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17903 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAnother IDL chunking fix for web/templates-based interfaces
senator [Thu, 23 Sep 2010 00:34:22 +0000 (00:34 +0000)]
Another IDL chunking fix for web/templates-based interfaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17901 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHopefully fix a holds list sorting issue that only manifested when printing.
senator [Thu, 23 Sep 2010 00:14:03 +0000 (00:14 +0000)]
Hopefully fix a holds list sorting issue that only manifested when printing.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17899 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoset label printer context for label printing
phasefx [Wed, 22 Sep 2010 20:01:59 +0000 (20:01 +0000)]
set label printer context for label printing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17897 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofix from tsbere to handle case where the print strategy is set to custom/external...
phasefx [Wed, 22 Sep 2010 20:01:55 +0000 (20:01 +0000)]
fix from tsbere to handle case where the print strategy is set to custom/external but the actual command is missing (perhaps due to xulrunner upgrades?)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17896 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agofixes a bug in Item Status -> Alternate View when the item being viewed has no circ...
phasefx [Wed, 22 Sep 2010 19:37:43 +0000 (19:37 +0000)]
fixes a bug in Item Status -> Alternate View when the item being viewed has no circ modifier

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17894 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHoldings Maintenance used to make too many assumptions about what a decent org hierar...
phasefx [Wed, 22 Sep 2010 19:31:07 +0000 (19:31 +0000)]
Holdings Maintenance used to make too many assumptions about what a decent org hierarchy looked like, and had these rules to suppress some of the fetch-render-happy behavior that existed when clicking on org units.  We can remove them now, and this allows volumes to render when owned by the top of the org tree

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17892 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdding a trigger. Upgrade # 0364 created the trigger function but not
scottmk [Wed, 22 Sep 2010 19:16:26 +0000 (19:16 +0000)]
Adding a trigger.  Upgrade # 0364 created the trigger function but not
the trigger itself.  However the base install script 040.schema.asset.sql
creates both the function and the trigger.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0414.schema.call-number-upd-ins-trigger.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17891 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoFor action.circulation and action.aged_circulation: add indexes
scottmk [Wed, 22 Sep 2010 15:59:06 +0000 (15:59 +0000)]
For action.circulation and action.aged_circulation: add indexes
on the target_copy column.

This change was made in upgrade script # 0017, but was apparently
never applied to the base install script.

M    Open-ILS/src/sql/Pg/090.schema.action.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17889 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoIn acq.fund_transfer: drop the NOT NULL constraint from dest_fund and
scottmk [Wed, 22 Sep 2010 12:55:28 +0000 (12:55 +0000)]
In acq.fund_transfer: drop the NOT NULL constraint from dest_fund and
dest_amount, in order to accommodate deallocations -- where we move
money out of a fund without moving it into another fund.

This change was applied via upgrade script # 0135, but apparently was
never applied to the base installation script.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17886 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoForward port r17847: Make query parser a bit more careful when converting convenience...
dbs [Wed, 22 Sep 2010 02:12:32 +0000 (02:12 +0000)]
Forward port r17847: Make query parser a bit more careful when converting convenience classes to search classes

Queries like "Heart disease: a global problem" were getting converted to series searches
due to the trailing "se:" in the search terms. This change ensures that the convenience
class is either at the start of the input or preceded by whitespace.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17883 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agohandle null as a return result for an empty list
phasefx [Wed, 22 Sep 2010 01:03:19 +0000 (01:03 +0000)]
handle null as a return result for an empty list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17881 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agouse fieldmapper.standardRequest here for easier configuration of the network timeout...
phasefx [Wed, 22 Sep 2010 00:55:55 +0000 (00:55 +0000)]
use fieldmapper.standardRequest here for easier configuration of the network timeout (the full pull list can take a while to return)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17879 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoReplace some changes that had inadvertently been deleted
scottmk [Tue, 21 Sep 2010 19:08:54 +0000 (19:08 +0000)]
Replace some changes that had inadvertently been deleted

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17877 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDon't make new auditor columns NOT NULL, or update them
scottmk [Tue, 21 Sep 2010 18:31:55 +0000 (18:31 +0000)]
Don't make new auditor columns NOT NULL, or update them

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17875 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoDon't update history tables to fill in new NOT NULL columns
scottmk [Tue, 21 Sep 2010 18:16:51 +0000 (18:16 +0000)]
Don't update history tables to fill in new NOT NULL columns

M    Open-ILS/src/sql/Pg/upgrade/0413.schema.upgrade-auditor-tables.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17873 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoResolve some discrepancies in the auditor schema between a freshly installed
scottmk [Tue, 21 Sep 2010 17:47:53 +0000 (17:47 +0000)]
Resolve some discrepancies in the auditor schema between a freshly installed
database and an upgraded one.

A    Open-ILS/src/sql/Pg/upgrade/0413.schema.upgrade-auditor-tables.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17872 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agooffline printer role
phasefx [Tue, 21 Sep 2010 17:02:52 +0000 (17:02 +0000)]
offline printer role

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17869 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHoldIsCancelled action_trigger validator
phasefx [Tue, 21 Sep 2010 16:19:04 +0000 (16:19 +0000)]
HoldIsCancelled action_trigger validator

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17867 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCorrect various discrepancies, especially in the auditor schema,
scottmk [Tue, 21 Sep 2010 15:40:23 +0000 (15:40 +0000)]
Correct various discrepancies, especially in the auditor schema,
between a freshly installed 2.0 database and an upgraded one.

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17866 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoyet another bib ingest knob
gmc [Tue, 21 Sep 2010 14:19:31 +0000 (14:19 +0000)]
yet another bib ingest knob

When enabled, the ingest.assume_inserts_only flag disables
checking several tables for old index data to delete; skipping this
makes a small but noticeable difference when doing an initial bib
ingest with more than one process in parallel.

Note that this flag should not be used when *re*ingesting records
unless you clear the old rows beforehand.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17863 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd ingest.metarecord_mapping.skip_on_update internal flag
gmc [Tue, 21 Sep 2010 04:46:52 +0000 (04:46 +0000)]
add ingest.metarecord_mapping.skip_on_update internal flag

Enabling this allows bibliographic reingests (for new/changed indexes
or after data changes that don't affect the fingerprint) to be run
in parallel without lock contention on metarecord.metarecord* operations.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17862 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoClean up description of ARN in O:A:Cat::Authority now that arn_value is gone
dbs [Tue, 21 Sep 2010 03:54:26 +0000 (03:54 +0000)]
Clean up description of ARN in O:A:Cat::Authority now that arn_value is gone

A comment in the create_authority_record_from_bib_field() method stated that
the ARN value needed to be unique across the database; that is no longer true
as of r17722. Fix comment accordingly.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17860 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoCreate and edit... authority record now gets $0 control subfield auto-applied
dbs [Tue, 21 Sep 2010 03:44:35 +0000 (03:44 +0000)]
Create and edit... authority record now gets $0 control subfield auto-applied

Following on r17857, when you create an authority record in the flow using
the "Create and edit..." option, a $0 control subfield will automatically
be appended to the target field once "Save Record" is clicked on the authority
record editor pane. Non-savers of the bib record beware! Also subject to
interesting effects of the bib editor tab gets destroyed before the auth
record is created via the Save Record button.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17858 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAppend the $0 controlling subfield to newly created authorities
dbs [Tue, 21 Sep 2010 03:25:05 +0000 (03:25 +0000)]
Append the $0 controlling subfield to newly created authorities

Still a work in progress; obviously we need to try and grab a better
institutional code, need to teach the "Create and edit..." option
how to do the same thing, and should augment the "Authority created"
dialog box to tell the user to save the record or lose the changes
they just made.

At some point we need to consider auto-saving records, perhaps immediately
after we provide infinite undo capability to step back through previous

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17857 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoUse verbose parameters for createdb
dbs [Tue, 21 Sep 2010 03:05:48 +0000 (03:05 +0000)]
Use verbose parameters for createdb

Thomas Berezansky noticed that the README was using "createdb -t template0",
which isn't a valid option.  To avoid case problems and to be more apparent
what these options mean, let's use the verbose parameters.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17855 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoHow about one more permission check for serials here? Need more comprehensive
senator [Mon, 20 Sep 2010 22:47:35 +0000 (22:47 +0000)]
How about one more permission check for serials here? Need more comprehensive
review of this later.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17853 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadd missing upgrade script for maintain_901() stored function
gmc [Mon, 20 Sep 2010 20:58:02 +0000 (20:58 +0000)]
add missing upgrade script for maintain_901() stored function

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17850 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoThe serials perms that were missing from the DB.
senator [Mon, 20 Sep 2010 20:40:23 +0000 (20:40 +0000)]
The serials perms that were missing from the DB.

Later it'd be better to make these more a) comprehensive and b) elegant.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17848 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoadded pgpt class to pre-load set
erickson [Mon, 20 Sep 2010 18:23:56 +0000 (18:23 +0000)]
added pgpt class to pre-load set

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17844 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoResolving various discrepancies between an upgraded 2.0 database
scottmk [Mon, 20 Sep 2010 18:07:01 +0000 (18:07 +0000)]
Resolving various discrepancies between an upgraded 2.0 database
and a freshly installed one.

M    Open-ILS/src/sql/Pg/1.6.1-2.0-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17843 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSo I don't have to worry about fixing this misspelling later.
senator [Mon, 20 Sep 2010 17:52:35 +0000 (17:52 +0000)]
So I don't have to worry about fixing this misspelling later.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17840 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoChange behavior of stat cat display in horizontal patron summary. Stat Cat tab shows...
phasefx [Mon, 20 Sep 2010 17:31:51 +0000 (17:31 +0000)]
Change behavior of stat cat display in horizontal patron summary.  Stat Cat tab shows all patron.stat_cat_entries.  Entries with usr_summary true also get shown in the Patron Info pane, underneath Email

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17838 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoaddd missing opac_visible col and labels to config.usr_setting_type
erickson [Mon, 20 Sep 2010 17:09:23 +0000 (17:09 +0000)]
addd missing opac_visible col and labels to config.usr_setting_type

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17836 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agomarc_add_ids - better failure recovery
gmc [Mon, 20 Sep 2010 08:27:59 +0000 (08:27 +0000)]
marc_add_ids - better failure recovery

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17833 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAdd a miniwizard for serials holding codes in the AutoGrid based interfaces,
senator [Mon, 20 Sep 2010 07:29:58 +0000 (07:29 +0000)]
Add a miniwizard for serials holding codes in the AutoGrid based interfaces,
sparing the user from needed to input MARC breaker.

    Don't assume we always start with 4,1,8,1
    auto-populate chronlogy caption fields based on date (this should be easy)
    make it work in a tooltipdialog? (or don't, it seems frustrating)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17831 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoAcq: change a FilteringSelect dijit to a regular <select> to avoid a
senator [Mon, 20 Sep 2010 05:05:00 +0000 (05:05 +0000)]
Acq: change a FilteringSelect dijit to a regular <select> to avoid a
manifestation  of Dojo bug #11062; add more refresh grid buttons to unified

"Refresh Grid" buttons are a sad little stopgap measure to address a problem
where some AutoGrids show only some of the rows they're supposed to. Calling
.refresh() on the AutoGrid consitently right the grid.  Maybe the problem
is some kind of race condition, and maybe it's related to the use of "get"
and "formatter" attributes for some columns.  Or maybe it's something else.
Attempts continue to find the root of the problem and repair it.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17829 dcc99617-32d9-48b4-a31d-7c20da2025e4

10 years agoSearch for humans: AND and OR are more understandable than "&&" and "||"
dbs [Mon, 20 Sep 2010 04:33:09 +0000 (04:33 +0000)]
Search for humans: AND and OR are more understandable than "&&" and "||"

The operators && and || will not mean much to many people, whereas AND and
OR have common meanings that will aid in understanding the advanced search

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17827 dcc99617-32d9-48b4-a31d-7c20da2025e4