Evergreen.git
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen-DocBook into doc_consolidati...
Dan Scott [Wed, 23 May 2012 20:16:58 +0000 (16:16 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen-DocBook into doc_consolidation_master

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into doc_consolidation_master
Dan Scott [Wed, 23 May 2012 20:16:38 +0000 (16:16 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into doc_consolidation_master

9 years agoTPAC: recover the ability to override hold placement failures
Bill Erickson [Tue, 22 May 2012 20:22:14 +0000 (16:22 -0400)]
TPAC: recover the ability to override hold placement failures

There is a certain class of hold failure events (e.g. HOLD_EXISTS,
HOLD_ITEM_CHECKED_OUT) that can be overridden by patrons when they have
the correct override permission.  This change recovers that ability,
which was recently removed with 99e8fc893a.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUpdate upgrade instructions to release candidate 1.
rsoulliere [Wed, 23 May 2012 11:50:05 +0000 (07:50 -0400)]
Update upgrade instructions to release candidate 1.

9 years agostamping upgrade script for saved queries
Mike Rylander [Tue, 22 May 2012 19:10:14 +0000 (15:10 -0400)]
stamping upgrade script for saved queries

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoTPAC: Search Filter Groups
Bill Erickson [Thu, 23 Feb 2012 22:01:28 +0000 (17:01 -0500)]
TPAC: Search Filter Groups

Adds support for a new CGI param:

fg:<filter_group_code>=filter_group_entry

Each filter group entry will be mapped to a filter_group_entry()
filter and appended to the current search query.

This includes a new filter selector builder at
parts/filter_group_selector.tt2.

Usage, assuming a filter_group with code "audience":

<span>[% ctx.filter_groups.audience.label %]<span>
<span>
[%
    INCLUDE 'opac/parts/filter_group_selector.tt2'
    filter_group=audience
    none_ok=1
%]
<span>

The set of filter groups available to the TPAC are those defined at the
search org unit and its ancestors.  If multiple filters have the same
code name, the filter owned closest to the context org unit is used.
This allows for global filters with local overrides.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agotpac : search_HINT cache fixes
Bill Erickson [Wed, 18 Apr 2012 20:15:46 +0000 (16:15 -0400)]
tpac : search_HINT cache fixes

When searching for multiple values like a list of IDs, generate the
cache key from the sorted JSON form of the search value instead of the
bare ARRAY ref.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoNew QueryParser filter_group_entry filter
Bill Erickson [Thu, 19 Apr 2012 17:54:34 +0000 (13:54 -0400)]
New QueryParser filter_group_entry filter

filter_group_entry() takes one or more filter_group_entry IDs as
parameters and applies the included sub-searches as filters on the
current search.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoGive the PG QP driver a subquery callback for the new saved_query() filter
Mike Rylander [Wed, 18 Apr 2012 17:25:06 +0000 (13:25 -0400)]
Give the PG QP driver a subquery callback for the new saved_query() filter

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTeach QueryParser about search filter callbacks, and if a callback returns a value...
Mike Rylander [Wed, 18 Apr 2012 17:24:24 +0000 (13:24 -0400)]
Teach QueryParser about search filter callbacks, and if a callback returns a value, parse it at the current recursion level

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoSearch Filter Groups and Generic Queries : DB / IDL
Bill Erickson [Thu, 23 Feb 2012 19:28:50 +0000 (14:28 -0500)]
Search Filter Groups and Generic Queries : DB / IDL

Adds 3 new tables.  The first is a general purpose container for
query-parser queries.  These can be used by other entities for storing
saved searches, saved search filters, etc.  Each contains a query string
and a label.

The two other tables are for creating org unit saved search filter
groups.  A filter group is a named set of search queries, treated as
filters, collected to create a high-level search filter.  Filter group
entries use search_query's under the covers, so the content of the
filter can be any valid query string, including other filters or even
other filter groups.

For example, you could create an "Audience" filter group with entries
like, "Children" => "audience(a, b) locations(3,4,5)" to filter on copy
location in addition to the MARC audience data.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoQuery Parser merged copy / non-dynamic filters
Bill Erickson [Mon, 21 May 2012 14:32:56 +0000 (10:32 -0400)]
Query Parser merged copy / non-dynamic filters

When more than one copy-level filter (e.g. locations()) is used in a
query-parser query, all but the first are ignored.  The goal of this
work is to compress multiple copy-level filters into a single filter
that represents the full collection.  Wherever possible, boolean
structures will be honored, to the extent possible for post-search
copy-level filters.

Examples:

concerto locations(1,2) locations(3,4)

==> concerto locations(1,2,3,4)

( concerto locations(3,4,5) ) || (piano locations(3,5,7) )

==> ( concerto || piano ) locations(3,4,5,6,7)

( concerto locations(3,4,5) ) && ( piano locations(3,5,7) )

==> concerto piano locations(3,5)

Note, in the last 2 examples, the final query does not exactly match the
original.  This is because copy-level filters are applied after the
initial search and cannot be executed as part of the  nested query.  The
best we can do is create a representation of the final copy-level
filter, based on the nesting, and apply it to the final result of the
nested search.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoQuery Parser nested dynamic filters
Bill Erickson [Tue, 15 May 2012 22:00:30 +0000 (18:00 -0400)]
Query Parser nested dynamic filters

Dynamic filters (from metabib.record_attr) are now parsed along with
search strings and facets as Query Parser descends the parse tree.  The
WHERE clause for the query as a whole is now a combination of the main
WHERE and the ON clause for JOINing to metabib.record_attr.  This gives
us the ability to create complex boolean nested queries using
SVF/record_attr filters, unlike before where nested filters were either
ignored or always treated as global filters.

For example:

concerto && ( ( item_type(a) subject|topic[Music] ) || item_form(a) )

This query now successfully limits the "concerto" search to results that
have either (item_type(a) AND subject|topic[Music]) OR item_form(a).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoQueryParser test script
Bill Erickson [Tue, 15 May 2012 21:59:56 +0000 (17:59 -0400)]
QueryParser test script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUse spaces instead of tabs in QueryParser.pm
Dan Scott [Mon, 21 May 2012 19:09:59 +0000 (15:09 -0400)]
Use spaces instead of tabs in QueryParser.pm

Copying swathes of SQL from logs into psql would often trigger the
autocompletion that psql offers, garbling a query awfully. Define the
local $spc var as two spaces and use that instead, leaving open the
option for reverting to tabs or anything else people prefer.

Also remove trailing whitespace, as this whole thing is about space.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoMakes a warning go away when running fts-replacement.pl, but may have...
Lebbeous Fogle-Weekley [Mon, 21 May 2012 18:22:40 +0000 (14:22 -0400)]
Makes a warning go away when running fts-replacement.pl, but may have...

...consequences.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoFix typo in TEST_SETUP for QueryParser.pm
Dan Scott [Mon, 21 May 2012 18:02:11 +0000 (14:02 -0400)]
Fix typo in TEST_SETUP for QueryParser.pm

"author|coporate" doesn't exist, probably doesn't matter much in
principle but is worthwhile getting rid of the distraction.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoabstract query representations from QueryParser
Mike Rylander [Thu, 29 Dec 2011 16:36:20 +0000 (11:36 -0500)]
abstract query representations from QueryParser

When you perform a search, you now also get back an abstract
representation of your search query.  fts-replacement.pl is a test
script that shows you things that QueryParser does, including the new
abstract query feature, and it also reconstitutes a string from the
abstract query to demonstrate the correctness of that query.

[Also]
Make last-wins true for facets, filters and modifiers -- arg!; Parameterized values win in the staged-search QP wrapper

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoQueryParser: comma-delimit multiple WITH clauses
Dan Scott [Mon, 21 May 2012 18:46:53 +0000 (14:46 -0400)]
QueryParser: comma-delimit multiple WITH clauses

Bill Erickson's fix for my breakage of QueryParser.pm for the speedup
via the WITH common table expression usage inadvertently left out
the commas required to delimit multiple WITH clauses, resulting in SQL
query errors.

This fixes that oversight. Note that the fts-replacement.pl script came
in quite handy for testing this; recommended.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd libnet-https-any-perl as precise deb requirement in Makefile.install.
Jason Stephenson [Sat, 19 May 2012 02:51:14 +0000 (22:51 -0400)]
Add libnet-https-any-perl as precise deb requirement in Makefile.install.

Business::OnlinePayment::PayPal requires it, and it does not always want
to install from CPAN. It says it require either Net-SSLeay or
Crypt-SSLeay but the CPAN package never wants to install unless they
both are installed. The deb package for Ubuntu seems to do the right
thing.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoQP support for nested WITH construction
Bill Erickson [Fri, 18 May 2012 20:42:19 +0000 (16:42 -0400)]
QP support for nested WITH construction

Nested query plans build their own tsquery chunks which have to be
individually JOINed to the final query.  To do this, each tsquery SELECT
gets its own entry in the top-level WITH, complete with alias for
joining.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFurther integration: link README to server install docs
Dan Scott [Mon, 21 May 2012 03:02:09 +0000 (23:02 -0400)]
Further integration: link README to server install docs

We will now have the INSTALL file linking to the README file which in
turn leads to the docs/installation/server_installation.text file. But
it all works!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoMerge the Evergreen docs into the code repository
Dan Scott [Mon, 21 May 2012 02:51:52 +0000 (22:51 -0400)]
Merge the Evergreen docs into the code repository

Rather than maintaining two separate repositories, with dual maintenance
of what are essentially single-sourced files in the release notes and
the install instructions, make better use of the docs/ subfolder of the
Evergreen repository. If this crazy scheme works, DIG can commit to the
docs/ subfolder, and devs can commit there too.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen-DocBook into doc_consolidati...
Dan Scott [Mon, 21 May 2012 02:35:54 +0000 (22:35 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen-DocBook into doc_consolidation_master

Conflicts:
README

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoFix licensing image.
rsoulliere [Thu, 17 May 2012 16:00:19 +0000 (12:00 -0400)]
Fix licensing image.

9 years agoOptimize full text search with a CTE
Dan Scott [Wed, 16 May 2012 04:29:11 +0000 (00:29 -0400)]
Optimize full text search with a CTE

The tsquery used directly in a JOIN was resulting in bad
plan with lots of nested loops and operations. Using a CTE
to define the query improves the plan.

Also, instead of ARRAY_AGG(DISTINCT foo), just return the
whole thing in an array. Not great for dupes, but we can
handle those inside search.query_parser_fts if we really
need to.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agolink to local cc-by-sa license icon.
rsoulliere [Thu, 17 May 2012 13:52:38 +0000 (09:52 -0400)]
link to local cc-by-sa license icon.

9 years agoVandelay authority existing queue search repair
Bill Erickson [Wed, 16 May 2012 19:55:23 +0000 (15:55 -0400)]
Vandelay authority existing queue search repair

When searching for an existing authority queue, search for an authority
queue, not a bib queue.  Apart from simply not working, the query will
fail with an "invalid input value for enum vandelay.bib_queue_queue_type"
and result in a client-side error.

https://bugs.launchpad.net/evergreen/+bug/989391

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoTypo fix.
rsoulliere [Thu, 17 May 2012 13:39:23 +0000 (09:39 -0400)]
Typo fix.

9 years agoAdd licensing to root.txt
rsoulliere [Thu, 17 May 2012 13:31:24 +0000 (09:31 -0400)]
Add licensing to root.txt

9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen-DocBook
rsoulliere [Thu, 17 May 2012 13:26:28 +0000 (09:26 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen-DocBook

9 years agoAdd licensing appendix and pdf image.
rsoulliere [Thu, 17 May 2012 13:25:19 +0000 (09:25 -0400)]
Add licensing appendix and pdf image.

9 years agoDocument hold-driven recalls
Dan Scott [Thu, 17 May 2012 03:40:52 +0000 (23:40 -0400)]
Document hold-driven recalls

Mostly reformatting the original commit message from c403d6bb54 as
documentation. Includes index entries. Tested with current master,
supported since 2.1.0.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoAvoid collisions of normalized values going into metabib.browse_entry
Lebbeous Fogle-Weekley [Mon, 14 May 2012 16:46:44 +0000 (12:46 -0400)]
Avoid collisions of normalized values going into metabib.browse_entry

This fixes a bug that prevented successful reingestion of bib records
during the 2.1->2.2 upgrade in some cases.  Reported by George Duimovich.

Key part here:

> ERROR: duplicate key value violates unique constraint
> "browse_entry_value_key"
> DETAIL: Key (value)=(545575) already exists.
> CONTEXT: SQL statement "INSERT INTO metabib.browse_entry (value) VALUES
>                     (metabib.browse_normalize(ind_data.value,

George confirmed that the changes to the version upgrade script fixed
the problem for him.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoFix text line widths - lomit to 80 characters.
rsoulliere [Mon, 14 May 2012 17:04:06 +0000 (13:04 -0400)]
Fix text line widths - lomit to 80 characters.

9 years agoTest linking form release notes.
rsoulliere [Sat, 12 May 2012 20:02:36 +0000 (16:02 -0400)]
Test linking form release notes.

9 years agoremove some reference to 2.2 since we are in 2.2 docs.
rsoulliere [Sat, 12 May 2012 19:34:25 +0000 (15:34 -0400)]
remove some reference to 2.2 since we are in 2.2 docs.

9 years agoAdd some content for general staff client usage. Thanks Sally and ESI for providing...
rsoulliere [Sat, 12 May 2012 19:15:04 +0000 (15:15 -0400)]
Add some content for general staff client usage. Thanks Sally and ESI for providing the content.

9 years agoAdd customizing the staff client toolbars and add a section for using the staff clien...
rsoulliere [Sat, 12 May 2012 18:44:44 +0000 (14:44 -0400)]
Add customizing the staff client toolbars and add a section for using the staff client in general.

9 years agoAdd user Activity Types documentation from Sally/ESI. Thanks!
rsoulliere [Sat, 12 May 2012 17:56:34 +0000 (13:56 -0400)]
Add user Activity Types documentation from Sally/ESI. Thanks!

9 years agoUpdate authorities chapter.
rsoulliere [Sat, 12 May 2012 16:04:47 +0000 (12:04 -0400)]
Update authorities chapter.

9 years agoAdd vandelay acquisitions integration fom Sall/ESI. Thanks!
rsoulliere [Sat, 12 May 2012 15:27:52 +0000 (11:27 -0400)]
Add vandelay acquisitions integration fom Sall/ESI. Thanks!

9 years agoAdd SMS text Messaging from Sally/ESI. Thanks!
rsoulliere [Sat, 12 May 2012 15:08:58 +0000 (11:08 -0400)]
Add SMS text Messaging from Sally/ESI. Thanks!

9 years agoAdd library settings editor from Sally/ESI. Thanks Sally and ESI!
rsoulliere [Sat, 12 May 2012 14:41:48 +0000 (10:41 -0400)]
Add library settings editor from Sally/ESI. Thanks Sally and ESI!

9 years agoAdd auto suggest chapter to root.
rsoulliere [Sat, 12 May 2012 14:19:34 +0000 (10:19 -0400)]
Add auto suggest chapter to root.

9 years agoAdd auto suggest documentation from Sally/ESI. Thanks Sally and ESI.
rsoulliere [Sat, 12 May 2012 14:16:50 +0000 (10:16 -0400)]
Add auto suggest documentation from Sally/ESI. Thanks Sally and ESI.

May want to revisit location of documentation. Some of this is OPAC/ end user  and some is admin related.

9 years agoBe more prepared for malformed serial holding code data in upgrade scripts
Lebbeous Fogle-Weekley [Fri, 11 May 2012 19:59:37 +0000 (15:59 -0400)]
Be more prepared for malformed serial holding code data in upgrade scripts

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoMove PLPERL dropping outside of 2.1-2.2 upgrade transaction
Dan Scott [Fri, 11 May 2012 14:45:39 +0000 (10:45 -0400)]
Move PLPERL dropping outside of 2.1-2.2 upgrade transaction

Sites might have added custom PLPERL database functions for migrations,
data clean up, etc, so don't make the success of the 2.1-2.2 upgrade
hinge on a database schema that exactly matches vanilla Evergreen;
just move it outside of the upgrade transaction and output a reassuring
note.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAdd missing weights fm_IDL entries
Thomas Berezansky [Wed, 18 Apr 2012 16:05:20 +0000 (12:05 -0400)]
Add missing weights fm_IDL entries

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoIn the 2.1-2.2 upgrade script, move 0691 into a failures-are-ok zone
Lebbeous Fogle-Weekley [Thu, 10 May 2012 20:19:26 +0000 (16:19 -0400)]
In the 2.1-2.2 upgrade script, move 0691 into a failures-are-ok zone

Mainly because it's already covered in the 2.1.1-2.1.2 upgrade script.
Thanks to George Duimovich for pointing this out in LP #997759.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoVersion Upgrade Cleanup
Thomas Berezansky [Thu, 10 May 2012 15:05:54 +0000 (11:05 -0400)]
Version Upgrade Cleanup

Merge tacked on transactions into the "primary" transaction.
Add in 0708 for tracking purposes.

Separate 0672 and 0679+0680 in the version-to-version upgrade script
They're all potentially slow.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoCheck if transaction needs closing after adding billings
Bill Erickson [Fri, 4 May 2012 13:18:10 +0000 (09:18 -0400)]
Check if transaction needs closing after adding billings

This addresses the issue where issuing refunds results in a negative
ballance and it is then impossible to close the transaction by creating
new billings.

https://bugs.launchpad.net/evergreen/+bug/758982

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoNearest Hold: Look at 100 instead of 10 holds
Thomas Berezansky [Mon, 7 May 2012 18:13:17 +0000 (14:13 -0400)]
Nearest Hold: Look at 100 instead of 10 holds

At the suggestion of Mike Rylander.

Because DB-wise the extra 90 IDs isn't a big deal, and this way we get more
chances to capture (or block renewal, etc).

Jeff Godin claims they have done this and it has produced no issues for them.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoHold Capture: Run permit tests on "old" holds
Thomas Berezansky [Mon, 7 May 2012 15:59:10 +0000 (11:59 -0400)]
Hold Capture: Run permit tests on "old" holds

Because we shouldn't be trusting that the copies are still valid.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoHold Editing: Retarget on some changes
Thomas Berezansky [Mon, 7 May 2012 15:40:41 +0000 (11:40 -0400)]
Hold Editing: Retarget on some changes

The main thing to cover is pickup library, but check a few other things too.

Note that most of what is being checked likely doesn't change in any normal
workflows or interfaces, but it looks like they could anyway later.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoHold Targeter: Ensure old best still valid
Thomas Berezansky [Mon, 7 May 2012 15:00:14 +0000 (11:00 -0400)]
Hold Targeter: Ensure old best still valid

Re-using a now invalid copy is a bad idea for various reasons.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoDefault email/phone hold pickup in TPac
Thomas Berezansky [Fri, 13 Apr 2012 17:26:59 +0000 (13:26 -0400)]
Default email/phone hold pickup in TPac

Like JSPac does, but currently without the check of having phone/email.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoRetarget Local Holds: Use part ID properly
Thomas Berezansky [Wed, 9 May 2012 12:42:58 +0000 (08:42 -0400)]
Retarget Local Holds: Use part ID properly

Because the mapping ID is meaningless unless you only create one part at a
time, assign them only once in the order you created them, etc.

Which I think pretty much describes most of my original test cycle.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoTPAC: Keep site() and depth() out of basic search box when widgets suffice
Lebbeous Fogle-Weekley [Tue, 8 May 2012 15:25:23 +0000 (11:25 -0400)]
TPAC: Keep site() and depth() out of basic search box when widgets suffice

This is a short term but working solution to the problem described here:
https://bugs.launchpad.net/evergreen/+bug/986196

Now when you have a selection for site on the advanced search page, it
doesn't lead to redundant site() and depth() terms in your basic search
query box.

Item type selections and search class selections (keyword/author/etc)
can still lead to ugliness in the advanced search box, but that's
because in the advanced search page you get a multi-select widget for
item type and in a basic search page you only get a single-select
dropdown, so there's not a clean way to map your advanced page
selections to basic page selections.  Search classes are kind of the
same issue, since you have three dropdowns on the advanced search page
and one on the basic.

So the "bigger" problem is one that we will have to solve later, but for
the common case at least we don't get the extra site() and depth() for
now.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoFix hold has copy at lookup
Thomas Berezansky [Mon, 7 May 2012 19:42:35 +0000 (15:42 -0400)]
Fix hold has copy at lookup

Filter on available or reshelving, and add more hold type support for lookup
purposes (parts and issuance holds).

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAdding a small pile of missing permissions
Bill Erickson [Fri, 4 May 2012 14:33:43 +0000 (10:33 -0400)]
Adding a small pile of missing permissions

ADMIN_ADDRESS_ALERT
VIEW_ADDRESS_ALERT
ADMIN_COPY_LOCATION_GROUP
ADMIN_USER_ACTIVITY_TYPE

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoTPAC: repair staff client End link for showing last record
Bill Erickson [Fri, 4 May 2012 16:07:35 +0000 (12:07 -0400)]
TPAC: repair staff client End link for showing last record

In the embedded TPAC, when staff clicks the End link in the record
detail page to jump to the last record in the search results, it now
makes an intermediate jump through search code, which locates the last
record in the set (via CGI param find_last) then redirects to the record
detail page for the last record.  With this approach, we don't have to
pre-fetch the entire set of record IDs just to render the paging links.
Tip o' the hat to Mike R. for the design suggestion.

https://bugs.launchpad.net/evergreen/+bug/984070

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoTPAC: more intelligent detail paging #1
Bill Erickson [Sat, 28 Apr 2012 18:12:53 +0000 (14:12 -0400)]
TPAC: more intelligent detail paging #1

Only fetch a small page of records at a time when generating the paging
links in the detail page.

Part 2 will be to repair the 'Last' record button in the staff client,
which will not work with this change.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
9 years agoTPac: Barcodes default to starting with digits
Thomas Berezansky [Wed, 9 May 2012 13:08:13 +0000 (09:08 -0400)]
TPac: Barcodes default to starting with digits

Because otherwise there is likely to be a lot of confusion when barcodes no
longer work, at all, for login when groups have no barcode regex.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoConsensus was reached to remove editor-specific globs from .gitignore.
Bradley M. Kuhn [Sat, 28 Apr 2012 13:39:12 +0000 (09:39 -0400)]
Consensus was reached to remove editor-specific globs from .gitignore.

In a highly overengineered discussion out of scope with the actual breadth
of this very minor issue, everyone has come to the conclusion that
editor-specific globs don't really belong in the project's .gitignore,
given that git permits a global-level ignore file for users.

Instead, a HACKING file is herein added, with its first entry to explain
how developers can set the own global gitignore.

Signed-off-by: Bradley M. Kuhn <bkuhn@ebb.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoAutoSuggest: Escape ampersands properly
Lebbeous Fogle-Weekley [Wed, 18 Apr 2012 14:41:27 +0000 (10:41 -0400)]
AutoSuggest: Escape ampersands properly

This fixes an issue reported by Yamil Suarez.

If you had relatively technical users composing searches with
QueryParser syntax, or if they were just typing ampersands for any
other reason, AutoSuggest would behave as if the ampersand marked the end
of user input.

This is fixed by applying the correct URI-encoding function for the
situation.

To be clear, QueryParser syntax does not actually affect suggestions;
such syntax is ignored.  AutoSuggest is not search.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agolp996776: Patch to fix the response if no configured status is detected.
Steven Callender [Tue, 8 May 2012 21:15:14 +0000 (17:15 -0400)]
lp996776: Patch to fix the response if no configured status is detected.

SIP response messages that use circulation_status where defaulting to just 1
rather than 01 if the status was not detected. Since SIP needs a 2 character
response, this was causing issues in some 3rd party devices. Added quoting
around the 01 to force the 2 characters.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoStop saving patron barcode in cookies
Thomas Berezansky [Fri, 30 Mar 2012 19:58:32 +0000 (15:58 -0400)]
Stop saving patron barcode in cookies

This causes bad interactions between patron windows and normal catalog
windows. Examples:

Load a patron, load place hold catalog in patron window. Future loads of
non-patron catalogs will default to this patron.

Load Patron A from written note, and open Place Hold catalog. Start
searching for the item Patron A wants.
Get interupted by Patron B calling. Load Patron B, and open Place Hold
catalog. Search, place a hold for Patron B.
Return to Patron A, find item, go to place hold. Find Patron B's barcode
populated.

Instead, teach the staff javascript, that already knows how to load hold
preferences, how to grab the barcode from xulG. This barcode should be
specific to the patron window the catalog is embedded in, and won't 'leak'
to other catalog interfaces.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoRoll back libjs version to 1.7.0
Dan Scott [Tue, 8 May 2012 16:52:02 +0000 (12:52 -0400)]
Roll back libjs version to 1.7.0

The install version of libjs (Spidermonkey) had been bumped to the
latest, 1.8.5, but it turned out that the tests for that had probably
been run on a system that had an old version of libjs source and/or
installed headers/libraries in place, as building libjs 1.8.5 is a
different beast entirely (different directory structure, etc).

In addition, there are several bugs along the lines of
https://rt.cpan.org/Public/Bug/Display.html?id=75058 that strongly
suggest that libjs-1.8.5 is not compatible with the
JavaScript::SpiderMonkey 0.21 Perl module.

Therefore, roll back to the tried-and-true libjs 1.7.0.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
9 years agoWe can't assume that 0526 was in fact run previously so we need to drop these more...
James Fournie [Mon, 7 May 2012 18:08:06 +0000 (11:08 -0700)]
We can't assume that 0526 was in fact run previously so we need to drop these more safely
to avoid producing an error if 0526 wasn't run previously

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agofix typo in CC payment form
Galen Charlton [Tue, 8 May 2012 13:25:19 +0000 (09:25 -0400)]
fix typo in CC payment form

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoUpgrade 0704 was missing from the 2.1-2.2 upgrade script.
James Fournie [Mon, 7 May 2012 17:57:30 +0000 (10:57 -0700)]
Upgrade 0704 was missing from the 2.1-2.2 upgrade script.

That upgrade added a parameter to search.query_parser_fts, without it,
Evergreen passes 11 parameters to the database but the searches fail because
there's only a 10 parameter function in the database.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoMerge remote branch 'sprater/patstatcat'
rsoulliere [Mon, 7 May 2012 15:08:27 +0000 (11:08 -0400)]
Merge remote branch 'sprater/patstatcat'

9 years agoStamping upgrade for 'inheritied' typo repair
Bill Erickson [Fri, 4 May 2012 18:46:16 +0000 (14:46 -0400)]
Stamping upgrade for 'inheritied' typo repair

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoFix "inheritied" typo in global flag
Dan Scott [Fri, 4 May 2012 18:14:12 +0000 (14:14 -0400)]
Fix "inheritied" typo in global flag

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoFix typo in TPAC noticed by Warren Layton
Dan Scott [Fri, 4 May 2012 17:55:55 +0000 (13:55 -0400)]
Fix typo in TPAC noticed by Warren Layton

Expiration needs to be spelled correctly; Warren Layton pointed out the
typo while working on a translation of the derived tpac.pot file. Many
thanks, Warren!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoAdd missing upgrade scripts 0705, 0707 to point-to-point upgrade script
Lebbeous Fogle-Weekley [Fri, 4 May 2012 16:23:19 +0000 (12:23 -0400)]
Add missing upgrade scripts 0705, 0707 to point-to-point upgrade script

These come from bugfixes I pushed to master and rel_2_2 on 28 April 2012
without remembering to address the point-to-point version upgrade script.

See c208754eafadb005439800f7fedd33241fca7b65 (LP #980199) and
89438b46fc39270ac3d47345cd99caacf6b6dee1 (LP #919279).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoPrereqs: Remove Ubuntu Hardy references
Dan Scott [Mon, 9 Apr 2012 20:31:06 +0000 (16:31 -0400)]
Prereqs: Remove Ubuntu Hardy references

We no longer support Ubuntu Hardy 8.04, so ditch any references to it in
the prerequisite installer.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoPrereqs: update to latest available versions
Dan Scott [Mon, 9 Apr 2012 20:29:46 +0000 (16:29 -0400)]
Prereqs: update to latest available versions

* JavaScript-SpiderMonkey: from 0.20 to 0.21
* libjs: from 1.7.0 to 185-1.0.0
* yaz: from 4.2.17 to 4.2.32

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoPrereqs: Remove references to CentOS / RHEL
Dan Scott [Mon, 9 Apr 2012 20:23:08 +0000 (16:23 -0400)]
Prereqs: Remove references to CentOS / RHEL

The prereqs were focused on the 5.x series for CentOS and RHEL, which is
hella-out-of-date and never really worked anyway. Get rid of the noise
to focus on the signal.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAllow subscriptions at org units without volumes
Dan Wells [Wed, 25 Apr 2012 19:56:20 +0000 (15:56 -0400)]
Allow subscriptions at org units without volumes

Subscriptions are sometimes owned at the consortium or system
level, so forcing can_have_vols() to be true was incorrect.

This commit removes those checks.  In addition, we also remove
some dead code and make the subscription org unit selector
consistent with the distribution org unit selector.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAdd indexes to 2.1.2 upgrade script to speed up acq search
Dan Scott [Thu, 3 May 2012 20:44:14 +0000 (16:44 -0400)]
Add indexes to 2.1.2 upgrade script to speed up acq search

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoAdd ISSN fix to the version upgrade script
Mike Rylander [Mon, 26 Mar 2012 15:09:14 +0000 (11:09 -0400)]
Add ISSN fix to the version upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoAdd "Updating translations with Launchpad" dev docs
Dan Scott [Thu, 3 May 2012 19:33:51 +0000 (15:33 -0400)]
Add "Updating translations with Launchpad" dev docs

Not 100% sure if this is where we want to keep developer process
documentation, but as I already have it in AsciiDoc we might as well
give it a try.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoAddress date sorting in Item Status and Copy Buckets interfaces, too
Jason Etheridge [Wed, 2 May 2012 19:23:06 +0000 (15:23 -0400)]
Address date sorting in Item Status and Copy Buckets interfaces, too

> The sort_value function for the date columns being used in those
> interfaces had no error protection, and were returning empty strings
> upon failure.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoFix date sorting in patron-related XUL interfaces
Lebbeous Fogle-Weekley [Wed, 2 May 2012 18:01:00 +0000 (14:01 -0400)]
Fix date sorting in patron-related XUL interfaces

Null time stamps are now converted to dates in the Middle Paleolithic
era so they always sort as the lowest date.

Seriously, this is the minimum possible date you can express with a JavaScript
date object.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoFix LP 984039: correct Syndetic Kirkus Reviews
Jeff Godin [Tue, 17 Apr 2012 14:46:22 +0000 (10:46 -0400)]
Fix LP 984039: correct Syndetic Kirkus Reviews

Use correct "filename" component of URL for retrieving Kirkus
Reviews content from Syndetic Solutions.

Correct filename confirmed by Bowker technical support, and by
empirical tests.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
9 years agoFix some "null" instead of blank values in JSPac
Thomas Berezansky [Tue, 3 Apr 2012 18:45:10 +0000 (14:45 -0400)]
Fix some "null" instead of blank values in JSPac

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoLink to the Attributions section from the introduction
Dan Scott [Tue, 1 May 2012 06:57:53 +0000 (02:57 -0400)]
Link to the Attributions section from the introduction

We know how to use intra-document links, so let's use them :)

Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agodblatex hates files with multiple periods
Dan Scott [Tue, 1 May 2012 06:36:11 +0000 (02:36 -0400)]
dblatex hates files with multiple periods

Running the PDF transform was generating errors from dblatex complaining
about unknown file extensions like ".50_Import1.jpg"; this was because
there were two periods in the file name. Easily fixed by renaming the
files, and I removed the useless ALT text from the image attributes in
the same pass.

Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoUpdate Release Notes and Installation documents to match code
Dan Scott [Tue, 1 May 2012 06:29:28 +0000 (02:29 -0400)]
Update Release Notes and Installation documents to match code

We need to keep the release notes and installation instructions in sync
with the code versions.

To make our lives easier, use the "leveloffset" AsciiDoc macro so that
we don't have to push all of the heading indicators in the
single-sourced documents down one level manually.

Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoRelease notes: clean up and introduce TPAC
Dan Scott [Tue, 1 May 2012 05:52:56 +0000 (01:52 -0400)]
Release notes: clean up and introduce TPAC

General clean-up of the release notes for consistency and to support
PDF output:

* Reformat line-widths to 80 characters or less
* Mark interface window and element names as bold
* Fix up some formatting glitches and headers
* Make the "Documentation is available..." note standard & separated
  by one line; I suspect we will want to modify this globally, so it
  will be easier if it is consistent.

Also, give a brief introduction to the TPAC and mention the forthcoming
JSPAC deprecation in the next feature release.

Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoLP992377: More 2.2 release notes from Kathy Lussier
Kathy Lussier [Tue, 1 May 2012 05:26:28 +0000 (01:26 -0400)]
LP992377: More 2.2 release notes from Kathy Lussier

Kathy Lussier <klussier@masslnc.org> contributed significant additions
to the 2.2 release notes in https://bugs.launchpad.net/bugs/992377 -
thanks Kathy!

Signed-off-by: Dan Scott <dan@coffeecode.net>
9 years agoAdd the licensing comment to the new PDF icon
Dan Scott [Mon, 30 Apr 2012 20:15:11 +0000 (16:15 -0400)]
Add the licensing comment to the new PDF icon

Inadvertently pushed the new PDF icon without the licensing statement
embedded as a comment; fix that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoReplace the questionable PDF icon with a CC-BY-SA icon
Dan Scott [Mon, 30 Apr 2012 20:02:21 +0000 (16:02 -0400)]
Replace the questionable PDF icon with a CC-BY-SA icon

The Adobe PDF icon policy at http://www.adobe.com/misc/linking.html
states that the icon may only be used with PDF documents created by an
Adobe Acrobat product. The DIG PDF files are not produced in this
manner.

Therefore, replace the current icon with a GIF derived from the CC BY-SA
Dropline Etiquette GNOME icons by Silvestre Herrerra
<silvestre.herrera@gmail.com>. Downloaded from
http://art.gnome.org/download/themes/icon/1049/ICON-DroplineEtiquette.tar.bz2

To comply with the "BY" part of BY-SA, the new GIF includes a comment
that clearly states the provenance of the icon.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoadditions to release notes for 2.2
Galen Charlton [Mon, 30 Apr 2012 11:22:01 +0000 (07:22 -0400)]
additions to release notes for 2.2

Written by Sally Fortin <sfortin@esilibrary.com>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoVandelay match set permission additions
Bill Erickson [Wed, 21 Mar 2012 20:33:39 +0000 (16:33 -0400)]
Vandelay match set permission additions

Allow retrieve access for match points with the VIEW_IMPORT_MATCH_SET
permission (in addition to ADMIN_IMPORT_MATCH_SET).

Adds 2 new permissions to the database:

ADMIN_IMPORT_MATCH_SET
VIEW_IMPORT_MATCH_SET

From Jason Stephenson resolving conflicts:
> Conflicts:
>
>  Open-ILS/src/sql/Pg/950.data.seed-values.sql
>
> I had to change the ids of the new permissions because another branch
> had used one of the ids since this branch was last rebased.  I also edited
> the ids in the upgrade script to match what is in 950.data.seed-values.sql.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoUpdate POT files for translators
Dan Scott [Sat, 28 Apr 2012 19:52:54 +0000 (15:52 -0400)]
Update POT files for translators

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoUpdate translations from Launchpad
Dan Scott [Sat, 28 Apr 2012 18:12:43 +0000 (14:12 -0400)]
Update translations from Launchpad

Includes a small update to the update_pofiles to make it easier for
release managers and release maintainers to run translation updates.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoConstrain serial.issuance.holding_code to be valid JSON or NULL
Lebbeous Fogle-Weekley [Thu, 5 Apr 2012 15:46:05 +0000 (11:46 -0400)]
Constrain serial.issuance.holding_code to be valid JSON or NULL

This avoids serial.materialize_holding_code() failing on bad data.  The
upgrade script will actually throw away bad values for
serial.issuance.holding_code.  This is no real loss, since bad data
there prevents any serials functions around the row in question from
working properly anyway.

This problem was reported by Martha Driscoll and Ben Shum.

*Also* put a couple of changes missed from the 0700 upgrade script into
210.schema.serials.sql.

Fix new serial constraint upgrades

1. None of the upgrades so far have moved is_json() from the public
to the evergreen schema.  That's probably a separate issue, but it
should be safe to call it unqualified, and that's what the rest of
the upgrade file does, so we will too.

2. Add a specific SET CONSTRAINT to avoid deferred trigger problems
when ALTERing the table.

3. Make sure that the unwanted columns on materialized_holding_code
do not exist regardless of your upgrade path.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>