VIEW_COPY_ALERTS and ADMIN_COPY_ALERT permissions were added
recently, but not assigned in the default seed data. This branch
assigns VIEW_COPY_ALERTS to Staff profiles at the Consortium depth
and adds ADMIN_COPY_ALERT to the Cataloging Administrator profile.
Since permissions are set so specifically per-site, this branch does
not contain an upgrade script, but does provide an update to release
notes reminding site admins to manually add them to the appropriate
profiles.
Change the update to an "ALTER FUNCTION ... STABLE" both
to make the purpose of the update more clear and to remove
the need to check the rest of the function definition when
backporting.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Chris Sharp [Mon, 20 May 2019 20:14:00 +0000 (16:14 -0400)]
LP#1768141 - Mark permission.grp_descendants STABLE.
Quoting Galen Charlton's comments on the bug report:
The database function permission.grp_descendants should
be marked stable; it qualifies, and doing so should allow
PostgreSQL to improve query plans. One example of a query
that would benefit is searching by patron profile (a la
bug 1497322)
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Jane Sandberg [Wed, 21 Aug 2019 17:26:47 +0000 (10:26 -0700)]
LP1739607: Add missing columns to patron record
To test:
1) Open up a patron record with some bills.
2) On the Items Out tab, notice that there is a column named Location
3) On the Bills tab, open up Bill history.
4) In the history transactions grid, note that the column picker is
missing the following columns:
* Item owning library
* Checkout/renewal library
* Due date
* Fines Stopped Reason
5) In the history payments grid, note that the column picker is missing
the same columns.
6) Apply this commit.
7) Note that the Items Out tab's column is renamed to "Shelving
Location".
8) Notice that both Bill history grids column pickers include the
requested columns.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
This fixes vertical alignment issues in the MARC View table
by removing the deprecated valign tags and moving the inline
CSS to the cat.css file. The text within each table cell should
now align to the top for better readability.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jeff Davis [Mon, 10 Jun 2019 16:53:44 +0000 (09:53 -0700)]
LP#1822630: fix sanitizing CGI params on place_hold_result
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Mon, 1 Apr 2019 22:13:09 +0000 (15:13 -0700)]
LP#1822630: further sanitizing of CGI params when embedded in HTML
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Mon, 1 Apr 2019 17:00:59 +0000 (10:00 -0700)]
LP#1822630: sanitize user input before display on browse results
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Thu, 13 Sep 2018 18:58:48 +0000 (11:58 -0700)]
LP#1559239: use rel="noopener" when opening external URLs in a new tab
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
blake [Fri, 1 Dec 2017 22:32:22 +0000 (16:32 -0600)]
LP1735847: Remove patron info from default Hold Transit Slip
Removes most patron information from the Hold Transit Slip
in both the web and XUL client default definitions.
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Version 6.07 or higher of LWP::Protocol::https is required to
avoid an issue where an SSL certificate check of localhost
cannot be bypassed. We could instead have chosen to install
that Perl module from CPAN rather than packages, but since there's
presently no non-test code that requires that bugfix, I've elected
not to bother installing that module from CPAN for now.
The live perl test is failing because we are not passing all
the right parameters for ignoring the SSL certificate verification
checks. Pass another variable to see if this helps.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1817645: (follow-up) avoid hardcoding user ID in a live_t test
This patch is an alternative implementation of an idea from
Ben Shum to avoid assuming that a given username in Concerto
will always be associated with the same patron ID.
When this branch was committed, some old seed data snuck back into
the file from LP#1759343 cleanup commit (eee5c5948ca). Remove the
extra code to prevent duplicate INSERT errors.
Skips the CREATE_PRECAT permission check when renewing pre-cataloged items.
Also disables all the elements except the Cancel button in the Pre-Cat dialog
when the user lacks the CREATE_PRECAT permission, and repositions the explanatory
text.
Also includes release notes.
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Add this permission to prevent untrained/un-authorized
circ staff from creating pre-cat items due to mis-scanned
barcodes. Added to all profiles by default, so that staff
admins can pinpoint users who may not have it, i.e Volunteers, etc.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Mark Bucholtz <mbucholtz@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
The main functionality for this enhancment produces toast messages for success
and failure, and the description for this particular event when testing had me
double-taking :)
Lp 1799272: Option to Limit Hold Items in SIP2 msg 64 to Available
This commit adds an implementation option to the oils_sip.xml that,
when enabled, will limit the hold items list and hold items counts in
the patron information response (response 64) to only the holds
available for pickup by the patron. When the setting is not enabled,
the full list of the patron's holds continues to be used.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Pearl [Thu, 25 May 2017 18:10:01 +0000 (14:10 -0400)]
LP#1731021: Support fine detail enhancement to SIP.
The particular flavor of fine detail output is manufacturer dependent,
although 3m is popular, and the default. To configure the selection,
modify the /openils/conf/oils_sip.xml file.
Testing: See the /openils/conf/oils_sip.xml file and test all supported
values for the av_format option. You should also test the case where
the option is omitted, or a non-supported value. I am not sure what
happens if you supply more than one option with same or different
values, but this is a non-supported degenerate case.
For each test value, ensure tha the fine item detail is the expected
format.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Two new options for importing holdings have been added to MARC Batch
Import/Export:
1) Auto-overlay On-order Cataloguing Copies
This is similar to "Auto-overlay In-process Acquisitions Copies," but
for copies that were not created from an acquisitions workflow.
Holdings information in the incoming record will be used to overlay any
existing On Order copies for the matching record which belong to the
owning library defined in the Holdings Import Profile. The Holdings
Import Profile is also used to match incoming to existing copies, if
possible; otherwise, On Order copies are overlaid in the order they were
created. The call number will also be overlaid if the incoming record
provides one.
2) Use Org Unit Matching in Copy to Determine Best Match
When there are multiple potential matching records, this feature allows
the user to automatically select the record which has the most copies at
libraries near the importing library in the org tree. That is, starting
at the importing library, it climbs the org tree, gradually expanding
the scope at which it checks for holdings on matching records; once
holdings are found, the record with the most holdings at that scope is
selected for overlay. If there are no matching records with holdings,
then the default best match overlay is attempted.
Two new permissions are added to control the use of these new features.
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop> Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Josh Stompro [Wed, 27 Feb 2019 16:31:54 +0000 (10:31 -0600)]
LP#1728331 - Action Trigger Aggregator Date Parameter
- Added release notes.
- Added note about script to support scripts doc.
- Added script to makefile for confile processing and installation.
- Added processed version of the script to .gitignore
I tested out the script with our production data and it worked as described.
Jeff Davis [Fri, 8 Feb 2019 21:59:14 +0000 (13:59 -0800)]
LP#1786552: optionally restrict auth_proxy login by home OU
This adds a new restrict_by_home_ou setting to auth_proxy authenticator
config. When enabled, if the login request includes an org param, the
authenticator will refuse to authenticate a user unless their home OU
matches or is a descendant of that org; login fails and auth_proxy
proceeds to the next configured authenticator.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Creates tables money.aged_billing and money.aged_payment. When a
circulation is aged, billings/payments linked to the circ are migrated
to the aged_* table.
Upgrade script includes a migration script for migrating existing
billings and payments.
Includes IDL entries for reporting and pcrud access just in case it's
needed. Note the 'xact' column on these new tables links directly to
the aged circulation instead of the non-existent money.billable_xact.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1840327: (follow-up) various fixes and improvements
* Fixed inabiilty to set the name for a new standing penalty
* Fixed the 'Delete Selected' action
* adjust for recId => recordId change to FM record editor
* remove a bit of copy-and-paste-itis
* Lint repairs
Mike Risher [Tue, 20 Aug 2019 20:29:23 +0000 (20:29 +0000)]
LP#1840327: port standing penalty admin interface to Angular
Convert standing penalty types admin UI from DOJO to Angular. Name
field is read only if the ID is below 100. Doing this involved:
- creating a new standing penalty component
- using rowFlairCallback functionality in the grid, so that an icon
and tooltip is shown for fields where the name cannot be edited
- making the ID show up in red text when it is below 100
- adding "readonly Override" functionality to fm-editor, so that
some fields of a given type are read only, but others are not
Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Fri, 16 Aug 2019 21:00:11 +0000 (17:00 -0400)]
LP1840050 Modularize various standalone components + more.
Create container modules for the String, Translate, FM record editor, and
Admin Page components & services. This simplifies imports and allows us
to avoid requiring these modules on pages that don't need them. In
particular, the staff splash page now loads fewer imports, which should
improve initial load/login time.
Additionally some components were enhanced.
FM record editor now has a eg-fm-record-editor-action component so users
can pass in an action, rendered as a button at the bottom of the editor.
FM record editor gets a delete record option and hideBanner option.
FM record editor now better handles real-time updates of its underlying
recordId and record values, including updates to some editor callers to
migrate to the modified API (replace recId with recordId).
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Fri, 16 Aug 2019 20:52:50 +0000 (16:52 -0400)]
LP1840050 Combobox responds favoribly to value changes
Using the power of getters/setters, teach the combobox to respond to
updates of the selected entry, particulary when the selected value is
applied before the set of underlying entries is modified.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Remington Steed [Tue, 28 May 2019 13:33:44 +0000 (09:33 -0400)]
LP#1741980: Give type label its own span and class for easy hiding
This commit separates the copy tag type label into its own span with a
new class "copy_tag_type_label", so that libraries can hide it or style
it differently. Release notes are included.
When copy/item tags (such as "Digital Bookplate") are displayed in the
OPAC, they currently only show the tag's value, but not the label of the
tags type. This commit fleshes in the tag type so we gain access to the
type's label, and it adds it to the OPAC display.
OPAC output before: "(Tag Value Here)"
OPAC output after: "Digital Bookplate: (Tag Value Here)"
It is not universally true that the patron needs to negotiate with the
owning library for more renewals, so we try to make it clear that this
is not always the case in the release notes.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Pearl [Mon, 19 Mar 2018 19:09:43 +0000 (15:09 -0400)]
LP1753536 - Add a new Owning Library column to the OPAC Items Out
This new column indicates which library owns the materials, and is
intended to help the patron contact the owning library should they be
out of renewals and would like an exception made.
Also adds some utility code for generating an org unit URL.
Make the presence of the column controlled by an organizational unit
setting.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Tue, 6 Aug 2019 15:34:51 +0000 (11:34 -0400)]
LP1823981 Angular perm group admin UX improvements
* Loading progress now increments as data arrives.
* Application perm list is now sorted
* Deleted map now use warning background instead of danger as it appears
to have better contrast.
* Inherited perms display the label 'Inherited' in the delete colum.
* Remove border boxes around non-actionable inherited values.
* Use Bootstrap button links instead of <a> for links to perm groups to
improve contrast and consistency.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
projects / Evergreen.git / log