]> git.evergreen-ils.org Git - Evergreen.git/log
Evergreen.git
12 years agoRemember MARC Template selection
Thomas Berezansky [Wed, 14 Sep 2011 17:37:27 +0000 (13:37 -0400)]
Remember MARC Template selection

Implement both a workstation default and "last used" for the MARC template
selector.

Workstation default is set with a new "Set Workstation Default" button.

"Last used" will override the workstation default, and is updated every
time you load a template. It is forgotten when you close the client.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd "submit on enter" to all advanced search boxes
Thomas Berezansky [Tue, 4 Oct 2011 19:28:36 +0000 (15:28 -0400)]
Add "submit on enter" to all advanced search boxes

Instead of just the one with an ID specified.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoStamped upgrade scrip fro authorities-indb-with-nfi
Bill Erickson [Fri, 14 Oct 2011 18:20:56 +0000 (14:20 -0400)]
Stamped upgrade scrip fro authorities-indb-with-nfi

Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoMove the NACO normalization script to earlier in the baseline schema installation...
Mike Rylander [Tue, 11 Oct 2011 18:25:36 +0000 (14:25 -0400)]
Move the NACO normalization script to earlier in the baseline schema installation process, as it is now used in the authority schema

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoWrapper functions in the baseline schema that were missed in the upgrade script
Mike Rylander [Fri, 7 Oct 2011 20:22:42 +0000 (16:22 -0400)]
Wrapper functions in the baseline schema that were missed in the upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoAddress regression causing main headings to be null because the thesaurus code we...
Mike Rylander [Fri, 7 Oct 2011 14:15:19 +0000 (10:15 -0400)]
Address regression causing main headings to be null because the thesaurus code we not being extracted as it was before

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoNew in-db search and browse of authorities with non-filing-indicator support
Mike Rylander [Wed, 21 Sep 2011 20:38:08 +0000 (16:38 -0400)]
New in-db search and browse of authorities with non-filing-indicator support

Upon authority ingest, record simple authority headings for searching,
browsing and sorting.  Respect non-filing indicators, if configured
(configuration is the nfi field on authority.control_set_authority_field).

Provide a full suite of search/browse top/center alpha/rank functions
based on authority tag, bib tag or browse axis at the database layer.

Provide functions to find the main-only and full tag list, and ref-variant
versions of the previously defined functions.

Teach OpenILS::WWW::SuperCat (responsible for RESTful feed-generating
interfaces) to use new OpenILS::Application::SuperCat methods that in
turn use the database methods.  The change should be transparent to
users of SuperCat web APIs.

Carry indicators over from authority main entries to bibs, when applying
them in the marc editor.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoLP873614 print_init error printing bill history
Jason Etheridge [Fri, 14 Oct 2011 16:14:14 +0000 (12:14 -0400)]
LP873614 print_init error printing bill history

xulG.url_prefix needs to be present for anything using util/print.js and the
Mozilla print strategy.  Alternately, we could duplicate the logic behind
url_prefix and bundle it into print.js :-/

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agosettings-tester.pl - add TPac required modules
Dan Scott [Fri, 14 Oct 2011 02:26:25 +0000 (22:26 -0400)]
settings-tester.pl - add TPac required modules

Keep up with the TPac requirements in settings-tester.pl

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd MARC::Record 2.0.1 minimum test to settings-tester.pl
Dan Scott [Fri, 14 Oct 2011 02:25:04 +0000 (22:25 -0400)]
Add MARC::Record 2.0.1 minimum test to settings-tester.pl

Wrap the use_ok() tests in a BEGIN block, per the recommendation of the
Test::More perldoc.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoSettings-tester.pl whitespace
Dan Scott [Fri, 14 Oct 2011 02:15:53 +0000 (22:15 -0400)]
Settings-tester.pl whitespace

Might as well complete the conversion of the file into modernity.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoRemove oils_web.xml test from settings-tester.pl
Dan Scott [Fri, 14 Oct 2011 02:13:02 +0000 (22:13 -0400)]
Remove oils_web.xml test from settings-tester.pl

In master, oils_web.xml is no more, replaced instead by Apache
configuration. Awww yeah.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoModernize settings-tester.pl a bit
Dan Scott [Fri, 14 Oct 2011 02:10:23 +0000 (22:10 -0400)]
Modernize settings-tester.pl a bit

* Add a section that checks for Evergreen services in opensrf_core.xml
* Ignore the qstore database credentials, as qstore is unused currently
* Split things off into subroutines for easier reading

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoFixes for SIP2 Fee Payment.
Jason Stephenson [Thu, 22 Sep 2011 16:52:08 +0000 (12:52 -0400)]
Fixes for SIP2 Fee Payment.

Skip negative or zero bill balance when paying multiple bills.

Log amount paid, bill id, balance, and amount remaining when paying
multiple bills.

Use sprintf("%.2f") to avoid floating point errors.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoStamping upgrade for asset.merge_record_assets fix from dbs
Mike Rylander [Thu, 13 Oct 2011 19:57:30 +0000 (15:57 -0400)]
Stamping upgrade for asset.merge_record_assets fix from dbs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoFix located URI merging in action.merge_record_assets()
Dan Scott [Thu, 13 Oct 2011 15:49:45 +0000 (11:49 -0400)]
Fix located URI merging in action.merge_record_assets()

Perhaps due to the unexpected results of the XPath expression, which
returns a count of nodes for subfields, etc, rather than just a count of
the number of 856 datafields, NULL was being concatenated onto a string
- which of course made the string NULL.

Use COALESCE() to prevent the NULLness from spreading and enable
action.merge_record_assets() to do the right thing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoMore self-closing cleanup
Thomas Berezansky [Tue, 27 Sep 2011 17:02:14 +0000 (13:02 -0400)]
More self-closing cleanup

All div and span tags in tt2, js, html, and xhtml files.

Ignored .xml files, as they are not (to my knowledge) served as text/html.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoReplace self-closing divs with open/close divs
Bill Erickson [Tue, 27 Sep 2011 14:51:29 +0000 (10:51 -0400)]
Replace self-closing divs with open/close divs

XML != HTML

Traditionally, Vandelay templates were parsed as XML on the server for
DTD replacement.  With the advent of locale::maketext for templates,
Vandelay no longer needs to be parsed as XML.  However, not parsing as
XML leaves any self-closing divs (<div/>) intact in the final source,
which are treated as opening divs in text/html.  This patch replaces
self-closing divs with open/close pairs.

https://bugs.launchpad.net/evergreen/+bug/860676

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoVerify session before trying any transactions in SIP->pay_fee.
Jason Stephenson [Mon, 26 Sep 2011 19:52:52 +0000 (15:52 -0400)]
Verify session before trying any transactions in SIP->pay_fee.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTPac: One prefers to download CSV, not to display it
Lebbeous Fogle-Weekley [Wed, 12 Oct 2011 18:04:01 +0000 (14:04 -0400)]
TPac: One prefers to download CSV, not to display it

For the "Download CSV" operation in the TPac "My Lists" interface,
provoke the user's browser to download the file, rather than displaying
the file in a new tab/window.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoGive OrgTree.js a locale, always
Dan Scott [Wed, 12 Oct 2011 18:54:25 +0000 (14:54 -0400)]
Give OrgTree.js a locale, always

We started generating locale-specific OrgTree.js files many moons ago,
and now no longer provide a "default" locale in the root of the
common/js directory. The result was that the index.xhtml page for the
staff client was throwing an "_l is undefined" exception; largely
meaningless, as it seems that the OrgTree isn't even used on that page,
but noise that doesn't need to be in the JavaScript console.

Here we correct that exception by providing a locale, and hopefully
prevent any further copy/paste mistakes.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAuthentication block logging
Bill Erickson [Tue, 11 Oct 2011 21:03:57 +0000 (17:03 -0400)]
Authentication block logging

* Login too-many-auth-failures message at Info level instead of Internal
* Log the username getting blocked

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoFix cut-paste-o in unapi.sitem, re stream and unit subobjects~
Mike Rylander [Wed, 12 Oct 2011 15:47:47 +0000 (11:47 -0400)]
Fix cut-paste-o in unapi.sitem, re stream and unit subobjects~

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoIncorrect version number in the upgrade script
Mike Rylander [Wed, 12 Oct 2011 15:01:34 +0000 (11:01 -0400)]
Incorrect version number in the upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agocopy-paste-o from the seed data
Mike Rylander [Wed, 12 Oct 2011 14:58:47 +0000 (10:58 -0400)]
copy-paste-o from the seed data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoFix z39.50 import isbn and issn searches on local catalog.
Jason Stephenson [Fri, 16 Sep 2011 12:52:44 +0000 (08:52 -0400)]
Fix z39.50 import isbn and issn searches on local catalog.

Make cat_search_z_style_wrapper do identifier searches for isbn and
issn.

Modify the_quest_for_knowledge to accept identifier searches for isbn
and issn.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd Show In Catalog button to Z39.50 Import.
Jason Stephenson [Fri, 16 Sep 2011 16:45:11 +0000 (12:45 -0400)]
Add Show In Catalog button to Z39.50 Import.

Changes to z3950.xul:
Add show_in_catalog command.
Add button next to Mark for Overlay button.

Changes to z3950.js:
Enable/disable Show In Catalog button whenever Mark for Overlay
button is enabled/disabled.
Add code for show_in_catalog to open the record detail screen in
a new tab.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoREADME: For master, focus on PostgreSQL 9.1
Dan Scott [Wed, 12 Oct 2011 13:43:40 +0000 (09:43 -0400)]
README: For master, focus on PostgreSQL 9.1

Given that the backports for Debian and Ubuntu already offer PostgreSQL
9.1, and Fedora 16 (out in a few weeks) comes with 9.1, focus on 9.1
where it is available.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd instructions/targets for Ubuntu/Debian PG9.1
Thomas Berezansky [Wed, 12 Oct 2011 13:06:31 +0000 (09:06 -0400)]
Add instructions/targets for Ubuntu/Debian PG9.1

No Fedora/RHEL/CentOS changes due to my lack of test environment.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoFix README for 9.1+ DB creation instructions
Thomas Berezansky [Wed, 12 Oct 2011 12:51:01 +0000 (08:51 -0400)]
Fix README for 9.1+ DB creation instructions

Also fix 9.0 typo of - instead of _ in filename.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoREADME: Minor whitespace cleanup
Dan Scott [Wed, 12 Oct 2011 00:31:24 +0000 (20:31 -0400)]
README: Minor whitespace cleanup

Just to get the indentation standardized on second and subsequent lines
of bullets. No big whoop.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoChange PostgreSQL 9 source for Ubuntu Lucid users.
Ben Shum [Tue, 11 Oct 2011 22:51:32 +0000 (18:51 -0400)]
Change PostgreSQL 9 source for Ubuntu Lucid users.

Currently, Ubuntu Lucid does not have backport options for PostgreSQL 9.
Instead, most community members who use Lucid have been using
Martin Pitt's PPA as an external repository source.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTPac: Use workstation to determine staff
Thomas Berezansky [Tue, 11 Oct 2011 20:55:12 +0000 (16:55 -0400)]
TPac: Use workstation to determine staff

Instead of user agent, which may be set easily by anyone, use the presence
of a workstation ID to determine "staff" use of the TPac.

This is much less likely to be spoofed or incorrect due to things like
previous use of the extension version of the client in Firefox.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoTPac; repairs to advanced search query propagation
Bill Erickson [Tue, 11 Oct 2011 15:33:28 +0000 (11:33 -0400)]
TPac; repairs to advanced search query propagation

In some cases, TPac will duplicate components of an advanced search
query into the advanced search rows.  This patch fixes that with
better array handling, particularly with CGI param search components
that do not have corresponding analogs at a given array position (i.e.
starting out with arrays of different sizes)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoProtect against undefined value as ARRAY reference
Dan Scott [Wed, 7 Sep 2011 06:41:43 +0000 (02:41 -0400)]
Protect against undefined value as ARRAY reference

We should not assume that the caller is going to supply an array
(empty or not) of addresses or cards in the input values for the
open-ils.actor.patron.update method.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agofix another POD glitch
Galen Charlton [Mon, 26 Sep 2011 02:58:32 +0000 (22:58 -0400)]
fix another POD glitch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agofix up POD
Galen Charlton [Mon, 26 Sep 2011 02:51:56 +0000 (22:51 -0400)]
fix up POD

- avoids some noise when building the Perl modules for
  distributions that check for correctness when converting
  POD to man pages
- add a an author test, taken straight from the Test::Pod
  documentation, for POD correctness

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoMerge remote branch 'working/user/berick/marc-stream-importer-read-repair'
Galen Charlton [Tue, 11 Oct 2011 13:52:06 +0000 (09:52 -0400)]
Merge remote branch 'working/user/berick/marc-stream-importer-read-repair'

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoGive CentOS / RHEL a chance at installing PostgreSQL 9.0
Dan Scott [Mon, 10 Oct 2011 20:46:48 +0000 (16:46 -0400)]
Give CentOS / RHEL a chance at installing PostgreSQL 9.0

Evergreen 2.1 requires PostgreSQL 9.0, and we accordingly updated the
package names back in the summer to point at PostgreSQL 9.0, but nobody
running CentOS / RHEL brought to our attention that the repo target
needed to be updated as well. This, although untested, at least gives
CentOS / RHEL users a fighting chance of installing Evergreen master /
2.1 on their system.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoFix broken Net::Z3950::SimpleServer 1.14 install
Dan Scott [Mon, 10 Oct 2011 20:15:04 +0000 (16:15 -0400)]
Fix broken Net::Z3950::SimpleServer 1.14 install

Pin the install of Net::Z3950::SimpleServer to the
known-to-work-with yaz 3.0.x version, 1.12. 1.14 introduced dependencies
on yaz 4.1.x that can't be easily worked around.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoCorrect varname for PostgreSQL RPMs
Dan Scott [Thu, 21 Jul 2011 21:16:32 +0000 (17:16 -0400)]
Correct varname for PostgreSQL RPMs

On Fedora, Red Hat, and CentOS, we were still trying to install
the set of PostgreSQL RPMs for PostgreSQL 8.4 using PGSQL_84_RPMS.
This had been updated to PGSQL_90_RPMS to match the updated
database version - using the right varname resolves the problem
(at least on Fedora).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoStamping baseline schema for previous commit
Mike Rylander [Mon, 10 Oct 2011 17:45:16 +0000 (13:45 -0400)]
Stamping baseline schema for previous commit

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoFix, as provided by Doug Kyle, for LP#822918
Mike Rylander [Mon, 10 Oct 2011 17:42:11 +0000 (13:42 -0400)]
Fix, as provided by Doug Kyle, for LP#822918

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoStamped upgrade script for Grace Period Closed-Date Extension features
Mike Rylander [Mon, 10 Oct 2011 17:32:55 +0000 (13:32 -0400)]
Stamped upgrade script for Grace Period Closed-Date Extension features

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoGrace period auto extension and backdate awareness
Thomas Berezansky [Thu, 15 Sep 2011 16:10:12 +0000 (12:10 -0400)]
Grace period auto extension and backdate awareness

Grace period auto extension:

Default is "grace periods don't auto extend".

OU setting turns on grace period auto extension. By default they only do so
when the grace period ends on a closed date, but there are two modifiers to
change that.

The first modifier causes grace periods to extend for all closed dates that
they intersect. This is "grace periods are only consumed by open days."

The second modifier causes a grace period that ends just before a closed
day, with or without extension having happened, to include the closed day
(and any following it) as well. This is mainly so that a backdate into the
closed period following the grace period will assume the "best case" of the
item having been returned after hours on the last day of the closed date.

Backdate grace period awareness:

By moving grace period calculations into a shared location backdating can
check the grace period, including extensions. If it finds that the backdate
is within the grace period (before or after extension) then instead of
voiding the fines for after the backdate it instead voids all fines for the
circulation. This emulates what would have happened (no fines) if the item
had been checked in at the time the backdate was made to take effect.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agotrival typo fix
Galen Charlton [Fri, 7 Oct 2011 18:01:43 +0000 (14:01 -0400)]
trival typo fix

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agocontrol client dump statements through pref
Jason Etheridge [Fri, 7 Oct 2011 15:38:14 +0000 (11:38 -0400)]
control client dump statements through pref

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoTPac: Jump-to-details on first result page only
Bill Erickson [Fri, 7 Oct 2011 13:08:38 +0000 (09:08 -0400)]
TPac: Jump-to-details on first result page only

When activated, jump-to-record-details-on-1-hit should only come into
play on the first page of results.  In other words, if page 2 of a
search has 1 item, do not jump to the record details page for that item.
Instead, show page 2 of the search results.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoTPac; start new facet "search" on page 0
Bill Erickson [Thu, 6 Oct 2011 20:34:40 +0000 (16:34 -0400)]
TPac; start new facet "search" on page 0

When selecting a facet, thereby appending it to the current search,
start the search over at the first page.  In other words, don't drop
into page X of a new search, since there may be no page X of the new
search.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agofix authentication failure
Galen Charlton [Thu, 6 Oct 2011 17:55:43 +0000 (13:55 -0400)]
fix authentication failure

Ensure that the auth_limit values are read when open-ils.auth
initializes, not during oilsAuthInit().  This solves a problem
observed on brick-based setups where authentication could
incorrectly fail because the drone that processes
open-ils.auth.authenticate.complete didn't have the the block
count value initialized yet.

Also fixed type nit when compare the fail count to the block
limit.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoFix "0 holds created" message on successful hold
Thomas Berezansky [Fri, 30 Sep 2011 20:55:05 +0000 (16:55 -0400)]
Fix "0 holds created" message on successful hold

Caused by results not always being an array.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTPac: My List add/remove page anchor fix
Bill Erickson [Thu, 6 Oct 2011 15:42:54 +0000 (11:42 -0400)]
TPac: My List add/remove page anchor fix

Removed /g modifier from URL anchor regex to prevent URLs with multiple
page #-anchors.  This change primarily affects IE which includes #-anchors
in the referer header.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoReally add *entire* selection list to a purchase order, when desired,
Lebbeous Fogle-Weekley [Tue, 4 Oct 2011 21:51:35 +0000 (17:51 -0400)]
Really add *entire* selection list to a purchase order, when desired,

and generally do what a user would expect when, in Acq, the user
executes an operation on "all items".

This addresses LaunchPad bug #810030.

The fundamental issue is that an AcqLiTable, which is used in several
different ways in different interfaces, may be representing items on a
selection list (for example), but it doesn't necessarily know all of the
items that belong to that selection list.  It only knows what it has drawn.

This addresses that deficiency by teaching the getSelected() method
some new tricks so that it can consult the server in the various ways
appropriate to getting a list of /all/ the items on a selection list, a
purchase order, a virtual PO, a set of search results, etc.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoFix copy-paste-o: "su - postgres" to become postgres
Dan Scott [Wed, 5 Oct 2011 20:30:54 +0000 (16:30 -0400)]
Fix copy-paste-o: "su - postgres" to become postgres

Thanks to sal_ in IRC who caught this nugget!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoREADME: Explicitly identify accounts for commands
Dan Scott [Wed, 5 Oct 2011 17:12:30 +0000 (13:12 -0400)]
README: Explicitly identify accounts for commands

Add a preamble to the beginning listing all of the accounts referenced
in the instructions (Linux accounts, PostgreSQL accounts, Evergreen
administrator accounts). Also move the Developer Instructions to the
start to follow the natural order of operations.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAvoid collecting facet data for non-facet fields
Bill Erickson [Wed, 5 Oct 2011 19:16:17 +0000 (15:16 -0400)]
Avoid collecting facet data for non-facet fields

If a config.metabib_field (Admin -> Server Admin -> MARC Search/Facet
Fields) starts out as a facet field but is later changed, data for that
facet can still bubble up since it has already been extracted.  This
patch prevents facets for config.metabib_field entries whose
facet_field=false from getting collected/cached for search results.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoTPac: jump to details page on single hit
Bill Erickson [Tue, 4 Oct 2011 19:25:00 +0000 (15:25 -0400)]
TPac: jump to details page on single hit

When enabled, any time an OPAC search yields 1 result, the user will be
redirected to the record detail page for that result.  This change adds
2 new org unit settings, one to control the behavior in the staff
client, the other to control the public catalog.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoFix typo in lang.dtd: "instantenous"
Dan Scott [Wed, 5 Oct 2011 03:17:39 +0000 (23:17 -0400)]
Fix typo in lang.dtd: "instantenous"

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoi18n: Fix es-ES illegal use of '%' in lang.dtd
Dan Scott [Wed, 5 Oct 2011 03:04:15 +0000 (23:04 -0400)]
i18n: Fix es-ES illegal use of '%' in lang.dtd

The '%' character is used to include previously defined blocks in DTD
files; would be nice if translate-toolkit gave a more obvious error to
alert us to this rather than saying the en-US doesn't validate and
dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoSlightly updated about.html for rel_2_1
Dan Scott [Tue, 4 Oct 2011 18:40:44 +0000 (14:40 -0400)]
Slightly updated about.html for rel_2_1

Not sure we want to actually keep listing individuals in this file -
there's a lot more credit to spread around - but at least I can bring it
somewhat up to date with current info.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agopin version for upgrade script
Jason Etheridge [Tue, 4 Oct 2011 18:22:15 +0000 (14:22 -0400)]
pin version for upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoUnwrapped upgrade script for security lockdown
Thomas Berezansky [Mon, 15 Aug 2011 13:04:13 +0000 (09:04 -0400)]
Unwrapped upgrade script for security lockdown

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoRequire permission or pref to debug in client
Thomas Berezansky [Mon, 15 Aug 2011 12:59:31 +0000 (08:59 -0400)]
Require permission or pref to debug in client

Disables all debug functions I know of unless:

1 - You have new DEBUG_CLIENT permission (after login)

This should work even on operator change.
Once a given debug interface is open you can change operator back.

2 - You have a client with the debug preference enabled

This causes the client in all places I touched to think you have DEBUG_CLIENT
This also allows debugging *before* login, including in the Standalone interface.

Debug functions I know of:

Debug box on login page (already protected by pref)
Debug items in Admin menu
    Venkman
    Javascript Shells
    Inspector
    Chrome List
CTRL+SHIFT+F7 debug box in overlays

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoClear password from password_prompt post-login
Thomas Berezansky [Fri, 12 Aug 2011 13:17:46 +0000 (09:17 -0400)]
Clear password from password_prompt post-login

Otherwise it remains as the plain text value.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoi18n: Fix ru-RU lang.dtd problem
Dan Scott [Tue, 4 Oct 2011 18:13:43 +0000 (14:13 -0400)]
i18n: Fix ru-RU lang.dtd problem

No ampersands at the end of a string! Breaks moz2po horribly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agopin version for upgrade script
Jason Etheridge [Tue, 4 Oct 2011 17:20:41 +0000 (13:20 -0400)]
pin version for upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoSwitch to Modal printing
Thomas Berezansky [Mon, 12 Sep 2011 16:43:59 +0000 (12:43 -0400)]
Switch to Modal printing

Prevents an OS-level race condition on window focus.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoUnwrapped upgrade script for print.custom_js_file
Thomas Berezansky [Wed, 24 Aug 2011 15:32:15 +0000 (11:32 -0400)]
Unwrapped upgrade script for print.custom_js_file

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoRemove in-template javascript, add script files
Thomas Berezansky [Wed, 24 Aug 2011 15:31:59 +0000 (11:31 -0400)]
Remove in-template javascript, add script files

Adds support for a print_custom.js file and an org unit specified file.

If either exists and contains a print_custom function it will be called
before printing to allow for DOM manipulation.

If neither exists the print_win.js file will call all functions it has
defined.

In addition, if any code sets do_print to false the window will close
instead of attempting to print.

The print_custom function will receive the type of template used, if any.
This only applies to "Receipt Template" based print jobs, and the type in
question is the "Type" that shows in the template editor.

Functions defined in print_win.js:

print_init
    Main function, checks for print_custom and does final printing

print_do_sums
    Does summing of values.

print_check_alt
    Does swapping out of template blocks with display:none styling.

print_check_noprint
    Disables printing under certain circumstances.

For more information about usage of the print_do_sums, print_check_alt,
and print_check_noprint functions check the comments in print_win.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoStamped upgrade script for username limit settings
Bill Erickson [Tue, 4 Oct 2011 17:00:59 +0000 (13:00 -0400)]
Stamped upgrade script for username limit settings

Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoUnwrapped, badly named upgrade script
Thomas Berezansky [Mon, 26 Sep 2011 14:19:20 +0000 (10:19 -0400)]
Unwrapped, badly named upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoWording change on username error
Thomas Berezansky [Sun, 25 Sep 2011 02:37:22 +0000 (22:37 -0400)]
Wording change on username error

Add that they may be restricted by policy.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoUsername Change Limits
Thomas Berezansky [Sun, 25 Sep 2011 02:31:41 +0000 (22:31 -0400)]
Username Change Limits

Default is "Only allowed to change username if it looks like a barcode".

There is a "Lock Username Changes" option to disallow username changing via
the OPAC entirely, useful if syncing usernames to an outside source.

There is also a username change limit disabling option that, if enabled and
the Lock option is disabled, allows the previous behaviour of unlimited
username changes.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoUsername Rules
Thomas Berezansky [Sun, 25 Sep 2011 01:50:15 +0000 (21:50 -0400)]
Username Rules

In TPac, enforce the "username can't look like a barcode" rule.
Add new setting for username validation. If set, usernames must match.
Add patron registration checks for usernames:
    No spaces
    If set, can look like a barcode (initial/no username picked)
    If set, can look like a username
    If both set, must look like one of them

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoRequire password to change email/username
Thomas Berezansky [Sat, 24 Sep 2011 20:51:20 +0000 (16:51 -0400)]
Require password to change email/username

Alter backend to check password period, not just for password changes.
Add form elements for asking for current password to JSPac and TPac.
Add handling for said form elements where needed.
Add handling for "incorrect password" events in TPac.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoTPac: Default Password Strength Rule
Thomas Berezansky [Sat, 24 Sep 2011 20:28:29 +0000 (16:28 -0400)]
TPac: Default Password Strength Rule

Every other password interface seems to have it.
Implemented as a single regex in this case.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoWhen workstation is invalid request a new seed
Thomas Berezansky [Mon, 12 Sep 2011 17:33:03 +0000 (13:33 -0400)]
When workstation is invalid request a new seed

The original one may no longer be valid

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoMake more auth values configurable
Thomas Berezansky [Thu, 1 Sep 2011 20:41:33 +0000 (16:41 -0400)]
Make more auth values configurable

Amount of time seed is valid
Amount of time to keep failure count in memcache since last auth event
Number of failures before locking out auth attempts

Also, remove seed from memcache once it has been used once.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoBrute Force protection for authentication
Thomas Berezansky [Tue, 30 Aug 2011 15:55:35 +0000 (11:55 -0400)]
Brute Force protection for authentication

Count auth failures in memcache.
If 10+ have occurred cause failure.

After 90 seconds of no activity counter resets.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agolink asset.copy_template.status to config.copy_status in the IDL
Lebbeous Fogle-Weekley [Fri, 30 Sep 2011 17:37:58 +0000 (13:37 -0400)]
link asset.copy_template.status to config.copy_status in the IDL

If nothing else, this provides a dropdown for status in the copy
template editor (the one for Serials, under the admin menus, not the
one on the copy editing interface).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 years agoMake sure baseline schema is up to date
Mike Rylander [Tue, 4 Oct 2011 13:22:03 +0000 (09:22 -0400)]
Make sure baseline schema is up to date

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoFix update_db.sh to set eg_version correctly
Dan Scott [Tue, 4 Oct 2011 03:35:35 +0000 (23:35 -0400)]
Fix update_db.sh to set eg_version correctly

psql wants --set=VARNAME=VALUE, we had -set VARNAME=VALUE; tested this
fix and it works with PostgreSQL 9.0.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTPAC: Fix searchbar typo by closing div
Dan Scott [Tue, 4 Oct 2011 03:22:27 +0000 (23:22 -0400)]
TPAC: Fix searchbar typo by closing div

Nesting of divs was thrown off, resulting in the footer appearing in the
wrong place in search results / record display / etc, with the result
that the footer inherited the 974px width instead of full 100% width.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoLP865817: Fix Located URI visibility test
Dan Scott [Tue, 4 Oct 2011 02:34:47 +0000 (22:34 -0400)]
LP865817: Fix Located URI visibility test

Wrapped upgrade script for LP865817.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoCorrect Located URI visiblity
Mike Rylander [Mon, 3 Oct 2011 19:01:26 +0000 (15:01 -0400)]
Correct Located URI visiblity

Located URIs should be visible when they exist at the search context org unit
or an ancestor thereof.  However, before the change embodied in this commit,
they effectively acted exactly like copies, making records visible anywhere
within the context+depth range.

An example, using the stock example OU hierarchy:

 * Before this change, a Located URI with an owner of BR1 would cause its
record to show up in a search at (or scoped to via a depth parameter) BR1,
SYS1 or CONS.

 * Before this change, a Located URI with an owner of SYS1 would NOT cause its
record to show up in a search at (or scoped to via a depth parameter) BR1!

 * After this change, a Located URI with an owner of BR1 will cause its record
to show up only in a search with a context OU of BR1, irrespective of depth
scoping.

 * After this change, a Located URI with an owner of SYS1 WILL cause its
record to show up in a search with a context OU of BR1 or SYS1, regardless of
depth scoping.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTPAC: No need for a 26px padding on the header bottom
Dan Scott [Tue, 4 Oct 2011 02:03:00 +0000 (22:03 -0400)]
TPAC: No need for a 26px padding on the header bottom

26px on the bottom of the header was giving a bit too much space to the
header.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoTPAC: Replace dashboard images with CSS
Dan Scott [Tue, 4 Oct 2011 01:58:17 +0000 (21:58 -0400)]
TPAC: Replace dashboard images with CSS

Also gets rid of a number of tables and a bunch of CSS definitions with
hard-coded widths that will cause trouble when longer translated terms
get dropped into place.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years agoTpac: expand facet display fix
Bill Erickson [Mon, 3 Oct 2011 15:52:34 +0000 (11:52 -0400)]
Tpac: expand facet display fix

When only one facet is collapsed, make sure we can expand it.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTPac: Facets on results page
Bill Erickson [Fri, 30 Sep 2011 20:01:22 +0000 (16:01 -0400)]
TPac: Facets on results page

Show search facets along the left side of the results page.  Clicking on
a facet re-runs the current search with the  new facet appeneded.
Selected facets are styled to indicate they are selected.  Clicking on a
selected facet removes that facet from the set of selected facets (i.e.
it backs out the facet).

TODO: update CSS to match default Evergreen skin

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoJSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ...
Lebbeous Fogle-Weekley [Mon, 3 Oct 2011 20:03:00 +0000 (16:03 -0400)]
JSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ...

... when search scope would have it so.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTweak the tab shape in TT OPAC
Michael Peters [Mon, 3 Oct 2011 20:07:30 +0000 (16:07 -0400)]
Tweak the tab shape in TT OPAC

A slight modification to the "tab" elements throughout the OPAC to make them look more like tabs on a file folder.  I
found the rounded off bottoms less attractive, so I flattened them out to flow more evenly with the rest of the page.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoHave TTPac utilize gradient friendly, transparent PNG files for the Evergreen logo
Michael Peters [Mon, 3 Oct 2011 14:47:22 +0000 (10:47 -0400)]
Have TTPac utilize gradient friendly, transparent PNG files for the Evergreen logo

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoTPAC: Simple CSS gradients for the header/footer
Dan Scott [Mon, 3 Oct 2011 02:59:28 +0000 (22:59 -0400)]
TPAC: Simple CSS gradients for the header/footer

Firefox, Safari, Chrome, Opera, and the Android browser support
gradients. Use them. iOS 5 will support gradients. IE does not,
naturally, but support is promised for IE 10.

Including better IE support.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoTPAC: Remove the printnav bar from all screens
Dan Scott [Tue, 20 Sep 2011 13:20:06 +0000 (09:20 -0400)]
TPAC: Remove the printnav bar from all screens

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoRevamp the search bar to a narrative, single-line style
Dan Scott [Tue, 20 Sep 2011 13:19:41 +0000 (09:19 -0400)]
Revamp the search bar to a narrative, single-line style

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoAdd the remaining extras back to the record details
Dan Scott [Tue, 20 Sep 2011 03:09:51 +0000 (23:09 -0400)]
Add the remaining extras back to the record details

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoTPAC: and then there were series
Dan Scott [Tue, 20 Sep 2011 02:49:55 +0000 (22:49 -0400)]
TPAC: and then there were series

Also, tighten up spacing considerably.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoMove the copies up higher
Dan Scott [Mon, 19 Sep 2011 23:55:08 +0000 (19:55 -0400)]
Move the copies up higher

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoRemove "Expand all extras" as there are fewer extras to expand
Dan Scott [Mon, 19 Sep 2011 23:43:28 +0000 (19:43 -0400)]
Remove "Expand all extras" as there are fewer extras to expand

Cleaner.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
12 years agoGoing for the Jungle skin feel (like Amazon)
Dan Scott [Mon, 19 Sep 2011 22:59:25 +0000 (18:59 -0400)]
Going for the Jungle skin feel (like Amazon)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>