Evergreen.git
8 years agoClear shelf canceled holds notification fix
Bill Erickson [Mon, 24 Oct 2011 20:27:29 +0000 (16:27 -0400)]
Clear shelf canceled holds notification fix

After cancelling a batch of holds via the clear-shelf process, before we
send the holds off to action/trigger for potential notification
generation, re-fetch the holds from the DB to pick up the calculated
cancel_time value (i.e. get a real value for "now").  Otherwise, A/T may
die attempting to create a DateTime object by parsing "now".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPac; hold success confirmation; redirect repairs
Bill Erickson [Wed, 2 Nov 2011 15:28:57 +0000 (11:28 -0400)]
TPac; hold success confirmation; redirect repairs

1. After a successful hold placement, provide feedback to the user that
the hold placement succeeded.  After placement, the user is taken to a
page (same page for failed holds) where the title(s) are listed along
with the success/failure information for each.

2. In some cases, the user may be redirected to the my account page
instead of the point of origin for holds placement.  This occurs
generally when the user is not already logged in and is asked to log in
prior to holds placement.

3. As a side effect, this change replaces one of the ornery
history.go(-1) actions with a true href/URL.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTPac; reduce vertical space caused by chilifresh link
Bill Erickson [Thu, 3 Nov 2011 14:18:12 +0000 (10:18 -0400)]
TPac; reduce vertical space caused by chilifresh link

CSS loaded from chilifresh forces a fixed height on the
.chili_review class, which causes significant vertical space gobbling in
the results and details pages.  Solution is to change the chili_review
container from a <div> to a <span>, where the height has no effect.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMake idlval build, rather than be dead code
Dan Scott [Sun, 23 Oct 2011 23:58:53 +0000 (16:58 -0700)]
Make idlval build, rather than be dead code

The tool "idlval" contained in Open-ILS/src/c-apps can be used to check
the correctness of fieldmapper definitions in files like
Open-ILS/examples/fm_IDL.xml - but currently does not have a build
target, nor does it compile cleanly due to the use of unspecified
OpenSRF header files. This commit adds a build target, fixes the compile
problems, and installs the tool in the bin directory.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAdd link to cbs from bre via bre.source -> cbs.id in fm_IDL.xml.
Jason Stephenson [Tue, 8 Nov 2011 19:39:29 +0000 (14:39 -0500)]
Add link to cbs from bre via bre.source -> cbs.id in fm_IDL.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoShow the patron account Create Date in both horizontal and vertical patron summary...
Jason Etheridge [Tue, 8 Nov 2011 20:01:43 +0000 (15:01 -0500)]
Show the patron account Create Date in both horizontal and vertical patron summary panes

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP887822 mint_condition/Quality not set correctly
Jason Etheridge [Tue, 8 Nov 2011 23:42:18 +0000 (18:42 -0500)]
LP887822 mint_condition/Quality not set correctly

during item creation.

Specifically, the Javascript object for a new item (acp) does not explicitly set
the mint_condition field, leaving it null. The item attribute editor treats the
null as false (which it displays as "Mediocre" for that field). The database has
a not null constraint the corresponding column in asset.copy, and defaults to
true. So a new item in the attribute editor will show "Mediocre", but when
actually created, will become "Good".

This branch just sets mint_condition to true when an item is created.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTpac; repair login link after password reset
Bill Erickson [Wed, 9 Nov 2011 15:13:28 +0000 (10:13 -0500)]
Tpac; repair login link after password reset

After a successful password reset, the UI offers a link to "Log In to My
Account".  Loging in this way would ultimately redirect the user back to
the password reset form.  This patch updates the Log In link to point to
myopac/main, which will direct the user to log in first,  instead of
pointing directly to /login, which, lacking any other information,
will return the user to the referer after logging in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMerge remote-tracking branch 'eg-working/collab/berick/lp_888239_prevent_post-capture...
Mike Rylander [Tue, 15 Nov 2011 16:48:15 +0000 (11:48 -0500)]
Merge remote-tracking branch 'eg-working/collab/berick/lp_888239_prevent_post-capture_hold_suspend'

8 years agoTPac; propagate query params to adv search (results link)
Bill Erickson [Fri, 11 Nov 2011 18:22:34 +0000 (13:22 -0500)]
TPac; propagate query params to adv search (results link)

Update the "Advanced Search" link that shows on search results pages
(next to "Another Search") to propagate the current query into the
advanced search page, just like the Advanced Search link just above the
search bar.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agotpac; honor password reset matching email setting
Bill Erickson [Fri, 11 Nov 2011 20:25:49 +0000 (15:25 -0500)]
tpac; honor password reset matching email setting

If the "circ.password_reset_request_requires_matching_email" org unit
setting is enable, prompt the user to enter the email address associated
with the account and subsequently pass it on to the password_reset api
call.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoSerials: in the holding code mini-wizard, offer a dropdown for seasons
Lebbeous Fogle-Weekley [Mon, 14 Nov 2011 20:31:14 +0000 (15:31 -0500)]
Serials: in the holding code mini-wizard, offer a dropdown for seasons

This spares the user from having to remember the MFHD code for the
season, when dealing with periodicals issued by season (21 - 24 for
Spring - Winter, respectively).

This also applies sets the "scrollOnFocus" attribute to false for the
dijits within the mini wizard, as the jumpy behavior you get in
less-than-fullscreen staff client windows is otherwise maddening.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agotpac; improve ssl and authentication redirection
Bill Erickson [Mon, 14 Nov 2011 21:27:05 +0000 (16:27 -0500)]
tpac; improve ssl and authentication redirection

Create a better separation between pages the require SSL and those
that also require authentication.  This change has a number of
beneficial side effects:

1. If a user is already logged in and is somehow redirected to the
non-SSL version of a page requiring SSL (via, for example, some external
link), they are simply taken to the SSL equivlent of the page first.  If
they are found to be logged in, we're done.  If not, they are directed to
the login page like usual.

2. password_reset page now requires SSL (but not auth, obviously)

3. Removed the unnecessary warning about logging out on a non-SSL
connection.  We now redirect the user to the SSL version of logout so,
if they are in fact logged in, they can be successfully logged out.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoMake checkin retargeting parts-aware
Thomas Berezansky [Wed, 26 Oct 2011 13:45:54 +0000 (09:45 -0400)]
Make checkin retargeting parts-aware

Skip part holds on copies san parts
Skip part holds for parts not on the copy
Skip title holds for copies with parts

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoMore filtering of characters that could end up in PO JEDI template output
Lebbeous Fogle-Weekley [Tue, 11 Oct 2011 15:25:51 +0000 (11:25 -0400)]
More filtering of characters that could end up in PO JEDI template output

Backslashes cause problems too.  Let's JSON encode this thing and get it
right once and for all.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoSerials: allow freer input in holding code mini-wizard
Lebbeous Fogle-Weekley [Thu, 10 Nov 2011 22:22:22 +0000 (17:22 -0500)]
Serials: allow freer input in holding code mini-wizard

In the Subscription Details interface of the Alternate Serials Control
View, under the Issuance tab, if you create a new issuance you can
now enter things like "01/02" in (say) the month field to denote a combined
January/February issue.  All those fields are now free-form, whereas some of
them used to be numeric only.

Also, avoid an occasional issue where an error message about
dijit.form.DateTextBox not being a constructor would appear in the
JavaScript console.  The problem was in a race condition among some
co-dependent JavaScript files that were all being loaded at the same
time.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoLP88653 force SSL for requests from local XUL
Jason Etheridge [Thu, 10 Nov 2011 17:55:32 +0000 (12:55 -0500)]
LP88653 force SSL for requests from local XUL

Modifies RemoteRequest.js to convert any http:// request URL to https:// if the
requesting location has a chrome:// protocol.

Modifies util/network.js such that any use of util.network.request (as opposed
to util.network.simple_request) will assume "secure" for the resulting request.

Adds an example to the bottom of eg_vhost.conf for forcing SSL for an entire
site (OPAC and everything), courtesy of Dan Wells.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoFedora 16 updates to README and Makefile.install
Dan Scott [Thu, 10 Nov 2011 06:04:50 +0000 (01:04 -0500)]
Fedora 16 updates to README and Makefile.install

Fedora 16 is out, we can improve the README and Makefile.install some to
better support it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac; disallow certain actions for captured holds
Bill Erickson [Wed, 9 Nov 2011 20:55:50 +0000 (15:55 -0500)]
TPac; disallow certain actions for captured holds

In the hold edit page, where users can update the pickup library,
suspend holds, etc. disallow actions that don't make sense for holds
that have already been captured.  These include suspending the hold and
changing the expire time.

This patch also replaces the confusing "Cancel" button in the hold edit
interface (which does not cancel the hold) with a "Go Back" button which
returns to the holds list.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPac; batch hold update detects suspension of captured hold
Bill Erickson [Wed, 9 Nov 2011 20:54:21 +0000 (15:54 -0500)]
TPac; batch hold update detects suspension of captured hold

If the user attempts to suspend a captured hold via batch hold update,
warn that user af the update the some holds may not have been suspended
and why.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoPrevent hold suspencion for captured holds in API
Bill Erickson [Wed, 9 Nov 2011 20:51:40 +0000 (15:51 -0500)]
Prevent hold suspencion for captured holds in API

This codifies at the API layer the standard Evergreen practice of
disallowing suspension of holds that have already been captured.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoprevent suspend in transit initial poking
Bill Erickson [Wed, 9 Nov 2011 19:08:10 +0000 (14:08 -0500)]
prevent suspend in transit initial poking

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoXML.ignoreWhitespace causes syntax errors
Thomas Berezansky [Wed, 9 Nov 2011 16:00:05 +0000 (11:00 -0500)]
XML.ignoreWhitespace causes syntax errors

So remove it.

Disabling pretty printing appears to be enough to fix the marc editor.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoFix a typo that snuck through the cracks in Cronscript.pm.in.
Jason Stephenson [Wed, 9 Nov 2011 14:37:44 +0000 (09:37 -0500)]
Fix a typo that snuck through the cracks in Cronscript.pm.in.

We had Opensrf::AppSession rather than OpenSRF::AppSession, which isn't
caught by the simple use_ok() tests that we largely rely on for our
current Perl test suite. In addition, when we manually tested the change
to Cronscript.pm.in, we didn't do both configure && make to ensure that
the new version of Cronscript.pm reflected the changes. Lots to learn,
luckily the method wasn't being used by anything else in Evergreen yet.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoFix vanishing whitespace in marc editor
Thomas Berezansky [Mon, 7 Nov 2011 22:28:02 +0000 (17:28 -0500)]
Fix vanishing whitespace in marc editor

XML.ignoreWhitespace and XML.prettyPrinting cause whitespace to vanish.

So disable them at the top of marcedit.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agolp849447: trival stylistic tweaks
Galen Charlton [Mon, 31 Oct 2011 15:46:48 +0000 (11:46 -0400)]
lp849447: trival stylistic tweaks

- rename variable avoid double-negative
- avoid 'Variable declared in conditional statement' perlcritic gripe

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoProtect against slony replication lag, LP#621448
Mike Rylander [Tue, 8 Nov 2011 17:43:44 +0000 (12:43 -0500)]
Protect against slony replication lag, LP#621448

Make open-ils.circ.captured_holds.id_list.* API calls authoritative within
the staff client to avoid replication-lag related stale displays.  Inspired
by James Fournie at SITKA.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoREADME: Use consistent endings (none!) for titles/subtitles
Dan Scott [Mon, 7 Nov 2011 21:44:42 +0000 (16:44 -0500)]
README: Use consistent endings (none!) for titles/subtitles

Most, but not all, of the titles/subtitles had colons appended. This
looks really weird in the Table of Contents, so try to be consistently
unweird and have no appended colons.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoBackup the existing opensrf config files before copying
Dan Scott [Mon, 7 Nov 2011 21:38:32 +0000 (16:38 -0500)]
Backup the existing opensrf config files before copying

Per a suggestion from Wolf Halton <wolf.halton@gmail.com>, create backup
versions of the opensrf configuration files when we're copying the
Evergreen example versions over, so that we can retrieve the Jabber user
names and passwords and domains from the backups (if necessary).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac; detail page "Search Results" page correction
Bill Erickson [Thu, 3 Nov 2011 19:51:41 +0000 (15:51 -0400)]
TPac; detail page "Search Results" page correction

On the detail page, when the user selects the "Search Results" link to
return the original search results, return to the correct page in the
search.  The correct page will be the page where the currently viewed
record sits within the search.  Normally, this is the last viewed
results page.  However, if the user does some paging within the detail
page, enough to cross a page boundry, "Search Results" will take them to
the new page (i.e. the page w/ the current record).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac; sort items out list by due date, oldest first
Bill Erickson [Wed, 2 Nov 2011 19:45:06 +0000 (15:45 -0400)]
TPac; sort items out list by due date, oldest first

Sort items most in need of return (i.e. oldest due date) to top.  This
is done by replacing the call to "open-ils.actor.user.checked_out",
which does a lot more than we need, in a way that does not support
sorting/paging, with a simple json_query.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoClose All Tabs shortcut
Thomas Berezansky [Wed, 28 Sep 2011 23:00:56 +0000 (19:00 -0400)]
Close All Tabs shortcut

Enable CTRL+Click on the close tab "X" to close all tabs.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoLP#860845 hold placement UI can break
Jason Etheridge [Tue, 27 Sep 2011 19:42:49 +0000 (15:42 -0400)]
LP#860845 hold placement UI can break

hold placement UI can break and give misleading error on Submit

Adds some defensive coding, but since I don't quite grok everything going on here, may not be the best fix.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoSkip forced targeting of frozen holds
Thomas Berezansky [Tue, 13 Sep 2011 18:48:16 +0000 (14:48 -0400)]
Skip forced targeting of frozen holds

Otherwise a frozen hold can be manually retargeted by staff and captured.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAcq: List provider code in lineitem lists
Bill Erickson [Thu, 15 Sep 2011 18:57:19 +0000 (14:57 -0400)]
Acq: List provider code in lineitem lists

Along with selection list and purchase order, when an item is attached
to a purchase order, also show the provider code

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac; improved UPC extraction
Bill Erickson [Mon, 24 Oct 2011 17:52:14 +0000 (13:52 -0400)]
TPac; improved UPC extraction

Handle the case where a record has multiple UPC's.  When this occurs,
use the first UPC as the value for added content lookups as necessary.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoThis prevents the acq unified_search method from returning anything other
James Fournie [Tue, 1 Nov 2011 23:01:57 +0000 (16:01 -0700)]
This prevents the acq unified_search method from returning anything other
than the objects of the expected type.

This is to address LP 884991 in which Acq users get a perm error for each
result of a search that they don't have access to retrieve.  They shouldn't
even know about the existence of anything they don't have access to retrieve.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTpac; hold error message 18n string extraction repairs
Bill Erickson [Wed, 2 Nov 2011 13:47:04 +0000 (09:47 -0400)]
Tpac; hold error message 18n string extraction repairs

Make it possible for xgettext.pl (using
Locale::Maketext::Extract::Plugin::TT2) to extract hold error
message strings for translation.  The plugin is not quite
smart enough to extract wholly dynamic values from the templates, since
it (presumably) only parses the templates and does not execute them.
The solution is to wrap the strings in l() where they are defined.

Add an example for the EVENT_MSG_MAP for the event PATRON_EXCEEDS_FINES.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCorrect oversight: replace old with new approach to upgrade script versioning
Lebbeous Fogle-Weekley [Fri, 4 Nov 2011 20:44:57 +0000 (16:44 -0400)]
Correct oversight: replace old with new approach to upgrade script versioning

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoPreviously invisible copies showed as beige in the staff client, they stopped doing...
James Fournie [Tue, 20 Sep 2011 19:03:03 +0000 (12:03 -0700)]
Previously invisible copies showed as beige in the staff client, they stopped doing this in 2.0

This is because in 2.0 the copy counts logic was moved from open-ils.storage.biblio.record_entry.copy_count.staff
to an in-database function wrapped in open-ils.search.biblio.record.copy_count.staff.  Both methods returned various
counts including an 'unshadow' count, however the 'unshadow' in the new database function was not completed and it
has only been returning a simple copy count rather than a count of opac visible copies as it should be to
replicate the old behaviour.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoAcq: better error message if trying to create PO without provider or agency
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 20:13:51 +0000 (16:13 -0400)]
Acq: better error message if trying to create PO without provider or agency

Before now, if you leave either the provider or ordering agency
fields blank in the "Create Purchase Order" dialog, you get a
nonsensical warning about prepayment.

This fixes that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoModified authority.indexing_ingest_or_delete to update MARC data
Liam Whalen [Thu, 3 Nov 2011 20:53:57 +0000 (16:53 -0400)]
Modified authority.indexing_ingest_or_delete to update MARC data

The authority.indexing_ingest_or_delete trigger in the update script
was missing a call to authority.propagate_changes which is responsible
for updating the MARC data of records affected by an auhtority merge.
This patch adds the call to authority.propagate_changes as it appears
in the authority.indexing_ingest_or_delete trigger from the file
999.functions.global.sql.

Signed-off-by: Liam Whalen <lwhalen@nrcan-rncan.gc.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoRepair Vandelay match_set_tree link
Bill Erickson [Fri, 21 Oct 2011 16:36:48 +0000 (12:36 -0400)]
Repair Vandelay match_set_tree link

ctx.base_path includes the "/eg" portion of the path, so no need to
duplicate that in the template.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAcq: fix a bug that sometimes prevents the general search page from loading
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 16:06:09 +0000 (12:06 -0400)]
Acq: fix a bug that sometimes prevents the general search page from loading

Within Acquisitions General Search, javascript included from one file
in the <head> relies on the variable "localeStrings" being initialized
by javascript included from a file in <body>.  Sometimes the wrong
javascript wins the race, you get an error about localeStrings being
undefined in the Javascript console, and the page stops loading.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoFine generator; raise multi-session mode recv timeout
Bill Erickson [Tue, 1 Nov 2011 21:02:44 +0000 (17:02 -0400)]
Fine generator; raise multi-session mode recv timeout

When fetching the batch of overdue circ IDs to process for fine
generation, wait a little longer for the data to arrive, since
it is a longer running DB query than most.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoforgot to update upgrade_log
Jason Etheridge [Tue, 1 Nov 2011 20:18:37 +0000 (16:18 -0400)]
forgot to update upgrade_log

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agopin upgrade version number
Jason Etheridge [Tue, 1 Nov 2011 19:58:15 +0000 (15:58 -0400)]
pin upgrade version number

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoProtect SVF normalizers against NULL values
Mike Rylander [Tue, 1 Nov 2011 19:49:15 +0000 (15:49 -0400)]
Protect SVF normalizers against NULL values

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoForce Amazon AC requests to use 10-digit ISBNs
Dan Scott [Tue, 1 Nov 2011 17:29:25 +0000 (13:29 -0400)]
Force Amazon AC requests to use 10-digit ISBNs

Inspired by a patch submitted by Ian Bays <ian.bays@ptfs-europe.com>
via https://bugs.launchpad.net/evergreen/+bug/870171, this patch takes
the incoming key and, if it is longer than 10 characters (a 10-digit
ISBN or Amazon ID), attempts to normalize it and return a 10-digit ISBN.

We don't normalize all incoming keys because some sites are horribly
abusing the 020 MARC field to include an Amazon ID instead of an ISBN -
but that works in practice and we'd rather not break working
installations if we can avoid it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoUse ne on line 631 of Actor.pm.
Jason Stephenson [Wed, 19 Oct 2011 20:47:03 +0000 (16:47 -0400)]
Use ne on line 631 of Actor.pm.

This is so that we stop getting errors like

Argument "1319057146.8881216485.4819607085" isn't numeric in numeric ne (!=) at
/usr/local/share/perl/5.10.1/OpenILS/Application/Actor.pm line 630.

in /openils/var/log/open-ils.actor_stderr.log

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTpac; bookbag MARC retrieved via unapi
Bill Erickson [Tue, 1 Nov 2011 15:35:41 +0000 (11:35 -0400)]
Tpac; bookbag MARC retrieved via unapi

Make sure the bookbag interface has access to metabib.record_attr's by
retrieving and parsing the marcxml via unapi (get_records_and_facets).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTrivial whitespace touchup to Cronscript.pm.in
Dan Scott [Mon, 31 Oct 2011 20:56:55 +0000 (16:56 -0400)]
Trivial whitespace touchup to Cronscript.pm.in

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoOpenILS::Utils::Cronscript can have only 1 session.
Jason Stephenson [Mon, 31 Oct 2011 20:36:27 +0000 (16:36 -0400)]
OpenILS::Utils::Cronscript can have only 1 session.

Work around the above limitation by using OpenSRF::AppSession
to create a session for open-ils.auth in the authenticate method.

Also requires us to manually check if we're bootstrapped, since
we can't rely on OpenILS::Utils::Cronscript->session to do it for
us.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoAdd authentication capability to OpenILS::Utils::Cronscript.
Jason Stephenson [Mon, 31 Oct 2011 19:48:38 +0000 (15:48 -0400)]
Add authentication capability to OpenILS::Utils::Cronscript.

This allows the client script to call authenticate with a hash ref of
user information so that the user can login and get an authtoken if
needed.

It also stores the authtoken and authtime values for later retrieval.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTpac: show staff saved searches on no-results page
Lebbeous Fogle-Weekley [Mon, 31 Oct 2011 15:00:02 +0000 (11:00 -0400)]
Tpac: show staff saved searches on no-results page

Not having it there is awkward for the user who relies on the feature
and enters a search term that gets no results.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTpac: staff saved searches expand/collapse, use right ou context for setting
Lebbeous Fogle-Weekley [Thu, 27 Oct 2011 22:20:00 +0000 (18:20 -0400)]
Tpac: staff saved searches expand/collapse, use right ou context for setting

1) Display staff saved searches collapsed by default. This makes the facet
display right underneath it more accessible in the case of long search
histories.

2) When checking the org unit setting for the limiting number of
searches to save, use the user's ws_ou as the context, since this is a
staff-client feature.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoA tweak to eg.conf to prevent against the BEAST exploit in TLS/SSL
Michael Peters [Thu, 27 Oct 2011 13:42:37 +0000 (09:42 -0400)]
A tweak to eg.conf to prevent against the BEAST exploit in TLS/SSL

Based on recommedation from https://community.qualys.com/blogs/securitylabs/2011/10/17/mitigating-the-beast-attack-on-tls

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoTpac: fix the doubly wrapped holds editor
Lebbeous Fogle-Weekley [Fri, 28 Oct 2011 14:40:03 +0000 (10:40 -0400)]
Tpac: fix the doubly wrapped holds editor

For some reason it must have made since in the past to wrap this
interface in both parts/base.tt2 and myopac/parts/base.tt2, but
nowadays that results in having extra headers and footers around
the actual page contents, so the layout looks broken.

This fixes that. No other interfaces were doing this double wrapping.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTpac: Rename orig_loc to physical_loc, for clarity's sake.
Lebbeous Fogle-Weekley [Fri, 28 Oct 2011 17:49:42 +0000 (13:49 -0400)]
Tpac: Rename orig_loc to physical_loc, for clarity's sake.

This is an OPAC parameter not so much meant for use by patrons at home,
but for users at machines physically located in libraries.  In
conjunction with OpenILS::WWW::Redirector, it helps those machines
"remember" what branch they're in.

Anyway, the name orig_loc doesn't make the parameter's meaning quite as
clear as it could whne you encounter it in code.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTpac: clear the per-process cache of org-unit settings on each page load
Lebbeous Fogle-Weekley [Thu, 27 Oct 2011 21:37:06 +0000 (17:37 -0400)]
Tpac: clear the per-process cache of org-unit settings on each page load

Any time saved is not worth the confusion of changes to org unit settings not
taking effect in the TPAC without an apache restart, or worse, taking
effect for some page loads but not others.

Actually authored by Bill.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping upgrade script for YAOUS-target-when-closed
Mike Rylander [Fri, 28 Oct 2011 15:09:32 +0000 (11:09 -0400)]
Stamping upgrade script for YAOUS-target-when-closed

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoAdd and use two YAOUS to allow hold targeting on copies at closed OUs
Lebbeous Fogle-Weekley [Wed, 28 Sep 2011 18:28:35 +0000 (14:28 -0400)]
Add and use two YAOUS to allow hold targeting on copies at closed OUs

One YAOUS completely ignores the closedness of the circ lib of the copy
being tested for potential targeting.

The other YAOUS ignores the closedness of the circ lib IFF the circ lib of
the copy being tested matches the pickup lib of the hold request.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTpac; holds edit page format icon improvements
Bill Erickson [Thu, 27 Oct 2011 16:12:40 +0000 (12:12 -0400)]
Tpac; holds edit page format icon improvements

* Fixed the image path to the format_icon
* Use the format_label as the title for the format_icon image

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac; sort coded value maps by label alphabetically
Bill Erickson [Thu, 27 Oct 2011 17:03:26 +0000 (13:03 -0400)]
TPac; sort coded value maps by label alphabetically

Affects languages, formats, and audience.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTpac; style due-date red/error for overdue items
Bill Erickson [Thu, 27 Oct 2011 19:10:23 +0000 (15:10 -0400)]
Tpac; style due-date red/error for overdue items

In the patrons items out list, if an item is overdue, style the due date as
"error" (i.e. bold red).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoLP#860685 List Actions and Print List fix
Jason Etheridge [Tue, 27 Sep 2011 15:56:51 +0000 (11:56 -0400)]
LP#860685 List Actions and Print List fix

List Actions and Print List broken in Check In interface when not using "Fast
Entry (Asynchronous)", due to the way we're using list.refresh_row.  This fixes
the internal list state for tracking retrieved versus un-retrieved list rows.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP874597 password from phone # when cloning users
Jason Etheridge [Fri, 14 Oct 2011 20:42:20 +0000 (16:42 -0400)]
LP874597 password from phone # when cloning users

Patron: password from phone # does not work when cloning users

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoZ39.50 service filter repairs
Bill Erickson [Wed, 26 Oct 2011 18:56:01 +0000 (14:56 -0400)]
Z39.50 service filter repairs

Do not attempt to filter out Z39.50 services by permission when
retrieveing the services in a non-authenticate manner (i.e. from within
the Z39.50 code).  Otherwise, the code will die on $e->requestor->id,
because there is no requestor.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoZ39.50 local catalog fetch-more repairs
Bill Erickson [Wed, 5 Oct 2011 13:39:47 +0000 (09:39 -0400)]
Z39.50 local catalog fetch-more repairs

Fixes the following problem:

When paging through local catalog results in the Z39.50 interface,
paging off then end of the local results would result in an unknown
server error caused by trying to retrieve an empty list of records.

$list->{count} in this context is the overall hit count, not the counts
in the current page of results.  Note also if {count} is zero, the list
of IDs will be undef, so we use both.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
8 years agoSIP2 Checkout "no-code" failure fix
Thomas Berezansky [Fri, 26 Aug 2011 20:19:13 +0000 (16:19 -0400)]
SIP2 Checkout "no-code" failure fix

Instead of assuming that code exists on a response do more checks.

Specifically, a response code can be empty but not zero when there is no
defined event code for the failure code.

An easily tested case of this is standing penalties.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoStamping Upgrade script to populate authority.simple_heading
Thomas Berezansky [Wed, 26 Oct 2011 22:35:04 +0000 (18:35 -0400)]
Stamping Upgrade script to populate authority.simple_heading

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoUpgrade script to populate authority.simple_heading
Mike Rylander [Wed, 26 Oct 2011 17:05:17 +0000 (13:05 -0400)]
Upgrade script to populate authority.simple_heading

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAvoid a possible bug in selection list deletion
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 22:06:22 +0000 (18:06 -0400)]
Avoid a possible bug in selection list deletion

This particularly matters for the "ephemeral," unnamed selection list that
Acquisitions General Search uses to hold bib records represented as
lineitems, as that list is deleted for the next run of that kind of
search.

It's possible to get lineitems onto that list that are in a state
other than "new".  Code that deletes this list first deletes the
lineitems that belong to it, but that code formerly assumed that there
are two types of lineitems. "new" ones (that should be deleted) and ones
that belong to purchase orders (that should be deatched).  That doesn't
necessarily cover all possible lineitems on the picklist, so deletion
ultimately fails.

This fixes that.

[update: now this bugfix incorporates a bugfix, the need for which was
detected by Ben Shum. See LP #869581]

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoProvide a QP modifier for sorting NULLS FIRST in the core SQL
Mike Rylander [Tue, 25 Oct 2011 15:53:25 +0000 (11:53 -0400)]
Provide a QP modifier for sorting NULLS FIRST in the core SQL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoTiny bookbag improvements
Lebbeous Fogle-Weekley [Wed, 19 Oct 2011 21:53:58 +0000 (17:53 -0400)]
Tiny bookbag improvements

Bookbag feed item sort order now defined

Bookbag list sort order on the "My Lists" page is now less agressively
propagated

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPac; holds format icon follow-up fix
Bill Erickson [Thu, 20 Oct 2011 15:39:40 +0000 (11:39 -0400)]
TPac; holds format icon follow-up fix

'bre' is no longer available to the templates.  use bre_id instead.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTpac; repair format icon display in holds lists
Bill Erickson [Thu, 20 Oct 2011 14:37:39 +0000 (10:37 -0400)]
Tpac; repair format icon display in holds lists

* Fetch MARC XML from unapi to pick up metabib::record_attr's for each
record.

* Update format icon code in holds list to use new-style precompiled
format_icon

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPAC: avoid problem with HOLD_EXISTS event in hold placement
Lebbeous Fogle-Weekley [Wed, 19 Oct 2011 22:16:14 +0000 (18:16 -0400)]
TPAC: avoid problem with HOLD_EXISTS event in hold placement

If you place a hold on something that generates a HOLD_EXISTS event (and
no other events?) you get a 500 error from Apache and an error in the
logs saying "not a hash reference" about $result in the lines I've
changed here.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
8 years agoTPac; use canned get_hold_status call for history UI
Bill Erickson [Wed, 19 Oct 2011 21:17:41 +0000 (17:17 -0400)]
TPac; use canned get_hold_status call for history UI

For consistency, use the same get_hold_status BLOCK to determine holds
status display in the holds history UI.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoLP875819: Fix SRU and Z39.50 default search index failures
Dan Scott [Sun, 16 Oct 2011 16:45:52 +0000 (12:45 -0400)]
LP875819: Fix SRU and Z39.50 default search index failures

Per http://www.loc.gov/standards/sru/specs/cql.html :

All parts of CQL are case insensitive [...] If any case insensitive
part of CQL is specified with both upper and lower case, it is
for aesthetic purposes only.

So fold the SRU qualifier and relation to lower case. This then
matches the srw.serverchoice entry that we already have in
config.metabib_search_alias so that default searches will successfully
point to the keyword index.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac; Fetch authoritative user object in my-account
Bill Erickson [Wed, 19 Oct 2011 20:53:44 +0000 (16:53 -0400)]
TPac; Fetch authoritative user object in my-account

Since user data changes in my-account, any time we fetch the fleshed
user object, fetch it within a transaction to avoid retrieval from a
(potentially lagging) DB replica.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoFix README issues
Dan Scott [Wed, 19 Oct 2011 20:00:58 +0000 (16:00 -0400)]
Fix README issues

Martha Driscoll <driscoll@noblenet.org> noted that the
create_database.sql script wasn't actually targeted by the psql command,
and also that there was an extraneous <code> tag in the OpenSRF start
command.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoCStoreEditor batch_retrieve repairs
Bill Erickson [Wed, 19 Oct 2011 17:42:16 +0000 (13:42 -0400)]
CStoreEditor batch_retrieve repairs

1. If the caller provides additional cstore params, like flesh,
flesh_fields, etc. make sure we only use the first component of the
search (the list of identifier values) for the cstore search.

2. Determine the identifier field from the class being retrieved instead
of hard-coding it to be "id"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoACQ: Add open holds count to lineitem worksheet
Bill Erickson [Tue, 20 Sep 2011 19:44:12 +0000 (15:44 -0400)]
ACQ: Add open holds count to lineitem worksheet

Includes a generic bre_open_holds_count reactor utility method

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac: Put staff saved searches in same div as facets on the results page
Lebbeous Fogle-Weekley [Wed, 19 Oct 2011 04:57:28 +0000 (00:57 -0400)]
TPac: Put staff saved searches in same div as facets on the results page

Also: make a minor improvement to bookbag sorting clicking heading sort
links a second time reverses order.

And on the record page, make them less ugly. We need to get rid of this
974-px-wide business. It's ridiculous, and it keeps us busy fighting CSS
just to keep a silly grey margin on the right side of the display, and
it keeps us from using all available space.  We need to simplify the CSS
greatly, in fact. Let's bite that bullet sooner than later.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTiny follow up to previous commit regarding sorting bookbag items
Lebbeous Fogle-Weekley [Wed, 19 Oct 2011 04:36:58 +0000 (00:36 -0400)]
Tiny follow up to previous commit regarding sorting bookbag items

Do the same thing to the sorter for the anonymous list

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoTPac: Put staff saved searches in same div as facets on the results page
Lebbeous Fogle-Weekley [Wed, 19 Oct 2011 03:38:53 +0000 (23:38 -0400)]
TPac: Put staff saved searches in same div as facets on the results page

And on the record page, make them less ugly. We need to get rid of this
974-px-wide business. It's ridiculous, and it keeps us busy fighting CSS
just to keep a silly grey margin on the right side of the display, and
it keeps us from using all available space.  We need to simplify the CSS
greatly, in fact. Let's bite that bullet sooner than later.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoremove the Sort by Relavance option from the bookbag sort options
Mike Rylander [Tue, 18 Oct 2011 23:54:42 +0000 (19:54 -0400)]
remove the Sort by Relavance option from the bookbag sort options

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoadd a couple semicolons
Galen Charlton [Tue, 18 Oct 2011 17:25:34 +0000 (13:25 -0400)]
add a couple semicolons

Not strictly required, but may as well save a picosecond
of grief for the next person who adds to this code.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoCreate events for hold_request.cancel.patron
Bill Erickson [Thu, 15 Sep 2011 17:38:17 +0000 (13:38 -0400)]
Create events for hold_request.cancel.patron

When a patron cancels his/her own hold, create events for the
(already-existing) hold_request.cancel.patron A/T hook.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoRe-fetch hold for cancel notify to correct timestamp
Bill Erickson [Tue, 18 Oct 2011 16:07:46 +0000 (12:07 -0400)]
Re-fetch hold for cancel notify to correct timestamp

Re-fetch the cancelled hold from the DB before passing it off to
action/trigger for notification processing.  Otherwise, A/T attempts to
perform date math on "now" instead of a valid timestamp and subsequently
croaks.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoCache open-ils.fielder results by locale
Dan Scott [Sun, 16 Oct 2011 22:39:00 +0000 (18:39 -0400)]
Cache open-ils.fielder results by locale

The problem was particularly visible in search facets, but existed
before: the cache key used for fielder results did not take locale into
account, so on a multi-locale system the first locale won and populated
the cache for all other locales.

Use a session locale if provided, otherwise default to the locale set in
opensrf.xml

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoAdd a view-in-catalog link to bookbags
Mike Rylander [Tue, 18 Oct 2011 15:42:56 +0000 (11:42 -0400)]
Add a view-in-catalog link to bookbags

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
8 years agoInitial patch from Sarah Chodrow on LP bug 849447.
Sarah E. Chodrow [Wed, 14 Sep 2011 13:15:14 +0000 (09:15 -0400)]
Initial patch from Sarah Chodrow on LP bug 849447.

Also check for standing penalties and expired cards when checking
if it is ok for the patron to checkout, charge_ok.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Sarah E. Chodrow (sarah.chodrow@bibliotheca-itg.com)
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoStamping upgrade script for LP#847973
Thomas Berezansky [Tue, 18 Oct 2011 14:07:08 +0000 (10:07 -0400)]
Stamping upgrade script for LP#847973

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoLP#847973 ensure JSON values for org settings
Jason Etheridge [Mon, 12 Sep 2011 15:29:51 +0000 (11:29 -0400)]
LP#847973 ensure JSON values for org settings

I don't believe you can violate this constraint via the Library Settings UI,
but this will catch speedy-admins mucking directly in the database.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
8 years agoTPac: Describe bookbags mo' semantically
Dan Scott [Mon, 17 Oct 2011 19:00:33 +0000 (15:00 -0400)]
TPac: Describe bookbags mo' semantically

Rather than "big-strong", use a heading (H2, as the previously used H2
headings got bumped to H1) and wrap the description in a styled DIV
rather than just dumping it after a <br /> and wrapping it in <em>.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTPac: bookbags - stop trying to show everything at once
Lebbeous Fogle-Weekley [Fri, 14 Oct 2011 21:53:49 +0000 (17:53 -0400)]
TPac: bookbags - stop trying to show everything at once

Go back to displaying one bookbag at a time (not counting the temporary
list, when that is populated)

This hopefully constitutes a usability improvement.

While it doesn't provide paging of bookbags themselves or of the items
therein, it should make that easier to do.  Showing all bookbags and all
their items made it nonobvious how paging would even be expected to
behave.

This also provides the same sorting for the items in the temporary list
as in real bookbags.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoTypo: It's MARC, not Marc. Sheesh.
Dan Scott [Mon, 17 Oct 2011 17:54:10 +0000 (13:54 -0400)]
Typo: It's MARC, not Marc. Sheesh.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
8 years agoSave MARC Default Template per-server
Thomas Berezansky [Wed, 14 Sep 2011 17:58:27 +0000 (13:58 -0400)]
Save MARC Default Template per-server

In case you use multiple servers with different template lists

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>