Evergreen.git
7 months agolp1739277 OrgSelect Class Callback Holdings Implementation
Kyle Huckins [Tue, 30 Jul 2019 19:00:14 +0000 (19:00 +0000)]
lp1739277 OrgSelect Class Callback Holdings Implementation

- Implement OrgSelectClassCallback in Angular Catalog Holdings UI

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.html
modified:   Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts

Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agoLP1739277 Angular org selector style callback
Bill Erickson [Tue, 30 Jul 2019 16:12:12 +0000 (12:12 -0400)]
LP1739277 Angular org selector style callback

Allow the caller of an <eg-org-select> to pass a function which is
called against each org unit in the list to determine what CSS class(es)
should be applied to the org unit label in the list.

Includes sandbox example.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agolp1855780 stamp upgrade script
Jane Sandberg [Wed, 17 Nov 2021 19:53:52 +0000 (11:53 -0800)]
lp1855780 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agolp1855780 preload values for comboboxes in angular event definition editor
Jane Sandberg [Wed, 17 Nov 2021 19:39:04 +0000 (11:39 -0800)]
lp1855780 preload values for comboboxes in angular event definition editor

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agolp1855780 remove unnecessary whitespace
Jane Sandberg [Wed, 17 Nov 2021 19:22:16 +0000 (11:22 -0800)]
lp1855780 remove unnecessary whitespace

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: add release notes entry
Galen Charlton [Tue, 9 Nov 2021 15:53:58 +0000 (10:53 -0500)]
LP#1855780: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: add grid config settings
Galen Charlton [Tue, 9 Nov 2021 15:51:27 +0000 (10:51 -0500)]
LP#1855780: add grid config settings

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: improve reporting of event test errors
Galen Charlton [Tue, 9 Nov 2021 15:41:58 +0000 (10:41 -0500)]
LP#1855780: improve reporting of event test errors

- make error title/caption strings available to i18n
- catch and report on exceptions, not just ILS events

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: adjustments to cloning
Galen Charlton [Tue, 9 Nov 2021 15:24:04 +0000 (10:24 -0500)]
LP#1855780: adjustments to cloning

- set the owning OU to null in the clone
- reduce console noise when cloning environment entries

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: tweaks to grids
Galen Charlton [Mon, 8 Nov 2021 20:58:04 +0000 (15:58 -0500)]
LP#1855780: tweaks to grids

- make main A/T event definition grid header sticky
- do not display environment ID and parameter ID
  columns by default in the event definition
  editor

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: add option to include environment in clone of an event
Galen Charlton [Mon, 8 Nov 2021 17:28:19 +0000 (12:28 -0500)]
LP#1855780: add option to include environment in clone of an event

This recovers a patch from Mike Risher that got dropped
when attempting to get a clean rebase from a branch merge.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: avoid race condition when deleting env or params
Galen Charlton [Mon, 8 Nov 2021 17:00:42 +0000 (12:00 -0500)]
LP#1855780: avoid race condition when deleting env or params

When deleting from a grid using pcrud.autoApply, the grid
should be refreshed only at the very end. Otherwise, even if you're
deleting only one row, the grid reload could occur before the
deletion is committed, yielding a grid fetch error when
pcrud complains about verifying access to a row that is
no longer in the database.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: updates to IDL
Galen Charlton [Mon, 8 Nov 2021 16:51:15 +0000 (11:51 -0500)]
LP#1855780: updates to IDL

- mark various action/trigger record fields as required
  for the sake of the Angular record editor
- make atcol retrievable via pcrud

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: fix lint
Galen Charlton [Mon, 8 Nov 2021 16:26:47 +0000 (11:26 -0500)]
LP#1855780: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780: adding the go-back button from Mike Risher's code
Rogan Hamby [Fri, 24 Sep 2021 19:21:47 +0000 (19:21 +0000)]
LP#1855780: adding the go-back button from Mike Risher's code

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP#1855780 Angular Notification/Action Triggers port
Mike Risher [Thu, 19 Dec 2019 17:56:41 +0000 (17:56 +0000)]
LP#1855780 Angular Notification/Action Triggers port

Port Notification Action Triggers from DOJO to Angular.  This consists of 4 grids, each
navigated to by its corresponding tab. The Trigger Event Definitions grid allows
cloning of records.  When editing an event defintion one can also edit parameters,
environments, and run tests.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP1951030: Remove OpenILS/Utils/ISBN from Manifest
Jason Stephenson [Mon, 15 Nov 2021 22:50:25 +0000 (17:50 -0500)]
LP1951030: Remove OpenILS/Utils/ISBN from Manifest

Remove a remnant of the OpenILS::Utils::ISBN module that was removed
in the branch for Launchpad bug 1856906.

To test this fix, run make check in Open-ILS/src/perlmods on a test
system to run the tests.  Before this patch, you get the following
message:

WARNING: the following files are missing in your kit:
lib/OpenILS/Utils/ISBN.pm
Please inform the author.

After applying this patch, the message goes away.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1856906: (follow-up) fix unit test count
Galen Charlton [Fri, 12 Nov 2021 20:38:17 +0000 (15:38 -0500)]
LP1856906: (follow-up) fix unit test count

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoDocs: Adding latency test and disable sounds to workstation admin.
Jennifer Pringle [Thu, 7 Oct 2021 18:46:13 +0000 (11:46 -0700)]
Docs: Adding latency test and disable sounds to workstation admin.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoDocs: Transit List
Lynn Floyd [Fri, 4 Jun 2021 19:41:31 +0000 (15:41 -0400)]
Docs: Transit List

Documentation on Transit List.

Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoDocs: Update receipt_template_editor.adoc
gmontimantis [Mon, 28 Jun 2021 16:22:57 +0000 (12:22 -0400)]
Docs: Update receipt_template_editor.adoc

Fixes https://bugs.launchpad.net/evergreen/+bug/1929592

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
7 months agoLP1766726 Clarify Field Hints on Print Templates
Terran McCanna [Tue, 21 Sep 2021 20:48:50 +0000 (16:48 -0400)]
LP1766726 Clarify Field Hints on Print Templates

Adds 'patron.' to beginning of patron field hints in Checkout and Items Out
templates to make it easier for users to understand.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1528301: minor tweaks to release notes
Galen Charlton [Thu, 11 Nov 2021 15:16:19 +0000 (10:16 -0500)]
LP#1528301: minor tweaks to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1528301: Release Note for Phone in Checkin Response
Jason Boyer [Fri, 6 Sep 2019 18:22:30 +0000 (14:22 -0400)]
LP1528301: Release Note for Phone in Checkin Response

Have to tell people about it if they're going to use it.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1528301: Hold Notify Phone in Checkin Response
Jason Boyer [Fri, 6 Sep 2019 18:10:45 +0000 (14:10 -0400)]
LP1528301: Hold Notify Phone in Checkin Response

Adds a setting to oils_sip.xml.sample to en/dis-able
the extention of including the hold notify phone number
for captured holds in the SIP Checkin Response.
Defaults to false.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1528301 Add SIP Support for BF field on type 10 checkin responses
blake [Thu, 9 Jun 2016 14:04:56 +0000 (09:04 -0500)]
LP1528301 Add SIP Support for BF field on type 10 checkin responses

This little patch will append the BF field in the SIP response during
checkin when the item is for another hold. Some self check software vendors
(ahem Bibliotheca) implement the hold phone number for the next patron this way.
You will need this patch as well as the code change to the SIPServer repo
LP1528301_Add_SIP_Support_for_BF_field_on_type_10_checkin_responses

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1856906: remove unused OpenILS::Utils::ISBN perl module
Jane Sandberg [Thu, 15 Jul 2021 20:58:43 +0000 (13:58 -0700)]
LP1856906: remove unused OpenILS::Utils::ISBN perl module

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1819233 improve AngularJS eg-basic-combo-box filtering
Mike Risher [Wed, 20 May 2020 23:27:20 +0000 (23:27 +0000)]
LP#1819233 improve AngularJS eg-basic-combo-box filtering

Adjust the eg-basic-combo-box so that it doesn’t give console errors
when typing characters such as [. Fix the bug that causes it to
sometimes show no results when there are valid results that match.

To test
-------
[1] Apply the patch, then create a new report template, add a
    display field, then open the Change Transform modal.
[2] Verify that the selection box will accept characters like '['
    as input without browser console noise, that the filtering
    is case-insensitive, and that filtering continues to work
    after clicking on the selector.
[3] Instances of this combo box can also be found in the AngularJS
    volume/copy editor.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist
Steven Callender [Fri, 4 Dec 2020 14:59:25 +0000 (09:59 -0500)]
LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist

This fix will correct an issue where the screen just keeps looping to
the override screen when trying to place a hold that has no titles
available for it.

Patch courtesy of Mike Rylander.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 Triggered Events Log Rewrite
Angela Kilsdonk [Mon, 18 Oct 2021 13:38:28 +0000 (09:38 -0400)]
docs: 3.8 Triggered Events Log Rewrite

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 hold copy ratio reports
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:35:33 +0000 (09:35 -0400)]
docs: 3.8 hold copy ratio reports

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 Acq Admin
Angela Kilsdonk [Mon, 18 Oct 2021 13:32:24 +0000 (09:32 -0400)]
docs: 3.8 Acq Admin

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 Patron Photo URL + Consolidate Patron Notes
Angela Kilsdonk [Mon, 18 Oct 2021 13:25:51 +0000 (09:25 -0400)]
docs: 3.8 Patron Photo URL + Consolidate Patron Notes

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 selected new Library Settings
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:19:53 +0000 (09:19 -0400)]
docs: 3.8 selected new Library Settings

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 Override Actions
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:16:12 +0000 (09:16 -0400)]
docs: 3.8 Override Actions

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: 3.8 Stripe Payment Intents
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:13:36 +0000 (09:13 -0400)]
docs: 3.8 Stripe Payment Intents

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1831803: stamp schema update
Galen Charlton [Fri, 5 Nov 2021 22:30:53 +0000 (18:30 -0400)]
LP#1831803: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1831803: (follow-up) update release notes formatting
Galen Charlton [Fri, 5 Nov 2021 22:27:03 +0000 (18:27 -0400)]
LP#1831803: (follow-up) update release notes formatting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1831803: drop the disused search-related types during upgrade
Galen Charlton [Fri, 5 Nov 2021 22:25:41 +0000 (18:25 -0400)]
LP#1831803: drop the disused search-related types during upgrade

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1831803: Remove unused data types
Jason Boyer [Fri, 24 Sep 2021 13:12:20 +0000 (09:12 -0400)]
LP1831803: Remove unused data types

The search.search_args and search.search_result types appear to have only
been used in combination with search.query_parser_qts, so they can also
be retired.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1831803: release note for removing old staged search stuff from db
Jeff Davis [Fri, 18 Oct 2019 19:44:52 +0000 (12:44 -0700)]
LP#1831803: release note for removing old staged search stuff from db

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1831803: remove asset.refresh_opac_visible_copies_mat_view if it exists too
Jeff Davis [Fri, 18 Oct 2019 19:26:03 +0000 (12:26 -0700)]
LP#1831803: remove asset.refresh_opac_visible_copies_mat_view if it exists too

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1831803: remove obsolete asset.opac_visible_copies and search.query_parser_fts...
Jeff Davis [Wed, 5 Jun 2019 21:30:11 +0000 (14:30 -0700)]
LP#1831803: remove obsolete asset.opac_visible_copies and search.query_parser_fts from database

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1830387: add release notes entry
Galen Charlton [Fri, 5 Nov 2021 22:19:55 +0000 (18:19 -0400)]
LP#1830387: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1830387: (follow-up) normalize whitespace
Galen Charlton [Fri, 5 Nov 2021 22:18:59 +0000 (18:18 -0400)]
LP#1830387: (follow-up) normalize whitespace

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1830387 Add access to juvenile flag in print templates
Terran McCanna [Tue, 21 Sep 2021 20:18:51 +0000 (16:18 -0400)]
LP1830387 Add access to juvenile flag in print templates

Adds juvenile t/f flag to print templates for checkout and
items out.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agodocs: add 3.8 to target branches for Antora
Galen Charlton [Fri, 5 Nov 2021 21:21:39 +0000 (17:21 -0400)]
docs: add 3.8 to target branches for Antora

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoTranslation updates - po files - 3.8.0
Galen Charlton [Fri, 5 Nov 2021 20:23:51 +0000 (16:23 -0400)]
Translation updates - po files - 3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agofinal update to release notes for 3.8.0
Galen Charlton [Fri, 5 Nov 2021 20:21:09 +0000 (16:21 -0400)]
final update to release notes for 3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoupdate upgrade script for 3.7.1-3.8.0
Galen Charlton [Fri, 5 Nov 2021 20:05:30 +0000 (16:05 -0400)]
update upgrade script for 3.7.1-3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1830089: close transaction and update copy status on payment or adjust to zero
Jeff Davis [Thu, 6 Jun 2019 21:30:34 +0000 (14:30 -0700)]
LP#1830089: close transaction and update copy status on payment or adjust to zero

When you make a payment that sets the balance owed to zero, Evergreen
closes the transaction and sets the item status to Lost & Paid (if
appropriate).  Adjust to Zero should do the same thing, but hitherto it
would not update the item status.  This commit refactors some code to
ensure that Evergreen gives the same result whether you make a payment
or adjust to zero.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoupdate Czech translations for Angular staff client
Galen Charlton [Fri, 5 Nov 2021 16:33:34 +0000 (12:33 -0400)]
update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP1948594: Fix pgtap live test
Jason Stephenson [Sun, 24 Oct 2021 18:38:52 +0000 (14:38 -0400)]
LP1948594: Fix pgtap live test

Fix the lp1145213_test_func_asset.merge_record_assets.pg pgtap live
test by removing the COMMIT and adding a ROLLBACK at the end.  This
permits the test to run multiple times without requiring a database
reload.

To verify the bug:

1. Install the pgtap package appropriate for your PostgreSQL database
version.

2. Load a fresh database with eg_db_config using the --load-all-sample
option.

3. Create the pgtap extension in the evergreen database.

4. Run the Open-ILS/src/sql/Pg/live_t/ tests with pg_prove.

5. Repeat step 4, and if this patch has not been applied, then the
lp1145213_test_func_asset.merge_record_assets.pg tests will fail on
the second run.

To test the fix, repeat steps 2 - 5, above, after pulling this commit.
Step 5 should succeed.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1947173: stamp schema update
Galen Charlton [Fri, 5 Nov 2021 16:07:52 +0000 (12:07 -0400)]
LP#1947173: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1947173: Clean up bad cataloging pot hole
Mike Rylander [Wed, 20 Oct 2021 20:22:37 +0000 (16:22 -0400)]
LP#1947173: Clean up bad cataloging pot hole

If a MARC record has effectively empty fields (all space or punctuation)
then it's possible to stumble over a NULL text array when parsing
content for the symspell dictionary.  This commit checks for that
condition and returns early to avoid the problem.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
7 months agoLP#1947173: Speed up the symspell part of ingest
Mike Rylander [Thu, 14 Oct 2021 13:57:24 +0000 (09:57 -0400)]
LP#1947173: Speed up the symspell part of ingest

For certain data, and certain data set sizes, merging the suggestion
arrays used by the symspell algorithm is noticably expensive.  This is
the case for suggestion arrays containing many thousands of entries.
These suggestion sets are not only slow, but generally not useful.  We
avoid the creation of such overly long suggestion sets using several
word filters that take advantage of our knowledge of the incoming data
to optimize for what is useful in a bibliographic context.  The
mechanisms employed by this patch are:

- Omit suggestions whose length is longer than the max prefix key length
  when the prefix key length is less than or equal to the maximum prefix
  key length minus the maximum edit distance.
- Omit words that contain a run of 5 or more digits. This will drop most
  identifiers from the dictionary while still allowing suggestions to
  happen for year values.
- Omit empty keys from the dictionary.  This should have been the case
  already but is now enforced directly.
- Add a small speedup to evergreen.text_array_merge_unique() by making
  it assume that arrays passed to it do not have null values, which we
  intentionally avoid, and against which we protect in other ways in the
  commit.

Besides improving reingest speed, the patches will also make the
search.symspell_dictionary table significantly smaller.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoForward-port the 3.6.5 db upgrade script
Jason Stephenson [Fri, 29 Oct 2021 16:30:11 +0000 (12:30 -0400)]
Forward-port the 3.6.5  db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
8 months agoForward-port 3.7.2 version upgrade script
Jason Stephenson [Fri, 29 Oct 2021 15:17:36 +0000 (11:17 -0400)]
Forward-port 3.7.2 version upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
8 months agoDocs: corrections to Hold Groups Admin doc
Andrea Buntz Neiman [Mon, 25 Oct 2021 19:50:07 +0000 (15:50 -0400)]
Docs: corrections to Hold Groups Admin doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8 months agoDocs: corrections to Library Groups Admin doc
Andrea Buntz Neiman [Mon, 25 Oct 2021 19:41:11 +0000 (15:41 -0400)]
Docs: corrections to Library Groups Admin doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8 months agoDocs: More 3.6.5 and 3.7.2 release notes cleanup
Jason Stephenson [Mon, 25 Oct 2021 17:16:18 +0000 (13:16 -0400)]
Docs: More 3.6.5 and 3.7.2 release notes cleanup

Signed-off-by: Jason Stephenson <jason@sigio.com>
8 months agoDocs: Fix previous release notes addition
Jason Stephenson [Mon, 25 Oct 2021 17:04:29 +0000 (13:04 -0400)]
Docs: Fix previous release notes addition

Signed-off-by: Jason Stephenson <jason@sigio.com>
8 months agoDocs: Add an upgrade note to the 3.7.2 and 3.6.5 release notes
Jason Stephenson [Mon, 25 Oct 2021 16:52:54 +0000 (12:52 -0400)]
Docs: Add an upgrade note to the 3.7.2 and 3.6.5 release notes

Add a note mentioning that upgrading sites should make sure to run
autogen.sh to update the fm_IDL.xml files.

Signed-off-by: Jason Stephenson <jason@sigio.com>
8 months agoDocs: updates to 3.7.2 and 3.6.5 release notes
Andrea Buntz Neiman [Mon, 25 Oct 2021 13:26:46 +0000 (09:26 -0400)]
Docs: updates to 3.7.2 and 3.6.5 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8 months agodocs: edit to 3.7.2 release notes
Andrea Buntz Neiman [Fri, 22 Oct 2021 19:51:17 +0000 (15:51 -0400)]
docs: edit to 3.7.2 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8 months agodocs: release notes 3.6.5
Andrea Buntz Neiman [Fri, 22 Oct 2021 19:45:50 +0000 (15:45 -0400)]
docs: release notes 3.6.5

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
8 months agodocs: release notes 3.7.2
Andrea Buntz Neiman [Fri, 22 Oct 2021 19:43:11 +0000 (15:43 -0400)]
docs: release notes 3.7.2

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8 months agoDocs: 3.8 Release Notes updates
Andrea Buntz Neiman [Fri, 15 Oct 2021 19:25:25 +0000 (15:25 -0400)]
Docs: 3.8 Release Notes updates

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
8 months agoTranslation updates - newpot
Galen Charlton [Tue, 12 Oct 2021 18:13:23 +0000 (14:13 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoi18n: fix contruct in seed data that broken string extraction
Galen Charlton [Tue, 12 Oct 2021 18:12:27 +0000 (14:12 -0400)]
i18n: fix contruct in seed data that broken string extraction

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoLP1903358 Staff catalog holds barcode realtime lookup
Bill Erickson [Tue, 27 Jul 2021 19:09:45 +0000 (15:09 -0400)]
LP1903358 Staff catalog holds barcode realtime lookup

Avoid requiring staff to send an Enter event (keyword / scanner) when
entering a patron barcode into the place holds form.  Instead, look the
barcode up after a sufficient amount of time has passed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoschema update script from 3.7.1 to 3.8-beta
Galen Charlton [Wed, 6 Oct 2021 16:39:38 +0000 (12:39 -0400)]
schema update script from 3.7.1 to 3.8-beta

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoLP#1846354: add another missed function update
Galen Charlton [Wed, 6 Oct 2021 16:11:01 +0000 (12:11 -0400)]
LP#1846354: add another missed function update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoLP#1846354: add missing function updates to schema update
Galen Charlton [Wed, 6 Oct 2021 15:48:59 +0000 (11:48 -0400)]
LP#1846354: add missing function updates to schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoadd typo fix to release notes
Galen Charlton [Wed, 6 Oct 2021 15:11:23 +0000 (11:11 -0400)]
add typo fix to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoDocs: add acknowledgment to 3.8 release notes
Jane Sandberg [Tue, 5 Oct 2021 18:16:57 +0000 (11:16 -0700)]
Docs: add acknowledgment to 3.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 months ago3.8 release notes copy-editing and acknowledgment updates
Galen Charlton [Mon, 4 Oct 2021 21:04:19 +0000 (17:04 -0400)]
3.8 release notes copy-editing and acknowledgment updates

Including typo fixes by Lisa Carlucci.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoLP#1826759: end DB update scripts with "COMMIT", not "END"
Galen Charlton [Mon, 4 Oct 2021 16:28:14 +0000 (12:28 -0400)]
LP#1826759: end DB update scripts with "COMMIT", not "END"

The former is what tools like make_release are looking
for.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agowipe the release note slate clean
Galen Charlton [Mon, 4 Oct 2021 16:06:10 +0000 (12:06 -0400)]
wipe the release note slate clean

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agocheck in first draft of release notes
Galen Charlton [Mon, 4 Oct 2021 16:04:56 +0000 (12:04 -0400)]
check in first draft of release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoLP#1922567: stamp schema update
Galen Charlton [Mon, 4 Oct 2021 14:52:35 +0000 (10:52 -0400)]
LP#1922567: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
8 months agoLp 1922567: Limit authority.full_rec.value indexes
Jason Stephenson [Tue, 6 Apr 2021 11:43:52 +0000 (07:43 -0400)]
Lp 1922567: Limit authority.full_rec.value indexes

Limit the authority_full_rec_value_index and
authority_full_rec_value_tpo_index indexes to the first 1024
characters of a field or subfield in order to avoid database errors
when inserting or updating authorities with long fields.

Include release note and regression test.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
9 months agoLp 1826759: Stamping Upgrade Script
Jason Stephenson [Mon, 27 Sep 2021 17:39:41 +0000 (13:39 -0400)]
Lp 1826759: Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>
9 months agoLp 1826759: Fix Database Upgrade Script
Jason Stephenson [Mon, 27 Sep 2021 17:32:41 +0000 (13:32 -0400)]
Lp 1826759: Fix Database Upgrade Script

Remove 2 extraneous updates, add a blank line between the remaining
updates, and add a placeholder the upgrade_deps_block_check().

Signed-off-by: Jason Stephenson <jason@sigio.com>
9 months agoLp 1826759: Spelling correction: oustanding to outstanding
Shula Link [Thu, 18 Mar 2021 14:27:02 +0000 (10:27 -0400)]
Lp 1826759: Spelling correction: oustanding to outstanding

Correct the spelling of "oustanding" to "outstanding" in the
descriptions of 3 config.org_unit_setting_type entries:

  * ui.circ.items_out.longoverdue
  * ui.circ.items_out.lost
  * ui.circ.items_out.claimsreturned

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
9 months agoLp 1942920: Show Legacy/Not Dated for Legacy Circs
Jason Stephenson [Tue, 7 Sep 2021 18:37:54 +0000 (14:37 -0400)]
Lp 1942920: Show Legacy/Not Dated for Legacy Circs

When legacy circ counts are displayed in the AngularJS client, the
year shows up as -1.  This patch attempts to replace -1 with a
translatable string: "Legacy/Not Dated" as was used in the XUL staff
client.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
9 months agoLP#1928258: update pgTAP regression test
Galen Charlton [Mon, 27 Sep 2021 13:43:18 +0000 (09:43 -0400)]
LP#1928258: update pgTAP regression test

Now that update_bib_editor is split out into a separate
merge profile field, need to account for that in the regression
test for 1447746.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
9 months agoLP#1864516: (follow-up) install current version of function
Galen Charlton [Fri, 24 Sep 2021 19:40:56 +0000 (15:40 -0400)]
LP#1864516: (follow-up) install current version of function

Fixes a regression that caused bib record saves to fail

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
9 months agoLP#1919465: fix issue with DB rev stamping
Galen Charlton [Fri, 24 Sep 2021 19:38:19 +0000 (15:38 -0400)]
LP#1919465: fix issue with DB rev stamping

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
9 months agoLP1919465: stamp upgrade script
Chris Sharp [Fri, 24 Sep 2021 19:24:23 +0000 (15:24 -0400)]
LP1919465: stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Pull list only shows holds with current_copy
Bill Erickson [Wed, 22 Sep 2021 15:04:18 +0000 (11:04 -0400)]
LP1919465 Pull list only shows holds with current_copy

This avoids a scenario where copy-level holds would appear in the pull
list even if they are not pull-able, because they have "a copy" (i.e.
the requested copy), but no current copy (i.e. targeted copy).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Avoid dupe Current Item's in pull list
Bill Erickson [Wed, 22 Sep 2021 14:24:30 +0000 (10:24 -0400)]
LP1919465 Avoid dupe Current Item's in pull list

* Show a value for Current Item when a hold is targeted
* Show a value for a new column on Requested Item for copy-level holds.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Pull List Mark Discard/Weed Action
Bill Erickson [Tue, 14 Sep 2021 15:04:10 +0000 (11:04 -0400)]
LP1919465 Pull List Mark Discard/Weed Action

Includes general purpose discard/weed dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Relabel Item Location -> Shelving Location
Bill Erickson [Tue, 14 Sep 2021 14:45:22 +0000 (10:45 -0400)]
LP1919465 Relabel Item Location -> Shelving Location

Rename various "Item Location ..." references to "Shelving Location ..."
in the Angular holds grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Pull list detail show record summary
Bill Erickson [Tue, 14 Sep 2021 14:43:47 +0000 (10:43 -0400)]
LP1919465 Pull list detail show record summary

Display the bib record summary when displaying the hold detail view from
the holds pull list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Pull list prefix/suffix sorting; columns
Bill Erickson [Tue, 14 Sep 2021 14:27:30 +0000 (10:27 -0400)]
LP1919465 Pull list prefix/suffix sorting; columns

* Include call number prefix and suffix in hold pull list sorting.
* Apply sane default grid columns.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Fix default holds pull list sorting
Bill Erickson [Fri, 13 Aug 2021 16:02:01 +0000 (12:02 -0400)]
LP1919465 Fix default holds pull list sorting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP1919465 Holds pull list Angular / Wide Holds API Port
Bill Erickson [Fri, 12 Mar 2021 22:50:40 +0000 (17:50 -0500)]
LP1919465 Holds pull list Angular / Wide Holds API Port

Ports the holds pull list to Angular and takes advantage of the new Wide
Holds API.  Includes seed data for grid preferences and a new holds pull
list (server) print template.

The UI displays the total holds count and includes a org unit selector.
It pre-fetches all holds, partly to display the full count, but also
based on the assumption that a pull list will typically be used all or
none.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP#1944765: add headers to bullseye install script
Chris Sharp [Fri, 24 Sep 2021 19:14:02 +0000 (15:14 -0400)]
LP#1944765: add headers to bullseye install script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
9 months agoLP#1944765: enable the Apache module mod_headers
Galen Charlton [Thu, 23 Sep 2021 20:11:42 +0000 (16:11 -0400)]
LP#1944765: enable the Apache module mod_headers

This patch enables mod_headers for Debian Stretch and Buster
and Ubuntu Bionic and Focal during installation. Without
mod_headers, the Angular staff client application can have
its index page cached for 24 hours on a stock system, meaning
that browsers will not consistently fetch the updated app
after an upgrade.

This patch does not change the Fedora Makefile as mod_headers
is enabled by default on RHEL-like distributions.

UPGRADE NOTES
-------------
Existing Evergreen systems on Debian and Ubuntu should
do the following to ensure that mod_headers is active:

sudo a2enmod headers
sudo systemctl restart apache2

To test
-------
[1] Perform a fresh installation of Evergreen on Stretch, Buster,
    Bionic, or Focal.
[2] Verify that mod_headers is enabled.
[3] (Optional) Fetch the Angular staff client index page, e.g.,
    /eg2/staff, and verify that the response headers call for
    not caching it.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>