- The html table was broken, fixed the markup.
- Added some styling to the table.
- Added a row with total records info.
- Fixed the progress bar popup; it now displays
percentage completion and has a title so it is
wide enough to do so
- Added color to failed row (red), and to completion text (green).
To test:
[1] In the staff interface (both XUL and web), perform
a MARC Batch Edit on a bucket that contains at least
a few bib records.
[2] Verify that the progress dialog now displays the
percentage completion of the batch edit; verify
that there is now a row displaying the total number
of records.
[1] Using MARC Batch Import/Export, load a file
of MARC records into a queue (arranging the matching
criteria so that at least a few of the records
aren't automatically imported into the catalog).
[2] Inspect the queue, and click on the "Export Non-Imported
Records link", then save the resulting file.
[3] Verify that the file contains, in MARC format, the set
of records that were not imported into the catalog.
Dan Wells [Thu, 25 Feb 2016 16:44:23 +0000 (11:44 -0500)]
LP#1548147 Quick Export Feature for Vandelay Queues
When we import records into Vandelay, sometimes some of the records
are not what we expected, so they get rejected. These records often
need to be loaded using a different set of options, so this link makes
it convenient to get a new file of just the rejects.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ensure all TT code lives within the [% ... %] blocks. This fixes an
issue where TT code "ctx.metalinks.push('');" was appearing in the
catalog as bare text.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Back in bug # 1414033 , we added rel="nofollow" attributes to many of the links
that led to search results or call number browsing. This was the right idea,
but a bit overzealous as it turns out. We actually want search engines to
follow those links; we just don't want search engines to index them.
Therefore, we can tweak the <meta> tag in the results and browse page headers
to say "follow,noindex", and remove many of the inline rel="nofollow"
attributes from the other pages.
In addition, add a rel="canonical" link to the catalogue home page.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
Open-ILS/src/templates/opac/parts/record/subjects.tt2
Jake Litrell [Tue, 1 Mar 2016 22:22:28 +0000 (17:22 -0500)]
LP#1312699: Minor modifications to patron checkout history deletions
Minor modifications to make patron checkout history deletions work with
the new table. open-ils.actor.history.circ.clear
extended to take an optional list of circ_ids, to limit what's deleted
from the history.
Dan Pearl [Tue, 20 Oct 2015 21:05:07 +0000 (17:05 -0400)]
LP#1312699 - Add feature to allow user to edit their checkout history.
In the checkout history page, a new column and action selector is provided to allow
the paton to indicate items they would just as soon not want to see again in the
history list for whatever reason. NOTE: This is not a PURGE function; it simply
suppresses display of items in the history list (and exported history files).
Internally, the circulations are kept by Evergreen for several reasons which are
not affected by this functionality.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jake Litrell <jake@masslnc.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Adding basic javascript to remove our search filter from the
textbox on an advanced search form. Because of the interplay among
various checkboxes/modifiers/filters, there may be duplicate filters
applied from another function's form submit; this removes all at once.
Signed-off-by: Jake Litrell <jake@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
In 002.schema.config.sql there was a small typo for "z3950attr_name_is_valid"
where that should be "z3950_attr_name_is_valid" with the underscore between.
Rather than use a CHECK constraint, this patch
uses a CONSTRAINT TRIGGER, er, constraint to verify
the z3950_attr_type field. This allows the trigger
to be deferred as any other deferrable constraint
and also allows parallel pg_restore jobs to complete
properly.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Ben Shum <ben@evergreener.net>
Jason Boyer [Wed, 2 Sep 2015 20:20:13 +0000 (16:20 -0400)]
LP#1491571: Ignore Case when Checking PW Reset email
Emails are not passwords and are not case sensitive;
while it is a good idea to require patrons to prove
they know the address associated with their account
it is not cool to deny them because they don't know
the capitalization of the value in the database.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Ben Shum <ben@evergreener.net>
Dan Pearl [Fri, 2 Oct 2015 18:54:39 +0000 (14:54 -0400)]
LP#1197636 - Email record detail does not check for email
Even though no email was configured, the message shown when requesting
bib information to be emailed indicated success. This misleading
behavior has been addressed by alerting the patron of the situation
and providing a link to the page where the email address is defined,
after which the action is automatically retried.
The success message has also been altered slightly to provide
confirmation of the generated email.
To test:
[1] Create a patron account that does not have an email address.
[2] In the OPAC, log in as that patron and attempt to email a
bib record. A message should display indicating that the
email can be sent; that message should contain a link to the
user's account page where they can set their email address.
[3] After setting the email address, you should then be
redirected back and the email sent.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Kathy Lussier [Thu, 25 Feb 2016 17:26:02 +0000 (12:26 -0500)]
LP#1422802 Fix javascript validation for visible parts
The previous javascript validation was not working for records with just one
part. This one works better. Many thanks to Dan Wells for identifying the fix.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Martha Driscoll [Mon, 22 Feb 2016 20:34:15 +0000 (15:34 -0500)]
LP1229757 - Distinct images for holds, reserves, transits
This commit changes the references to turtle.gif to three new images
holdshelf.png, reserve.png, and transit.png. When checking in a copy
that needs to go on the hold shelf, on the reservation shelf, or
in transit, a distinct image will show in the pop-up window.
This commit adds support for 'parts' import in Vandelay. It is
modeled after the existing support for stat cat import. As such, it:
- Uses '|' characters to separate labels to allow for multiple
part assignment.
- Adds to (rather than replaces) any existing parts assigned to overlay
copies.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Dan Wells [Tue, 26 Jan 2016 19:22:21 +0000 (14:22 -0500)]
LP#1468422 Use auth_internal.validate to shore up AuthProxy
Even if a user has valid credentials in the external system, we should
block them from logging in if their Evergreen account is out of sorts.
Use the API designed for this.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Previously, AuthProxy.pm would simply lookup and use the hashed password
when the external authentication had passed. This simple method no
longer works, since even cstore doesn't have access to the hashed
password.
Instead, take advantage of the new 'auth_internal' service to create the
user session after the user has been externally authenticated.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Basically, if we aren't given a username, and we can't find a username
by barcode, give up immediately. This helps simplify the rest of the
code a bit.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Avoid what may be an unacceptible login delay caused by work factor 14
by dropping down to 10. This reduces the CRYPT() time from ~1 second to
~.1 seconds.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Prevent leaking information from authentication by only reporting that a
card is inactive if the caller provided the correct credentials. This
is consistent with how the code handles inactive patrons.
To avoid a lot of code duplication and to reduce the potential for
leaking memory (C code, amiright?), this commit includes a number of
changes to avoid exiting the API function early and saving the memory
cleanup routines until the end of the API call.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
User update in Actor.pm was the only remaining code that leveraged
the open-ils.storage remote_update API. With that code moving to
open-ils.cstore, save some RAM by no longer auto-loading/publishing
remote_update methods.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Migrate the user update code from open-ils.storage to open-ils.cstore.
This has several benefits:
1. We can re-use the patron password update code
2. Several actions (bad contacts, invalid address) which previously
resulted in data modifications outside the main transaction now
take place with the main patron update transaction.
3. Bigger, better, faster, stronger.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Service is responsible for adding user data to the authentication cache.
Cache times are determined from opensrf.xml/AOUS settings. No
authentication checks are performed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Fri, 17 Jul 2015 20:00:17 +0000 (16:00 -0400)]
LP#1468422 Password storage/migration SQL getting started
* Backwards compatible salted password storage using pgcrypt
* Adds actor.passwd and actor.passwd_type tables
* Includes pgtap tests
* Includes installation of pgcrypto
Current flow:
1. Application requests a salt to use as the CHAP-style seed
2. If new-style password exists, salt is returned.
3. Else, old password is migrated and the new salt is returned.
4. App finalizes login by checking verify_passwd.
== continued...
Store the iter_count and start using the crypt_algo column.
Make it possible to change the salt, and potentially strengthen
the salt, when changing passwords.
Make is possible to start salt-less passwords, for pw's that are managed
outside of the DB.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Thu, 25 Feb 2016 18:33:20 +0000 (13:33 -0500)]
LP#1333254 Improve entry debit maintenance for inv. open/close.
Improve handling of debit->entry links for invoices that cross the
open/close boundary, modifying the number of items invoiced on an entry,
and rolling back invoice entry debits.
Prior to this, some debits would be unnecessarily linked to entries and
fail to clean up properly when rolled back.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Set encumbrance=false on invoiced fund debits when the invoice is closed
(complete=true) instead of when the invoice is created.
To test:
1. Activate a purchase order.
2. Create an invoice for the PO.
3. Confirm PO shows same amount encumbered as befor invoicing and $0
paid.
4. Close the invoice.
5. Confirm amount encumbered on the PO is reduced by the amount invoiced
and the amount paid on the PO is increased by the amount invoiced.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Checkout history is now derived from the new action.usr_circ_history
table. When a patron disables circ history, all history is deleted from
the new table. Also, when disabling circ or holds history, the patron
is now warned if data will be deleted or, in the case of holds, become
inaccessible.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Adds a new table action.usr_circ_history for tracking opt-in checkout
history. History is maintained via trigger on action.circulation.
Includes updates to html/email/csv checkout history templates to
gracefully handle NULL checkin_time values, since history starts as soon
as an item is checked out.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Sat, 16 Jan 2016 20:15:01 +0000 (15:15 -0500)]
LP#1452950 Remove unsaved data warning after click-thru
Once the user clicks through the unsaved data warning, clear the warning
for future navigation. If more fields are changed, the warning will be
reinstated.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
projects / Evergreen.git / log