Cesar Velez [Fri, 8 Dec 2017 18:50:38 +0000 (13:50 -0500)]
LP#1732275: Patron Itemsout Notices - Add YAOUS for pre-due notices
Adding library permission 'webstaff.circ.itemsout_notice_count_excludes_courtesies'
so that pre-due/courtesy events aren't included in the notices count.
Cesar Velez [Mon, 13 Nov 2017 23:25:05 +0000 (18:25 -0500)]
LP#1732275: add open-ils.actor.user.itemsout.notices api
Add a method to Actor.pm to count completed action
trigger events for a given circ and return the latest
notice date. Uses the json_query for performance.
Add release notes for the new --uris option on marc_export.
To test the new option, run marc_export to export records with
holdings for a given library using the --library and --items options.
If that library also has electronic resources, do another export with
the same options but add the --uris option and direct this output to a
different file. Compare the file sizes. The second file should be
larger than the first.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kathy Lussier [Wed, 21 Feb 2018 20:19:34 +0000 (15:19 -0500)]
LP#1661688: Add a link and other tweaks to alternate hold pickup feature
Adding a couple of tweaks to the alternate hold pickup feature:
* Created a link for the hold patron so that staff can easily retrieve the record and potentially verify that the user allows the alternate patron to pick
up their holds.
* Tweaked the language in the event dialog.
* Removed the new OU setting from actor.org_unit_setting so that a default value is not set.
Dan Pearl [Tue, 24 Jan 2017 18:59:01 +0000 (13:59 -0500)]
LP##1661688 - Want easy way to clear a hold when picked up by other patron.
This common action was handled previously as
1) item is scanned - The system detects that this items is for a different
patron, and an error message is displayed.
2) Force Override was selected - If the librarian had the appropriate
privileges, the Force Override could allow the checkout to occur.
3) librarian cancels original hold - This independent operation would
be needed to cancel the original hold, otherwise the hold would be
targeted again.
This feature provides the option to cancel the hold in step #2. An error
message will be displayed as before, but within that message will be a checkbox to allow cancelling of the original hold which, if checked, will mean that step #3 will be automatically done.
The checked/non-checked state of the checkbox is initialized with an
organizational unit setting. The default is false (to preserve default
prior behavior).
Note: This change only affects the "web client".
TO TEST THIS
A. Before the Patch
Hold an item for patron "A". Attempt to check it out for patron "B".
Observe the choices to Force Override (to allow the checkout) or to cancel.
Do a Force Override and observe that the original hold is still active.
B. After the Patch
Repeat the above scenario, and observe the (blank) checkbox. Perform the
Force Override and observe that the original hold is still active.
Repeat the scenario, except this time check the checkbox. Observe after the checheckout is done that original hold is gone.
Adjust the organizational setting (see the Release Notes) to change the default
appearance of the checkbox.
For completeness, you can verify that if you cancel out the message pop-up that the checkout is cancelled and and that the hold status is unchanged, regardless of the state of the checkbox.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kathy Lussier [Mon, 26 Feb 2018 20:04:30 +0000 (15:04 -0500)]
LP#1744385: Additions and edits to release note entry
Minor edits to the release notes entry. Also, I highlighted the increased
use of Display Fields in the client since I thought it would be of
interest to some users. I also incorporated information regarding
default weights, which were added after Mike wrote up his release
note for this feature.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
This commit removes a layer of opensrf-perl indirection and uses cstore
instead of storage for retrieval. This trims seconds off the render time
of results and a bit off record detail.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Here we replace the series title link generation based directly on the MARCXML
with the Display Field equivalent. Note, the previous method created broken
links in many cases, because it included more in the search terms than were
being indexed by the stock series title definition.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Starting # ../../../../multi-source-attrs.sql
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Wed, 14 Feb 2018 17:52:21 +0000 (12:52 -0500)]
LP#1744385: Optimize real-field additions to virtual field searches
Now we only add on UNION query for each class providing real fields to a
virtual field, rather than a UNION per real field. This should reduce
core-query run time.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Instead of searching by combined field within the rank-addition real fields,
we'll just search on the fields itself. This preserves the ranking additions
provided by the real-virtual mapping.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
* Improve author and publisher display fields
* Reimplement Simple Record Extracts using Display Fields
* Address potential failure in combined search collection
* Provide useful helper function for inspecting transformed records
* Implement MODS transforms specified by LoC documentation but not
actually included in the stylesheet
* Expand highlighting use to publisher, edition, and physical description
* Reifying schema from updates
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Mike Rylander [Mon, 11 Sep 2017 19:24:55 +0000 (15:24 -0400)]
LP#1744385: Search and Result Display improvements
== Virtual Index Definitions
The practical purpose of Virtual Index Definitions is to supply an Evergreen administrator with
the ability to control the weighting and field inclusion of values in the general keyword index,
commonly referred to as "the blob," without requiring tricky configuration that has subtle semantics, an
over-abundance of index definitions which can slow search generally, or the need to reingest all
records on a regular basis as experiments are performed and the configuration refined. Significant
results of recasting keyword indexes as a set of one or more Virtual Index Definitions will be simpler
search configuration management, faster search speed overall, and more practical reconfiguration and
adjustment as needed.
Previous to this commit, in order to provide field-specific weighting to keyword matches against titles or authors, an
administrator must duplicate many other index definitions and supply overriding weights to those
duplicates. This not only complicates configuration, but slows down record ingest as well as search. It
is also fairly ineffective at achieving the goal of weighted keyword fields. Virtual Index Definitions will
substantially alleviate the need for these workarounds and their consequences.
* A Virtual Index Definition is not required supply any configuration for extracting bibliographic
data from records, but instead can become a sink for data collected by other index definitions
which is then colocated together to supply a search target made up of the separately extracted
data. Virtual Index Definitions are effectively treated as aggregate definitions, matching across
all values extracted from constituent non-virtual index definitions. They can further make use
of the Combined class functionality to colocate all values in a class together for matching even
across virtual fields.
* Configuration allows for weighting of constituent index definitions that participate in a
Virtual Index Definition. This weighting is separate from the weighting supplied when the index
definition itself is a search target.
* The Evergreen QueryParser driver returns the list of fields actually searched using every
user-supplied term set, including constituent expansion when a Virtual Index Definition is
searched. In particular, this will facilitate Search Term Highlighting described below.
* Stock configuration changes make use of pre-existing, non-virtual index definitions mapped
to new a Virtual Index Definition that implements the functionality provided by the
keyword|keyword index definition. The keyword|keyword definition is left in place for the time
being, until more data can be gathered about the real-world effect of removing it entirely and
replacing it with Virtual Index Definition mappings.
* New system administration functions will be created to facilitate modification of Virtual Index
Definition mapping, avoiding the need for a full reingest when existing index definitions are
added or removed from a virtual field.
== Increased use of Metabib Display Fields
In extention of changes proposed in other available branches, we here use Metabib Display Fields
to render catalog search results, intermediate metarecord results, and record detail pages.
This will requires the addition of several new Metabib Display Field definitions, as well as Perl
services to gather and render the data.
== Search Term Highlighting
This commit enables Search Term Highlighting in the OPAC on the main search results page, the record
detail page, and intermediate pages such as metarecord grouped results page. Highlighting
search terms will help the user determine why a particular record (or set of records) was retrieved.
Highlighting of matched terms uses the same stemming used to accomplish the search, as configured
per field and class.
This feature will help the user more quickly determine the relevance of a particular record by calling their
attention to search terms in context. Lastly, it will help familiarize the user with how records are
searched, including which fields are searched as well as exposing concepts like stemming.
== Interfaces
A new AngularJS "MARC Search/Facet Fields" interface has been created to replace the Dojo version, and
both have been extended to support Virtual Index Definition data supplier mapping and weighting.
== Settings & Permissions
The new Virtual Index Definition data supplier mapping table, config.metabib_field_virtual_map, requires
the same permissions as the MARC Search/Facet Fields interface: CREATE_METABIB_FIELD, UPDATE_METABIB_FIELD,
DELETE_METABIB_FIELD, or ADMIN_METABIB_FIELD for all actions
There is a new template-level global configuration variable in config.tt2 called search.no_highlight
which disables highlighting for users of that config.tt2 instance.
== Public Catalog
The public and staff catalog will make use of new APIs to identify and display highlight-augmented
values for those Display Fields used to render the search result pages, intermediate metarecord
constituent pages, and record detail pages. Highlighting of terms will be performed using the
application of Template::Toolkit-driven CSS. A generic CSS class identifying a highlighted term,
along with CSS classes identifying the search class and each search field will be available for
use for customization of the highlighting. A stock CSS
template is provided as a baseline upon which sites may expand.
When highlighting is generally enabled, it may be turned on or off on a per-page basis through the use of
a UI component which will request the page again without highlighting.
== Backend
There now exist several new database tables and functions primarily in support of search highlighting.
Additionally, the QueryParser driver for Evergreen has been augmented to be able to return a data structure
describing how the search was performed, in a way that allows a separate support API to gather a highlighted
version of the Display Field data for a given record.
== Re-ingest or Indexing Dependencies
With the addition and modification of many Index Definitions, a full reingest is recommended. However, search
will continue to work as it did before the changes in this commit for those records that have not yet been
reingested during that process. Therefore a slow, rolling reingest is recommended.
== Performance Implications or Concerns
Because the Metabib Display Fields infrastructure will eventually replace functionality that is significantly more
CPU-intensive in the various forms of XML parsing, XSLT transformation, XPath calculation, and
Metabib Virtual Record construction, it is expected that the overall CPU load will be reduced by this
development, and ideally the overall time required to perform and render a search will likewise drop. It
is unlikely that the speed increase will be visible to users on a per-search basis, but that search in
aggregate will become a smaller consumer of resources.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Replace reporter.simple_record data with metabib display fields.
Use flat_display_entries instead of wide_display_entry partially as an
example, but also because it requires slightly less data munging on the
DB side.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Support an option in the webstaff-side display field munging code to
collapse array/multi values down to a single comma-separated string.
This is useful for buidling displays (grids especially) where you have a
single spot to put a field's value (e.g. a list of ISBN's) and don't want
to munge the data by hand in each UI.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Galen Charlton [Wed, 28 Feb 2018 16:27:52 +0000 (11:27 -0500)]
LP#1676608: activate more copy alert types by default
Since users of 3.1 should be using the web staff client unless
they absolutely cannot switch from the XUL client yet, the copy
alert types for exceptional checkin and checkout statuses are now
active by default.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
In a few places we use the word "Paid", but there are quite a few
things in that bucket (forgiveness, adjustments, etc.) which don't fit
well under the term "Paid".
Though we have some deep structural causes for this, we can take a baby
step in the right direction by sprinkling the term "Credited" in a few
key places.
Also, correct an mislabeled "Balance" field.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Over time, Evergreen has developed a rich set of features to support
various billing scenarios. Unfortunately, our interface has not kept up
in some ways, and this leads to some confusion at times, particularly
for front line staff.
One way to bring clarity is to apply better grouping, labeling, and
ordering of the various transactional events. By doing so, we can
generate a billing "statement" with similarities to the statements we
regularly encounter when dealing with other financial institutions.
This branch does so for the staff client view, but it also seems viable
to carry over the same idea to an eventual patron (or print) view as
well.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Tue, 27 Feb 2018 22:23:22 +0000 (17:23 -0500)]
LP#1676608: don't sound the klaxon for unusual copy statuses during checkin
During a successful checkin, play the success sound if an
unexpected copy status is noted in the success message -- it
may have been set via a copy alert.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 23 Feb 2018 21:54:51 +0000 (16:54 -0500)]
LP#1676608: inject copy alert dialog in two more places
The copy alert dialog (if an item has relevant copy alerts)
is now injected into the dialog box series when handling
checkouts of items that are in transit or where the patron
record has overridable conditions that would block the checkout.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Thu, 22 Feb 2018 22:02:11 +0000 (17:02 -0500)]
LP#1676608: provide DB update script to convert legacy copy alert messages
Legacy copy alert messages are moved to new normal checkout and
normal checkin copy alerts. This patch also converts the foreign
key relationship from asset.copy_alert to asset.copy to a "fake"
one using a constraint trigger.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Thu, 22 Feb 2018 21:34:15 +0000 (16:34 -0500)]
LP#1676608: tweak defaults for alerts in vol/copy editor
Changed the defaults key for new-style copy alerts to be the same
as what was used for legacy copy alert messages; this means that
users who set editor defaults prior to upgrading are more likely
to have the Copy Alerts button be active out of the box.
Also moved the location of Add/Edit Copy Alerts in the defaults
tab.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
A handfull of cases have arisen, including but not limited to
the copy alerts feature, where focus-me is set to simply "true"
rather than being bound to to a scope variable. This patch formalizes
this and gets rid of the following console warning:
angular.min.js:119 TypeError: model.assign is not a function
at ui.js:23
at angular.min.js:160
at f (angular.min.js:45)
at angular.min.js:48
(anonymous) @ angular.min.js:119
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Wed, 7 Feb 2018 21:41:55 +0000 (16:41 -0500)]
LP#1676608: add some sorting to copy alert dialogs
Copy alert types in drop-downs are now sorted by name
and copy alerts themselves are now consistently sorted
by ID (which will have the affected of putting the most
recent alert at the bottom in the copy alert manager dialog).
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Wed, 7 Feb 2018 21:30:04 +0000 (16:30 -0500)]
LP#1676608: conditionally enable manage copy alerts button on item status details
The 'Manage' button for copy alerts on the Item Status Detail view
is now enabled only if there is at least one active copy alert. This
patch also tweaks how the copy alert dialogs sequence record update
and modal-closing so that the caller can be sure that the transaction
has committed.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
pcrud.apply() is supposed to skip any entries in the list
of CUD actions that don't explicitly mark themselves as
being a creation, update, or deletion, but didn't manage
to fully skip them. As a consequence, the browser console
would note complaints that open-ils.pcrud.apply.$IDLCLASS
methods do not exist.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The Copy Alerts feature allows library staff to add customized alert
messages to copies. The copy alerts will appear when a specific event
takes place, such as when the copy is checked in, checked out, or
renewed. Alerts can be temporary or persistent: temporary alerts will be
disabled after the initial alert and acknowledgement from staff, while
persistent alerts will display each time the alert event takes place.
Copy Alerts can be configured to display at the circulating or owning
library only or, alternatively, when the library at which the alert
event takes place is not the circulating or owning library. Copy Alerts
can also be configured to provide options for the next copy status that
should be applied to an item. Library administrators will have the
ability to create and customize Copy Alert Types and to suppress copy
alerts at specific org units.
Copy alerts can be added via the volume/creator and the check in,
check out, and renew pages. Copy alerts can also be managed at the
item status page.
Copy alert types can be managed via the Copy Alert Types page in
Local Administration, and suppression of them can be adminstered
via the Copy Alert Suppression page under Local Administration.
Co-authored-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 8 Nov 2017 21:26:10 +0000 (16:26 -0500)]
LP#1733695: Pull record attribute values from multiple sources
Previously, a multi-valued record attribute could only be extracted using
one strategy (XPath, tag+subfield, fixed field, etc). For multi-valued
attributes, though, there's no reason to restrict this as long as the values
from various sources would, after normalization, have the same shape. So
now we allow that, and we update the item_lang definition in order to allow
searching for records with multiple languages in various boolean ways.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Boyer [Thu, 7 Dec 2017 19:45:21 +0000 (14:45 -0500)]
LP1737016: Ease Constraints on afs.code
acq.funding_source.code currently has a UNIQUE
constraint applied, which can be confusing to
users. This branch only requires that a code be
unique to the funding source's owner, simplifying
the management of funding sources.
Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Display a message in the web staff bib record display indicating when a
bib record has been merged to another record. The message includes the
merge date and target record and is rendered as a link to the target
record.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Adds "merge_date" and "merged_to" fields for bib records. Merge date
is applied to all records involved in a record merge at merge time.
merged_to is applied to all subordinate (merged) records and points to
the target record.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jason Stephenson [Sun, 29 Oct 2017 19:14:41 +0000 (15:14 -0400)]
Lp 1694058: Fix Issue With Place Holds Reported in Testing
When staff did have to override in order to place the hold, and the
"Place another hold for this title" link was subsequnetly used, the
inputs for the patron barcodes and some other fields on the place
holds page were duplicated. To avoid this, we now use uniq from the
List::MoreUtils library when retrieving the hold targets list from the
CGI parameters.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP 1694058: Final OPAC Changes for Multiple Hold Placement
Add JavaScript code to disable the number of copies selection when a
part is chosen for a record that has both parts and non parts holds
available. If a part is chosen, the number of copies select should be
disabled and reset to 1. It should be enabled again if the All Parts
option is chosen. It does not appear if the hold requires a part.
Test Plan for the OPAC changes:
1. Set circ.holds.max_duplicate_holds to 5 for BR1.
2. Login to the OPAC as any patron from BR1.
3. Perform any search.
4. Select a title and click Place Hold.
5. See that the selection box for placing multiple holds does not appear on the place holds screen.
6. Place the hold to see that hold placement still works as expected.
8. Go to the patron’s list of holds in My Opac to see that the hold appears.
9. Cancel the hold so it doesn’t interfere with later testing.
10. Logout.
11. Login to the OPAC as any patron from BR2 or any branch other than BR1.
12. Perform any search.
13. Select a title and click Place Hold.
14. See that the selection box for placing multiple holds does not appear on the place holds screen.
15. Place the hold to see that hold placement still works as expected.
16. Go to the patron’s list of holds in My Opac to see that the hold appears.
17. Cancel the hold so it doesn’t interfere with later testing.
18. Logout.
19. Login to the web staff client as a circulator for BR1 at BR1.
20. Select a patron barcode for any BR1 patron.
21. Perform any search.
22. Choose a title without parts and click place holds.
23. See that the selection box for placing multiple holds appears with 1 as the default.
24. Click the selection box to see that the values go from 1 to 5.
25. Place any number of holds for the patron whose barcode was chosen in step 15.
26. Open the patron in the staff client and check the patron’s holds list to see that they have the correct number of holds for this title listed.
27. Repeat steps 21 – 26 with metarecord holds on one of the metarecord titles.
28. Perform a search and select a title.
29. Choose an item to place a copy hold for the same patron.
30. Notice that the multiple hold number selection box does not appear.
31. Place the hold as normal (if you like) to test that copy hold placement still works.
32. Search for a title with parts.
33. Select a part in the parts drop down or radio button.
34. Notice that the number of copies select box is reset to 1 and disabled when a part is selected.
35. Repeat the above steps for a BR2 circulation account logged in at BR2 (or any other branch staff).
36. Notice that the selection box never appears when placing holds where the org. unit setting does not apply.
37. Clear the org. unit setting for BR1 and repeat the above steps, if desired.
The web staff client tests should work in the XUL staff client as well.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Stephenson [Sat, 30 Sep 2017 19:30:22 +0000 (15:30 -0400)]
LP 1694058: Add confirmation dialog for multiple title holds.
Add a dialog to confirm that the user really wants to place the
requested number of title or metarecord holds to the
validateHoldForm() function.
Along the way, we add a format() function to the JS String prototype
in the i18n_strings.tt2 so that we can have translated strings with
placeholders in JavaScript.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP 1694058: Add backend code to allow multiple hold placement.
We add a constant for the circ.holds.max_duplicate_holds setting.
We modify Holds.pm to check if we're placing a title or metarecord
hold, that we have the CREATE_DUPLICATE_HOLDS permission, and that we
haven't placed more than the maximum allowed number of duplicate holds
before returning the HOLD_EXISTS event.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
* Remove grunt devDependencies
* Add Webpack devDepenencies
* Copy and minify operations are now handled by Webpack via 'npm run
build' for dev builds and 'npm run build-prod' for
production/minified builds.
* Running 'npm run build-watch' executes webpack in --watch mode to
watch for affected file changes and automatically rebuild. Useful for
development.
* Karma unit tests are now invoked directly from node via 'npm run
test'.
* Docs and release installer updated to match.
* Removed long-outdated inline installer readme.
Webpack is configured to create bundles from sets of JS files. As it
stands, there are 2 sets: core.bundle.js and vendor.bundle.js. Core has
all of the EG core services that are loaded on every page. Vendor
contains all of the 3rd-party dependencies (angular, etc.). These 2
bundles are loaded on every web staff page (via base_js.tt2).
All other <script/> tags remain as they were.
When building in dev mode ('npm run build'), core service JS files are
bunded un-minified with an inline source map for debugging. Vendor
files (angularjs, etc.) are always minified because they are quite
large.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Fri, 22 Dec 2017 17:19:43 +0000 (12:19 -0500)]
LP#1739803 Quiet some repetitive console messages for unit tests
These console logs repeat during unit test runs and add clutter (ditto
the browser console log). I commented them out instead of removing them
since they may still be useful for debugging in the future.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Rebuild package.json starting with Angular 1.6. This resulted in a
number of dependency updates and small changes required to keep the
dependencies happy.
* Teach print.js to use promise-style $http responses, instead of
.success() and .error()
* Remove unused '$http' dependency in hatch.js
* Fix egDate custom test matcher to work with newer version of
karma-jasmine.
* Build IDL for test scripts using Grunt/exec "cwd" since Grunt fails to
understand "&&" commands, like 'cd foo && bar'.
* For correctness, move dev-only depenencies into the package.json
devDependencies section.
See also
https://docs.angularjs.org/guide/migration#migrating-from-1-5-to-1-6
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Since the display is not refreshed until the payment finishes, it
is possible to fire off a second payment by double-clicking.
This commit is a simple way to disable the button while a payment is
in process, then enable it again after the display refreshes.
Since the 'sendPayment()' function is wrapped, we may need to move
this logic up, but this being a single promise is simpler, and it
solved the problem in testing.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
projects / Evergreen.git / log