Evergreen.git
4 years agoLP1464765: Speed Up Number Padding for Sort Keys
Jason Boyer [Tue, 30 Jun 2015 12:53:21 +0000 (08:53 -0400)]
LP1464765: Speed Up Number Padding for Sort Keys

[New commit message by Galen Charlton:]
This patch was originally written to fix a problem with
normalization of various labels, but the patches for
bug 1155313 fixed the function problem.  However, testing
shows that this version of evergreen.lpad_number_substrings()
is about a third faster, so this patch is being merged to
get the speed improvement and the additional tests.

Thanks to Thomas Berezansky for a much simplified approach.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1406387 Fix for Holds Placement Advanced Options
Adam Bowling [Mon, 19 Jan 2015 17:05:19 +0000 (12:05 -0500)]
LP#1406387 Fix for Holds Placement Advanced Options

In the staff client, when placing a hold and clicking
Advanced Hold Options, the barcode input will populate
with the staff member's barcode if it was previously
empty, regardless of whether the radio input for the
hold was specified for a patron or the staff member.

This patch corrects that behavior, and also populates
the input radio on load after clicking Advanced Hold
Options.

Signed-off-by: Adam Bowling <abowling@emeralddata>
Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1501471: Stamping SQL update
Bill Erickson [Thu, 5 Nov 2015 14:27:51 +0000 (09:27 -0500)]
LP#1501471: Stamping SQL update

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1501471: add some unit tests for batch OU retrieval
Galen Charlton [Wed, 4 Nov 2015 21:27:14 +0000 (21:27 +0000)]
LP#1501471: add some unit tests for batch OU retrieval

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1501471: add DB function for batch retrieval of OU settings
Galen Charlton [Wed, 30 Sep 2015 22:11:55 +0000 (22:11 +0000)]
LP#1501471: add DB function for batch retrieval of OU settings

This adds a new stored function and a utility routine that uses it
for retrieving a set of OU settings in one fell swoop.  This offers
a significant speed boost for the Dojo patron editor, which loads
about 70 OU settings when it initalizes itself.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1501471: check OU setting view_perms only when needed
Galen Charlton [Wed, 30 Sep 2015 20:16:02 +0000 (20:16 +0000)]
LP#1501471: check OU setting view_perms only when needed

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1251415: (follow-up) fix typos
Galen Charlton [Wed, 4 Nov 2015 22:03:59 +0000 (22:03 +0000)]
LP#1251415: (follow-up) fix typos

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1251415: (follow-up) update release note extension
Galen Charlton [Wed, 4 Nov 2015 21:57:16 +0000 (21:57 +0000)]
LP#1251415: (follow-up) update release note extension

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1251415: juv-to-adult release notes
Bill Erickson [Wed, 19 Aug 2015 14:02:37 +0000 (10:02 -0400)]
LP#1251415: juv-to-adult release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1251415: Juv-to-adult live test
Bill Erickson [Fri, 14 Aug 2015 14:54:31 +0000 (10:54 -0400)]
LP#1251415: Juv-to-adult live test

Confirms org unit setting takes precedence and deleted users are
ignored.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1251415: Skip deleted users in juvenile update
Bill Erickson [Mon, 10 Aug 2015 20:05:45 +0000 (16:05 -0400)]
LP#1251415: Skip deleted users in juvenile update

Avoid setting juvenile = false on deleted users during the batch
juvenile update routine, even if they are a million years old.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1251415: Use the juvenile setting when removing juvenile flag.
Steven Callender [Thu, 14 Nov 2013 20:07:33 +0000 (15:07 -0500)]
LP#1251415: Use the juvenile setting when removing juvenile flag.

When calling the API open-ils.storage.actor.user.juvenile_to_adult,
most notably from the juv_to_adult.srfsh support script, instead of
strictly using the hardcoded passed value, first check the
global.juvenile_age_threshold from the settings based on the user's
home library. If the setting does not exist, then fall back on the
hardcoded passed value.

This will allow each library to be able to set different juvenile
thresholds if needed and at the very least, give control to the
settings rather than rely strictly on the hardcoded passed value.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1502152: (follow-up) fix a typo
Galen Charlton [Wed, 4 Nov 2015 21:51:02 +0000 (21:51 +0000)]
LP#1502152: (follow-up) fix a typo

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP 1502152: Improve marc_export warnings.
Jason Stephenson [Mon, 5 Oct 2015 16:35:37 +0000 (12:35 -0400)]
LP 1502152: Improve marc_export warnings.

Trap warnings from MARC libraries in marc_export so we can report the
id of the record that triggered the warning.

Use warn to print our warnings, instead of print STDERR.  This includes
the existing errors, trapped by eval, that were being printed to STDERR.

To test
-------
[1] Ensure that a record has an error that would become apparent
    during export.  An easy way to do this is to insert the "‡"
    character in the contents of a subfield, then use
    --encoding MARC8 when exporting the record.
[2] Run the MARC export, e.g.,

    cat id_list | marc_export -i > /tmp/bibs.mrc
[3] Verify that a warning is reported, e.g.,

Warning from bibliographic record 1: no mapping found at position 0...

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740: remove ersatz --auth-source switch
Galen Charlton [Wed, 4 Nov 2015 20:27:33 +0000 (20:27 +0000)]
LP#1384740: remove ersatz --auth-source switch

Looks like a bit of copy-and-pastitis; authority records
don't presently have an equivalent to the Evergreen bib
source.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740: (follow-up) change extension of release note
Galen Charlton [Wed, 4 Nov 2015 18:39:55 +0000 (18:39 +0000)]
LP#1384740: (follow-up) change extension of release note

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740 MARC stream importer auth release notes
Bill Erickson [Tue, 18 Aug 2015 14:47:56 +0000 (10:47 -0400)]
LP#1384740 MARC stream importer auth release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740 MARC stream (etc) use auth nonce
Bill Erickson [Wed, 24 Jun 2015 15:00:25 +0000 (11:00 -0400)]
LP#1384740 MARC stream (etc) use auth nonce

Add an authentication nonce to the shared oils_header.pl file to avoid
too-many-logins by a single username causing login rejections.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740 marc_stream_importer no-import repairs
Bill Erickson [Tue, 23 Jun 2015 20:17:07 +0000 (16:17 -0400)]
LP#1384740 marc_stream_importer no-import repairs

Report "no_import" records, which occur when a record fails to import
due to merge rules, quality rules, etc. (i.e. non-error conditions) as
failures to the client.

Also deprecates the "--queue" parameter, suggesting instead to use
--bib-queue or --auth-queue.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740 marc_stream_importer test script
Bill Erickson [Fri, 21 Nov 2014 23:12:34 +0000 (18:12 -0500)]
LP#1384740 marc_stream_importer test script

Simple test script which sends a single authority record over the
network for testing marc_stream_importer.pl.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1384740 marc_stream_importer auth and cleanup
Bill Erickson [Thu, 20 Nov 2014 22:53:52 +0000 (17:53 -0500)]
LP#1384740 marc_stream_importer auth and cleanup

Add support for importing authority records to marc_stream_importer and
clean up some cruft along the way.  A single instance of the script can
import either type of record.  The record leader is inspected to
determine if it's an authority record or not.

New options:

--auth-merge-profile
--auth-queue
--auth-source
--bib-import-no-match
--bib-auto-overlay-exact
--bib-auto-overlay-1match
--bib-auto-overlay-best-match
--auth-import-no-match
--auth-auto-overlay-exact
--auth-auto-overlay-1match
--auth-auto-overlay-best-match

Deprecated options:

--import-no-match
--auto-overlay-exact
--auto-overlay-1match
--auto-overlay-best-match

These map to the new --bib-* versions for now, but will be removed
in a future version for clarity / consistency.  The script will
print a deprecation warning when these are used.

Cleanup:

--import-by-queue is no longer supported.  This option serves no
particular purpose and is a bad idea when re-using the same queue over
and over as most people do, because queue bloat will increase run times.

--noqueue (AKA "direct import") is no longer supported.  All imports go
through Vandelay now.

Opens a new XMPP connection with each forked child during child init.
Previously, a single XMPP connection was shared by all forked children,
which lead to crossed streams and chaos.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1340852: Retain search params for copy location groups
Jake Litrell [Mon, 14 Sep 2015 21:49:29 +0000 (17:49 -0400)]
LP#1340852: Retain search params for copy location groups

The order in which we determined what to 'selected' in the "Library"
dropdown put the resolved locg first (which allows for shortnames, e.g.
BR1).  That only gives us half the location group though, which is why
it was bumping up a level.  Now, if we have a location group selected,
it will use that first (since they don't have shortnames); the remaining
select order will be the same.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1467634: Hide saved searches from screen readers for non-staff client
Yamil Suarez [Mon, 22 Jun 2015 18:33:28 +0000 (14:33 -0400)]
LP#1467634: Hide saved searches from screen readers for non-staff client

This commit will only allow screen readers to see the saved searches for
users that are logged through XUL client.
Assuming that a screen reader can be attached to the XUL client.

It should also work for a user logged in through the web staff
client that is using a screen reader.

To test
-------
[1] Apply the patch, then perform a search in the public catalog and
    view the HTML source.  Verify that there's no "sr-only" heading
    for "Saved searches".
[2] Set the opac.staff_saved_search.size library setting to a non-zero
    value.
[3] In the web staff client, perform a search using the embeded OPAC;
    verify that the recent searches list is displayed.
[4] Repeat step 4 in the XUL client.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1503782: fix horizontal scrollbar in MARC import queue inspector
Galen Charlton [Wed, 7 Oct 2015 17:49:19 +0000 (17:49 +0000)]
LP#1503782: fix horizontal scrollbar in MARC import queue inspector

In the XUL client (and webstaff), attempting to view the contents
of a MARC record import queue displays a table that, due to
its width, will almost always have a horizontal scrollbar. However,
attempting to actually use the scrollbar often causes the
focus to jump to the top of the table instead.  This patch
fixes that.

To test:

[1] Create a bib queue that has at least a dozen records or so.
[2] Inspect the contents of the queue, scroll to the bottom of
    the table, and interact with the horizontal scrollbar.
[3] Observe that doing so typically results in jumping up
    to the top of the table.
[4] Apply the patch, clear cache and refresh, and try step #2
    again.
[5] This time, the horizontal scrollbar should act normally.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
4 years agoLP#1406786: fix remapping copies during parts merge
Galen Charlton [Thu, 29 Oct 2015 19:30:31 +0000 (19:30 +0000)]
LP#1406786: fix remapping copies during parts merge

This patch fixes an issue with how copies are mapped
on the target part when using "Merge Selected" in the
Monograph Parts interface.

To test:

[1] Create some monograph parts on a record and assign
    some copies to use them.
[2] Use the merge parts function to collapse all of the
    parts created in step 1 onto a single part.
[3] Verify that the copies whose original parts were removed
    are now mapped onto the part that was the target of the
    merge.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 years agoLP#1482336: use *.adoc as extension for extant release notes
Galen Charlton [Wed, 4 Nov 2015 17:10:43 +0000 (17:10 +0000)]
LP#1482336: use *.adoc as extension for extant release notes

Note that for any pending branches that already have release
notes, the *.txt extension will still be recognized.

This patch also adjusts the release notes script to account for the
new name of the template file.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1482336 - Add *.adoc support to create_release_notes.sh
Josh Stompro [Thu, 3 Sep 2015 21:22:00 +0000 (16:22 -0500)]
LP#1482336 - Add *.adoc support to create_release_notes.sh

This allows release note entries under /docs/RELEASE_NOTES_NEXT to
use the .adoc extension.  It also changes the output file format to .adoc
because why not.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1504615: add release notes
Galen Charlton [Wed, 4 Nov 2015 16:33:53 +0000 (16:33 +0000)]
LP#1504615: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1504615: include part names when sorting copies for public catalog display
Dan Pearl [Mon, 2 Jun 2014 14:03:27 +0000 (10:03 -0400)]
LP#1504615: include part names when sorting copies for public catalog display

This adds a level of sorting to allow certain parts to be more
easily found in the list.

The hierarchy will now be:
Org Unit / Call Number / Part Label Sortkey / Copy Number / Barcode

Previously, the hierarchy was
Org Unit / Call Number / Copy Number / Barcode

To test:

[1] Create a record with several copies under one volume
    using different monograph parts.  Observe that the
    order of copies in the record details page in the
    public catalog is not sorted by part.
[2] Apply the patch and view the records details page; this
    time, the copies should be sorted by part.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1510641 Release notes (PO actions selector)
Bill Erickson [Tue, 27 Oct 2015 18:15:18 +0000 (14:15 -0400)]
LP#1510641 Release notes (PO actions selector)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1510641 Always show actions selector in PO view
Bill Erickson [Tue, 27 Oct 2015 18:08:53 +0000 (14:08 -0400)]
LP#1510641 Always show actions selector in PO view

Ensure the actions selector is always visible for PO's, even when no
lineitems are present.  This allows printing and history view (and
potentially future actions) for PO's that only contain direct charges.

The custom Add Brief Record button is no longer present, since the same
action is accessible from the actions selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
4 years agoLP#1509479: set a limit on loops in QP's decompose() method
Galen Charlton [Fri, 23 Oct 2015 20:03:07 +0000 (20:03 +0000)]
LP#1509479: set a limit on loops in QP's decompose() method

Following a suggestion of Dan Scott's, add a pair of
suspenders to the belt and enforce an arbitrary limit
of 1000 passes through QP->decompse().

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP#1509479: fix infinite loop bug in QueryParser
Galen Charlton [Fri, 23 Oct 2015 19:23:05 +0000 (19:23 +0000)]
LP#1509479: fix infinite loop bug in QueryParser

An unclosed phrase search that has a modifier can cause QueryParser to
enter an infinite loop, tying up open-ils.storage backends.

Examples of such searches include:

  -"cats and dogs
  subject:+"physical chemistry

This patch fixes the bug by allowing the end of the query string
to terminate a phrase (in addition to a quotation mark).

To test:

[1] Verify that the t/21-QueryParser.t unit test passes
[2] To test in a *development* database, before applying the patch
    run one of the example queries.  Observe that no
    results are returned, and that one of the open-ils.storage
    drones is running at 100% CPU.
[3] Apply the patch and restart the open-ils.storage service.
[4] Try the query again; this time, it should return results
    immediately without causing an open-ils.storage drone to
    peg a CPU.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
4 years agoLP#838525 DoB as date SQL upgrade repairs
Bill Erickson [Mon, 12 Oct 2015 15:12:07 +0000 (11:12 -0400)]
LP#838525 DoB as date SQL upgrade repairs

1. Modify auditor.actor_usr_history DoB column in the same manner
   as actor.usr to ensure consistent date truncation.

2. let update_auditors() recreate auditor.actor_usr_lifecycle for us.

3. Wrap the whole shebang in a PLPGSQL "DO" block so we can easily test
for the presence of optional reporter views that depend on actor.usr, so
they can be recreated as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoDocs: Rename bullet images to fix epub build error
Remington Steed [Fri, 9 Oct 2015 18:58:01 +0000 (14:58 -0400)]
Docs: Rename bullet images to fix epub build error

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoRelease Notes: Move/copy relevant sections to Upgrade Notes
Remington Steed [Thu, 24 Sep 2015 15:09:33 +0000 (11:09 -0400)]
Release Notes: Move/copy relevant sections to Upgrade Notes

This commit moves two sections from "New Features -> Administration ->
Upgrade Notes" to the main level "Upgrade Notes" section, which had been
accidentally left empty and was causing AsciiDoc-to-ePub conversion
errors. This commit also copies two other sections to the main "Upgrade
Notes" section, since they contain information relevant to the upgrade
process.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP 1502156: Fix marc_export error when dumping authorities.
Jason Stephenson [Fri, 2 Oct 2015 14:17:09 +0000 (10:17 -0400)]
LP 1502156: Fix marc_export error when dumping authorities.

There is a chance that marc_export will attempt to call a nonexistent
field on MARC::Record if an error occurs while exporting authority
records.  The bug could only be triggered if a conversion error
occurred while exporting the authority as either MARCXML or USMARC.

The fix is to rename a couple of variables in the Marque::Authority->next
method to be more like those used in Marque::Biblio->next.  This will have
the side effect of making marc_export easier to maintain, since the
variables used in one method will now have the same meaning as those
in the other.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
5 years agoDocs 2.9: Add summary of Web Client changes
Remington Steed [Fri, 2 Oct 2015 13:41:39 +0000 (09:41 -0400)]
Docs 2.9: Add summary of Web Client changes

This commit adds the Web Client release notes summary to the appropriate
docs section. It also updates the wording and links regarding the
completed UI Style Guide internship.

Next we need to copy the Cataloging content into the web client section
and provide web client screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDoc build: update the implicit ID for release notes
Dan Scott [Thu, 1 Oct 2015 20:13:45 +0000 (16:13 -0400)]
Doc build: update the implicit ID for release notes

The implicit ID for a given heading changes each release as we update
the release notes, so bump 2.8 to 2.9 so that the reference to the ID
can be resolved.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoDocs: Update release notes reference to 2.9
Remington Steed [Thu, 17 Sep 2015 15:10:51 +0000 (11:10 -0400)]
Docs: Update release notes reference to 2.9

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDoc build: use the implicit ID for lib settings editor
Dan Scott [Thu, 1 Oct 2015 20:16:27 +0000 (16:16 -0400)]
Doc build: use the implicit ID for lib settings editor

We no longer have an explicitly set ID for the library settings editor
section, so update references to use the implicit ID instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoDoc build: link to the right media file
Dan Scott [Thu, 1 Oct 2015 20:15:12 +0000 (16:15 -0400)]
Doc build: link to the right media file

The screenshot for the list of call numbers is a PNG image, not a JPEG
image, so referring to it with the appropriate extension will make it
show up in the docs and enable the epub and PDF builds to successfully
complete.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoDoc build: use XML-compliant IDs
Dan Scott [Thu, 1 Oct 2015 20:11:57 +0000 (16:11 -0400)]
Doc build: use XML-compliant IDs

Doc builds that depend on an intermediate XML transform (epub, PDF) also
need to use IDs that comply to the XML standard. In this case, numbers
are not valid NameStartChars:
http://www.w3.org/TR/REC-xml/#NT-NameStartChar

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAvoid duplicate IDs in doc build
Dan Scott [Thu, 1 Oct 2015 20:10:41 +0000 (16:10 -0400)]
Avoid duplicate IDs in doc build

Defining the same ID twice in the same document results in broken builds
that depend on an intermediate XML transform (epub, PDF), so redefine
the second ID in this document.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoStamping upgrade script and test file
Mike Rylander [Thu, 1 Oct 2015 18:50:44 +0000 (14:50 -0400)]
Stamping upgrade script and test file

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#838525 libdbi DATE types translated via gmtime
Bill Erickson [Tue, 29 Sep 2015 16:10:53 +0000 (12:10 -0400)]
LP#838525 libdbi DATE types translated via gmtime

libdbi assumes a date (w/ no time or timezone) is GMT.  Parse the date
via gmtime() instead of localtime() to ensure the date returned to the
caller matches the date in the DB.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#838525 DoB as date PGTAP test
Bill Erickson [Wed, 30 Sep 2015 16:13:21 +0000 (12:13 -0400)]
LP#838525 DoB as date PGTAP test

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#838525 Store date of birth as SQL DATE type
Bill Erickson [Tue, 29 Sep 2015 16:10:31 +0000 (12:10 -0400)]
LP#838525 Store date of birth as SQL DATE type

Upgrade script translates DoB ahead 3 hours before translating to DATE
(from TIMESTAMPTZ) to ensure dates stored in alternate daylight savings
TZ (e.g. -05 vs. -04) are translated to the proper date.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoDocs: Documentation for negative balance work
Kathy Lussier [Thu, 10 Sep 2015 18:28:57 +0000 (14:28 -0400)]
Docs: Documentation for negative balance work

Documentation for negative balance settings in 2.9. The updates in this branch
include:

* Updates of the circulation, patron record, and library settings sections
to reflect the new features contained in the negative balance work.
* General updates, consolidation, and re-organization of some components
of the billing section.

A new understanding and confiuring billing section is still to come, but this
branch brings existing documentaiton up to date.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1497318 - Acknowledgments update Adding Northwest Regional Library System to 2...
Josh Stompro [Sun, 20 Sep 2015 15:43:10 +0000 (10:43 -0500)]
LP#1497318 - Acknowledgments update Adding Northwest Regional Library System to 2.8 and 2.9
  and Matthew Berowski for typo fixes to 2.8 Release Notes.

Signed-off-by: Josh Stompro <stomproj@larl.org>
5 years agoLP 1497307: Fix 2.8.4 to 2.9.0 upgrade script.
Jason Stephenson [Fri, 18 Sep 2015 15:06:07 +0000 (11:06 -0400)]
LP 1497307: Fix 2.8.4 to 2.9.0 upgrade script.

Chris Sharp noticed another ERROR: cannot ALTER TABLE
"record_attr_definition" because it has pending trigger events
with the 2.8.4 to 2.9.0 upgrade script.  I have rearranged the
transactions so that there are now 3.

1. One for the initial inserts and other changes up to 0937.

2. One for the two alter table statements in 0937.

3. One for 0938 to the end (0944).

This resolves the issue and works for me on an upgrade from a
clean 2.8.4 installation.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoDocs: Restoring the acknowledgements template
Kathy Lussier [Fri, 18 Sep 2015 14:06:31 +0000 (10:06 -0400)]
Docs: Restoring the acknowledgements template

Restoring the acknowledgements template back to **TO DO** so that we don't
mistakenly do acknowledgements for 2.9 contributions in 2.next.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon
Jason Stephenson [Thu, 17 Sep 2015 19:12:40 +0000 (15:12 -0400)]
LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon

It looks like two lines of code got duplicated in commit e2f6cca0 in
AssetCommon.  This duplication can lead to data loss for the function
update_fleshed_copies.  It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:

"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.

After this patch, the warning disappears.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoDocs: Apache config includes examples for "no image"
Remington Steed [Thu, 17 Sep 2015 13:35:19 +0000 (09:35 -0400)]
Docs: Apache config includes examples for "no image"

This commit adds a note about the new commented config blocks in the
example Apache vhost file for providing a custom image for items with no
image. This commit also moves a related section into the "External
Content" section, so all external content info is together.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoLP#1496837: Postgres fixed a bug and broke our test
Mike Rylander [Thu, 17 Sep 2015 12:24:56 +0000 (08:24 -0400)]
LP#1496837: Postgres fixed a bug and broke our test

So, we will unbreak it here.  The PG fix in question can be seen here:

http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=c975fa4713c2325623d7bbfd81806327234281ac

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoDocs: Fix typo in acknowledgements for RELEASE_NOTES_2_9.txt
Ben Shum [Thu, 17 Sep 2015 03:43:13 +0000 (23:43 -0400)]
Docs: Fix typo in acknowledgements for RELEASE_NOTES_2_9.txt

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years agoDocs: Add one missing entry to RELEASE_NOTES_2_9.txt
Ben Shum [Thu, 17 Sep 2015 03:09:11 +0000 (23:09 -0400)]
Docs: Add one missing entry to RELEASE_NOTES_2_9.txt

Because one of the notes was written with a .adoc extension
instead of the .txt, the automated script missed it.

Adding this entry to the main RELEASE_NOTES_2_9.txt file and
removing the .adoc file.

Signed-off-by: Ben Shum <bshum@biblio.org>
5 years ago2.9 Release notes creation and cleanup
Jason Stephenson [Wed, 16 Sep 2015 22:08:37 +0000 (18:08 -0400)]
2.9 Release notes creation and cleanup

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoForward port 2.9.0 translations.
Jason Stephenson [Wed, 16 Sep 2015 20:42:52 +0000 (16:42 -0400)]
Forward port 2.9.0 translations.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoPorting 2.8.4->2.9.0 SQL upgrade
Jason Stephenson [Wed, 16 Sep 2015 21:41:46 +0000 (17:41 -0400)]
Porting 2.8.4->2.9.0 SQL upgrade

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoDocs 2.9: Update and add detail for Holdings Import profile
Remington Steed [Wed, 16 Sep 2015 21:07:13 +0000 (17:07 -0400)]
Docs 2.9: Update and add detail for Holdings Import profile

In order to add details about the new ability to import Stat Cat data
for a copy, this commit adds a table of all the import fields available
in the Holdings Import Profile. It also duplicates some content from
another section about batch importing, and updates the screenshot and
some wording in the original section.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocs: 2.8 Acknowledgements addition
Kathy Lussier [Wed, 16 Sep 2015 20:14:51 +0000 (16:14 -0400)]
Docs: 2.8 Acknowledgements addition

We missed acknowledgements for a few code contributors during the 2.8.3
point release. Adding them here as well as a fix to get the header to display
properly for the 2.8.4 release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoAdditions to the 2.9 release notes
Kathy Lussier [Wed, 16 Sep 2015 18:03:42 +0000 (14:03 -0400)]
Additions to the 2.9 release notes

Adjusting the release notes entry for conditional negative balances to reflect
recent changes in the code and adding ackwnowledgements. Also, cleaning up some
grammar and removing entries that already made it into point release notes as
bug fixes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoPorting 2.8.3->2.8.4 SQL upgrade
Bill Erickson [Wed, 16 Sep 2015 19:20:49 +0000 (15:20 -0400)]
Porting 2.8.3->2.8.4 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years ago2.8.4 release notes
Kathy Lussier [Wed, 16 Sep 2015 18:33:37 +0000 (14:33 -0400)]
2.8.4 release notes

Release notes for the 2.8.4 point release.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1494544 Stamping Upgrade Script
Jason Stephenson [Wed, 16 Sep 2015 17:30:02 +0000 (13:30 -0400)]
LP#1494544 Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1494544 Complete XUL UI for adjustment vs. void options
Dan Wells [Tue, 15 Sep 2015 19:28:44 +0000 (15:28 -0400)]
LP#1494544 Complete XUL UI for adjustment vs. void options

This commit does several things to complete the adjustment UI changes.

1) Adds "Adjust to Zero" to the "Actions" menu.  It was previously only
on the right-click popup.
2) Shows or hides the void/adjustment controls based on permissions.
3) Generates a new force-verified warning if you attempt to void, but
there is also some chance that doing so would be contrary to your
negative balance policy settings.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1494544 Add ADJUST_BILLS permission to seed data
Dan Wells [Mon, 14 Sep 2015 15:12:38 +0000 (11:12 -0400)]
LP#1494544 Add ADJUST_BILLS permission to seed data

This commit adds the new ADJUST_BILLS permission to the seed data.
Note that the upgrade script only adds the perm and avoids adding it
to any groups, as that should only be done with local discretion.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: LP#1437110 add Manual Floating Active
Victoria Lewis [Thu, 16 Jul 2015 20:07:04 +0000 (13:07 -0700)]
webstaff: LP#1437110 add Manual Floating Active

Add Manual Floating Active to Checkin Modifiers in web staff client.

Signed-off-by: Victoria Lewis <“vlewis@catalystitservices.com”>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agowebstaff: LP#1436980: Default copy circ count to 0 instead of undefined
Mike Rylander [Wed, 16 Sep 2015 14:28:46 +0000 (10:28 -0400)]
webstaff: LP#1436980: Default copy circ count to 0 instead of undefined

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agowebstaff: LP#1436980 Total Circulations in Patron Bills
Victoria Lewis [Fri, 24 Jul 2015 22:08:15 +0000 (15:08 -0700)]
webstaff: LP#1436980 Total Circulations in Patron Bills

Add code to display Total Circulations in
Item Summary on Bills page.

Signed-off-by: Victoria Lewis <vlewis@catalystitservices.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agowebstaff: LP#1483857 Add code to clear barcodes from in-house use
Stephen Moss [Tue, 18 Aug 2015 18:28:25 +0000 (11:28 -0700)]
webstaff: LP#1483857 Add code to clear barcodes from in-house use

Signed-off-by: Stephen Moss <smoss@catalystitservices.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agowebstaff: Provide hooks for on-save callback for marc edit to, for instance, refresh...
Mike Rylander [Tue, 15 Sep 2015 21:32:41 +0000 (17:32 -0400)]
webstaff: Provide hooks for on-save callback for marc edit to, for instance, refresh the record summary UI

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agowebstaff: record summary now signals if record is deleted
Galen Charlton [Tue, 15 Sep 2015 01:22:12 +0000 (01:22 +0000)]
webstaff: record summary now signals if record is deleted

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agolp1494427: Fix refund error
Kathy Lussier [Fri, 11 Sep 2015 17:54:32 +0000 (13:54 -0400)]
lp1494427: Fix refund error

Fixes an error that occurs when attempting to refund a negative balance from
the patron's bill record. We removed the staff.patron.bills.handle_refund.
confirm_message string, which caused the error when the handle_refund function
tried to retrieve the string. It turns out the string never displayed in the
client. Therefore, in this branch, we stop the handle_refund function from
trying to retrieve the string. I did the confirmation message for the
adjust_to_zero function since the same issue was occurring there.

Test case: Find a negative balance transaction and, from the patron's bills
record, select the transaction and select the option to Refund. Pre-patch, this
action will generate an error message. Post-patch, this action should generate
a prompt asking the user to confirm the action.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoFix typo in comment in 002.schema.config.sql.
Jason Stephenson [Mon, 14 Sep 2015 20:08:06 +0000 (16:08 -0400)]
Fix typo in comment in 002.schema.config.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP 1495509: Stamping upgrade scripts.
Jason Stephenson [Mon, 14 Sep 2015 19:55:26 +0000 (15:55 -0400)]
LP 1495509: Stamping upgrade scripts.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agoLP#1489955: tweak to work on PostgreSQL 9.1
Galen Charlton [Mon, 14 Sep 2015 15:34:47 +0000 (15:34 +0000)]
LP#1489955: tweak to work on PostgreSQL 9.1

Stored functions written in SQL cannot use parameter
names in their bodies until Pg 9.2.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: update release notes for sprint 2
Galen Charlton [Mon, 14 Sep 2015 13:08:12 +0000 (13:08 +0000)]
webstaff: update release notes for sprint 2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: explicitly pass record type to MARC editor from Z39.50
Galen Charlton [Fri, 11 Sep 2015 13:40:30 +0000 (13:40 +0000)]
webstaff: explicitly pass record type to MARC editor from Z39.50

This fixes a bug where the Edit then Import action would
pop up an empty MARC editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Remove dependency-suggesting indent from "Use checkdigit" default
Mike Rylander [Thu, 10 Sep 2015 19:09:22 +0000 (15:09 -0400)]
webstaff: Remove dependency-suggesting indent from "Use checkdigit" default

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Propagate changes to barcode auto-gen defaults immediately
Mike Rylander [Thu, 10 Sep 2015 19:08:07 +0000 (15:08 -0400)]
webstaff: Propagate changes to barcode auto-gen defaults immediately

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Add barcode generation and checkdigit checking
Mike Rylander [Thu, 10 Sep 2015 17:16:20 +0000 (13:16 -0400)]
webstaff: Add barcode generation and checkdigit checking

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: tweak Phys Char Wizard layout
Galen Charlton [Thu, 10 Sep 2015 15:01:42 +0000 (15:01 +0000)]
webstaff: tweak Phys Char Wizard layout

Ensure that if a drop-down is particularly wide, it
can no longer overlap with the previous/next buttons.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Phys Char Wiz various additions and repairs
Bill Erickson [Thu, 10 Sep 2015 00:52:14 +0000 (20:52 -0400)]
webstaff: Phys Char Wiz various additions and repairs

 * Show <unset> as selector value when no value is selected
 * Properly handle gaps (undefined slots) in 007 field value
 * Return to origin value when dialog Cancel is chosen

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Phys Char Wiz : wizard continued
Bill Erickson [Tue, 8 Sep 2015 13:23:02 +0000 (09:23 -0400)]
webstaff: Phys Char Wiz : wizard continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Phys Char Wiz : wizard continued
Bill Erickson [Tue, 8 Sep 2015 00:37:40 +0000 (20:37 -0400)]
webstaff: Phys Char Wiz : wizard continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Phys Char Wiz : initial dialog / wizard
Bill Erickson [Mon, 7 Sep 2015 17:46:01 +0000 (13:46 -0400)]
webstaff: Phys Char Wiz : initial dialog / wizard

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Phys Char Wiz : launcher link
Bill Erickson [Mon, 7 Sep 2015 15:51:39 +0000 (11:51 -0400)]
webstaff: Phys Char Wiz : launcher link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Phys Char Wiz : initial service funcs
Bill Erickson [Mon, 7 Sep 2015 15:23:48 +0000 (11:23 -0400)]
webstaff: Phys Char Wiz : initial service funcs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: implement Transfer Title Holds from record bucket
Galen Charlton [Thu, 10 Sep 2015 01:06:01 +0000 (01:06 +0000)]
webstaff: implement Transfer Title Holds from record bucket

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Allow optional override of TITLE_LAST_COPY event
Mike Rylander [Thu, 10 Sep 2015 00:15:33 +0000 (20:15 -0400)]
webstaff: Allow optional override of TITLE_LAST_COPY event

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Transfer Copies to Marked Volume
Jason Etheridge [Wed, 9 Sep 2015 22:02:06 +0000 (18:02 -0400)]
webstaff: Transfer Copies to Marked Volume

in Copy Bucket

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Allow editing of /only/ volume data
Mike Rylander [Wed, 9 Sep 2015 23:51:27 +0000 (19:51 -0400)]
webstaff: Allow editing of /only/ volume data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Allow adding vol/copy to an empty bib (or when no vol/lib is selected)
Mike Rylander [Wed, 9 Sep 2015 23:51:06 +0000 (19:51 -0400)]
webstaff: Allow adding vol/copy to an empty bib (or when no vol/lib is selected)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: implement Merge Selected Records from record bucket
Galen Charlton [Wed, 9 Sep 2015 22:56:08 +0000 (22:56 +0000)]
webstaff: implement Merge Selected Records from record bucket

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Add "add items to bucket" action to holdings maint
Mike Rylander [Wed, 9 Sep 2015 20:26:44 +0000 (16:26 -0400)]
webstaff: Add "add items to bucket" action to holdings maint

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Refactor replace-barcode to be reusable, and reuse it in holdings maint
Mike Rylander [Wed, 9 Sep 2015 17:57:41 +0000 (13:57 -0400)]
webstaff: Refactor replace-barcode to be reusable, and reuse it in holdings maint

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: Conjoined items management
Mike Rylander [Wed, 9 Sep 2015 14:17:05 +0000 (10:17 -0400)]
webstaff: Conjoined items management

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
5 years agowebstaff: ensure that side-by-side MARC record views don't overlap text
Galen Charlton [Tue, 8 Sep 2015 21:47:49 +0000 (21:47 +0000)]
webstaff: ensure that side-by-side MARC record views don't overlap text

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>