Merge remote branch 'working/collab/phasefx/unified_vol_copy_ui_from_item_status_ui'

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Remove extraneous COMMIT message in 950 seed data

The extra COMMIT message didn't hurt when creating a new schema, but did
result in a warning message that could cause confusion. So, get rid of
it to avoid that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Item Status->Alternate View support for the dynamic Record Summary

For now, you could put something like this in server/skin/custom.js to re-configure the display:

try {

    netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
    var prefs = Components.classes['@mozilla.org/preferences-service;1'].getService(Components.interfaces['nsIPrefBranch']);
    prefs.setCharPref(
        'oils.bib_brief.alternate_copy_summary.dynamic_grid_replacement.data',
        js2JSON([
            ['title',       'edition',  'editor'],
            ['author',      'pubdate',  'edit_date'],
            ['call_number', 'tcn',      'create_date']
        ])
    );

} catch(E) {
    dump('Error in custom.js trying to set oils.bib_brief.alternate_copy_summary.dynamic_grid_replacement.data: ' + E + '\n');
}

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

dynamic Record Summary layout based on preference

For now, you could add something like this to server/skin/custom.js to re-configure the display:

try {

    netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
    var prefs = Components.classes['@mozilla.org/preferences-service;1'].getService(Components.interfaces['nsIPrefBranch']);
    prefs.setCharPref(
        'oils.bib_brief.horizontal.dynamic_grid_replacement.data',
        js2JSON([
            ['title',           'edition',  'editor'],
            ['author',          'pubdate',  'edit_date'],
            ['bib_call_number', 'tcn',      'create_date']
        ])
    );

} catch(E) {
    dump('Error in custom.js trying to set oils.bib_brief.horizontal.dynamic_grid_replacement.data: ' + E + '\n');
}

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

some refactoring in prep for dynamic Record Summary layout

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

in staff Record Summary (bib brief) pane, stretch the column for title, author, and bib call #

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Address minor code formatting consistency

The rest of the code has spaces around the conditional clause in an if()
statement, so do likewise here.

Signed-off-by: Dan Scott <dan@coffeecode.net>

Spine label editor assumes LC as reported in LP #780665.

This patch encapsulates the LC-assuming code in an IF block which
considers the asset.call_number.volume.label_class.  If that is equal to
3, it will use the LC formatting.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>

fix bill ui display update bug where total owed and total checked were not updated if the total owed as paid off in full

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Bad join condition all_circulation view"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Bad join condition in secondary (physical) address lookup, causing terrible performance of circ aging

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP795032 Fix cursor rendering and dropdown position in holdings maintenance OU dropdown
Signed-off-by: mrpeters-isl <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Opac Renewal at original circ library"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Default to existing behaviour for the new circ-behaviour global flag

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Cache global flag at first use

This way only the first opac renewal per backend has to ask the database for the global flag.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Opac Renewal at original circ library

Fixes multiple potential issues:
1 - Bad home ou on patron breaks circ rules
    Ex. Patron edited while editor would let you pick bad home ou
2 - Item not allowed to circ at patron home ou
    Ex. Patron went to where they were allowed to pick it up
3 - Fines change to patron home ou fine rules
    Ex. Patron's home ou doesn't charge fines but circ lib does
    Ex. Circ lib doesn't charge fines but Patron's home ou does

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Prevent OU loops at DB level"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script for ou loop protect

May need to be split into "create function" and "add trigger" pieces.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Prevent OU loops at DB level

Database trigger to prevent actor.org_unit from being parent of self

Actually detects any loops, even those above the current point

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make spell-checking case insensitive

As it stands, if you search for a proper noun using
lower case, but manage to trigger the "did you mean"
functionality, all the words are 'corrected' even if
just the case is wrong.  However, we are stripping
out the best correction precisely because it is the
same word, different case.  It is a bit confusing to
explain, but here is an example:

daniel potatoe

gets corrected to:

Daniela potato

This happens because the current spell check is case
sensitive, so 'daniel' is spelled wrong, but then we
remove 'Daniel' from the list of corrections
(presumably to avoid possibly suggesting terms which
would yield the same exact result set).

So, we either need to make the spell-check itself case
insensitive, or stop removing the re-cased corrections.
Since the catalog search itself is already
case-insensitive, I think it makes sense that the spell
check should follow suit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "INDB Circ Matrix + Checkout Overrides Fix"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script for checkout overrides

Replace the function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

INDB Circ Matrix + Checkout Overrides Fix

Move most failures to after matchpoint lookup.
This prevents "no duration rule" errors on overridable errors.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Fix part holds in reporter.hold_request_record"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix part holds in reporter.hold_request_record

Specifically, make them show a bib id, instead of null.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Vandelay item import copy location inheritance

When importing items that have a copy location configured and no such
location exists at the copy's owning/circ lib, Vandelay will now use
copy locations from ancestor org units as appropriate.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Corrected the logic of format string building for metarecord holds and...

made hold possiblity checking for metarecord holds respect the format
string (so you can't place holds on formats for which there will never
be anything targetable)

Made possible by much concerted effort from Mike Rylander

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Correct CDBI thinko -- search_where is smart about wantarray, search is not

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Remove deprecated, conflicting version of vandelay.match_bib_record from base schema.  Thanks, Galen

Signed-off-by: Bill Erickson <berick@esilibrary.com>

pin an upgrade version for fix_maintain_901_quoting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

upgrade script for bugfix for lp#809540

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

lp#809540: quote replacement values properly in maintain_901()

Prevents a failure if, for example, the tcn_value of a bib to be
added or updated contains the string '\1'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

alert the user when the OPAC's Quick Search->Item Barcode function returns a pre-cataloged item

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

"Mark Local Result as Overlay Target" action in z39.50 client

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Removing errant comma spotted by Thomas Berezansky

Signed-off-by: Mike Rylander <mrylander@gmail.com>

append line items to table in specified order

Prior to this patch, the order that line items were displayed
in (e.g.) a purchase order view was effetively randomized based
on the amount of time it would take for async calls to fetch
additional line item details to return.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'authority-control-sets-squashed_for_master'

Authority control sets! Largely by Mike Rylander, somewhat by me and
others.

This is the merge commit.  See individual commit messages for more
detail.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamping Mike's upgrade script for authority control sets

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Unstamped upgrade script for Authority Control Sets

... with additional fixes from Lebbeous Fogle-Weekley

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge/rebase cleanup -- remove useless/incorrect versions of the MARC flattener for different record types

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge/rebase cleanup -- authority template by id is needed

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make search by authority ID actually work on the first try

and also show an odd number of authority record results so that
there can actually be a "middle."

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Provide sorters for browse axes

Make the default bib result sorter 'titlesort' for every
browse axis, which is what makes sense if you think about it.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Create facet for going right to records linked to a given authority record

Still need an upgrade script, of course, but so does this whole branch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

attempted to add sanity to paging, but not really there yet

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Make linking to bib records work better by saying any format will do.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

working! with paging and linking to bibs, except:

... my new facet thingy doesn't seem to work.  here's what I did
sql-wise:

    INSERT INTO config.metabib_field (
        id, field_class, name, label, xpath,
        format, search_field, facet_field
    ) VALUES (
        28, 'identifier',
        'authority_id', 'Authority Record ID',
        '//marc:datafield/marc:subfield[@code=''0'']', 'marcxml', false, true
    );

    INSERT INTO config.metabib_field_index_norm_map (field, norm)
    VALUES (28, 5);

Yet after re-ingesting my bibs I have nothing new in
metabib.facet_entry.  So the "show related bibliographic holdings" links
don't quite work (I believe they /would/, though, if I had the facet
thingy right).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Finally starting to get somewhere: record display

Record display kind of works.  Need paging and links to bibs.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Closer to being able to get authority control set from thesaurus code

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

towards using fielder in openils.AuthorityControlSet

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

working on an auth browser

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add function to set Control Set by Thesaurus Code

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Normalize fixed field names to OCLC values where they exist (what catalogers are used to)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

config ui trivial improvements, scratching out a place for a browse UI

Fix minor glitch when trying to create new authority fields

The Autogrid can handle empty arrays as values for acsaf.bib_fields and
acsaf.axis_maps, but can't handle undefined.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Move the authority control set config interfaces back into conify

Really, that's where they make sense.  And they're done.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Axis-field map editor and editor for the axes themselves

The editor for the axes themselves is accessed directly from staff
client menu.  Everything else is reached indirectly from the control set
editor.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add bib field editor.  Also make all the editors written so far...

... for authority control sets-related objects do the right thing to
help users create/edit new child objects linked to the right parent
table without extra effort.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Ability to return to specific authority.control_set or

to specific authority.control_set_authority_field from a child table.
Other improvements heading toward finishing authority control set config UI

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Editor for authority fields

Due to time constraints (and AutoGrid limitations) a click-through UI
with separate pages for separate objects used by the new authority
control sets feature is necessary for now rather than a comprehensive
interface with multiple grids on the same page.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Thesauri editor

moving stuff where it goes

conify type interfaces in progress.

not completely deleting old unfinished ones yet; there are probably
things to salvage

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Put thesaurus-z handling back in

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Beginnings of the config interfaces

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Move RULE down so that the named tables actually exist

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Switch authority startwith index back to the pre-checking-deletedness version

Signed-off-by: Mike Rylander <mrylander@gmail.com>

correcting template generation; filter out subfields that we do not use in the authority record

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Minor bug fixes (alignment of fm classes, etc); Do not check deletedness, just remove the afr data upon "delete" of an authority; We still need the non-tpo index on afr.value

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Heading normalization bug; Use CStoreEditor, not Editor; syntax-y bugs

Signed-off-by: Mike Rylander <mrylander@gmail.com>

General bug fixes and formatting cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repaired syntax errors in SuperCat.pm

Signed-off-by: berick <berick@esilibrary.com>

Repaired syntax errors and thinkos

 * Syntax in AuthorityControlSet.js
 * Protect against empty kwargs hash
 * marcedit.js fixes: Load dojo class before use; Load in my_init(), before which dojo is not defined

Signed-off-by: berick <berick@esilibrary.com>

Protect against empty lists of linked bib searches

Instead of returning undef when passed an empty list of bibs, always
return an array from
open-ils.cat.authority.records.count_linked_bibs
Apart from consistency, this prevents JS errors in the Manage
Authorities UI.

Signed-off-by: berick <berick@esilibrary.com>

SQL typo cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use the configured set of authority browse axes in the authority browse interfaces

Use the new singular methods that accept an axis as a param for browse and startwith

Add method for returning valid authority browse axes

Browse axis based browse and startswith methods; minor documentation corrections

Use ACS utility functions instead of hard-wired mapping

Fetch ACS stuff up front; enhance inter-object mapping per IDL; utility functions

Add axis_maps virtual field to control set authority field

Adding tables for browse axis mapping

Use MARC.FixedFields.setFixedField and validate by startwith search against simple_normalized_heading

Function to find authority records matching a MARC field

adjust parameters and documentation note

use the new transformed-value starwith operator

add a special startwith op for use with transformed values (cannot do it another way currently)

Methods for searching by marcxml, constrained (or not) by control set

Add an index using authority.simple_normalize_heading for search

Variant of authority.normalize_heading which ignores thesaurus for comparing slim auth records generated from bibs

functions for converting bibs to authorities based on ACS

Move the AuthorityControlSet module into openils -- it loads data from the server

Utility methods

Bug fixes; Add a method for setting fixed fields; Set the Type FF when rtype=AUT

Move the function to before its first use

Only load control sets once, set the default to the first (for now... YAOUS later)

Add some logic for fetching stored controlsets and switching amongst them