]> git.evergreen-ils.org Git - Evergreen.git/log
Evergreen.git
8 years agoLP#1440114 Direct charge blanket orders
Bill Erickson [Tue, 7 Apr 2015 19:47:10 +0000 (15:47 -0400)]
LP#1440114 Direct charge blanket orders

Support "blanket" (long-lived, multi-invoice) orders via a new "blanket"
boolean on invoice item types.  Blanket charges can be invoiced multiple
times by creating a new fund_debit for each invoice item linked to a
blanket po_item.

This change also adds the amounts paid over time for blanket charges to
the Amount Paid summary information for purchase orders containing the
charges.

Adds a new Invoice Item Type of "Blanket Order".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1440114 Remove inv_item via po_item from invoice
Bill Erickson [Wed, 8 Apr 2015 19:17:01 +0000 (15:17 -0400)]
LP#1440114 Remove inv_item via po_item from invoice

Allow invoice_items which were descended from po_item's (direct charges)
to be removed from invoices.  Prior to this, a JS exception prevented
removal of these items.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1379815: Stamping upgrade scripts for vandelay stat cat import
Ben Shum [Wed, 19 Aug 2015 16:17:17 +0000 (12:17 -0400)]
LP#1379815: Stamping upgrade scripts for vandelay stat cat import

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1379815 Better error handling
Remington Steed [Tue, 7 Jul 2015 20:08:23 +0000 (16:08 -0400)]
LP#1379815 Better error handling

This commit adds more thorough error checking and handling for the stat
cat import feature, including adding two custom import error codes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1379815 Add release notes
Remington Steed [Fri, 20 Feb 2015 15:54:26 +0000 (10:54 -0500)]
LP#1379815 Add release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1379815 Add pgTAP test
Remington Steed [Fri, 20 Feb 2015 14:57:18 +0000 (09:57 -0500)]
LP#1379815 Add pgTAP test

This commit adds a pgTAP test which ensures that imported items are
being successfully added to the 'import_item' table. The test confirms
that the correct number of items have stat cat data in the table. The
test also ensures that the new xpath function works properly, simply by
using it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1379815 Add code to assign stat cats on Vandelay imported items
Remington Steed [Mon, 8 Sep 2014 20:11:37 +0000 (16:11 -0400)]
LP#1379815 Add code to assign stat cats on Vandelay imported items

This commit adds columns to the Holdings Import Profile table
(vandelay.import_item_attr_definition) and to vandelay.import_item, adds
the corresponding fields to the IDL, modifies the database functions
which import the data (ingest_bib_items() and ingest_items()) and adds
code that parses the imported stat cat data (of the form
CAT 1|VALUE 1||CAT 2|VALUE 2) and applies it to the appropriate
overlayed copy.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1379815 Add missing behavior to update_copy_stat_entries
Dan Wells [Wed, 8 Oct 2014 17:35:43 +0000 (13:35 -0400)]
LP#1379815 Add missing behavior to update_copy_stat_entries

The current function doesn't provide the level of control we need, even
with the 'delete_stats' flag set to zero. This commit adds a new
'add_or_update_only' option which preserves existing stat cat entry maps
for any stat cat not represented on the incoming copy object, and
updates values when appropriate.

This commit also updates the function comment for better clarity.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1379815 Fetch tag data as a table using tag/xpath combo
Dan Wells [Mon, 6 Oct 2014 15:52:27 +0000 (11:52 -0400)]
LP#1379815 Fetch tag data as a table using tag/xpath combo

New function: oils_xpath_tag_to_table()

This function is adapted from oils_xpath_table() with the goal of being
more targeted and simpler to use.

The main issue with oils_xpath_table() is that it relies on peer
UNNEST() functions, and that leads to unexpected behavior whenever the
xpath arguments result in uneven or "gapped" selections.  In the first
type of case, the resulting table includes rows representing the least
common multiple of the underlying xpath selections.  In the second
type, though the xpaths may sometimes return the same number of values,
those values are not correlated except by order in the marc, which does
not account for the real possibility of null values in the set.

Crude Example:

999 $d ABC $e 123
999 $d DEF
999 $d GHI
999 $e 456

We need a table representing subfields 'd' and 'e' of the '999' fields,
so we might try an xpath like:

//*[@tag="999"]/*[@code="d"]|//*[@tag="999"]/*[@code="e"]

We want:

 d  |  e
---------
ABC | 123
DEF |
GHI |
    | 456

but we get:

 d  |  e
---------
ABC | 123
DEF | 456
GHI | 123
ABC | 456
DEF | 123
GHI | 456

This example illustrates both negative behaviors (non-correlated fields
and least-common-multiple row multiplication).

The new method, while internally quite similar, has a different
signature, with the most significant change being a 'tag' argument
which serves as a common base element for the xpaths (now an array
rather than a pipe-delimited string).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1406370 Set Search Preferences Ordered by Name
Adam Bowling [Mon, 19 Jan 2015 21:04:04 +0000 (16:04 -0500)]
LP#1406370 Set Search Preferences Ordered by Name

Set search preferences is currently ordered by shortname in
Admin > Workstation Administration > Set Search Preferences.
This patch adds functionality that orders each org unit and
its children in alphabetical order by name, rather than by
shortname.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoLP#1476370 Selfcheck warning template cleanup
Bill Erickson [Wed, 19 Aug 2015 15:18:23 +0000 (11:18 -0400)]
LP#1476370 Selfcheck warning template cleanup

Remove a duplicated chunk of template code which was inadverently added
while working on LP1476370 -- logout warning dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1444514: Have amnesty mode override backdate for voiding
Thomas Berezansky [Wed, 15 Apr 2015 14:48:03 +0000 (10:48 -0400)]
LP#1444514: Have amnesty mode override backdate for voiding

Otherwise you get amnesty notes on just backdate voiding.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1437292: Order Bucket Names Alphabetically
Jason Boyer [Fri, 27 Mar 2015 12:32:41 +0000 (08:32 -0400)]
LP 1437292: Order Bucket Names Alphabetically

Prefer alpha ordering to database ordering for bucket names.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoDocumentation typo fixes
Matt Berowski [Tue, 18 Aug 2015 14:17:26 +0000 (09:17 -0500)]
Documentation typo fixes
 - Corrected effect to affect
 - Removed double the
 - Spelling correction Preceeded to Preceded
 - Corrected Spelling error self serve to self-serve
 - Small typo in staff client receipt template - hold slip 2 docs.

Matt's first commit to evergreen docs!

Signed-off-by: Matt Berowski <berowskim@larl.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
8 years agoLP#1463590 Loosen read access to distribution formulas
Bill Erickson [Tue, 9 Jun 2015 21:59:42 +0000 (17:59 -0400)]
LP#1463590 Loosen read access to distribution formulas

Make it possible for ACQ staff that have the CREATE_PURCHASE_ORDER
permission to view distribution formulas (via PCRUD) , making it
possible to use them from the PO batch update operation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1438252 SIP honor floating copy checkin location
Bill Erickson [Mon, 30 Mar 2015 15:19:55 +0000 (11:19 -0400)]
LP#1438252 SIP honor floating copy checkin location

Report the new value for a copy's circ_lib when it's a floating copy
whose circ_lib is modified during checkin.

This affects the AQ field of the SIP checkin (10) message.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP1431541: SRU UTF8 encoding issues
Dan Scott [Thu, 12 Mar 2015 20:06:16 +0000 (16:06 -0400)]
LP1431541: SRU UTF8 encoding issues

The SuperCat SRU service was encoding MARCXML using an encode_utf8()
call that ended up corrupting non-ASCII characters. In addition, the
HTTP header charset was not being set, meaning that the return header
would default to ISO-8859-1.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1419172: Stamping upgrade script for optimizing full circ count
Ben Shum [Wed, 19 Aug 2015 03:06:39 +0000 (23:06 -0400)]
LP#1419172: Stamping upgrade script for optimizing full circ count

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1419172 Optimize full_circ_count view to avoid seq scans
Dan Wells [Thu, 7 May 2015 20:43:16 +0000 (16:43 -0400)]
LP#1419172 Optimize full_circ_count view to avoid seq scans

As reported by Chris Sharp:

"The reporter.classic_item_list view was modified in bug 1208572 to use
extend_reporter.full_circ_count to provide the use count for each item.
Unfortunately, this change was found to be the cause of consistently
long-running (2+ hours) reports queries in PINES as its query plan on
our PostgreSQL 9.3 server was resulting in sequential scans of both the
circulation and aged_circulation tables."

This commit restructures the view to avoid JOINs, and is in production
at PINES with noted improvement.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1481036 Ignore future backdates live test
Bill Erickson [Wed, 5 Aug 2015 21:41:51 +0000 (17:41 -0400)]
LP#1481036 Ignore future backdates live test

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1481036 Ignore future backdates (part 2).
Bill Erickson [Mon, 3 Aug 2015 18:03:52 +0000 (14:03 -0400)]
LP#1481036 Ignore future backdates (part 2).

Ensure that future backdates are successully ignored in the checkin API.
The logic was in place to do this, but it failed to clear the values,
resulting in using the future backdate anyway.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1204671: Stamping upgrade script for fund tag propagation
Ben Shum [Wed, 19 Aug 2015 02:30:13 +0000 (22:30 -0400)]
LP#1204671: Stamping upgrade script for fund tag propagation

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1204671 Allow fund tags to remain attached to new fund during end-of-year propagation
Dan Pearl [Fri, 9 Jan 2015 19:23:58 +0000 (14:23 -0500)]
LP#1204671  Allow fund tags to remain attached to new fund during end-of-year propagation
or rollower.

Signed-off-by: Dan Pearl dpearl@cwmars.org
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1450561: Stamping upgrade script for library settings editor history limits
Ben Shum [Wed, 19 Aug 2015 02:22:42 +0000 (22:22 -0400)]
LP#1450561: Stamping upgrade script for library settings editor history limits

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1450561: Restore org. unit settings history limit function and trigger
Jason Stephenson [Fri, 1 May 2015 19:33:05 +0000 (15:33 -0400)]
LP 1450561: Restore org. unit settings history limit function and trigger

The evergreen.limit_oustl function and the limit_log_oustl trigger on
config.org_unit_setting_type_log were missed in the upgrade scripts
when these were added to the base schema.  This commit adds them and a
pgtap test to check that they exist after.

This commit also alters the body of the limit_oustl function to take into
account of the org unit when deleting entries from the log table.  This
change allows multiple consortium members to have their own five history
entries.  The original code only kept the last five entries of any given
setting across the whole installation.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1112723: stamping upgrade script for unapi copy visibility
Ben Shum [Wed, 19 Aug 2015 02:14:26 +0000 (22:14 -0400)]
LP#1112723: stamping upgrade script for unapi copy visibility

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1112723 Consider copy-level opac_visible flag when ranking
Dan Wells [Thu, 7 Mar 2013 13:30:02 +0000 (08:30 -0500)]
LP#1112723 Consider copy-level opac_visible flag when ranking

The current unAPI calls consider opac_visibility of the status,
but not the copy itself. If you have a record with copies set to
opac_visible = false, you might see few or no copies in the OPAC
results list, as these invisible copies may be the first five
returned, and they then crowd out the visible copies.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1478997 Items out display sort overdues to top (webstaff)
Bill Erickson [Tue, 28 Jul 2015 14:44:38 +0000 (10:44 -0400)]
LP#1478997 Items out display sort overdues to top (webstaff)

Sort overdue items to the top of the patron items out display in the
webstaff client, consistent with pre-2.5 behavior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1478997 Items out display sort overdues to top
Bill Erickson [Tue, 28 Jul 2015 14:39:57 +0000 (10:39 -0400)]
LP#1478997 Items out display sort overdues to top

Sort overdue items to the top of the patron items out display in the XUL
client, consistent with pre-2.5 behavior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agolp1481844 Change Available Copies Display
Kathy Lussier [Wed, 5 Aug 2015 16:50:53 +0000 (12:50 -0400)]
lp1481844 Change Available Copies Display

The Show link in the available copies area of the record summary will now
display for any org unit that owns a copy of the title, even if those copies
are unavailable. This commit also changes the language in the display to read
"x of y copies available at z library."

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agolp1486252 Change label for acq admin menu
Kathy Lussier [Tue, 18 Aug 2015 17:55:26 +0000 (13:55 -0400)]
lp1486252 Change label for acq admin menu

Now that the acq admin menus have move outside of the Server Admin menu, it
should be called "Acquisitions Administration" to be consistent with other
options in this area.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1482400: add release notes
Galen Charlton [Tue, 18 Aug 2015 01:25:00 +0000 (01:25 +0000)]
LP#1482400: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#1482400: UT for OpenILS::Application::Acq::BatchManager changes
Galen Charlton [Tue, 18 Aug 2015 01:18:28 +0000 (01:18 +0000)]
LP#1482400: UT for OpenILS::Application::Acq::BatchManager changes

This patch adds tests for the changes to how ::BatchManager()
calculates the request response freqency throttle.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#1482400: when activating a PO, provide better progress updates
Galen Charlton [Thu, 6 Aug 2015 22:15:54 +0000 (22:15 +0000)]
LP#1482400: when activating a PO, provide better progress updates

This patch improves how progress is reported during the activation
of a purchase order that has a large number of assets (bibs and
copies) to create.  Specifically, it:

[1] Shows a progress bar during the asset creation phase.
[2] Calculates a linear throttle for updating the record counts
    widget. The value is based on the maximum number of bibs and
    items that could be created during the activation, divided by 20
    (which is an empirically derived number of streaming responses
    that can be sent back before the XUL client starts having
    difficulty).
[3] During the asset-creation phase, the number of records created is
    displayed above the progress bar.
[4] Adds a title to the progress bar that's displayed during the
    second phase of order activation.

To test, after applying the patch:

[1] Create a purchase order that has a large number of
    brief bibs and copies to create during activation.  For
    example, 30 line items and 60 copies.
[2] Activate the purchase order.  You should see the following
    after entering the record import queue and submitting:

    (a) Progress dialog whose title is "Creating bib, call number,
        and copy records.."
    (b) The progress dialog displays and updates text above the
        progress bar indicating how many records it has processed,
        e.g., "Bib Records Merged/Import: 25"
    (b) The record update counts should be updated at a regular
        frequency.
    (c) When the asset creation phase is done, the progress bar's
        title should change to "Activating purchase order..."

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#1468404: Fix typo and ommissions in action_trigger_aggregator.pl help
Josh Stompro [Sun, 9 Aug 2015 18:12:53 +0000 (13:12 -0500)]
LP#1468404: Fix typo and ommissions in action_trigger_aggregator.pl help

 - ISO was mistyped as IDO in the help text.
 - Several arguments were missing from the help text.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1463097 - eg_db_config.in help text fix
Josh Stompro [Sat, 13 Jun 2015 11:38:10 +0000 (06:38 -0500)]
LP#1463097 - eg_db_config.in help text fix

Two of the descriptions of which config files are used were transposed.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1478123: fix leak of file descriptors by Apache workers
Josh Stompro [Fri, 24 Jul 2015 19:20:21 +0000 (14:20 -0500)]
LP#1478123: fix leak of file descriptors by Apache workers

Apache backends handling TPAC requests and making requests
of the added content handler were not properly closing
their sockets. This patch adds a close() after the shutdown()
to plug the leak.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#483502 PGTAP test for evergreen.xml_escape(TEXT)
Bill Erickson [Fri, 14 Aug 2015 16:02:54 +0000 (12:02 -0400)]
LP#483502 PGTAP test for evergreen.xml_escape(TEXT)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP1483509: tests for xml_famous5_to_text
Liam Whalen [Fri, 14 Aug 2015 20:25:11 +0000 (13:25 -0700)]
LP1483509: tests for xml_famous5_to_text

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1361900: Add release note for Acq Admin Menu move
Ben Shum [Mon, 17 Aug 2015 17:58:47 +0000 (13:58 -0400)]
LP#1361900: Add release note for Acq Admin Menu move

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1361900 Move Acquistions Admin Menu
Michael Peters [Wed, 10 Jun 2015 16:57:00 +0000 (12:57 -0400)]
LP#1361900 Move Acquistions Admin Menu

This patch fills a wishlist request to have the Acquisitions
Admin functions moved out of "Server Options" and into their own
adminitrative menu.

They can now be accessed via Admin > Acquisitions > Currency Type, etc.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Jennifer Pringle <jpringle@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1485240: More Legacy Circ Script Removal
Jason Stephenson [Sat, 15 Aug 2015 18:42:39 +0000 (14:42 -0400)]
LP 1485240: More Legacy Circ Script Removal

This commit removes the last few references to the script_runner
used by OpenILS::Application::Circ::Circulate::Circulator to run
JavaScript circ policies.  The script_runner is basically doing
nothing at this point.

To test this commit, apply it to a test system, install Evergreen,
start or restart the open-ils.circ service and check that check
outs and renewals still work.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1178377: Stamping upgrade script for unapi to include bib source
Ben Shum [Mon, 17 Aug 2015 16:59:21 +0000 (12:59 -0400)]
LP#1178377: Stamping upgrade script for unapi to include bib source

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1178377: Add release note for new bib source variable in catalog
Ben Shum [Mon, 17 Aug 2015 16:53:30 +0000 (12:53 -0400)]
LP#1178377: Add release note for new bib source variable in catalog

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1178377: Make bib source optional element from unapi.bre
Doug Kyle [Mon, 14 Apr 2014 16:31:11 +0000 (12:31 -0400)]
LP#1178377: Make bib source optional element from unapi.bre

also add cbs (config bib source) to flesh arg of get_records_and_facets

Change the baseline schema file

Signed-off-by: Doug Kyle <dkyle@grpl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1178377: Expose bib source in TPAC
Jeff Davis [Thu, 9 May 2013 19:03:58 +0000 (12:03 -0700)]
LP#1178377: Expose bib source in TPAC

- Add unapi.cbs database function to grab config.bib_source data, and
  include this in unapi.bre XML output.
- Make bib_source.id and bib_source.source available as record
  attributes in TPAC.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1433328: Add release note for new class attribute for e-resource links
Ben Shum [Mon, 17 Aug 2015 16:45:57 +0000 (12:45 -0400)]
LP#1433328: Add release note for new class attribute for e-resource links

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1433328: Add class attribute to e-resource links in TPAC
Jeff Davis [Tue, 17 Mar 2015 21:53:05 +0000 (14:53 -0700)]
LP#1433328: Add class attribute to e-resource links in TPAC

In the TPAC, links to electronic resources are not directly, uniquely
identifiable in the DOM. You can specify these links indirectly, with
something like '.result_table_title_cell > td > a' in search results
or '.rdetail_uri > a' on the record details page, but this is fragile
and a bit cumbersome. Adding a unique class attribute directly to the
link elements would make things easier for services built on top of
the TPAC, such as Overdrive API integration or JS-based analytics for
e-resources.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1435938: Add release note for clear Added Content cache link
Ben Shum [Mon, 17 Aug 2015 16:38:39 +0000 (12:38 -0400)]
LP#1435938: Add release note for clear Added Content cache link

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1435938: Set no_cache on AC clear response
Thomas Berezansky [Wed, 10 Jun 2015 16:41:45 +0000 (12:41 -0400)]
LP#1435938: Set no_cache on AC clear response

So that the clearing itself isn't cached.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1435938: Wrap auth check around clearcache URLs
Thomas Berezansky [Tue, 24 Mar 2015 15:13:36 +0000 (11:13 -0400)]
LP#1435938: Wrap auth check around clearcache URLs

Only allow staff to clear the cache values.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1435938: Add link to clear cache from staff client
Thomas Berezansky [Tue, 24 Mar 2015 14:37:41 +0000 (10:37 -0400)]
LP#1435938: Add link to clear cache from staff client

New functionality isn't all that useful without an access point, after all.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1435938: AddedContent: Add "clearcache" functionality
Thomas Berezansky [Tue, 24 Mar 2015 14:28:32 +0000 (10:28 -0400)]
LP#1435938: AddedContent: Add "clearcache" functionality

Intended use: When staff edit a record's identifiers they can manually clear
the AddedContent cashe.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1484655: ftp://ftp.mozilla.org moved to http://archive.mozilla.org
Jason Stephenson [Thu, 13 Aug 2015 19:22:33 +0000 (15:22 -0400)]
LP 1484655: ftp://ftp.mozilla.org moved to http://archive.mozilla.org

This commit changes the XULRUNNER_URL in Open-ILS/xul/staff_client/
Makefile.am from using ftp to talk to ftp.mozilla.org to using http
with archive.mozilla.org.  This is necessary because Mozilla.org
have apparently declared the former to be closed and the latter to
be the canonical location for downloads.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoDocumentation: Items out enhancements
Angela Kilsdonk [Tue, 11 Aug 2015 19:53:22 +0000 (15:53 -0400)]
Documentation: Items out enhancements

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoLP#1394989: Do not include deleted users when retrieving for Collections
Bill Ott [Tue, 28 Jul 2015 20:05:31 +0000 (16:05 -0400)]
LP#1394989: Do not include deleted users when retrieving for Collections

As a side effect of discovering that users with no cards were being retrieved
as part of the Collections API calls, those users ended up being mostly
made up of deleted users (merged with an actual lead record, etc.)

This patch contribued by Bill Ott changes the retrieval so that it skips
over those deleted users.

Signed-off-by: Bill Ott <bott@grpl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1394989: Make users_of_interest test for defined actor.usr.card values
Michael Peters [Thu, 20 Nov 2014 22:41:44 +0000 (17:41 -0500)]
LP#1394989: Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to provide "undef" in the event that there is
not a proper barcode associated with the user when retrieving results for the
API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoDocumentation: Add 2.8 docs for void on claims returned
Kathy Lussier [Fri, 7 Aug 2015 15:00:46 +0000 (11:00 -0400)]
Documentation: Add 2.8 docs for void on claims returned

Adding docs for void on claims returned feature. Also, adding a reference
to new "no billing activity on zero balance transaction" in one area of
circulation that was missed. Branch includes some other updates to old
information.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoForward-port 2.8 translation import
Bill Erickson [Fri, 27 Feb 2015 16:44:54 +0000 (11:44 -0500)]
Forward-port 2.8 translation import

Unfortunately, we had forgotten that translation changes for .pot files
need to be pushed to master for translators.

For the purpose of getting the ball started again, forward porting these
changes for 2.8 from rel_2_8 to master.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1479953: Stamping Upgrade Script
Jason Stephenson [Thu, 6 Aug 2015 15:42:39 +0000 (11:42 -0400)]
LP#1479953: Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoLP#1479953: Rename indexes to *_idx and add pgTAP test.
Jason Stephenson [Thu, 6 Aug 2015 15:13:00 +0000 (11:13 -0400)]
LP#1479953: Rename indexes to *_idx and add pgTAP test.

To make the new index names more consistent with existing indices,
I took the liberty of adding _idx to the new index names.

We also add a pgTAP test to verify that the new indices exist in
the database.  The test would fail before running the upgrade
script and succeed after.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoLP#1479953: Add indexes to vqbr foreign key references
Jeff Davis [Thu, 30 Jul 2015 20:12:35 +0000 (13:12 -0700)]
LP#1479953: Add indexes to vqbr foreign key references

Deleting a bib queue can be quite slow if it contains many queued
records.  This is because each queued record needs to be deleted, and
this in turn affects many tables that contain unindexed foreign key
references to vandelay.queued_bib_record.  Indexing those foreign keys
can speed up bib queue deletion substantially.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoLP 1198465: Load negative balance test transactions in load_all.sql
Dan Wells [Wed, 29 Jul 2015 15:30:51 +0000 (11:30 -0400)]
LP 1198465: Load negative balance test transactions in load_all.sql

This commit integrates the SQL needed to setup negative balance
testing into the load_all.sql which loads the rest of the test data.

It also separates out the "reset" commands into a separate SQL file.
They are useful when doing repeated testing, but unnecessary and
may eventually require manual tweaking, so they are provided here as a
convenience only.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
8 years agoLP 1198465: Move negative balance test xacts into sample data
Dan Wells [Wed, 29 Jul 2015 15:04:24 +0000 (11:04 -0400)]
LP 1198465: Move negative balance test xacts into sample data

It makes more sense for this to live with the other sample data, so
let's put it there.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
8 years agoLP 1198465: Add missing util function for tests
Dan Wells [Wed, 29 Jul 2015 14:48:28 +0000 (10:48 -0400)]
LP 1198465: Add missing util function for tests

do_checkin_override() is needed for the new tests, but was missing
from the branch.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
8 years agoLP#1347807: Release note for "No Image" configuration examples
Ben Shum [Tue, 28 Jul 2015 21:04:03 +0000 (17:04 -0400)]
LP#1347807: Release note for "No Image" configuration examples

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1347807: Add example "No Image" configuration
Thomas Berezansky [Wed, 23 Jul 2014 13:46:32 +0000 (09:46 -0400)]
LP#1347807: Add example "No Image" configuration

To make it easy to see how to do that kind of thing.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1465385: Fix some syntax issues with make_release
Mike Rylander [Mon, 15 Jun 2015 19:32:20 +0000 (15:32 -0400)]
LP#1465385: Fix some syntax issues with make_release

Some versions of bash become confused when a unary = operator
is used in place of a binary == operator.  Also, some variables
live without the protection of quoting, and thus further confuse
the shell when their contents are not as simple as originally
expected.

Here we adress those issues.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1454879: Release notes for Account Expiration Date in OPAC
Ben Shum [Tue, 28 Jul 2015 20:49:23 +0000 (16:49 -0400)]
LP#1454879: Release notes for Account Expiration Date in OPAC

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP1454879: Add Account Expiration Date to OPAC
Terran McCanna [Fri, 15 May 2015 17:18:15 +0000 (10:18 -0700)]
LP1454879: Add Account Expiration Date to OPAC

Added Account Expiration Date to OPAC My Account display on
Account Summary page and Account Preferences page. This is in
response to patron requests to know when their accounts will
expire before the point at which they actually expire.

To test, log into My Account through the OPAC - a new table row
with account expiration date should appear on the main account
summary page, and another new row should appear on the main
account preferences page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1476370 Selfcheck inactivity warning release notes
Bill Erickson [Tue, 21 Jul 2015 14:00:41 +0000 (10:00 -0400)]
LP#1476370 Selfcheck inactivity warning release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP1476370 Selfcheck logout warning, checkout resets
Bill Erickson [Mon, 20 Jul 2015 20:26:30 +0000 (16:26 -0400)]
LP1476370 Selfcheck logout warning, checkout resets

* Show a logout warning dialog 20 seconds before discontinuing a
self-check patron login session.

* Reset the inactivity timer with each checkout.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1466201: Release note for disabling Google Analytics in staff interface
Ben Shum [Tue, 28 Jul 2015 20:40:55 +0000 (16:40 -0400)]
LP#1466201: Release note for disabling Google Analytics in staff interface

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agolp1466201 Disable Google Analytics in the staff client
Kathy Lussier [Fri, 10 Jul 2015 03:23:08 +0000 (23:23 -0400)]
lp1466201 Disable Google Analytics in the staff client

As Galen Charlton noted in bug 1452883, "I suggest disabling Google Analytics
outright in the staff client; there's far too much potential for leaking patron
information." This branch aims to do so.

Test plan: Enable Google Analytics in config.tt2. Access the catalog in the
staff client. Click Debug to view the source code. Pre-patch, you'll see
the Google Analytics javascript within the head element. Post-patch, that
javascript will be gone. Viewing the source of a catalog page in a browser
should continue to show the Google Analytics javascript within the head element.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1198465: Stamping upgrade script for conditional negative balance
Ben Shum [Tue, 28 Jul 2015 20:28:45 +0000 (16:28 -0400)]
LP#1198465: Stamping upgrade script for conditional negative balance

Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Adapt some language in the negative balance branch
Kathy Lussier [Fri, 24 Jul 2015 00:53:33 +0000 (20:53 -0400)]
LP 1198465: Adapt some language in the negative balance branch

End users may see the term 'adjustment payment' and think that an actual
payment was made. Let's use 'account adjustment' instead. Also, remove any
references to credits in the description for the OU settings since it could
be confused with patron credits, which aren't prohibited by the code.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: More tests for conditional negative balances
Remington Steed [Tue, 21 Jul 2015 17:21:15 +0000 (13:21 -0400)]
LP 1198465: More tests for conditional negative balances

This commit adds the remaining test cases documented by Kathy Lussier on
this wiki page:

    http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

Test cases included in this commit are:

    6. Restores Overdue Fines Appropriately, No Previous "Voids", Patron
       Will Not Owe On Lost Item Return
    7. Restores Overdue Fines Appropriately, No Previous "Voids", Patron
       Will Still Owe On Lost Item Return
    9. Restore Overdue Fines Appropriately, Previous Voids, Negative
       Balance Allowed
   13. Prohibit negative balances on lost materials bills ONLY
   14. Prohibit negative balances on overdue bills ONLY

Note that test case 5 is omitted because it is a duplicate of case 2,
and case 11 is included but commented out because it is unclear how best
to handle the situation.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Make conditional negative balances test sql re-runnable
Dan Wells [Fri, 17 Jul 2015 20:45:16 +0000 (16:45 -0400)]
LP 1198465: Make conditional negative balances test sql re-runnable

Add some DELETEs and some more explicit setting of a few DB pieces such
that running the test SQL a second time will get everything back to
state where the tests will again proceed as expected (hopefully
successfully!).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Initial tests for conditional negative balances
Remington Steed [Fri, 17 Jul 2015 19:42:37 +0000 (15:42 -0400)]
LP 1198465: Initial tests for conditional negative balances

This is a first commit of work-in-progress for testing the conditional
negative balances features.  It covers 9 of the 14 test cases listed
here (as of today):

http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

TODO:
- The test is currently an SQL setup file plus a Perl live test file.
  One simple improvement would be to switch the setup process to
  cstore calls within the Perl test file.  This would be both more
  contained and more robust.
- A second step to more advanced and useful tests would be to use
  higher-level API calls to create portions of the setup rather than
  doing everthing manually.  However, some test conditions cannot be
  reasonably setup with the normal API calls (e.g. bills of a specific
  age, or bills using a legacy format no longer generated by current
  code), so certain areas will likely always require direct
  manipulation.

Signed-off-by: Daniel Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Clean up terminology
Dan Wells [Thu, 28 May 2015 18:10:50 +0000 (14:10 -0400)]
LP 1198465: Clean up terminology

Replace the "void payment" language with "adjustment" in variable names
and comments.  This commit should not make any functional difference.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Set restored overdue timestamp to time of last overdue
Dan Wells [Thu, 28 May 2015 17:54:26 +0000 (13:54 -0400)]
LP 1198465: Set restored overdue timestamp to time of last overdue

When we have our settings configured to generate new overdues on lost
item return, we start generation after the most recent overdue fine.
Because of this, we need the restored fine to be dated in the past,
which in turn allows the fine generator to apply catch-up fines as
expected.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Account for overdues voided the old way
Remington Steed [Wed, 18 Jun 2014 13:34:13 +0000 (09:34 -0400)]
LP 1198465: Account for overdues voided the old way

The code for the particular case of "void"-overdues-for-lost is incomplete.
This is the one case in the new code where it now always adjusts rather
than voids, but the new restore code still needs to recognize cases where
the voiding happened under the old code.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Delay creation of bill map for special bill handling
Dan Wells [Tue, 1 Apr 2014 19:13:00 +0000 (15:13 -0400)]
LP 1198465: Delay creation of bill map for special bill handling

We were making the map, then deciding whether we wanted to void or
adjust.  Since we only want the map if we adjust (and it creates havoc
when voiding), let's just get the bill IDs, then let the adjustment
code create the map it needs.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Fix and improve void/adjustment code
Dan Wells [Wed, 26 Feb 2014 22:44:45 +0000 (17:44 -0500)]
LP 1198465: Fix and improve void/adjustment code

This commit does three things:

- Replace ou_ancestor_setting() with ou_ancestor_setting_value() calls
  This also fixed a bug where we were expecting just the setting, not
  a HASH

- Reword interval checking
  This fix is two part.  First, we simplify the check to not require
  the whole payment map.  Second, we use this newfound simplicity to
  push this check up into the gatekeeper functions, further clarifying
  the code paths.

- make $note into $for_note for void_or_zero_bills_of_type()
  Because the function can both void and adjust, we can't supply a
  complete note, so let's just supply text of what the void/adjustment
  is for.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Refactor logic into gatekeeper functions
Dan Wells [Wed, 26 Feb 2014 16:12:21 +0000 (11:12 -0500)]
LP 1198465: Refactor logic into gatekeeper functions

The bulk of this commits take the logic from adjust_bills_to_zero() and
moves it up a layer into the "gatekeeper" void_or_zero* functions.
This move also allows us to simplify the logic, since some facts are
already known based on our function path.

Also:
- give void_or_zero_overdues() a new signature to better support
  multiple options
- add new 'force_void' and 'force_zero' options to this function
- rename real_void_bills() to simply void_bills() (since there is no
  other void_bills(), the "real" was redundant)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Rename internal functions for clarity
Dan Wells [Fri, 20 Feb 2015 22:19:42 +0000 (17:19 -0500)]
LP 1198465: Rename internal functions for clarity

These methods will now be the splitting point for void vs. adjustment,
so let's give them broader names.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Restore voiding code, rename adjustment function
Dan Wells [Tue, 25 Feb 2014 22:37:43 +0000 (17:37 -0500)]
LP 1198465: Restore voiding code, rename adjustment function

This commit restores the code we removed a few commits earlier, and
also renames "real_void_bills()" "adjust_bills_to_zero()" in order to
better delineate the split functionality.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Fix typo in BILL_ALREADY_VOIDED event
Jason Stephenson [Tue, 25 Feb 2014 19:47:47 +0000 (14:47 -0500)]
LP 1198465: Fix typo in BILL_ALREADY_VOIDED event

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Update CDBI/money.pm for adjustment_payment
Jason Stephenson [Wed, 8 Jan 2014 01:44:47 +0000 (20:44 -0500)]
LP 1198465: Update CDBI/money.pm for adjustment_payment

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od
Jason Stephenson [Sun, 6 Oct 2013 21:13:01 +0000 (17:13 -0400)]
LP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()
Jason Stephenson [Sun, 6 Oct 2013 15:09:10 +0000 (11:09 -0400)]
LP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()

Simplify it to use the new, CircCommon->void_bills_of_type() method.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP 1198465: Add code for adjustment payments
Jason Stephenson [Fri, 20 Feb 2015 22:17:46 +0000 (17:17 -0500)]
LP 1198465: Add code for adjustment payments

This new payment type complements the current void logic that flags
bills as voided.

This new payment type is needed because the current way that Evergreen
voids bills requires that all voids happen in the same increment as the
bills themselves.  This prevents voiding of a partial bill or a bill
that has had a partial payment applied.

This commit also adds the org. unit setting types for the conditional
negative balances enhancements:

bill.prohibit_negative_balance_default
bill.prohibit_negative_balance_on_overdues
bill.prohibit_negative_balance_on_lost
bill.negative_balance_interval_default
bill.negative_balance_interval_on_overdues
bill.negative_balance_interval_on_lost

Finally, create a helper function for checking intervals along the way,
and a handy little subroutine to void all bills of a given type on a
circulation transaction.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1478299: fix location for asset used in test
Jason Etheridge [Mon, 27 Jul 2015 20:04:17 +0000 (16:04 -0400)]
LP#1478299: fix location for asset used in test

specifically lp1277731_hold_permit_test.pg

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Tue, 2 Apr 2013 21:22:37 +0000 (17:22 -0400)]
LP#1155771 Copy location sample data additions

* added some new locations and better groups (thanks gdunbar)
* applying locations to copies in a slightly more sane fashion
* added todo comment about possible future improvement

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Mon, 18 Mar 2013 15:01:36 +0000 (11:01 -0400)]
LP#1155771 Copy location sample data additions

* Add/remove some locations
* Add some locations whose flags (circulate, etc.) vary along the org
  pathway.  Thanks to Thomas Berezansky for this suggestion.
* Ensure that copy location owner matches copy circ lib when applying
  locations to copies.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1155771 Sample data : copy locations, location groups
Bill Erickson [Fri, 15 Mar 2013 18:32:18 +0000 (14:32 -0400)]
LP#1155771 Sample data : copy locations, location groups

Adds a pile of sample copy location and location groups to the sample
data in Open-ILS/tests/datasets/sql.  Samples are loaded as part of
"load_all.sql"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat...
Jeff Davis [Mon, 1 Jun 2015 23:16:25 +0000 (16:16 -0700)]
LP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
8 years ago2.8 doc image name change
Angela Kilsdonk [Mon, 6 Jul 2015 19:51:15 +0000 (14:51 -0500)]
2.8 doc image name change

Image name change to fix display

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoLP#1312308 circ scripts, penalty removal release notes
Bill Erickson [Fri, 22 May 2015 20:25:18 +0000 (16:25 -0400)]
LP#1312308 circ scripts, penalty removal release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoLP#1312308 remove deprecated open-ils.penalty service
Bill Erickson [Fri, 22 May 2015 20:07:29 +0000 (16:07 -0400)]
LP#1312308 remove deprecated open-ils.penalty service

open-ils.penalty service has not been used by Evergreen since before
version 2.0.  Instead of just cleaning out the script configuration,
clean out the entire application.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>