Galen Charlton [Wed, 11 May 2016 17:17:55 +0000 (13:17 -0400)]
webstaff: add server administration page
This patch adds a landing page for Server Administration and
code to embed all of the admin pages available under Serer
Administration in the XUL staff client.
TODO:
* fix the permission groups editor so that it works
when embedded in the web staff client
* refactor admin/local/app.js and admin/server/app.js to
unify some of the copy and pasting
* replace the embedded legacy OU editor with a new
angular one
* fixes some CSS issues that make text hard to read in
a few places
Galen Charlton [Wed, 4 May 2016 19:04:23 +0000 (15:04 -0400)]
webstaff: work log: various improvements
* Don't use $location.path() to generate a URL for when opening
a new window, as that can cause the parent window to reset
itself.
* Fix the refresh button
* Add support for paging through worklog entries
* Don't prematurely resolve the promise that is
feeding rows to the grid
* Ensure that entries are displayed in timestamp order
Jim Keenan [Fri, 12 Aug 2016 18:51:28 +0000 (14:51 -0400)]
lp1592934 removed lines referencing edition fields 534 and 775. These fields refer to other, different editions of the work and not to the work actually being returned.
Signed-off-by: Jim Keenan <jkeenan@cwmars.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Thu, 11 Aug 2016 12:20:34 +0000 (08:20 -0400)]
LP#1612054: unbreak test case now that SSN is no longer an ID type
The patch for bug 1566016 broke the live_t/17-lp1579225_new_patron_passwords.t
test, as it used a patron ID type that is no longer in the seed
data. This patch fixes the test.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Dan Wells [Tue, 9 Aug 2016 19:50:50 +0000 (15:50 -0400)]
LP#1611495 Don't use .xml for MARC21 files in Vandelay Export
The new 'Export Non-imported Records' feature in Vandelay (see bug
LP#1548147) was tweaked before merge to export MARC21 files by default
(rather than MARC-XML). However, the file save dialog still defaults to
(and filters by) ".xml" for the file extension. This is confusing and
otherwise problematic.
Let's go ahead and save the export using a ".mrc" extension instead.
While not an official extension (as far as I know), it is widely used,
easy to understand, and far less likely to cause issues with other
software.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
The previous patch had a side-effect of changing the 852$d
value from the circ library's shortname to its long name. This
patch restores the previous behavior.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Wed, 26 Aug 2015 17:59:37 +0000 (17:59 +0000)]
LP#1037553: bibliographic record source now copied to 901$s
If a bibliographic record has a source set, the name of that source
is now copied to the 901$s whenever the record is created or updated.
This allows the source to be used for record matching and MARC
field queries.
To test:
[1] Create or import a bibliographic record and ensure that its
source is set to a non-null value.
[2] Inspect the record in MARC format view and verify that its
901 field now has a subfield $s containing the name of the
source.
[3] Use pg_prove to run the pgTAP test added by this patch
and verify that the test passes.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP 1503867: Use ws_ou in open-ils.circ.copy_transit.receive.
After putting NCIPServer into production, we discovered that a staff
user cannot receive a transit destined for their work org. unit if
the actor.usr.home_ou is not the same as their current work_ou.
This occurred because transit_receive in OpenILS::Application::
Circ::Transit uses the requestor's home_ou and not the ws_ou.
If you want to trigger this bug, write a little script to receive
transits, then login with a staff account at a location other than
their home_ou and try to receive a transit destined for the work_ou.
It will fail.
This small commit replaces home_ou in two places with ws_ou in order
to make the above work.
NOTE: This bug affects an API call not used in Evergreen except in
one test script. It used in two ILL add-ons for Evergreen: issa and
NCIPServer. Receiving transits by checking copies in via the staff
client, the typical workflow, is not affected by this bug or its fix.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
KPAC config files must be cached per config path in order to support
cases where more than one KPAC interface has been configured in different
vhosts or locations.
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1575177 Add text informing users they cannot add survey questions
Survey questions cannot be added or modified once a survey has started, so
let's add some warning text in the interface letting them know why they can't
perform these actions.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
For Content Cafe, jam two B&T entrys into the hash so that Business::ISBN
doesn't register them as invalid prefix ISBNs.
B&T uses internal ISBN's with country codes 630 and 631 for materials
ordered through them when no assigned ISBN exists. The ContentCafe
added content service knows about these ISBNs, but they are not generally
used by other providers.
To Test: This only works if you are using the ContentCafe added content provider.
- Before Patch -
1. Add the isbn 9786315820243 as the only isbn on a record. Remove UPCs also..
2. Clear the added content cache by restarting memcached or using the staff link.
3. View record in catalog and you should see no cover art.
- After Patch -
1. Clear the added content cache.
2. View the record in the catalog and you should now see cover art for the title
"Video games: the movie"
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1604515: Remove Advanced Hold Options link when part holds are expected
This branch removes the Advanced Hold Options link from the Place Hold
screen in cases where all copies on the bib record contain parts. If a user
attempts to place a metarecord hold and all other copies in the group also
contain parts, the hold will fail. By removing the link, we are removing one
potential point of failure for the user.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP1534283 SIP prevents renewal when user has any blocking standing penalties
This code dives into each penalty to investigate weather or not the patron
can renew based on the block list column. Before, SIP would block renewals with
the presence of penalty 1 or 2 regardless.
Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Thu, 17 Mar 2016 21:47:52 +0000 (17:47 -0400)]
LP 1501781: Make patron name search diacritic/space insensitive.
Add pgtap tests for the new org unit setting, the new indexes, and to
test the evergreen.unaccent_and_squash() functionality. Many of the
latter tests are based on the tests for evergreen.lowercase().
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Thu, 17 Mar 2016 12:01:54 +0000 (08:01 -0400)]
LP 1501781: Make patron name search diacritic/space insensitive.
This commit adds the necessary code to storage actor publisher to use
the new evergreen.unaccent_and_squash db function when doing a patron
name search.
It is based on code originally by Dan Pearl, but then modified to
remove a dependency on a new Perl module by calling the db function on
the search input as well.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Pearl [Thu, 1 Oct 2015 13:49:17 +0000 (09:49 -0400)]
LP#1501781 - Make patron name search diacritic/space insensitive.
Diacritical marks may exist in the patron record, as they should, but
this makes patron name search difficult for librarians who may be
unfamiliar with all the special characters used and also how to elicit
them from a keyboard. To ease this, accented characters will be
converted into their 'plain' analogs for comparison purposes.
So, for example, if the patron's last name is Chávez, typing "Chavez"
in the Last Name box in Patron Search will match it.
Spaces in a name (like "De la Croix") will be squashed out so that
name would be matched by "Delacroix" or "De la Croix" or variants.
The librarian can enter the accented characters or not.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Boyer [Fri, 13 May 2016 16:51:07 +0000 (12:51 -0400)]
LP1183964: Payment Limit Options
Add support for 2 new OU settings, a payment warning
amount (try to pay more than this and you're required
to confirm it) and a hard limit where no payment larger
will be accepted. Support is also added to both the XUL
client and webstaff client.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Rearranging the order of the various sources of hold
failure messages makes it less likely to see spurious
"Item is too new to transit this far" messages. Now
errors due to excessive fines or number of existing
holds.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/templates/opac/parts/place_hold_result.tt2
LP#1588543: tests for verifying correct generated of record attributes
This patch adds tests to verify that the expected
set of record attributes are generated when a bib record
is ingested. The tests serve a couple purposes:
- verifying that changes to the record attribute ingest
stored procedure don't have unexpected side-effects
- validating record attribute definitions in the seed data
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1588543: further speed up record attribute ingest
Following a suggestion from Dan Wells, this patch adds
an index on config.coded_value_map(ctype). My testing shows
that the index by itself can halve the time required to
fully ingest a new record; in conjunction with the
change in the previous patch, full reingest time is
reduced by about 60%.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
A huge number of rows (700+) have been added to
config.record_attr_definition in recent versions of Evergreen. However,
these rows do not actually define any indexing at all, but are used for
other purposes. The reingest process currently churns over all of these
rows to ultimately do nothing.
This commit limits the group of attributes considered at ingest to only
those which might index something. Testing indicates a substantial
speed boost to typical use of metabib.reingest_record_attributes()
(over 2x speedup).
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Mon, 1 Aug 2016 22:09:04 +0000 (18:09 -0400)]
LP#1608711: Update schema.org property name from "seller" to "offeredBy"
Per the 2015-11-05 release of schema.org
(http://schema.org/docs/releases.html#v2.2), the "offeredBy" property is now
the preferred property to use for non-commercial entities (such as libraries)
making an offer of an item for borrowing, sale, etc.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net>
LP#1549505: Decrease value of Max popularity importance multiplier
My testing found that a setting between 1.1 and 1.2 resulted in fairly good
results when using the popularity-adjusted relevance sort. Adjusting the value
in the seed data to 1.1 since it will be a better starting point for libraries.
We need to be sure that all query values are of the same type in the same
columns because PLPGSQL functions are compiled and cached. In this case,
the core query of the in-db search cannot have its shape change. This
commit assures that browse and search uses of the SP provide core queries
that match on their SELECT lists. Of particular importance is the type
of the "rel" output column, which was variously float8 or numeric, depending
on whether the search contained any terms (a "search") or not (a browse
link).
This patch ensures that the core query passed to
query_parser_fts by staged browse contains dummy
badges and popularity columns (and thus, doesn't break);
note that browse itself cares nothing about popularity.
Galen Charlton [Fri, 11 Mar 2016 18:27:03 +0000 (13:27 -0500)]
LP#1549505: add flag to tweak popularity-adjusted relevance
This adds a new global_flag, search.max_popularity_importance_multiplier,
to control the factor by which popularity affects Popularity Adjusted
Relevance ranking.
The value should be a decimal number, typically between 1.0 and 2.0:
* 1.0 be would be equivalent to not adjusting relevance for popularity
at all.
* 1.1 would mean that the multiplier would range from 1 (for zero
popularity) to 1.1 (for maximum popularity), for a maximum boost of
10% of the base relevance value of the record.
What's happening in the code:
Scale the 0-5 effect of popularity badges by providing a multiplier
for the badge average based on the overall maximum multiplier. Two
examples, comparing the effect to the default $max_mult value of 2.0,
which causes a $adjusted_scale value of 0.2:
* Given the default $max_mult of 2.0, the value of
$adjusted_scale will be 0.2 [($max_mult - 1.0) / 5.0].
For a record whose average badge score is the maximum
of 5.0, that would make the relevance multiplier be
2.0:
1.0 + (5.0 [average score] * 0.2 [ $adjusted_scale ],
This would have the effect of doubling the effective
relevance of highly popular items.
* Given a $max_mult of 1.1, the value of $adjusted_scale
will be 0.02, meaning that the average badge value will be
multiplied by 0.02 rather than 0.2, then added to 1.0 and
used as a multiplier against the base relevance. Thus a
change of at most 10% to the base relevance for a record
with a 5.0 average badge score. This will allow records
that are naturally very relevant to avoid being pushed
below badge-heavy records.
* Given a $max_mult of 3.0, the value of $adjusted_scale
will be 0.4, meaning that the average badge value will be
multiplied by 0.4 rather than 0.2, then added to 1.0 and
used as a multiplier against the base relevance. Thus a
change of as much as 200% to (or three times the size of)
the base relevance for a record with a 5.0 average badge
score. This in turn will cause badges to outweigh
relevance to a very large degree.
The maximum badge multiplier can be set to a value less than
1.0; this would have the effect of making less popular items
show up higher in the results. While this is not a likely
option for production use, it could be useful for identifying
interesting long-tail hits, particularly in a database
where enough badges are configured so that very few records
have an average badge score of zero.
Mike Rylander [Thu, 4 Feb 2016 22:19:03 +0000 (17:19 -0500)]
LP#1549505: Add ability to set default sorter via global flag
In addition, support for sorting by ascending popularity remains
in the back end, however, since if one's configured badges such
that almost every record has a badge score, that sort order could
be useful for examining the long tail of the collection.
Galen Charlton [Thu, 12 May 2016 19:58:49 +0000 (15:58 -0400)]
LP#1581196: webstaff: fix dirty form detection in patron editor
This patch fixes a problem wherein the patron editor
form would think that it had been modified by the
user immediately after initialization.
To test
-------
[1] Load the patron editor, then refresh the page. Note that
you are warned that there is unsaved input.
[2] As above, but hit the save button. Note that after saving,
you still get a warning that there is unsaved input.
[3] Apply the page, then repeat tests 1 and 2. This time, you
shouldn't get inappropriate unsaved data warnings.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
This commit fixes two small AsciiDoc syntax problems that prevented a
line of code from displaying properly. First, it changes the code block
lines from three dashes to four dashes. Second, it adds a plus sign on
the preceding line, to connect the code block to the previous list item.
This commit fixes a small AsciiDoc syntax bug caused by a real '_' that
accidentally closed the '_' italics tag. This block of documentation
will now more closely match the identical content found in
'admin/template_toolkit.txt' (chapter labeled "TPac Configuration and
Customization").
LP#1568046: Replace last two uses of connectby with other function calls.
Modify permission functions permission.usr_has_perm_at_nd and
permission.usr_has_perm_at_all_nd to no longer require the connectby
function from the tablefunc extension. The connectby functionality is
replaced by existing database functions to retrieve org. unit
descendants.
This change removes the need to load the tablefunc extension, so it is
dropped from the create scripts. The upgrade script does not remove
the extension as sites may be using connectby or other functions from
the extension.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Update too_many_overdue and excessive_fines in OpenILS::SIP::Patron
to account for the fact that the user object in this context no
longer contains an array of ausp objects, but just an array of ausp
IDs.
This fixes SIP2 failures with patron information messages when a
patron has one or more blocking penalties that are not otherwise
ignored.
Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This patch wraps the standing penalty checks in evals so that if they
crash, the test script can carry on -- and make it to the point where
it cleans up the standing penalties it adds.
Ben Shum [Wed, 8 Jun 2016 11:41:30 +0000 (07:41 -0400)]
LP#1554714: Set angular 1.5.5 as minimum, not exact version
By adding the ~ in front of the angular version specified, we say
make this the minimum version to look for. This bypasses the issue
for when new releases of the 1.5.x angular series is released, such
as 1.5.6, which is the current new version as of this patch.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Galen Charlton [Wed, 16 Dec 2015 16:03:42 +0000 (11:03 -0500)]
LP#1526858: speed up queries for shelf-expired holds during checkin
This patch adds indexes on action.hold_request and tweaks
the definition of the alhr IDL view to more efficiently
identify holds that can be canceled if the "Clear Holds Shelf"
checkin modifier is in use. This can prevent a problem
where such checkins can time out in very large databases.
The tweaks were created by Jason Etheridge and have been in
production at a large consortium for some time.
To test
-------
[1] With a suitably large database, set up an item that
is on the holds shelf but has passed its shelf-expiration
time, then check it in using the "Clear Holds Shelf" modifier.
[2] The checkin may fail with a "network failure" message due
the query on the alhr timing out.
[3] Apply the patch and repeat step 1. This time, the checkin
should succeed.
Codey Kolasinski [Mon, 16 May 2016 13:28:09 +0000 (09:28 -0400)]
Adds two missing link fields (patron profile and patron home library) to
the fm_idl.xml for the Combined Active and Aged Circulations (combcirc)
reporter source. The fix was originally posted in a comment to the
Launchpad bug by Codey Kolasinski.
This patch removes the SSN (Social Security Number) as a stock
patron identification type, as it is no longer recommended
practice for libraries to store SSNs.
To test:
[1] Verify that in a fresh installation of Evergreen that
has this patch in place, that SSN is no longer listed
as a patron identification type.
Galen Charlton [Mon, 23 May 2016 16:29:04 +0000 (12:29 -0400)]
LP#1373578: fix translatability of hold placement errors
This patch fixes a circumstance where ->maketext() could be
passed an empty string, causing it to emit the PO file header text
rather than a desired string.
To test
-------
[1] Configure Evergreen to use a TPAC localization (e.g.,
the Czech translation).
[2] Enable the "Has Local Copy Alert" library setting.
[3] In the OPAC, change locale and attempt to place a
hold that would trigger the alert saying that there's
already a local copy available.
[4] Note that the alert reads as "Project-Id-Version: evergreen Report-Msgid-Bugs-To: ..."
[5] Apply the patch.
[6] Try step 3; this time the alert will be translated correctly,
e.g., "Ve vaší domovské knihovně je již dostupný exemplář."
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Jason Stephenson [Thu, 26 May 2016 19:23:03 +0000 (15:23 -0400)]
LP 1548993: Remember the Show More/Fewer Details button selection.
The state of the Show More/Fewer Details button selection was
previously not remembered across searches or across changes to
advanced search. This commit attempts to remedy that.
Jason Stephenson [Thu, 19 May 2016 19:53:48 +0000 (15:53 -0400)]
LP 1548993: Restore Show More/Show Fewer Details button functionality.
When using a show_more_details.default setting of true in config.tt2,
the Show More/Show Fewer Details button functionality is broken. The
detail record view is always shown, regardless of the button's state.
This patch attempts to repair the behavior so that the user can toggle
the detail record view even though the default is set to true.
Galen Charlton [Mon, 23 May 2016 14:29:09 +0000 (10:29 -0400)]
LP#1584801: fix tagging of previous circs in metarecord search results
This patch fixes a bug where previously-checked-out items were not
indicated as such in search results when doing a metarecord search.
To test:
[1] Ensure that the opac.search.tag_circulated_items library setting
is enabled and that you are testing with a user that has opted-in
to retaining circ history.
[2] Make a couple loans to that user.
[3] Log into the public catalog using that user.
[4] Perform a catalog search, choosing search terms such that
the previously-loaned items appear in results.
[5] Verify that "I have checked this item out before" is displayed
on the relevant hits.
[6] Click the "Group Formats and Editions" checkbox; note that
after the page refreshes, previously-borrowed hits are /not/
tagged.
[7] Apply the patch and restart the open-ils.search service.
[8] Repeat step 6; verify that this time previously-borrowed hits
are tagged.
Josh Stompro [Wed, 30 Mar 2016 13:47:57 +0000 (08:47 -0500)]
LP#1517556 - Exclude inactive event defs from find_event_def_by_hook.
Currently when find_event_def_by_hook is called to find an appropriate
event_def based on the hook, it doesn't exclude inactive event defs. So
strange behavior can happen if inactive event defs are present.
I ran into this issue when I was trying out different versions of the self
check receipt event def. I had one ative and one inactive while I was
troubleshooting, and when the system would grab the inactive event def by
chance, the self check UI would freeze. I think it is a resonable expectation
that an event def marked inactive doesn't get used by the system.
To test this out, clone one of the self check event defs, such as
"Self-Checkout Items Out Receipt" and mark the copy as inactive. Now
go and trigger this event in the self check interface by attempting to
print from the Items Out screen. It should now fail 50% of the time, since
both the active and inactive defs are returned.
After the fix the inactive event def will always be excluded, so the action
should no longer fail.
This patch fixes a typo in the error message presented
if the queued record could not be cleaned up for some
reason; it also reports the correct type of the record.
Delete the successfully imported authority record from the vandelay
authority queue instead of the bib record that happens to have the same
ID as the imported authority record.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Kathy Lussier [Mon, 23 May 2016 23:17:36 +0000 (19:17 -0400)]
LP#1447746: Fix lp957466_update_date_and_source regression test
The new code introduced through LP1447746 adding an update_bib_source flag to
Vandelay merge profiles broke a test that was verifying the bib source and
edit fields were updated in Vandelay uploads.
This patch fixes the test and also adds a new test to ensure the flag works as
expected when set to both true and false. It also renames the test since the
it's now testing the newer code rather than the previous expected behavior.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
As with other dependencies, the hotkeys package name changed since the
last update. It's now cfp-angular-hotkeys
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
The script was not inserting the version into config.upgrade_log when
run standalone because the line to do so was still commented out.
This commit removes the comment characters.
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
projects / Evergreen.git / log