11 years agoadded crad config UI
miker [Mon, 7 Mar 2011 16:03:12 +0000 (16:03 +0000)]
added crad config UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19610 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocrad uses 'name' as its pkey
miker [Mon, 7 Mar 2011 16:03:09 +0000 (16:03 +0000)]
crad uses 'name' as its pkey

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19609 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocode value map admin page, filtered by record attr def
miker [Mon, 7 Mar 2011 16:03:07 +0000 (16:03 +0000)]
code value map admin page, filtered by record attr def

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19608 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoupdate any existing I18N values for maps moved to ccvm
miker [Mon, 7 Mar 2011 16:03:05 +0000 (16:03 +0000)]
update any existing I18N values for maps moved to ccvm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19607 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoOnly generate ORed filters if there are some to use
miker [Mon, 7 Mar 2011 16:03:02 +0000 (16:03 +0000)]
Only generate ORed filters if there are some to use

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19606 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoupgrade script version of the trigger fixes
miker [Mon, 7 Mar 2011 16:03:00 +0000 (16:03 +0000)]
upgrade script version of the trigger fixes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19605 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agosome update trigger issues from SVF generalization
miker [Mon, 7 Mar 2011 16:02:58 +0000 (16:02 +0000)]
some update trigger issues from SVF generalization

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19604 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomore SVF filter cleanup
miker [Mon, 7 Mar 2011 16:02:56 +0000 (16:02 +0000)]
more SVF filter cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19603 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoGeneral testing-based cleanup of the new SVF QueryParser code. More to come.
miker [Mon, 7 Mar 2011 16:02:53 +0000 (16:02 +0000)]
General testing-based cleanup of the new SVF QueryParser code.  More to come.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19602 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoname is the pkey, not id
miker [Mon, 7 Mar 2011 16:02:50 +0000 (16:02 +0000)]
name is the pkey, not id

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19601 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoupdate 950 seed data for use with the core SVF table ... that was painful
miker [Mon, 7 Mar 2011 16:02:46 +0000 (16:02 +0000)]
update 950 seed data for use with the core SVF table ... that was painful

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19600 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocommit at the end ... and I'd like to reserve a db version number, but not until...
miker [Mon, 7 Mar 2011 16:02:43 +0000 (16:02 +0000)]
commit at the end ... and I'd like to reserve a db version number, but not until it's in trunk

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19599 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoarg, typo
miker [Mon, 7 Mar 2011 16:02:41 +0000 (16:02 +0000)]
arg, typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19598 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTeach storage to initialize the new bits of QueryParser
miker [Mon, 7 Mar 2011 16:02:38 +0000 (16:02 +0000)]
Teach storage to initialize the new bits of QueryParser

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19597 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWorking towards SVF. This is most of phase 1, which is basic DB and QP support.
miker [Mon, 7 Mar 2011 16:02:36 +0000 (16:02 +0000)]
Working towards SVF. This is most of phase 1, which is basic DB and QP support.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19596 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFix cloning of AutoField widgets: LP #728055
dbs [Mon, 7 Mar 2011 15:07:39 +0000 (15:07 +0000)]
Fix cloning of AutoField widgets: LP #728055

Cloning Action/Trigger event definitions was not working properly, as
all values were being copied from the original object using their display
strings rather than the underlying values.

Bill Erickson suggested a fix in IRC that works, so full credit to him
for this change!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19590 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCorrect search index definitions for subject|complete and identifier|bibcn
dbs [Sat, 5 Mar 2011 03:14:47 +0000 (03:14 +0000)]
Correct search index definitions for subject|complete and identifier|bibcn

Dan Wells reported in LP# 729385 that the index definitions for
subject|complete and identifier|bibcn were not working, and traced
the problem to a change in how indexes are generated in 2.0+. Dropping
the trailing '//text()' on these two indexes addresses the problem.

Sites upgrading from a previous version of Evergreen 2.0 will want
to refresh the indexes after applying this schema change to enable
searches against subject|complete and identifier|bibcn to work.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19587 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTeach marc_export how to export bibs for specified libraries
dbs [Fri, 4 Mar 2011 20:58:27 +0000 (20:58 +0000)]
Teach marc_export how to export bibs for specified libraries

Useful shortcut for getting the bibs for libraries based on the
non-deleted callnumbers they have attached to non-deleted bibs.
Doesn't guarantee that they also have either a visible copy or
localized URI attached but whaddya want, magic? :)

Usage: marc_export --library BR1 --library BR2

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19586 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoRespect a setting of depth=0. In particular, this fixes holdings requests for branch...
dbwells [Fri, 4 Mar 2011 19:46:13 +0000 (19:46 +0000)]
Respect a setting of depth=0.  In particular, this fixes holdings requests for branch-level searches with an 'Everything' scope.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19583 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTeac marc_export how to replace the 001 field value with the record ID
dbs [Fri, 4 Mar 2011 18:03:12 +0000 (18:03 +0000)]
Teac marc_export how to replace the 001 field value with the record ID

This is option is probably more useful prior to 2.0 where we introduced
the automated "munge control numbers" option, but new features go
here, right? A site that wants to export their bibliographic records
to send to a large library consortium for control number matching
may find this a useful way to send out records with a local 001 record
ID and get standard identifier control numbers back that they can
add as a 035, per MARC standards.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19582 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSRU: Restructure the hash returned from open-ils.supercat.biblio.search_aliases
dbs [Fri, 4 Mar 2011 02:39:53 +0000 (02:39 +0000)]
SRU: Restructure the hash returned from open-ils.supercat.biblio.search_aliases

By returning explicit index and title elements from the method,
we can backport cleanly to 2.0 and set the stage for pulling the
title element directly from the database in 2.1 and beyond.

In addition, the enriched object enables us to get rid of the
hardcoded nested qualifier map for bibs, and also enables us to
fix the explain document for SRU for authority records.

Finally, we also fix the mappings of SRU qualifiers to Evergreen
search aliases (in many cases we had been quietly falling back
to plain kw searches, which was not cool).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19573 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd complete set of Evergreen search aliases and attributes to SRU explain
dbs [Thu, 3 Mar 2011 20:47:23 +0000 (20:47 +0000)]
Add complete set of Evergreen search aliases and attributes to SRU explain

Original "pull from database" code had limited the search aliases to those
that were qualified; now we pull all of them, and if they are not qualified,
we qualify them as "eg".

In addition, for some of the non-index attributes (sort, direction, site,
available), restore the descriptive title that was previously available.
Slightly longer term we will add a "description" column to
config.metabib_search_alias to store this information.

Also, we had always been using the global %qualifier_map in
return_sru_explain(), even though the intention was to enable the authority
explain index to pass in an overriding set of values. This commit breaks the
authority SRU explain, but as it had been incorrectly dumping the bib explain,
this brings us a step closer to proper explain support for authorities.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19572 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoDraw SRU search indexes from config.metabib_search_alias
dbs [Thu, 3 Mar 2011 05:44:33 +0000 (05:44 +0000)]
Draw SRU search indexes from config.metabib_search_alias

We had hardcoded search indexes for SRU, but thanks to the work
of Mike Rylander, it is fairly easy to remove that brittle code
and replace it with code that polls the contents of
config.metabib_search_alias and dumps it into the explain document.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19564 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhitespace consistency for O:WWW:SuperCat.pm
dbs [Thu, 3 Mar 2011 05:43:25 +0000 (05:43 +0000)]
Whitespace consistency for O:WWW:SuperCat.pm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19563 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCall number sorting "before" the context needs to be segregated based on directly...
miker [Wed, 2 Mar 2011 20:43:17 +0000 (20:43 +0000)]
Call number sorting "before" the context needs to be segregated based on directly on the label, "here-and-after" on the bytea version.  Testing bears this out, but more eyes would be appreciated.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19560 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd example intervals to some library setting descriptions
dbs [Wed, 2 Mar 2011 02:53:23 +0000 (02:53 +0000)]
Add example intervals to some library setting descriptions

Based on a patch provided by Michael Peters <mrpeters@library.in.gov>
in Launchpad bug 717308, provide examples of intervals in several
descriptions that lacked them.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19558 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPrevent an unitialized variable warning when loading OpenILS::WWW::EgWeb
dbs [Tue, 1 Mar 2011 22:27:43 +0000 (22:27 +0000)]
Prevent an unitialized variable warning when loading OpenILS::WWW::EgWeb

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19555 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoRemove dead code: OpenILS::WWW::Web and OpenILS::WWW::Method modules
dbs [Tue, 1 Mar 2011 22:27:03 +0000 (22:27 +0000)]
Remove dead code: OpenILS::WWW::Web and OpenILS::WWW::Method modules

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19554 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoupdate cached user after email/password update; repaired recently-introduced typo...
erickson [Tue, 1 Mar 2011 21:19:39 +0000 (21:19 +0000)]
update cached user after email/password update; repaired recently-introduced typo on user transaction retrieval method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19552 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agowhen using the force-reload option to reset timeout, propagate the ws_ou and wsid...
erickson [Tue, 1 Mar 2011 18:09:57 +0000 (18:09 +0000)]
when using the force-reload option to reset timeout, propagate the ws_ou and wsid values from the cached user object into the reloaded user object

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19551 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomerging in some useful changes from the opac-tt-poc branch, including capture of...
erickson [Tue, 1 Mar 2011 16:20:52 +0000 (16:20 +0000)]
merging in some useful changes from the opac-tt-poc branch, including capture of authtime in CStoreEditor, some holds retrieval de-fleshing options, and a total_count field added to user opac vital stats api

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19549 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd a TT helper to encode email headers in UTF-8
dbs [Tue, 1 Mar 2011 04:16:07 +0000 (04:16 +0000)]
Add a TT helper to encode email headers in UTF-8

This can and should be used to encode any headers (To, From, Subject, etc)
in an email that might include text outside of the ASCII 7-bit range. Names
of people or libraries, for example, that might otherwise come out garbled.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19546 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoUpdated org selector code in org setting UI
erickson [Fri, 25 Feb 2011 21:32:02 +0000 (21:32 +0000)]
Updated org selector code in org setting UI

Removed some ad-hoc org-unit tree widget code and replaced with
the a standard solution from the openils dojo user lib.

Pass the auth on org value retrieval to pick up perm-protected settings.

Use STAFF_LOGIN for context selector perm, since each setting has its
own perm that is checked before fetching.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19543 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomake sure asset.call_number.label_sortkey is up to date
miker [Fri, 25 Feb 2011 19:12:49 +0000 (19:12 +0000)]
make sure asset.call_number.label_sortkey is up to date

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19540 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotypo fix
gmc [Thu, 24 Feb 2011 21:57:23 +0000 (21:57 +0000)]
typo fix

"Pat, I'd like to buy a vowel"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19537 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFix regex in maintain 901c
dbwells [Thu, 24 Feb 2011 20:00:09 +0000 (20:00 +0000)]
Fix regex in maintain 901c

The previous regex would delete any 901 fields *and* any fields which followed.  Since the 901 is typically the last field, this problem didn't surface during testing.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19534 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded missing columns to CDBI table definitions
gmc [Thu, 24 Feb 2011 16:50:55 +0000 (16:50 +0000)]
added missing columns to CDBI table definitions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19531 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPer Robert Soulliere, it can be necessary in some cases to clean out bad
senator [Thu, 24 Feb 2011 15:35:12 +0000 (15:35 +0000)]
Per Robert Soulliere, it can be necessary in some cases to clean out bad
data from action.reservation_transit_copy before applying the missing
fkeys to said table.


git-svn-id: svn://svn.open-ils.org/ILS/trunk@19528 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoclear out the hold_copy_map entries for holds cancelled via the clear-shelf processes
erickson [Wed, 23 Feb 2011 22:20:05 +0000 (22:20 +0000)]
clear out the hold_copy_map entries for holds cancelled via the clear-shelf processes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19525 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoinclude copy/call_number deletedness in staff-version copy counts
miker [Wed, 23 Feb 2011 21:32:42 +0000 (21:32 +0000)]
include copy/call_number deletedness in staff-version copy counts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19522 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd 830 as a controllable bibliographic field in authority linking script
dbs [Wed, 23 Feb 2011 15:05:36 +0000 (15:05 +0000)]
Add 830 as a controllable bibliographic field in authority linking script

Per http://www.loc.gov/marc/bibliographic/bd830.html, bibliographic 830
should be controlled by authority 130. The "common cataloging practice"
in 830 of omitting non-filing characters may cause some entries to not be
linked that otherwise would be.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19518 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomissing semicolon
phasefx [Wed, 23 Feb 2011 04:28:15 +0000 (04:28 +0000)]
missing semicolon

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19517 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotypo
phasefx [Wed, 23 Feb 2011 04:17:33 +0000 (04:17 +0000)]

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19516 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWorking SRU search for various authority records
dbs [Wed, 23 Feb 2011 02:56:54 +0000 (02:56 +0000)]
Working SRU search for various authority records

We now have search indexes for:
  * ID
  * name
  * subject
  * title
  * topic

O:WWW:SuperCat::sru_search has been refactored somewhat to reduce
code duplication between the authority SRU and the bibliographic SRU.

This SRU interface lives, by default, at http://hostname/opac/extras/sru_auth

Explain output is still a bit wonky in the configInfo section.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19514 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCorrect the install location for Dojo i18n bundles
dbs [Wed, 23 Feb 2011 02:10:05 +0000 (02:10 +0000)]
Correct the install location for Dojo i18n bundles

We had been converting xx-YY into xx/yy for a directory structure,
but current evidence shows that it should be xx-yy. Hard to believe
we've overlooked this for so long. Also, with the exception of the
en-ca/en-gb/en-us locales, we should probably trim the locale to
just xx - but that's a different problem, and let's just focus on
getting this working to begin with.

Addresses Launchpad # 723489

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19507 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMerging in unAPI v2, the bono edition
miker [Wed, 23 Feb 2011 02:06:06 +0000 (02:06 +0000)]
Merging in unAPI v2, the bono edition

 * Add unapi schema, functions and initial transform setup
 * General purpose tag URI parser
 * upgrade script and build-db.pl integration

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19506 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agodojo.js has to be loaded from the same domain as the page, unless it's a cross-domain...
erickson [Tue, 22 Feb 2011 21:18:14 +0000 (21:18 +0000)]
dojo.js has to be loaded from the same domain as the page, unless it's a cross-domain build

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19503 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMake sure we continue looping in situations where there is only one copy
miker [Mon, 21 Feb 2011 18:34:02 +0000 (18:34 +0000)]
Make sure we continue looping in situations where there is only one copy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19499 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd support for 9.0 in initial db creation scripts
miker [Mon, 21 Feb 2011 15:44:17 +0000 (15:44 +0000)]
Add support for 9.0 in initial db creation scripts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19495 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAddressing LP bug: https://bugs.launchpad.net/evergreen/+bug/721450
miker [Mon, 21 Feb 2011 15:39:29 +0000 (15:39 +0000)]
Addressing LP bug: https://bugs.launchpad.net/evergreen/+bug/721450

If a series-class index definition has been removed, the data remains in the field entry table.  This is because there was no fkey previously.  We need to clean that data out so that the fkey can be validated during upgrade.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19494 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoA function for normalizing numeric strings
miker [Fri, 18 Feb 2011 20:32:13 +0000 (20:32 +0000)]
A function for normalizing numeric strings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19491 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoWhitespace - convert mix of tabs/spaces to pure spaces
dbs [Fri, 18 Feb 2011 18:37:33 +0000 (18:37 +0000)]
Whitespace - convert mix of tabs/spaces to pure spaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19486 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoSwitch to BT.textContent() for Opera compatibility
dbs [Fri, 18 Feb 2011 18:36:49 +0000 (18:36 +0000)]
Switch to BT.textContent() for Opera compatibility

The BT.textContent() method abstracts away some of the browser
differences for us. Most importantly, it makes Opera happy.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19485 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agows_ou may be null in an opac context, fall back to home org
erickson [Fri, 18 Feb 2011 14:35:06 +0000 (14:35 +0000)]
ws_ou may be null in an opac context, fall back to home org

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19480 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow users to see their own payments w/o perm
erickson [Fri, 18 Feb 2011 14:35:05 +0000 (14:35 +0000)]
allow users to see their own payments w/o perm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19479 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoretain ability for a user to see his/her own payments and open transactions
erickson [Fri, 18 Feb 2011 14:35:04 +0000 (14:35 +0000)]
retain ability for a user to see his/her own payments and open transactions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19478 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoMore user transaction retrieval API cleanup
erickson [Fri, 18 Feb 2011 14:35:03 +0000 (14:35 +0000)]
More user transaction retrieval API cleanup

Use consistent xact fleshing mechanism for circulations both for
less/cleaner code and to consistently take advantage of CSToreEditor for
authoritative support.

Added .flesh option to transaction history api calls, consistent with
non-history version.

Added a have_payments history call so we can limit retrieval to xacts
that had at least 1 payment

When making sub-req calls to payment API calls, call .authoritative as

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19477 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoBolster SendEmail Reactor's handling of UTF-8 content
dbs [Fri, 18 Feb 2011 05:44:11 +0000 (05:44 +0000)]
Bolster SendEmail Reactor's handling of UTF-8 content

Use the Encode module and encode_utf8() instead of utf8 and utf8::encode.
The utf8 module is meant for enabling UTF-8 content in source code.

Also, add the MIME-Version / Content-type / charset headers that
some mail user agents need to know that they're dealing with Unicode

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19476 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoBooking: fix the targeter in the I'm-reserving-this-exact-resource-with-this-
senator [Thu, 17 Feb 2011 20:53:36 +0000 (20:53 +0000)]
Booking: fix the targeter in the I'm-reserving-this-exact-resource-with-this-
exact-barcode case.

It should have always worked like this. This should better mirror the behavior
in the holds targeter when placing a copy-level hold.  Basically don't fail
to target a resource for a reservation later just because it's not in an
available status right at this moment.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19470 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAvoid mixed-content warnings due to HTTP link for Google Chrome Frame
dbs [Thu, 17 Feb 2011 18:55:31 +0000 (18:55 +0000)]
Avoid mixed-content warnings due to HTTP link for Google Chrome Frame

We're hardcoding this to HTTPS for now to avoid the mixed-content warnings that
occur when content location is https:// and the linked script is at http:// but
a config-aware patch probably wouldn't be a bad idea.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19466 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agovestigial 2nd param to session.retrieve from opac now actually changes the behavior...
erickson [Thu, 17 Feb 2011 18:35:06 +0000 (18:35 +0000)]
vestigial 2nd param to session.retrieve from opac now actually changes the behavior (see r19447) in an unexpected way, remove

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19464 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCSS hook for check-in failures with selfcheck
phasefx [Thu, 17 Feb 2011 04:18:27 +0000 (04:18 +0000)]
CSS hook for check-in failures with selfcheck

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19461 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTeach maintain_901 trigger to respect the "Use record ID for TCN" global flag
dbs [Thu, 17 Feb 2011 03:27:53 +0000 (03:27 +0000)]
Teach maintain_901 trigger to respect the "Use record ID for TCN" global flag

Rather than relying on the Perl layer to set the correct TCN on the way in,
do it as part of the in-database indexing to ensure that we have consistent
results no matter how the record gets into the database.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19458 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch based on work by Dan Wells to improve Opera BibTemplate support
miker [Wed, 16 Feb 2011 22:20:53 +0000 (22:20 +0000)]
Patch based on work by Dan Wells to improve Opera BibTemplate support

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19455 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Thomas Berezansky to implement circulation matchpoint value fallthrough...
miker [Wed, 16 Feb 2011 20:47:11 +0000 (20:47 +0000)]
Patch from Thomas Berezansky to implement circulation matchpoint value fallthrough, whereby specific rules can inherit values from generic rules.

Background, taken from https://bugs.launchpad.net/evergreen/+bug/635463:

Make the things returned (circulate, duration_rule, recurring_fine_rule, max_fine_rule, hard_due_date, total_copy_hold_ratio, available_copy_hold_ratio and renewals) "fall through" when set to NULL.

The circ matrix edit screen has had some changes too, partially for showing "Inherited" in some places where appropriate, partially for field ordering and editing display and consistency. The fields that show up earlier contribute to tests that will be applied to the circulation attempt, while the "results" that do not change what rows are considered are grouped at the end.


You can override a subset of those fields with a specific rule while allowing broader rules to fill in the holes.
This may result in less duplication of information across rules, making things easier to maintain.
Thus, this may result in less rules in general, and thus less processing time on sorting them overall.


Manually figuring out the specifics of what will happen will take more time/effort.
Changing a single rule may have a greater unintended effect on other rules.
Staff would need training for when to have a rule fall through and when to set it specifically.
More time to return from the DB for any rule that is "falling through" to broader rules.

Examples for the following org tree:


Implementing the following "business" rules:

At the CONS level:
By default, everything circulates, uses DFLT_DUR duration, DFLT_RFINE recurring fine, and DFLT_MFINE max fine.
Circ Modifier "book" uses the duration BOOK_DUR
Reference flagged materials don't circulate

At the SYSA level there are no special rules.

At the SYSB level the max fine should be SYSB_MFINE.

At the LIBC level the recurring fine is LIBC_RFINE

At the LIBD level circ modifier "book" uses the DFLT_DUR duration instead of "BOOK_DUR"

At the LIBE level reference flagged materials circulate.

At the LIBF level there are no special rules.

The current method would require the following circ rules to implement those business rules:


16 circ rules total.

The new method would require the following circ rules to implement those business rules:


7 circ rules total.

Starting with the above, lets assume that SYSA wants to change their recurring fine to SYSA_RFINE.
LIBC's recurring fine is to be unchanged.

The current method requires the following changes:

ADD the following entries:

UPDATE the LIBD entries:

4 rules added, 2 changed, total is now 20 rules.

The new method would require the following changes:

ADD the following entry:

1 rule added, 0 changed, total is now 8 rules.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19453 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Thomas Berezansky to make many older OU setting types i18n friendly
miker [Wed, 16 Feb 2011 20:21:17 +0000 (20:21 +0000)]
Patch from Thomas Berezansky to make many older OU setting types i18n friendly

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19451 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agorealign trunk permission numbering with 2.0
miker [Wed, 16 Feb 2011 19:52:20 +0000 (19:52 +0000)]
realign trunk permission numbering with 2.0

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19449 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoadded option to open-ils.auth.session.retrieve to return the full cached object,...
erickson [Wed, 16 Feb 2011 15:07:04 +0000 (15:07 +0000)]
added option to open-ils.auth.session.retrieve to return the full cached object, which includes the auth time (cache timeout) of the cached user object

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19447 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAdd a note for future work for full hold count coverage
miker [Tue, 15 Feb 2011 20:49:37 +0000 (20:49 +0000)]
Add a note for future work for full hold count coverage

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19446 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agowho needs this much noise in the javascript console? javascript.options.strict =...
phasefx [Tue, 15 Feb 2011 19:00:47 +0000 (19:00 +0000)]
who needs this much noise in the javascript console? javascript.options.strict = false

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19445 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocapture credit card order_number
erickson [Mon, 14 Feb 2011 21:06:51 +0000 (21:06 +0000)]
capture credit card order_number

Uunique payment transaction ID for online payments

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19443 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoEnable MFHD tests to find their testdata
dbs [Mon, 14 Feb 2011 07:22:11 +0000 (07:22 +0000)]
Enable MFHD tests to find their testdata

When the MFHD tests wrapped in mfhd.t are invoked from outside of the directory,
they tests failed to find the mfhddata.txt file. Judicious use of the __FILE__
special literal and File::Basename::dirname() avoids that problem. Now we just
need to munge @INC to ensure that testlib.pm can be resolved (and hope that
no conflicts ever turn up).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19442 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTeach authority_control_fields.pl about record ranges
dbs [Sun, 13 Feb 2011 03:14:21 +0000 (03:14 +0000)]
Teach authority_control_fields.pl about record ranges

Passing --record 10,000 times at the command line sucks, and
--all is not particularly realistic for large databases. Adding
--start_id and --end_id makes this script more usable.

Also provide reasonably full POD documentation, and rely on
Pod::Usage to provide help based on it when help is requested
or passed in options don't make sense.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19439 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoNormalize ISBNs by stripping hyphens in search methods and in reporter.materialized_s...
dbs [Fri, 11 Feb 2011 21:39:48 +0000 (21:39 +0000)]
Normalize ISBNs by stripping hyphens in search methods and in reporter.materialized_simple_record

We weren't normalizing ISBNs in search or in reporter.materialized_simple_record
which required users to exactly match the form of the ISBN as entered in the
MARC record to get a successful search result - pretty hit or miss.

The longer term fix in 2.0 and above is to make the ISBN search search against
the identifier|isbn index, which also gets ISBN10/ISBN13 equivalence goodness.
But this patch will be relatively easy to backport through to 1.6.1 and plugs
some of the holes in our exposed APIs and search points in the short term.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19432 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agobump xulrunner version
phasefx [Fri, 11 Feb 2011 02:38:45 +0000 (02:38 +0000)]
bump xulrunner version

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19430 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPostgres 9.0 is more strict about variable names in functions. We will probably hit...
miker [Fri, 11 Feb 2011 00:49:40 +0000 (00:49 +0000)]
Postgres 9.0 is more strict about variable names in functions. We will probably hit more of these, but these in particular break the OPAC.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19427 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Thomas Berezansky addressing his recent dynamic circ/hold field weighting...
miker [Thu, 10 Feb 2011 14:56:01 +0000 (14:56 +0000)]
Patch from Thomas Berezansky addressing his recent dynamic circ/hold field weighting patch.

Due to an oversight of auto-casting on my part dynamic weighting may incorrectly order similar rows that differ only in org unit or permission group.

Bad me for not testing for that case before now.

The attached patch should fix this. All it does is replace two functions, and in them replaces one INT variable with a NUMERIC(6,2) and a pile of integer constants with numeric constants (by virtue of adding .0 to them).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19422 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoReduce hard-coded strings in Serial Control interfaces
dbwells [Wed, 9 Feb 2011 18:57:50 +0000 (18:57 +0000)]
Reduce hard-coded strings in Serial Control interfaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19419 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow item status update if either status-specific perm is allowed or UPDATE_COPY...
erickson [Wed, 9 Feb 2011 18:22:14 +0000 (18:22 +0000)]
allow item status update if either status-specific perm is allowed or UPDATE_COPY is allowed.  fire off related A/T events after the initial transaction has been committed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19414 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agotweak selector used for font_helper() CSS classes
phasefx [Tue, 8 Feb 2011 22:52:31 +0000 (22:52 +0000)]
tweak selector used for font_helper() CSS classes

Makes the flat-text MARC editor respect the global font settings,
resolving bug https://bugs.launchpad.net/evergreen/+bug/678078

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19411 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Robert Soulliere to update settings-tester.pl
miker [Tue, 8 Feb 2011 17:56:08 +0000 (17:56 +0000)]
Patch from Robert Soulliere to update settings-tester.pl

Changes include:

- Use Test::More perl module to replace eval/die tests for initial tests (as indicated in FIXME comment)
Note/question: should I add an install of the Test::More perl module in Makefile.install for Evergreen prerequisites?

- Add a statement to print postgresql version.

- Add an elsif during "driver" testing to say OK to SIP driver since this is used in telephony section. -- remove scary ERROR

- Add UUID::Tiny to perl module list of checks.
question: More perl module checks needed?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19409 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPatch from Thomas Berezansky addressing circ/hold config constraints, and their lack...
miker [Tue, 8 Feb 2011 17:22:00 +0000 (17:22 +0000)]
Patch from Thomas Berezansky addressing circ/hold config constraints, and their lack of usefulness.

The config.circ_matrix_matchpoint and config.hold_matrix_matchpoint tables have unique constraints that are intended to ensure that you have at most one entry in the table for each set of input conditions.

These constraints operate over a set of fields that can (in whole or part) be set to null, and thus don't do what they are intended to in most (if not basically all) cases.

[This patch] replaces the unique constraints with unique indexes. Nullable fields are coalesced into empty strings so that they can be matched against, and the index only applies to those rows set as active.

The included upgrade script cleans up the tables by taking each set of non-unique rows the unique index would fail on and setting all but the first (in id order) to active=false. If an administrator determines that the wrong row was left active they can toggle active off on the one that was left and back on for the correct one.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19408 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoRemove syntax error from O:A:Storage:Publisher:authority and add strict pragma
dbs [Tue, 8 Feb 2011 06:20:36 +0000 (06:20 +0000)]
Remove syntax error from O:A:Storage:Publisher:authority and add strict pragma

Came across a line of dead code while debugging a related problem, and
noticed that strict/warnings wasn't in place, so I culled the dead code
and added use strict/use warnings accordingly (now that we no longer
have the syntax error caused by the dead code).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19406 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoCreate authorities that only contain controlled subfields (LP 712496)
dbs [Tue, 8 Feb 2011 06:12:24 +0000 (06:12 +0000)]
Create authorities that only contain controlled subfields (LP 712496)

Selecting "Create authority" on a field containing uncontrolled subfields
would generate an authority record that contained those uncontrolled
subfields. This would, in turn, prevent the "Validate" button from operating
correctly - if you added a 700 with $a and $c subfields, clicked "Create
authority", and then immediately clicked "Validate", the field would show
up as red.

Now we filter out the uncontrolled subfields before they get sent to
the "Create authority" function, avoiding this validation problem.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19404 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoEnsure new authority ID subfield is inserted in the correct XUL DOM location
dbs [Tue, 8 Feb 2011 05:11:47 +0000 (05:11 +0000)]
Ensure new authority ID subfield is inserted in the correct XUL DOM location

Addresses LP 712499. After creating an authority via the context menu
in the MARC editor, the new ID subfield ($0) would be created right after
the subfield on which the context menu was invoked. It turns out that it
was being placed in the wrong location, and one symptom was that the
Validate button would not validate the controlled field against the newly
created authority.

Now we hunt through the parent DOM nodes until we find the 'sf_box' element
and then we append the ID subfield to that node. We also eliminate some
duplicate code by defining a common function so that the problem can be
fixed in one stroke...

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19402 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPrevent authority context menu on whitespace content
dbs [Tue, 8 Feb 2011 03:49:36 +0000 (03:49 +0000)]
Prevent authority context menu on whitespace content

Continuing the refinement of LP 712538, if the subfield contains
only whitespace, treat it as though it were empty for the purposes
of the context menu.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19399 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoPrevent authority context menu from being displayed on empty content (LP 712538)
dbs [Tue, 8 Feb 2011 03:43:08 +0000 (03:43 +0000)]
Prevent authority context menu from being displayed on empty content (LP 712538)

It's confusing to have the authority context menu - particularly the
"Create authority" options - appear for empty content. Check to ensure
that the subfield being clicked on actually has some content before
displaying the authority context menu.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19398 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoFix ModsParser.pm bug involving invalid ISBNs. See bug #697398.
dbwells [Fri, 4 Feb 2011 18:51:45 +0000 (18:51 +0000)]
Fix ModsParser.pm bug involving invalid ISBNs.  See bug #697398.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19383 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoremove debugging remnant
phasefx [Fri, 4 Feb 2011 06:29:30 +0000 (06:29 +0000)]
remove debugging remnant

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19382 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoreset "no change" label whenever a specific row in the check-in interface is selected...
phasefx [Fri, 4 Feb 2011 06:27:22 +0000 (06:27 +0000)]
reset "no change" label whenever a specific row in the check-in interface is selected, but for now, only if the transaction has a balance owed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19381 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoported open-ils.actor.user.transaction.[fleshed.]retrieve to CStoreEditor both for...
erickson [Fri, 4 Feb 2011 00:14:26 +0000 (00:14 +0000)]
ported open-ils.actor.user.transaction.[fleshed.]retrieve to CStoreEditor both for cleanup and to take advantage of .authoritative.  Use authoritative version in staff client

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19379 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoportal tweaks; don't link to launchpad
phasefx [Thu, 3 Feb 2011 23:50:16 +0000 (23:50 +0000)]
portal tweaks; don't link to launchpad

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19378 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agomake the browser Reload button aware of tab locking for unsaved data
phasefx [Thu, 3 Feb 2011 23:40:50 +0000 (23:40 +0000)]
make the browser Reload button aware of tab locking for unsaved data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19377 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoclear shelf expire time and some other fields when un-cancelling a hold
erickson [Thu, 3 Feb 2011 23:30:34 +0000 (23:30 +0000)]
clear shelf expire time and some other fields when un-cancelling a hold

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19375 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoTwo binding fixes for manage items
dbwells [Thu, 3 Feb 2011 16:47:49 +0000 (16:47 +0000)]
Two binding fixes for manage items

The first fix is more or less cosmetic.  When selecting a target unit, both areas need to refresh in order to not show the selected unit's items in the main list.

The second fix involves handling cases where moving items from one unit to another does not empty the 'donor' unit.  In those cases, we need to update the contents of both the new and the old unit.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19373 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoAuthorities: control 610/611, do not control 4xx by default
dbs [Thu, 3 Feb 2011 14:15:47 +0000 (14:15 +0000)]
Authorities: control 610/611, do not control 4xx by default

The 4xx fields in bibliographic records have not been controlled
fields for some time (1988 for CAN/MARC, 1999 for USMARC per)
http://www.loc.gov/marc/bibliographic/bd4xx.html; and
http://www.oclc.org/bibformats/en/4xx/default.shtm also lists
these as obsolete. So, remove them from the default controlled
fields in Evergreen.

Also, add 610/611 to the controlled fields list (per LP #712467).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19371 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agolet due date show up correctly in the copy browser for circulating items
phasefx [Wed, 2 Feb 2011 20:51:40 +0000 (20:51 +0000)]
let due date show up correctly in the copy browser for circulating items

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19369 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoallow deletion of stat cat entries in the patron editor (or more accurately, rows...
phasefx [Wed, 2 Feb 2011 19:56:39 +0000 (19:56 +0000)]
allow deletion of stat cat entries in the patron editor (or more accurately, rows in actor.stat_cat_entry_usr_map) by blanking out the value

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19364 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agocirc.claim_return.mark_missing was superceded with circ.claim_return.copy_status...
phasefx [Wed, 2 Feb 2011 19:34:36 +0000 (19:34 +0000)]
circ.claim_return.mark_missing was superceded with circ.claim_return.copy_status.  It's still lingering in 1.6.1-2.0-upgrade-db.sql, and in other branches.  Thanks to bshum for noticing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19363 dcc99617-32d9-48b4-a31d-7c20da2025e4

11 years agoexit finish_fines_and_voiding() if there is no open circ
erickson [Wed, 2 Feb 2011 18:53:25 +0000 (18:53 +0000)]
exit finish_fines_and_voiding() if there is no open circ

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19361 dcc99617-32d9-48b4-a31d-7c20da2025e4