LP#1812900: fix retention of saved defaults in holdings editor
Because the $watch on the statistical category default OU filter
in the holdings editor can fire before the form is fully initialized,
saved defaults (i.e., the cat.copy.defaults workstation setting)
could get overwritten with the hard-coded default value for that, er,
set of defaults.
This patch ensures that that $watch saves the defaults only when the
value of the default stat cat OU filter has changed.
To test
-------
[1] Use the holdings editor on an item. Change to the defaults
tab and check or uncheck checkboxes such as "Use checkdigit"
and "Print Item Labels on Save and Exit"
[2] Refresh the page or open the holdings editor on a different item.
Note that the settings from step #1 are not retained.
[3] Apply the patch.
[4] Repeat steps #1 and #2. This time, the settings should be retained.
[5] Set the Default Filter Library in the same tab and refresh. Verify
that the OU you chose is retained.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: John Amundson <jsamundson@cwmars.org> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Add a title attribute to the top-right menu in the AngularJS form of the
navbar.
Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval
It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason. When this happens,
the user sees an Internal Server Error. The underlying cause is the
following Perl error:
Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.
This commit rearranges the code around that line to avoid this
particular undefined value reference error.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Fri, 24 May 2019 17:16:00 +0000 (17:16 +0000)]
lp1789257 Items Out Monograph Part Column
Retrieve and display the label of all monograph parts for
copy listed in the Items Out table
To test
-------
[1] Apply the patch.
[2] Check out an item that has one or more monograph parts
linked to it.
[3] Verify that the Monograph Part column is available in the
Items Out grid and displays the part label(s). An example
of an item in the Concerto set that has a part is
CONC70001420.
Bill Erickson [Fri, 8 Mar 2019 15:38:43 +0000 (10:38 -0500)]
LP1748265 Hold fetch API sms_carrier option
Support a new "include_sms_carrier" option to the holds retrieve API so
the data may be fetched along with the hold instead after the fact in
the patron holds list, etc.
Garry Collum [Sun, 3 Jun 2018 19:54:25 +0000 (15:54 -0400)]
LP#1748265 SMS Carrier not an option in the patron's list of holds.
Adds SMS Carrier name as an option in the patron's list of holds.
To test:
1. Set 'Enable features that send SMS text messages' in the Library Settings to true.
2. Place a few holds for a patron, selecting text message notification.
3. Go to the patron's record and view their holds.
4. Display the 'Notifications SMS Carrier' column to view the carrier name.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Garry Collum [Sat, 19 May 2018 21:00:40 +0000 (17:00 -0400)]
LP1772206 Tooltips missing from Patron Summary
Adds tooltips for home branch and Last Activity to emulate the XUL
client. The home branch tool tip displays the long OU name. The
last activity tooltip displays the last type of activity.
To test:
Home branch
1. Perform a patron search.
2. Click on one of the patrons in the results.
3. Hover over the home branch location in the patron summary.
Last Activity
4. Log into the opac with a patron account to some patron activity.
5. Bring up the patron in the staff client.
6. Hover over the last activity date.
Dan Pearl [Tue, 10 Apr 2018 18:45:47 +0000 (14:45 -0400)]
LP1760893 Add Holdings Part dropdown should list items in order
Without a defined sort, the Part dropdown when editing a holding simply
displays in database order. Let's be more deterministic about it.
In this case, while slightly surprising, consensus opinion was that
reverse order on label_sortkey provides the best overall usability.
This is obviously true on records with many parts, but can help in all
cases.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
- ensures that the Boolean values get saved as 't' or 'f', as
the reporter builder doesn't recognize JSON true or false in
this context.
- pretty-prints the current filter value in the dialog
- removes a logging line
To test
-------
[1] Apply the patch.
[2] Create or clone one or more report templates and add Boolean
column filters. Change the filter value and verify that
it displays the current value and lets you change it.
[3] Run reports from the template(s) created in step 2 and
verify that the reports produce the expected results.
Jason Boyer [Tue, 29 Jan 2019 17:15:25 +0000 (12:15 -0500)]
LP1642337: Reporter Boolean Filters
The dialog controller doesn't appreciate getting
a bare boolean as a message, so if the current item
is a boolean call toString() on it before calling
the egConfirmDialog.
An <Unset> string is also added to the reporter
strings for further use, but if there are no
strong feelings re: using it, it can be dumped and
a '' used in its place.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Thu, 16 Nov 2017 20:56:51 +0000 (20:56 +0000)]
lp1642337 Boolean Filters in Reporter
- Add condition check to see if filter is boolean, and if so,
substitute a confirm dialog for the default prompt, repalcing
the text input with buttons for True/False values.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
a. bellenir [Mon, 11 Mar 2019 17:39:00 +0000 (13:39 -0400)]
LP1775639: Refresh required to see Patron Credit
reload patron data when applying a payment
if the payment will change the patron's credit forward balance.
To test
-------
[1] Bill a patron, then make sure that the "Convert Change to Patron
Credit" checkbox is checked. Pay bill with more than the total
balance. Note that the Credit Available amount in the billing
summary does not change. Refresh the page.
[2] Bill a patron, then use the patron credit added in step 1 to
pay off the bill. Note that again, the Credit Available amount
does not change.
[3] Apply the patch and repeats steps 1 and 2. This time, the Credit
Available field should get updated.
Jane Sandberg [Wed, 17 Apr 2019 20:46:46 +0000 (16:46 -0400)]
LP1744386: Alphabetize stat cats in volcopy attr editor
To test:
1. Go to the volume copy editor. Confirm that the stat
cats do not display in order of owning library or stat cat
name.
2. Apply this commit.
3. Go to the volume copy editor. Confirm that the stat
cats now display in alphabetical order by owning library,
then stat cat name.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1440890: add vandelay_queue to the types of containers retrieved by batch edit
To test
-------
[1] Perform a batch bibliographic record import, then add the import
queue to a new bucket.
[2] In the web staff client, go to Cataloging | Batch Edit.
[3] Note that the bucket created in step 1 does _not_ appear in the
bucket selector on the batch edit page.
[4] In the web staff client, go to the record bucket and hit the
Batch edit button.
[5] Note that the bucket created in step 1 does _not_ appear in the
bucket selector on the batch edit page.
[6] Apply the patch and repeat steps 2-3. This time, the bucket
should appear in the selector.
[7] Repeat steps 4-5. This time, the bucket should appear in the selector
(and be the active choice).
Jane Sandberg [Thu, 6 Dec 2018 23:49:40 +0000 (15:49 -0800)]
LP1760599: Only show merge records action when multiple bucket records selected
To test:
1) Create a bucket.
2) Select one record from your bucket. Right-click on your record or click on the Actions drop-down.
3) Note that "Merge Selected Records" is clickable.
4) Apply this commit.
5) Repeat steps 2-3. Note that "Merge Selected Records" is no longer
clickable, unless you select two or more records.
Jason Boyer [Thu, 7 Feb 2019 18:48:13 +0000 (13:48 -0500)]
LP1790896: Receipt Errors with invalid emails
The attempt at belt-and-suspenders checking for a valid
email for use in the has_email template field sadly
causes the JS to trip over said suspenders if there is
a value in the field but it doesn't contain a '@'.
The raw return from "".match() (either an array or null)
is enough to do the right thing when converted into a
Boolean and doesn't cause the same problems.
To test
-------
[1] Set up a patron record with an invalid email address,
e.g., one that lacks the '@' character.
[2] Check out an item the patron, then from the Items Out
tab, print an item receipt.
[3] Note that nothing happens and an error is logged in the
browser console.
[4] Apply the patch and repeat step 2. This time, a receipt
should be generated.
Lp 1768987: Use FindBin in 24-sql-gettext-unique.t.
Use FindBin in the 24-sql-gettext-unique.t test file so that it can be
run from directories other than Open-ILS/src/perlmods.
To test
-------
[1] Apply the patch.
[2] From the root of the Evergreen checkout, run
prove Open-ILS/src/perlmods/t/24-sql-gettext-unique.t
[3] Verify that the tests pass.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Daniel Pearl [Wed, 12 Dec 2018 17:51:07 +0000 (12:51 -0500)]
LP#1029601: Prevent duplicate holds from double clicks
Double clicking on hold submit buttons causes multiple holds to be
generated. This commits adds code to disable the Submit button(s)
after the first click, so subsequent clicks don't "work" in unintended
ways.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jeff Davis [Fri, 8 Jun 2018 19:09:54 +0000 (12:09 -0700)]
LP#1788680 prevent copy template apply failure on null stat cats
Under some circumstances, the current code can result in a JS failure:
Cannot read property 'filter' of undefined
When this happens, the copy template may apply partially or not at all.
This change simply makes sure cp.stat_cat_entries() exists before
attempting to filter it.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jason Boyer [Mon, 3 Dec 2018 13:11:29 +0000 (08:11 -0500)]
LP1806394: Placing Holds in Item Buckets
A missing return prevents a list of item ids from
being built so no holds can be placed from item
buckets. This branch returns the return to its
proper place.
To test
-------
[1] Add some items to an item bucket, ensuring that they are
all holdable.
[2] From the item bucket interface, select the items and choose
the Request Selected Items action.
[3] Confirm placing the requests.
[4] Note that the requests are not actually created.
[5] Apply the patch and repeat steps #1-#4. This time, the requests
should be placed.
LP#1826890: set page title for Statistical Popularity Badges admin page
To test
-------
[1] In the browser client, navigate to Local Administration -> Statistical
Popularity Badges
[2] Note that the web browser's tab header doesn't display a title for the
page, just the URL.
[3] Apply the patch and reload the page. This time, a page title should
be dispayed in the browser's tab header.
LP#1782014 Fix grid path for Title in patron items out
When the Items Out grid was updated to use display fields, the
displayed title was updated (along with the fleshed data in the
javascript) but the grid "path" was not. This commit fixes the path,
which fixes title sorting. (Title sorting broke because the
simple_record.title was no longer being fleshed in via the JS code, so
the grid was attempting to sort on an empty value.)
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jason Stephenson [Tue, 18 Dec 2018 14:26:11 +0000 (09:26 -0500)]
Lp 1752968: Select content when focusing on the barcode field.
To reproduce the reported behavior:
1. Find a title in the staff client catalog.
2. Click on Add Holdings.
3. See that the Barcode field does not have cursor focus.
4. Repeat step 1.
5. Click on edit next to one of the barcoded items in the list of
holdings.
6. Click Show Holdings Details and see that the Barcode field does
not have focus and the content is not selected.
To test this branch:
1. Find a title in the staff client catalog.
2. Click on Add Holdings.
3. See that the Barcode field has cursor focus, i.e. the cursor is in
the field and blinking.
4. Repeat step 1.
5. Click on edit next to one of the barcoded items in the list of
holdings.
6. Click Show Holdings Details and see that the Barcode field has
cursor focus and the content is selected/highlighted.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Volume transfer did not honor the cat.bib_keep_on_empty organizational
unit setting when removing empty bib records. This commit changes it
so that tranfer honors the setting in the same manner that deleting
copies and volumes does.
To test this fix, set cat.bib_keep_on_empty for your workstation
org. unit to true, and then transfer all of the volumes from one bib
record to another. The empty bib record should not get deleted.
You can also test with the setting on false to make sure that the
empty bib gets deleted.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Beth Willis <willis@noblenet.org>
Jeff Davis [Fri, 5 Apr 2019 18:08:55 +0000 (11:08 -0700)]
LP#1823387: avoid double slashes in booking URLs, which will not work with recent versions of Apache
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Wed, 24 Apr 2019 13:19:40 +0000 (09:19 -0400)]
LP1642036 Group member detail grid query repair
Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc
Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Way back when, we switched from a misspelled 'clense_ISO8601' to a
corrected 'cleanse_ISO8601' in OpenSRF. This function has again moved,
and is now part of OpenILS::Utils::DateTime, and is named
'clean_ISO8601'. This was done as part of LP bug #1552778.
However, a few stragglers of the misspelling remained, so these were
missed when the big changeover occurred. This hopefully catches them
all!
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Mike Rylander [Mon, 31 Jul 2017 19:55:34 +0000 (15:55 -0400)]
LP#1635737 Apply DST-aware timezone to context dates
Do our best to enforce the rule required by OpenSRF's interval_to_seconds
that when a context date is in use, and you care about DST awareness, you
must set the timezone to a DST-aware value, e.g., 'America/New_York'. In
most situations, 'local' will suffice for this, as the server is typically
configured with a DST-aware timezone in its environment. However, we will
look for an org unit setting called 'lib.timezone' and use that where we
can. See LP#1705524 for info on that setting.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/NonCat.pm
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Dan Wells [Fri, 21 Jul 2017 18:28:16 +0000 (14:28 -0400)]
LP#1635737 Use new OpenSRF interval_to_seconds() context
Use the optional context for interval_to_seconds() to account for the
variable length of duration components. For example, "1 day" may be
shorter or longer than 24 hours during a time change event, "1 month"
may be shorter or longer depending on which month it is currently, etc.
Also, remove some timestamp munging, as that happens within
interval_to_seconds() already.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Dan Wells [Tue, 6 Nov 2018 20:13:47 +0000 (15:13 -0500)]
LP#1635737 Add optional context to interval_to_seconds
Any given interval (e.g. "1 month") can be a different amount of
seconds depending on the context (i.e. "1 month" after February 1 is
March 1, but "1 month" after March 1 is April 1, yet March is longer
than February). This affects months all the time, but also can
affect days, hours, and even seconds once you consider DST and "leap"
times.
By giving an optional context to interval_to_seconds, you can find
the true number of seconds in, for example, "1 month", when starting
from "February 1" (the context).
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1789442: turn of Perl taint-checking on 14-OpenILS-Utils.t
This works around a bug in DateTime::TimeZone 1.63
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737265> that
causes one of the new tests to spuriously fail on Ubuntu 14.04 LTS.
As the comment indicates, taint checking is not typically enabled
when running Evergreen, but we may want to consider changing
that should tuits arise.
LP#1789442: fix editing due date of hourly loans in web staff
This patch fixes a bug where editing the due date of an hourly
loan would result in the time portion always getting set to 00:00.
To test
-------
[1] Set up some daily and hourly loans in your database.
[2] Apply the patch.
[3] From the items out page, edit the due date for one or
more hourly loans. Verify that the resulting due date
is set correctly.
[4] From the items out page, edit the due date for some
daily loans and verify correctness. In particular,
verify that the resulting due date is /not/ the
following day if testing in time zones in the Americas.
LP#1552778: add timepicker to webstaff checkout page
This patch adds a timepicker to go along with the datepicker
if the operator invokes the option to set a specific due
date.
To test
-------
[1] Arrange circ policies to have both hourly and daily loans.
[2] Apply the patch.
[3] Check out an item for an hourly loan. Verify that the
due date and time is per policy.
[4] Check out an item for a daily loan. Verify that the
due date is per policy.
[5] Check out an item for an hourly loan, but set a specific
due date and time. Verify that the due date and time matches
the selected value.
[6] Check out an item for a daily loan, but set a specific
due date. Verify that the due date matches the selected
value; note that any time component is ignored since
for daily loans the time gets normalized to 23:59.
LP#1552778: make clean_ISO8601 recognize 'Z' as a timezone specifier
Prior to this patch, clean_ISO8601 would ignore 'Z' as a timezone
specifier (e.g., '2018-09-21T15:34:21Z') and treat it as if the
timestamp were in the server's time zone, leading to incorrect
results (e.g., '2018-09-21T15:34:21-04:00') unless user, client,
and server all happen to be in UTC+0. In particular, this allows
date strings emitted by the JavaScript Date object's toISOString()
method to be correctly parsed, as those strings invariably use
'Z' as the timezone specifier.
To test
-------
[1] Apply patch.
[2] Verify that regression test in t/14-OpenILS-Utils.t passes.
LP#1552778: copy some date/time utils from OpenSRF
As preparation for subsequent bugfixes, this patch
copies several date/time routines from OpenSRF::Utils
to a new module, OpenILS::Utils::DateTime. Specifically,
the routines copied over are:
* clean_ISO8601() (renaming of the OpenSRF cleanse_ISO8601)
* gmtime_ISO8601()
* interval_to_seconds()
* seconds_to_interval()
This move will allow us to fix bugs in this core routines
without requiring a mandatory OpenSRF upgrade. Furthermore,
with the exception of interval_to_seconds() (and in only one
place), none of those routines are used by OpenSRF itself.
To test
-------
[1] Apply the patch.
[2] Verify that unit tests pass.
[3] Verify that all Perl services start correctly.
[4] Verify that date/time and interval calculations continue
to work as expected, particularly in circulation.
Moving from Translate Toolkit 1.10 to 2.0 changed a large number of
strings in backwards incompatible ways, so I think we need to consider
simply freezing translations on 3.1.
This revert is an attempt to recover the existing translations, though
I am not certain it will work.
Remington Steed [Wed, 20 Mar 2019 16:16:54 +0000 (12:16 -0400)]
Docs: Add bugfix release notes for 3.1.11
For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.1.11. Not sure if this is the same as past
point release notes.
Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order
- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org>
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.
We add the call number prefix and suffix as separate columns to the
holds pull list print template. We also add the suffix to the end of
the orderBy so that we also sort by the suffix.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: John Amundson <jamundson@cwmars.org>
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines
The below message repeats in the open-ils.storage_stderr.log:
Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.
This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.
Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected
If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers
Provide call numbers extracted from the MARC record as options in the
volume batch editor. Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.
Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement
Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data. The key benefit is that subfields retain their order
in affected MARC fields. As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached
This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update
Previously, if a volume label was edited, all items attached to that
volume would be essentially affected. Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched. If no copies are
being edited along with a volume, then the volume itself is edited.
Auto-merging of volumes may still happen in all of these scenarios.
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status
The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels
This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID. As a consequence, the
following fields are now available for label templates:
If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.
To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
or more of the new fields listed above; verify that the current
value is displayed on the label preview.
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view
To test:
[1] Locate or create a bibliographic record that has at least
one located URI (e.g., an 856 with a $9 containing an org
unit code)
[2] View the record in the Holdings View in the web staff interface,
with the 'Show empty call numbers' (or volumes) option
selected.
[3] Note that rows are displayed with a call number label of '##URI##';
these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
should not display.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Signed-off-by: James Fournie <jfournie@vcc.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying
This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.
Two paths to test:
Path A)
1. Import a new bib record from z3950, but via "Edit then Import"
2. Bring up marc editor and choose save w/ bib source.
3. Verify chosen bib source saved correctly on record page.
Path B)
1. Mark a record as target for Overlay, go to z3950 import.
2. Make a search, select item for Overlay.
3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
4. Verify chosen bib source saved correctly on record page.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / Evergreen.git / log