9 years agoadded support for selecting individual copy statuses that will prevent checkout at...
erickson [Tue, 20 Jul 2010 21:15:59 +0000 (21:15 +0000)]
added support for selecting individual copy statuses that will prevent checkout at self-check even when the generic copy_not_available event has been overridden to allow for non-standard copy circs from selfcheck.  TODO: ui for managing the list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16990 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPatch from John Craig providing a saner timestamp cleansing setup for backdated circs
miker [Tue, 20 Jul 2010 19:54:38 +0000 (19:54 +0000)]
Patch from John Craig providing a saner timestamp cleansing setup for backdated circs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16986 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobackporting r16982: use the correct table and field, caught by Doug Kyle and reported...
miker [Tue, 20 Jul 2010 15:58:48 +0000 (15:58 +0000)]
backporting r16982: use the correct table and field, caught by Doug Kyle and reported via IRC

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16985 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agomd5 module is deprecated; move to hashlib
erickson [Tue, 20 Jul 2010 12:58:13 +0000 (12:58 +0000)]
md5 module is deprecated;  move to hashlib

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16981 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agouse abs() to get page number in either direction
miker [Mon, 19 Jul 2010 19:03:20 +0000 (19:03 +0000)]
use abs() to get page number in either direction

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16980 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agouse LEFT JOIN to allow a single query to count copies per circ mod
miker [Mon, 19 Jul 2010 15:06:59 +0000 (15:06 +0000)]
use LEFT JOIN to allow a single query to count copies per circ mod

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16979 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoupdated default estimated hold wait display to handle seconds instead of days returne...
erickson [Mon, 19 Jul 2010 14:06:35 +0000 (14:06 +0000)]
updated default estimated hold wait display to handle seconds instead of days returned by the ML API call.  TODO, consider if/how to handle sub-day intervals

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16978 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agowhen calculating estimed hold wait time, don't ignore copies that have no circ modifier
erickson [Mon, 19 Jul 2010 14:06:34 +0000 (14:06 +0000)]
when calculating estimed hold wait time, don't ignore copies that have no circ modifier

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16977 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agorepaired sql syntax for upgrade log commit
erickson [Mon, 19 Jul 2010 12:47:02 +0000 (12:47 +0000)]
repaired sql syntax for upgrade log commit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16975 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoput the null return back, in case that is important on the client side
miker [Sun, 18 Jul 2010 14:44:18 +0000 (14:44 +0000)]
put the null return back, in case that is important on the client side

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16973 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoremove ingest service call from authority import thanks to in-db ingest of auth by...
miker [Sun, 18 Jul 2010 00:21:09 +0000 (00:21 +0000)]
remove ingest service call from authority import thanks to in-db ingest of auth by dbs; send final message with total and count processed; send record counts at most every 3%; rearrange queue cleanup code to aviod needless rollback and cover all queues, not just the first one we test

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16972 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoTeach marc2sre.pl MFHD record ingest script to read a mapping of library names to...
dbs [Sat, 17 Jul 2010 20:53:55 +0000 (20:53 +0000)]
Teach marc2sre.pl MFHD record ingest script to read a mapping of library names to OU IDs

The past approach required workarounds that weren't fun for a library
without in-house scripting expertise; this provides a straightforward
mapping approach with docs and a working sample. Which should be helpful
for all of the libraries that will go with the MFHD serials approach in
the future. Heh.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16971 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSwitch to ingesting authority records automatically via database triggers
dbs [Sat, 17 Jul 2010 20:51:15 +0000 (20:51 +0000)]
Switch to ingesting authority records automatically via database triggers

Taken largely from the existing approach for ingesting biblio records,
there is some duplication here that we could genericize. But for now,
we'll go with the working-but-separate approach to avoid introducing
badness into the relatively stable biblio ingest pipeline.

Also, move some of the existing authority-related functions out of
the metabib schema file and into 999.functions.global.sql.

Finally, the direct_ingest.pl script is no longer necessary for
ingest of authority records, either, so die in that case as well.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16970 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFix schema creation breakage. Damn you dangling commas.
dbs [Sat, 17 Jul 2010 20:45:08 +0000 (20:45 +0000)]
Fix schema creation breakage. Damn you dangling commas.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16969 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd seed for COPY_NEEDED_FOR_HOLD.override permission
gmc [Fri, 16 Jul 2010 20:38:38 +0000 (20:38 +0000)]
add seed for COPY_NEEDED_FOR_HOLD.override permission

Being careful during the upgrade since a fair number of
EG database in the wild had this one added manually.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16968 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoIt is important to update the upgrade_log to prevent collisions and such.
dbs [Fri, 16 Jul 2010 19:55:37 +0000 (19:55 +0000)]
It is important to update the upgrade_log to prevent collisions and such.

Updating config.upgrade_log to 0340.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16967 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoreturn NULL terminator to indicate successful read; fixed typo
erickson [Fri, 16 Jul 2010 19:02:37 +0000 (19:02 +0000)]
return NULL terminator to indicate successful read; fixed typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16966 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoget rid of the chrome instantiated sound object so it's every interface for itself...
phasefx [Fri, 16 Jul 2010 18:28:27 +0000 (18:28 +0000)]
get rid of the chrome instantiated sound object so it's every interface for itself, and have remote xul load server/skin/custom.js instead of chrome

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16965 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agomake --timeout actually work if setting a timeout > 60 seconds
gmc [Fri, 16 Jul 2010 15:53:14 +0000 (15:53 +0000)]
make --timeout actually work if setting a timeout > 60 seconds

Also remove ersatz XML declarations so that XML output
is well-formed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16964 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoserial.record_entry already had an owner column spelled "owning_lib"
dbs [Fri, 16 Jul 2010 15:23:15 +0000 (15:23 +0000)]
serial.record_entry already had an owner column spelled "owning_lib"

Adjust the table and affected function accordingly

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16963 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd the new owner column to the are object in the IDL
dbs [Fri, 16 Jul 2010 14:56:46 +0000 (14:56 +0000)]
Add the new owner column to the are object in the IDL

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16962 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agorearrange while loop to prevent error: Can't 'last' outside a loop block
erickson [Fri, 16 Jul 2010 13:57:15 +0000 (13:57 +0000)]
rearrange while loop to prevent error: Can't 'last' outside a loop block

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16956 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd --timeout switch to marc_export
gmc [Fri, 16 Jul 2010 13:41:53 +0000 (13:41 +0000)]
add --timeout switch to marc_export

Provides way to export bibs with holdings
that have a large number of copies attached.  Default
timeout remains 1 second when exporting bibs; increased
to 300 seconds when exporting holdings based on
empirical tests on a big database.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16955 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agowhitespace consistency improvements
gmc [Fri, 16 Jul 2010 13:25:06 +0000 (13:25 +0000)]
whitespace consistency improvements

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16954 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agouse a left join instead of -not-exists for anti-join -- much faster for large nullabl...
miker [Fri, 16 Jul 2010 02:37:24 +0000 (02:37 +0000)]
use a left join instead of -not-exists for anti-join -- much faster for large nullable-side sets in this case

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16953 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoThis should have been part of r16946. Now the TranslatorPopup works in the
senator [Thu, 15 Jul 2010 22:01:29 +0000 (22:01 +0000)]
This should have been part of r16946.  Now the TranslatorPopup works in the
Copy Location Editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16952 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoHave open-ils.circ.circulation.due_date.update return the circ instead of the circ...
phasefx [Thu, 15 Jul 2010 21:34:21 +0000 (21:34 +0000)]
Have open-ils.circ.circulation.due_date.update return the circ instead of the circ id so that modified rows in Items Out refresh correctly, and have Items Out -> Edit Due Date, -> Renew with Specific Date, and -> Mark Claimed Returned use the date/timepicker dialog

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16951 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agomore configuration options for date/timepicker dialog, and use that dialog with staff...
phasefx [Thu, 15 Jul 2010 21:34:16 +0000 (21:34 +0000)]
more configuration options for date/timepicker dialog, and use that dialog with staff editing of hold thaw date and expire time

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16950 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agowrong variable; could refresh the wrong rows
phasefx [Thu, 15 Jul 2010 21:34:09 +0000 (21:34 +0000)]
wrong variable; could refresh the wrong rows

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16949 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoallow open-ils.circ.hold.update.batch to apply nulls to fields
phasefx [Thu, 15 Jul 2010 21:34:06 +0000 (21:34 +0000)]
allow open-ils.circ.hold.update.batch to apply nulls to fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16948 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd copy circ lib to alternative item details view
phasefx [Thu, 15 Jul 2010 21:34:02 +0000 (21:34 +0000)]
add copy circ lib to alternative item details view

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16947 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agomake openils.widget.TranslatorPopup a little more environment-agnostic
senator [Thu, 15 Jul 2010 21:19:24 +0000 (21:19 +0000)]
make openils.widget.TranslatorPopup a little more environment-agnostic

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16946 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoARG! Missed a semicolon. Perl, be like JS and make them optional. On second thought...
miker [Thu, 15 Jul 2010 20:27:18 +0000 (20:27 +0000)]
ARG! Missed a semicolon. Perl, be like JS and make them optional.  On second thought do not be like JS in any way.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16945 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoreturn # of imported and failed records to the caller
erickson [Thu, 15 Jul 2010 20:10:10 +0000 (20:10 +0000)]
return # of imported and failed records to the caller

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16943 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoProtect authority records from real deletion and add a "merge authorities" function
dbs [Thu, 15 Jul 2010 19:22:19 +0000 (19:22 +0000)]
Protect authority records from real deletion and add a "merge authorities" function

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16942 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agocompanion to "browse", which drops you into the middle of a list centered on your...
miker [Thu, 15 Jul 2010 17:17:53 +0000 (17:17 +0000)]
companion to "browse", which drops you into the middle of a list centered on your input, "startwith" browses only from your input on

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16941 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoDelete links to deleted bib records as part of biblio.indexing_ingest_or_delete()
dbs [Thu, 15 Jul 2010 15:50:58 +0000 (15:50 +0000)]
Delete links to deleted bib records as part of biblio.indexing_ingest_or_delete()

Moves authority.bib_linking cleanup from the special case
of merging bib record assets to the general case of deleting bib records

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16940 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobug 605921: fix bib search hang on queries like "title ; subtitle"
gmc [Thu, 15 Jul 2010 15:15:43 +0000 (15:15 +0000)]
bug 605921: fix bib search hang on queries like "title ; subtitle"

More generally, the fix avoids a to_tsquery exception in cases
where a search term is normalized away to the empty string.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16939 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobug 605884: make MARC expert search of control fields work
gmc [Thu, 15 Jul 2010 13:52:06 +0000 (13:52 +0000)]
bug 605884: make MARC expert search of control fields work

Allows users to search on the 001 and 003 fields, for example.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16938 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoasset.merge_record_assets() needs auth_link declaration (was in upgrade script)
dbs [Thu, 15 Jul 2010 10:24:44 +0000 (10:24 +0000)]
asset.merge_record_assets() needs auth_link declaration (was in upgrade script)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16937 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoOn second thought, delete authority links pointing to stale bib records
dbs [Thu, 15 Jul 2010 10:22:17 +0000 (10:22 +0000)]
On second thought, delete authority links pointing to stale bib records

This avoids the overhead of updating controlled fields in deleted bib records.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16936 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoTeach assets.merge_record_assets() to also merge authority->bib links
dbs [Thu, 15 Jul 2010 09:35:27 +0000 (09:35 +0000)]
Teach assets.merge_record_assets() to also merge authority->bib links

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16935 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAuthority records get some fixed-field love in the MARC Editor
dbs [Wed, 14 Jul 2010 21:08:32 +0000 (21:08 +0000)]
Authority records get some fixed-field love in the MARC Editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16934 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoCSS makes things visible, or not. Display the nascent MFHD fixed-field editor.
dbs [Wed, 14 Jul 2010 19:41:56 +0000 (19:41 +0000)]
CSS makes things visible, or not. Display the nascent MFHD fixed-field editor.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16933 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoWhen returning a list of bind variables: If a default_ or actual_value
scottmk [Wed, 14 Jul 2010 18:55:05 +0000 (18:55 +0000)]
When returning a list of bind variables: If a default_ or actual_value
is undefined for a given variable, leave it out of the JSON object
altogether, rather than create an entry with a JSON null for it.

That way the client can distinguish between an undefined value and
a value defined as null.

M    Open-ILS/src/c-apps/buildSQL.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16932 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSet the 004 of the new MFHD record to the ID of the targeted bib record
dbs [Wed, 14 Jul 2010 15:14:01 +0000 (15:14 +0000)]
Set the 004 of the new MFHD record to the ID of the targeted bib record

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16930 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoIn theory, this would be a step towards MFHD records in the editor looking saner.
dbs [Wed, 14 Jul 2010 15:06:57 +0000 (15:06 +0000)]
In theory, this would be a step towards MFHD records in the editor looking saner.

In practice, the BKS fixed fields are hidden. Sadly, the leader values
for the MFHD record are not displayed either.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16929 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agovalidate.tag.id_list: Return an empty list instead of 0 in the case of no matching...
dbs [Wed, 14 Jul 2010 12:07:19 +0000 (12:07 +0000)]
validate.tag.id_list: Return an empty list instead of 0 in the case of no matching records

This makes it a little easier to handle cases where there was no match,
rather than having to check to see if we have a scalar or a reference
to a list.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16927 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoImprove auto-authority-control processing script:
dbs [Wed, 14 Jul 2010 09:50:16 +0000 (09:50 +0000)]
Improve auto-authority-control processing script:
  * Prevent duplicate $0 subfields from being generated by multiple runs
  * Provide more bib field/subfield -> auth field/subfield mappings
  * Protect against missing bib->auth maps
  * Correct --all option to actually retrieve all undeleted records

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16926 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoBe more relaxed about what we receive in Vandelay (a bad LDR/09 need not lead to...
dbs [Tue, 13 Jul 2010 22:09:19 +0000 (22:09 +0000)]
Be more relaxed about what we receive in Vandelay (a bad LDR/09 need not lead to complete misery)

If MARC::File::XML->as_xml_record() receives a record with anything other
than 'a' in LDR/09 position, it will try to run a MARC8-to-UTF8 conversion
on the record - even though the source file itself was XML and clearly
couldn't have been MARC8.

This code corrects the leader on the fly so that MARC::File::XML won't
try to convert it and throw a "wide character" warning, but the fix
means that something was wrong with the leader to begin with, so we also
write a warning to the log about the situation.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16925 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoremove even more namespace prefixes ... take THAT, IE!
miker [Tue, 13 Jul 2010 20:27:45 +0000 (20:27 +0000)]
remove even more namespace prefixes ... take THAT, IE!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16924 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRelax bib type parsing a little and allow spaces (like the comments promised)
dbs [Tue, 13 Jul 2010 20:12:14 +0000 (20:12 +0000)]
Relax bib type parsing a little and allow spaces (like the comments promised)

Also fix a few drive-by typos

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16923 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoQstore: support LIMIT and OFFSET clauses.
scottmk [Tue, 13 Jul 2010 20:10:37 +0000 (20:10 +0000)]
Qstore: support LIMIT and OFFSET clauses.

Also: add some links to the IDL, that should have been there
in the first place.

M    Open-ILS/include/openils/oils_buildq.h
M    Open-ILS/src/c-apps/oils_storedq.c
M    Open-ILS/src/c-apps/buildSQL.c
M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0336.schema.query-limit-offset-fkey.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16922 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMake maintain_901() more robust in the presence of namespaces
dbs [Tue, 13 Jul 2010 19:03:41 +0000 (19:03 +0000)]
Make maintain_901() more robust in the presence of namespaces

Some records manage to get XML namespace declarations into each element,
like <datafield xmlns:marc="http://www.loc.gov/MARC21/slim"

This broke the old maintain_901(), so we'll make the regex more robust

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16919 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoStub script for adding authority control to an existing set of bibs
dbs [Tue, 13 Jul 2010 15:56:33 +0000 (15:56 +0000)]
Stub script for adding authority control to an existing set of bibs

The goal of this script is to iterate over every bib record listed at
the command line (or --all) and check every controlled bib field for
matching subfield combinations in authority records. This is going to
be slow, friends, but for this iteration we're looking at paying a
one-time cost; after that, controlled fields will automatically be
maintained by triggers on the authority.record_entry tables.

The bib field-to-auth field mapping needs to be fleshed out (should
be comparable to the mapping in marcedit.js) and floating subdivisions
still need to be controlled. Probably in a separate pass over the bibs,
given the current "design".

We extend open-ils.s*.authority.validate.tag to offer an id_list() variant
so that we can get the corresponding authority record ID back from the
call, instead of just a count.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16918 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd limit_count and offset_count columns to query.stored_query table.
scottmk [Tue, 13 Jul 2010 12:44:49 +0000 (12:44 +0000)]
Add limit_count and offset_count columns to query.stored_query table.

M    Open-ILS/src/sql/Pg/002.schema.config.sql
M    Open-ILS/src/sql/Pg/008.schema.query.sql
A    Open-ILS/src/sql/Pg/upgrade/0334.schema.query-limit-offset.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16917 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd 100$e (relator) and 711$c (Location of meeting) to controlled field map
dbs [Tue, 13 Jul 2010 11:25:17 +0000 (11:25 +0000)]
Add 100$e (relator) and 711$c (Location of meeting) to controlled field map

We'll probably flesh this out further as we get more serious about authority
control, but these ones stood out in our initial testing.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16916 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoWhitespace consistency for Vandelay
dbs [Mon, 12 Jul 2010 20:58:36 +0000 (20:58 +0000)]
Whitespace consistency for Vandelay

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16915 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoPrevent MARC batch import from blindly trusting the user by checking LDR/06
dbs [Mon, 12 Jul 2010 20:51:59 +0000 (20:51 +0000)]
Prevent MARC batch import from blindly trusting the user by checking LDR/06

With this commit, Vandelay will now check the leader of the incoming MARC
record to ensure that its MARC type matches the indicated import record
type. This is useful, for example, if you have a mixed set of bib & holdings
records that you want to import; you don't want to import the holdings records
as bib records.

This is a fairly strict implementation; we could relax this by turning the
check on its head and allowing the import as the user-indicated type as long
as the LDR/06 doesn't explicitly match another record type.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16914 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMake a translate button available in the name column of copy locations editor
senator [Mon, 12 Jul 2010 19:24:28 +0000 (19:24 +0000)]
Make a translate button available in the name column of copy locations editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16913 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoprintable_output() for the patron editor, given that printing the Dojo here is proble...
phasefx [Mon, 12 Jul 2010 18:12:55 +0000 (18:12 +0000)]
printable_output() for the patron editor, given that printing the Dojo here is problematic

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16912 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoprinting the contents of iframes is sometimes problematic, especially with complex...
phasefx [Mon, 12 Jul 2010 18:12:50 +0000 (18:12 +0000)]
printing the contents of iframes is sometimes problematic, especially with complex DHTML, etc.  This change allows content to define a printable_output() function for simple text to print instead of the rendered content itself

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16911 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoprotect against deletion of serial.unit rows
gmc [Mon, 12 Jul 2010 17:09:23 +0000 (17:09 +0000)]
protect against deletion of serial.unit rows

Rules are not inherited by child tables, so must
add one explicitly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16910 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agocache OPAC-visibility of copies and bibs
gmc [Mon, 12 Jul 2010 16:08:14 +0000 (16:08 +0000)]
cache OPAC-visibility of copies and bibs

Create a new "materialized view" table, asset.opac_visible_copies,
for use during the copy visibility check during OPAC searches.  This
is used by search.query_parser_fts(), replacing a check of a five-table
join for each bib in the search results that proved to be far
too slow on some large databases.

This table is maintained by triggers on inserts and updates to the
following tables:


During a migration or large global change operation, it is recommended
that those triggers be disabled.  To (re)populate the materialized
view, do

SELECT asset.refresh_opac_visible_copies_mat_view();

Thanks to Mike Ryladner for his help with this.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16909 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSeveral fixes for authority-controlled field and control number syncing
dbs [Mon, 12 Jul 2010 15:11:45 +0000 (15:11 +0000)]
Several fixes for authority-controlled field and control number syncing

The fix for maintain_control_numbers() was committed earlier, but wasn't
part of a new upgrade script; this will ensure that everyone following
trunk picks up the correction.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16908 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoNFC() needs Unicode::Normalize - strange that this didn't come up in previous testing
dbs [Mon, 12 Jul 2010 10:03:24 +0000 (10:03 +0000)]
NFC() needs Unicode::Normalize - strange that this didn't come up in previous testing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16907 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofacet query correction
miker [Mon, 12 Jul 2010 00:02:49 +0000 (00:02 +0000)]
facet query correction

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16906 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agothinko in upgrade script
miker [Sun, 11 Jul 2010 23:41:36 +0000 (23:41 +0000)]
thinko in upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16905 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agobreak facets out to a separate table for speed
miker [Sun, 11 Jul 2010 23:35:00 +0000 (23:35 +0000)]
break facets out to a separate table for speed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16904 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agodojo == elegant; refactor cursor up/down and hide fixed fields in MARC editor
dbs [Fri, 9 Jul 2010 21:58:33 +0000 (21:58 +0000)]
dojo == elegant; refactor cursor up/down and hide fixed fields in MARC editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16903 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoNew feature: maintain control numbers (001, 003, 035) for MARC records
dbs [Fri, 9 Jul 2010 15:42:54 +0000 (15:42 +0000)]
New feature: maintain control numbers (001, 003, 035) for MARC records

If a site wishes to maintain their control numbers and control number
identifiers in authority, bibliographic, and MFHD MARC records according
to the MARC21 specification, they will now be able to:

1. Enable the global flag 'cat.maintain_control_numbers' to turn on
control number maintenance. This is disabled by default, so no changes
will be made by the system until the flag is enabled.

2. (Optionally) Set the cat.marc_control_number_identifier OU setting
to override the control number identifier for records owned by that OU;
if this is not set, then the control number identifier defaults to the
OU shortname.

3. Set the owner field for the records that are to be controlled; otherwise
they will fall back to the global default which is currently hardcoded as

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16899 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoRestore whitespace consistency (spaces not tabs)
dbs [Fri, 9 Jul 2010 15:00:16 +0000 (15:00 +0000)]
Restore whitespace consistency (spaces not tabs)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16898 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoInitial support for wrapping long subfields in the MARC editor
dbs [Fri, 9 Jul 2010 14:59:20 +0000 (14:59 +0000)]
Initial support for wrapping long subfields in the MARC editor

Limitations of the current approach are that the line width is arbitrarily set
to break at 100 characters, and is only calculated on a per-subfield basis. So
if a given field contains 50 subfields, each with 90 characters, this commit
isn't going to help you. (But really... in that scenario, you're beyond help

Also, the double-dagger aligns itself at the top of the box rather than the
middle once the box goes into multiline mode, which is annoying; but long 505
fields that scroll ten screens to the right are more annoying, so I'll commit
this for now rather than waste more time trying to CSS it into shape.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16897 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd support for switching between xul and textarea marc editors
miker [Fri, 9 Jul 2010 14:34:47 +0000 (14:34 +0000)]
add support for switching between xul and textarea marc editors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16896 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agovandelay.dtd already includes the arrows in the entity definition for next/previous...
dbs [Fri, 9 Jul 2010 12:06:13 +0000 (12:06 +0000)]
vandelay.dtd already includes the arrows in the entity definition for next/previous page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16895 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoSuperCat requests for plain marcxml were returning holdings / links
dbs [Fri, 9 Jul 2010 10:01:44 +0000 (10:01 +0000)]
SuperCat requests for plain marcxml were returning holdings / links

This could cause "great fun" in the MARC editor as a bib record suddenly
grew volume and xhtml:link elements; everything would spiral downward
from there.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16894 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agofix initial subfield detection bug
miker [Thu, 8 Jul 2010 19:31:50 +0000 (19:31 +0000)]
fix initial subfield detection bug

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16891 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadd sig handler back in for alarm. log error when read times out from alarm
erickson [Thu, 8 Jul 2010 18:35:15 +0000 (18:35 +0000)]
add sig handler back in for alarm.  log error when read times out from alarm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16888 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoGive the "About" button a legitimate accesskey
dbs [Thu, 8 Jul 2010 18:29:05 +0000 (18:29 +0000)]
Give the "About" button a legitimate accesskey

r15562 contained a fix for this to rel_1_6_0, but apparently I never
forward-ported that "fix". Unfortunately, this leads to broken interfaces in
the i18n build (bug re-found by Robert Souilliere in the release).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16887 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFixes Mark Claimed Returned. It seems that dojo isn't the only library picky about...
phasefx [Thu, 8 Jul 2010 17:09:36 +0000 (17:09 +0000)]
Fixes Mark Claimed Returned.  It seems that dojo isn't the only library picky about ISO8601; DateTime::Format::ISO8601->parse_datetime was choking in this case

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16886 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAcq: try looking up jacket image by UPC if ISBN is not available
senator [Thu, 8 Jul 2010 15:58:49 +0000 (15:58 +0000)]
Acq: try looking up jacket image by UPC if ISBN is not available

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16885 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoReclaim cataloguing real estate by hiding unnecessary rows in fixed field grid editor
dbs [Thu, 8 Jul 2010 15:32:59 +0000 (15:32 +0000)]
Reclaim cataloguing real estate by hiding unnecessary rows in fixed field grid editor

The fixed field grid editor currently shows blank rows for fixed field
attributes that don't apply to the currently displayed MARC record type. We
can hide these rows and offer more screen real estate for the MARC record

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16884 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agorecord the billing_last and billing_first fields from bill_cc_info.xul into cc_first_...
phasefx [Thu, 8 Jul 2010 15:25:15 +0000 (15:25 +0000)]
record the billing_last and billing_first fields from bill_cc_info.xul into cc_first_name and cc_last_name on money.credit_card_payment, even for out-of-band (externally processed) payments.  Also protect the bill_cc_info dialog from patrons with no billing address (such as admin)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16883 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAcq: If you go from a catalog record to "View/Place orders", there are now
senator [Thu, 8 Jul 2010 15:11:24 +0000 (15:11 +0000)]
Acq: If you go from a catalog record to "View/Place orders", there are now
easy shortcuts for adding a new lineitem to a selection list or a PO if there
aren't already any existing lineitems to work with.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16881 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoStreamline pcrud a bit.
scottmk [Thu, 8 Jul 2010 14:56:37 +0000 (14:56 +0000)]
Streamline pcrud a bit.

If there is a permacrud entry for the relevant action, but the list of
permissions is empty, we grant access.

The change: grant access as soon as the permission list can be known
to be empty, instead of doing a lot of irrelevant stuff first
(including extra database fetches in some cases).

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16880 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoinstead of reading the MARC data directly from the socket, set the end-of-line charac...
erickson [Thu, 8 Jul 2010 14:31:46 +0000 (14:31 +0000)]
instead of reading the MARC data directly from the socket, set the end-of-line character appropriately and read the data directly from STDIN.  The 'wait' time is now only used as a security measure to prevent accidental hogging of worker processes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16879 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoEnable plain up-arrow and down-arrow to jump to next row in MARC editor
dbs [Thu, 8 Jul 2010 14:15:04 +0000 (14:15 +0000)]
Enable plain up-arrow and down-arrow to jump to next row in MARC editor

As TAB/shift-TAB move between each editable element of the MARC record,
we already have fine-grained keyboard navigation. However, moving down
10 data fields requires around 50 TAB presses or more, depending on how
many subfields are in the intervening data fields, or a looonng hold of
the tab key; not good for RSI.

The up-arrow and down-arrow keys, then, move directly to the next or
previous row, placing the focus in the first editable subfield element
rather than in the tag name (under the assumption that cataloguers are
most likely to want to edit the contents of a given subfield, and not
the tag name or indicators).

Now, in the worst-case scenario, a cataloguer who wants to edit the tag
name of a field 10 rows below their current position will have to
make 14 key presses (10 down arrows, 4 shift-TABs). Not too shabby.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16878 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agocolumn tweaks. If you already ran 0328, see comments at top
phasefx [Thu, 8 Jul 2010 14:11:06 +0000 (14:11 +0000)]
column tweaks.  If you already ran 0328, see comments at top

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16877 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadding a cc_name field to money.credit_card_payment to hold the human name on the...
phasefx [Thu, 8 Jul 2010 13:40:01 +0000 (13:40 +0000)]
adding a cc_name field to money.credit_card_payment to hold the human name on the credit card

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16876 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agohold/transit data in Item Status->Alternate View->Holds/Transit
phasefx [Thu, 8 Jul 2010 13:24:17 +0000 (13:24 +0000)]
hold/transit data in Item Status->Alternate View->Holds/Transit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16875 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agopopulate some fields in Item Status->Alternate View->Circulation History->Most Recent...
phasefx [Thu, 8 Jul 2010 13:24:13 +0000 (13:24 +0000)]
populate some fields in Item Status->Alternate View->Circulation History->Most Recent Circ Group when we're not bothering to retrieve the circ chain

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16874 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoFix a bug in pcrud.
scottmk [Thu, 8 Jul 2010 03:32:13 +0000 (03:32 +0000)]
Fix a bug in pcrud.

When checking a row for permissions, we often read a fresh copy of the
row in order to ensure that we have all the foreign keys that we need.
However in some cases (mainly when the class is a view), there is no
primary key, so we can't re-read the row.

Solution: if there is no primary key, don't try to do a fresh read.
Use the row image that we already have.

For these cases, this solution re-creates the possibility that we may
not have all the necessary columns.  There's no good way around that

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16873 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoLost my commit msg the first time around, so...
phasefx [Wed, 7 Jul 2010 18:48:38 +0000 (18:48 +0000)]
Lost my commit msg the first time around, so...

This CGI script might be useful for providing an easy way for EZproxy to authenticate users against an Evergreen instance.

For example, if you modify your eg_vhost.conf by adding this:
<Directory "/openils/var/cgi-bin/ezproxy">
    AddHandler cgi-script .pl
    AllowOverride None
    Options +ExecCGI
    allow from all

and make that directory and copy remoteauth.cgi to it:
mkdir /openils/var/cgi-bin/ezproxy/
cp remoteauth.cgi /openils/var/cgi-bin/ezproxy/

Then you could add a line like this to the users.txt of your EZproxy instance:


git-svn-id: svn://svn.open-ils.org/ILS/trunk@16872 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoMerge branch 'browser'
phasefx [Wed, 7 Jul 2010 18:44:13 +0000 (18:44 +0000)]
Merge branch 'browser'

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16871 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoForward port of r16867: add missing event definition required by vandelay authority...
miker [Wed, 7 Jul 2010 17:13:41 +0000 (17:13 +0000)]
Forward port of r16867: add missing event definition required by vandelay authority import

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16870 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agodefine these variables as parameters
phasefx [Wed, 7 Jul 2010 14:25:05 +0000 (14:25 +0000)]
define these variables as parameters

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16866 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadded OPAC support for 1) selecting SSL manually and having it stick and 2) forcing...
erickson [Wed, 7 Jul 2010 13:46:37 +0000 (13:46 +0000)]
added OPAC support for 1) selecting SSL manually and having it stick and 2) forcing SSL when the user is logged in to protect auth tokens and other private data.  The latter option is enabled via new apache env variable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16865 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoupdated call number browse pass-thru to accommodate new copy location and status...
erickson [Wed, 7 Jul 2010 02:13:19 +0000 (02:13 +0000)]
updated call number browse pass-thru to accommodate new copy location and status filters

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16864 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoadding status/copy_location filter support to call number browse
miker [Wed, 7 Jul 2010 00:29:37 +0000 (00:29 +0000)]
adding status/copy_location filter support to call number browse

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16863 dcc99617-32d9-48b4-a31d-7c20da2025e4

9 years agoAdd new program test_qstore, a command-line utility for testing
scottmk [Tue, 6 Jul 2010 21:08:08 +0000 (21:08 +0000)]
Add new program test_qstore, a command-line utility for testing
and exercising most of the code for the qstore server.

A    Open-ILS/src/c-apps/test_qstore.c
M    Open-ILS/src/c-apps/Makefile.am

git-svn-id: svn://svn.open-ils.org/ILS/trunk@16862 dcc99617-32d9-48b4-a31d-7c20da2025e4