Jason Etheridge [Thu, 7 Apr 2022 16:06:17 +0000 (12:06 -0400)]
LP1857910 add org family selector to field doc UI
If we want this to default to workstation org or something, we can do that, though I was having trouble
getting that to work. Right now it'll include all orgs in its default unselected state. I'm also not
sure about i18n-labelText and whether that works with eg-org-family-select.
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Bill Erickson [Mon, 17 Aug 2020 21:29:50 +0000 (17:29 -0400)]
LP1857910 Field doc UI Angular 10 updates
Modify the lazy loader to use the new Ang10 style loading syntax.
Avoid using template variables as output variables for other components,
since template variables (those declared with let-foo="bar" in
<ng-template/>) are read-only, possibly as of Ang 10, so the page was
not loading at first.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Kyle Huckins [Wed, 8 Jan 2020 18:04:11 +0000 (18:04 +0000)]
lp1857910 Field Documentation Port
- Port grid UI allowing the creation and editing of Field
Documentation from DOJO to Angular
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.module.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Wed, 11 May 2022 22:55:21 +0000 (15:55 -0700)]
LP#1946531: use batch method to add users to bucket via User Buckets UI
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#1970486: fix SuperCat crash on serial units with stat cats
This patch fixes a bug where retrieving a title via SuperCat (in
particular, with holdings XML) can crash of the title has a serial
unit (i.e., barcoded serial item) attached that also has a statistical
category.
To test
-------
[1] Create a title with a barcoded serial item.
[2] Attempt to fetch the title via SuperCat:
[3] Note that an internal server error is returned.
[4] Apply the patch and repeat step 2. This time, an XML
document should be returned that includes the serial item
and its stat cat.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
This patch moves the buttons for each list row underneath the title and descriptions fields.
It makes the create list form collapsible using a button.
If there are lists, the create form is collapsed.
The create form is expanded on load, if the user selects move bucket to new list, or add rec to new list from a menu or button from another page.
The "Move contents of basket to this list?" in the creation form now defaults to 'yes' if an option to move a basket to a new list is chosen from a menu.
It adds localization functions to the button texts and removes a dangling </div> in anon-list.tt2
It moves the create form from a <table> design and uses Bootstrap elements instead.
To Test.
1. After applying the patch view the list page and notice that the form is expanded.
2. Create a list. The form is now collapse.
3. Perform a search and add some of the titles to a basket.
4. From one of the result rows drop-down the Add to My List menu and select 'Add to New List'.
The form is expanded and the "Move contents of basket to this list" should be 'yes'.
5. From the basket screen or from the lists screen click on the 'Add to New List' button. The results should be the same as step 4.
6. After creating a few lists, notice that the buttons for each list are now displayed under the list title and description and
each row is distinguished by a bottom border.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Bill Erickson [Tue, 19 Apr 2022 17:27:17 +0000 (13:27 -0400)]
LP1956626 Copy editor loads all needed copy locations
The item-location-select component now allows the caller to pass in a
set of context org unit IDs (in lieu of just a single id) for loading
copy locations across different areas of the org unit tree (without
having to load *all* copy locations).
Changes applied to the Angular copy location editor to pass the needed
context org units to the item location select component.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Galen Charlton [Wed, 10 Nov 2021 15:06:36 +0000 (10:06 -0500)]
LP#1950468: make Replace Barcode from Item Status detect duplicate barcodes
This patch makes the Replace Barcode action when invoked from
Item Status properly detect and warn if the replacement barcode
is a duplicate of one already found in the system. This is a complement
to the fix for bug 1890498.
To test
-------
[1] Enter an item barcode into Item Status.
[2] Try 'Replace Barcode' from detail view and set the
replacement barcode to one that is already active in
Evergreen. Note that the dialog closes without
updating the barcode or warning about the duplicate and
that a error is logged in the browser console.
[3] Repeat step 2, but this time from list view. Note
the problem remains the same.
[4] Apply the patch and repeat steps 2 and 3. Note that
now the dialog will remain open and will display an
error message complaining about the duplicate barcode.
Mike Rylander [Fri, 8 Apr 2022 15:10:35 +0000 (11:10 -0400)]
LP#1967770: Followup fix for cover image directories
In the initial fix we checked for the top level cover image location and
error out if it's not there, but this is unnecessary since it will be
created if it doesn't yet exist.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
This update fixes an error when trying to process a 755 tag in
and authority record that has a source set.
See the discussion on the listserv at:
https://georgialibraries.markmail.org/thread/rmwcxkwjzv2qczmu
To test, try to import the sample authority record provided
by Linda Jansova (https://markmail.org/thread/2ay3j4wg7fecymhz)
in evergreen, and see the log files for the import errors.
It is also possible to test from the command line.
In /openils/var/xsl, copy the example autority marc xml file to
that directory, name it americ.xml, then run the command
xsltproc ./MARC21slim2MADS.xsl ./americ.xml
This will error out.
After patch has been applied, try importing the sample authority
record and see that it imports successfully.
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
LP#1942240 Insufficient color contrast in boostrap forms
Overrides the bootstrap form-control border color. Also changes the
border_standard color in colors.tt2 which is used for the border
around some form elements.
After this patch is applied the color ratio is 3.54:1
Garry Collum [Mon, 17 Jan 2022 18:05:37 +0000 (13:05 -0500)]
LP1958163 Bootstrap Opac: the 'Request a Card' link.
This fixes the 'Request a Card' link which displays in the bootstrap opac
regardless of the 'Allow Patron Self-Registration' library setting in both
the login page and the login modal.
To Test:
1. Click on My Account in the Bootstrap Opac to open the login modal.
Notice the Request a Card link. Click Login without adding a barcode
or pin# to see the login page with its link.
2. Set the Allow Patron Self_Registration library setting to false for the
Consortium.
3. Repeat 1, and notice that the link still displays.
4. Apply the patch.
5. Now the link should not be visible in both forms.
6. Set the library setting to true, to verify that the link does display.
Josh Stompro [Thu, 28 Feb 2019 15:43:49 +0000 (09:43 -0600)]
LP#1778783 - Circulate.pm fix log_me correct barcode var
The log_me sub wasn't using the correct variable for showing the entered
barcode. It should be $self->copy_barcode instead of $self->barcode.
Testing Notes:
Before fix:
1. Watch the logs with something like
tail -f osrfsys.log | fgrep 'circulator: do_permit()'
2. Perform a checkout of a non-existant barcode.
3. Notice that the entered barcode is missing after 'copy='
After fix:
1. Restart the circ openils service
osrf_control -l --service open-ils.circ --restart
2. Watch the logs.
3. Perform a checkout of a non-existant barcode.
4. Notice that the barcode is now shown after 'copy='
Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Terran McCanna [Mon, 31 Jan 2022 19:29:16 +0000 (14:29 -0500)]
LP1958265 Angular Holds Grids Not Printing Barcode
This adds the ability to print (or download CSV) the Current Item
and Requested Item barcodes from the Holds Pull List and from the
Holds tab of the bib record.
Jason Stephenson [Fri, 11 Feb 2022 14:44:55 +0000 (09:44 -0500)]
LP1959904: Fix Angular Profile Select Component
The Angular profile select component has a bug when permission group
tree display entries are used. It will loop forever if the grp and
parent have the same value in permission.grp_tree_display_entry
because it is comparing permission group tree entries to permission
group tree display entries in the groups filter of the grpLabel
function.
This patch adds a ternary operator to compare display entries to
display entries and group tree entries to group tree entries in a
manner identical to how the parent value is determined a few lines
above.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Garry Collum [Thu, 13 Jan 2022 20:02:34 +0000 (15:02 -0500)]
LP1920039-Bootstrap Opac: More Details button doesn't change on use.
The 'More Details' button in a bib record in the Bootstrap Opac should change
to say 'Less Details' when pressed. This patch fixes that behavior.
To Test.
1. Go to a bib record in the boostrap opac.
2. Press "More Details"
3. Notice the button still displays "More Details"
4. Apply the patch and repeat.
5. The button should now toggle between "More Details" and "Less Details"
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
The cover image upload test assumes that it will be run from exactly one
location, but that's not necessarily true. This commit uses FindBin to
provide the right filesystem context for the test to find the files it
needs.
[Code by Galen, commit message by Mike]
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Tue, 15 Mar 2022 13:39:54 +0000 (09:39 -0400)]
LP 1964963: Improve Customization of BOOPAC topnav logo
Move the anchor for the topnav logo from topnav_links.tts to
topnav_logo.tt2. This minor change means that those who wish to move
or remove the topnav logo will have fewer files to change and those
changes will be less likely to conflict with future changes to BOOPAC.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Rogan Hamby [Wed, 23 Feb 2022 18:55:01 +0000 (13:55 -0500)]
This feature supplies the ability to create alternate templates for Action Triggers
that will generate locale specific out for Action Triggers. If you send notices in
multiple languages, we recommend putting some words to that effect in your notice
templates. The template, message and message title can all be localized. To use the
feature the following new UI elements have been added:
- When you double-click on an Event Definition under Notifications / Action Triggers
to edit it there will be a tab option for Edit Alternate Template if the reactor is
ProcessTemplate, SendEmail or SendSMS.
- In the Patron Registration and Patron Editor screens staff members may now select a
locale for a patron and edit it in the Patron Preferred Language field.
- Patrons may set their own locale in the My Account interface off the OPAC by going to
Preferences -> Personal Information and setting the Preferred Language field.
The templates used on the Edit Definition tab are the defaults that are used if there are
no alternate templates available that match the preferred language. If alternate templates
are available the system will use a locale that is an exact match and then if failing that
use one where the language code matches and then fall back to the default one.
For example, if a patron has a locale of fr-CA and there are templates for both fr-CA and
fr-FR it will use the fr-CA. If the fr-CA template was deleted it would fall back on using
the fr-FR for the patron since it at least shares the same base language.
Valid locales are the codes defined in the i18n_locale table in the config schema.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
This commit improves the logic needed to control record inclusion in
OAI Sets. Sets for bib records are currently based on copy visibility,
Located URI visibility, or bib source. Generally useful combinations
are generated for item, Located URI, and transcendant [sic] bib sources.
Sets for authority records are based on the browse axis of the heading
for the record.
All generated Sets for bib records currently test for effective search
visibilty on the three described components.
In order to retrieve item data from a specific branch of the org tree,
a harvester must use a Set that contains COPIES:. The hierarchial
shortnames of the org units follow the colon, so in a freshly installed
system a Set with the setSpec of COPIES:CONS:SYS2:BR3 will retrieve all
bib records that have visible copies at BR3, and include only the item
data for that org unit.
To retrieve records with Located URIs, which behave in the heirarchical
reverse of copies by limiting display to those org units "inside" the
branch of the tree where the licensing "lives", a harvester should
supply a setSpec with an org unit shortname that would display the
Located URI. For example: LURIS:CONS:SYS2:BR3
Note: the LURI: org unit is also used to restrict any item data that may
be available for LURI-filtered records.
To retrive records are in a transcendant [sic] bib source, a harvester
can used a setSpec starting with SOURCES: followed by the source name.
To harvest all records, including deleted records, simply omit the
setSpec from the request. All item data will be included.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP#1729620: (follow-up) do not suggest timestamp manipulation
The suggestion in the upgrade script and the release notes
to consider adding triggers to update biblio.record_entry.timestamp
upon updates of linked call numbers or items is not a good one:
[1] implementing it means that any workflows that require knowing
when a bib itself has changed become untrustworthy
[2] it would cause tremendous bloating of auditor.biblio_record_entry_history,
as every single change to an item -- including ones caused by
circulation activity -- would result in a new entry.
[3] item changes due to circulation activity aren't necessarily
going to want to trigger record updates by the harvester
Wanting the update timestamp for OAI harvest to reflect changes
to items is a perfectly valid use case, but this is not the way.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP#1729620: (follow-up) move OAI methods to open-ils.supercat
A new service isn't really necessary for the handful
of methods that OAI support needs. Since SuperCat is
where other record harvesting and export methods live, what
was open-ils.oai is moved to SuperCat via this patch.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
* Perl no longer allows the `keys` function to take scalar expressions
* Typo in service name in opensrf_core example config file
* Added oai schema script to the manifest file so that it is run as part of installation
* Unnecessary sigil
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
- Rename DB schema file to follow convention
- Remove optional DB commands, and leave them in Release Notes (and
possibly add to Official Docs)
- Create DB upgrade script
- Print optional DB commands using \qecho
- Change variable "tcn" to "rec_id" everywhere
- Move perl API registration to be immediately after related function
- Remove unused parameter from sub oai_list_retrieve() in
Application/OAI.pm, and from API calls in WWW/OAI.pm
- Fix mislabeled parameter in API doc
- Add missing end-comment tags in opensrf.xml.example
- Add dependency to Ubuntu/Debian makefiles
- Add missing init handler in apache/eg.conf.in
- Fix reference to sysconfdir in apache/eg_startup.in
- Undo extraneous change to .gitignore
- Trim/rename release notes, since most of the install process is
handled via Evergreen install instructions.
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Lucien van Wouw [Thu, 2 Nov 2017 14:14:51 +0000 (15:14 +0100)]
LP#1729620 New optional feature: an OAI2 provider service.
This module is an opensrf service that exposes bibliographic and authority records through the OAI2 protocol.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Lucien van Wouw, IISG, Amsterdam. Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Boyer [Thu, 15 Oct 2020 17:50:18 +0000 (13:50 -0400)]
LP1900005: Don't require a specific 'opensrf' user
There's no technical reason to require a specific user beyond our
instructions stating that it's the default. One thing that we should
do is not allow our network services to be run as root.
Additionally, autogen.sh is excluded from running as root because while
that would work, it may then have to *always* be run by root or
require you to change the file owner between runs.
NOTE: We check for the user by id rather than name, as there's no rule
saying user 0 must be called "root" on Linux.
NOTE: This also cleans up and unifies the the coding style and removes
some dead code in autogen.sh.
To test:
Pre-patch:
Use oils_ctl.sh to start SIP or z3950 as opensrf, Success.
Use oils_ctl.sh to start SIP or z3950 as yourself, Failure.
Use oils_ctl.sh to start SIP or z3950 as root, Failure.
Run autogen.sh as opensrf, Success.
Run autogen.sh as yourself, Failure.
Run autogen.sh as root, Failure.
Post patch:
Use oils_ctl.sh to start SIP or z3950 as opensrf, Success.
Use oils_ctl.sh to start SIP or z3950 as your normal user, Success.
Use oils_ctl.sh to start SIP or z3950 as root, Failure.
Run autogen.sh as opensrf, Success.
Run autogen.sh as yourself, potential Success - IF you're able to write to the correct directory / files.
Run autogen.sh as root, Failure.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Terran McCanna [Wed, 2 Jun 2021 19:29:53 +0000 (15:29 -0400)]
LP1930614 Bootstrap OPAC Summary Block
This breaks out the summary (from the 520 field) from the rest
of the MARC data so that it displays above/outside of the More
Details button on the record page.
Bill Erickson [Thu, 20 Jan 2022 21:16:10 +0000 (16:16 -0500)]
LP1958581 Angular Grid Copy To Clipboard
To test, right click on a row in an Angular grid. A dialog should
appear which allows the user to click on a value to select the value
into the clipboard. Once selected, the dialog should close.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Garry Collum [Thu, 3 Feb 2022 22:57:45 +0000 (17:57 -0500)]
LP#1959405: hold status not looking for shelf delay status
This patch fixes the blank status display in the opac by treating that
status as a 'Waiting for Copy' status. This commit covers both the TPAC
and the Bootstrap OPAC.
To Test:
As stated by Erica in LP1959405
1. Administration->Local Administration->Library Settins Editor
set Hold Shelf Status Delay to 1 minute.
2. Place a hold for a patron
3. Capture the hold.
The opac will change from "Waiting for Copy" to a blank column.
4. Allow the delay interval to expire
The opac will change from a blank status to "Available"
5. Apply the patch
6. Repeat 2-3.
The opac will continue to display "Waiting for Copy"
7. Allow the delay interval to expire
The opac will change from "Waiting for Copy" to "Available"
Jason Stephenson [Thu, 30 Dec 2021 15:17:58 +0000 (10:17 -0500)]
LP1883171 & LP1940663: Add release notes
This work was sponsored by NOBLE.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Tue, 23 Nov 2021 03:09:26 +0000 (22:09 -0500)]
LP1883171 & LP1940663: Add Perl live test
Add live tests to test that invetory dates are added, or not, during
checkin and inventory update as appropriate. These tests cover the
basics for the backend Perl methods. The database tests are slightly
more thorough.
This work was sponsored by NOBLE.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Modify the Item Staus view to check the new return values of the
update copy inventory function.
Fix toast handling in the list view to properly report success and failure.
Add toast handling to the single copy Item Status view to report
success and failure.
NOTE: More work could be done on the toasts to report number of
successful updates, etc. I tried using the compileContent and trusted
HTML, but this lead to new errors that I couldn't decipher.
This work was sponsored by NOBLE.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Sun, 31 Oct 2021 20:14:10 +0000 (16:14 -0400)]
LP1883171 & LP1940663: Replace circ method to update latest inventory
Replace the open-ils.circ.circulation.update_latest_inventory method
with open-ils.circ.circulation.update_copy_inventory.
Beyond renaming the method and changing the tables it operates on, the
following changes are also made:
1. Use savepoints to allow some updates to succeed when others fail.
2. Modify the return value to include success and failure counts so that
these could potentially be used in client feedback.
This work was sponsored by NOBLE.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Sun, 31 Oct 2021 19:18:22 +0000 (15:18 -0400)]
LP1883171 & LP1940663: Modify do_checkin for asset.copy_inventory
Modify the do_chekin method of Circulate.pm to create a new
asset::copy_inventory object when the do inventory modifier is used.
This change necessitates moving the check for a floating copy up to
where the do inventory code is run and subsequent modifications to the
transit and noop checkin code.
Set checkin_changed to true when adding an asset.copy_inventory entry
during check-in so that even if there would otherwise be a NO_CHANGE
response, the row will still get created.
This work was sponsored by NOBLE.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / Evergreen.git / log