Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels
This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID. As a consequence, the
following fields are now available for label templates:
If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.
To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
or more of the new fields listed above; verify that the current
value is displayed on the label preview.
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view
To test:
[1] Locate or create a bibliographic record that has at least
one located URI (e.g., an 856 with a $9 containing an org
unit code)
[2] View the record in the Holdings View in the web staff interface,
with the 'Show empty call numbers' (or volumes) option
selected.
[3] Note that rows are displayed with a call number label of '##URI##';
these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
should not display.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Signed-off-by: James Fournie <jfournie@vcc.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying
This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.
Two paths to test:
Path A)
1. Import a new bib record from z3950, but via "Edit then Import"
2. Bring up marc editor and choose save w/ bib source.
3. Verify chosen bib source saved correctly on record page.
Path B)
1. Mark a record as target for Overlay, go to z3950 import.
2. Make a search, select item for Overlay.
3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
4. Verify chosen bib source saved correctly on record page.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jane Sandberg [Thu, 27 Sep 2018 14:53:35 +0000 (07:53 -0700)]
LP1782652: Make template dropdown larger in Volume/Copy Editor
To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates. Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates. Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again. Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab. Note that the template dropdown has changed
to be much larger.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Terran McCanna [Wed, 12 Dec 2018 22:57:19 +0000 (17:57 -0500)]
LP#1743783 Web Client Bill Full Detail Display Issues
Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type
2) Corrected path for Type
3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Remington Steed [Mon, 26 Nov 2018 19:10:36 +0000 (14:10 -0500)]
Docs: LP#1731048: Update json_query documentation for new join syntax
This commit simply adds the text from the related commit message (see
LP#1527731) to the original DocBook file. NOTE: This documentation is
also available on the wiki, and has been updated there as well:
katiegmartin [Thu, 2 Aug 2018 19:06:28 +0000 (15:06 -0400)]
Docs: LP1783387: update print templates to reflect new name
launchpad 1783387 - update receipt template editor documentation to reflect language change to "print templates" in web client
put both terms in index
updated title to Print (Receipt) Templates
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Added a section on how to apply a binding template to a distribution as this is necessary to ensure the binding does not fail. Also updated an instance of "Action" to "Actions".
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Remington Steed [Mon, 26 Nov 2018 15:04:28 +0000 (10:04 -0500)]
LP#1739606: Allow saving Billing History xacts grid
For a web staff eg-grid to save and retrieve its settings, it needs a
unique persist-key. This commit adds one for the Transactions tab grid
under Billing History (on patron record Bills tab, click the History
grid button).
Garry Collum [Sat, 16 Jun 2018 18:13:22 +0000 (14:13 -0400)]
LP#1761242 Z39.50 Marc View Usability with Mobile Repsonsiveness
This patch changes the size of the image in the Z39.50 Marc View from large to
medium. It also incorporates bootstrap's media classes to present the Marc
record and the cover image side by side. If there is no image the marc record
display floats to the left of the modal. From a suggestion by Jane Sandbert, it
also hides the book cover image on small devices.
To test.
1. Perform a search in z39.50. An LOC title search for "Cat in the Hat"
returms results of titles with and without images.
2. View some of the titles in Marc View, noting the large image.
3. Apply the patch.
4. Perform the same search and view the results in Marc View.
MODS 3.3 support was introduced in March 2009, but this
change was never included in an upgrade script. Older
sites on 3.1+ will need to apply this update to avoid scary
segmentation faults, and it should be harmless for newer
sites and desirable for those on 3.0 or older.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Jason Boyer [Thu, 15 Nov 2018 16:43:30 +0000 (11:43 -0500)]
LP1755625: Multiple emails in patron editor
Even though the HTML5 "email" input type allows multiple
addresses to be separated by commas there is nothing that
can be done to signal to Angular.js that this is ok; it
will only ever accept a single address. This patch forces
the type of the input tag to plain text so Angular will
rely on any supplied regex to verify the entry.
The ui.patron.edit.au.email.regex (Regex for email field on patron
registration) library setting can be used to control whether
one or multiple email addresses will be permitted on the
patron registration form.
To test
-------
[1] In the web staff client, try to register a new patron, entering
multiple email addresseses in the email field separated by
commas.
[2] Note that the email field displays as invalid and the
record cannot be saved.
[3] Apply the patch and repeat step #1, This time, the email
field should accept multiple addresses.
[4] Set the Regex for email field on patron registration library
setting to the multiple-email form listed above. Reload
the patron registration form and verify that it will
continue to accept multiple email addresses but will not
accept entry that doesn't look like an email address.
[5] Set the library setting to the single-address value. Reload
the patron registration form; this time it should accept
a valid email address but not multiple ones.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Avoid excessive browser page re-flows, caused by checking cell widths
for rendering tooltips, by rendering tooltips for all cells regardless
of the size of the content.
For some strange reason the volcopy bchannel event data.records
would be an array of string integers or a array of ints depending
on whether you're adding or editing holdings. This addresses that
weirdness.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Mike Rylander [Fri, 14 Sep 2018 15:03:30 +0000 (11:03 -0400)]
LP#1684202: Protect against missing features; Make feature more general
I've wrapped the BroadcastChannel code in a test derived from the auth version
of the same concept. Also broadcasting the full set of record IDs and the
pre-update call number IDs for other interfaces that might be interested. The
channel name is also made more generic and made to follow the precedent from
the auth channel name.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Located URIs depend upon bib-level visibility, as there are no copies
to work with. The browse code, however, was joining in the copy
visibility table as if it would always have at least one row per bib,
but in the case of located URIs, it does not.
Let's change it to a LEFT JOIN to allow the bib row to show up, at
which point the existing bib visibility check can do its job.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
The default tab selection was not being honored from catalog searches,
as the search had already set $scope.record_tab, and we were honoring
that value in all cases.
Instead, let's honor that value in cases where the OPAC load doesn't
change our current record, which should only happen if we load the
record directly to a non-opac tab, then go to the OPAC view.
To test:
1) Set any tab other than "OPAC View" as your default view in record
details.
2) Do a catalog search.
3) Select a record, and notice your default view is not set.
4) Apply patch, do the same steps, and notice the default view is now
selected.
To test regression of bug #1708951:
1) In Firefox, load a record directly (e.g.
/eg/opac/staff/cat/catalog/record/123).
2) Note the default view loaded.
3) Click "OPAC View".
4) Note the view does not return to your default view, but stays on
the OPAC.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
LP#1783602: Remove copy counts from mr search results page
The copy counts on the mr search results page can be wrong if a limiter was
applied to the metarecord search. Rather than supply inaccurate information to
the user, let's remove the counts from that page until a long-term solution can
be developed.
Kathy Lussier [Tue, 13 Mar 2018 16:54:42 +0000 (12:54 -0400)]
LP#1755543: Add help tips to Print Item Labels Settings tab
Instead of providing lengthy settings descriptions, which result in a lot of
scrolling on the Print Item Template page, let's use help tips that can
provide guidance to new users without adding clutter to the interface.
This commit also turns the field labels into HTML labels for improved
accessibility and removes borders on the page. The borders were helpful
when we displayed the help text on the page, but are no longer needed.
Garry Collum [Thu, 7 Jun 2018 18:54:45 +0000 (14:54 -0400)]
LP#1755896: Web Client mobile menu font color contrast.
When viewing the main menu in the web client in a small device or in a
browser with a width that is resized to less than 800px the menu
collapses and the submenu choices are difficult to read because of lack
of contrast. This patch adds some contrast.
To test:
1. View the web client in a browser and lessen the width until the menu
collapses, or view it in a small device.
2. Open some of the menu options to observe the submenus.
3. Apply the patch.
4. Refresh the browser and repeat steps 1-2 to view the more readable
submenus.
Galen Charlton [Mon, 5 Nov 2018 21:40:34 +0000 (16:40 -0500)]
LP#1789747: tweak disabling the offline circulation link
This patch ensures that the menu link can be fully disabled by
giving the "disabled" CSS class to the anchor as well as the
li that contains it. It also adds a CSS rule to the disabled
class to force the cursor to not-allowed; due to a quirk, an
anchor with "pointer-events: none" will not respect "cursor: not-allowed",
but the containing element can have that cursor rule.
Avoid page load failures when SharedWorkers (for offline mode) are
not supported. Additionally, disable the Offline Circulation menu
option when SharedWorkers are not supported.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Use of mod_remoteip is technically optional, since it's not
required that Evergreen run with a proxy such as NGINX. However, since
use of proxies is common, enablig mod_remoteip just in case could
be useful with minimal cost.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Galen Charlton [Mon, 5 Nov 2018 17:49:35 +0000 (12:49 -0500)]
LP#1801759: add mod_remoteip configuration to example Apache config
Text taken from an OpenSRF patch added by Bill Erickson per bug 1684970.
This patch adds an Apache configuration stanza that uses mod_remoteip
to pass the user agent's IP address to the HTTP translator. It is meant
for when Apache is being run behind a proxy such as NGINX.
To test
-------
[1] Set up Evergreen with Apache and the WebSockets server running
behind a proxy such as NGINX.
[2] Enable mod_remoteip (e.g., sudo a2enmod remoteip).
[3] Apply the Apache configuration change in this patch, uncommenting
out the directives and (if necessary) updating the internal IP
address of the proxy.
[4] Reload Apache.
[5] Perform an action that uses the HTTP translator, e.g., adding a
vendor record using the Dojo interface.
[6] Verify that the client IP logged is that of the user agent, not
the proxy.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Boyer [Fri, 26 Oct 2018 13:16:14 +0000 (09:16 -0400)]
LP1796988: Fix Saving Last Copy Template
A line that belongs within a forEach loop escaped
its bounds and caused a reference error that prevented
the applyTemplate function from saving the last used
template. This branch ushers this line back to its
pen where it can trouble us no more.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Apply a default value to the browser client iframe URL so the iframe
does not attempt to load a copy of the current page. The default value
points to a simple loading page, displying "Loading..." plus our
standard spinny gif.
Progress gif copied from web/opac/images/ to web/images/ to avoid
dependence on the old opac directory.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Mike Rylander [Wed, 19 Sep 2018 14:38:42 +0000 (10:38 -0400)]
LP#1746536: Allow batch-apply to volume fields in multi-record context
I can't see a reason to restrict Batch Apply for volume fields in a multi-
record context, as all the data is gathered based on the volume owners, not
record information. This commit removes that restriction.
Cesar Velez [Wed, 12 Sep 2018 09:37:28 +0000 (05:37 -0400)]
LP#1746536 - enable volcopy editor for multi-bib but only volumes
This removes the disabling of the volcopy editor caused by
passing it a record id of 0. Allowing the Item Status grid's
Edit>Volumes to function as a way to batch edit volumes of
more than 1 bib record.
a. bellenir [Wed, 27 Jun 2018 18:48:56 +0000 (14:48 -0400)]
LP1746536: cannot edit vol/call number in item status
spawnHoldingsEdit was disabling record summary by passing record_id: 0
this change will provided the record_id if exactly one record is selected.
behavior is unchanged if multiple records are selected.
Signed-off-by: a. bellenir <ab@grpl.org> Signed-off-by: cesar velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/item.js
Dan Wells [Wed, 10 Oct 2018 20:07:24 +0000 (16:07 -0400)]
LP#1796978 Realign working copy refresh with proper condition
The "working copy" grid needs to update whenever the copy data above
updates. I *believe* this aligns the refresh with its intended
condition.
This appears to have come about via bug #1732761, so retesting of
that fix may be in order.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Dan Wells [Thu, 11 Oct 2018 13:21:05 +0000 (09:21 -0400)]
LP#1796971 Wait for call number and copy before loading locations
In cases where add a copy to a call number, we fetch the original
call number via async, then attach the new copy to it. Before this
commit, however, we were not waiting for the call number fetch
promise to resolve, so the copy wasn't there to use for limiting the
location load.
Since the async request is internal to a loop, one way out is to
capture that promise, then make sure it resolves before loading the
locations.
(We previously returned the copies from the internal function, but that
value wasn't being used anyway, so we don't worry about unwrapping the
$q.all() when it resolves.)
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
Support copying formatted addresses to the clipboard in the browser
staff client, similar to the XUL client. Action is performed via a new
link in the addresses section (next to "print") in the patron summary
sidebar.
This has the side effect of fixing a problem where the batch
edit timestamps were not wrapped correctly in Firefox.
To test
-------
1. Using user buckets, make some batch changes on some patrons and roll
back some of those changes.
2. Using Firefox, click on the 'View Batch Edits' button.
3. Note that the times dispayed are formatted as raw
database timestamps
4. Note that the summary for the user bucket displays the
create time as a raw database timestamp.
5. Navigate to a record bucket and note that its create
time is displayed as a raw timestamp as well.
3. Apply patch.
4. Repeat steps 2-5; this time, the times should be displayed
using the correct date and time format.
Garry Collum [Thu, 21 Jun 2018 23:41:48 +0000 (19:41 -0400)]
LP#1778083 Location, Floating, and Age Protect missing from Items Out
Adds columns for Location (Copy), Floating Group, and Age-based Hold
Protection to the items out grid.
To test.
1. View an items out screen to see that the Location, Floating Group,
and Age-based Hold protection columns are not available as options.
2. Apply the patch.
3. Edit some items and add definitions for Floating Group, and
Age-based hold protection.
4. Check out these items and other items that do not have a floating
group or age-based protection.
5. Display the Location, Floating Group, and Age-based Hold Protection
columns.
Galen Charlton [Fri, 5 Oct 2018 20:41:04 +0000 (16:41 -0400)]
LP#1770246: (follow-up) display the open-in-new-window/tab icon
Since the title links added by the previous patch intentionally open
the record in a new tab, display the corresponding icon to be
consistent with other interfaces.
Garry Collum [Fri, 1 Jun 2018 01:22:35 +0000 (21:22 -0400)]
LP#1770246 Catalog linked title column in query and pending buckets
To mirror the Record Bucket View grid, this patch adds a title column
in the query and pending bucket tabs that links to the catalog record
of the title displayed. The catalog record is opened in a new tab, so
the query and pending data is not lost.
Mike Rylander [Mon, 27 Aug 2018 16:08:37 +0000 (12:08 -0400)]
LP#1786987: Locale-less org tree cache object becomes stale
The autogen.sh script calls a function that flushes all org tree objects
cached by locale, but does not flush the one used when the locale is
unkown. This commit forces that flushing to occur.
berick: Definition of my $cache pushed up above first use.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
projects / Evergreen.git / log