Bill Erickson [Tue, 29 Jan 2019 16:15:38 +0000 (11:15 -0500)]
LP1813647 Angular page title component & sandbox example
Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.
Each title may have a prefix and/or a suffix. If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Sam Link [Wed, 12 Dec 2018 16:35:20 +0000 (11:35 -0500)]
LP1802594 - Splash Page Image Alt Text
Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.
Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Sat, 6 Oct 2018 12:52:09 +0000 (05:52 -0700)]
LP1796225: Only auto-focus search on the home page
For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.
To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages. Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages. Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog. Notice that the
cursor still leaps to the search bar on this page only.
Jason Boyer [Mon, 3 Dec 2018 18:23:39 +0000 (13:23 -0500)]
LP1799963: Adjust fix to Staff Default Adv Search
By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels
This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID. As a consequence, the
following fields are now available for label templates:
If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.
To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
or more of the new fields listed above; verify that the current
value is displayed on the label preview.
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view
To test:
[1] Locate or create a bibliographic record that has at least
one located URI (e.g., an 856 with a $9 containing an org
unit code)
[2] View the record in the Holdings View in the web staff interface,
with the 'Show empty call numbers' (or volumes) option
selected.
[3] Note that rows are displayed with a call number label of '##URI##';
these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
should not display.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global
For some reason copy alerts require global permissions. Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.
Signed-off-by: James Fournie <jfournie@vcc.ca> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values. This commit changes it to
a more generic if() test to cover null/undefined. Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.
Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.
Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 14 Dec 2018 04:50:15 +0000 (20:50 -0800)]
LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2
To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2. Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Cesar Velez [Fri, 21 Sep 2018 15:46:59 +0000 (11:46 -0400)]
LP#1727345 - fix bibsource when importing or overlaying
This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.
Two paths to test:
Path A)
1. Import a new bib record from z3950, but via "Edit then Import"
2. Bring up marc editor and choose save w/ bib source.
3. Verify chosen bib source saved correctly on record page.
Path B)
1. Mark a record as target for Overlay, go to z3950 import.
2. Make a search, select item for Overlay.
3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
4. Verify chosen bib source saved correctly on record page.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Fri, 7 Dec 2018 00:42:49 +0000 (16:42 -0800)]
LP1805856: Open records in new tabs
Catalogers have given the feedback that it's very helpful to have
certain records open in a new tab after they perform certain tasks.
This commit opens the relevant records in a new tab in the following
circumstances:
1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
existing tab)
2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
overlaid record at all)
3) Cataloging > Record Buckets > Merge (previously opened the lead
record in the existing tab)
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jason Boyer [Wed, 16 Jan 2019 13:36:40 +0000 (08:36 -0500)]
LP1742521: Receipt Count Repair
The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Add a deprecation warning to the Hatch configuration page notifying
users that Hatch for storage is deprecated. Includes suggestions on how
to migrate away from Hatch for storage.
Remove the unusued "Use Hatch for Offline Files" option.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Cesar Velez [Fri, 7 Dec 2018 23:50:43 +0000 (18:50 -0500)]
LP1765179 - fix issue with pending/staged user reg
After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Jane Sandberg [Thu, 27 Sep 2018 14:53:35 +0000 (07:53 -0700)]
LP1782652: Make template dropdown larger in Volume/Copy Editor
To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates. Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates. Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again. Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab. Note that the template dropdown has changed
to be much larger.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Terran McCanna [Wed, 12 Dec 2018 22:57:19 +0000 (17:57 -0500)]
LP#1743783 Web Client Bill Full Detail Display Issues
Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type
2) Corrected path for Type
3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Remington Steed [Wed, 12 Dec 2018 16:36:17 +0000 (11:36 -0500)]
Docs: Fix screenshot file name
The asciidoc is looking for "My_Lists_dd.png", but the file has a
capitalized extension ".PNG". This commit renames the file to match the
code, since lowercase is our common naming convention.
Remington Steed [Mon, 26 Nov 2018 19:10:36 +0000 (14:10 -0500)]
Docs: LP#1731048: Update json_query documentation for new join syntax
This commit simply adds the text from the related commit message (see
LP#1527731) to the original DocBook file. NOTE: This documentation is
also available on the wiki, and has been updated there as well:
Jason Boyer [Fri, 7 Dec 2018 15:05:43 +0000 (10:05 -0500)]
LP1807398: Add workstation to marc_stream_importer
In order to work properly with vandelay session
tracking in 3.2+ a workstation is required at login.
This branch adds a workstation option to the importer
and alerts the user if it's missing.
Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Ben Shum [Sun, 9 Dec 2018 08:11:48 +0000 (03:11 -0500)]
Docs: Followup commit to fix screenshot for My_Lists3.jpg
The previous commit added some new screenshots for My_Lists, but this one
was saved with .JPG extension instead of .jpg so the original file was
retained.
katiegmartin [Thu, 2 Aug 2018 19:06:28 +0000 (15:06 -0400)]
Docs: LP1783387: update print templates to reflect new name
launchpad 1783387 - update receipt template editor documentation to reflect language change to "print templates" in web client
put both terms in index
updated title to Print (Receipt) Templates
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Added a section on how to apply a binding template to a distribution as this is necessary to ensure the binding does not fail. Also updated an instance of "Action" to "Actions".
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Remington Steed [Mon, 26 Nov 2018 15:04:28 +0000 (10:04 -0500)]
LP#1739606: Allow saving Billing History xacts grid
For a web staff eg-grid to save and retrieve its settings, it needs a
unique persist-key. This commit adds one for the Transactions tab grid
under Billing History (on patron record Bills tab, click the History
grid button).
Way back when, we switched from a misspelled 'clense_ISO8601' to a
corrected 'cleanse_ISO8601' in OpenSRF. This function has again moved,
and is now part of OpenILS::Utils::DateTime, and is named
'clean_ISO8601'. This was done as part of LP bug #1552778.
However, a few stragglers of the misspelling remained, so these were
missed when the big changeover occurred. This hopefully catches them
all!
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Jason Boyer [Tue, 20 Nov 2018 16:54:50 +0000 (11:54 -0500)]
LP1793154: Cancel Holds from OPAC Record
The name of the grid handler was misspelled
in the holds grid for records in the opac.
Swapping the location of the 'wide' part of
the function name will allow it to match up
with the functions available in the holds
grid module.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Garry Collum [Sat, 16 Jun 2018 18:13:22 +0000 (14:13 -0400)]
LP#1761242 Z39.50 Marc View Usability with Mobile Repsonsiveness
This patch changes the size of the image in the Z39.50 Marc View from large to
medium. It also incorporates bootstrap's media classes to present the Marc
record and the cover image side by side. If there is no image the marc record
display floats to the left of the modal. From a suggestion by Jane Sandbert, it
also hides the book cover image on small devices.
To test.
1. Perform a search in z39.50. An LOC title search for "Cat in the Hat"
returms results of titles with and without images.
2. View some of the titles in Marc View, noting the large image.
3. Apply the patch.
4. Perform the same search and view the results in Marc View.
MODS 3.3 support was introduced in March 2009, but this
change was never included in an upgrade script. Older
sites on 3.1+ will need to apply this update to avoid scary
segmentation faults, and it should be harmless for newer
sites and desirable for those on 3.0 or older.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Ben Shum <ben@evergreener.net>
The hold shelf rewrite brought back an old behavioral bug where items deleted
while on the hold shelf continued to show on the hold shelf list. The most
recent behavior was to ignore those items, which this commit does. It also
addresses an adjacent issue where holds may show with "Hold Shelf Delay"
instead of "Ready For Pickup" in some cases.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Jason Boyer [Thu, 15 Nov 2018 16:43:30 +0000 (11:43 -0500)]
LP1755625: Multiple emails in patron editor
Even though the HTML5 "email" input type allows multiple
addresses to be separated by commas there is nothing that
can be done to signal to Angular.js that this is ok; it
will only ever accept a single address. This patch forces
the type of the input tag to plain text so Angular will
rely on any supplied regex to verify the entry.
The ui.patron.edit.au.email.regex (Regex for email field on patron
registration) library setting can be used to control whether
one or multiple email addresses will be permitted on the
patron registration form.
To test
-------
[1] In the web staff client, try to register a new patron, entering
multiple email addresseses in the email field separated by
commas.
[2] Note that the email field displays as invalid and the
record cannot be saved.
[3] Apply the patch and repeat step #1, This time, the email
field should accept multiple addresses.
[4] Set the Regex for email field on patron registration library
setting to the multiple-email form listed above. Reload
the patron registration form and verify that it will
continue to accept multiple email addresses but will not
accept entry that doesn't look like an email address.
[5] Set the library setting to the single-address value. Reload
the patron registration form; this time it should accept
a valid email address but not multiple ones.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Bill Erickson [Tue, 6 Nov 2018 14:42:17 +0000 (09:42 -0500)]
LP#1797007 Grid cell tooltips apply to all cells (Ang)
Avoid excessive browser page re-flows, caused by checking cell
widths for rendering tooltips, by rendering tooltips for all cells
regardless of the size of the content.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Avoid excessive browser page re-flows, caused by checking cell widths
for rendering tooltips, by rendering tooltips for all cells regardless
of the size of the content.
For some strange reason the volcopy bchannel event data.records
would be an array of string integers or a array of ints depending
on whether you're adding or editing holdings. This addresses that
weirdness.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
projects / Evergreen.git / log