Terran McCanna [Tue, 1 Mar 2016 22:35:28 +0000 (17:35 -0500)]
LP#1551447 Selfcheck: Printing Fines Prints All Open Transactions
This corrects the behavior of the selfcheck fines receipt print template.
Prior to this, it printed all open billable transactions (eg, every item
that the patron had checked out) regardless of whether or not it had bills
associated with it. This adds a small bit of logic to the template to
check for a balance due. It also updates the javascript to check for a
balance on the account before launching the print function to prevent the
system from taking unnecessary action.
This includes a SQL upgrade script to update the Self-Checked Fines
Receipt template for systems that are already in production, as well as
including an update to the seed data.
Terran McCanna [Wed, 2 Mar 2016 21:52:13 +0000 (16:52 -0500)]
LP#1275118 Holds history displays canceled holds as active
Prior to this change, when a patron viewed holds history, canceled holds
displayed as active. From the patron point of view, the hold is no
longer active after it has been canceled.
Terran McCanna [Thu, 11 Jun 2015 22:15:13 +0000 (18:15 -0400)]
LP#1454871: Fix KPAC Hold Notification Preferences
Correction to KPAC holds notification default preferences to allow for
SMS text messaging options.
Prior to this correction, KPAC hold notifications would only pick up
hold preferences if set to email and/or phone. This correction allows
it to pick up email and/or phone and/or sms notification preferences.
To test, set hold preferences to different options, place hold via the
KPAC, and then view the hold to see which preferences were recognized.
(May need to show columns for Phone Notify, Text Notify, and Email Notify.)
Terran McCanna [Wed, 24 Feb 2016 22:17:27 +0000 (17:17 -0500)]
LP#1548869 KPAC hold results screen not displaying complete info
The getit_results.tt2 page was not displaying item title after
hold placement or after adding to a list. It was also not pulling
in the item id (which was needed for navigational links back to the
record) and was not pulling in the list name after adding an item
to a named list.
This patch adds some logic to prevent subroutine conflicts, adds
missing parameters to a function call, and corrects a variable name.
To test:
Log in to the KPAC and perform the following actions:
1. Place a successful hold (results screen should show item title
and pickup library, and provide links back to record page).
2. Place an unsuccessful hold (try placing a hold on an item you
already have a hold on - the results screen should show the item
title).
3. Add item to a temporary list (results screen should show item title).
4. Add item to a named list (results screen should show item title and
title of list it was added to).
Josh Stompro [Sat, 27 Feb 2016 14:54:04 +0000 (08:54 -0600)]
LP#1549393 - Remove undef values from isbn and issn arrays.
This prevents empty requests being sent to content providers.
This caused a problem for us because invalid ISBNs were causing
requests to Content Cafe to fail, since Content Cafe returns an
error if there is a blank key sent along with valid ISBNs and UPCs.
Specifically we had problems with DVD records from Baker & Taylor because
B&T creates unoffical ISBNs for the DVDs they sell. Those ISBN's do
not validate when run through B::ISBN.
ISSNs are also cleaned since they are validated and set to undef if
invalid just like ISBNs are.
It shouldn't hurt to not send blank requests to providers in any case.
To test:
1. I know this is a problem with Content Cafe, I don't
know if any other providers are effected. Let me know
if you need Content Cafe credentials to test.
2. Add an invalid ISBN 020a entry to a bib record that has added content. 9786316271976 is an example of a fake ISBN that doesn't
pass B::ISBN validation. Or just make up a fake number.
3. Clear out the memcache entries for that record. In 2.9+ there
is a link to clear the cache in the record detail view under Permalink.
4. Reload the record and the cover art and other added content should
not be displayed. This is because the invalid ISBN gets set to undef
, and the undef gets sent to content cafe as a blank key request.
5. Now apply the fix. Clear the memcache entries for that bib, and now
the cover art should be displayed since the undef entries due to the invalid
ISBN's have been removed.
Josh Stompro [Fri, 4 Mar 2016 19:51:34 +0000 (13:51 -0600)]
LP#1550495 - Add EDI Cancel Code 85 - used by Baker & Taylor
Baker & Taylor send back a quantity code 85 response when they cancel
a line item. This code wasn't included as one of the built in EDI
codes so those line items were not being canceled automatically in
evergreen.
The system looks for the response code + 1200 to find the cancel reason,
so this code is entered as ID 1285 in the acq.cancel_reason table.
I received confirmation from another system that uses B&T as an EDI vendor
that they also receive code 85 responses when something gets canceled.
This patch makes open-ils.auth_internal look for
default_timeout values for persistent authentication
in the intended section of opensrf.xml.
To test:
[1] Attempt to log into the public catalog with the "Stay logged in?"
option in effect. The login will either fail or the session
will not persist when navigating within the "My Account"
pages.
[2] Apply the patch and restart services.
[3] Attempt step 1 again; this time, authentication should work
and the session should remain active.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Terran McCanna [Wed, 2 Mar 2016 17:16:43 +0000 (12:16 -0500)]
LP#1454884 Hold placed on grouped metabib result displays wrong title
Prior to this change, a full/extended title displayed even on metarecord
holds that had different extended titles, which sometimes led to situations
where a video's full title displayed on a book hold, or vice versa. This
change displays the short version of the title on metarecord holds and
the full version on individual record holds.
Chris Sharp [Mon, 8 Feb 2016 18:00:06 +0000 (13:00 -0500)]
LP#1533331 - Fix evergreen.protect_reserved_rows_from_delete() trigger function
The fix for bug 1513554 included creating a general trigger function to prevent
the deletion of reserved table rows with an ID lower than a specified threshold.
Testing for that seemed to pass muster, but using the function in practice revealed
a failure to delete deletable rows either.
This adds an explicit RETURN to the function, which fixes the issue.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
The functions search.facets_for_record_set and
search.facets_for_metarecord_set that were added in the 0958 upgrade
script from Launchpad Bug #1505286 are not compatible with PostgreSQL
9.1. This commit makes them compatible with Pg 9.1 for those who need
it.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Jeff Davis [Tue, 12 Jan 2016 19:58:13 +0000 (11:58 -0800)]
LP#1533329: Selectively disallow opt-in based on patron's home library
Patrons from Library A can "opt in" to sharing their personal
information with Library B. However, hitherto there has been no way for
Library A to prevent their patrons from being opted in at other
libraries. This would be useful if, for example, Library A is a school
library and does not want other libraries in the consortium to have
access to student accounts.
This commit adds the ability to selectively disallow opt-in by home
library. Specifically, it makes the following changes:
1. Adds an org setting (org.restrict_opt_to_depth) that governs opt-in
restrictions. All org units within the home OU's section of the org
tree at or below depth X are within the patron's opt-in scope; opt-in is
disallowed at any library outside of that scope. If the setting is not
enabled, the entire org tree is effectively within scope. (None of this
should be confused with the opt boundary, which defines the point at
which patrons need to be opted in vs. just granting access without
opt-in.)
2. Modifies open-ils.actor.user.org_unit_opt_in.check so that it checks
that setting and determines if the current work OU is within the
patron's opt-in scope. If opt-in is not permitted at this work OU,
an appropriate response is returned.
3. Handles the response in both staff clients. If opt-in is disallowed,
staff will see an alert which says, "This patron's record is not
viewable at your library."
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Define all fixed fields for use in the MARC editor and
add acceptable values for context menues. Also define
composite coded values for special multi-position
single character fields.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
LP#1391282: Add Auto-Submitted: auto-generated header to included A/T email templates.
This patch updates various stock A/T definitions for
email notifications to add the following email header:
Auto-Submitted: auto-generated
This specifies to email clients that the message was
generated by a computer program and that no automatic
response is desired (particularly out-of-office/vacation
responses).
No upgrade script is provided; administrators who
wish to use this header for existing notices should
update them manually.
Mike Rylander [Sun, 28 Sep 2014 20:37:33 +0000 (16:37 -0400)]
LP#1375043: Support for in-A/T telephony configuration
The AstCall reactor module creates a callfile for Asterisk, given a
template describing the message and an environment defining
necessary information for contacting the Asterisk server and scheduling
a call with it.
If you have only one SIP server, you can set it up like this in the
opensrf.xml configuration file:
<telephony>
<!-- replace all values below when telephony server is configured -->
<enabled>0</enabled>
<driver>SIP</driver> <!-- SIP (default) or multi -->
<channels> <!-- explicit list of channels used if multi -->
<!-- A channel specifies technology/resource -->
<channel>Zap/1</channel>
<channel>Zap/2</channel>
<channel>IAX/user:secret@widgets.biz</channel>
</channels>
<host>localhost</host>
<port>10080</port>
<user>evergreen</user>
<pw>evergreen</pw>
<!--
The overall composition of callfiles is determined by the
relevant template, but this section can be invoked for callfile
configs common to all outbound calls.
callfile_lines will be inserted into ALL generated callfiles
after the Channel line. This content mat be overridden
(in whole) by the org unit setting callfile_lines.
Warning: Invalid syntax may break ALL outbound calls.
-->
<!-- <callfile_lines>
MaxRetries: 3
RetryTime: 60
WaitTime: 30
Archive: 1
Extension: 10
</callfile_lines> -->
</telephony>
To support more than one SIP server, say, per library, you can use
Action/Trigger parameters like these, which model the same information
as above:
Terran McCanna [Thu, 25 Feb 2016 21:26:46 +0000 (16:26 -0500)]
LP #1466173 Selfcheck Hide UI Elements Until Patron Auth
Currently, there are visible elements on the lower portion of the
login screen that the patron cannot use until after authenticating.
This patch hides those elements except when the patron is authenticated.
Mike Rylander [Thu, 2 Jul 2015 18:44:25 +0000 (14:44 -0400)]
LP#1470957: Normalize date1 (pubdate sorter) to null when not numeric
We supply a normalizer function for making sure date-ish values are
always numeric (several, in fact) but we don't enable them by default
for appropriate fields. This does that.
Additionally, we allow NULL sorters so that the reingest of a "broken"
record will get fixed.
We avoid the need for a reingest to cover the sorter issue by removing
non-numeric pubdate sorters.
To test
-------
[1] Identify some records where the Date1 value in the 008 field
is '||||'.
[2] Perform a catalog search that includes some of those records
and sort by publication date newest to oldest. Note that
the |||| records sort at the top.
[3] Apply the patch and perform the schema update.
[4] Perform the search again (possibly clearing the search
results cache first). This time, the |||| records should
sort near the end.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Galen Charlton [Tue, 16 Feb 2016 20:36:26 +0000 (15:36 -0500)]
LP#1492793: teach Clark Kent to set the Pg app name
Clark Kent can now also use the application_name
setting in the relevant sections of opensrf.xml to
set the Pg application name.
To test:
[1] Apply the patch, restarting opensrf.settings, and
start Clark.
[2] Run a report that will take at least a minute to
finish. While it is running, query the pg_stat_activity
table. There should be at least one row where the
application_name column is set to 'Clark Kent (reports)'.
[3] Note that since the master Clark process opens a database
connection, checks whether there are any reports to run,
then immediately closes the connection, it's unlikely that
you'll catch a 'Clark Kent (state)' connection when
querying pg_stat_activity.
Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Boyer [Sun, 6 Sep 2015 16:58:49 +0000 (12:58 -0400)]
LP1492793: Support Application Name Postgres Option
If app_settings/database/application_name is defined,
connections by that service will have the application_name
postgres option set, allowing log analyzers to associate
queries and services.
To test:
[1] Apply the patch and restart OpenSRF services.
[2] Query the pg_stat_activity table in the PostgreSQL
database; the application_name column should now
be populated with values like 'open-ils.cstore'
or 'open-ils.storage' that indicate which Evergreen
service holds the database connection.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 16 Nov 2015 19:48:23 +0000 (14:48 -0500)]
LP#1516757: ensure that SIP2 returns DOB correctly
Parse dates of birth using the local timezone to ensure that the date in
the database will match what is sent to SIP clients. Otherwise, the
date will be parsed as UTC and may result in the DoB value being offset
by one day in the SIP response.
To test
-------
[1] Fire up a SIP client of some sort and retrieve a patron record;
verify that the patron's date of birth is correct, and not
offset by one day.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Galen Charlton [Mon, 19 Oct 2015 20:41:12 +0000 (20:41 +0000)]
LP#1516022: new reporting source for hold/copy ratios
This patch adds a new reporting source, "Hold/Copy Ratio per Bib
and Pickup Library (and Descendants)", that, for each bib
that has a hold request on it or any of its components,
calculates the following:
- active holds at each OU (including the OU's descendants)
- holdable copies at each OU (and its descendants)
- the ratio of the above two counts
- counts and ratio across the entire consortium
This work was sponsored by the Pennsylvania Integrated Library
System (PaILS).
LP#1531976: fix bringing up Mesage Center and Triggered Events
This patch fixes a bug in the XUL staff client where
using Other -> Triggered Events from the patron page,
then Other -> Message Center, only brings up the Triggered
Events page in both cases (and vice versa).
This patch works by preventing the deck code from thinking they are
the same page, despite both using the browser wrapper as their base URL.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Galen Charlton [Wed, 2 Mar 2016 19:32:35 +0000 (14:32 -0500)]
LP#1519911: upgrade script to fix self-checkout receipt A/T template
This patch adds an update to fix the "lb_addr.post_code" typo
in the stock A/T event definition for self-checkout receipts.
This update changes the definition *only* if it has not
been customized by the user, and it does not attempt to
fix any copies of that definition.
To test
-------
[1] Upon applying the update, generate a receipt from the
web-based self-check interface. The library's postal
code (if set) should now display in the receipt.
- The html table was broken, fixed the markup.
- Added some styling to the table.
- Added a row with total records info.
- Fixed the progress bar popup; it now displays
percentage completion and has a title so it is
wide enough to do so
- Added color to failed row (red), and to completion text (green).
To test:
[1] In the staff interface (both XUL and web), perform
a MARC Batch Edit on a bucket that contains at least
a few bib records.
[2] Verify that the progress dialog now displays the
percentage completion of the batch edit; verify
that there is now a row displaying the total number
of records.
[1] Using MARC Batch Import/Export, load a file
of MARC records into a queue (arranging the matching
criteria so that at least a few of the records
aren't automatically imported into the catalog).
[2] Inspect the queue, and click on the "Export Non-Imported
Records link", then save the resulting file.
[3] Verify that the file contains, in MARC format, the set
of records that were not imported into the catalog.
Dan Wells [Thu, 25 Feb 2016 16:44:23 +0000 (11:44 -0500)]
LP#1548147 Quick Export Feature for Vandelay Queues
When we import records into Vandelay, sometimes some of the records
are not what we expected, so they get rejected. These records often
need to be loaded using a different set of options, so this link makes
it convenient to get a new file of just the rejects.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Ensure all TT code lives within the [% ... %] blocks. This fixes an
issue where TT code "ctx.metalinks.push('');" was appearing in the
catalog as bare text.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Back in bug # 1414033 , we added rel="nofollow" attributes to many of the links
that led to search results or call number browsing. This was the right idea,
but a bit overzealous as it turns out. We actually want search engines to
follow those links; we just don't want search engines to index them.
Therefore, we can tweak the <meta> tag in the results and browse page headers
to say "follow,noindex", and remove many of the inline rel="nofollow"
attributes from the other pages.
In addition, add a rel="canonical" link to the catalogue home page.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
Open-ILS/src/templates/opac/parts/record/subjects.tt2
Jake Litrell [Tue, 1 Mar 2016 22:22:28 +0000 (17:22 -0500)]
LP#1312699: Minor modifications to patron checkout history deletions
Minor modifications to make patron checkout history deletions work with
the new table. open-ils.actor.history.circ.clear
extended to take an optional list of circ_ids, to limit what's deleted
from the history.
Dan Pearl [Tue, 20 Oct 2015 21:05:07 +0000 (17:05 -0400)]
LP#1312699 - Add feature to allow user to edit their checkout history.
In the checkout history page, a new column and action selector is provided to allow
the paton to indicate items they would just as soon not want to see again in the
history list for whatever reason. NOTE: This is not a PURGE function; it simply
suppresses display of items in the history list (and exported history files).
Internally, the circulations are kept by Evergreen for several reasons which are
not affected by this functionality.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jake Litrell <jake@masslnc.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Adding basic javascript to remove our search filter from the
textbox on an advanced search form. Because of the interplay among
various checkboxes/modifiers/filters, there may be duplicate filters
applied from another function's form submit; this removes all at once.
Signed-off-by: Jake Litrell <jake@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
In 002.schema.config.sql there was a small typo for "z3950attr_name_is_valid"
where that should be "z3950_attr_name_is_valid" with the underscore between.
Rather than use a CHECK constraint, this patch
uses a CONSTRAINT TRIGGER, er, constraint to verify
the z3950_attr_type field. This allows the trigger
to be deferred as any other deferrable constraint
and also allows parallel pg_restore jobs to complete
properly.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Ben Shum <ben@evergreener.net>
Jason Boyer [Wed, 2 Sep 2015 20:20:13 +0000 (16:20 -0400)]
LP#1491571: Ignore Case when Checking PW Reset email
Emails are not passwords and are not case sensitive;
while it is a good idea to require patrons to prove
they know the address associated with their account
it is not cool to deny them because they don't know
the capitalization of the value in the database.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Ben Shum <ben@evergreener.net>
Dan Pearl [Fri, 2 Oct 2015 18:54:39 +0000 (14:54 -0400)]
LP#1197636 - Email record detail does not check for email
Even though no email was configured, the message shown when requesting
bib information to be emailed indicated success. This misleading
behavior has been addressed by alerting the patron of the situation
and providing a link to the page where the email address is defined,
after which the action is automatically retried.
The success message has also been altered slightly to provide
confirmation of the generated email.
To test:
[1] Create a patron account that does not have an email address.
[2] In the OPAC, log in as that patron and attempt to email a
bib record. A message should display indicating that the
email can be sent; that message should contain a link to the
user's account page where they can set their email address.
[3] After setting the email address, you should then be
redirected back and the email sent.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <ben@evergreener.net>
Kathy Lussier [Thu, 25 Feb 2016 17:26:02 +0000 (12:26 -0500)]
LP#1422802 Fix javascript validation for visible parts
The previous javascript validation was not working for records with just one
part. This one works better. Many thanks to Dan Wells for identifying the fix.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Martha Driscoll [Mon, 22 Feb 2016 20:34:15 +0000 (15:34 -0500)]
LP1229757 - Distinct images for holds, reserves, transits
This commit changes the references to turtle.gif to three new images
holdshelf.png, reserve.png, and transit.png. When checking in a copy
that needs to go on the hold shelf, on the reservation shelf, or
in transit, a distinct image will show in the pop-up window.
This commit adds support for 'parts' import in Vandelay. It is
modeled after the existing support for stat cat import. As such, it:
- Uses '|' characters to separate labels to allow for multiple
part assignment.
- Adds to (rather than replaces) any existing parts assigned to overlay
copies.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Dan Wells [Tue, 26 Jan 2016 19:22:21 +0000 (14:22 -0500)]
LP#1468422 Use auth_internal.validate to shore up AuthProxy
Even if a user has valid credentials in the external system, we should
block them from logging in if their Evergreen account is out of sorts.
Use the API designed for this.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Previously, AuthProxy.pm would simply lookup and use the hashed password
when the external authentication had passed. This simple method no
longer works, since even cstore doesn't have access to the hashed
password.
Instead, take advantage of the new 'auth_internal' service to create the
user session after the user has been externally authenticated.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
projects / Evergreen.git / log