Evergreen.git
5 weeks agoLP#1729435: Allow saving Bill Full Details grids
Remington Steed [Mon, 5 Nov 2018 21:11:35 +0000 (16:11 -0500)]
LP#1729435: Allow saving Bill Full Details grids

For a web staff eg-grid to save and retrieve its settings, it needs a unique
persist-key. This commit adds one for the Bills grid and Payments grid on the
patron bills Full Details view (right-click a bill, choose Full Details, then
click the Details tab).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP#1803790: apply alphabetization fix to Angular admin splash pages
Galen Charlton [Fri, 4 Oct 2019 14:12:49 +0000 (10:12 -0400)]
LP#1803790: apply alphabetization fix to Angular admin splash pages

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP#1803790 Re-alphabetize Local & Server Administration Links
Terran McCanna [Wed, 6 Mar 2019 21:40:53 +0000 (16:40 -0500)]
LP#1803790 Re-alphabetize Local & Server Administration Links

Small fix that re-orders the links that were out of order due
to link name changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings
Jeff Davis [Tue, 2 Oct 2018 21:28:31 +0000 (14:28 -0700)]
LP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings

To test:

1. Create a bib record.
2. Add an item to the record at BR1. Mark it as not OPAC-visible.
3. Do a CONS-level SRU search for the record, including holdings. The
   record is not included in results because there are no OPAC-visible
   holdings.
4. Add a second item to the same record, this time at BR3. Mark this
   one as OPAC-visible.
5. Repeat the CONS-level SRU search, including holdings. The record
   appears in search results, but holdings information in 852 includes
   *all* copies, including non-OPAC-visible copies.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP 1827250: Fix Last Captured Hold Check for Holds Shelf
Jason Stephenson [Thu, 2 May 2019 12:36:15 +0000 (08:36 -0400)]
LP 1827250: Fix Last Captured Hold Check for Holds Shelf

When the current copy on an on shelf hold is the same as that on some
uncaptured holds, the hold fails to appear on the hold shelf when it
should.  This comes down to some SQL in the storage function to
retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.

The intent of the new code is to check that the current hold matches
the most recently captured hold for the copy.  However, the order by
in the query fails to take into account holds with a NULL capture time
on the same copy will sort before the captured holds.  This patch
rectifies this situation by adding "NULLS LAST" to the order by.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agolp1813056 Fixes Current Date in Date Returned in Circ History CSV
Garry Collum [Mon, 20 May 2019 16:48:10 +0000 (12:48 -0400)]
lp1813056 Fixes Current Date in Date Returned in Circ History CSV

The date returned column in the csv file created in the opac for the patron's
Check Out History contains the current date instead of the check-in date. This
patch fixes that issue.

To test:
1. Turn on "Keep history of checked out items" in the patron Search and
History Preferences in the opac, or find a patron that already has this
option turned on.
2. Check-in some items that the patron has checked-out.
3. Wait a day, or if it was an existing history list immediately, go to the patron's Items Checked Out in the opac and look at the Date Returned
column in the Check Out History list.
4. Download the CSV file and note that the date is the current date.
5. Apply the patch.
6. Refresh and download the CSV file again and note that the Date Returned
is now the checkin date.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
5 weeks agoLP#1836963: reduce the cost of utility functions, speeding up search
Mike Rylander [Wed, 17 Jul 2019 21:14:01 +0000 (17:14 -0400)]
LP#1836963: reduce the cost of utility functions, speeding up search

For large org trees, some several seconds are spent testing org visibility.
The immediate cause is that AppUtils::get_org_tree() does not populate the
process-local cache with a memcache-cached org tree. That only happens when
memcache does not have a copy of the org tree. This is obviously a simple
oversight, which is addressed by making sure any memcache return value
is pushed into the the process local cache.

Additionally, the visibility check is making heavy use of lots of
indirection and delegation to utility code, when some slightly smarter code
could avoid many repeated function calls.  We now supply some local
utility code to flesh and unflesh the parent_ou field of objects in the
org tree, allowing us to avoid using find_org() and instead just calling
parent_ou() when walking "up" the tree.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoDocs: adding basic documentation for new 3.4 features
Jane Sandberg [Thu, 3 Oct 2019 16:41:09 +0000 (09:41 -0700)]
Docs: adding basic documentation for new 3.4 features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 weeks agoforward-port 3.3.3-3.4.0 schema update
Galen Charlton [Wed, 2 Oct 2019 21:28:11 +0000 (17:28 -0400)]
forward-port 3.3.3-3.4.0 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoforward-port 3.4 release notes
Galen Charlton [Wed, 2 Oct 2019 21:27:16 +0000 (17:27 -0400)]
forward-port 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agonote minimum OpenSRF version in upgrade instructions
Galen Charlton [Wed, 2 Oct 2019 20:08:59 +0000 (16:08 -0400)]
note minimum OpenSRF version in upgrade instructions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP#1846369: add libhtml-defang-perl to Debian Buster installation
Galen Charlton [Wed, 2 Oct 2019 16:55:28 +0000 (12:55 -0400)]
LP#1846369: add libhtml-defang-perl to Debian Buster installation

This patch fixes an oversight where the HTML::Defang dependency
added in LP#1825851 wasn't installed on Debian Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
5 weeks agoLP#1846357: fix circulation and billing aging
Galen Charlton [Wed, 2 Oct 2019 15:31:06 +0000 (11:31 -0400)]
LP#1846357: fix circulation and billing aging

An error merging an update to action.age_circ_on_delete() resulted
in a regression to the aging of billings. This patch fixes it.

To test
-------
[1] Apply the patch, then age circulations. Verify that relevant
    billings are also aged.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoTranslation updates - po files
Galen Charlton [Wed, 2 Oct 2019 00:02:33 +0000 (20:02 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoTranslation updates - newpot
Galen Charlton [Tue, 1 Oct 2019 23:58:33 +0000 (19:58 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP1842940: stamping and slight tweak to upgrade script
Jane Sandberg [Tue, 1 Oct 2019 21:47:07 +0000 (14:47 -0700)]
LP1842940: stamping and slight tweak to upgrade script

Mike Rylander suggested the INSERT ... SELECT ... WHERE NOT
EXISTS approach, since this fix is being backported to older
releases, and we don't want to cause duplicate entries or
upgrade failures if the perm already exists

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1842940: Improve Alert
Mike Rylander [Tue, 17 Sep 2019 15:07:04 +0000 (11:07 -0400)]
LP#1842940: Improve Alert

Attempt to float the alerts below the sticky bar and above the main
content of the user editor.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1842940: Alert when editing is disallowed
Mike Rylander [Wed, 11 Sep 2019 18:46:44 +0000 (14:46 -0400)]
LP#1842940: Alert when editing is disallowed

Provide functions that checks the permissions required to edit ones
own account, or accounts in groups based on group application
permissions, and alert the user if and why they can't edit an account.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1842940: add perm to permit staff to edit their own accounts in the client
Jeff Davis [Thu, 5 Sep 2019 17:23:55 +0000 (10:23 -0700)]
LP#1842940: add perm to permit staff to edit their own accounts in the client

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1842940: Don't allow self-edit or perm-restricted edit
Mike Rylander [Thu, 5 Sep 2019 15:34:51 +0000 (11:34 -0400)]
LP#1842940: Don't allow self-edit or perm-restricted edit

Pre-webstaff, we disallowed editing of ones own record, an of records
that have a group application permission that the staff do not possess.

This commit brings back those restrictions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLP#1835458: bump up OpenSRF requirement
Galen Charlton [Tue, 1 Oct 2019 21:56:47 +0000 (17:56 -0400)]
LP#1835458: bump up OpenSRF requirement

OpenSRF 3.2.0 or later is now required for Evergreen 3.4+ as
a consequence of the new support for Debian 10 Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoupdates to 3.4 release notes
Galen Charlton [Tue, 1 Oct 2019 21:55:58 +0000 (17:55 -0400)]
updates to 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1835085: stamp DB update
Galen Charlton [Tue, 1 Oct 2019 21:24:16 +0000 (17:24 -0400)]
LP#1835085: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLp 1835085: Update Item Status templates for auto-renewal
Jason Stephenson [Mon, 9 Sep 2019 12:47:09 +0000 (08:47 -0400)]
Lp 1835085: Update Item Status templates for auto-renewal

Add checks for circ.auto_renewal() == 't' in the circ list and summary
pane views of the web staff client Item Status interface.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLp 1835035: Refactor auto_renewal back end code
Jason Stephenson [Fri, 30 Aug 2019 15:37:24 +0000 (11:37 -0400)]
Lp 1835035: Refactor auto_renewal back end code

Refactor the auto_renewal feature so that it works like other renewal
types: opac_renewal, sip_renewal, etc.  This refactor prevents
desk_renewal from being set when auto_renewal is set.

Deprecate the newly added open-ils.circ.renew.auto API and ensure that
it still works as intended.  Add release note indicating the
deprecation of this API and intent to remove it in Evergreen 3.5.

Modify the AutoRenew action trigger reactor to use the plain
open-ils.circ.renew API with the auto_renewal option set to 1.

Add database update script to cleanup (i.e. set to FALSE) the
desk_renewal field on action.circulation and action.aged_circulation
tables where auto_renewal is TRUE.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1835577: stamp schema updates
Galen Charlton [Tue, 1 Oct 2019 21:19:51 +0000 (17:19 -0400)]
LP#1835577: stamp schema updates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLp 1835577: Add more missing auto_renewal fields
Jason Stephenson [Tue, 10 Sep 2019 15:27:07 +0000 (11:27 -0400)]
Lp 1835577: Add more missing auto_renewal fields

Add missing auto_renewal and auto_renewal_remaining fields to the
following additional IDL classes:

* aacs
* aoc
* circbyyr
* robcirc

Add database updates to add auto_renewal fields to the following
views:

* action.billable_circulations
* action.open_circulation
* reporter.circ_type
* reporter.overdue_circs

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLp 1835577: Add missing Auto Renewal fields to the IDL
Jason Stephenson [Thu, 29 Aug 2019 14:15:33 +0000 (10:15 -0400)]
Lp 1835577: Add missing Auto Renewal fields to the IDL

Add entries for auto_renewal and auto_renewal_remaining fields to the
acirc and combcirc classes in fm_IDL.xml.  They were missing after the
auto-renewal feature was added.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1839002: stamp DB update
Galen Charlton [Tue, 1 Oct 2019 21:15:36 +0000 (17:15 -0400)]
LP#1839002: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLp 1839002: Default circulation auto_renewal field to FALSE
Jason Stephenson [Thu, 29 Aug 2019 15:06:56 +0000 (11:06 -0400)]
Lp 1839002: Default circulation auto_renewal field to FALSE

Change the definition of the action.circulation table so that the
auto_renewal field is not null, default false.

Add an upgrade script to update the field values and alter the field
definition in both the action.circulation and action.aged_circulation
tables.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1840669: stamp schema update
Galen Charlton [Tue, 1 Oct 2019 21:06:16 +0000 (17:06 -0400)]
LP#1840669: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLp 1840669: Handle autorenewals when aging circulations
Jason Stephenson [Thu, 29 Aug 2019 14:03:50 +0000 (10:03 -0400)]
Lp 1840669: Handle autorenewals when aging circulations

Add auto_renewal and auto_renewal_remaining fields to the
action.age_circ_on_delete trigger function.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1845050: fix issue where reports interface was partially loaded
Galen Charlton [Tue, 24 Sep 2019 17:48:08 +0000 (13:48 -0400)]
LP#1845050: fix issue where reports interface was partially loaded

This patch adjusts mod_xmlent to not free its XML parser
prematurely in the face of an EOS bucket received while processing
a sub-request.

To test
-------
[1] Test on a platform that has Apache 2.4.25 or later, such as
    Debian Stretch.
[2] Note that when loading the reports interface that the source
    of the frame containing oils_rpt.xhtml is incomplete and that
    actions like creating a template or folder do not work in the
    interface.
[3] Apply the patch and repeat step 2. This time, oils_rpt.xhtml
    should be fully loaded and the interface fuctional.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
6 weeks agoLP#1845260: add additional DB update to be sure
Galen Charlton [Tue, 1 Oct 2019 20:54:39 +0000 (16:54 -0400)]
LP#1845260: add additional DB update to be sure

... that the function is correct if somebody is upgrading a
beta1 or beta2 database.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1845260: fix error in vandelay.auto_overlay_org_unit_copies db function
Jeff Davis [Mon, 23 Sep 2019 23:15:14 +0000 (16:15 -0700)]
LP#1845260: fix error in vandelay.auto_overlay_org_unit_copies db function

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP1844812 Combobox avoids processing matching entry lists
Bill Erickson [Fri, 20 Sep 2019 15:31:16 +0000 (11:31 -0400)]
LP1844812 Combobox avoids processing matching entry lists

Teach the combobox to only process newly provided entry lists if they
are different from the list already on record for the combobox.

The combobox entry list Input() is responsive to changes in data
throughout the life of the combobox.  As a new entry list is provided,
the component will perform various actions on the list.  However, in
many cases the list provided may be identical the list the component
already has, which can lead to a lot of unnecessary processing and in
some case an infinite loop of inputs and outputs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1811442 - Assign copy alert permissions.
Chris Sharp [Mon, 20 May 2019 19:44:08 +0000 (15:44 -0400)]
LP#1811442 - Assign copy alert permissions.

VIEW_COPY_ALERTS and ADMIN_COPY_ALERT permissions were added
recently, but not assigned in the default seed data.  This branch
assigns VIEW_COPY_ALERTS to Staff profiles at the Consortium depth
and adds ADMIN_COPY_ALERT to the Cataloging Administrator profile.

Since permissions are set so specifically per-site, this branch does
not contain an upgrade script, but does provide an update to release
notes reminding site admins to manually add them to the appropriate
profiles.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1560805 Webstaff locale picker repair
Bill Erickson [Wed, 23 May 2018 15:13:16 +0000 (11:13 -0400)]
LP#1560805 Webstaff locale picker repair

Make the locale picker less finicky by replacing the search/replace
regex with a simple static URL for applying the locale.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1830642: add tests for authenticating users when password contains percent sign
Jeff Davis [Mon, 27 May 2019 19:03:00 +0000 (12:03 -0700)]
LP#1830642: add tests for authenticating users when password contains percent sign

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1768141: Stamping Upgrade Script
Jason Boyer [Tue, 1 Oct 2019 19:10:56 +0000 (15:10 -0400)]
LP#1768141: Stamping Upgrade Script

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
6 weeks agoLP#1768141: (follow-up) change schema update
Galen Charlton [Fri, 2 Aug 2019 14:41:44 +0000 (10:41 -0400)]
LP#1768141: (follow-up) change schema update

Change the update to an "ALTER FUNCTION ... STABLE" both
to make the purpose of the update more clear and to remove
the need to check the rest of the function definition when
backporting.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
6 weeks agoLP#1768141 - Mark permission.grp_descendants STABLE.
Chris Sharp [Mon, 20 May 2019 20:14:00 +0000 (16:14 -0400)]
LP#1768141 - Mark permission.grp_descendants STABLE.

Quoting Galen Charlton's comments on the bug report:

The database function permission.grp_descendants should
be marked stable; it qualifies, and doing so should allow
PostgreSQL to improve query plans. One example of a query
that would benefit is searching by patron profile (a la
bug 1497322)

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
6 weeks agoLP1739607: Add missing columns to patron record
Jane Sandberg [Wed, 21 Aug 2019 17:26:47 +0000 (10:26 -0700)]
LP1739607: Add missing columns to patron record

To test:
1) Open up a patron record with some bills.
2) On the Items Out tab, notice that there is a column named Location
3) On the Bills tab, open up Bill history.
4) In the history transactions grid, note that the column picker is
missing the following columns:
  * Item owning library
  * Checkout/renewal library
  * Due date
  * Fines Stopped Reason
5) In the history payments grid, note that the column picker is missing
the same columns.
6) Apply this commit.
7) Note that the Items Out tab's column is renamed to "Shelving
Location".
8) Notice that both Bill history grids column pickers include the
requested columns.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
6 weeks agoDocs: minor formatting changes to Hide Fields doc
Andrea Buntz Neiman [Tue, 1 Oct 2019 17:57:32 +0000 (13:57 -0400)]
Docs: minor formatting changes to Hide Fields doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 weeks agoDocs: adding Hiding Fields in Holdings Editor docs and screenshots
Beth Willis [Tue, 1 Oct 2019 17:32:06 +0000 (13:32 -0400)]
Docs: adding Hiding Fields in Holdings Editor docs and screenshots

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 weeks agoDocs: added another contributor
Andrea Buntz Neiman [Fri, 27 Sep 2019 20:51:35 +0000 (16:51 -0400)]
Docs: added another contributor

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 weeks agoLP#1843637 MARC View Display Issues
Terran McCanna [Mon, 16 Sep 2019 19:45:52 +0000 (15:45 -0400)]
LP#1843637 MARC View Display Issues

This fixes vertical alignment issues in the MARC View table
by removing the deprecated valign tags and moving the inline
CSS to the cat.css file. The text within each table cell should
now align to the top for better readability.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 weeks agoDocs: Adding contributors and employers; fixing formatting
Jane Sandberg [Wed, 25 Sep 2019 20:58:04 +0000 (13:58 -0700)]
Docs: Adding contributors and employers; fixing formatting

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoDocs: typo corrections and added dev funders
Andrea Buntz Neiman [Wed, 25 Sep 2019 20:22:42 +0000 (16:22 -0400)]
Docs: typo corrections and added dev funders

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
7 weeks agoDocs: rearranging 3.4 release notes
Jane Sandberg [Tue, 24 Sep 2019 20:17:52 +0000 (13:17 -0700)]
Docs: rearranging 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 weeks agoadded code formatting to text
Andrea Buntz Neiman [Tue, 24 Sep 2019 19:48:53 +0000 (15:48 -0400)]
added code formatting to text

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
7 weeks agoForward-port 3.3.4 upgrade script
Dan Wells [Thu, 19 Sep 2019 19:34:47 +0000 (15:34 -0400)]
Forward-port 3.3.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoupdate 3.4 release notes for security bugfixes
Galen Charlton [Thu, 19 Sep 2019 19:38:23 +0000 (15:38 -0400)]
update 3.4 release notes for security bugfixes

NOTE: This section can be removed for 3.4-rc.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoDocs: adding release notes for 3.3.4
Jane Sandberg [Wed, 18 Sep 2019 03:59:28 +0000 (20:59 -0700)]
Docs: adding release notes for 3.3.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoDocs: adding release notes for 3.2.9
Jane Sandberg [Wed, 18 Sep 2019 03:55:19 +0000 (20:55 -0700)]
Docs: adding release notes for 3.2.9

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoDocs: adding release notes for 3.1.15
Jane Sandberg [Wed, 18 Sep 2019 03:48:13 +0000 (20:48 -0700)]
Docs: adding release notes for 3.1.15

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1822630: fix sanitizing CGI params on place_hold_result
Jeff Davis [Mon, 10 Jun 2019 16:53:44 +0000 (09:53 -0700)]
LP#1822630: fix sanitizing CGI params on place_hold_result

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1822630: further sanitizing of CGI params when embedded in HTML
Jeff Davis [Mon, 1 Apr 2019 22:13:09 +0000 (15:13 -0700)]
LP#1822630: further sanitizing of CGI params when embedded in HTML

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1822630: sanitize user input before display on browse results
Jeff Davis [Mon, 1 Apr 2019 17:00:59 +0000 (10:00 -0700)]
LP#1822630: sanitize user input before display on browse results

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1559239: use rel="noopener" when opening external URLs in a new tab
Jeff Davis [Thu, 13 Sep 2018 18:58:48 +0000 (11:58 -0700)]
LP#1559239: use rel="noopener" when opening external URLs in a new tab

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1735847: Remove patron info from default Hold Transit Slip
blake [Fri, 1 Dec 2017 22:32:22 +0000 (16:32 -0600)]
LP1735847: Remove patron info from default Hold Transit Slip

Removes most patron information from the Hold Transit Slip
in both the web and XUL client default definitions.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
2 months agoDocs: Group similar release notes together
Remington Steed [Tue, 10 Sep 2019 13:21:09 +0000 (09:21 -0400)]
Docs: Group similar release notes together

This commit simply moves one release note to be near a group of similar
release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 months agoDocs: Make "staff catalog" titles consistent in 3.4 Rel Notes
Remington Steed [Tue, 10 Sep 2019 13:18:24 +0000 (09:18 -0400)]
Docs: Make "staff catalog" titles consistent in 3.4 Rel Notes

This commit tries to make the release note titles regarding the angular
staff client both consistent and more readable.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 months agoTranslation updates - po files
Galen Charlton [Mon, 9 Sep 2019 21:05:56 +0000 (17:05 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoTranslation updates - newpot
Galen Charlton [Mon, 9 Sep 2019 20:57:43 +0000 (16:57 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoprune RELEASE_NOTES_NEXT
Galen Charlton [Mon, 9 Sep 2019 20:50:57 +0000 (16:50 -0400)]
prune RELEASE_NOTES_NEXT

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agofirst rough pass at 3.4 release notes
Galen Charlton [Mon, 9 Sep 2019 20:49:51 +0000 (16:49 -0400)]
first rough pass at 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoEnsure "Reshelved" copies are still reshelving
Thomas Berezansky [Wed, 15 Oct 2014 15:32:58 +0000 (11:32 -0400)]
Ensure "Reshelved" copies are still reshelving

Rather than "were reshelving when the query started"

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
2 months agoLP#1817645: adjust live_t remoteauth checks
Galen Charlton [Mon, 9 Sep 2019 19:27:19 +0000 (15:27 -0400)]
LP#1817645: adjust live_t remoteauth checks

Version 6.07 or higher of LWP::Protocol::https is required to
avoid an issue where an SSL certificate check of localhost
cannot be bypassed. We could instead have chosen to install
that Perl module from CPAN rather than packages, but since there's
presently no non-test code that requires that bugfix, I've elected
not to bother installing that module from CPAN for now.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1817645: fix live perl test for basic auth API
Ben Shum [Sun, 8 Sep 2019 21:21:18 +0000 (17:21 -0400)]
LP#1817645: fix live perl test for basic auth API

The live perl test is failing because we are not passing all
the right parameters for ignoring the SSL certificate verification
checks. Pass another variable to see if this helps.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1817645: (follow-up) avoid hardcoding user ID in a live_t test
Galen Charlton [Mon, 9 Sep 2019 18:28:18 +0000 (14:28 -0400)]
LP#1817645: (follow-up) avoid hardcoding user ID in a live_t test

This patch is an alternative implementation of an idea from
Ben Shum to avoid assuming that a given username in Concerto
will always be associated with the same patron ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoDocs: cleaning up headings in 3.4 release notes
Jane Sandberg [Sun, 8 Sep 2019 15:58:59 +0000 (08:58 -0700)]
Docs: cleaning up headings in 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoLP#1817645: Fix pgtap tests
Ben Shum [Sat, 7 Sep 2019 16:26:14 +0000 (12:26 -0400)]
LP#1817645: Fix pgtap tests

There was a missing closing parenthesis on the pgtap tests from
this new feature.

Also, one of the comparisons had the wrong value matching and it
failed to pass. Inactive patrons return "not_found" rather than
"blocked" apparently.

Signed-off-by: Ben Shum <ben@evergreener.net>
2 months agoLP#1816475: Cleanup 950.data.seed-values.sql
Ben Shum [Sat, 7 Sep 2019 03:32:42 +0000 (23:32 -0400)]
LP#1816475: Cleanup 950.data.seed-values.sql

When this branch was committed, some old seed data snuck back into
the file from LP#1759343 cleanup commit (eee5c5948ca).  Remove the
extra code to prevent duplicate INSERT errors.

Signed-off-by: Ben Shum <ben@evergreener.net>
2 months agoLP#1068287: stamp database update
Galen Charlton [Fri, 6 Sep 2019 22:09:05 +0000 (18:09 -0400)]
LP#1068287: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1068287 UI tweak and renewal behavior
Jason Etheridge [Fri, 6 Sep 2019 03:51:46 +0000 (23:51 -0400)]
LP#1068287 UI tweak and renewal behavior

Skips the CREATE_PRECAT permission check when renewing pre-cataloged items.

Also disables all the elements except the Cancel button in the Pre-Cat dialog
when the user lacks the CREATE_PRECAT permission, and repositions the explanatory
text.

Also includes release notes.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1068287 - Add CREATE_PRECAT permission
Cesar Velez [Thu, 13 Dec 2018 23:13:39 +0000 (18:13 -0500)]
LP#1068287 - Add CREATE_PRECAT permission

Add this permission to prevent untrained/un-authorized
circ staff from creating pre-cat items due to mis-scanned
barcodes. Added to all profiles by default, so that staff
admins can pinpoint users who may not have it, i.e Volunteers, etc.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1823255: stamp database update
Galen Charlton [Fri, 6 Sep 2019 22:03:14 +0000 (18:03 -0400)]
LP#1823255: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1823255: optionally require ident_value
Mark Bucholtz [Mon, 1 Apr 2019 14:45:20 +0000 (07:45 -0700)]
LP#1823255: optionally require ident_value

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mark Bucholtz <mbucholtz@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLp 1811696: Add --rebuild-rmsr option to pingest.pl
Jason Stephenson [Wed, 3 Apr 2019 17:30:07 +0000 (13:30 -0400)]
Lp 1811696: Add --rebuild-rmsr option to pingest.pl

Add the option to rebuild the reporter.materialized_simple_record
table to the pingest.pl support script.

Add release notes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1841270: release notes
Jason Etheridge [Fri, 23 Aug 2019 19:48:41 +0000 (15:48 -0400)]
LP#1841270: release notes

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1841270: fix ITEM_NOT_HOLDABLE event description
Jason Etheridge [Wed, 14 Aug 2019 13:16:31 +0000 (09:16 -0400)]
LP#1841270: fix ITEM_NOT_HOLDABLE event description

The main functionality for this enhancment produces toast messages for success
and failure, and the description for this particular event when testing had me
double-taking :)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1841270: add Title Hold option in various places in staff client
Jason Etheridge [Fri, 19 Jul 2019 22:59:19 +0000 (18:59 -0400)]
LP#1841270: add Title Hold option in various places in staff client

* Adds a Title Hold option to certain invocations of Request Items
(Item Status, Copy Buckets, but not Holdings View)

* Switches count of items to count of titles when Title hold option
is selected

* Adds a checkbox for honoring the preferred notification settings
and default pickup library of the selected patron

* Adds a success/failure toast for Request Items

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLp 1799272: Option to Limit Hold Items in SIP2 msg 64 to Available
Jason Stephenson [Fri, 2 Nov 2018 13:03:07 +0000 (09:03 -0400)]
Lp 1799272: Option to Limit Hold Items in SIP2 msg 64 to Available

This commit adds an implementation option to the oils_sip.xml that,
when enabled, will limit the hold items list and hold items counts in
the patron information response (response 64) to only the holds
available for pickup by the patron.  When the setting is not enabled,
the full list of the patron's holds continues to be used.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1731021 SIP fine detail fee type additions
Bill Erickson [Mon, 13 May 2019 14:43:51 +0000 (10:43 -0400)]
LP1731021 SIP fine detail fee type additions

Adds support for specifying different fee types in the fine/fee response
based on the most recent billing type of each transaction.

Thanks to Jason Stephenson for the initial implementation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1731021 SIP Fine detail repairs / display fields
Bill Erickson [Wed, 10 Apr 2019 16:45:56 +0000 (12:45 -0400)]
LP1731021 SIP Fine detail repairs / display fields

Resolve commit issues with the second commit from the source branch
working/user/dpearl/LP1731021_fine_item_detail

Migrating circ title/author lookup to use metabib display fields instead
of MVR's.

Minor code refactoring.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1731021: Support fine detail enhancement to SIP.
Dan Pearl [Thu, 25 May 2017 18:10:01 +0000 (14:10 -0400)]
LP#1731021: Support fine detail enhancement to SIP.

The particular flavor of fine detail output is manufacturer dependent,
although 3m is popular, and the default.  To configure the selection,
modify the /openils/conf/oils_sip.xml file.

Testing: See the /openils/conf/oils_sip.xml file and test all supported
values for the av_format option.  You should also test the case where
the option is omitted, or a non-supported value.  I am not sure what
happens if you supply more than one option with same or different
values, but this is a non-supported degenerate case.

For each test value, ensure tha the fine item detail is the expected
format.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1444644: stamp database update
Galen Charlton [Fri, 6 Sep 2019 21:51:21 +0000 (17:51 -0400)]
LP#1444644: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1444644 Copy Import Development Work
Liam Whalen [Thu, 2 Oct 2014 02:17:34 +0000 (19:17 -0700)]
LP#1444644 Copy Import Development Work

Two new options for importing holdings have been added to MARC Batch
Import/Export:

1) Auto-overlay On-order Cataloguing Copies

This is similar to "Auto-overlay In-process Acquisitions Copies," but
for copies that were not created from an acquisitions workflow.
Holdings information in the incoming record will be used to overlay any
existing On Order copies for the matching record which belong to the
owning library defined in the Holdings Import Profile.  The Holdings
Import Profile is also used to match incoming to existing copies, if
possible; otherwise, On Order copies are overlaid in the order they were
created.  The call number will also be overlaid if the incoming record
provides one.

2) Use Org Unit Matching in Copy to Determine Best Match

When there are multiple potential matching records, this feature allows
the user to automatically select the record which has the most copies at
libraries near the importing library in the org tree.  That is, starting
at the importing library, it climbs the org tree, gradually expanding
the scope at which it checks for holdings on matching records; once
holdings are found, the record with the most holdings at that scope is
selected for overlay.  If there are no matching records with holdings,
then the default best match overlay is attempted.

Two new permissions are added to control the use of these new features.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1728331 - Action Trigger Aggregator Date Parameter
Josh Stompro [Wed, 27 Feb 2019 16:31:54 +0000 (10:31 -0600)]
LP#1728331 - Action Trigger Aggregator Date Parameter

- Added release notes.
- Added note about script to support scripts doc.
- Added script to makefile for confile processing and installation.
- Added processed version of the script to .gitignore

I tested out the script with our production data and it worked as described.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP1728331: A/T Aggregator Date Parameter
Jason Boyer [Tue, 20 Feb 2018 19:51:21 +0000 (14:51 -0500)]
LP1728331: A/T Aggregator Date Parameter

Adds a --date parameter to action_trigger_aggregator.pl
to make it simpler to pull events for a single day when
that day isn't "today."

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1786552: AuthProxy: release note for LDAP bind_user and restrict_by_home_ou
Jeff Davis [Fri, 21 Jun 2019 23:25:04 +0000 (16:25 -0700)]
LP#1786552: AuthProxy: release note for LDAP bind_user and restrict_by_home_ou

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1786552: AuthProxy: restrict_by_home_ou based on authenticator org_units
Jeff Davis [Thu, 20 Jun 2019 19:49:31 +0000 (12:49 -0700)]
LP#1786552: AuthProxy: restrict_by_home_ou based on authenticator org_units

It makes more sense to check the patron's home library against the org
units to which the authenticator applies, rather than the login org
param.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1786552: optionally restrict auth_proxy login by home OU
Jeff Davis [Fri, 8 Feb 2019 21:59:14 +0000 (13:59 -0800)]
LP#1786552: optionally restrict auth_proxy login by home OU

This adds a new restrict_by_home_ou setting to auth_proxy authenticator
config.  When enabled, if the login request includes an org param, the
authenticator will refuse to authenticate a user unless their home OU
matches or is a descendant of that org; login fails and auth_proxy
proceeds to the next configured authenticator.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1786552: LDAP bind user option
Jeff Davis [Wed, 17 Oct 2018 01:24:00 +0000 (18:24 -0700)]
LP#1786552: LDAP bind user option

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1793802: stamp database update
Galen Charlton [Fri, 6 Sep 2019 21:38:02 +0000 (17:38 -0400)]
LP#1793802: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1793802 - Add new aged/all billing/payment sources to aged/all circ sources.
Chris Sharp [Tue, 21 May 2019 10:53:53 +0000 (06:53 -0400)]
LP#1793802 - Add new aged/all billing/payment sources to aged/all circ sources.

The new aged/all billing/payment sources need to be included
in the aged/all circulations reporting sources.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1793802 Age circ ages payments before billings
Bill Erickson [Sat, 20 Oct 2018 12:11:46 +0000 (08:11 -0400)]
LP#1793802 Age circ ages payments before billings

When aging a circulation, payments must be deleted before billings,
since account_adjustements (payment) reference billings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1793802 Billing/payment purge improvements
Bill Erickson [Wed, 26 Sep 2018 21:22:11 +0000 (17:22 -0400)]
LP#1793802 Billing/payment purge improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agoLP#1793802 Aged billings/payments release notes
Bill Erickson [Fri, 21 Sep 2018 19:56:25 +0000 (15:56 -0400)]
LP#1793802 Aged billings/payments release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>