stop some strict warnings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@1700 dcc99617-32d9-48b4-a31d-7c20da2025e4

diff --git a/Evergreen/staff_client/chrome/content/evergreen/util/error.js b/Evergreen/staff_client/chrome/content/evergreen/util/error.js
index 25a6f23..a567137 100644 (file)
--- a/Evergreen/staff_client/chrome/content/evergreen/util/error.js
+++ b/Evergreen/staff_client/chrome/content/evergreen/util/error.js
@@ -103,7 +103,7 @@ function sdump(level,msg) {
        try {
                var now = new Date();
                var message = now.valueOf() + '\tdelta = ' + (now.valueOf() - sdump_last_time.valueOf()) + '\n' + level + '\n' + msg;
        try {
                var now = new Date();
                var message = now.valueOf() + '\tdelta = ' + (now.valueOf() - sdump_last_time.valueOf()) + '\n' + level + '\n' + msg;

-               if (sdump_levels['D_NONE']) return;
+               if (sdump_levels['D_NONE']) return null;

                if (sdump_levels[level]||sdump_levels['D_ALL']) {
                        sdump_last_time = now;
                        if (debugDump)
                if (sdump_levels[level]||sdump_levels['D_ALL']) {
                        sdump_last_time = now;
                        if (debugDump)

diff --git a/Evergreen/staff_client/chrome/content/evergreen/util/widgets.js b/Evergreen/staff_client/chrome/content/evergreen/util/widgets.js
index 376245d..7bb64f9 100644 (file)
--- a/Evergreen/staff_client/chrome/content/evergreen/util/widgets.js
+++ b/Evergreen/staff_client/chrome/content/evergreen/util/widgets.js
@@ -17,7 +17,7 @@ function append_treeitem() {
        if (typeof(e) != 'object') { throw('typeof e != object : typeof e = ' + typeof(e)); }
        var treechildren = e;
 
        if (typeof(e) != 'object') { throw('typeof e != object : typeof e = ' + typeof(e)); }
        var treechildren = e;
 

-       if (!treechildren) { sdump('D_WIDGETS','No ' + id + ' to append to\n'); return; }
+       if (!treechildren) { sdump('D_WIDGETS','No ' + id + ' to append to\n'); return null; }

 
        var treeitem = elem('treeitem'); treechildren.appendChild(treeitem);
        var treerow = elem('treerow'); treeitem.appendChild(treerow);
 
        var treeitem = elem('treeitem'); treechildren.appendChild(treeitem);
        var treerow = elem('treerow'); treeitem.appendChild(treerow);


@@ -115,7 +115,7 @@ function empty_listbox() {
                e = arguments[1];
                if (typeof(e) != 'object') { e = d.getElementById(e); }
        }
                e = arguments[1];
                if (typeof(e) != 'object') { e = d.getElementById(e); }
        }

-       if (typeof(e) != 'object') { sdump('D_WIDGETS','Failed on empty_listbox\n'); return; }
+       if (typeof(e) != 'object') { sdump('D_WIDGETS','Failed on empty_listbox\n'); return null; }

        var nl = e.getElementsByTagName('listitem');
        for (var i = 0; i < nl.length; i++) {
                e.removeChild(nl[i]);
        var nl = e.getElementsByTagName('listitem');
        for (var i = 0; i < nl.length; i++) {
                e.removeChild(nl[i]);


@@ -133,7 +133,7 @@ function empty_widget() {
                e = arguments[1];
                if (typeof(e) != 'object') { e = d.getElementById(e); }
        }
                e = arguments[1];
                if (typeof(e) != 'object') { e = d.getElementById(e); }
        }

-       if (typeof(e) != 'object') { sdump('D_WIDGETS','Failed on empty_widget\n'); return; }
+       if (typeof(e) != 'object') { sdump('D_WIDGETS','Failed on empty_widget\n'); return null; }

        while (e.lastChild) { e.removeChild(e.lastChild); }
 }
 
        while (e.lastChild) { e.removeChild(e.lastChild); }
 }
 


@@ -315,7 +315,7 @@ function incr_progressmeter() {
        if (typeof(meter)!='object') 
                meter = d.getElementById(meter);
        if (typeof(meter)!='object')
        if (typeof(meter)!='object') 
                meter = d.getElementById(meter);
        if (typeof(meter)!='object')

-               return;
+               return null;

 
        var real = meter.getAttribute('_real');
 
 
        var real = meter.getAttribute('_real');
 


@@ -449,7 +449,7 @@ function swap_attributes() {
                a2 = arguments[3];
                if (typeof(e) != 'object') { e = d.getElementById(e); }
        }
                a2 = arguments[3];
                if (typeof(e) != 'object') { e = d.getElementById(e); }
        }

-       if (typeof(e) != 'object') { sdump('D_WIDGETS','Failed on swap_attributes\n'); return; }
+       if (typeof(e) != 'object') { sdump('D_WIDGETS','Failed on swap_attributes\n'); return null; }

        var a1_v = e.getAttribute(a1);
        var a2_v = e.getAttribute(a2);
        e.setAttribute(a1,a2_v);
        var a1_v = e.getAttribute(a1);
        var a2_v = e.getAttribute(a2);
        e.setAttribute(a1,a2_v);


@@ -470,8 +470,8 @@ function toggle_hidden_grid_rows() {
        if (typeof(grid) != 'object') {
                grid = d.getElementById(grid);
        }
        if (typeof(grid) != 'object') {
                grid = d.getElementById(grid);
        }

-       if (!grid) { return; }
-       var rows = grid.lastChild; if (!rows) { return; }
+       if (!grid) { return null; }
+       var rows = grid.lastChild; if (!rows) { return null; }

        for (var r = 0; r < rows.childNodes.length; r++ ) {
                var row = rows.childNodes[r];
                if (typeof(row) == 'object') {
        for (var r = 0; r < rows.childNodes.length; r++ ) {
                var row = rows.childNodes[r];
                if (typeof(row) == 'object') {