LP#1541559: Use HTTPS for OverDrive requests

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/EbookAPI/OverDrive.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/EbookAPI/OverDrive.pm
index 6bb5be5..07df43e 100644 (file)
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/EbookAPI/OverDrive.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/EbookAPI/OverDrive.pm
@@ -103,9 +103,9 @@ sub initialize {
     my $ou = $self->{ou};
 
     my $discovery_base_uri = OpenILS::Application::AppUtils->ou_ancestor_setting_value($ou, 'ebook_api.overdrive.discovery_base_uri');
-    $self->{discovery_base_uri} = $discovery_base_uri || 'http://api.overdrive.com/v1';
+    $self->{discovery_base_uri} = $discovery_base_uri || 'https://api.overdrive.com/v1';
     my $circulation_base_uri = OpenILS::Application::AppUtils->ou_ancestor_setting_value($ou, 'ebook_api.overdrive.circulation_base_uri');
-    $self->{circulation_base_uri} = $circulation_base_uri || 'http://patron.api.overdrive.com/v1';
+    $self->{circulation_base_uri} = $circulation_base_uri || 'https://patron.api.overdrive.com/v1';
 
     my $account_id = OpenILS::Application::AppUtils->ou_ancestor_setting_value($ou, 'ebook_api.overdrive.account_id');
     if ($account_id) {

diff --git a/Open-ILS/src/sql/Pg/950.data.seed-values.sql b/Open-ILS/src/sql/Pg/950.data.seed-values.sql
index bdd70d7..a1f036d 100644 (file)
--- a/Open-ILS/src/sql/Pg/950.data.seed-values.sql
+++ b/Open-ILS/src/sql/Pg/950.data.seed-values.sql
@@ -16681,7 +16681,7 @@ VALUES (
     ),
     oils_i18n_gettext(
         'ebook_api.overdrive.discovery_base_uri',
-        'Base URI for OverDrive Discovery API (defaults to http://api.overdrive.com/v1)',
+        'Base URI for OverDrive Discovery API (defaults to https://api.overdrive.com/v1). Using HTTPS here is strongly encouraged.',
         'coust',
         'description'
     ),
@@ -16697,7 +16697,7 @@ VALUES (
     ),
     oils_i18n_gettext(
         'ebook_api.overdrive.circulation_base_uri',
-        'Base URI for OverDrive Circulation API (defaults to http://patron.api.overdrive.com/v1)',
+        'Base URI for OverDrive Circulation API (defaults to https://patron.api.overdrive.com/v1). Using HTTPS here is strongly encouraged.',
         'coust',
         'description'
     ),

diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.org-setting.ebook-api-overdrive.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.org-setting.ebook-api-overdrive.sql
index 7e10262..bbcf92c 100644 (file)
--- a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.org-setting.ebook-api-overdrive.sql
+++ b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.org-setting.ebook-api-overdrive.sql
@@ -17,7 +17,7 @@ VALUES (
     ),
     oils_i18n_gettext(
         'ebook_api.overdrive.discovery_base_uri',
-        'Base URI for OverDrive Discovery API (defaults to http://api.overdrive.com/v1)',
+        'Base URI for OverDrive Discovery API (defaults to https://api.overdrive.com/v1). Using HTTPS here is strongly encouraged.',
         'coust',
         'description'
     ),
@@ -33,7 +33,7 @@ VALUES (
     ),
     oils_i18n_gettext(
         'ebook_api.overdrive.circulation_base_uri',
-        'Base URI for OverDrive Circulation API (defaults to http://patron.api.overdrive.com/v1)',
+        'Base URI for OverDrive Circulation API (defaults to https://patron.api.overdrive.com/v1). Using HTTPS here is strongly encouraged.',
         'coust',
         'description'
     ),