]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1562153: fix case where changing sort order to relevance can fail
authorGalen Charlton <gmc@esilibrary.com>
Fri, 25 Mar 2016 20:46:24 +0000 (16:46 -0400)
committerMike Rylander <mrylander@gmail.com>
Thu, 28 Apr 2016 16:04:25 +0000 (12:04 -0400)
commite45c91d53f249b01dce43bf9224b891dfa304942
tree761a0b4b7ebef04035d6794d8d1979b21af20661
parent977f85bd0a48cd0954aac40103e7f7ec65da9437
LP#1562153: fix case where changing sort order to relevance can fail

This patch fixes a cause where sending a 'sort' CGI parameter
with the empty string as value (which specifies relevance sorting)
fails to override a previously-set sort order.

To test:

[1] Do a public catalog search starting from the advanced search form,
    e.g., keyword = "cats"
[2] Change the sort order to (say) Title A-Z from the results page.
[3] Note that the query string changes to "sort(titlesort) cats" and
    that the results are re-sorted
[4] Attempt to change the sort order to relevance.
[5] This time, the sort order does not change ... and it should have.
[6] Apply the patch and repeat steps 1-5. This time, the sort order
    should be successfully changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm