]> git.evergreen-ils.org Git - Evergreen.git/commit
Fix LP1180140, View Holds not working for a serial with subscription and no issuances
authorSteven Chan <schan@sitka.bclibraries.ca>
Wed, 15 May 2013 21:30:15 +0000 (14:30 -0700)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thu, 12 Dec 2013 21:43:03 +0000 (16:43 -0500)
commitd1258da72f97f1a46cc85e3ff0b88c74d0f797f6
treef4343f3774c49cdc8cb7477c87fd6bd28f66f673
parent46768f14f6a87833ad38ecdf80f37589abe687c3
Fix LP1180140, View Holds not working for a serial with subscription and no issuances

A request is made to
open-ils.circ.holds.retrieve_all_from_title,
which is the function Circ/Holds.pm/all_rec_holds().

In the function, when checking for issuance holds, there is a missing @
to dereference the list of issuance IDs, so that the ahr table is search
with badly formed input, which results in returning an undefined list
instead of an empty list.  The error will occur for any record with a
serial.subscription entry but with no related entries in
serial.issuance.

We also recode the initialization of the response object in order to
clarify its expected structure, a hash of array references.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm