]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1785061: move the filter value munging to the template service
authorGalen Charlton <gmc@equinoxinitiative.org>
Wed, 22 May 2019 15:12:37 +0000 (11:12 -0400)
committerDan Wells <dbw2@calvin.edu>
Wed, 14 Aug 2019 13:06:58 +0000 (09:06 -0400)
commitbf37b1e3efa16a2a67aa0902a42afc4616b23cf6
tree87c7787dbe25f4402e30504429495e5b5c9f482a
parenta31074eb5073086d54d8208c00b6958505ead30a
LP#1785061: move the filter value munging to the template service

This allows the reporter app to stay a bit more focused on
display concerns.

Here's a test plan for the patch series
---------------------------------------
[1] Create a reporter template that has a filter field
    and a filter operator of "In list", "Not in list", "Between",
    or "Not between" and hard-code a value for that filter
    in the template, separating values with a comma.
[2] Try to create a report from that template; note that it
    fails with an error.
[3] Apply the patch and repeat steps 1 and 2. This time, the
    report should succeed.

Note that this fix applies only to hardcoding filter values in the
template; it doesn't change any behavior when attempting to set
a filter value for any of the four operators above at the point of
creating a report.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/reporter/template/app.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Open-ILS/web/js/ui/default/staff/reporter/services/template.js
Open-ILS/web/js/ui/default/staff/reporter/template/app.js