]> git.evergreen-ils.org Git - Evergreen.git/commit
LP1824709: Allow comboboxes inputs to have IDs
authorJane Sandberg <sandbej@linnbenton.edu>
Thu, 17 Sep 2020 21:13:54 +0000 (14:13 -0700)
committerJane Sandberg <js7389@princeton.edu>
Fri, 4 Nov 2022 02:30:03 +0000 (19:30 -0700)
commit8c3317b94b6fae2e944201130a954a0fc3d01c12
tree407938e8d53e833fbe5122eedd0c766e800d3bcd
parent78093899b33f07e0f0882d65ef5966d2deee523c
LP1824709: Allow comboboxes inputs to have IDs

This adds a new input, domId, for the combobox component.

A good way to test:

1) Download the Wave accessibility checker.
2) Go to one of the following screens:
  - Admin > Local > Course Reserves > Choose a course > Associate
    item from catalog
  - Admin > Local > Course Reserves > Choose a course > Associate
    brief record
  - MARC Batch Import
  - MARC Batch Import/Export > Inspect Queue
  - Staff Catalog Add to bucket
  - Staff catalog conjoined items
  - Hold cancel dialog
3) Right click and select "WAVE this page"
4) On the Details tab of WAVE, notice that there are several "Missing
   form label" errors.
5) Apply this patch.
6) Run WAVE again; notice that the number of missing form label errors
   has decreased.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html
Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.html
Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
Open-ILS/src/eg2/src/app/staff/share/buckets/bucket-dialog.component.html
Open-ILS/src/eg2/src/app/staff/share/holdings/conjoined-items-dialog.component.html
Open-ILS/src/eg2/src/app/staff/share/holds/cancel-dialog.component.html
Open-ILS/src/eg2/src/app/staff/share/marc-edit/simplified-editor/simplified-editor.component.html