]> git.evergreen-ils.org Git - Evergreen.git/commit
LP1895660: Silence Perl Warnings
authorJason Boyer <JBoyer@equinoxinitiative.org>
Tue, 15 Sep 2020 12:50:26 +0000 (08:50 -0400)
committerGalen Charlton <gmc@equinoxOLI.org>
Fri, 14 May 2021 21:37:59 +0000 (17:37 -0400)
commit87f86d8404c1335765f89df25ad6af39af84f19c
tree49efebbba131ed303b09453ab5e95776f6c217ef
parent8c24c33bec5195f53358c3f29df133ad836bd006
LP1895660: Silence Perl Warnings

There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.

Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Booking.pm