]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1686194 Account for adjustments when generating fines
authorDan Wells <dbw2@calvin.edu>
Mon, 24 Apr 2017 18:29:04 +0000 (14:29 -0400)
committerGalen Charlton <gmc@equinoxinitiative.org>
Tue, 20 Jun 2017 14:05:25 +0000 (10:05 -0400)
commit7dddee8e2fc781f7f7860a990b5364cc5f50dffe
tree8628b2aeab98634e88bc3227c51f42d4dc721958
parent3c81ca661e615982562695b08c021645cb9ac204
LP#1686194 Account for adjustments when generating fines

Fine generation stops at a predetermined 'max fines' amount, but this
does not account for possible adjustments which lower the effective
fine amount.  This situation is common in cases where lost items are
returned, and the library wants to generate additional overdues upon
that event.

With this commit, fine generation will pull in any adjustments applied
to overdue fines, and use those to offset the current total fine when
checking for max fines.

Also includes test for this condition.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/perlmods/live_t/09-lp1198465_neg_balances.t
Open-ILS/tests/datasets/sql/neg_bal_custom_transactions.sql