]> git.evergreen-ils.org Git - Evergreen.git/commit
TPAC: Keep site() and depth() out of basic search box when widgets suffice
authorLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Tue, 8 May 2012 15:25:23 +0000 (11:25 -0400)
committerLebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Wed, 9 May 2012 18:49:03 +0000 (14:49 -0400)
commit3eeb80320ce04ba4e910cce828e28dfc8cd2fa94
treeb15052fda9b870c52b88b7940886c17de8396580
parentbd190b0b66baaeb669f042b90053732596771311
TPAC: Keep site() and depth() out of basic search box when widgets suffice

This is a short term but working solution to the problem described here:
https://bugs.launchpad.net/evergreen/+bug/986196

Now when you have a selection for site on the advanced search page, it
doesn't lead to redundant site() and depth() terms in your basic search
query box.

Item type selections and search class selections (keyword/author/etc)
can still lead to ugliness in the advanced search box, but that's
because in the advanced search page you get a multi-select widget for
item type and in a basic search page you only get a single-select
dropdown, so there's not a clean way to map your advanced page
selections to basic page selections.  Search classes are kind of the
same issue, since you have three dropdowns on the advanced search page
and one on the basic.

So the "bigger" problem is one that we will have to solve later, but for
the common case at least we don't get the extra site() and depth() for
now.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
Open-ILS/src/templates/opac/parts/searchbar.tt2