]> git.evergreen-ils.org Git - Evergreen.git/commit
LP#1379824 Make PermaCrud.js disconnect() actually disconnect
authorDan Wells <dbw2@calvin.edu>
Thu, 9 Oct 2014 21:32:42 +0000 (17:32 -0400)
committerBen Shum <bshum@biblio.org>
Fri, 10 Oct 2014 19:05:28 +0000 (15:05 -0400)
commit18ef1cef2adb0beffe1758690bc8afc8e1189917
treeffb9037808c5218bf976f6b730f64db33a8e8a24
parentcf421fe14298ab9eef46ecbd0cb67604460dec78
LP#1379824 Make PermaCrud.js disconnect() actually disconnect

The disconnect() method in PermaCrud.js was meant to wrap the
underlying session disconnect, but it never actually disconnected
the session.  This could lead to problems in long-living PermaCrud
objects, as they may think they are still connected when they are not
(the session remote_id is never cleared).

Also, remove a couple (now redundant) manual session.disconnect() calls.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Open-ILS/web/js/dojo/openils/PermaCrud.js